From patchwork Wed Aug 9 07:18:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Mogalapalli X-Patchwork-Id: 133115 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp2647583vqr; Wed, 9 Aug 2023 01:34:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH1DTxX6X6NPeZA2frhQMAf44NpMaIrCx8/pX2TcXJhMbxZoNgqoH8PhtPF53Oxpy9gmv+0 X-Received: by 2002:a05:6358:99a6:b0:133:4ce:4e8c with SMTP id j38-20020a05635899a600b0013304ce4e8cmr1931376rwb.29.1691570059433; Wed, 09 Aug 2023 01:34:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691570059; cv=none; d=google.com; s=arc-20160816; b=Ea0fgFTLFaaDCrPqrtN3krnaTT30uuf33ohDm1ZlwDoXDI5REFxvmk+ZTqvFU3c3uP hHNsVmRHgmevudslFK1MrARGosaF+8TVNHL1SFlLYf+2eZpaLo9Nl6aNgLE5rF5fvEXP yUqzpTaVKFJsQFwMQKDdr6MCEYqMC7hSKwAjpsEG7lUuiL6EJRTFuzIvm3scp8vIs77W /gjsdZtlYCeFcVzjieFus/K5ghpoFeIDrukljxwCLaiFsdSZXeVM4tB0q41pu3kVMj62 17Y53Tia7llAzTYQnMz9xHD0HwNDFo4bNXOaVCt8y2Hp5NBE5WVafF+Rl85IQMibnfvc vd5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=VeqHu8sZLiFLMdgcIzTyJGviQjbnz6KSyK1BX8Dx/so=; fh=eysOZudm7PYHoOehoz9R37VXoYu8Zt9VkBv4uTtyjg0=; b=irOh3XNAQd4+H/gBsLvgSmf+Ohm+93sBj6dmZ5X7zkm1UK4LukUHijEJs+DNiU+kOn rbU2nGh1eVYRLc3sduwSTV3EpHyxfl/jPR0iMb4uadYAWMCVMiUXmy0nHuykc0993miT Q2m3U5xpOulP/W+EzGsxfs0Zd30CmpvHwwwpkxjsjW3p/7+wr9pBkIX0cAKdsFI6z+Z3 IDF9gRx+3BEDiBMXfJlfasX6/xQkMpVJtT/3IMj74ORAuu6dJ7JivXJTkaxRjawzDmEL zpfJ78ow6YISs7oBfEUqlJ3yUvTx1+U0AkIUDT7jVfHZyxpQewuRAmUrhHFRrfIM/Ne3 UHIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-03-30 header.b=axMTGxNb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f22-20020a631016000000b005641315d956si8920553pgl.147.2023.08.09.01.34.06; Wed, 09 Aug 2023 01:34:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-03-30 header.b=axMTGxNb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231604AbjHIHSx (ORCPT + 99 others); Wed, 9 Aug 2023 03:18:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230120AbjHIHSw (ORCPT ); Wed, 9 Aug 2023 03:18:52 -0400 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 178521BCF; Wed, 9 Aug 2023 00:18:51 -0700 (PDT) Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3794P8lg031848; Wed, 9 Aug 2023 07:18:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=corp-2023-03-30; bh=VeqHu8sZLiFLMdgcIzTyJGviQjbnz6KSyK1BX8Dx/so=; b=axMTGxNbrEYaOA3AbIdPsi/HpthnEtTzF2oztQlq6bJcss9pVj+bz1rP/WwncE5bRMrj nE31YtIOal1OPFeYvvEN6ipgQ3N6dqo+QuYPxKYG5Lz1pZVHIlfels84KIuzIqtDrDKH ltHy+72o4EGoQzBwb2FFNR8kEf9dgeAVajkNLZJUYIRJ7H1s9+Xxr84yOXB+qNCDcpd4 WwwQCzm5+NHtAhFoXId2hTxGeb/tPcmzO3Ps1hKRN6+vkQupOaviAdFlVVDlnGTd/c34 mZcNs9Jl9+m+n6u/BVKpucAUpwYMHWvSRblNlFHUWRFmaNViLM11ac/p6i51XY3uMKdd 6w== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3s9dbc8408-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Aug 2023 07:18:41 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3795jmFR021400; Wed, 9 Aug 2023 07:18:40 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3s9cvdn0pf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Aug 2023 07:18:40 +0000 Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3797Idt4039843; Wed, 9 Aug 2023 07:18:39 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 3s9cvdn0nx-1; Wed, 09 Aug 2023 07:18:39 +0000 From: Harshit Mogalapalli To: tonyhuang.sunplus@gmail.com, lhjeff911@gmail.com, ulf.hansson@linaro.org, dan.carpenter@linaro.org Cc: arnd@arndb.de, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, error27@gmail.com, harshit.m.mogalapalli@oracle.com, kernel-janitors@vger.kernel.org Subject: [PATCH next v2 1/2] mmc: sunplus: Fix error handling in spmmc_drv_probe() Date: Wed, 9 Aug 2023 00:18:11 -0700 Message-ID: <20230809071812.547229-1-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-09_05,2023-08-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 spamscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308090063 X-Proofpoint-ORIG-GUID: mfotAyxPi_3bhWNPosR6a7WJtMs5yKid X-Proofpoint-GUID: mfotAyxPi_3bhWNPosR6a7WJtMs5yKid X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773737698417642939 X-GMAIL-MSGID: 1773739766686808153 When mmc allocation succeeds, the error paths are not freeing mmc. Fix the above issue by changing mmc_alloc_host() to devm_mmc_alloc_host() to simplify the error handling. Remove label 'probe_free_host' as devm_* api takes care of freeing, also remove mmc_free_host() from remove function as devm_* takes care of freeing. Fixes: 4e268fed8b18 ("mmc: Add mmc driver for Sunplus SP7021") Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/a3829ed3-d827-4b9d-827e-9cc24a3ec3bc@moroto.mountain/ Signed-off-by: Harshit Mogalapalli --- This is based on static analysis with smatch, only compile tested. v1->v2: Simplify code by using devm_mmc_alloc_host() instead of mmc_alloc_host() (Ulf Hansson's suggestion) --- drivers/mmc/host/sunplus-mmc.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/mmc/host/sunplus-mmc.c b/drivers/mmc/host/sunplus-mmc.c index a55a87f64d2a..2bdebeb1f8e4 100644 --- a/drivers/mmc/host/sunplus-mmc.c +++ b/drivers/mmc/host/sunplus-mmc.c @@ -863,11 +863,9 @@ static int spmmc_drv_probe(struct platform_device *pdev) struct spmmc_host *host; int ret = 0; - mmc = mmc_alloc_host(sizeof(*host), &pdev->dev); - if (!mmc) { - ret = -ENOMEM; - goto probe_free_host; - } + mmc = devm_mmc_alloc_host(&pdev->dev, sizeof(struct spmmc_host)); + if (!mmc) + return -ENOMEM; host = mmc_priv(mmc); host->mmc = mmc; @@ -938,11 +936,6 @@ static int spmmc_drv_probe(struct platform_device *pdev) clk_disable: clk_disable_unprepare(host->clk); - -probe_free_host: - if (mmc) - mmc_free_host(mmc); - return ret; } @@ -956,7 +949,6 @@ static int spmmc_drv_remove(struct platform_device *dev) pm_runtime_put_noidle(&dev->dev); pm_runtime_disable(&dev->dev); platform_set_drvdata(dev, NULL); - mmc_free_host(host->mmc); return 0; } From patchwork Wed Aug 9 07:18:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Mogalapalli X-Patchwork-Id: 133084 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp2621766vqr; Wed, 9 Aug 2023 00:29:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHTrJD3y+cHbTiwpASfOgxoBjXdbVfBXqJ8AhsHP4moMi2ZsDiD0phzWPklk3vFYVn4KyQm X-Received: by 2002:a05:6402:38e:b0:522:21a1:5153 with SMTP id o14-20020a056402038e00b0052221a15153mr1633158edv.11.1691566142042; Wed, 09 Aug 2023 00:29:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691566142; cv=none; d=google.com; s=arc-20160816; b=zfKwMnOST3p188BtbqY1IO/tqiG1XNp6VdODQp31OA7+g9u9jApQ8lOo+dlIpVN4tw 7bei+BLD1tD67pXda3KNckwISA2PHK9ueegsuv13gxR/siOrPKnxqT9FFaYixAdb1mlK f1WIrava1ANWY0la9gP1gTVnKX5PDS+Rm9GphhXXBlrZJpvw/mT0ldmQiHX3ekQrV4Fg FrXhw/sq3rY1aN+GJKTIefApeEdxzV/V055gsSIK1sPHO/2xkZAhRsOWB8DP8Zy2Mimm 4OIKMkWA5S9/DVxBvZA3Ig+0JcFsdyt3XK7qafk2+qJ4ewL1W+HAUj6nxWngCtcXptwG PTgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xyjIwviWQ1Y4Ul0E3eBRLFREfmmQQQHeusPVsYsC+rY=; fh=eysOZudm7PYHoOehoz9R37VXoYu8Zt9VkBv4uTtyjg0=; b=EveyGgYNLOusqlH3YKxhhCfglQkdzbBPRupqQm22KvbPLX6lVz+31UFUnIe7Vt5Lij lm4ex6tymV/sZ6zsRjr1Bt09Odb/79D+DKHSytgDTwqkoo/nQYye1j+2Tx1E4ykrbtz6 RZsxILbdXxUqltW38hGz56JBwNfZjMk1y1PVw0aC20WiV+WjCQW7T/l8TbZNpjm9eeNG GEYxHSRYUfvaOV7KtF0iymCr+FhVVkegxl9HI2M1xOnVHzN4AHb72gHn/JvBLd80jKTB tteeC1jGcDyEm2rnx1jwdZvX0KHwx2jmWFswPfHVJXgdvq68MvOyCSxwQHBiSf07DKk6 x7Kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-03-30 header.b=EmABS84C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u23-20020aa7d0d7000000b0051debd3e95asi7975637edo.146.2023.08.09.00.28.37; Wed, 09 Aug 2023 00:29:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-03-30 header.b=EmABS84C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231617AbjHIHTG (ORCPT + 99 others); Wed, 9 Aug 2023 03:19:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231620AbjHIHTE (ORCPT ); Wed, 9 Aug 2023 03:19:04 -0400 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04D101FD0; Wed, 9 Aug 2023 00:19:04 -0700 (PDT) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3796qtmn027037; Wed, 9 Aug 2023 07:18:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=corp-2023-03-30; bh=xyjIwviWQ1Y4Ul0E3eBRLFREfmmQQQHeusPVsYsC+rY=; b=EmABS84CdywCzOfltQJQv96L4iiUSlvwKYV9y7rXoYdpSotnFTr+hLpQCeSaXe04E7Jw KbMZamfR0FuJ6bQ/GM6sXIwv8TINi0wD/io46pVBWCNFs/emvGvlW80KX1J679L42vJk ywvEevL6AyR37bTRTnhRkN/sY81JfZo2nyV4RldbhAEziabGMyf5Ik9YX1PpIVSKt/T+ JcmOWJ+TUZjF8N3T99ooQV9Kg6hwvtNxllbSdJcb0oG8+hS9NXzR+wqZIlvtHcmHrkGs /t12wdqJJ8uGFaBlVxYbG8c4MZsct//E5oonLvgEKIQS451UgpsyVBQI9pyIremOOcR1 IA== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3s9eaar1er-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Aug 2023 07:18:54 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3795wulp022167; Wed, 9 Aug 2023 07:18:53 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3s9cvdn12w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Aug 2023 07:18:53 +0000 Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3797Idt6039843; Wed, 9 Aug 2023 07:18:53 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 3s9cvdn0nx-2; Wed, 09 Aug 2023 07:18:53 +0000 From: Harshit Mogalapalli To: tonyhuang.sunplus@gmail.com, lhjeff911@gmail.com, ulf.hansson@linaro.org, dan.carpenter@linaro.org Cc: arnd@arndb.de, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, error27@gmail.com, harshit.m.mogalapalli@oracle.com, kernel-janitors@vger.kernel.org Subject: [PATCH next v2 2/2] mmc: sunplus: Fix platform_get_irq() error checking Date: Wed, 9 Aug 2023 00:18:12 -0700 Message-ID: <20230809071812.547229-2-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230809071812.547229-1-harshit.m.mogalapalli@oracle.com> References: <20230809071812.547229-1-harshit.m.mogalapalli@oracle.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-09_05,2023-08-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 spamscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308090063 X-Proofpoint-ORIG-GUID: QIuaasK0VBi-D7t0kNkI7SdqIIbhabU7 X-Proofpoint-GUID: QIuaasK0VBi-D7t0kNkI7SdqIIbhabU7 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773735659385767124 X-GMAIL-MSGID: 1773735659385767124 The platform_get_irq() function returns negative error codes on failure. Fixes: 4e268fed8b18 ("mmc: Add mmc driver for Sunplus SP7021") Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/a3829ed3-d827-4b9d-827e-9cc24a3ec3bc@moroto.mountain/ Signed-off-by: Harshit Mogalapalli --- v1->v2: Split into two patches as they are doing different things. This is based on static analysis with smatch, only compile tested. --- drivers/mmc/host/sunplus-mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sunplus-mmc.c b/drivers/mmc/host/sunplus-mmc.c index 2bdebeb1f8e4..e9cb1a57cb75 100644 --- a/drivers/mmc/host/sunplus-mmc.c +++ b/drivers/mmc/host/sunplus-mmc.c @@ -885,7 +885,7 @@ static int spmmc_drv_probe(struct platform_device *pdev) return dev_err_probe(&pdev->dev, PTR_ERR(host->rstc), "rst get fail\n"); host->irq = platform_get_irq(pdev, 0); - if (host->irq <= 0) + if (host->irq < 0) return host->irq; ret = devm_request_threaded_irq(&pdev->dev, host->irq,