From patchwork Mon Aug 7 09:30:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 131767 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp1330806vqr; Mon, 7 Aug 2023 02:38:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFnhbe5R2nW3Axx974ChVusl1lmYwSi3iw4Eshpa4pXMrCRGXY5zXOYXxJhh/H5clDKVhps X-Received: by 2002:a17:906:53ce:b0:99c:7300:94b8 with SMTP id p14-20020a17090653ce00b0099c730094b8mr6749536ejo.10.1691401097626; Mon, 07 Aug 2023 02:38:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691401097; cv=none; d=google.com; s=arc-20160816; b=U8wMHM85ozbhaW2EVXYEX6KXDNHAfIo/welpXIrNuKeH3PCEjsQWNKhXISEUbKZxTV VABmKO/WpY/Uba7xscJL5HFa5lBM2UeCtY7F/GOMP8Mi0Fy5V2L6xSDSrmqmFAgI+jHD rg8GzY2rdIlFegN7lSMdzfxOzJdYqg/KNl34bO7eft4vwLio4tZLZtzrw9CuVIBI9wnC PTUW9yvc0wQp8SU0O13dn613On1/pL41XZ8k4hYe5oL4TuspVe0nspytSkCkd173LDl+ Bvb7NmeOA5+xZk3LTHdsQj86sRXhBGnG6fWwQf4O6g3v7ndP5zYHmNNnN/6Ltjbb20Yd AnXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=n123o8yW0UC4r/Oiw8lJSyqoS6ioNCVBJf2HFxUMh+A=; fh=BnHmLoAsuittPlboDXVahhauR+sXkoEO/Su0wRDVxEg=; b=pNri/9FnYXNNVowBwB8BKkZjDUHRnNGxbLOX9SMZER7L4+2VseFhXlfwbJKEpWhQB4 CLy+omGjilww6/7ctmWPaAUBm8Ey+otqCC1j0QLGO0mi28LMhiGrMXE62No+bQemYd0Q kSWcoDNvxPdGnlxgLwEntQkXvPflXfj4JrJhlyarWCmxQ+81IGKR6BWFzUY4chBVnDv7 H7vxSPDG+uOX473Nqj5ScXpoL4BW/PbiNAAiNya3emWg4Dhvdzr9hFYKmZhZTKI8BzLq rp3lX/xzKUJDMbXD+oV3ph2wDZm0axDvqsyMqI2TsrRoc4SVacjgfWPyiD6guU6JoPRV VBjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i5-20020a1709061cc500b0099bd667fcf1si1990175ejh.776.2023.08.07.02.37.54; Mon, 07 Aug 2023 02:38:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231142AbjHGJat (ORCPT + 99 others); Mon, 7 Aug 2023 05:30:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230523AbjHGJar (ORCPT ); Mon, 7 Aug 2023 05:30:47 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03CC8E7B for ; Mon, 7 Aug 2023 02:30:43 -0700 (PDT) Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RK9xF0DTWzVkCc; Mon, 7 Aug 2023 17:28:49 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 7 Aug 2023 17:30:40 +0800 From: Ruan Jinjie To: , Arnd Bergmann , Greg Kroah-Hartman CC: Subject: [PATCH -next v2 RESEND] misc: tps6594: Remove redundant dev_err_probe() for platform_get_irq_byname() Date: Mon, 7 Aug 2023 17:30:10 +0800 Message-ID: <20230807093010.2112302-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773562597036430915 X-GMAIL-MSGID: 1773562597036430915 There is no need to call the dev_err_probe() function directly to print a custom message when handling an error from platform_get_irq_byname() function as it is going to display an appropriate error message in case of a failure. Signed-off-by: Ruan Jinjie --- v2: - Update the commit title. --- drivers/misc/tps6594-esm.c | 3 +-- drivers/misc/tps6594-pfsm.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/misc/tps6594-esm.c b/drivers/misc/tps6594-esm.c index 68cc235181cc..b4d67a1a24e4 100644 --- a/drivers/misc/tps6594-esm.c +++ b/drivers/misc/tps6594-esm.c @@ -56,8 +56,7 @@ static int tps6594_esm_probe(struct platform_device *pdev) for (i = 0; i < pdev->num_resources; i++) { irq = platform_get_irq_byname(pdev, pdev->resource[i].name); if (irq < 0) - return dev_err_probe(dev, irq, "Failed to get %s irq\n", - pdev->resource[i].name); + return irq; ret = devm_request_threaded_irq(dev, irq, NULL, tps6594_esm_isr, IRQF_ONESHOT, diff --git a/drivers/misc/tps6594-pfsm.c b/drivers/misc/tps6594-pfsm.c index 0e24f8daaa9a..88dcac814892 100644 --- a/drivers/misc/tps6594-pfsm.c +++ b/drivers/misc/tps6594-pfsm.c @@ -266,8 +266,7 @@ static int tps6594_pfsm_probe(struct platform_device *pdev) for (i = 0 ; i < pdev->num_resources ; i++) { irq = platform_get_irq_byname(pdev, pdev->resource[i].name); if (irq < 0) - return dev_err_probe(dev, irq, "Failed to get %s irq\n", - pdev->resource[i].name); + return irq; ret = devm_request_threaded_irq(dev, irq, NULL, tps6594_pfsm_isr, IRQF_ONESHOT,