From patchwork Mon Aug 7 00:04:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 131634 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp1154723vqr; Sun, 6 Aug 2023 17:43:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEmpS0iAYcbQap6wNQEdOML8QbvV/rNYmKQRoZQhVp2FiH0JmQF8pUzAsexV6wynR/HDVv7 X-Received: by 2002:a17:907:2ccc:b0:994:1eb4:6896 with SMTP id hg12-20020a1709072ccc00b009941eb46896mr6376430ejc.25.1691369026254; Sun, 06 Aug 2023 17:43:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691369026; cv=none; d=google.com; s=arc-20160816; b=LMWMI1aK6XYv+DlLFi4GsjYHkdisj3+koXLVDk+e+F0ZswDWClc85YoZqBooYrQuDc TSSRulODlr9Fvkq/RkfhZEd7buEhRnzb3f/+OaB2p4F9pkk0rkCKtgrzDCkaxYWPwZ40 s0ft4qln/igxH5GyxsvUgJUsOcxKH4lVkmphbRTT6Re2QEUBmCyzNVCcvC4SNDgbbyfX Vtcbe/+t2U1T434A73FpyyfCLSfDnAWmlWfAb4Q3RZdmcocnzgRpRglKWs+LlrJXFctI SpuG8FdhGgHZQ5Hpiq1o35bg82nfprKPx3/IQXOOKwcE+jq2dLk+zxqqpFKDJ8y5YJfN 6kOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=4T8zEIJJrZJkkRGXZNKDlizg2PWGhxjAWQvXBdZHEqE=; fh=dO/e/wed5j8qjEsc8CQeFUhVtYCxUjxHlA7b7fgI4Fs=; b=TCi6QlDudn96ix2bIRA8RrZX/v7VSAKwjU0AOpXlrZZ/Jx4kiDGUcoY/jSa3YVEerA HkhVjzGPmjiOGSuOG0Y+7ccvMlhqA9dF5SZ6C4uQzvsvAMF+BbqpE9TKQQXPzKzzEXox pvV6gZF9KX4DYJfPmgBbxtQQY/Xoo18ZcxtMsU1x5INCKt73oelECLjNIIQjRt6MaCYP hyeAKDIMUrdpHxEgUxOxKx/rswaGgHpGZ/lGsPU3U7LVPWBenfRzrlh1SKBx7uPC1vXz E68TSRC0ySD5GJT0yYdUoBqtAheiZPw9XuiGKuUmjx/2TB+0rRN311MW2P6GEcVAemu9 Bjtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=HRStPPOm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qq4-20020a17090720c400b0099396546ffesi5017673ejb.768.2023.08.06.17.43.23; Sun, 06 Aug 2023 17:43:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=HRStPPOm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229491AbjHGAFI (ORCPT + 99 others); Sun, 6 Aug 2023 20:05:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjHGAFH (ORCPT ); Sun, 6 Aug 2023 20:05:07 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1AB7FA for ; Sun, 6 Aug 2023 17:05:06 -0700 (PDT) Received: from workpc.. (109-252-150-127.dynamic.spd-mgts.ru [109.252.150.127]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id 7D27A660711A; Mon, 7 Aug 2023 01:05:03 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1691366704; bh=zxAsuZOqI5T9dSHzdfn9q25oiwiUf0oORASmCnorRKs=; h=From:To:Cc:Subject:Date:From; b=HRStPPOmPmcRYmy16V3Yif2MhylntUx0MSOU6dqy4iQJmQV9cpyKvwMkwidvbDDkB REo4Ju0loyZlofyAUGCjWxPvnu+hOxVmeYeQql5EiMLKuDJMFSlU6lG5snEKk0/HXb bi5WlKrP+NLd6c6/RHTn1amblRyBof4IFcXAS/wZWiOmu3KjXNH5yxwlUXkgcVMnIv 0CAdrsmWGfNIak6gwiIieA4mvsvZg+Dr3iURPvaUBkmLZy6ybyqYjMNQyH3SdAXzJC mTqI+FEiR1NI1DLgoZnLMm8TxqZozMPTDd8APBphlINNeU8qIuCLfzRMQ7iL+VdX5v 8bMouR/Y1szQQ== From: Dmitry Osipenko To: AngeloGioacchino Del Regno , Rob Herring , Steven Price , Boris Brezillon Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: [PATCH v4] drm/panfrost: Sync IRQ by job's timeout handler Date: Mon, 7 Aug 2023 03:04:44 +0300 Message-ID: <20230807000444.14926-1-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773528968261235754 X-GMAIL-MSGID: 1773528968261235754 Panfrost IRQ handler may stuck for a long time, for example this happens when there is a bad HDMI connection and HDMI handler takes a long time to finish processing, holding Panfrost. Make Panfrost's job timeout handler to sync IRQ before checking fence signal status in order to prevent spurious job timeouts due to a slow IRQ processing. Reviewed-by: Steven Price Reviewed-by: Boris Brezillon Reviewed-by: AngeloGioacchino Del Regno Tested-by: AngeloGioacchino Del Regno # MediaTek MT8192 and MT8195 Chromebooks Signed-off-by: Dmitry Osipenko --- Changelog: v4: - Improved comment like was suggested by Boris and added his r-b. v3: - Added comment to the code as was suggested by Boris - Added r-b/t-b from Steven and Angelo v2: - Moved synchronize_irq() after first signal-check to avoid unnecessary blocking on syncing. - Added warn message about high interrupt latency. drivers/gpu/drm/panfrost/panfrost_job.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c index dbc597ab46fb..db6d9a17004f 100644 --- a/drivers/gpu/drm/panfrost/panfrost_job.c +++ b/drivers/gpu/drm/panfrost/panfrost_job.c @@ -720,6 +720,22 @@ static enum drm_gpu_sched_stat panfrost_job_timedout(struct drm_sched_job if (dma_fence_is_signaled(job->done_fence)) return DRM_GPU_SCHED_STAT_NOMINAL; + /* + * Panfrost IRQ handler may take a long time to process an interrupt + * if there is another IRQ handler hogging the processing. + * For example, the HDMI encoder driver might be stuck in the IRQ + * handler for a significant time in a case of bad cable connection. + * In order to catch such cases and not report spurious Panfrost + * job timeouts, synchronize the IRQ handler and re-check the fence + * status. + */ + synchronize_irq(pfdev->js->irq); + + if (dma_fence_is_signaled(job->done_fence)) { + dev_warn(pfdev->dev, "unexpectedly high interrupt latency\n"); + return DRM_GPU_SCHED_STAT_NOMINAL; + } + dev_err(pfdev->dev, "gpu sched timeout, js=%d, config=0x%x, status=0x%x, head=0x%x, tail=0x%x, sched_job=%p", js, job_read(pfdev, JS_CONFIG(js)),