From patchwork Sun Aug 6 09:20:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 131570 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp848373vqr; Sun, 6 Aug 2023 02:58:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHJIfPKFp1ojZ4fYLxmOeb7kgixrP4etMDHVu7fIOsUJ1AaJgYixJ1lmy7ly4K7f3iEEidC X-Received: by 2002:a17:907:770b:b0:99b:605b:1f49 with SMTP id kw11-20020a170907770b00b0099b605b1f49mr5711221ejc.36.1691315910093; Sun, 06 Aug 2023 02:58:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691315910; cv=none; d=google.com; s=arc-20160816; b=isuXSE7haGgjpvnPGNDT+oeeTsJETkqlUdGr0VxHW4sT1u919PEoQ7tq/TgSECjJ6u ndNnx3KSLVgGpe+z7woexTmI/spPHpvWL3F+Ti1yH6pdDXPo/0x7JBiXQ8nFY8ZS/x2A ZQ/wuRUJPjifJZIn1HUCSfCPDzWllb7/7nAOuIu8U/H0dqNPEQRXj8aEytIs2lsjLkqM As5H7MFaqKyJkbtQINwA6PMtrVMKYoyPAYuoU67bsPzeM+Qy9Wzm2kC+n03wDduTEtXQ hPYWbsnfSwelZKbZXsjfxoWP/z36gNbjJV3xDdYOrWQ/vXMWKqLA9rvnCwEDpdqcOdU6 VfgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=pdz+YJROiQvcrik7pbVgrSQWWKWInFaTdpoef+sMGGU=; fh=9LhevukQlN8QgABBNKHWl1nBtSwK1vKoyAVqIrNCnSI=; b=BSwYoF7UPxdIpznskU8OTqBdSI3ZRS2KdXPhnFvkRGZ0QaNmrD6nmsb5vYrDbzMqWq tPC9WtjlSHfDETaG70RMq38vcuStQODz7bCHf5+DhP2ml+63K/esY3weoGQuMoIJrIaz agxK1b3JadF7nF/8i7k/YuYVK/DCmuzVmsM1sUwTrZF86fhmBeRFYzc9yjb3k/Pik/e+ uQv1bsfilcxOzBduUgASeqwCdarkoOgR2rI1DgN+0rXzi+gqlAi69+Cj8Vr1pvjsgV2p ibwU6TubF0pseYbqVhEQpaf3uWfRtifFuM7dPrqlnrqyZaOKQMNXHzZd6gRLekKcXc3a NpeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uVrbbOOc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jr9-20020a170906a98900b0099bdfd4cc50si4563918ejb.830.2023.08.06.02.58.06; Sun, 06 Aug 2023 02:58:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uVrbbOOc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230177AbjHFJco (ORCPT + 99 others); Sun, 6 Aug 2023 05:32:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230159AbjHFJcl (ORCPT ); Sun, 6 Aug 2023 05:32:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F059F3; Sun, 6 Aug 2023 02:32:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7B8B060FFF; Sun, 6 Aug 2023 09:32:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E103C433CA; Sun, 6 Aug 2023 09:32:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691314358; bh=DXeugDAACdhg9l7C34Qgdlwo7dhx5GjmUFqTsipeB0Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uVrbbOOcZGFF+EtxOnb9SfVeKmKrNXmA8pibv3fg5Z3hyc9Na7dG+RyOc53gKPp4c GvxkzrQuGSef/o6c8X8Owq6H/EYLh/39iq3oNfFMdy2OpSHF0ZkhXZ7RjvjA+ll8CN SG/QEXAdL9TQ+GqMo0nKrahCy60542cWlSIcvGHx65XoWuHDVEXptBEABaWg9vGf/I EMpNaZB9E1sa60Tkyzho8artbV7shsTOm5YyjhUxMvD3Y0ulJVQHTzEET+2Wco6bJP zjymIqMReAu1zCYaTvvljKVmrVYfSDQjDTquO3Nx9sPG+cudFchNEbdx5V60QzImjV OCdMF4euPk1sA== From: Jisheng Zhang To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Andy Shevchenko , Jiri Slaby Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] dt-bindings: serial: snps-dw-apb-uart: make interrupt optional Date: Sun, 6 Aug 2023 17:20:55 +0800 Message-Id: <20230806092056.2467-2-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230806092056.2467-1-jszhang@kernel.org> References: <20230806092056.2467-1-jszhang@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773473271460048765 X-GMAIL-MSGID: 1773473271460048765 The driver fall back to poll style when there's no irq. "poll" still looks better than no support. Signed-off-by: Jisheng Zhang --- Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml index 3862411c77b5..17c553123f96 100644 --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml @@ -117,7 +117,6 @@ properties: required: - compatible - reg - - interrupts unevaluatedProperties: false From patchwork Sun Aug 6 09:20:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 131569 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp847673vqr; Sun, 6 Aug 2023 02:55:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFKKCCxmMqHE9hgQpXMtyOb0wgC59D0bZAPld6hFA8RoQfc3Jv/9nRl9tu7fFBl+tcaZ2HQ X-Received: by 2002:a17:907:781a:b0:99b:c952:309b with SMTP id la26-20020a170907781a00b0099bc952309bmr5829660ejc.55.1691315736270; Sun, 06 Aug 2023 02:55:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691315736; cv=none; d=google.com; s=arc-20160816; b=A+LbVJDGtB5j4zeY12CpeB4bH6WdM7zLRcnz0Z55NXomgEDr+IEtBpRdSSBz+qBt5d PP9cdEQyy0EFGyCj9GYJoR0Js4wDHgXgh7wCR2ysoNd10ZsfjlqwSWujoiBaWVjXLOPh T7bZdQE3fN2Roif+bP73nEGynwKsOhuBqvrMmRxBR/O1GLuy8Q2+S6X8ldGznEu6vxmT XvWSVr92DBiFQBf6m3pH0GvYEmDS5j53kzC9aZnN1W68QO8HxVXCzWKFjUZ5qZOk8aDZ i2DHXRJbYV9IhLGqB6mA7VEZA2je6iHbNtXXFFS22LrHNS2tPIiuYjL7QuUGea/zx+4M SBnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ERumemdOiVFOlIHOtj67gaJ2faoeNW4yCGRBq5U5+Us=; fh=9LhevukQlN8QgABBNKHWl1nBtSwK1vKoyAVqIrNCnSI=; b=pXwBNOqgZRS82KksIXhrQRqd19hh9h32ZfHa9g650PYsYYvoAw4XVFTdbY/DPQgevJ ImPB8yzD7BBR4dZ9JUUXLnM39X/6bSlT/3I+ZQlscKefG+YOYp+x0Ug7c0Nbe/HFqzcV OUovjnoHjlV87JPKYknb1J+T4xqDwQtBMHcMYa27fJMOqkGkJY5YoZmth4lE+j0tC0wG Qdzrv+BFkXo90LIgiEyFiyu2s6dKKurzsvL6RcHCLlBBO7vsl5Obkrb/OMyuqs82589S gDEGDHoCIPf2fHr1SpNVw1fZvI+2UWXYxn78YzJLLOW86O632gVmyXtNgaR7MhJa66Qp A5+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="jszcQuU/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t23-20020aa7d4d7000000b0051e3cbc399dsi4158374edr.287.2023.08.06.02.55.12; Sun, 06 Aug 2023 02:55:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="jszcQuU/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230197AbjHFJcu (ORCPT + 99 others); Sun, 6 Aug 2023 05:32:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230171AbjHFJcn (ORCPT ); Sun, 6 Aug 2023 05:32:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 745D01BFC; Sun, 6 Aug 2023 02:32:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0433C6100A; Sun, 6 Aug 2023 09:32:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C192C433CB; Sun, 6 Aug 2023 09:32:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691314361; bh=plXfZ6NESmXmkMd2BEKNNu9j1SnUKyka5nXAMxoPibY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jszcQuU/5DSTnUmyu/OD+prBihCdWWfNBi3PvQsNEbzF/XlSESwy65RvAyyQjgwoo 5SfXws34GtC7qrnzTNKj0vAU96o8+ByTIqQ9g7jOy00MRrAmM0IMWYHZN5s5I832i7 pSJX0UjwOJKL1gxo9tiDA3vSEWc2XqUd0W0AnQcFiBxTV9XgQoBVSn+OXT1xSh27ik 7AWShAct8DQVQLcqpjr2GQe+kYxdDjgG1v0meBZ13+Xss9fA0b+hEL5MvZRdr7OuNr IFU99Skw7uE02RbB1v2Tqpp57ICI61XhU1b7WI2AbmB58phtRGf68gtJ/tnz9cwl2u 1K2z3oZr9Mmvw== From: Jisheng Zhang To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Andy Shevchenko , Jiri Slaby Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] serial: 8250_dw: fall back to poll if there's no interrupt Date: Sun, 6 Aug 2023 17:20:56 +0800 Message-Id: <20230806092056.2467-3-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230806092056.2467-1-jszhang@kernel.org> References: <20230806092056.2467-1-jszhang@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773473089594219974 X-GMAIL-MSGID: 1773473089594219974 When there's no irq(this can be due to various reasons, for example, no irq from HW support, or we just want to use poll solution, and so on), falling back to poll is still better than no support at all. Signed-off-by: Jisheng Zhang --- drivers/tty/serial/8250/8250_dw.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c index 7db51781289e..f4cafca1a7da 100644 --- a/drivers/tty/serial/8250/8250_dw.c +++ b/drivers/tty/serial/8250/8250_dw.c @@ -523,7 +523,10 @@ static int dw8250_probe(struct platform_device *pdev) if (!regs) return dev_err_probe(dev, -EINVAL, "no registers defined\n"); - irq = platform_get_irq(pdev, 0); + irq = platform_get_irq_optional(pdev, 0); + /* no interrupt -> fall back to polling */ + if (irq == -ENXIO) + irq = 0; if (irq < 0) return irq;