From patchwork Fri Aug 4 16:38:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnaldo Carvalho de Melo X-Patchwork-Id: 131263 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:44a:b0:3f2:4152:657d with SMTP id ez10csp400087vqb; Fri, 4 Aug 2023 10:03:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHh2TIE3d5HvyEiNuwDOtUY+o+fAJbqHyUaJ54ptqf/HOpysnFL8QvFG5lH2nqhzyjnM1B7 X-Received: by 2002:a17:907:2c42:b0:99b:ef86:60d8 with SMTP id hf2-20020a1709072c4200b0099bef8660d8mr1720224ejc.5.1691168632551; Fri, 04 Aug 2023 10:03:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691168632; cv=none; d=google.com; s=arc-20160816; b=s4xM0g7NXe1HSExP1cTfW8GLljYZ5kgKhCHn+DOe180IhODt0sov3tnNLyCqJnptL8 QDMOglByah5j/suZVvikptIzhoEnXT5B1sYGxUi2Na924VwBvCPPni+72dqhD748+Ahl D6L2RXskviMG7G3cJjUZxwoibXs0wGrU6gdQrNr0SeSBIeQE1Es8FArB+j9LIzmbkawN //D68b0jWjiAluKXu7gw7w47fwUsCs4slXGTpk8g1kZQixepIux0ykyujGS2dfNC5DoP Pl5CAsVNZ1a267vglJzMZJcPUj7L4KDZgSFOABFEi+godW4DOQJx+q/fDFoL221ElBuE qapQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=GeuHOY7/4VcwBKh4SZDkc+3AyLYNA7KGzqXmMSPaW8U=; fh=Kn7JZodw35s50fWKjdRVXYXH28v8+weD7e9SXWnRImI=; b=OKgkWyOInRVBquO/YcO7Yx1badg5E/ImdJZASGk+sY+N7X6xDyMG/Fe6e0ZgXB1hBT 2F148X82YWeICx8OTQqwGC7oGdbGydkYDzQxvDAZJDhz5Vhx4Ss8zRR8JPue/MuvOH5e /chT0kg2cVf3gnKTx5I5pH8SO3cp1PvM2Ei3uBRIeiSv/BtSkLT7Ehz8LEsYxWpzqU+i Mko5AGN9GQb+DHArsh2TuUK+PO+nQRps8EifmFGTj22greL2yTUOhRTh4RvB+61Fg9WT fKoXwnct5tT9wShv7ET0KiRwcfJbwgM6qTCWfFtJjTOn0XyzeWAQhGlLG7DQp44ka486 no3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sdwHziPj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jx24-20020a170906ca5800b0099bcb8f4f00si1802521ejb.409.2023.08.04.10.02.41; Fri, 04 Aug 2023 10:03:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sdwHziPj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230355AbjHDQiv (ORCPT + 99 others); Fri, 4 Aug 2023 12:38:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231176AbjHDQim (ORCPT ); Fri, 4 Aug 2023 12:38:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E44CE7 for ; Fri, 4 Aug 2023 09:38:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D0880620A6 for ; Fri, 4 Aug 2023 16:38:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 140F2C433C7; Fri, 4 Aug 2023 16:38:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691167120; bh=qcJmbyKrYS1D8pZSxSWl2IPsapUnOSqx7XtwpMAymew=; h=Date:From:To:Cc:Subject:From; b=sdwHziPjIpgFr0QXhr0cMolYytboK7rTwF4y1BjYwfNLHd/bndW6VrIhxURbu5rb5 bRDTEhq2bgT5hMt1CbYqaaHF0Wi0MfwlUOHOLy6R0q9pBlRHaaEtyytzC8XFGbQpwt L84eKKYhavD3pBeSSwi2jBbyYykUTBtGgsjMhnsbFa9h/VoBo++AaRyU8UqaFTW718 aEVvpeIOS2WuLJFws6PuZXNBLxiUQJZ6A6i5kD0LgTkjW6JFRxdom7qcP+oJ3K2cjD SRCPQR6rsc5fEi1c8pVfVuyKLPH5zc6kq4ZFlsTtgZl2DHMA6VQiLl0wQ+fw4UoSlb aJVf8mzqia0jg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 7A6AC404DF; Fri, 4 Aug 2023 13:38:37 -0300 (-03) Date: Fri, 4 Aug 2023 13:38:37 -0300 From: Arnaldo Carvalho de Melo To: Masami Hiramatsu Cc: Adrian Hunter , Ian Rogers , Jiri Olsa , Namhyung Kim , Linux Kernel Mailing List Subject: [PATCH 1/1] perf probe: Make synthesize_perf_probe_point() private to probe-event.c Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773318839810679566 X-GMAIL-MSGID: 1773318839810679566 Not used in any other place, so just make it static. Cc: Adrian Hunter Cc: Ian Rogers Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Namhyung Kim Link: https://lore.kernel.org/lkml/ Signed-off-by: Arnaldo Carvalho de Melo Reviewed-by: Ian Rogers Acked-by: Masami Hiramatsu (Google) --- tools/perf/util/probe-event.c | 4 +++- tools/perf/util/probe-event.h | 1 - 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index 2835d87cb97771f9..1a5b7fa459b23204 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -53,6 +53,8 @@ bool probe_event_dry_run; /* Dry run flag */ struct probe_conf probe_conf = { .magic_num = DEFAULT_PROBE_MAGIC_NUM }; +static char *synthesize_perf_probe_point(struct perf_probe_point *pp); + #define semantic_error(msg ...) pr_err("Semantic error :" msg) int e_snprintf(char *str, size_t size, const char *format, ...) @@ -2010,7 +2012,7 @@ char *synthesize_perf_probe_arg(struct perf_probe_arg *pa) } /* Compose only probe point (not argument) */ -char *synthesize_perf_probe_point(struct perf_probe_point *pp) +static char *synthesize_perf_probe_point(struct perf_probe_point *pp) { struct strbuf buf; char *tmp, *ret = NULL; diff --git a/tools/perf/util/probe-event.h b/tools/perf/util/probe-event.h index 8ad5b1579f1d37b6..7e3b6c3d1f7447a7 100644 --- a/tools/perf/util/probe-event.h +++ b/tools/perf/util/probe-event.h @@ -137,7 +137,6 @@ int parse_probe_trace_command(const char *cmd, struct probe_trace_event *tev); char *synthesize_perf_probe_command(struct perf_probe_event *pev); char *synthesize_probe_trace_command(struct probe_trace_event *tev); char *synthesize_perf_probe_arg(struct perf_probe_arg *pa); -char *synthesize_perf_probe_point(struct perf_probe_point *pp); int perf_probe_event__copy(struct perf_probe_event *dst, struct perf_probe_event *src);