From patchwork Fri Aug 4 07:29:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuai Xue X-Patchwork-Id: 131009 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:44a:b0:3f2:4152:657d with SMTP id ez10csp111215vqb; Fri, 4 Aug 2023 01:29:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFpqnEQRXa0uHm0V/XmjVFSAcwU5kPSf4JfS9TCZPt9jMJ0f26m/kYUAdjlgXecIrtVCnmI X-Received: by 2002:a17:907:7783:b0:978:928:3b99 with SMTP id ky3-20020a170907778300b0097809283b99mr916845ejc.46.1691137749133; Fri, 04 Aug 2023 01:29:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691137749; cv=none; d=google.com; s=arc-20160816; b=Kw3pKtM5Yb5ewfelrn9mCh0WM8i6W8YDA3nYh8oqMwKvubjK+gXU46cUIhLyRdliIz OQ7pRtzpu1PF+bRh+Tdm56YzyC6FQBujETUCKZXmpPv+BSWpc8cPj/6vhnb6DoYHibzJ lCqlwdUSJMcH2O52Avql0i/rdjq5ACjtioLy2FGosMbinrdTG1VCFiFmBdwTc7kCwJom JSsUm1oH3zh0+VoYglo+MDEPGcEEnwZjpuTC7MzUifyZRTXCKO7I0R3Dc+l9wRZqpvDh DSTSB+zgzoHwm+xtatMrx0S6LY4uWdEIlXYbO2DY+47l74P8vhEH71vsPuj5Z3aZD4QR xD7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=jkkinhBK27ZPwQ2Etx2BwaBf7u0gsLaavmzN+FBQj24=; fh=YBikRTpR9zYoVYjuRUV1Fnixx8IEvJqVUBSmWl5mLFU=; b=nnVhTsZCRqfFBHpacLBnzs6lzDDAB1kNDoGaRDvFRqlQSNKta/KhpyoYW/GSWyDXoL qjX1u7Xx/w+YqPCfoyAHSJN8hZKRlUqze0QxLXy39+Kr9ce7L/rCdsTLUaMPAF49aTPn Z8KUE22OyKLJzzIDhEZnHwbzXMzVUQg3tc1KPr9Ozw/TTrB0aWO/XBtgusvDLH/7Gk6i X/V043UcF5pIm2wOzV/54zV2r/qCxx/Wvt0cYRYjcwUilCwwlKbz6Xtp9fd5vUW4E4eF CytpzTIMEINbk1bcGnGjGCRHTZ9sljpzEgxjAen7gD21FtaQeTSwaz83kysbh27KVIx0 00xQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c26-20020a170906155a00b00997bd26a559si228052ejd.881.2023.08.04.01.28.44; Fri, 04 Aug 2023 01:29:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234254AbjHDHcc (ORCPT + 99 others); Fri, 4 Aug 2023 03:32:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234070AbjHDHcG (ORCPT ); Fri, 4 Aug 2023 03:32:06 -0400 Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E430E46A0; Fri, 4 Aug 2023 00:31:08 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=16;SR=0;TI=SMTPD_---0Vp.c2JM_1691134193; Received: from localhost.localdomain(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0Vp.c2JM_1691134193) by smtp.aliyun-inc.com; Fri, 04 Aug 2023 15:29:55 +0800 From: Shuai Xue To: alexander.shishkin@linux.intel.com, peterz@infradead.org, james.clark@arm.com, leo.yan@linaro.org Cc: mingo@redhat.com, baolin.wang@linux.alibaba.com, acme@kernel.org, mark.rutland@arm.com, jolsa@kernel.org, namhyung@kernel.org, irogers@google.com, adrian.hunter@intel.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, nathan@kernel.org, bpf@vger.kernel.org Subject: [PATCH v4 1/2] perf/core: Bail out early if the request AUX area is out of bound Date: Fri, 4 Aug 2023 15:29:44 +0800 Message-Id: <20230804072945.85731-2-xueshuai@linux.alibaba.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230804072945.85731-1-xueshuai@linux.alibaba.com> References: <20230804072945.85731-1-xueshuai@linux.alibaba.com> MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773284571030849977 X-GMAIL-MSGID: 1773286456346733199 When perf-record with a large AUX area, e.g 4GB, it fails with: #perf record -C 0 -m ,4G -e arm_spe_0// -- sleep 1 failed to mmap with 12 (Cannot allocate memory) and it reveals a WARNING with __alloc_pages(): [ 66.595604] ------------[ cut here ]------------ [ 66.600206] WARNING: CPU: 44 PID: 17573 at mm/page_alloc.c:5568 __alloc_pages+0x1ec/0x248 [ 66.608375] Modules linked in: ip6table_filter(E) ip6_tables(E) iptable_filter(E) ebtable_nat(E) ebtables(E) aes_ce_blk(E) vfat(E) fat(E) aes_ce_cipher(E) crct10dif_ce(E) ghash_ce(E) sm4_ce_cipher(E) sm4(E) sha2_ce(E) sha256_arm64(E) sha1_ce(E) acpi_ipmi(E) sbsa_gwdt(E) sg(E) ipmi_si(E) ipmi_devintf(E) ipmi_msghandler(E) ip_tables(E) sd_mod(E) ast(E) drm_kms_helper(E) syscopyarea(E) sysfillrect(E) nvme(E) sysimgblt(E) i2c_algo_bit(E) nvme_core(E) drm_shmem_helper(E) ahci(E) t10_pi(E) libahci(E) drm(E) crc64_rocksoft(E) i40e(E) crc64(E) libata(E) i2c_core(E) [ 66.657719] CPU: 44 PID: 17573 Comm: perf Kdump: loaded Tainted: G E 6.3.0-rc4+ #58 [ 66.666749] Hardware name: Default Default/Default, BIOS 1.2.M1.AL.P.139.00 03/22/2023 [ 66.674650] pstate: 23400009 (nzCv daif +PAN -UAO +TCO +DIT -SSBS BTYPE=--) [ 66.681597] pc : __alloc_pages+0x1ec/0x248 [ 66.685680] lr : __kmalloc_large_node+0xc0/0x1f8 [ 66.690285] sp : ffff800020523980 [ 66.693585] pmr_save: 000000e0 [ 66.696624] x29: ffff800020523980 x28: ffff000832975800 x27: 0000000000000000 [ 66.703746] x26: 0000000000100000 x25: 0000000000100000 x24: ffff8000083615d0 [ 66.710866] x23: 0000000000040dc0 x22: ffff000823d6d140 x21: 000000000000000b [ 66.717987] x20: 000000000000000b x19: 0000000000000000 x18: 0000000000000030 [ 66.725108] x17: 0000000000000000 x16: ffff800008f05be8 x15: ffff000823d6d6d0 [ 66.732229] x14: 0000000000000000 x13: 343373656761705f x12: 726e202c30206574 [ 66.739350] x11: 00000000ffff7fff x10: 00000000ffff7fff x9 : ffff8000083af570 [ 66.746471] x8 : 00000000000bffe8 x7 : c0000000ffff7fff x6 : 000000000005fff4 [ 66.753592] x5 : 0000000000000000 x4 : ffff000823d6d8d8 x3 : 0000000000000000 [ 66.760713] x2 : 0000000000000000 x1 : 0000000000000001 x0 : 0000000000040dc0 [ 66.767834] Call trace: [ 66.770267] __alloc_pages+0x1ec/0x248 [ 66.774003] __kmalloc_large_node+0xc0/0x1f8 [ 66.778259] __kmalloc_node+0x134/0x1e8 [ 66.782081] rb_alloc_aux+0xe0/0x298 [ 66.785643] perf_mmap+0x440/0x660 [ 66.789031] mmap_region+0x308/0x8a8 [ 66.792593] do_mmap+0x3c0/0x528 [ 66.795807] vm_mmap_pgoff+0xf4/0x1b8 [ 66.799456] ksys_mmap_pgoff+0x18c/0x218 [ 66.803365] __arm64_sys_mmap+0x38/0x58 [ 66.807187] invoke_syscall+0x50/0x128 [ 66.810922] el0_svc_common.constprop.0+0x58/0x188 [ 66.815698] do_el0_svc+0x34/0x50 [ 66.818999] el0_svc+0x34/0x108 [ 66.822127] el0t_64_sync_handler+0xb8/0xc0 [ 66.826296] el0t_64_sync+0x1a4/0x1a8 [ 66.829946] ---[ end trace 0000000000000000 ]--- 'rb->aux_pages' allocated by kcalloc() is a pointer array which is used to maintains AUX trace pages. The allocated page for this array is physically contiguous (and virtually contiguous) with an order of 0..MAX_ORDER. If the size of pointer array crosses the limitation set by MAX_ORDER, it reveals a WARNING. So bail out early with -ENOMEM if the request AUX area is out of bound, e.g.: #perf record -C 0 -m ,4G -e arm_spe_0// -- sleep 1 failed to mmap with 12 (Cannot allocate memory) Signed-off-by: Shuai Xue --- kernel/events/ring_buffer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/events/ring_buffer.c b/kernel/events/ring_buffer.c index a0433f37b024..c445e927368d 100644 --- a/kernel/events/ring_buffer.c +++ b/kernel/events/ring_buffer.c @@ -699,6 +699,9 @@ int rb_alloc_aux(struct perf_buffer *rb, struct perf_event *event, watermark = 0; } + /* Can't allocate more than MAX_ORDER */ + if (get_order((unsigned long)nr_pages * sizeof(void *)) > MAX_ORDER) + return -ENOMEM; rb->aux_pages = kcalloc_node(nr_pages, sizeof(void *), GFP_KERNEL, node); if (!rb->aux_pages) From patchwork Fri Aug 4 07:29:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuai Xue X-Patchwork-Id: 131004 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:44a:b0:3f2:4152:657d with SMTP id ez10csp109318vqb; Fri, 4 Aug 2023 01:23:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFH9nwkNDwhFaV6Zwf0j307DWDCBs3agYSnhYJliN8rwyM2UX69dxTXyko9cXyzelIhQQ5V X-Received: by 2002:a05:6358:249f:b0:13a:9d5:356a with SMTP id m31-20020a056358249f00b0013a09d5356amr97719rwc.21.1691137439108; Fri, 04 Aug 2023 01:23:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691137439; cv=none; d=google.com; s=arc-20160816; b=wEH16DOdzDdBzzj3HggZ5+hK/VXyM+e4lUoxFe+uUrU5EsoLyvUmYtn00AU7Q4FH0V 6GqNSzs3cAiEQEPQnwleJibUgDebvhahn2NNikea/4V6QtxLtZpzwvHbZE0ZW9ArcsAx VBY9rLRTbZkyL1HmoWo7IqOg4KcuMeU137Qr3N7QClVqPeP+X9c1aGGc92S5iUrQ6/Nb +dxMsvTMXJZhsfJE4yewZE4m5a9wvCtE9y3JcG6yIFD0s0qWUpHSU/KwsLR8sCyhng32 lAZYy5kBAEN6Ez6dY0GtWkEN0Egph14DnLwkjaB8YwwMedLhdppCorbi0kL3X+xAk1o+ E1wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=DMRXbyZgZ5S0K4812xQbLo0ye892sTPJ6ZLWwDaT7Hc=; fh=YBikRTpR9zYoVYjuRUV1Fnixx8IEvJqVUBSmWl5mLFU=; b=hJtQrlsucrA0Zf5kXUgWlUOSRN08k4S0iuHF924zU5n4kf7tEzPGRnQJdLx46VGx5r OoU63Sdw3e8kV8+NGv77bdtT9ZproYxPveAxKyusjJqcWzp9Ka4Zc/MBGIPvAS0vLroV /VrnvqVRU1DltnQzkX35PV67uatRzAihQ5HynfA+gAAVYMksqc/JDa/7idR8dvAkqDth EQe+RRYzaFCTV9hzJtKFZ0P3sONFVfKsWlDNkNX/gndm24fw5jqZdzqrioLB+91kltdl +yvd1dAopI0DC5jQI3FPzkY9UKFyX1j6yKbnYrALveBMA9n5QqqVBMJ+rnCJRcJxAz/Y kRGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c17-20020a63da11000000b0054481da6ee5si1407619pgh.418.2023.08.04.01.23.45; Fri, 04 Aug 2023 01:23:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234353AbjHDHc3 (ORCPT + 99 others); Fri, 4 Aug 2023 03:32:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233944AbjHDHcD (ORCPT ); Fri, 4 Aug 2023 03:32:03 -0400 Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDCC14EE0; Fri, 4 Aug 2023 00:31:03 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R641e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=16;SR=0;TI=SMTPD_---0Vp.c2KL_1691134195; Received: from localhost.localdomain(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0Vp.c2KL_1691134195) by smtp.aliyun-inc.com; Fri, 04 Aug 2023 15:29:56 +0800 From: Shuai Xue To: alexander.shishkin@linux.intel.com, peterz@infradead.org, james.clark@arm.com, leo.yan@linaro.org Cc: mingo@redhat.com, baolin.wang@linux.alibaba.com, acme@kernel.org, mark.rutland@arm.com, jolsa@kernel.org, namhyung@kernel.org, irogers@google.com, adrian.hunter@intel.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, nathan@kernel.org, bpf@vger.kernel.org Subject: [PATCH v4 2/2] perf record: Update docs regarding the maximum limitation of AUX area Date: Fri, 4 Aug 2023 15:29:45 +0800 Message-Id: <20230804072945.85731-3-xueshuai@linux.alibaba.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230804072945.85731-1-xueshuai@linux.alibaba.com> References: <20230804072945.85731-1-xueshuai@linux.alibaba.com> MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773286131013991158 X-GMAIL-MSGID: 1773286131013991158 The maximum AUX area is limited by the page size of the system. Update the documentation to reflect this. Signed-off-by: Shuai Xue --- tools/perf/Documentation/perf-record.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt index 680396c56bd1..b0ee7b63da0e 100644 --- a/tools/perf/Documentation/perf-record.txt +++ b/tools/perf/Documentation/perf-record.txt @@ -292,6 +292,9 @@ OPTIONS Also, by adding a comma, the number of mmap pages for AUX area tracing can be specified. + The maximum AUX area is limited by the page size of the system. For + example with 4K pages configured, the maximum is 2GiB. + -g:: Enables call-graph (stack chain/backtrace) recording for both kernel space and user space.