From patchwork Fri Aug 4 06:50:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengming Zhou X-Patchwork-Id: 131030 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:44a:b0:3f2:4152:657d with SMTP id ez10csp130070vqb; Fri, 4 Aug 2023 02:13:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHZU+ZntbK7/4Il0bGfn7yac9yFvF6pRQeOx6n19EbkY0rVIatv8HjmgeLTA/33fgLU2+Mq X-Received: by 2002:a17:907:2c44:b0:99b:57f0:68b5 with SMTP id hf4-20020a1709072c4400b0099b57f068b5mr929445ejc.75.1691140437600; Fri, 04 Aug 2023 02:13:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691140437; cv=none; d=google.com; s=arc-20160816; b=bmapScRwzIQWjBVGv9DN6yevybZcslnn5Zaf+bZMuUDTsXbrxTIvaTHWd4SBC3/URz EY/O3alZrCU6ZPHrALOrg8uBThBTvUQnyQiPWc9VMNCnFgmpadX3Nygn6EBOSAiDSYh3 N/perbOMJAUHvqMn9UaR/5B1J6qZQrJ7fY8cVHAnNPMkK5g+D3txkpIJy/feyOIotAz1 02n5LoSwvARvfI2l9ucVZbFSvf1N46ZB32WC7b5CQ0BpIlnWEqwX/cszH8k5RGq3TQVZ lS04RUL94G5U9nuimjjC9K7+xJ0FvNx03f94qggc/7SXAR/AAbdnd/ZzmySNXquiOuE1 jXxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=zxLKOBj7wIHNRdSalkXgxfxEOVasPtHv6AvF944bYZE=; fh=trl8IP3/IStrfUzErWPHTQPip+nFa0aNkVvc3yxpI3E=; b=ie0BCstQRT1I8CygQ2RtpsCKBA5K6WqOI1RnpEem44Nl1onbuF/08uZd6Etlk8BzuC OQ5+a5hBPyLFw9KaORITw8Ze3iwXGFFGptDzuJC4nZP9kPJGDQmwKVuIadVb3JOp5IgR 2FzmzGBEajjJcPNPsbo9uco3OHM1V524lZcC+LsFondF2WNqj6bZTDKc+PneDldtmINO LV2cCIyW/yMbarQKJwgPpWqr57HoiRGkB4yT5qh5BoolL0/vs+WNZu89FX3MtoMVxb58 9F4WavfJoKEpjOQN/jooBMTu8yoMTMCFlDnSDGe3ZIV8oazdVJzPuUqj/t4wXPAMRTDR /YGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=mvpRv1+b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i21-20020a170906091500b0099bcec1f1bbsi1301697ejd.182.2023.08.04.02.13.34; Fri, 04 Aug 2023 02:13:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=mvpRv1+b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233884AbjHDGvp (ORCPT + 99 others); Fri, 4 Aug 2023 02:51:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233949AbjHDGvT (ORCPT ); Fri, 4 Aug 2023 02:51:19 -0400 Received: from out-118.mta1.migadu.com (out-118.mta1.migadu.com [IPv6:2001:41d0:203:375::76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 260A55248 for ; Thu, 3 Aug 2023 23:50:55 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1691131854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=zxLKOBj7wIHNRdSalkXgxfxEOVasPtHv6AvF944bYZE=; b=mvpRv1+bRyyifvUHQhFtMF1aGHzLQjXFyxTvOLG+1OCmGKyUN5wltRQBi2683v1N8R0pMd BLqR1EhtekRy4twLO9hfzdbukyI/ftgRrfhhToFBwJQ8nai5u73FuuNR9iYKTf5ZnjtCkh B5q3OUTb6CVz3SOgAxzRw6kb9w9c3hw= From: chengming.zhou@linux.dev To: axboe@kernel.dk, tj@kernel.org Cc: linux-kernel@vger.kernel.org, zhouchengming@bytedance.com Subject: [PATCH 1/3] iocost_monitor: fix kernel queue kobj changes Date: Fri, 4 Aug 2023 14:50:37 +0800 Message-ID: <20230804065039.8885-1-chengming.zhou@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773289275732217759 X-GMAIL-MSGID: 1773289275732217759 From: Chengming Zhou When I use iocost_monitor on nvme0n1, this error shows up: "Could not find ioc for nvme0n1" There is no kobj in struct queue in recent kernel, it seems that the commit 2bd85221a625 ("block: untangle request_queue refcounting from sysfs") move the queue kobj to struct gendisk. Fix it by using mq_kobj which is at the same level with queue kobj. Signed-off-by: Chengming Zhou --- tools/cgroup/iocost_monitor.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/cgroup/iocost_monitor.py b/tools/cgroup/iocost_monitor.py index 0dbbc67400fc..7aa076cb559e 100644 --- a/tools/cgroup/iocost_monitor.py +++ b/tools/cgroup/iocost_monitor.py @@ -221,7 +221,7 @@ ioc = None for i, ptr in radix_tree_for_each(blkcg_root.blkg_tree.address_of_()): blkg = drgn.Object(prog, 'struct blkcg_gq', address=ptr) try: - if devname == blkg.q.kobj.parent.name.string_().decode('utf-8'): + if devname == blkg.q.mq_kobj.parent.name.string_().decode('utf-8'): q_id = blkg.q.id.value_() if blkg.pd[plid]: root_iocg = container_of(blkg.pd[plid], 'struct ioc_gq', 'pd') From patchwork Fri Aug 4 06:50:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengming Zhou X-Patchwork-Id: 131021 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:44a:b0:3f2:4152:657d with SMTP id ez10csp118474vqb; Fri, 4 Aug 2023 01:47:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFz6whTp5aNCd0KsZuCUHSsyCBWI+XHvuLrn/Lc8HtCYLl7IFknS6+JuioS4/16t6/tv583 X-Received: by 2002:a17:907:7888:b0:99b:7297:fbf5 with SMTP id ku8-20020a170907788800b0099b7297fbf5mr1012600ejc.61.1691138865054; Fri, 04 Aug 2023 01:47:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691138865; cv=none; d=google.com; s=arc-20160816; b=YAw70UAa0xsuaOXBhwJvuEQ52ycVnXehxIASwaaSHH9eEL/HdICnGFuBCMHrFWQg7g vZAVMp2Ph3Cwd8wZdoYgQA3a3CTO585DlLRgg/CcTDcdh0oAJ+CqMv13OSJpx0cl3a4u uQJELZvfSGHbS5q8IjrYEE8UkRUse6P6+JSi4uEL9c2LGbHU21wu7BQUFVRYC23ADPHd 7Xw18qQj6G0A49CF+eDK7vkMfXEA4n885WqUXJEWK7+k0F8n8fdqnTKNt414I7UOSco0 P3YuXSRcg2mGTnx4ruX8CQ+dfHR7NBZIztrSHRmAhi1mD3JkVqfRG9Mi+sE1CqSwNl9n vGCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=OzB+tj5WG2nRg5qjnj2AfK3ycFx9pV+276EIl9UNjzI=; fh=trl8IP3/IStrfUzErWPHTQPip+nFa0aNkVvc3yxpI3E=; b=RHf7F7WDFxegwc3t6t7v0RGHaTe49n6wgef81+1+RqSyTv+t6IeSJahFxMmgop0amg vm/gi8RpZlHeFqIms1MUf6cpxhTKIX5dJbyPRnfK5jt6RrohTSAog76fJAav/Wuwdg/f 7x/frWu/xvAYbSAbMnC0h+Heeuh4CtO+Yp+Aok3YkC5sEz3aSPxRDK5MGzO8+xjz8t4L pbMvmYpxcnjvPFoaEcO5Flauewukjhp2fCEBII35ccimG4+MaKjXkQk736zJ2yDn7ZNX BVfGIviMK2wLMOeoxDE2wQE+zzakXmh81DoiPk4Bfc35REupPvmE7UD0ZrGHZKzlTqmY 5Fgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=YLZj7PyQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m16-20020a1709062b9000b009888aa1da13si1357261ejg.752.2023.08.04.01.47.21; Fri, 04 Aug 2023 01:47:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=YLZj7PyQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233959AbjHDGvs (ORCPT + 99 others); Fri, 4 Aug 2023 02:51:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233890AbjHDGvV (ORCPT ); Fri, 4 Aug 2023 02:51:21 -0400 Received: from out-123.mta1.migadu.com (out-123.mta1.migadu.com [95.215.58.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAA6F49E5 for ; Thu, 3 Aug 2023 23:50:58 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1691131856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OzB+tj5WG2nRg5qjnj2AfK3ycFx9pV+276EIl9UNjzI=; b=YLZj7PyQ1W40IvVqKAz4telK3UOEU755Km77YnQbv6fHLPvZQLj4HLBy8qQgXP4ZtwjJOn o0KkbrYXbekt3SbDYkjwl7DygkR0L1YXDxsqPO5tw2ancYRZnm9ZoDzWy/FdaabEwqnrSZ 6LQs+S8cUSey6argktmIpAW7y+RW5Gg= From: chengming.zhou@linux.dev To: axboe@kernel.dk, tj@kernel.org Cc: linux-kernel@vger.kernel.org, zhouchengming@bytedance.com Subject: [PATCH 2/3] iocost_monitor: print vrate inuse along with base_vrate Date: Fri, 4 Aug 2023 14:50:38 +0800 Message-ID: <20230804065039.8885-2-chengming.zhou@linux.dev> In-Reply-To: <20230804065039.8885-1-chengming.zhou@linux.dev> References: <20230804065039.8885-1-chengming.zhou@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773287626618517923 X-GMAIL-MSGID: 1773287626618517923 From: Chengming Zhou The real vrate iocost inuse is not base_vrate, but the atomic vtime_rate. We need iocost_monitor tool to display this real vrate that iocost use, to check if the boosted compensated vrate is normal. Effect after change: nvme0n1 RUN per=50.0ms cur_per=172116.580:v1040587.433 busy= +0 \ vrate=135.00%:270.00% params=ssd_dfl(CQ) ^ | this is real vrate inuse Signed-off-by: Chengming Zhou --- tools/cgroup/iocost_monitor.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/cgroup/iocost_monitor.py b/tools/cgroup/iocost_monitor.py index 7aa076cb559e..52ae9d1595b2 100644 --- a/tools/cgroup/iocost_monitor.py +++ b/tools/cgroup/iocost_monitor.py @@ -100,6 +100,7 @@ class IocStat: self.period_at = ioc.period_at.value_() / 1_000_000 self.vperiod_at = ioc.period_at_vtime.value_() / VTIME_PER_SEC self.vrate_pct = ioc.vtime_base_rate.value_() * 100 / VTIME_PER_USEC + self.ivrate_pct = ioc.vtime_rate.counter.value_() * 100 / VTIME_PER_USEC self.busy_level = ioc.busy_level.value_() self.autop_idx = ioc.autop_idx.value_() self.user_cost_model = ioc.user_cost_model.value_() @@ -119,7 +120,9 @@ class IocStat: 'period_at' : self.period_at, 'period_vtime_at' : self.vperiod_at, 'busy_level' : self.busy_level, - 'vrate_pct' : self.vrate_pct, } + 'vrate_pct' : self.vrate_pct, + 'ivrate_pct' : self.ivrate_pct, + } def table_preamble_str(self): state = ('RUN' if self.running else 'IDLE') if self.enabled else 'OFF' @@ -127,7 +130,7 @@ class IocStat: f'per={self.period_ms}ms ' \ f'cur_per={self.period_at:.3f}:v{self.vperiod_at:.3f} ' \ f'busy={self.busy_level:+3} ' \ - f'vrate={self.vrate_pct:6.2f}% ' \ + f'vrate={self.vrate_pct:6.2f}%:{self.ivrate_pct:6.2f}% ' \ f'params={self.autop_name}' if self.user_cost_model or self.user_qos_params: output += f'({"C" if self.user_cost_model else ""}{"Q" if self.user_qos_params else ""})' From patchwork Fri Aug 4 06:50:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengming Zhou X-Patchwork-Id: 130999 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:44a:b0:3f2:4152:657d with SMTP id ez10csp96774vqb; Fri, 4 Aug 2023 00:53:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHt9DsLGyCMpp0EeQalSz/s/TBjPOn3cu0EO9IqIlydUZZO4B7wb0VwR6L8tQFU84xjG0x/ X-Received: by 2002:a05:6a20:728f:b0:12f:952:11fb with SMTP id o15-20020a056a20728f00b0012f095211fbmr953289pzk.52.1691135601848; Fri, 04 Aug 2023 00:53:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691135601; cv=none; d=google.com; s=arc-20160816; b=KcMw95L8zGSdRYjfVVEV6w3wIaqhGKQH7xRW2ofJ+h464JYfqxO0CJDNLmCQaoUN6v MS73SiW/F9kknh6jZDzZ0QJeRJlqTSffVvTtUV6WmNM+oHEHoBIl0b8XK8Mp9YjxU0pq ycfCvVX+bkp7BzixsGxHK2QB29DXUpmKsAiwDBZlMAfDbGVQA8paC/BmK7P85m7+jLSr aefQzQi8rlXiOAlsatpgS2KQAazbkPC3HvCZtpqGBceLexnd+jxR7tVoN03LApSMVZLE KLpqNu9gMcXlWX2U2/7oFL/cnuhjSQzq5tRb2UClMnvRSA7au+1QgJidbe3p7l8SGOSI XQnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6+OCmkB89lJ9QhqUH4GLLqFHcU5/CM75quLqXRzfOwY=; fh=trl8IP3/IStrfUzErWPHTQPip+nFa0aNkVvc3yxpI3E=; b=fIYAsr3WWWDDhf0fWt2PAmfZm0BOHUZgrFyLgPRu2jWw+2RiUlP2fvVKfvDRVVjHfN UnijZmDegqaK8n/JzDHRVIFVuixIBC9MvmKLZ0Wq+MjRImzcDXTPrs4JNd3vwlL+oCMd h0agdpjpNtROKwdiRIy/cO+THdprnJD5fjVcyleci2dOGjX+VcrM8SW/lAlGmxFMhBoG OV+/BQmvKY4PSZS5Sm6PHXS5PHROGZyleQpP/DpBYyYjcP+D4+vaa+OJDqYgsDd2Xu8k 4U56M3oa1EPXpy2F9pg5uo3Z8tQDOaP8QpuDPv2SAlKVlIUw25f2jEaU++Mc20sauKQo Ez5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=oH0V0+nU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f11-20020a056a0022cb00b00686e7b259fcsi1418561pfj.184.2023.08.04.00.53.09; Fri, 04 Aug 2023 00:53:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=oH0V0+nU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233746AbjHDGvv (ORCPT + 99 others); Fri, 4 Aug 2023 02:51:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233957AbjHDGvX (ORCPT ); Fri, 4 Aug 2023 02:51:23 -0400 Received: from out-106.mta1.migadu.com (out-106.mta1.migadu.com [IPv6:2001:41d0:203:375::6a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 438DAE69 for ; Thu, 3 Aug 2023 23:51:01 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1691131858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6+OCmkB89lJ9QhqUH4GLLqFHcU5/CM75quLqXRzfOwY=; b=oH0V0+nUwhj+72gwRc5ePHbuqdLY/xtqB7P0DP84CcRPglVSIUiSlTqBKcH5X9gWCF69Y3 ALYeZ+iP0YR4jahdwaAvrK7vez+SbpXMeCDnYRQQ+x76r27KkBQPrwryjXUHDHBZqGsFl7 W0whfcJRbxal3QLq7RCQygin4tnNfq4= From: chengming.zhou@linux.dev To: axboe@kernel.dk, tj@kernel.org Cc: linux-kernel@vger.kernel.org, zhouchengming@bytedance.com Subject: [PATCH 3/3] iocost_monitor: improve it by adding iocg wait_ms Date: Fri, 4 Aug 2023 14:50:39 +0800 Message-ID: <20230804065039.8885-3-chengming.zhou@linux.dev> In-Reply-To: <20230804065039.8885-1-chengming.zhou@linux.dev> References: <20230804065039.8885-1-chengming.zhou@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773284204744225333 X-GMAIL-MSGID: 1773284204744225333 From: Chengming Zhou The iocg can have three throttled metrics: wait, debt, delay. This patch add missing wait_ms to IocgStat to show the latest wait_ms of iocg. As we are here, group iocg usage percents "inflt%" and "usage%" together, and group iocg throttled metrics "wait", "debt" and "delay" together. Effect after changes: nvme0n1 RUN per=50.0ms cur_per=177105.713:v1053528.587 busy= +0 vrate=135.00%:270.00% params=ssd_dfl(CQ) active weight hweight% inflt% usage% wait debt delay InterfererGroup0 * 100/ 100 54.28/ 9.09 0.34 24.07 0.00 0.00 0.00 interfered * 84/ 1000 45.72/ 90.91 0.48 41.09 0.00 0.00 0.00 Signed-off-by: Chengming Zhou Acked-by: Tejun Heo --- tools/cgroup/iocost_monitor.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tools/cgroup/iocost_monitor.py b/tools/cgroup/iocost_monitor.py index 52ae9d1595b2..933c750b319b 100644 --- a/tools/cgroup/iocost_monitor.py +++ b/tools/cgroup/iocost_monitor.py @@ -138,7 +138,7 @@ class IocStat: def table_header_str(self): return f'{"":25} active {"weight":>9} {"hweight%":>13} {"inflt%":>6} ' \ - f'{"debt":>7} {"delay":>7} {"usage%"}' + f'{"usage%":>6} {"wait":>7} {"debt":>7} {"delay":>7}' class IocgStat: def __init__(self, iocg): @@ -164,6 +164,8 @@ class IocgStat: self.usage = (100 * iocg.usage_delta_us.value_() / ioc.period_us.value_()) if self.active else 0 + self.wait_ms = (iocg.stat.wait_us.value_() - + iocg.last_stat.wait_us.value_()) / 1000 self.debt_ms = iocg.abs_vdebt.value_() / VTIME_PER_USEC / 1000 if blkg.use_delay.counter.value_() != 0: self.delay_ms = blkg.delay_nsec.counter.value_() / 1_000_000 @@ -180,9 +182,10 @@ class IocgStat: 'hweight_active_pct' : self.hwa_pct, 'hweight_inuse_pct' : self.hwi_pct, 'inflight_pct' : self.inflight_pct, + 'usage_pct' : self.usage, + 'wait_ms' : self.wait_ms, 'debt_ms' : self.debt_ms, 'delay_ms' : self.delay_ms, - 'usage_pct' : self.usage, 'address' : self.address } return out @@ -192,9 +195,10 @@ class IocgStat: f'{round(self.inuse):5}/{round(self.active):5} ' \ f'{self.hwi_pct:6.2f}/{self.hwa_pct:6.2f} ' \ f'{self.inflight_pct:6.2f} ' \ + f'{min(self.usage, 999):6.2f} ' \ + f'{self.wait_ms:7.2f} ' \ f'{self.debt_ms:7.2f} ' \ - f'{self.delay_ms:7.2f} '\ - f'{min(self.usage, 999):6.2f}' + f'{self.delay_ms:7.2f}' out = out.rstrip(':') return out