From patchwork Fri Aug 4 03:01:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 130962 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:44a:b0:3f2:4152:657d with SMTP id ez10csp34860vqb; Thu, 3 Aug 2023 22:09:45 -0700 (PDT) X-Google-Smtp-Source: APBJJlEhGD+6Ceh5wrVQfgmZqsuUOMpRgSv6j2z+3KWl53mHVDPq8N2WShGwJp2pOp3xYQ6asWMG X-Received: by 2002:a17:906:224b:b0:99c:22e9:fbe4 with SMTP id 11-20020a170906224b00b0099c22e9fbe4mr8601815ejr.1.1691125785107; Thu, 03 Aug 2023 22:09:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691125785; cv=none; d=google.com; s=arc-20160816; b=ZBDH7aqZgBqZNsAykju++iJMcYLy8i3x8OEGsHQy7xBuLnRItwXwFf+0I7Ikzx+QT7 nEgmWqtZDPwnXaBGjjmwMErCg/28Y+KkXf1WxzDIFBHW3D/+wL+RlCaS+gEMRXcxzHLW hISQgFt4VeGVd/1ozXFQLJs3l8Fh9yUNf/MEFk6VmBMuQ2XbK/TIRxIRSQPFsI//Ry0r xv04PRJoKB6HfHGjmB9aTXLt6NNfooBnZwPZPUnirjkyGR7ZsecQu9ABexMaKM4/ezWJ BAH2m/hn7QZx4MPdqnKN1t306PWJ6+i7r+XhX1F8Tx95En5EJFk+OdI/B6ZOCtv7zCoI mFfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=gDKP5i31iXcB7XY3CqXxxapdhR7Wmw4nqvFeijbaPqw=; fh=fNxBHeidubM00zzTWyG4U2vV1A2k83GeNWhj07FemCY=; b=0C6MMkp5OkJLjYgJ02GLlJeneSo47UWM+uhaWAZJjplgc+16m1ir/0u2n2AqAEmy/3 1209tYa8ciX4adpshTZtLppf1C054r76hPdZ8zqF8nfNoNIVAjUN8E2wxYwXzlaEZ/2a YZ7smG93Z2475+sufwYH4pW1/kJ0gQwRswe7th45tyHyKipYKPhk+vmhZdw0CRqIjoNc jz8IT+DpqWi590d+78kq9buN03iSZa5xXXpytweIKM09HYYuwWjQCh4V87mY7ZW1xK9T l+l+NHYtYIgHTdUxxEvBK+yU5ShcZdkcLo+CYzUhVGZ4novb30zfQ1dd/F7JCbITqe/J +DoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=sYB4qL2o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a14-20020a17090682ce00b0098718971f52si913623ejy.87.2023.08.03.22.09.21; Thu, 03 Aug 2023 22:09:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=sYB4qL2o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230165AbjHDDCk (ORCPT + 99 others); Thu, 3 Aug 2023 23:02:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232913AbjHDDCP (ORCPT ); Thu, 3 Aug 2023 23:02:15 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A3B04494 for ; Thu, 3 Aug 2023 20:01:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:In-Reply-To:References; bh=gDKP5i31iXcB7XY3CqXxxapdhR7Wmw4nqvFeijbaPqw=; b=sYB4qL2oR+AXtSDWIhmnLdhQjI 4TYGWK4XIRcf98vrdd5qZv8odaIHu3wmVZ2jFLZMkpIOyoDy99B/amCBWB/Cg+T+v4pHhdMNeq18/ 8QOU3oge6sBZPSIWZFvLzUopywaD2sMYm2w1Kaq4gU92fQ21ynEV670ZDnWHkyM4y4DHTQlqAbBUR WTfKFONe8Se45AYl0fjrkytU+87PXmuGv8HK7p7SmcSWIlPlhBqJ8iyQo/CSixYZDw1U6vnjrRFg1 b5Bmr6v+Ba2F/a2lGTDdcLaLuJIJ/Gj+VNZxBZoqw98SEV6LdgHAsjHdPJINrn15GlGK/KysTKpZD uVsUbXqQ==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qRl4P-00BQPu-1e; Fri, 04 Aug 2023 03:01:41 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Aleksandr Nogikh , Adam Ford , Maxime Ripard , =?utf-8?q?Guido_G=C3=BCnther?= , Robert Chiras , Sam Ravnborg , Neil Armstrong , Andrzej Hajda , Robert Foss , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH] drm: bridge: for GENERIC_PHY_MIPI_DPHY also select GENERIC_PHY Date: Thu, 3 Aug 2023 20:01:37 -0700 Message-ID: <20230804030140.21395-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773273911303130425 X-GMAIL-MSGID: 1773273911303130425 Three DRM bridge drivers select GENERIC_PHY_MIPI_DPHY when GENERIC_PHY might not be set. This causes Kconfig warnings and a build error. WARNING: unmet direct dependencies detected for GENERIC_PHY_MIPI_DPHY Depends on [n]: GENERIC_PHY [=n] Selected by [y]: - DRM_NWL_MIPI_DSI [=y] && DRM_BRIDGE [=y] && DRM [=y] && COMMON_CLK [=y] && OF [=y] && HAS_IOMEM [=y] - DRM_SAMSUNG_DSIM [=y] && DRM [=y] && DRM_BRIDGE [=y] && COMMON_CLK [=y] && OF [=y] && HAS_IOMEM [=y] (drm/bridge/cadence/Kconfig was found by inspection.) aarch64-linux-ld: drivers/gpu/drm/bridge/samsung-dsim.o: in function `samsung_dsim_set_phy_ctrl': drivers/gpu/drm/bridge/samsung-dsim.c:731: undefined reference to `phy_mipi_dphy_get_default_config_for_hsclk' Prevent these warnings and build error by also selecting GENERIC_PHY whenever selecting GENERIC_PHY_MIPI_DPHY. Fixes: fced5a364dee ("drm/bridge: cdns: Convert to phy framework") Fixes: 44cfc6233447 ("drm/bridge: Add NWL MIPI DSI host controller support") Fixes: 171b3b1e0f8b ("drm: bridge: samsung-dsim: Select GENERIC_PHY_MIPI_DPHY") Signed-off-by: Randy Dunlap Reported-by: Aleksandr Nogikh Link: lore.kernel.org/r/20230803144227.2187749-1-nogikh@google.com Cc: Adam Ford Cc: Maxime Ripard Cc: Guido Günther Cc: Robert Chiras Cc: Sam Ravnborg Cc: Neil Armstrong Cc: Andrzej Hajda Cc: Robert Foss Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Reviewed-by: Guido Günther Tested-by: Aleksandr Nogikh Reviewed-by: Adam Ford --- drivers/gpu/drm/bridge/Kconfig | 2 ++ drivers/gpu/drm/bridge/cadence/Kconfig | 1 + 2 files changed, 3 insertions(+) diff -- a/drivers/gpu/drm/bridge/cadence/Kconfig b/drivers/gpu/drm/bridge/cadence/Kconfig --- a/drivers/gpu/drm/bridge/cadence/Kconfig +++ b/drivers/gpu/drm/bridge/cadence/Kconfig @@ -4,6 +4,7 @@ config DRM_CDNS_DSI select DRM_KMS_HELPER select DRM_MIPI_DSI select DRM_PANEL_BRIDGE + select GENERIC_PHY select GENERIC_PHY_MIPI_DPHY depends on OF help diff -- a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -181,6 +181,7 @@ config DRM_NWL_MIPI_DSI select DRM_KMS_HELPER select DRM_MIPI_DSI select DRM_PANEL_BRIDGE + select GENERIC_PHY select GENERIC_PHY_MIPI_DPHY select MFD_SYSCON select MULTIPLEXER @@ -227,6 +228,7 @@ config DRM_SAMSUNG_DSIM select DRM_KMS_HELPER select DRM_MIPI_DSI select DRM_PANEL_BRIDGE + select GENERIC_PHY select GENERIC_PHY_MIPI_DPHY help The Samsung MIPI DSIM bridge controller driver.