From patchwork Thu Aug 3 14:44:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Zhangjin Wu X-Patchwork-Id: 130683 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp1217069vqx; Thu, 3 Aug 2023 08:14:27 -0700 (PDT) X-Google-Smtp-Source: APBJJlFcd2lP9HZzTXlA7HTsMbEA7b3G0Fy6IqIChnA/0mBl0ddgr5K5q+6FpM0JRtWqQWIO+INj X-Received: by 2002:a05:6512:554:b0:4fd:d1c0:6439 with SMTP id h20-20020a056512055400b004fdd1c06439mr6712861lfl.41.1691075667063; Thu, 03 Aug 2023 08:14:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691075667; cv=none; d=google.com; s=arc-20160816; b=Ka1izR/13c+Zl2ggMa+709WlRbVRRNRjOP3Fc/otMZ2gmmNhWsucKVH/Uaf5PgBmVa l4MizvvpFgIre83MPlqGvGFJOht7qefQ2VdrMjgcFGdzM9XYGstRIc7T555m//jlA0Vb dZaw4atyzDylhHuJ3aWbMtvmHk8rsRh81XG8lbQ/IA6oChvMHBW7LXvhUmncYCfd496d MtBptZxZwKm/z0rEiOb1MVPhRiYyNxxapBpFOxwrpm5fIQvuTxAeO3CXwhiy6HGv2Jc6 fJFGq7yLIgQ8qPjKlLlslSO5BLUhvi8oyhf1mwl+qYXnQ7oUGS+b7rCKLF1i6899PNQu A4mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=G9vZQC45d7UweKvtcoWRnkQWv0O99aOQ1Fowd6WiFOA=; fh=TsKNe/ZSymFDLfCGQokP79s6S6Z9FKHYw1KoAUSYM0Y=; b=qFoPIVaNy1fIQtgg6J0qYSHXw7a8VICSy4o8NsLbOwN3ukuM1YhUtBQlfnuZeCxk85 wGXuohp6NYUBjkqEnxRz62C+qYFqEvfg4y00MY91NJ4V3V3SANpnOBNFYG35yRZGs3+/ cviKAQ6ziZORGVoG2fSYf0IZIjtFmPLKxDkzpRZXjCeE/mZf2Yj41Cs9P6czaVzWgG7m ChabanHO9e6qA0JqdYxM72gXdrnQoTwGS+G5r3sGdjvlKadT/DecympvSxHRuWkZtZnK cl+ydboSLRUT1xzlMiFiWRQ5OCeqJajJlQnjcd4ZLER9U4qJrgj9F3D6JTCR2tyrH33U UDSA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w8-20020aa7cb48000000b005227bab0331si458839edt.139.2023.08.03.08.13.54; Thu, 03 Aug 2023 08:14:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234916AbjHCOpV (ORCPT + 99 others); Thu, 3 Aug 2023 10:45:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229838AbjHCOpU (ORCPT ); Thu, 3 Aug 2023 10:45:20 -0400 Received: from bg4.exmail.qq.com (bg4.exmail.qq.com [43.154.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F25F6272A; Thu, 3 Aug 2023 07:45:01 -0700 (PDT) X-QQ-mid: bizesmtp68t1691073889t4khgjyo Received: from linux-lab-host.localdomain ( [116.30.131.233]) by bizesmtp.qq.com (ESMTP) with id ; Thu, 03 Aug 2023 22:44:48 +0800 (CST) X-QQ-SSF: 01200000000000E0X000000A0000000 X-QQ-FEAT: IcCSTr/hHjOY6VEm71/IgqzXpvSKtnkkeAhaXGC6ywTF2cpGNkzcpdx/TKfBR hiT/uimJdY9bSUpyUuSaerHKZybT6bxkLtzpKWPzP4ooH8Q94U9UtiRcBQ3eFczhrRwN0sP b4pn/bUfnf6T2k4b4Fv80z+bDiHCUHDykgviC0pI3DKArvoIjWychyt0uvjPLtexRtVLQx5 pU4R/Quxhus+VsmVZ6eOZH5iVH/ob+OX1ILvDCjEkeaYJWleLJOER+TqdX2+vAzvDLswN3O q8BOXHnGwEIhwM+sJs2a4ElA7H7t8fgMjeA19g2jg7owR+VT0XL665E/HiEvaKafzk9JWY+ +/sXOyNDWMr9NK7kd0RcSvv4+qaaME1X7G1Y8NPx/JA2YLJAOgRmSVXABKMtA== X-QQ-GoodBg: 0 X-BIZMAIL-ID: 16889210508808416794 From: Zhangjin Wu To: thomas@t-8ch.de, w@1wt.eu Cc: falcon@tinylab.org, arnd@arndb.de, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, tanyuan@tinylab.org Subject: [PATCH v1 1/3] selftests/nolibc: allow report with existing test log Date: Thu, 3 Aug 2023 22:44:47 +0800 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:tinylab.org:qybglogicsvrgz:qybglogicsvrgz5a-1 X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773221358757391789 X-GMAIL-MSGID: 1773221358757391789 After the tests finish, it is valuable to report and summarize with existing test log. This avoid rerun or run the tests again when not necessary. Signed-off-by: Zhangjin Wu Reviewed-by: Thomas Weißschuh --- tools/testing/selftests/nolibc/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/testing/selftests/nolibc/Makefile b/tools/testing/selftests/nolibc/Makefile index 16cc33db54e3..51fef5e6a152 100644 --- a/tools/testing/selftests/nolibc/Makefile +++ b/tools/testing/selftests/nolibc/Makefile @@ -225,6 +225,10 @@ rerun: $(Q)qemu-system-$(QEMU_ARCH) -display none -no-reboot -kernel "$(srctree)/$(IMAGE)" -serial stdio $(QEMU_ARGS) > "$(CURDIR)/run.out" $(Q)$(REPORT) $(CURDIR)/run.out +# report with existing test log +report: + $(Q)$(REPORT) $(CURDIR)/run.out + clean: $(call QUIET_CLEAN, sysroot) $(Q)rm -rf sysroot From patchwork Thu Aug 3 14:45:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhangjin Wu X-Patchwork-Id: 130704 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp1245442vqx; Thu, 3 Aug 2023 09:01:34 -0700 (PDT) X-Google-Smtp-Source: APBJJlGmkpi+V2F8IqoHA9Ep570nYLY8EcDgF/+3ck6VvLRAxP+YTbUTKiVbC9vCwlSTbel/42s7 X-Received: by 2002:a05:651c:14a:b0:2b9:acad:b4b2 with SMTP id c10-20020a05651c014a00b002b9acadb4b2mr8553194ljd.6.1691078493831; Thu, 03 Aug 2023 09:01:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691078493; cv=none; d=google.com; s=arc-20160816; b=tfu6/Wi4sgSwOWcBJSO7lxpuSdBHc497VW23ctA1GHmyUVyMD1qM8/JhmLWHtJ9r/J brdrx9VzKRrqL8ro67GL0axEE2Q2UYksMAk4WPmVf+lNutb9cilpoIBCd7wBSGkDSXDF RstFNT9VIMGOGOrSoFSAf7Mihxp4GUQGbxXMuy6AV9VPZ+XDkwwVD/fO2LfzXWW2rLpJ ocaiOWvVg04RzEyIqvXTbucrozA1vDIs5ipknEiVm4OJDJrQDDW6z22ROLEDPF+vlMyq vDK4PQNrxIXA1LCodd1UVl2RtG5AwbNSYF42G8Rme79ZFUFFpZTHnnBZTbwgoTu7/J9e Y8lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=yJBSaWpPj9X/4+wKwjKpG1AzyQRibLCgN6gNsn38ZCs=; fh=TsKNe/ZSymFDLfCGQokP79s6S6Z9FKHYw1KoAUSYM0Y=; b=IpIFwq2BKtSQi0vqOrIbtg+JdbVhtkMQ8itIjHydWPDRmbiN9TBe4LaC1eTySwa8MB G7kER1cobmPXOQYqOa4nliwIiUfbgpY5gYy+ejSsg3KIos1pd30muPJ1QWnfYEpzdFQF 9w6rnJ4somWOdFWwf/kyE4FEy+BZ+pseoFiKxZ2THExjY7t7npLO46qZrR3rtxhHoPm6 uvANzgb//LR+wVrvw4q6/S6zcci+UCN+W8s1I+EZKJeyPn4yK9nNGAHRGsVQsbVWYV6B IKpCVDtAAz3R+fDhDArxZdv2O1gn+9PcgbLaWUwZXHufBy2wFoHbyJoq37NqNBJHhp52 CcbA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h3-20020a17090619c300b00992e90ca00dsi18755ejd.16.2023.08.03.09.01.07; Thu, 03 Aug 2023 09:01:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235924AbjHCOqS (ORCPT + 99 others); Thu, 3 Aug 2023 10:46:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235304AbjHCOqO (ORCPT ); Thu, 3 Aug 2023 10:46:14 -0400 Received: from bg4.exmail.qq.com (bg4.exmail.qq.com [43.154.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5DB71BC3; Thu, 3 Aug 2023 07:46:09 -0700 (PDT) X-QQ-mid: bizesmtp88t1691073958thq43qfz Received: from linux-lab-host.localdomain ( [116.30.131.233]) by bizesmtp.qq.com (ESMTP) with id ; Thu, 03 Aug 2023 22:45:57 +0800 (CST) X-QQ-SSF: 01200000000000E0X000000A0000000 X-QQ-FEAT: kUim6XnhvqW9dcd6EzLklGa12GVbNXdonLh2Hg+1w3dBPk/x2b5VmNG+MPDn6 PEFmwIR3cWR5MbUVbtIZAVws1QPogU+mUqaPc8Z5UL+wjlb/HxUYHDFDvWxvxrn7beB6YEn BJDzwZdTbH+Pnq0s4jmy5USrmMOGCTiHxvHBDfw/upU5HD5rm6FNcWY2ldr2xYwhSoB3WBs PydhNf4Gm9/FF4g1QfFcGO6D/1kY4BgUZfzgZOoFzKDqyTLkcYjUwBmT0W+0+t3inyNao0z f/vv2iK7gyd6zVCAbhLmVK+KbTNnHyFRBSR3I1RimV2DcL7oRA9h0E+76pdW21iRRQWUVYs X2PNNE2eNamVHpyeMuQ3SnFchCFW33O5RCRXPS9FqjSIWkh1GgEQMKggZnremX9J5q+j9qf pKTbbIaUw/s= X-QQ-GoodBg: 0 X-BIZMAIL-ID: 2311120515883083357 From: Zhangjin Wu To: thomas@t-8ch.de, w@1wt.eu Cc: falcon@tinylab.org, arnd@arndb.de, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, tanyuan@tinylab.org Subject: [PATCH v1 2/3] selftests/nolibc: fix up O= option support Date: Thu, 3 Aug 2023 22:45:52 +0800 Message-Id: <759307255e4ca3b37b67321d333967a21122c422.1691073180.git.falcon@tinylab.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:tinylab.org:qybglogicsvrgz:qybglogicsvrgz5a-1 X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773224323075391188 X-GMAIL-MSGID: 1773224323075391188 To avoid pollute the source code tree and avoid mrproper for every architecture switch, the O= argument must be supported. Both IMAGE and .config are from the building directory, let's use objtree instead of srctree for them. If no O= option specified, means building kernel in source code tree, objtree should be srctree in such case. Suggested-by: Willy Tarreau Link: https://lore.kernel.org/lkml/ZK0AB1OXH1s2xYsh@1wt.eu/ Signed-off-by: Zhangjin Wu --- tools/testing/selftests/nolibc/Makefile | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/nolibc/Makefile b/tools/testing/selftests/nolibc/Makefile index 51fef5e6a152..af590aee063a 100644 --- a/tools/testing/selftests/nolibc/Makefile +++ b/tools/testing/selftests/nolibc/Makefile @@ -9,6 +9,9 @@ ifeq ($(srctree),) srctree := $(patsubst %/tools/testing/selftests/,%,$(dir $(CURDIR))) endif +# add objtree for O= argument, required by IMAGE and .config +objtree ?= $(srctree) + ifeq ($(ARCH),) include $(srctree)/scripts/subarch.include ARCH = $(SUBARCH) @@ -217,12 +220,12 @@ kernel: initramfs # run the tests after building the kernel run: kernel - $(Q)qemu-system-$(QEMU_ARCH) -display none -no-reboot -kernel "$(srctree)/$(IMAGE)" -serial stdio $(QEMU_ARGS) > "$(CURDIR)/run.out" + $(Q)qemu-system-$(QEMU_ARCH) -display none -no-reboot -kernel "$(objtree)/$(IMAGE)" -serial stdio $(QEMU_ARGS) > "$(CURDIR)/run.out" $(Q)$(REPORT) $(CURDIR)/run.out # re-run the tests from an existing kernel rerun: - $(Q)qemu-system-$(QEMU_ARCH) -display none -no-reboot -kernel "$(srctree)/$(IMAGE)" -serial stdio $(QEMU_ARGS) > "$(CURDIR)/run.out" + $(Q)qemu-system-$(QEMU_ARCH) -display none -no-reboot -kernel "$(objtree)/$(IMAGE)" -serial stdio $(QEMU_ARGS) > "$(CURDIR)/run.out" $(Q)$(REPORT) $(CURDIR)/run.out # report with existing test log From patchwork Thu Aug 3 14:47:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Zhangjin Wu X-Patchwork-Id: 130685 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp1217994vqx; Thu, 3 Aug 2023 08:15:50 -0700 (PDT) X-Google-Smtp-Source: APBJJlFm8vj+XOYjAjJFQkg24DV+Wr6OIRuSIIJAKf2DXol++43bXBGeT4eDm9jqKc1r8vRcNgzF X-Received: by 2002:a17:906:18b1:b0:970:71c:df58 with SMTP id c17-20020a17090618b100b00970071cdf58mr6562117ejf.42.1691075749857; Thu, 03 Aug 2023 08:15:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691075749; cv=none; d=google.com; s=arc-20160816; b=DiozS70ZbXKKLQHW1lMavhLCue5hhGBK3QUkwFYDZ081lsuvP18sL1CcyS3hBOGW5u VsJX12ella43mIBsbD60a48Pz2xK85+KLh+pIoEGDdti7QlXqxS4uMSGNr3CQh49HC6z Y8eSgGGBNy9UGD9DJQgKCPjhbfIbYrH5tmXW14uzfzYAKhfoLOvCt3kAb+eyZ2Ds2uII linvWtNVENpskFus/FqIIZWCVP3uKZQVAca4OA1eOlRo3V0kqctbVXRBSbAdn9KlviV7 dNibs3C3uUVKN1jieqIFgw5NtWkuJHW3O6YJK1G6T6M+LPjN/FCnwEeDyTbcwlOynH7t oa0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=ILOHCNzNBBkYKpEbkk9GIDEnfu4YmboN1NtOd42o4Vc=; fh=TsKNe/ZSymFDLfCGQokP79s6S6Z9FKHYw1KoAUSYM0Y=; b=kcxDQ3gWqkfX2MWH0+A09ux8eUrpnIuKWpD7T+hSvgcRE+6LTWIN3KlKJWXSQkpwto 8Y1+J5UMXKnbLxBlFylIG1uQAXCtyWshMPV4GZ5rVGf8Etr70SbGt5I9FHxFbkuXZhZY ovKpguepRexZ1XboVRNG9h/vSoRT0yb7Wc4f6tXlATLHXpvLJdM6PzwvuKc8Y8L1gj90 Yemg9ndTRTcEFrLt/40EnYu3Ujd7K0Zf/Z7rOvTX81N9MxSIVvhCH5BIiGCK7hGKpnkz 8VgCFxb7CVkcQvQrdvzThS6mOFEUdOhDx5gNgbMOlFEol3UcopEO0jkeIgaNtRTu9p+2 0Wrg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qt8-20020a170906ece800b0099ba1cf9543si1354665ejb.460.2023.08.03.08.15.23; Thu, 03 Aug 2023 08:15:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234622AbjHCOrm (ORCPT + 99 others); Thu, 3 Aug 2023 10:47:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235671AbjHCOrh (ORCPT ); Thu, 3 Aug 2023 10:47:37 -0400 Received: from bg4.exmail.qq.com (bg4.exmail.qq.com [43.154.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E93C1BE4; Thu, 3 Aug 2023 07:47:15 -0700 (PDT) X-QQ-mid: bizesmtp78t1691074025tkmonxr9 Received: from linux-lab-host.localdomain ( [116.30.131.233]) by bizesmtp.qq.com (ESMTP) with id ; Thu, 03 Aug 2023 22:47:04 +0800 (CST) X-QQ-SSF: 01200000000000E0X000000A0000000 X-QQ-FEAT: EKa9/5zJOSjEdzda4qaDuVCtg7Ilp8g7uMOnt2Znfu3gOhN23U58dt8i2H0rQ wL7+pkiMzvAKuxsqW+rE00MFBYMdyTnHePlHshxwQ/zl6vI/IyQEfs3kKI6VG8Pff13TJaR u6BakN1cnrbLslooXXrsyYGIH3Rm+CWvRrE+96D7kdTdSW2e/5zi4nLM1QZ4PKmo3kMkX8B nQH69mtUKZEDlygzHvq2A0U2IDAC3ah9yya5qGoNb4Iw0+zV76LxZvO71ZhHTIIWBMMFrwM GTpRKl1iVuvFCe24lsUjoJj4X7KgSO7qiaYw/6yt/R4BHwq8FCFA+YyRtEMi7qCfrzh0yTd LyIg4XeReqzeXtfo1EZnnMMpLDvrtk8KXiZLihozj35AoYe6/sApd8Ipv+6xpiBeRtF4nU6 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 9459210872236914971 From: Zhangjin Wu To: thomas@t-8ch.de, w@1wt.eu Cc: falcon@tinylab.org, arnd@arndb.de, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, tanyuan@tinylab.org Subject: [PATCH v1 3/3] tools/nolibc: stackprotector.h: make __stack_chk_init static Date: Thu, 3 Aug 2023 22:47:01 +0800 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:tinylab.org:qybglogicsvrgz:qybglogicsvrgz5a-1 X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773221445033578732 X-GMAIL-MSGID: 1773221445033578732 This allows to generate smaller text/data/dec size. As the _start_c() function added by crt.h, __stack_chk_init() is called from _start_c() instead of the assembly _start. So, it is able to mark it with static now. Signed-off-by: Zhangjin Wu Reviewed-by: Thomas Weißschuh --- tools/include/nolibc/crt.h | 2 +- tools/include/nolibc/stackprotector.h | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/tools/include/nolibc/crt.h b/tools/include/nolibc/crt.h index 32e128b0fb62..a5f33fef1672 100644 --- a/tools/include/nolibc/crt.h +++ b/tools/include/nolibc/crt.h @@ -10,7 +10,7 @@ char **environ __attribute__((weak)); const unsigned long *_auxv __attribute__((weak)); -void __stack_chk_init(void); +static void __stack_chk_init(void); static void exit(int); void _start_c(long *sp) diff --git a/tools/include/nolibc/stackprotector.h b/tools/include/nolibc/stackprotector.h index b620f2b9578d..13f1d0e60387 100644 --- a/tools/include/nolibc/stackprotector.h +++ b/tools/include/nolibc/stackprotector.h @@ -37,8 +37,7 @@ void __stack_chk_fail_local(void) __attribute__((weak,section(".data.nolibc_stack_chk"))) uintptr_t __stack_chk_guard; -__attribute__((weak,section(".text.nolibc_stack_chk"))) __no_stack_protector -void __stack_chk_init(void) +static __no_stack_protector void __stack_chk_init(void) { my_syscall3(__NR_getrandom, &__stack_chk_guard, sizeof(__stack_chk_guard), 0); /* a bit more randomness in case getrandom() fails, ensure the guard is never 0 */ @@ -46,7 +45,7 @@ void __stack_chk_init(void) __stack_chk_guard ^= (uintptr_t) &__stack_chk_guard; } #else /* !defined(_NOLIBC_STACKPROTECTOR) */ -__inline__ void __stack_chk_init(void) {} +static void __stack_chk_init(void) {} #endif /* defined(_NOLIBC_STACKPROTECTOR) */ #endif /* _NOLIBC_STACKPROTECTOR_H */