From patchwork Thu Aug 3 11:46:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 130510 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp1088747vqx; Thu, 3 Aug 2023 04:47:03 -0700 (PDT) X-Google-Smtp-Source: APBJJlHnJV146ZHMdHoMqaqj8qLM1miTC2HYjBYEeMVww3QLxigrTcHIjFrXl1Fup0icJ7h/+dsk X-Received: by 2002:a17:907:7745:b0:993:d536:3cb8 with SMTP id kx5-20020a170907774500b00993d5363cb8mr7202041ejc.2.1691063222889; Thu, 03 Aug 2023 04:47:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691063222; cv=none; d=google.com; s=arc-20160816; b=tRPCivpnUxYFIrAnG635k2BNrjQZd+T2S8tT2fAtxFCvk1H5X5QDNuULpZW+8qKSnK Y72hLn80PfFIq5qByayyZ4XdZPIoHECXV4l6d4einSbuMkxwljbI/7rtX3QrzWh7Wh1P kMsqvG70EDvkbkoGFnSQK5uotqhAyEvXbSeNceXHltCnGtj/No24woJ0cHJV3bjH3JvA w2X3q5W2aYz63//s5TthsHxRff8xdSRiLIcScV3KoQB/eY2KNCLP7wC3vbxgv1jrlzUO P8JauC5vZbWFPNTe3ttFGZhxkXyE/OkDNYLxsElrxQWe/pzzU13O7iFhlmKxj29gzSoB xHQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=9JFhfw6+2d1szxLlv3eJV643k/PD7eEjAUoo1PNun1Y=; fh=HNIqzTA9Dp00ovCAyCdXfuEvWDT00OlFxFRPLybXRis=; b=k74WOJmq0iHT+6++j8xt59p3a8eH13lLwE0EvOhkOkpUE2SNGE8mArOGRoWfP5X2th qycD3BOA3FIQXrc5ATBiXvtlRdIpOfFoxQwQ7OdHLk4kEp6V0I6hz3Nm9Ihm2vIJgz1Y 9+qcixz2a7Ucx8Y2RzXW23OSTV1paqnOWu1laG+Zr3rZjv2ZkWvQpWrnk+getQtTMKvj sga8uIYLeJQQUFtqbCsmQwKAwPsvvWAVB7l7UJ9R47tOTDGh7Dlx2KrKF+F/QR72cmH4 mr9wTVDzjg7tBYYLwJ+3elII1EPChB3QqmmzZocLqGxPxNtSU1SgQHZLcR26UnFwCu51 AuZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=LdK7EjpX; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id b6-20020a170906d10600b0099b445b4f45si7688366ejz.389.2023.08.03.04.47.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 04:47:02 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=LdK7EjpX; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 72873385DC07 for ; Thu, 3 Aug 2023 11:46:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 72873385DC07 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1691063176; bh=9JFhfw6+2d1szxLlv3eJV643k/PD7eEjAUoo1PNun1Y=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=LdK7EjpXR8mqWAXB8TBgMV/Lq9+AvPJ7VmAW4iU2H7XK2RMsVpVTOMoSfxOeUp2JN PlyFyDhc4aKRpDXMrS0jJuIQpUXCjQVaFdSfrDO2cCkR9DE8lK38mO/tS1XffcVT1A aiuMmNikJwYsrpHeD0s8oDBbJSOtj4mS6cbUmxro= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 0773E3857346 for ; Thu, 3 Aug 2023 11:46:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0773E3857346 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1b8b4749013so7521095ad.2 for ; Thu, 03 Aug 2023 04:46:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691063167; x=1691667967; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9JFhfw6+2d1szxLlv3eJV643k/PD7eEjAUoo1PNun1Y=; b=hkfwGqOKOHp2iHo3ZnG6h/FOweBOWv9gBcf9tew1vZB4F55Fle5+xU9Lp0DqMmAdLL q13cyJyvU2L9kc4cgje9HtZW+mZLbWYYrp/DGmNcgVpmRw3ISJfDdIuHZugqTDRFnQNY pn6u0EWRR5rJNqIKwNE1OBoE/LOp0XyypqkB5Y2rkQ1OHmoPD7R+ctrwCHa/deDv4LV2 viEGpyI9wKzhvwZV3RbfqCiza3kEYK26HRtI6326sAK+6ipa3X9Q1GUKfA6ifnZuSQvi c0ONzsiHqDL3xijbcmhpR2gvmuJtyHjSgtjVItH91lQehyANWLESwI6knzB7zLvFDvbn 6jCQ== X-Gm-Message-State: ABy/qLbddtx7S9TdmUOLYoaKVBOhd+ywx4fmH7GWstIztXeWKiBP8a17 gBCen3+MN8vlFr82w2jueB5vSRQFTs4= X-Received: by 2002:a17:902:db08:b0:1b0:4205:8501 with SMTP id m8-20020a170902db0800b001b042058501mr23044243plx.6.1691063166669; Thu, 03 Aug 2023 04:46:06 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:a029:aaba:dbee:92cb]) by smtp.gmail.com with ESMTPSA id b11-20020a170903228b00b001bbb7af4963sm14190005plh.68.2023.08.03.04.46.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 04:46:06 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id D7A3611427AD; Thu, 3 Aug 2023 21:16:03 +0930 (ACST) Date: Thu, 3 Aug 2023 21:16:03 +0930 To: binutils@sourceware.org Subject: xtensa: sprintf sanitizer null destination pointer Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3033.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773208309906061380 X-GMAIL-MSGID: 1773208309906061380 * config/tc-xtensa.c (xtensa_add_config_info): Use auto buffer rather than malloc. Use sprintf return value. diff --git a/gas/config/tc-xtensa.c b/gas/config/tc-xtensa.c index fd3ed067659..025376be9a9 100644 --- a/gas/config/tc-xtensa.c +++ b/gas/config/tc-xtensa.c @@ -8979,16 +8979,15 @@ static void xtensa_add_config_info (void) { asection *info_sec; - char *data, *p; + char data[100]; + char *p; int sz; info_sec = subseg_new (".xtensa.info", 0); bfd_set_section_flags (info_sec, SEC_HAS_CONTENTS | SEC_READONLY); - data = XNEWVEC (char, 100); - sprintf (data, "USE_ABSOLUTE_LITERALS=%d\nABI=%d\n", - XSHAL_USE_ABSOLUTE_LITERALS, xtensa_abi_choice ()); - sz = strlen (data) + 1; + sz = 1 + sprintf (data, "USE_ABSOLUTE_LITERALS=%d\nABI=%d\n", + XSHAL_USE_ABSOLUTE_LITERALS, xtensa_abi_choice ()); /* Add enough null terminators to pad to a word boundary. */ do @@ -9015,8 +9014,6 @@ xtensa_add_config_info (void) /* Finally, write the descriptor. */ p = frag_more (sz); memcpy (p, data, sz); - - free (data); }