From patchwork Wed Nov 2 08:01:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jojo R X-Patchwork-Id: 14069 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp3473246wru; Wed, 2 Nov 2022 01:01:32 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5Ogzr1EXHZPN8gluWs3UoWOtLuFufK/yuHA/bgYOEHxxn2EUwZb3h6cPvW4iW3n0oWaIjK X-Received: by 2002:a17:906:444d:b0:7ad:eb7f:8697 with SMTP id i13-20020a170906444d00b007adeb7f8697mr7338000ejp.770.1667376092723; Wed, 02 Nov 2022 01:01:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667376092; cv=none; d=google.com; s=arc-20160816; b=i7nmv/PijIcGwjj+8PFBvol+kqODg1AVDwZfZTm95azltgayBEdWpcpCPFTDPsyoBI IFJGP17HhUdJ1pgFLXMjHSvLabeMQH+uaRSVQuopko56/SsK2jWC5wx1SLvY4j+MIedv zywaGoEFTFCfE/Kvr0uEPYzGcVILW7/kFpUbNaguf/WktkT2chLtdTln+LSNeNvE2f7J TOIzFj3HwI+qxmI5QgowpSu4ePXmFiIWLgtZWC2K5Z/s1lQ72msKGY+1R4XW6fiP8GmM IaOwQs+F5AK9cnJLrqSBIl/aCTXqmlmyAnRhGxY54X8KE+I+guUhElQdR5OBVQvsCKel TuKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=BCYbDZVrDtoFMkuaD1lJ/PD97DfiF/QHr/0e34A0Kl0=; b=ZqdSfmBpYvcYduwXFLLSx5+sNr1+wDyLFWyIHcmaoJaNZKeu4zl6obNNhXCsXSN1zO /ADbr/gSDqSbaEgbO1M5cPpunprEa9SPY3gCncksdVNvgGhr8pcQrw5K5oIz6Z0Sh9FN ZZQ2zSMzsnl3JrFc8MFO1hx9W2r4bMl3g+JTBwOzR5sLKaRemYO2+ginIrpv/k+7J1Rw AVnVHmw2ms0cBn12bGc5aV74d/2L5/MQIfdrb5WBwVKgQVjwdEaMYQYxumP3jvs1Am86 JyUQ5ATby2nkr19tqp5uGYh6tEmddtvefHOCQzOQ9VPo6F/ueVluJUaWub1lKTdX7Dny 1gTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=lBl3ia4Z; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id f15-20020a50fe0f000000b0045cdea002e4si12621140edt.66.2022.11.02.01.01.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 01:01:32 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=lBl3ia4Z; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B6BF638582B6 for ; Wed, 2 Nov 2022 08:01:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B6BF638582B6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1667376091; bh=BCYbDZVrDtoFMkuaD1lJ/PD97DfiF/QHr/0e34A0Kl0=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=lBl3ia4ZiqtjkJKzKszK3tL93i8A3wDqUTV+9vb8MfrF4XoFJA0w3yXWnq/89aUL0 43QlPq3A73bm7r0IkUx3ThE7qJ0pXjAgQZaZXB8kwlvTgXCe7VRXqI1Y3UrkXSPEcq NnLyOITmzIlXJuZ0GmBouhSEbxG4PHcw2d6nuV6o= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by sourceware.org (Postfix) with ESMTPS id 3C9A63858C54 for ; Wed, 2 Nov 2022 08:01:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3C9A63858C54 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R861e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=ay29a033018045176; MF=rjiejie@linux.alibaba.com; NM=1; PH=DS; RN=3; SR=0; TI=SMTPD_---0VTn4Xle_1667376075; Received: from localhost(mailfrom:rjiejie@linux.alibaba.com fp:SMTPD_---0VTn4Xle_1667376075) by smtp.aliyun-inc.com; Wed, 02 Nov 2022 16:01:16 +0800 To: nickc@redhat.com, rjiejie@linux.alibaba.com, binutils@sourceware.org Subject: [PATCH v2] Support multiple .eh_frame sections Date: Wed, 2 Nov 2022 16:01:12 +0800 Message-Id: <20221102080112.33378-1-rjiejie@linux.alibaba.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20220729074837.82957-1-rjiejie@linux.alibaba.com> References: <20220729074837.82957-1-rjiejie@linux.alibaba.com> MIME-Version: 1.0 X-Spam-Status: No, score=-19.0 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, UNPARSEABLE_RELAY, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jojo R via Binutils From: Jojo R Reply-To: Jojo R Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748370553763802186?= X-GMAIL-MSGID: =?utf-8?q?1748370553763802186?= This patch is based on MULTIPLE_FRAME_SECTIONS and EH_FRAME_LINKONCE, it allows backend to enable this feature and use '--gc-sections' simply. * gas/dw2gencfi.h (TARGET_MULTIPLE_EH_FRAME_SECTIONS): New. (MULTIPLE_FRAME_SECTIONS): Add TARGET_MULTIPLE_EH_FRAME_SECTIONS. * gas/dw2gencfi.c (EH_FRAME_LINKONCE): Add TARGET_MULTIPLE_EH_FRAME_SECTIONS. (is_now_linkonce_segment): Likewise. (get_cfi_seg): Create relocation info between .eh_frame.* and .text.* section. * bfd/elf-bfd.h (elf_backend_can_make_multiple_eh_frame): New. * bfd/elfxx-target.h (elf_backend_can_make_multiple_eh_frame): Likewise. * bfd/elflink.c (_bfd_elf_default_action_discarded): Add checking for elf_backend_can_make_multiple_eh_frame. --- bfd/elf-bfd.h | 3 +++ bfd/elflink.c | 7 +++++++ bfd/elfxx-target.h | 4 ++++ gas/doc/internals.texi | 4 ++++ gas/dw2gencfi.c | 27 +++++++++++++++++++++++++-- gas/dw2gencfi.h | 7 ++++++- 6 files changed, 49 insertions(+), 3 deletions(-) diff --git a/bfd/elf-bfd.h b/bfd/elf-bfd.h index f00f87b2779..fa4b9bcf193 100644 --- a/bfd/elf-bfd.h +++ b/bfd/elf-bfd.h @@ -1432,6 +1432,9 @@ struct elf_backend_data bool (*elf_backend_can_make_lsda_relative_eh_frame) (bfd *, struct bfd_link_info *, asection *); + /* Tell linker to support multiple eh_frame sections. */ + bool elf_backend_can_make_multiple_eh_frame; + /* This function returns an encoding after computing the encoded value (and storing it in ENCODED) for the given OFFSET into OSEC, to be stored in at LOC_OFFSET into the LOC_SEC input section. diff --git a/bfd/elflink.c b/bfd/elflink.c index 89dcf26108c..b2ad374c85d 100644 --- a/bfd/elflink.c +++ b/bfd/elflink.c @@ -10924,6 +10924,13 @@ elf_section_ignore_discarded_relocs (asection *sec) unsigned int _bfd_elf_default_action_discarded (asection *sec) { + const struct elf_backend_data *bed; + bed = get_elf_backend_data (sec->owner); + + if (bed->elf_backend_can_make_multiple_eh_frame + && strncmp (sec->name, ".eh_frame.", 10) == 0) + return 0; + if (sec->flags & SEC_DEBUGGING) return PRETEND; diff --git a/bfd/elfxx-target.h b/bfd/elfxx-target.h index ca600bb5ddf..f39244e7f52 100644 --- a/bfd/elfxx-target.h +++ b/bfd/elfxx-target.h @@ -658,6 +658,9 @@ #ifndef elf_backend_can_make_lsda_relative_eh_frame #define elf_backend_can_make_lsda_relative_eh_frame _bfd_elf_can_make_relative #endif +#ifndef elf_backend_can_make_multiple_eh_frame +#define elf_backend_can_make_multiple_eh_frame 0 +#endif #ifndef elf_backend_encode_eh_address #define elf_backend_encode_eh_address _bfd_elf_encode_eh_address #endif @@ -891,6 +894,7 @@ static const struct elf_backend_data elfNN_bed = elf_backend_eh_frame_address_size, elf_backend_can_make_relative_eh_frame, elf_backend_can_make_lsda_relative_eh_frame, + elf_backend_can_make_multiple_eh_frame, elf_backend_encode_eh_address, elf_backend_write_section, elf_backend_elfsym_local_is_section, diff --git a/gas/doc/internals.texi b/gas/doc/internals.texi index a91d2ab9c1e..f0288746d78 100644 --- a/gas/doc/internals.texi +++ b/gas/doc/internals.texi @@ -1581,6 +1581,10 @@ If defined, GAS will check this macro before performing any optimizations on the DWARF call frame debug information that is emitted. Targets which implement link time relaxation may need to define this macro and set it to zero if it is possible to change the size of a function's prologue. + +@item TARGET_MULTIPLE_EH_FRAME_SECTIONS +If defined, GAS will create multiple .eh_frame.* sections according to +the name of owner's function sections. @end table @node Object format backend diff --git a/gas/dw2gencfi.c b/gas/dw2gencfi.c index 6be8cb50495..461ab601321 100644 --- a/gas/dw2gencfi.c +++ b/gas/dw2gencfi.c @@ -75,7 +75,8 @@ # define tc_cfi_endproc(fde) ((void) (fde)) #endif -#define EH_FRAME_LINKONCE (SUPPORT_FRAME_LINKONCE || compact_eh) +#define EH_FRAME_LINKONCE (SUPPORT_FRAME_LINKONCE || compact_eh \ + || TARGET_MULTIPLE_EH_FRAME_SECTIONS) #ifndef DWARF2_FORMAT #define DWARF2_FORMAT(SEC) dwarf2_format_32bit @@ -277,6 +278,9 @@ is_now_linkonce_segment (void) if (compact_eh) return now_seg; + if (TARGET_MULTIPLE_EH_FRAME_SECTIONS) + return now_seg; + if ((bfd_section_flags (now_seg) & (SEC_LINK_ONCE | SEC_LINK_DUPLICATES_DISCARD | SEC_LINK_DUPLICATES_ONE_ONLY | SEC_LINK_DUPLICATES_SAME_SIZE @@ -1333,14 +1337,33 @@ static segT get_cfi_seg (segT cseg, const char *base, flagword flags, int align) { /* Exclude .debug_frame sections for Compact EH. */ - if (SUPPORT_FRAME_LINKONCE || ((flags & SEC_DEBUGGING) == 0 && compact_eh)) + if (SUPPORT_FRAME_LINKONCE || ((flags & SEC_DEBUGGING) == 0 && compact_eh) + || ((flags & SEC_DEBUGGING) == 0 && TARGET_MULTIPLE_EH_FRAME_SECTIONS)) { + segT iseg = cseg; struct dwcfi_seg_list *l; l = dwcfi_hash_find_or_make (cseg, base, flags); cseg = l->seg; subseg_set (cseg, l->subseg); + + if (TARGET_MULTIPLE_EH_FRAME_SECTIONS + && (flags & DWARF2_EH_FRAME_READ_ONLY)) + { + const frchainS *ifrch = seg_info (iseg)->frchainP; + const frchainS *frch = seg_info (cseg)->frchainP; + expressionS exp; + + exp.X_op = O_symbol; + exp.X_add_symbol = (symbolS *) local_symbol_make (cseg->name, cseg, 0, frch->frch_root);; + exp.X_add_number = 0; + subseg_set (iseg, ifrch->frch_subseg); + fix_new_exp (ifrch->frch_root, 0, 0, &exp, 0, BFD_RELOC_NONE); + + /* Restore the original segment info. */ + subseg_set (cseg, l->subseg); + } } else { diff --git a/gas/dw2gencfi.h b/gas/dw2gencfi.h index d570cdb8db3..0f5ae77d800 100644 --- a/gas/dw2gencfi.h +++ b/gas/dw2gencfi.h @@ -66,7 +66,12 @@ extern void cfi_add_CFA_restore_state (void); #define SUPPORT_COMPACT_EH 0 #endif -#define MULTIPLE_FRAME_SECTIONS (SUPPORT_FRAME_LINKONCE || SUPPORT_COMPACT_EH) +#ifndef TARGET_MULTIPLE_EH_FRAME_SECTIONS +#define TARGET_MULTIPLE_EH_FRAME_SECTIONS 0 +#endif + +#define MULTIPLE_FRAME_SECTIONS (SUPPORT_FRAME_LINKONCE || SUPPORT_COMPACT_EH \ + || TARGET_MULTIPLE_EH_FRAME_SECTIONS) struct cfi_insn_data {