From patchwork Thu Aug 3 08:41:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 130439 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp1011845vqx; Thu, 3 Aug 2023 02:07:48 -0700 (PDT) X-Google-Smtp-Source: APBJJlE6A1QFpAWfcIJh+I+eGZsAmfyN0stBPwlgogL/TKemZk7DCT80ZqlIwjiMDvRldX1TK2yD X-Received: by 2002:a17:906:18a1:b0:99b:ca24:ce33 with SMTP id c1-20020a17090618a100b0099bca24ce33mr6306558ejf.31.1691053668294; Thu, 03 Aug 2023 02:07:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691053668; cv=none; d=google.com; s=arc-20160816; b=Q0wRWdg33QHlqlX0d0+gOdENKf3P8j1VXZtZRjIGulbY06PE869uFNAV/S3fNGUNgs 8FsTeoRkRuw1QWwrEXAHaORMxMpdpiNOgH1AoPUnLkK8urTHouZaTg3l1aHNb19wEx0w idnpwqvRJldZnm9Kk5Y3CpjShFBai9f1fEeSVHECeSrVN5Zo5Ky8oDNhQRN5E3lOH2Nk AIT4t66troE04lqsEM9BMfHKxzfckV1ZqdbOEdyul30MGtHn7Fe5innJPavgnUujnMCo aZjLE7zI0Oc0ZXl0IHXHA3bQQ1xUN/F9GzZUodbapGZEZeYXDJLre48OwtglB06jLu+T 3YVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=5W3w+bnoSeWnoRB5HX7OOU4dc/wmeXOpnuvt6gGEqvI=; fh=OqXResVBGmKVif32WrPB9+w/XjWhGxZKnootS83aEBI=; b=S8TEB85ZI4cD+AolLO8VQqV7MqgnnGw0yriWVQ2x8M5o3qXnxdlDt8u4XWtRA9oDtG F1fG0tbk0PJ5jHiV9d+LBj5TtKuv3bq1xVd1g/2zFO1nTNBgd8KHSFN986j/G+I80FqF BHDdr7TU9Q6uhjSZq4JlIpRCSZE+iOUKrbeT0ZFUwQW9RI7PbMyNq3ip0PzvsUmYOHfU CEkHzSbpFyU7CHyG145dQJ4keWOPRkrv4pwbgD4IQCuPfAg1h9yE64XdU0Bu3pR/Pi85 Yh4j7KZ7yTsT2yZg97Vg0nTXwugJSKYxv/Nnj+Wj0BXfav4MA2fUw9E5TzVczodSw74a G9lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=NNB2lcdi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g16-20020a17090613d000b0099367e9043dsi12109179ejc.870.2023.08.03.02.07.23; Thu, 03 Aug 2023 02:07:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=NNB2lcdi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234307AbjHCImJ (ORCPT + 99 others); Thu, 3 Aug 2023 04:42:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233384AbjHCImC (ORCPT ); Thu, 3 Aug 2023 04:42:02 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3EF1E7; Thu, 3 Aug 2023 01:42:00 -0700 (PDT) Received: from [127.0.1.1] (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C6DB4D4A; Thu, 3 Aug 2023 10:40:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1691052055; bh=egXxbNnChhv3B43ArDJxxblwfAW0XcIBDvL/amPdS8M=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=NNB2lcdi4vLXuVOXd5LLJ7Ssv2mzREjUQJH2ZKy7Fkxwl3KuPNRBUYf9DcdFIrKTT VSrEK6bJnZ2TbPntimZthAigsNiFU7SuY56vRsLPEsHq1FmSyWjmnYrGy+G9aAKgIK 5Q2m6mlUNdGjkgunjRKZWqmmidAxJhbw0KTVBRX0= From: Tomi Valkeinen Date: Thu, 03 Aug 2023 11:41:38 +0300 Subject: [PATCH 1/2] media: i2c: ds90ub9x3: Fix use of uninitialized variables MIME-Version: 1.0 Message-Id: <20230803-ub9xx-uninit-vars-v1-1-284a5455260f@ideasonboard.com> References: <20230803-ub9xx-uninit-vars-v1-0-284a5455260f@ideasonboard.com> In-Reply-To: <20230803-ub9xx-uninit-vars-v1-0-284a5455260f@ideasonboard.com> To: Mauro Carvalho Chehab , Laurent Pinchart , Sakari Ailus , Andy Shevchenko , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Tomi Valkeinen X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2315; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=egXxbNnChhv3B43ArDJxxblwfAW0XcIBDvL/amPdS8M=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBky2hVCiT5ZSmCfesqk5bdJbl6+ncGJSNISqvnC mAvQuS3yWWJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZMtoVQAKCRD6PaqMvJYe 9WfED/9GUcDLKyBaAol8r2Z6UJpzboB2urTpc/hF93xBeMK0A9c1nZvCv1B0lIh/IV/Dwbng/C4 eG8U+4xI6npmVdoibnVapQD3dl7pkFWBjYm2MJ+fEC7IwBG4QZgLbS1OwoVSo6KzY3xg2UhxJ4m U505l/sb8Xho/cjvShfuWgkD6YvHkh3HPvKFyOofC7UKTOQBV2P+D4Mjf3MlicLnvgD3q/Rrn5K 1gF4LVj7hLN5hq5sGYlzHnoJCAzf7m+YREAmyEk1lZYUVX2D2Eh4oKnH47XOTiVYr5zMNUuJURq dlUXdRDWIyq9lx2fO7AbDZQYUkUyxaEy/9kI5pbsHAoSG8BfWxNM6CAqytdtOd322zZ1SqyC1gr 1ly1GO+o5fVbGegpNGZy0XigFPT800ihE0m51QOYGUPv59cYbRJbXNo5gbvcw9bd2Q2jbQdlJzq DHBKaCUBnbuhVnDmOiLSAS0cCieymwXf7R+kGUkJ+IRXuFFr2oC1A1p9wJheSxq/hhyZh8Ckp7M XXDT5Dp0G0lGdL3+cIXDIX+AA/NxQmQkptLQU15cMRznhVXshNZ+x26NUqY5+Mk1PLj2Tw9r6hw W7DagvJjgLSjCpt62U3mBZ+J0LvzKy5zUhYV0d9r4qrGGboj3gZf+xNGySI43SWPWWbfDzw46Md 0ia9tPf3IG/KVqw== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773198291134585456 X-GMAIL-MSGID: 1773198291134585456 smatch reports some uninitialized variables: drivers/media/i2c/ds90ub913.c:481 ub913_log_status() error: uninitialized symbol 'v1'. drivers/media/i2c/ds90ub913.c:481 ub913_log_status() error: uninitialized symbol 'v2'. drivers/media/i2c/ds90ub953.c:655 ub953_log_status() error: uninitialized symbol 'gpio_local_data'. drivers/media/i2c/ds90ub953.c:655 ub953_log_status() error: uninitialized symbol 'gpio_input_ctrl'. drivers/media/i2c/ds90ub953.c:655 ub953_log_status() error: uninitialized symbol 'gpio_pin_sts'. These are used only for printing debug information, and the use of an uninitialized variable only happens if an i2c transaction has failed, which will print an error. Thus, fix the errors just by initializing the variables to 0. Fixes: 6363db1c9d45 ("media: i2c: add DS90UB953 driver") Fixes: c158d0d4ff15 ("media: i2c: add DS90UB913 driver") Reported-by: Hans Verkuil Closes: https://lore.kernel.org/all/8d6daeb1-b62a-bbb2-b840-8759c84f2085@xs4all.nl/ Signed-off-by: Tomi Valkeinen --- drivers/media/i2c/ds90ub913.c | 2 +- drivers/media/i2c/ds90ub953.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ds90ub913.c b/drivers/media/i2c/ds90ub913.c index 80d9cf6dd945..b2115e3519e2 100644 --- a/drivers/media/i2c/ds90ub913.c +++ b/drivers/media/i2c/ds90ub913.c @@ -469,7 +469,7 @@ static int ub913_log_status(struct v4l2_subdev *sd) { struct ub913_data *priv = sd_to_ub913(sd); struct device *dev = &priv->client->dev; - u8 v = 0, v1, v2; + u8 v = 0, v1 = 0, v2 = 0; ub913_read(priv, UB913_REG_MODE_SEL, &v); dev_info(dev, "MODE_SEL %#02x\n", v); diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c index cadf75eb0773..27471249a62a 100644 --- a/drivers/media/i2c/ds90ub953.c +++ b/drivers/media/i2c/ds90ub953.c @@ -593,9 +593,9 @@ static int ub953_log_status(struct v4l2_subdev *sd) u8 v = 0, v1 = 0, v2 = 0; unsigned int i; char id[UB953_REG_FPD3_RX_ID_LEN]; - u8 gpio_local_data; - u8 gpio_input_ctrl; - u8 gpio_pin_sts; + u8 gpio_local_data = 0; + u8 gpio_input_ctrl = 0; + u8 gpio_pin_sts = 0; for (i = 0; i < sizeof(id); i++) ub953_read(priv, UB953_REG_FPD3_RX_ID(i), &id[i]); From patchwork Thu Aug 3 08:41:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 130461 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp1060499vqx; Thu, 3 Aug 2023 03:56:15 -0700 (PDT) X-Google-Smtp-Source: APBJJlFqIwpnRSXI0iztS6kS82C7AbS2WY1Yqr3RgqmLMqgS7/n9S9L7AiKuW48npsTsWL+MEo6h X-Received: by 2002:a17:906:3118:b0:99c:40f2:a402 with SMTP id 24-20020a170906311800b0099c40f2a402mr4381504ejx.6.1691060174837; Thu, 03 Aug 2023 03:56:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691060174; cv=none; d=google.com; s=arc-20160816; b=y0pypEoxp0XphPtYEraQwcKBq09PLUWb8wWj5Swo8tUmvCevvtAbKqJe+aubN998TV 0ksm8ekvZvo7tQeFqhtS5T03KPz42HGzx1YMUqY0BqPGmiKK/P/CrU9i8gL3jzVf02ER 67qE+pCLQvpLZTtOB2sEmvhLsmYy/lbSLuTcZh9g5TgLDCquxB/s/kGVkQSs7jqxm/yV iDoWnPKBFHpG89jeX+5zzELL8hJ/EzMRv9gYjZfUA0MGkgT79pJgi8P0+CC0a/zAUq0A 3dghJ5buAjjhpx9VLMM6gE5iG7SiJTUx6WRpM7tjbqdoWiplqkPtu7WgUEqToERWJn42 VeVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=3JHocNfFIvImhguOggnzRsvrPhHlenPNGYaxVMeN9Po=; fh=OqXResVBGmKVif32WrPB9+w/XjWhGxZKnootS83aEBI=; b=k4pxqSgfRjUDS5UWpj2bUPXNfcm+rngDblFgpUNJFW0IYbuZYKXwu83TYGYCt4K7LU jWaVi1LLv7joVhR5qwoKolRQU4YG7EDrrZ+xOHBvF5xLqeOW5Ag199+bNJ45fm9K7a+h zciu3Z4p3jndT5c6vWT47mYlkGjW4lTBGF9VxI3fVkmQ65J0Jurvup9kUcQKHS1cw5h6 AiOYv/kkFbOrstUSnrruJ5Sr1Q0o0ceU6e+yNv2kShuSkWKAjNKElArxfAC4tJiV/tcl ZXsUhORCGFvq68bjrwXFQcovZdMiI0VYitRQ+MCCaO199ZIku+iz7k3FMhyJRF9lIgCu 1yYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=qH1DE64u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cw16-20020a170906c79000b0099bc8c2fbcfsi12625133ejb.718.2023.08.03.03.55.50; Thu, 03 Aug 2023 03:56:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=qH1DE64u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234367AbjHCImM (ORCPT + 99 others); Thu, 3 Aug 2023 04:42:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232768AbjHCImD (ORCPT ); Thu, 3 Aug 2023 04:42:03 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D346DB0; Thu, 3 Aug 2023 01:42:02 -0700 (PDT) Received: from [127.0.1.1] (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7D645EEA; Thu, 3 Aug 2023 10:40:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1691052056; bh=X/zAB0Jj0qtm9fUujGG3j4YnlOSerudhleIY+ZFE7Pk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=qH1DE64u4YxQCM+dwmrEBINgZ/TmMqlH24BICuVvHn12qvLSOxkSGGIqR9Yglz8vS Sdrq0EeescYNU2YxfqFdqhoSWg74ap6eSCvglBOzdxUjkFozQmtRCwJoDfCYGoXr4b TkzgtFHLBERyr29hO43Bv94Q1EDORIDSLshTqyg4= From: Tomi Valkeinen Date: Thu, 03 Aug 2023 11:41:39 +0300 Subject: [PATCH 2/2] media: i2c: ds90ub960: Fix PLL config for 1200 MHz CSI rate MIME-Version: 1.0 Message-Id: <20230803-ub9xx-uninit-vars-v1-2-284a5455260f@ideasonboard.com> References: <20230803-ub9xx-uninit-vars-v1-0-284a5455260f@ideasonboard.com> In-Reply-To: <20230803-ub9xx-uninit-vars-v1-0-284a5455260f@ideasonboard.com> To: Mauro Carvalho Chehab , Laurent Pinchart , Sakari Ailus , Andy Shevchenko , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Tomi Valkeinen X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=958; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=X/zAB0Jj0qtm9fUujGG3j4YnlOSerudhleIY+ZFE7Pk=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBky2hVH4mzodkwHQDT/qFB0cXR6NAIPQ86YdBFQ KAmu7DI6SqJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZMtoVQAKCRD6PaqMvJYe 9R2BEACAlP22T4NNeiUW0lczthwN5yziGaJMShZlaAoa/AvhqHDrFqEAMBQVNj40TgcWmf4nZBF 7lG4B1P7tOKiZC+4iDylMUQXCDd0wEqFfuqhvQ00HxLIZfR5gKnZ8CsufqRmY4a4qJZRVd9JAle 3Km9ubgxQOA1hNFk2Cgf0lHT0jn+nNKNk0asKXQ2EYJem+JKfvB5Y/C2jKhR3/h++R1hdXcPeg6 7aHc30rZ6IJ/Rllijgp8kCRXSm2HZzfj5rPM2a6SecNBQyyy5xBQRWUlS/wTRKtoOS64Ovzgsbd WRQtoUyfafxDLO4zQ+tt06K7+IIghRS2G7cYqQY3YswpZ7fXt42LXdBvhF/zYhKZIBGRgh1umAs PuLAjcldLmgeJx6AsIXu3cJj59HzmHzjLthzr+bRp3KvF6MLaWZJ9nAPDGQtyC0MS9AOFQEHqi3 lliSJ9jLgmiH6chImqyIcf0LRoDan5m99d3FUuuOvm3tJCagC8Jf7kRwSyUGeEomIYvYTyl4j89 Bk3JRvVBsw39SfBCT47IO2UeX/jIAvJlO0sJVzaf0zn5CwjUqFkPJxiQ51nQog4zU99i4oKFWNe 2KJ5lNJDejaV7C9KEXkBsTiIOiFBYfQnCpb24TJNnuLfDawrKX8cg7iaDfO33mr4g0iXsMTLL9z hdhXW5f7UGYTT8g== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773205113705262102 X-GMAIL-MSGID: 1773205113705262102 smatch reports: drivers/media/i2c/ds90ub960.c:1788 ub960_init_tx_ports() error: uninitialized symbol 'pll_div'. This is caused by 'pll_div' not being set for 1200 MHz CSI rate. Set the 'pll_div' correctly. Fixes: afe267f2d368 ("media: i2c: add DS90UB960 driver") Reported-by: Hans Verkuil Closes: https://lore.kernel.org/all/8d6daeb1-b62a-bbb2-b840-8759c84f2085@xs4all.nl/ Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/media/i2c/ds90ub960.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c index 4833b39b9178..4ab45e326d80 100644 --- a/drivers/media/i2c/ds90ub960.c +++ b/drivers/media/i2c/ds90ub960.c @@ -1763,6 +1763,7 @@ static int ub960_init_tx_ports(struct ub960_data *priv) break; case MHZ(1200): speed_select = 1; + pll_div = 0x18; break; case MHZ(800): speed_select = 2;