From patchwork Wed Aug 2 19:31:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naresh Solanki X-Patchwork-Id: 130129 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp711504vqx; Wed, 2 Aug 2023 13:35:23 -0700 (PDT) X-Google-Smtp-Source: APBJJlFmmZfwn/u3tdm7jkTyD4JHMbvP+k8W3TXAH7mQrlP6lpSMuJkqSqbvumbkho1p+VJ34Jji X-Received: by 2002:a05:6a20:841f:b0:112:cf5:d5cc with SMTP id c31-20020a056a20841f00b001120cf5d5ccmr20140427pzd.1.1691008523182; Wed, 02 Aug 2023 13:35:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691008523; cv=none; d=google.com; s=arc-20160816; b=xcsyIPixyItQw7M4p5f+Q2Z+Caa/nt7pI4uhYb8IrviK4z5PhVG8oePEBWH4KGU2YH rtvR/CQNqoqwxFhS2aIZF72BWmh6TkSJXMC6KSoLO1HGxWsWsvrPYQJQDlbxfpCBDZFz k/EXV+9G81R9LUvg+/RFzWkGFrzecqp25MSV4dnqKNWP4HsuaWYE/NPazETJdMcf4TlS we0qwNhKaHML7WMy3hY1rp9v4wCa12TVxMJx0dFeTXCRxm8t1PZUgsy8GA6fmjGEplrG ZSJutw9GOHo7ksLofGMJHMdz4WskicGeAWkIB6ZoVLQKs9e78tV+zxckKCCq+XgnZsSX AeBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=FG/HvA/ZhPB46DVPJ1FluHZ8X/9xTIstvJa8fWyAL7s=; fh=mFuvIzLWteCW3m+PeZ45FPs/58IIfculf7XGiSFPuc0=; b=ECX9m1k7Lh1rOZWX87hA6ZwUQhMlm8OQqN+aI1t1DK7lUwOOCnQLeo1zz5/kNpv9Fb 5oVBSnDOZCZ7JHFA5ADhMNP8tdeKfZkitFc3Cv1I6Zw183dLDjmJDeJU7ajMRiV47jI5 HDLgRh4Cjfyvf9a7tkyd2wx83ZBal7LyJ6Kp1DrHjPy0908D5RxpkL2rax54t39UH/ev CqNnMfbS9RP6eP8BubPXZ/r8eC09Pq1/ChfSXoGDCXL5ZV5Cr1fAnB7oMdV+XNASlcKr RUIk5nsvsWNt1fEMX6CEza86eHujeMei1TjGo60SqsEpNnsxYTNhlVdq1oPzpMnfj/JU IFyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=aTsL5G7m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h16-20020a633850000000b00563d74b6350si1276431pgn.737.2023.08.02.13.35.07; Wed, 02 Aug 2023 13:35:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=aTsL5G7m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232850AbjHBTcP (ORCPT + 99 others); Wed, 2 Aug 2023 15:32:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232413AbjHBTcM (ORCPT ); Wed, 2 Aug 2023 15:32:12 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86FF01996 for ; Wed, 2 Aug 2023 12:32:09 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3fe32016bc8so2094925e9.1 for ; Wed, 02 Aug 2023 12:32:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1691004728; x=1691609528; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FG/HvA/ZhPB46DVPJ1FluHZ8X/9xTIstvJa8fWyAL7s=; b=aTsL5G7mheOUz7tnXWywhC8ziDCKBSxTb575FaYpQBIM/DZkYwPjCr3TUqQo/D7KjM 681xxo/H2QmzJKKL2zBfZCINoUgHqhhTCuRi/Zn4T2JRCMWoLAJnSSvdCo7qZByXp9S9 ImGdJOfmB2l0dDlVv3aXGZI1ZROQ9TmrkRo/ioe1zJOBuRqKl8cqpwvNQ/ENKNEEptWz X54bIgMBjzQrAdCgDO3MSdlefWZFAzTPfrpqopcUk/fEiQ+AYQ9ka2t+G7h3P+XFqLZT kHE/yTqcMa4lIR1zDqn7JGJc9+G7+ReIXoyDBXgAW9tmPt4ybhXsCOyFsHO/FqOjW65u FWzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691004728; x=1691609528; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FG/HvA/ZhPB46DVPJ1FluHZ8X/9xTIstvJa8fWyAL7s=; b=khrdkJvdI9Sz6PAAxg2X9kVYFYFHKjFOml13AHd7+/lVtU+k1kwwOKF1slZQ1k8O9f VdTUHOJG5/aj4PvyxruTqx8XJ2ijxw4Q+edVjmAeAfp+OCRWlWEEGdecoln9qJ2jpGxk UcNi/pWIom2e2+kpIUPuIyixv+bGmAUEDvqeDZwNSxrflhUDIeBTXvs9SsGIsMpkwDyg MUbj1q0XUg6atHOp6s25Z0sE0SgEgylKYL+1KG+5eQDMu0mWNCzluQhebBiKH5fl+A05 Va5mfAuWp6NiJOBscXT/z7OfMGdJlmRDd67hsDX6qleCXXiYsxz8wOplHssn7yJpsMub dIgA== X-Gm-Message-State: ABy/qLbSmBxBEuvc3QgtoCN8gmeKHEB9685Q0T2Lh9bklhFX+X+1oWfq mvmBqIFxyKxeVomvp0N0cGk7vA== X-Received: by 2002:a05:6000:152:b0:314:5376:f0d6 with SMTP id r18-20020a056000015200b003145376f0d6mr5372863wrx.52.1691004727865; Wed, 02 Aug 2023 12:32:07 -0700 (PDT) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id v18-20020a5d43d2000000b003177074f830sm19666773wrr.59.2023.08.02.12.32.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 12:32:07 -0700 (PDT) From: Naresh Solanki X-Google-Original-From: Naresh Solanki To: Guenter Roeck , Jean Delvare , krzysztof.kozlowski+dt@linaro.org, Rob Herring , Conor Dooley , Naresh Solanki Cc: linux-hwmon@vger.kernel.org, Patrick Rudolph , Naresh Solanki , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/3] dt-bindings: hwmon: Add Infineon TDA38640 Date: Wed, 2 Aug 2023 21:31:51 +0200 Message-ID: <20230802193155.2170935-1-Naresh.Solanki@9elements.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773150953153729054 X-GMAIL-MSGID: 1773150953153729054 From: Patrick Rudolph The TDA38640 chip has different output control mechanisms depending on its mode of operation. When the chip is in SVID mode, only hardware-based output control is supported via ENABLE pin. However, when it operates in PMBus mode, software control works perfectly. To enable software control as a workaround in SVID mode, add the DT property 'infineon,en-svid-control'. This property will enable the workaround, which utilizes ENABLE pin polarity flipping for output when the chip is in SVID mode. Signed-off-by: Patrick Rudolph Signed-off-by: Naresh Solanki --- .../hwmon/pmbus/infineon,tda38640.yaml | 51 +++++++++++++++++++ .../devicetree/bindings/trivial-devices.yaml | 2 - 2 files changed, 51 insertions(+), 2 deletions(-) create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml base-commit: cb7022b8976e3c4d12cea2e7bb820a2944e2fd7b diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml new file mode 100644 index 000000000000..c5924ddf1b47 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- + +$id: http://devicetree.org/schemas/hwmon/pmbus/infineon,tda38640.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Infineon TDA38640 Synchronous Buck Regulator with SVID and I2C + +maintainers: + - Naresh Solanki + +description: | + The Infineon TDA38640 is a 40A Single-voltage Synchronous Buck + Regulator with SVID and I2C designed for Industrial use. + + Datasheet: https://www.infineon.com/dgdl/Infineon-TDA38640-0000-DataSheet-v02_04-EN.pdf?fileId=8ac78c8c80027ecd018042f2337f00c9 + +properties: + compatible: + enum: + - infineon,tda38640 + + reg: + maxItems: 1 + + infineon,en-svid-control: + description: | + When enabled, it allows the chip to utilize workaround for + software control of output when operating in SVID mode where + hardware-based output control is the default behavior. + type: boolean + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + tda38640@40 { + compatible = "infineon,tda38640"; + reg = <0x40>; + }; + }; + diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index 40bc475ee7e1..86c7d34f63bf 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -151,8 +151,6 @@ properties: - infineon,slb9645tt # Infineon SLB9673 I2C TPM 2.0 - infineon,slb9673 - # Infineon TDA38640 Voltage Regulator - - infineon,tda38640 # Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor - infineon,tlv493d-a1b6 # Infineon Multi-phase Digital VR Controller xdpe11280 From patchwork Wed Aug 2 19:31:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naresh Solanki X-Patchwork-Id: 130122 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp694623vqx; Wed, 2 Aug 2023 13:02:01 -0700 (PDT) X-Google-Smtp-Source: APBJJlERCLKKwttQ7aG+RBSncEDt+rqRp8Awhs7Ixgo/EnOfXoW34YhGDrrq7P5ATpJI2GAsIrnb X-Received: by 2002:a17:90b:1116:b0:25c:8b5e:814 with SMTP id gi22-20020a17090b111600b0025c8b5e0814mr15358698pjb.44.1691006520791; Wed, 02 Aug 2023 13:02:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691006520; cv=none; d=google.com; s=arc-20160816; b=gcmi+tC+m58IEef6Jp79sDNUZAgf7Zg51I8wfTQWo7UwDdO8SbcIHK380tt8pBrUyl mDNTFGNejCR5ZhbI1Vp8/fvl8a9lLtlddrSDTrADiLXQPAWd30U/unMJiphJbvvsuPkG yseqWcbywRaqG8c/64VvGjnmAfMWf7UmIS+6UeB7GTCPZNXsaZIHsLPpY7e9yinft1HU KezULjC3gSSUPIeRa0zTmtmTRdINrBcdcJyYttPPR/jsh96Iv+A4KKsNqBBTBCcBBC1F yNF1ymRYu61ToLb+XiHLNPdluhjqBBoO2o6BqK2XpBwTKl/AyKumuz7ulXiiAG5gsx4C xJQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4EsAms/GBsK+1iUec9cOrJls/H2UjnYhAk3txEAwGRk=; fh=/6OmkISz2jasWA5ktD7Ct/RQ5jfIZG0BSS+/WFT7oFk=; b=jhn1ap+Rc7pW9IJecoFHBq3wlP6pYqvvVWfuyFor9ocCIyCBWQxCoKzhgorWDDMC5P qkur/Qon5LvhrCrs64URzmyn3ymnUYJc4b97fK7PqKyiioxbL07ORGi3/DIy+DMxHCRa 2QFYhU5zfqOgBPhBbRJ2KysnhqarK3IX30+XQIi/OnhlX4R0X3vyzRfD6ZOB/HXD1Xnt bgbh4L/V77G37uj2y7ghgurPDQlIIvXoJE60xi/8jxOcvh4g21WHYNFTL6ZI/SavkyoQ yzGZ40MsKbRPjXhLwUJDDrmMZG1mJhS0azzQbajooQomoT005Aww7RrmV0uMkEUSgTZa WL4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=edwj5ZoJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mi3-20020a17090b4b4300b00259b2afc651si1688188pjb.62.2023.08.02.13.01.46; Wed, 02 Aug 2023 13:02:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=edwj5ZoJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233191AbjHBTcT (ORCPT + 99 others); Wed, 2 Aug 2023 15:32:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230319AbjHBTcM (ORCPT ); Wed, 2 Aug 2023 15:32:12 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9532A26AF for ; Wed, 2 Aug 2023 12:32:10 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3fbf1b82d9cso2002835e9.2 for ; Wed, 02 Aug 2023 12:32:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1691004729; x=1691609529; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4EsAms/GBsK+1iUec9cOrJls/H2UjnYhAk3txEAwGRk=; b=edwj5ZoJK2mDlEgtJqkJ/LdE4dco1cDR22RFFEgaEqH2xEWa3vDgeZwwqHuKfynDWd CZMBcVzj5hq3971PzjjYTe5iENmfw2OIvTTDTG/GH/u5iRxOj1lxrK2ncXbUXt1AjBZ7 plKxrLw4l5wbr9CNds67+T2rgRLlDNGkonef3XHU6Ipn02jIheM4hPU1cV0B5Kzp4kAj BG+fMx+7e7Lliiw425s8H4zC4cXN98DNhlfe7oeZqyiRUrUesc8Y37ercCaGEYSVHmwy zOdSoNNnxxXROw1SZ4QI2SAQGJDS1sTh554bVaWFKbyN5DrlqfcqqDuLTPGaaJ/k6MML kHMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691004729; x=1691609529; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4EsAms/GBsK+1iUec9cOrJls/H2UjnYhAk3txEAwGRk=; b=B5p/khs+sH/0tkSCUxhOkP3+ihsbCIfkHPQHn6VSIgfX/O5SWfvTM2kwx7vh2gPti3 3oIR1BfjP/dUoXP+3OKQXmkYld3/HGD2WMgq7rEU6RL9hounj2eE7rImAEyD0RbZbM95 C/6pt52sJiFdQ8tTf+4XBhFy8Dcnjzbz3cjeLC/p+UKg7YraPLoNSZ+m0SAIaPD55x1a XMBiGxPcQVoS+8kF2PhWfD4/Y6taZT3PE1VSwzsacMFIbOEe1QGtAub5xaTHI3uCyoFq 7HfF8gANsdn64EBMCDEOxcXeoQqsmUTf/qQYMieV9bGDfDVr4AZj64snG4Fb42YjHV+9 zxnw== X-Gm-Message-State: ABy/qLY6hdAzxFuwYq8LfE0cTSSzbjvsPuS/waF0vV6E2SB1JhomF3AV WJyR1WuKko3o1WM+TUg/+UNWwA== X-Received: by 2002:a7b:cc8c:0:b0:3fe:159d:422b with SMTP id p12-20020a7bcc8c000000b003fe159d422bmr5475260wma.32.1691004729038; Wed, 02 Aug 2023 12:32:09 -0700 (PDT) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id v18-20020a5d43d2000000b003177074f830sm19666773wrr.59.2023.08.02.12.32.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 12:32:08 -0700 (PDT) From: Naresh Solanki X-Google-Original-From: Naresh Solanki To: Guenter Roeck , Jean Delvare , krzysztof.kozlowski+dt@linaro.org Cc: linux-hwmon@vger.kernel.org, Patrick Rudolph , Naresh Solanki , linux-kernel@vger.kernel.org Subject: [PATCH v3 2/3] hwmon: (pmbus) Add ON_OFF_CONFIG register bits Date: Wed, 2 Aug 2023 21:31:52 +0200 Message-ID: <20230802193155.2170935-2-Naresh.Solanki@9elements.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230802193155.2170935-1-Naresh.Solanki@9elements.com> References: <20230802193155.2170935-1-Naresh.Solanki@9elements.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773148853266282276 X-GMAIL-MSGID: 1773148853266282276 From: Patrick Rudolph Add bits found in the ON_OFF_CONFIG register. Signed-off-by: Patrick Rudolph Signed-off-by: Naresh Solanki Reviewed-by: Guenter Roeck --- drivers/hwmon/pmbus/pmbus.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/hwmon/pmbus/pmbus.h b/drivers/hwmon/pmbus/pmbus.h index b0832a4c690d..7a28bac7f171 100644 --- a/drivers/hwmon/pmbus/pmbus.h +++ b/drivers/hwmon/pmbus/pmbus.h @@ -243,6 +243,15 @@ enum pmbus_regs { */ #define PB_OPERATION_CONTROL_ON BIT(7) +/* + * ON_OFF_CONFIG + */ +#define PB_ON_OFF_CONFIG_POWERUP_CONTROL BIT(4) +#define PB_ON_OFF_CONFIG_OPERATION_REQ BIT(3) +#define PB_ON_OFF_CONFIG_EN_PIN_REQ BIT(2) +#define PB_ON_OFF_CONFIG_POLARITY_HIGH BIT(1) +#define PB_ON_OFF_CONFIG_TURN_OFF_FAST BIT(0) + /* * WRITE_PROTECT */ From patchwork Wed Aug 2 19:31:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naresh Solanki X-Patchwork-Id: 130133 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp718354vqx; Wed, 2 Aug 2023 13:51:15 -0700 (PDT) X-Google-Smtp-Source: APBJJlHbmIcqsrVm4ZaRXglq3yyLOyGZVW9VMZFDdV7/ww+KCcTKFKJQzKx9udBKRzwclp9rj5ZV X-Received: by 2002:a05:6a20:9696:b0:138:834:5dc7 with SMTP id hp22-20020a056a20969600b0013808345dc7mr15132691pzc.30.1691009475667; Wed, 02 Aug 2023 13:51:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691009475; cv=none; d=google.com; s=arc-20160816; b=udKwN+aLVir2NnRnBLKYH+5wJM8fv62K1ARbRs6qySyxJt+hCJIM4H8Y5EIIGsj1Lg GPT8AXd0FFzoax7VMViV9oeIa264RzuN2pK3PsnfDQRAkj4xPd4fBNzn6CSzV9kRhl1i GMWcE9Ibw3F1l0XZazEHMnr3BObyfpt8auhPVdoArH/kzNBrQ35nyw2P3v6iyVku8EOs t44dwt8Y43wyt9cd3mkRRyIWeqFM8mf49Tb9brY1ATcLPNDPGGxjD24qGjnzYYp/isHB jaErmyLRW4ckxd9iNnU9Nhh9tJZsaQ5SPfDg45QaU/Bj3GbqWyIh2ErXOZNpyMM1bVHF abNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=MYt9Jjxnfumr5xXWagiHEc6kz+KL1UN3g0bRxIEi7bI=; fh=/6OmkISz2jasWA5ktD7Ct/RQ5jfIZG0BSS+/WFT7oFk=; b=iAJSjF41JuCgO7XJ3bXQeLsXf6RIFFZJMCEUiabmRVVEoZm18UqUI/LuNjWFb3I4mM xfqFHp2mw0o5gMNfuoxK3q3qLUDnujoqJ2rdegzxmFj71NkpSaDzBHHL5p2fiRKoAk8i pTdZhVegJxgb2p0cwDlmdI4qfKWvChv7eBDqM/TYPfM1vhQzlm3dHEe/2VrBLDQspFaz +HWFy0E2BuTTLfkf34vzukIJ9gQGjCFiczPI2Z9M6cRz1vAFQ6Xi6QVIEiGtn9uosD+y Md2Tcv4/y3VVImxaUAR6v+MhlpzTJ17kJBmNaQ7PoWLd8c+/jqUF0AP3ucINsgQyZBg6 1dCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=BGGslXHt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s1-20020a63dc01000000b00563de165964si11263533pgg.43.2023.08.02.13.51.01; Wed, 02 Aug 2023 13:51:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=BGGslXHt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233133AbjHBTcW (ORCPT + 99 others); Wed, 2 Aug 2023 15:32:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232678AbjHBTcN (ORCPT ); Wed, 2 Aug 2023 15:32:13 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7DF126BB for ; Wed, 2 Aug 2023 12:32:11 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-3fe167d4a18so2300055e9.0 for ; Wed, 02 Aug 2023 12:32:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1691004730; x=1691609530; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MYt9Jjxnfumr5xXWagiHEc6kz+KL1UN3g0bRxIEi7bI=; b=BGGslXHtIQBHWYdVYrx5YGuUAjIzVNlro61Kvk419BDSKHCb/aats6mo74h6P/a85f 3SZoZQTqPPTUs4bmq0Sn1hR7U0IVPJwVW9aRGX4hpGbGTTuynmECf06hUGjW1xyGP9Tt sYgT3Re/5bXqVTfTXv/jNwNaPmzsCLVRmI1Dc5p3qOuiAUzq3OxnXKpK9J/N9SxHQJ5E LK6+3RdwGoqa6+nHHEVHVJMmMBR1tkruhIe6vee2Wi668T1S/G4xHrdaDQ1RMjwrUVqR 7PG1bEOjH6IUVDWakcoUMZ25p56W03pwW0adYRzVSLroTyWLpu3UPigHu6DOk5pdy6Rp BWMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691004730; x=1691609530; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MYt9Jjxnfumr5xXWagiHEc6kz+KL1UN3g0bRxIEi7bI=; b=OD9x0qCeTC2/mbEMkW/SRfD4P48LhVIkEzCAdvVFp2bQ1AttEKI2wztej1S55eW5zw S7rX1c1J26iK1StB7Rd8lV1PDbnr7RBOPnE6NWZ278rBUbkxc5acVRbPbCP+p7TKr4O5 3cQiCR8/B2FnEsH+gNMK5En0WoRsqq/qJbnx631i/PunlvMCTdquV558OiilUJHtZJt6 nr/gynvtnOhLjfbTQkpDXjZj3oYcc1H2LK3bi1G9iaUiQJ6I2V72Y1fGy/08bBDBOvZu 9nEEVUbXluyYXKwuQ6BT1XTj59ofDfYrN9ksnA6X0v8wevS5Bk6AC3sactW3+WtbJfIE ulaw== X-Gm-Message-State: ABy/qLbL+HnXoYUwJahw6roVuByXMQlY61OZAActhNsIQo4YVcD6HR/X Z6EM2tB43AXajqJ5RTeY0mdWNA== X-Received: by 2002:a7b:c3d2:0:b0:3fb:e054:903f with SMTP id t18-20020a7bc3d2000000b003fbe054903fmr6024825wmj.36.1691004730239; Wed, 02 Aug 2023 12:32:10 -0700 (PDT) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id v18-20020a5d43d2000000b003177074f830sm19666773wrr.59.2023.08.02.12.32.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 12:32:09 -0700 (PDT) From: Naresh Solanki X-Google-Original-From: Naresh Solanki To: Guenter Roeck , Jean Delvare , krzysztof.kozlowski+dt@linaro.org Cc: linux-hwmon@vger.kernel.org, Patrick Rudolph , Naresh Solanki , linux-kernel@vger.kernel.org Subject: [PATCH v3 3/3] hwmon: (pmbus/tda38640) Add workaround for bug in SVID mode Date: Wed, 2 Aug 2023 21:31:53 +0200 Message-ID: <20230802193155.2170935-3-Naresh.Solanki@9elements.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230802193155.2170935-1-Naresh.Solanki@9elements.com> References: <20230802193155.2170935-1-Naresh.Solanki@9elements.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773151951907830775 X-GMAIL-MSGID: 1773151951907830775 From: Patrick Rudolph TDA38640 can operate in either PMBus mode or SVID mode. In SVID mode, by design ENABLE pin is the only option for controlling the output rail. In scenarios that utilizes the chip in SVID mode with ENABLE pin either grounded or tied to logic high & software control is desired then use dt property 'infineon,en-svid-control' to enable the below workaround. The workaround utilizes ENABLE pin polarity flipping to control output rail. If property 'infineon,en-svid-control' is specified then determine if chip is in SVID mode by checking BIT15 of MTP memory offset 0x44 as described in the datasheet. If chip is in SVID mode then apply the workaround by 1. Determine EN pin level 2. Maps BIT7 of OPERATION(01h) to EN_PIN_POLARITY(BIT1) of PB_ON_OFF_CONFIG. Signed-off-by: Patrick Rudolph Signed-off-by: Naresh Solanki ---- Changes in V3: - Use dt property to determine if workaround is needed. Changes in V2: - Remove dependency on DT propery, - Runtime determine SVID mode & ENABLE pin level, - Update commit message. Reviewed-by: Guenter Roeck --- drivers/hwmon/pmbus/tda38640.c | 154 ++++++++++++++++++++++++++++++++- 1 file changed, 152 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/pmbus/tda38640.c b/drivers/hwmon/pmbus/tda38640.c index 450b0273fb59..d3d987d0d7b6 100644 --- a/drivers/hwmon/pmbus/tda38640.c +++ b/drivers/hwmon/pmbus/tda38640.c @@ -18,6 +18,127 @@ static const struct regulator_desc __maybe_unused tda38640_reg_desc[] = { PMBUS_REGULATOR("vout", 0), }; +struct tda38640_data { + struct pmbus_driver_info info; + u32 en_pin_lvl; +}; + +#define to_tda38640_data(x) container_of(x, struct tda38640_data, info) + +/* + * Map PB_ON_OFF_CONFIG_POLARITY_HIGH to PB_OPERATION_CONTROL_ON. + */ +static int tda38640_read_byte_data(struct i2c_client *client, int page, int reg) +{ + const struct pmbus_driver_info *info = pmbus_get_driver_info(client); + struct tda38640_data *data = to_tda38640_data(info); + int ret, on_off_config, enabled; + + if (reg != PMBUS_OPERATION) + return -ENODATA; + + ret = pmbus_read_byte_data(client, page, reg); + if (ret < 0) + return ret; + + on_off_config = pmbus_read_byte_data(client, page, + PMBUS_ON_OFF_CONFIG); + if (on_off_config < 0) + return on_off_config; + + enabled = !!(on_off_config & PB_ON_OFF_CONFIG_POLARITY_HIGH); + + enabled ^= data->en_pin_lvl; + if (enabled) + ret &= ~PB_OPERATION_CONTROL_ON; + else + ret |= PB_OPERATION_CONTROL_ON; + + return ret; +} + +/* + * Map PB_OPERATION_CONTROL_ON to PB_ON_OFF_CONFIG_POLARITY_HIGH. + */ +static int tda38640_write_byte_data(struct i2c_client *client, int page, + int reg, u8 byte) +{ + const struct pmbus_driver_info *info = pmbus_get_driver_info(client); + struct tda38640_data *data = to_tda38640_data(info); + int enable, ret; + + if (reg != PMBUS_OPERATION) + return -ENODATA; + + enable = !!(byte & PB_OPERATION_CONTROL_ON); + + byte &= ~PB_OPERATION_CONTROL_ON; + ret = pmbus_write_byte_data(client, page, reg, byte); + if (ret < 0) + return ret; + + enable ^= data->en_pin_lvl; + + return pmbus_update_byte_data(client, page, PMBUS_ON_OFF_CONFIG, + PB_ON_OFF_CONFIG_POLARITY_HIGH, + enable ? 0 : PB_ON_OFF_CONFIG_POLARITY_HIGH); +} + +static int svid_mode(struct i2c_client *client, struct tda38640_data *data) +{ + /* PMBUS_MFR_READ(0xD0) + MTP Address offset */ + u8 write_buf[] = {0xd0, 0x44, 0x00}; + u8 read_buf[2]; + int ret, svid; + bool off, reg_en_pin_pol; + + struct i2c_msg msgs[2] = { + { + .addr = client->addr, + .flags = 0, + .buf = write_buf, + .len = sizeof(write_buf), + }, + { + .addr = client->addr, + .flags = I2C_M_RD, + .buf = read_buf, + .len = sizeof(read_buf), + } + }; + + ret = i2c_transfer(client->adapter, msgs, 2); + if (ret < 0) { + dev_err(&client->dev, "i2c_transfer failed. %d", ret); + return ret; + } + + /* + * 0x44[15] determines PMBus Operating Mode + * If bit is set then it is SVID mode. + */ + svid = !!(read_buf[1] & BIT(7)); + + /* + * Determine EN pin level for use in SVID mode. + * This is done with help of STATUS_BYTE bit 6(OFF) & ON_OFF_CONFIG bit 2(EN pin polarity). + */ + if (svid) { + ret = i2c_smbus_read_byte_data(client, PMBUS_STATUS_BYTE); + if (ret < 0) + return ret; + off = !!(ret & PB_STATUS_OFF); + + ret = i2c_smbus_read_byte_data(client, PMBUS_ON_OFF_CONFIG); + if (ret < 0) + return ret; + reg_en_pin_pol = !!(ret & PB_ON_OFF_CONFIG_POLARITY_HIGH); + data->en_pin_lvl = off ^ reg_en_pin_pol; + } + + return svid; +} + static struct pmbus_driver_info tda38640_info = { .pages = 1, .format[PSC_VOLTAGE_IN] = linear, @@ -26,7 +147,6 @@ static struct pmbus_driver_info tda38640_info = { .format[PSC_CURRENT_IN] = linear, .format[PSC_POWER] = linear, .format[PSC_TEMPERATURE] = linear, - .func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_STATUS_INPUT | PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP | PMBUS_HAVE_IIN @@ -41,7 +161,37 @@ static struct pmbus_driver_info tda38640_info = { static int tda38640_probe(struct i2c_client *client) { - return pmbus_do_probe(client, &tda38640_info); + struct tda38640_data *data; + int svid; + + data = devm_kzalloc(&client->dev, sizeof(*data), GFP_KERNEL); + if (!data) + return -ENOMEM; + memcpy(&data->info, &tda38640_info, sizeof(tda38640_info)); + + if (IS_ENABLED(CONFIG_SENSORS_TDA38640_REGULATOR) && \ + of_property_read_bool(client->dev.of_node, "infineon,en-svid-control")) { + svid = svid_mode(client, data); + if (svid < 0) { + dev_err_probe(&client->dev, svid, "Could not determine operating mode."); + return svid; + } + + /* + * Apply ON_OFF_CONFIG workaround as enabling the regulator using the + * OPERATION register doesn't work in SVID mode. + * + * One should configure PMBUS_ON_OFF_CONFIG here, but + * PB_ON_OFF_CONFIG_POWERUP_CONTROL and PB_ON_OFF_CONFIG_EN_PIN_REQ + * are ignored by the device. + * Only PB_ON_OFF_CONFIG_POLARITY_HIGH has an effect. + */ + if (svid) { + data->info.read_byte_data = tda38640_read_byte_data; + data->info.write_byte_data = tda38640_write_byte_data; + } + } + return pmbus_do_probe(client, &data->info); } static const struct i2c_device_id tda38640_id[] = {