From patchwork Wed Aug 2 10:09:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Billy Tsai X-Patchwork-Id: 129774 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp378752vqx; Wed, 2 Aug 2023 04:19:11 -0700 (PDT) X-Google-Smtp-Source: APBJJlHeoivxax9Pz+CRAnsrqi/k0xn9XXBNGz50nTFPM7tDoTOb2ZzjHakMRurD/F/85BZqol4D X-Received: by 2002:a05:6a00:810:b0:687:52a8:81ae with SMTP id m16-20020a056a00081000b0068752a881aemr5188659pfk.33.1690975151030; Wed, 02 Aug 2023 04:19:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690975151; cv=none; d=google.com; s=arc-20160816; b=xNn9+xhvZwt3ahlJD4T+1np/EkZPMqKTGm9IYaU6Jtv1rbTZX1KziPNzzenX8MDbvH jRZGiRUn2X5bcjwD9zp2n9GgK4Udy9qUk3pliqy5lkEYVufX6RSX1wpDOR8xePC8aO8+ 2ybVKPptnhESwviTcaPgZfaYFAmy6A1tJ3HG4S7/w6P6wJ7UGeRKjw6TdLa/qN4Z6zUX JPk9J4dXCP/YdrV70qu7UsgE+rk2PyizvU7xTYyuIVteBOOrO/zsz/rV2/G0PJVfc8Dn r/JscFPCM3KW4o+qfghW2/yzNH5PbfKRrCOcNXdCDBVSRZ4++PMDNvOEZLLGT1Lr3myn OgCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from; bh=XEZri695rATjdvNjcuHhv64PWdIQisFJ8UFARUsld9A=; fh=tD90eJ3zutO44gsPKUJdFEyVgY0i4Ju5+K4/QTouAEE=; b=i0JwEROUgYVKv+iMIIm6eVpLdkkbyIVeJLMdHq1ZWw7deTUleI5iS1GceYy2FkfvEp OU54h56ETucbYx7LFqSn+LJDOfLOIfhm8lCu1OZJaonusge5d+Z7UuzIhesY8TDoC5Q4 GK2b33yx5oYXPpV+iZ45aiUWb9qoUlYzGc60JvelejlcjLaDBNJ5lCGBsiJYPsdT8xnm KJ1R/hIZBHFJCmjzBEkl9ehs0ajNJN1M8o7VOZEAbVyEbTNb2T3gHf8xHJ228n/YhNEj EXZNVVYHPPHBQ0VO7BmUVF8CwyZ0P75V5cdOQaNGS3QdOsYeuAHSRB4mAN137tTZfbjm Mrwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=aspeedtech.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j31-20020a63fc1f000000b00563d7689978si6482701pgi.561.2023.08.02.04.18.56; Wed, 02 Aug 2023 04:19:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=aspeedtech.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232933AbjHBKKf (ORCPT + 99 others); Wed, 2 Aug 2023 06:10:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233057AbjHBKK0 (ORCPT ); Wed, 2 Aug 2023 06:10:26 -0400 X-Greylist: delayed 63 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 02 Aug 2023 03:10:15 PDT Received: from TWMBX02.aspeed.com (mail.aspeedtech.com [211.20.114.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 708DB2701 for ; Wed, 2 Aug 2023 03:10:15 -0700 (PDT) Received: from TWMBX02.aspeed.com (192.168.0.24) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 2 Aug 2023 18:09:10 +0800 Received: from twmbx02.aspeed.com (192.168.10.10) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 2 Aug 2023 18:09:10 +0800 From: Billy Tsai To: , , , Subject: [PATCH] i3c/master: cmd_v1: Fix the exit criteria for the daa procedure Date: Wed, 2 Aug 2023 18:09:09 +0800 Message-ID: <20230802100909.2568215-1-billy_tsai@aspeedtech.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Received-SPF: Fail (TWMBX02.aspeed.com: domain of billy_tsai@aspeedtech.com does not designate 192.168.10.10 as permitted sender) receiver=TWMBX02.aspeed.com; client-ip=192.168.10.10; helo=twmbx02.aspeed.com; X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_FAIL,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773115959807127148 X-GMAIL-MSGID: 1773115959807127148 The exit criteria for the DAA should check if the data length is equal to 1, instead of checking if the response status is equal to 1. Signed-off-by: Billy Tsai --- drivers/i3c/master/mipi-i3c-hci/cmd_v1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c index d97c3175e0e2..6a781f89b0e4 100644 --- a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c +++ b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c @@ -339,7 +339,7 @@ static int hci_cmd_v1_daa(struct i3c_hci *hci) break; } if (RESP_STATUS(xfer[0].response) == RESP_ERR_NACK && - RESP_STATUS(xfer[0].response) == 1) { + RESP_DATA_LENGTH(xfer->response) == 1) { ret = 0; /* no more devices to be assigned */ break; }