From patchwork Wed Aug 2 05:05:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 129629 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp248942vqx; Tue, 1 Aug 2023 23:32:54 -0700 (PDT) X-Google-Smtp-Source: APBJJlGzwSHGYKEhg822s7OkSQLRLi3RTK24Apx0Hv9RR1DeeM/W+pYm+LqkvVSVYUPRjMPXRHK8 X-Received: by 2002:a17:90b:3c3:b0:268:94b:8d0 with SMTP id go3-20020a17090b03c300b00268094b08d0mr18161767pjb.11.1690957973773; Tue, 01 Aug 2023 23:32:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690957973; cv=none; d=google.com; s=arc-20160816; b=Ek7N7A9Aeq/HBlVdeJU6GgxrrxjasIflrvyXLvVthP2iA3knP2R9400tEFZj83dEPC IQ0jt0DnfntKsXHsX/7uqLEwzGVZGNO8puI0FL6tO5nQssg97k/9EPQNucf2AMFVSOFY IX0l7SGTX2sWyRbBe11+soiHg76BE5UkSyY0ocLy1k75tmngZH9rFZ2UTO2FPMDqEK7h AeO+AptsmMkUAeSo6FwTpPr66LpsZKQloO9lt9wF88S5iPE8U0J4rMyiBvSsFrl/wREo 6hAYLyIxUQOR9xyxq0cG109pKrP4aQyHAS9Ra7oDpHjNm7ZbkV1NdtqO/10Dx9D+HrsW KImA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=fHuHIza0qWwk4bnlegiBooqCBm98VbfuHRDFdFwGhLY=; fh=Ld4bEJMliET3pg5SF4t5/bzEu7hB0dttY59G24FXQc0=; b=JDwPkI9RTeQCnXgiYGegmt/Y/n4do2sP/5ykJnCH9BJed9yej2NQUW3didHYd9H/yk 7CHqQbFpvC2EMADTQJUqAnYNVOsClzwd+m1d1quCJEVV2A716SkTc4lqDXpcA64nG/uX B4WrRfHty+l8yBp3fHmr4HlroR22ptxMmgREyr/J7JzkBuwagZGEoBW3r4egS3oS4v2W CUGV2B0t0U5tlSuciNgjX5sW/IGqOzzye4jPhlLQP4c/LwiPQbUFjEW3K6q1W958pClW eheJWDTxzfy3YNsd7hThcXgDfhXAoEP8Z5uCckHVUyExfU++5MgKNVY1dAzS6DQwhjsV BwHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jIR3DAN3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s7-20020a17090aad8700b0025bf45ac365si702906pjq.82.2023.08.01.23.32.40; Tue, 01 Aug 2023 23:32:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jIR3DAN3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232119AbjHBFEe (ORCPT + 99 others); Wed, 2 Aug 2023 01:04:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232029AbjHBFEb (ORCPT ); Wed, 2 Aug 2023 01:04:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4BA5268E; Tue, 1 Aug 2023 22:04:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 49D43617E2; Wed, 2 Aug 2023 05:04:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F79BC433C7; Wed, 2 Aug 2023 05:04:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690952667; bh=roMvJpb+EzYKwtQeG0++SvhEzIg74QW7AkwQyMIYc/8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jIR3DAN3rPp40JJ80ZHvkLqrCjGI4pSRFKCrEkL1vHVjBNGUvz3xOLHhxuwLauIXl 2w3Hi13EWZBk9l75KXdGL6arb1bAYS7vRLZvWif0lYIFruJuRKXWZW1imPdW/bQRQE HLH311XABoSVxhP3HRVme9J+NCojqdyrqGM5/2dsSPZfZnaWPpJolWQNNsN40YA50T XTSgR+6axNJjZpTIE5xji6Pg1woOTWvU6UFD3M3+enuWUkQuYpfc8bcbEbeTfiNRQv CtdfFKEfbdRGpccfrBCQ5avkgYsXGxT+36SJkAGGGt+V2rYcBvzr4fvAYxpjs4NhEf +M3pG5cOlt9EQ== Date: Tue, 1 Aug 2023 23:05:31 -0600 From: "Gustavo A. R. Silva" To: Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: [PATCH 1/4][next] i40e: Replace one-element array with flex-array member in struct i40e_package_header Message-ID: <768db2c3764a490118f6850d24f6e49998494b6c.1690938732.git.gustavoars@kernel.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773097948067413672 X-GMAIL-MSGID: 1773097948067413672 One-element and zero-length arrays are deprecated. So, replace one-element array in struct i40e_package_header with flexible-array member. The `+ sizeof(u32)` adjustments ensure that there are no differences in binary output. Link: https://github.com/KSPP/linux/issues/335 Signed-off-by: Gustavo A. R. Silva Tested-by: Pucha Himasekhar Reddy (A Contingent worker at Intel) --- drivers/net/ethernet/intel/i40e/i40e_ddp.c | 4 ++-- drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ddp.c b/drivers/net/ethernet/intel/i40e/i40e_ddp.c index 7e8183762fd9..0db6f5e3cfcc 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_ddp.c +++ b/drivers/net/ethernet/intel/i40e/i40e_ddp.c @@ -220,7 +220,7 @@ static bool i40e_ddp_is_pkg_hdr_valid(struct net_device *netdev, netdev_err(netdev, "Invalid DDP profile - size is bigger than 4G"); return false; } - if (size < (sizeof(struct i40e_package_header) + + if (size < (sizeof(struct i40e_package_header) + sizeof(u32) + sizeof(struct i40e_metadata_segment) + sizeof(u32) * 2)) { netdev_err(netdev, "Invalid DDP profile - size is too small."); return false; @@ -281,7 +281,7 @@ int i40e_ddp_load(struct net_device *netdev, const u8 *data, size_t size, if (!i40e_ddp_is_pkg_hdr_valid(netdev, pkg_hdr, size)) return -EINVAL; - if (size < (sizeof(struct i40e_package_header) + + if (size < (sizeof(struct i40e_package_header) + sizeof(u32) + sizeof(struct i40e_metadata_segment) + sizeof(u32) * 2)) { netdev_err(netdev, "Invalid DDP recipe size."); return -EINVAL; diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h index 388c3d36d96a..c3d5fe12059a 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_type.h +++ b/drivers/net/ethernet/intel/i40e/i40e_type.h @@ -1456,7 +1456,7 @@ struct i40e_ddp_version { struct i40e_package_header { struct i40e_ddp_version version; u32 segment_count; - u32 segment_offset[1]; + u32 segment_offset[]; }; /* Generic segment header */ From patchwork Wed Aug 2 05:05:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 129640 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp257182vqx; Tue, 1 Aug 2023 23:53:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlEYi+e+aXSxeVpakSBZLgS6evpoSxWBZy6fgGvIbOUqzXPKdFEUXF1CNwNNwKhqXmwefZfk X-Received: by 2002:a05:6830:10d7:b0:6b9:b1b0:fcd1 with SMTP id z23-20020a05683010d700b006b9b1b0fcd1mr13710364oto.31.1690959189155; Tue, 01 Aug 2023 23:53:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690959189; cv=none; d=google.com; s=arc-20160816; b=BFeVnAyGnGiu8h9FwAq70jaXif7D5MznhgaCWN2EAvcey3XgnxySTaaAYnOs2AwCre A0vHQl5IDeUK/alE6Ztf/ArIMMpsr2YuzrCzJ9giyM0SuAhml2e3ifVnaZjglph1oxJe Y5xaxIqQlw9MBtKm/SDuBdbY9D5lXzWdMFvzSZ/egicGLWLENHJtw34HIwJAINXVO0xS ERekyf8i92lm7GfRbkbVwJdrpuRRYHj8+Zl4DWj8steXrdgSfOgLG7bZ/J7YVQYIEeGa IoDGBIFgZ3wkIwdMm0VJ9NWCPL0LExocL8sP3uYqGN7dU3iZxI3KDpMj33HljVSDG8xE 1AIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=pcqvn7KrGwtsXqh6yH5QHbwrgV/PyF8NBQKwzaw/5kk=; fh=Ld4bEJMliET3pg5SF4t5/bzEu7hB0dttY59G24FXQc0=; b=EPjszrdo2EPL5hnKil7r88Sae1xv9KSlQcBg9pMlfTZ5e35r20DYXBlAxCBMi+QIUg eOtHQrw5O3oIGaygs0W1gbhgo8MVumzi8YeLzHmkGWjbu8dm/+Ln1V0q3Dc1ossoUxS0 FLhP0Z7+KZ8nsyDxCNuATnSbdq8V+pQueYWRLn+eWRAbuClWlB2psa8l27CehMJLro8M WWgKd/4J1MZMVj7DtvJThcGuQDOkZp5E9bnzAjWP3yc/MImRfYDrXoiEzFN22mq59pMo NpJtc1zStGvlN1Fq0IbNrt/OgHryUCbVUG1cqeaqgnxGp68GFv/eXXDjF+LQ4ZmlUXCU nU2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=o9z225Vu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nl5-20020a17090b384500b00262f99a851asi762547pjb.96.2023.08.01.23.52.56; Tue, 01 Aug 2023 23:53:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=o9z225Vu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231901AbjHBFFY (ORCPT + 99 others); Wed, 2 Aug 2023 01:05:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232184AbjHBFFP (ORCPT ); Wed, 2 Aug 2023 01:05:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DB4E273A; Tue, 1 Aug 2023 22:04:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D21AA617C2; Wed, 2 Aug 2023 05:04:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26A01C433C8; Wed, 2 Aug 2023 05:04:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690952695; bh=20F4xPeEvNj9IuAftI9KVAMz4n8aQOzO8rp3P7fmGNc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o9z225Vuo0O0cdGOCNgMKn+dvOU5eE4KM84og9IwU8gxi8fE1GdcLi226AenlSZDC vyN968CCLHAicKjG2npw9QyTqf5V/7QZu14QhJGEr4DkIVbWKR7qYIecWtVJzw1T7W EnZjm9vb2bb4d/bdiRASxZ05afIqPnbs8yXhC0nYM0Bqua4+iLDZ9cA8LvkqcX7Vsn nvgxRUpo8d1lo4C+hmsSlHKapcKTwO2CsB0UjWlgs+UD3Vz5T/i3qPzZGITD2F2V4M J9k1qrzUxWHpKqpbPVEyzMjyozTZzMyYntlUSlqJqOkJYXnhkJgBP5a4azkS2YzVeZ YeliueNUPZC5Q== Date: Tue, 1 Aug 2023 23:05:59 -0600 From: "Gustavo A. R. Silva" To: Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: [PATCH 2/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_segment Message-ID: <52da391229a45fe3dbd5c43167cdb0701a17a361.1690938732.git.gustavoars@kernel.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773099222997686646 X-GMAIL-MSGID: 1773099222997686646 One-element and zero-length arrays are deprecated. So, replace one-element array in struct i40e_profile_segment with flexible-array member. This results in no differences in binary output. Link: https://github.com/KSPP/linux/issues/335 Signed-off-by: Gustavo A. R. Silva Reviewed-by: Simon Horman Tested-by: Pucha Himasekhar Reddy (A Contingent worker at Intel) Tested-by: Justin Stitt Reviewed-by: Justin Stitt --- drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h index c3d5fe12059a..f7a984304b65 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_type.h +++ b/drivers/net/ethernet/intel/i40e/i40e_type.h @@ -1487,7 +1487,7 @@ struct i40e_profile_segment { struct i40e_ddp_version version; char name[I40E_DDP_NAME_SIZE]; u32 device_table_count; - struct i40e_device_id_entry device_table[1]; + struct i40e_device_id_entry device_table[]; }; struct i40e_section_table { From patchwork Wed Aug 2 05:06:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 129650 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp266187vqx; Wed, 2 Aug 2023 00:12:30 -0700 (PDT) X-Google-Smtp-Source: APBJJlHt8gCaKqb/Hp+RuXz0OWyYgewyBFOH/b0qEDxRwxPb2MZO9AxA36gly+yk3RCeV/Uqfp7B X-Received: by 2002:a05:6358:280d:b0:134:d030:e5da with SMTP id k13-20020a056358280d00b00134d030e5damr2830779rwb.21.1690960350349; Wed, 02 Aug 2023 00:12:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690960350; cv=none; d=google.com; s=arc-20160816; b=ptb068CoyoJjkvRuB/68a2aLZP3q45HqhJ0dmiB+DPLZ5t7Cdf0uaXQRxMMLGZqkbG U0QkMlD5SBJcBD1TbFLNXDiqQClCH1TVTATv3na1JGYSKcHBHCJ0H/ZGhPOmZ2O2JY/P 5xqrAO/p47gQ6bKvq/Yr/R/BtvScvIXM/xIR8nkBjFCevcZlME9mLNswNhSVAY2VUctz G98OeXtyVf9BlsX9x01u0h15ymvMpBBA15SBHqpA8enndfxmlWq8EIRuPsctQqz1f4cu R5tTcz8RwUKjfEWnnOQOLU0giWt+mPFUiyJhFO8kmRBJF0jj+eEarVgtOZ0E/iMKWqNj qLSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/6pyNE991xmWeFXyGzcUu6WcZcIKikA21VZFJiVKjCE=; fh=Ld4bEJMliET3pg5SF4t5/bzEu7hB0dttY59G24FXQc0=; b=lOjVKshBKjPeeO5A8vR/iqUrzQnpTczIBI7wFDNMx0f5gG6sFxwvYsDqF30tDIpxnV 8KRdQVIPbfd55tuFNmj69a7HePdjmIFnaXV6HhBLZBZa0c1ZJaKRBIfiGtAqWcoQpEY8 0N4/Kqb7OwCo23fdCyNZQzbEPZum5df+SMfy3IUBBfXGOLaDtHGTm2iThYjyzVi7WqUS cvZzQ5hBHnLaAI3KYgUz+i5Tvj1WdBDuLCZLQfsVuB1Et1gLxaHDRI7fX+Mnb1NL13CV dpmGgZG0ds0BvyJP1rkA6+YIpHPYPc67kppc6wJfMZXV0ArSlLZmQS9VwDRymEjUriWf /o6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aVODpFlG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q37-20020a631f65000000b0054ff38f6448si10091332pgm.238.2023.08.02.00.12.16; Wed, 02 Aug 2023 00:12:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aVODpFlG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232130AbjHBFFf (ORCPT + 99 others); Wed, 2 Aug 2023 01:05:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232218AbjHBFF2 (ORCPT ); Wed, 2 Aug 2023 01:05:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5134A1FCF; Tue, 1 Aug 2023 22:05:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D24F3617E2; Wed, 2 Aug 2023 05:05:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14365C433CA; Wed, 2 Aug 2023 05:05:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690952726; bh=mqqkGVbU/w5XVGL8wNFiKBrpnoFsZ0U7xfNm17f7El4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aVODpFlGBTgJf/7xxXR6C30T6BZmJoEN3+kRYa79kTII0nnf6ub3clATPGufXTnTE P1eFFL1msnaqiFvcfvjhfbIWovhU1tqPpSdnflkPghhkn2lh+hZ5ZVoaHo2VaQypDj xV+96UEjZDU4q2/giYSW3dfh9wWNayYZcKuYJ63+9jB0uKPZfoy3MyJkKN7gxkmCO0 55jVCANF0xJbgIXgoULvPYhOrsgUFYs10dSKWJ46Pm6V3nVYy/aB/0YZ8yNl8Isl/v AEa+nwN887eWcZeTNlqhP7f9DUeSP+L1HcCFO/w3mQm7W43LY4naJJaRTzU9eZdGCu sWK96H0/eRzpQ== Date: Tue, 1 Aug 2023 23:06:30 -0600 From: "Gustavo A. R. Silva" To: Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: [PATCH 3/4][next] i40e: Replace one-element array with flex-array member in struct i40e_section_table Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773100440533219440 X-GMAIL-MSGID: 1773100440533219440 One-element and zero-length arrays are deprecated. So, replace one-element array in struct i40e_section_table with flexible-array member. This results in no differences in binary output. Link: https://github.com/KSPP/linux/issues/335 Signed-off-by: Gustavo A. R. Silva Reviewed-by: Simon Horman Tested-by: Pucha Himasekhar Reddy (A Contingent worker at Intel) --- drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h index f7a984304b65..010261a10f56 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_type.h +++ b/drivers/net/ethernet/intel/i40e/i40e_type.h @@ -1492,7 +1492,7 @@ struct i40e_profile_segment { struct i40e_section_table { u32 section_count; - u32 section_offset[1]; + u32 section_offset[]; }; struct i40e_profile_section_header { From patchwork Wed Aug 2 05:07:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 129624 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp246225vqx; Tue, 1 Aug 2023 23:26:27 -0700 (PDT) X-Google-Smtp-Source: APBJJlHU2h3zF1KuypceZTbMOTurpWNnqNkZwMW8B/Uj4Wsq+5zBAMAXC5JMRi0WDSL1BZpHB8wh X-Received: by 2002:a05:6358:3a0a:b0:134:ded4:294 with SMTP id g10-20020a0563583a0a00b00134ded40294mr6160703rwe.17.1690957587451; Tue, 01 Aug 2023 23:26:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690957587; cv=none; d=google.com; s=arc-20160816; b=QvpKO67R3ZHWFC9EMLhrChQqLsHrsk9aK/XKNQj2NgpUIg+LsLHzAheapSG5PhthH1 JTkysO3J34/N/9XP4SOUTeB9yVcQQb8BCx2wVdpHU2n1Acu7dXuVmyeybxIgDX9EBd34 bOIrz0FMFsrmrL+sl5b6dnaa8LSzjCCRhJSG3F+RegO/XhaDFXmKd+r2VHQfhPW1USec W9qWqTh7uzGxZA9dPUDAqP5SBdg6XtzYlhrjqKBegeph/XnL4BDB5V/2k2c85puLxFZ/ y2+tMZfHL5BtrhUJCIGhcg/bAjuy/KS1SPQNsnWIHOHbNqB3KOlP4WZ3ltB5v5Qaa/I5 pMLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=BdT5InxzLsPrnUC9KW3M5vI51BbqPBfr/W7DUiagpSs=; fh=Ld4bEJMliET3pg5SF4t5/bzEu7hB0dttY59G24FXQc0=; b=cOuohR+REdpUVtkmwJU9h7JaPykjTZ1GReI8P2+oo0q9w/B2NKUhZdg79YIVtlOjjv RI+/2slWbvPferbYhbjXQfil6ebuOYXt/QDtQCkEakxirKhklhss8ZoPTiwjTploQqdj Dw0pcKAHSJSd7w0Xa4i8bjXTu9COKkmGE8qM7GMy0QdxoXE1sMAfKtphxQO6MZWqCfpJ QL0sOLFwMC6SBU1a3HXsqst2eddFSkECtMXVIfBGy8jBAQYivW9QNV2MjMjhRz1p0Z7V BmnqgFAs2YDF6UWyxriQlLdksdM3vpuuhjRwUQvgUNCuWFObwe7rV/gPG0DVVbotExAp Exlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TGoDdwO7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b23-20020a63cf57000000b005538e9fb8cbsi9841734pgj.550.2023.08.01.23.26.13; Tue, 01 Aug 2023 23:26:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TGoDdwO7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229685AbjHBFGO (ORCPT + 99 others); Wed, 2 Aug 2023 01:06:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230411AbjHBFGM (ORCPT ); Wed, 2 Aug 2023 01:06:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F6F3210A; Tue, 1 Aug 2023 22:06:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E903D617D8; Wed, 2 Aug 2023 05:06:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39A3CC433C7; Wed, 2 Aug 2023 05:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690952762; bh=vIsmaLOHNHCmvZTxuykbw4hyJBbUacnWk4VvMmzUK9Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TGoDdwO7hOgoCxkDVBaD4hulYPoImelxdjPjcsAzBC2Hck8e6L1owP4Unq/187OVz AaStDAYVHCuEzbXh3yndCl5XABgFRv/5KrYue7+slumcRYB7WQ2g3CME5mdZ+llh66 jII4nKJ7g63cth/fX997PJyM8Kry7RBTy31bDAp+MWEwX2BfKZg4uLn9TWVJWWQtP5 oKN++/7yTJTf5yp54Xz8LRF10QeLPhaJaOBXF8ivvu+VLabPMa2Nnf3KHILWMn692S Xb3thfwhybIBYbI34Btvu072VaqksAauTVZoOI3ndEnrtNlYosLlTpWYVOr0c8x5TY woBuhwwh0qrpA== Date: Tue, 1 Aug 2023 23:07:06 -0600 From: "Gustavo A. R. Silva" To: Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: [PATCH 4/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_aq_section Message-ID: <8b945fa3afeb26b954c400c5b880c0ae175091ac.1690938732.git.gustavoars@kernel.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773097543035547549 X-GMAIL-MSGID: 1773097543035547549 One-element and zero-length arrays are deprecated. So, replace one-element array in struct i40e_profile_aq_section with flexible-array member. This results in no differences in binary output. Link: https://github.com/KSPP/linux/issues/335 Signed-off-by: Gustavo A. R. Silva Reviewed-by: Simon Horman Tested-by: Pucha Himasekhar Reddy (A Contingent worker at Intel) --- drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h index 010261a10f56..b9d50218344b 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_type.h +++ b/drivers/net/ethernet/intel/i40e/i40e_type.h @@ -1524,7 +1524,7 @@ struct i40e_profile_aq_section { u16 flags; u8 param[16]; u16 datalen; - u8 data[1]; + u8 data[]; }; struct i40e_profile_info {