From patchwork Tue Aug 1 00:14:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 128936 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp2365514vqg; Mon, 31 Jul 2023 18:08:00 -0700 (PDT) X-Google-Smtp-Source: APBJJlFXQkZ8VvB7gUbbHbrUmzf0FNg8Y5aA4soS9ptMGKmpBL9PnZc6vX9dbre7wjrQCqZ0EmWj X-Received: by 2002:a5d:53c6:0:b0:317:69f9:668e with SMTP id a6-20020a5d53c6000000b0031769f9668emr5479376wrw.5.1690852080052; Mon, 31 Jul 2023 18:08:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690852080; cv=none; d=google.com; s=arc-20160816; b=j4QLWO5RwIgXxf/fecAFS6KXd4YsU4d3X9mFT9iYN0uaxUVcYYuHtg8NjypDZues6c A6ed6U51tuC4AQHmIn7jJXdQphfUIaQK9O6UVYXSbKjGkBd2BZ1GXt3JOjvUWB+yZ4ep nnR+5KUij+TVpwJ/waq5Lit6jCvkKYRR9+LiYL01zbaz3FD+ZR9SUKtuZdsFyLt+UHp0 uroIlaNRjPPNU0DxqDfxHLvIE3ySQJ+GBhPQbGYyPrLsYxwhl6uqJiFid0mjXLaxu259 TP5cok7oLrXxptsFAxCQKNkv3nCB7OCdZqhe8SiGviZRKtLZbzH4muDwVhGbWjH4gJrL Ls3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=j8Gn0vUbqn5KrPRESg/tfqYET2suOSB2grBNovpzc7I=; fh=dO/e/wed5j8qjEsc8CQeFUhVtYCxUjxHlA7b7fgI4Fs=; b=qI7UlDG0thtkAYlEjT6PoCCKG1iakiv5EZM+Fsuq3RPJzf85fv5daKZFFo3aZu9BXF U12YGUmF3JzZXa13jjCWpwTcZ+n+tVm6/yZ1RuxNulGHLaS0P6TNekODRfF6mZ5WKuGw 8DPGexJ/C8F8n7/lJNuNYpArkIwesBWSVY1f7H+slj4dobsN00GXeBC2nMUuuuroIM1C +yHPobcWuCMpC7JMfsMr9iI7cycV/n+C6LdkSJZXPxOvEzPJFAWzbAtXqYU24tuCPIPG t9Qgm8gnQt/MvJtIqbSgUHuHKsF0zmjrCm/Tfc+AI+kz+6fnyfFMAaZ0rBANths4qrmp l22w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=oFHeD2e8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f5-20020aa7d845000000b0051e28ec9d30si4731149eds.665.2023.07.31.18.07.35; Mon, 31 Jul 2023 18:08:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=oFHeD2e8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230269AbjHAAQh (ORCPT + 99 others); Mon, 31 Jul 2023 20:16:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229661AbjHAAQf (ORCPT ); Mon, 31 Jul 2023 20:16:35 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CABD8173B for ; Mon, 31 Jul 2023 17:16:34 -0700 (PDT) Received: from workpc.. (109-252-150-127.dynamic.spd-mgts.ru [109.252.150.127]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id ACBBF6606FCD; Tue, 1 Aug 2023 01:16:32 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1690848993; bh=S7knx5egzrTAirnUxqfoRPb8R6N7s1X8bGrSKkYmowM=; h=From:To:Cc:Subject:Date:From; b=oFHeD2e8efQb5MMGRKIoxSOrkmqqtIVFtIFodNbd486+hkL/12fkbxmBIwWg7EI5U 5lXVP6QcCO3IVxdKVh60sxA+xoU7UgUlfCEiNULKBL/WEuaeCvhxO0nE4A6+zyJ6J1 ZGCG57sLCoPAYwSFn00gA9rjf6HLEF7pnrZvy98BMJBRcbUNA3oiJA/g6JPgd7246n Nmo+NAmFEXzF9UdBCJxT1hbOlgkEy32aaeQ295i3M6a514CC+5U767aUGwlTvfL6At xDVuM0v+KNv0LCv7HId1R8y5iNb+zv2dRNkOfzsPm7AqDRKbv8t+Ohiuc4ImWCHAhk /rXYC4mwRE9zA== From: Dmitry Osipenko To: AngeloGioacchino Del Regno , Rob Herring , Steven Price , Boris Brezillon Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: [PATCH v3] drm/panfrost: Sync IRQ by job's timeout handler Date: Tue, 1 Aug 2023 03:14:27 +0300 Message-ID: <20230801001427.176981-1-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772986910687383094 X-GMAIL-MSGID: 1772986910687383094 Panfrost IRQ handler may stuck for a long time, for example this happens when there is a bad HDMI connection and HDMI handler takes a long time to finish processing, holding Panfrost. Make Panfrost's job timeout handler to sync IRQ before checking fence signal status in order to prevent spurious job timeouts due to a slow IRQ processing. Reviewed-by: Steven Price Reviewed-by: AngeloGioacchino Del Regno Tested-by: AngeloGioacchino Del Regno # MediaTek MT8192 and MT8195 Chromebooks: Signed-off-by: Dmitry Osipenko Reviewed-by: Boris Brezillon --- Changelog: v3: - Added comment to the code as was suggested by Boris - Added r-b/t-b from Steven and Angelo v2: - Moved synchronize_irq() after first signal-check to avoid unnecessary blocking on syncing. - Added warn message about high interrupt latency. drivers/gpu/drm/panfrost/panfrost_job.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c index dbc597ab46fb..ea1149354f9d 100644 --- a/drivers/gpu/drm/panfrost/panfrost_job.c +++ b/drivers/gpu/drm/panfrost/panfrost_job.c @@ -720,6 +720,21 @@ static enum drm_gpu_sched_stat panfrost_job_timedout(struct drm_sched_job if (dma_fence_is_signaled(job->done_fence)) return DRM_GPU_SCHED_STAT_NOMINAL; + /* + * Panfrost IRQ handler may take long time to process if there is + * another IRQ handler hogging the processing. For example, HDMI + * may stuck in IRQ handler for a significant time in a case of bad + * cable connection. In order to catch such cases and not report + * spurious Panfrost job timeouts, synchronize the IRQ handler and + * re-check the fence status. + */ + synchronize_irq(pfdev->js->irq); + + if (dma_fence_is_signaled(job->done_fence)) { + dev_warn(pfdev->dev, "unexpectedly high interrupt latency\n"); + return DRM_GPU_SCHED_STAT_NOMINAL; + } + dev_err(pfdev->dev, "gpu sched timeout, js=%d, config=0x%x, status=0x%x, head=0x%x, tail=0x%x, sched_job=%p", js, job_read(pfdev, JS_CONFIG(js)),