From patchwork Mon Jul 31 05:50:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yuan Tan X-Patchwork-Id: 128347 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp1822076vqg; Sun, 30 Jul 2023 23:06:28 -0700 (PDT) X-Google-Smtp-Source: APBJJlFL8FpY6enPGx+cTLSMMaAlOR/I6NtVRnFd7jrM3tYKuA0DMUe3I3qeYx3KjGZE8/yL+d6L X-Received: by 2002:a17:907:a070:b0:987:4e89:577f with SMTP id ia16-20020a170907a07000b009874e89577fmr6057406ejc.24.1690783588034; Sun, 30 Jul 2023 23:06:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690783588; cv=none; d=google.com; s=arc-20160816; b=f9tbdZVst2RSTuikwymmWqk7sdE1Qosz7zN9HMgDQXhVHoR+UI0MWQDNn9xPfOaFoO tTvRraH/wdWIo2QqlJNZ3A9is0gY+wDxx/nuRrQZaUvLDR7clYtMZoFhbsk4P08+xHWs IwFeYN1EcrQFUPuT9HSrSudARCP8rJmzD1/Y2fnLbjBY1VEKqiZiL9EngIkalo1TxHYf bmc4HVCDUEbjQDwZWVF+6LBSVb+Va1TisNJ/PFveQv+vZ05BogJzoY6qN1rtPd74zEgV qVTdPQH/1T8vX27tFDfpfxsJyrzNOvtM4DFyh9w7QS8Sy+49pwfLOEZ4rGvteAGHuAkn fsAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=OyTWay/O+aswax5QnWEJfPOUv0J3mt+gxsvtBQ2OYsw=; fh=8heE8X7c/6KBQVGdiUUfEdY5Aql55kcYv0bNCPp9yaU=; b=e3pKTJb7eWT8x48Ij/KEu5h2XItXcTzm8SJbEIn/GrUmf7jER7b8XubVV1r8BX52J6 vWjrt/A9SYhTLQdaroLDC9TTKZNQu2632o8lopMI1GvZGjEvYQVSMc3F5Xd9acX0AMKI djS8OK653fcMEEuHlkVSiqV9H/zsoj/f1QuM5m6YAzoT2OMhg31IYT4wjevn9lglwCn1 m+H9PG7Rm60gY4T0Seu8+Cw0OSeoAC49ZJyvs9q46A32Q5MXaTTwzfCEo0qiZFZjQG5q MfiwPFBfb91MynmQ6DmydgwNA5vewO0HK01SdGD5YWa5WiFaJkIBYReiqovW+cCZpctW cf+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b14-20020a1709062b4e00b009886d385534si7095547ejg.950.2023.07.30.23.06.02; Sun, 30 Jul 2023 23:06:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230082AbjGaFvG (ORCPT + 99 others); Mon, 31 Jul 2023 01:51:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230032AbjGaFu5 (ORCPT ); Mon, 31 Jul 2023 01:50:57 -0400 Received: from bg4.exmail.qq.com (bg4.exmail.qq.com [43.154.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65DBBE76; Sun, 30 Jul 2023 22:50:55 -0700 (PDT) X-QQ-mid: bizesmtp68t1690782649tezi1726 Received: from dslab-main2-ubuntu.tail147f4.ts ( [202.201.15.117]) by bizesmtp.qq.com (ESMTP) with id ; Mon, 31 Jul 2023 13:50:47 +0800 (CST) X-QQ-SSF: 01200000000000704000000A0000000 X-QQ-FEAT: lO87fmWkX3HIdlFAfcAaSU54ZhJkQnHcfd0NxI/L0CMTSCQD5GQMbaxv2ExB3 Vb3xSIQr3LnxxXtg354jzyBPkZz5hvWUwn9K1zH0B6+YEa2BDvgENNLsOe5N0CwRrzbCueb ftemh3/tUhA17rKPM2v1yXcQQAoOXdqA5vkHJnOXmxc0n5rF6TFNIZ9BYf8LqzxirdkWC4d NZqxjjAo+Z0FYWV9emq73G7rj+oy8XONBUYJY7e2taLamipnq/eaMzFRw7YX5aAw3qt2a2O IcLPZ8tG2RoS9KcuIns1Ttz9TMt758U4m6vEE0C0DaYva/ca4GGMNZlwZLe5N5zzq+XKcOW l/eNWpqsCT7sohq73d+r9mjiHm0Qb5z+j+hBnoIjW8TfsvK5pc= X-QQ-GoodBg: 0 X-BIZMAIL-ID: 15683328812315869985 From: Yuan Tan To: w@1wt.eu, thomas@t-8ch.de Cc: falcon@tinylab.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Yuan Tan Subject: [PATCH v2 1/2] tools/nolibc: add pipe() and pipe2() support Date: Mon, 31 Jul 2023 13:50:45 +0800 Message-Id: <23019c9ad3a63d7026a60df8bc41934c3e74e564.1690733545.git.tanyuan@tinylab.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:tinylab.org:qybglogicsvrgz:qybglogicsvrgz5a-1 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772915091794451019 X-GMAIL-MSGID: 1772915091794451019 According to manual page [1], posix spec [2] and source code like arch/mips/kernel/syscall.c, for historic reasons, the sys_pipe() syscall on some architectures has an unusual calling convention. It returns results in two registers which means there is no need for it to do verify the validity of a userspace pointer argument. Historically that used to be expensive in Linux. These days the performance advantage is negligible. Nolibc doesn't support the unusual calling convention above, luckily Linux provides a generic sys_pipe2() with an additional flags argument from 2.6.27. If flags is 0, then pipe2() is the same as pipe(). So here we use sys_pipe2() to implement the pipe(). pipe2() is also provided to allow users to use flags argument on demand. [1]: https://man7.org/linux/man-pages/man2/pipe.2.html [2]: https://pubs.opengroup.org/onlinepubs/9699919799/functions/pipe.html Suggested-by: Zhangjin Wu Link: https://lore.kernel.org/all/20230729100401.GA4577@1wt.eu/ Signed-off-by: Yuan Tan --- tools/include/nolibc/sys.h | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/tools/include/nolibc/sys.h b/tools/include/nolibc/sys.h index 8bfe7db20b80..9fec09c22dbe 100644 --- a/tools/include/nolibc/sys.h +++ b/tools/include/nolibc/sys.h @@ -752,6 +752,30 @@ int open(const char *path, int flags, ...) } +/* + * int pipe2(int pipefd[2], int flags); + * int pipe(int pipefd[2]); + */ + +static __attribute__((unused)) +int sys_pipe2(int pipefd[2], int flags) +{ + return my_syscall2(__NR_pipe, pipefd, flags); +} + +static __attribute__((unused)) +int pipe2(int pipefd[2], int flags) +{ + return __sysret(sys_pipe2(pipefd, flags)); +} + +static __attribute__((unused)) +int pipe(int pipefd[2]) +{ + pipe2(pipefd, 0); +} + + /* * int prctl(int option, unsigned long arg2, unsigned long arg3, * unsigned long arg4, unsigned long arg5); From patchwork Mon Jul 31 05:51:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yuan Tan X-Patchwork-Id: 128353 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp1826634vqg; Sun, 30 Jul 2023 23:19:46 -0700 (PDT) X-Google-Smtp-Source: APBJJlH6/WtWfJEyMDk722oZRL8Fa4MQFwIzOowLA0E3mvd93E7iEXEp5Qq5wOr1S8mxkn9q6ubR X-Received: by 2002:a05:6a20:5483:b0:13a:cfdf:d7a1 with SMTP id i3-20020a056a20548300b0013acfdfd7a1mr10708689pzk.2.1690784385691; Sun, 30 Jul 2023 23:19:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690784385; cv=none; d=google.com; s=arc-20160816; b=MvBEU6ZlF1xOHeNBa/1AKau8k46zohzRLAFWzAgwUwR/bhh+5XCsN86XkPxD4qKXQD DxQo7f8WdQxRX1zj/wcFr7jy2stzJJfncxj56KwIIw6BXQ7Ui1NxfJI6UPXV1KwYAHtV zCHupEalljueCaXVOmR5wRkPK08r2i0RD/Qk6taJ5B4d/p5mHHBF7B47GK7CrbHVRdL7 r+Ri2vsM3VklUaTwzO3hJBaxQAY+hTWLyq1NoddOKmcxeTvqR1TUdwKgt4RH9s9Gcnpv pT0Y1QleR4OoD0olxFHCnHA0lY80MnBqDzRIUJ6MRh+S9bZtRKd4VuQirZ+uF7CZn1S6 212g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=JMaPzOGjgfVkSjQGLxdtHl4jNZJbK8eVXGPANJZlJeY=; fh=8heE8X7c/6KBQVGdiUUfEdY5Aql55kcYv0bNCPp9yaU=; b=G/F4NAO8nOGd7LE54QxCT6IfqSSot7r91u+1jDdD5ld0v1CCTqE79h3a6GSfuf7glq bM0dHnPPe/Z/WMVIAQn/K8W9GU4CEDxPz8MJhwZ+WYg5fXZmPmWpN3SpvMJahZyubYOx k7aLr/kjOj/DEGzZRjoR3z6/nbsMmWVAzU71Bl9jG/eLGeAS164QIZG+gmThm3nYICC4 K3oRFsRJzsb0s7ZMRtBkYjAlf2mkpNda1l/jIWYjneDl92+2kZ7T727X6td39uG/xkxy u/aFTnJC3+iWZo6+YphGYGxa+6Okjna2z0TOWqKahei0ZrCo5Y2NdTLzkBP0g90xOuVg tZ+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s3-20020a63d043000000b0055fdd2c3fd4si4250386pgi.22.2023.07.30.23.19.32; Sun, 30 Jul 2023 23:19:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230096AbjGaFvb (ORCPT + 99 others); Mon, 31 Jul 2023 01:51:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230102AbjGaFvX (ORCPT ); Mon, 31 Jul 2023 01:51:23 -0400 Received: from bg4.exmail.qq.com (bg4.exmail.qq.com [43.154.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E61781730; Sun, 30 Jul 2023 22:51:11 -0700 (PDT) X-QQ-mid: bizesmtp75t1690782665t6sax2el Received: from dslab-main2-ubuntu.tail147f4.ts ( [202.201.15.117]) by bizesmtp.qq.com (ESMTP) with id ; Mon, 31 Jul 2023 13:51:03 +0800 (CST) X-QQ-SSF: 01200000000000704000000A0000000 X-QQ-FEAT: jXjag1m6xl4TUwwOcxAHuSNvjezdnyUkeJyXtjE6BB1LN2sUyINMeltLYijKJ UMECH7SIllnAtxMSpIe2wh4MC38HJh6Vjamnwx6HerLMhs4ijK/ySftTd6SmXUXtSgBI6zF fdgepgMm9EFt3L9YSC/bFVrBnGow+n8WogQzdxwoXciLOZSmjVtdtnUWdmd3l4n9cOKh7s9 FitwrNZKDEevJn3RWFS4ficqy+A4GOlYHO3dvlEZkBA+p5n13KQF6lTPIIF6EMZDy+nWUNi PoJzti3ZCeUjBV0P90IyLi0sDKCraQ/Hzwrd2oFMoiZ78XlgKImyNU8Ac8D0eeCwTXCiniw JLazDYb9coRHXrMul12RLTJ7BMefgZSoqRYPt9kHjU+giphf34TNGRv9foQPw== X-QQ-GoodBg: 0 X-BIZMAIL-ID: 9840545900577853987 From: Yuan Tan To: w@1wt.eu, thomas@t-8ch.de Cc: falcon@tinylab.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Yuan Tan Subject: [PATCH v2 2/2] selftests/nolibc: add testcase for pipe Date: Mon, 31 Jul 2023 13:51:00 +0800 Message-Id: <9221753abe0509ef5cbb474a31873012e0e40706.1690733545.git.tanyuan@tinylab.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:tinylab.org:qybglogicsvrgz:qybglogicsvrgz5a-1 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772915928216825311 X-GMAIL-MSGID: 1772915928216825311 Add a testcase of pipe that child process sends message to parent process. Here we use memcmp() to avoid the output buffer issue. Suggested-by: Thomas Weißschuh Suggested-by: Willy Tarreau Link: https://lore.kernel.org/all/c5de2d13-3752-4e1b-90d9-f58cca99c702@t-8ch.de/ Signed-off-by: Yuan Tan --- tools/testing/selftests/nolibc/nolibc-test.c | 35 ++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c index 03b1d30f5507..2653ab8d5124 100644 --- a/tools/testing/selftests/nolibc/nolibc-test.c +++ b/tools/testing/selftests/nolibc/nolibc-test.c @@ -767,6 +767,41 @@ int test_mmap_munmap(void) return ret; } +int test_pipe(void) +{ + const char *const msg = "hello, nolibc"; + int pipefd[2]; + char buf[32]; + pid_t pid; + ssize_t len; + + if (pipe(pipefd) == -1) + return 1; + + pid = fork(); + + switch (pid) { + case -1: + return 1; + + case 0: + close(pipefd[0]); + write(pipefd[1], msg, strlen(msg)); + close(pipefd[1]); + exit(EXIT_SUCCESS); + + default: + close(pipefd[1]); + len = read(pipefd[0], buf, sizeof(buf)); + close(pipefd[0]); + waitpid(pid, NULL, 0); + + if (len != strlen(msg)) + return 1; + return !!memcmp(buf, msg, len); + } +} + /* Run syscall tests between IDs and . * Return 0 on success, non-zero on failure.