From patchwork Fri Jul 28 22:51:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 127892 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp746734vqg; Fri, 28 Jul 2023 16:25:19 -0700 (PDT) X-Google-Smtp-Source: APBJJlGfPnky3aCkF12smyRxb4qQnpQ0dpvk+UWq2vDh+wvI5bbdO1MSooT+63YhoVvVTNReUEHs X-Received: by 2002:a17:90a:8982:b0:263:d249:9b7 with SMTP id v2-20020a17090a898200b00263d24909b7mr3336447pjn.25.1690586718690; Fri, 28 Jul 2023 16:25:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690586718; cv=none; d=google.com; s=arc-20160816; b=dDlcCjpvDck0ytanBM73riq+6Q5hvaZeEabnSBXzdCrYFMOgc+ar3/OiKEFAzP39lA xcuBF1aGzJBwqVFvbumIbCmU+HuVjtTrENQO1QmlWXLm8ED2SkYLzaR6pDlajKncPF8i ZI1Ez7UYKbMV0mWY/cYLuvbjUMeDXiMG9++OM8g1YRkba0w10ipHEMnMv8xTRoeyLVVo 2cKujCIVUb0KMZIj1lJAwJDR5AsBR+NDZTJo1VbXkeu0NEGbtkn6WUY9/f1lMP9+zRRU FM01KS5IRhEeMZOZB5m8w6vKAUHYL9Y+xiVxvXfLmjzDHOYHTM8FXFcnn7ALY+Uq+8Et b6wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=0W78swAsRDw3bwp66LmS/YIYQ3HpBs97Fw94fZP2Co8=; fh=gsAi6XYBDlj2no5ch28ZlwFf5rjnIoE7OSMSOysE1bo=; b=09rz4cJ9eXZov/f6+dTA0M2ZbQ9MPfgmsbBBPi3EGUYQuq5CHI8pxtLYY7Ns+4HO5U zLjsx5MEDHi59196A+slb1uLaMRu79BhMnD7dQEcqUR/3+09SQ5u4SpiF6vKPDw5MWVA juZRjQLQBEwjllg2h28URCJM5hD+pghPuwMJHMkjlLrHE2nx46qBr9N6HD0A6kIfatPG EgCxKYaiVePk2WbvWKhBmPNUAY6N2AX4YpAe/ivTdvL7zY543h6WPgrwFciXSglIl3xq xV6CLbCy0yA1JXX2ij3mcpk97asjNxe1Av1g8RUUMMKpBkoNWBgDp3CgFc7fR0sjL7ui otDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SXbqMisz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ie18-20020a17090b401200b002639acf55c7si5307831pjb.7.2023.07.28.16.25.05; Fri, 28 Jul 2023 16:25:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SXbqMisz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234523AbjG1WwT (ORCPT + 99 others); Fri, 28 Jul 2023 18:52:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229615AbjG1WwR (ORCPT ); Fri, 28 Jul 2023 18:52:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3DF81739 for ; Fri, 28 Jul 2023 15:52:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 61E7A621A9 for ; Fri, 28 Jul 2023 22:52:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97588C433CA; Fri, 28 Jul 2023 22:52:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690584735; bh=/VxquELnUb4G2FURJ1lShYSnMPZoWyDDj/JtcT/O038=; h=From:Date:Subject:To:Cc:From; b=SXbqMisz2YGQcuuUD6CnCnsM+La5M9h7N/Qh3nRef2LDxSxhI+e1NzE+Is0pWdnc/ Jy+H0XG0Z86EFr6pgG79LsEdY60jC2pGEYzz/2pxPh4SoEKa2SHanOCZ8ruOo4Bjfm r45C/P+gGz/xPlnrkM6OLVnLLX1bhy8wT91MQfZJyWIJ5TSAT2WmrMDG1V4c4xl9Ta aBgDXYPRjQs+j+CSpdRiQM+Ug32gTF5//4kPYpUrK76ji+yntbYPNOgoT6RnaOODgU moaW7wBJNgCiBk2Yim4/b910q+4A0+f9aFUwEQmh7DfGDgc28f2jIZmOOZawVQiF64 OBLR0LVJ0beHA== From: Mark Brown Date: Fri, 28 Jul 2023 23:51:03 +0100 Subject: [PATCH v2] net: netsec: Ignore 'phy-mode' on SynQuacer in DT mode MIME-Version: 1.0 Message-Id: <20230728-synquacer-net-v2-1-aea4d4f32b26@kernel.org> X-B4-Tracking: v=1; b=H4sIAFZGxGQC/3WMQQ6CMBAAv0L27Bpaaqqe/IfhAO0WGk3BLTYS0 r9buXucSWY2iMSeIlyrDZiSj34KBeShAjN2YSD0tjDIWja1lhrjGl7vzhBjoAVJKuEa1RfRQ2l mJuc/++/eFh59XCZe930SP/vvlAQKVFa7k1HGnO3l9iAO9DxOPECbc/4CofclDKsAAAA= To: Jassi Brar , Ilias Apalodimas , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ard Biesheuvel Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.13-dev-099c9 X-Developer-Signature: v=1; a=openpgp-sha256; l=2412; i=broonie@kernel.org; h=from:subject:message-id; bh=/VxquELnUb4G2FURJ1lShYSnMPZoWyDDj/JtcT/O038=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBkxEac/HgX4BM2ZmomaS9LhsHegblYFAkBMWx3s XFDBAbcIPmJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZMRGnAAKCRAk1otyXVSH 0BSjB/9Da88h6x31LhquQ0af5opa2737G1k++8n6+9Avn+iYmb2GaxANvyu38XUl0pDkAzdLXxg x9Mpf9tYrafwb7eeD04TKZdcU+OB000IHy9sizl+Pt+/JJbkrXYLK4VWHfrXiDeKWvd0LpweBTv LYmQWgMGjzdT+rnw+zEmjlFbq9MbUMLAR5t3OEYpa4Sk+fot2XMxrRUvlVTNw5GATslKyYgB9Lo QSP22A+wW/Y3Q7rfDnmy1brKOIdyLf/pFxLCxa45+fOoicMoBHNPrm+Dd1CE6tWfY/Tub8j1z/Q Dz3Oaf17PfY5bHkryYoU8+BuP+rozCiAKLps4nHjdTvWcVYP X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772614137072925079 X-GMAIL-MSGID: 1772708658942564938 As documented in acd7aaf51b20 ("netsec: ignore 'phy-mode' device property on ACPI systems") the SocioNext SynQuacer platform ships with firmware defining the PHY mode as RGMII even though the physical configuration of the PHY is for TX and RX commits. Since bbc4d71d63549bc ("net: phy: realtek: fix rtl8211e rx/tx delay config") this has caused misconfiguration of the PHY, rendering the network unusable. This was worked around for ACPI by ignoring the phy-mode property but the system is also used with DT. For DT instead if we're running on a SynQuacer force a working PHY mode, as well as the standard EDK2 firmware with DT there are also some of these systems that use u-boot and might not initialise the PHY if not netbooting. Newer firmware imagaes for at least EDK2 are available from Linaro so print a warning when doing this. Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver") Signed-off-by: Mark Brown --- Changes in v2: - Unlike ACPI force what appears to be the correct mode, there are u-boot firmwares which might not configure the PHY. - Link to v1: https://lore.kernel.org/r/20230727-synquacer-net-v1-1-4d7f5c4cc8d9@kernel.org --- drivers/net/ethernet/socionext/netsec.c | 11 +++++++++++ 1 file changed, 11 insertions(+) --- base-commit: 6eaae198076080886b9e7d57f4ae06fa782f90ef change-id: 20230727-synquacer-net-e241f34baceb Best regards, diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c index 2d7347b71c41..cdb05db3d6ac 100644 --- a/drivers/net/ethernet/socionext/netsec.c +++ b/drivers/net/ethernet/socionext/netsec.c @@ -1851,6 +1851,17 @@ static int netsec_of_probe(struct platform_device *pdev, return err; } + /* + * SynQuacer is physically configured with TX and RX delays + * but the standard firwmare claimed otherwise for a long + * time, ignore it. + */ + if (of_machine_is_compatible("socionext,developer-box") && + priv->phy_interface != PHY_INTERFACE_MODE_RGMII_ID) { + dev_warn(&pdev->dev, "Outdated firmware reports incorrect PHY mode, overriding\n"); + priv->phy_interface = PHY_INTERFACE_MODE_RGMII_ID; + } + priv->phy_np = of_parse_phandle(pdev->dev.of_node, "phy-handle", 0); if (!priv->phy_np) { dev_err(&pdev->dev, "missing required property 'phy-handle'\n");