From patchwork Fri Jul 28 17:29:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Shuah Khan X-Patchwork-Id: 127824 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp616599vqg; Fri, 28 Jul 2023 11:25:18 -0700 (PDT) X-Google-Smtp-Source: APBJJlEpXhbVUBllfCzs9h8FiVOyEIDtFF9qOnWMFdAqsnrXxeIc3giiMhH1/bAK0AMDe/x/dRVn X-Received: by 2002:a05:6a21:790a:b0:137:48cc:9cfa with SMTP id bg10-20020a056a21790a00b0013748cc9cfamr1880135pzc.24.1690568717811; Fri, 28 Jul 2023 11:25:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690568717; cv=none; d=google.com; s=arc-20160816; b=gOtoFEhhSuTj+ZeqtMcp2DNiWRQxGI5VKn10A1aFkx6mpwxVhIHYTlAnncfgatPudk zE4p/xZu0URMx0fhqDbPkZ4W3/77RWoNa0vA0dTcQM+UV3V3ZHj3Y6fLv0iB5zmMz3h6 eL+wKxDz5q2WUKlKZATTm+xn0MZdgER4r82ZorM1uDF5P2tvWvzIeP4tfu0YcW46VLI+ t65SaDxBAL4GyHTuwBJTUdKiOPmBPxoRh1v6N1U58CTKLlOw9Oe2ywcffV1GSViUrlnI YloKPOa17VJYLqs7kuKxuLog1C813L2r+zltKTxCm+6SEP/ipbHIamNtaJo97exCePRl SIyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TyD41TjCbmVuD3Q46FNMhjbjisbmz8hDWYj37AkUnHk=; fh=yCidwXy35mqeYY6eogBmAKa0Gqv9iSvC+rHY2Lis5gk=; b=GdIThy5lSjUspAcKXnubyhwtpDdQVfjSUsMRL9gi2SXgZ3kEK4zM681I/YVnFACWwT bVfQaMBQJWFaSwVkNpEIeIuOfs6y2taagF18EyITXLiFPK1oUwFgrom35xZ6TRu981s3 1vEdUGeuMrm0jb5Tnx6m371J5mrd+BGAhpyN3MbE+jazHLJawUOmMSckI0qOIUvfmzKm T991Sv7N8g8wi95DtsXCeGLWPT/CBejh4D6dT1tciW0ULyi30/KaPHTXmTNNZXMkgPGP tVk88KLWaD6V4t9mPDH0kxUDmZ5g4l4X8Q14tyDgv4a9FXBSgmfusJdoa0VrZyo2e5Da Q+6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=hRWim4l1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cd23-20020a056a00421700b0068719ad3172si249888pfb.76.2023.07.28.11.25.03; Fri, 28 Jul 2023 11:25:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=hRWim4l1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234402AbjG1R3x (ORCPT + 99 others); Fri, 28 Jul 2023 13:29:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231667AbjG1R3h (ORCPT ); Fri, 28 Jul 2023 13:29:37 -0400 Received: from mail-il1-x142.google.com (mail-il1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CED435BF for ; Fri, 28 Jul 2023 10:29:32 -0700 (PDT) Received: by mail-il1-x142.google.com with SMTP id e9e14a558f8ab-348dfefd2d6so2041475ab.1 for ; Fri, 28 Jul 2023 10:29:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1690565371; x=1691170171; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TyD41TjCbmVuD3Q46FNMhjbjisbmz8hDWYj37AkUnHk=; b=hRWim4l1+IGA137PJlwexSNurfpuER9flcSAxOm4LsJLdw4LW3UU3afJMVs4uU00D3 1Qt5g/3GnnH930VtMFyQBycmOwkuWCDxTkUfNRg36JNk6CjHSj/4FJQSx52zavvuSDms r8tm/WVlJJnSmLy94GGd+gUn1klK5b8ETym7Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690565371; x=1691170171; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TyD41TjCbmVuD3Q46FNMhjbjisbmz8hDWYj37AkUnHk=; b=hjxyUQfOgngO1cAaJHZz34REFxH8wo4XPDrebTZfxWuu9td7fDmsBRCihbBrnZLIWJ L5dFxhhJp13nTAjLVsMq0qoJAH+986zy3f43lDJAGsma/3eg1g1I3lAgp5hV5dA9mPIR /R3JqjEJMxavySL0dUjLI8JsIl5ukSdT6cunGVSaWdrrYQmsOPAiqAcJ1WMCR4EpgSd1 1r2HHqlS7AKM/bLzWmcN3QqK7cF161gSfNyWpalFDiaztUg8pU2lHH8V5yhApBohliFy SoqpP68ZstXYvm1urtnjV4GmtnEFUrBf/rLv0SdlTplrgK7undpcXgDXoVLS6jCUIEFi AXvg== X-Gm-Message-State: ABy/qLaV0GIfiNbMmExoNzFs0F4y3Frb/r1LKlwoQIGfhNxgAdewIgUm mEPWqgZ5vhO8hCdIhaLvIbSmZg== X-Received: by 2002:a05:6602:2b91:b0:77a:ee79:652 with SMTP id r17-20020a0566022b9100b0077aee790652mr339190iov.1.1690565371630; Fri, 28 Jul 2023 10:29:31 -0700 (PDT) Received: from shuah-tx13.internal ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id b2-20020a029a02000000b0042b37dda71asm1181050jal.136.2023.07.28.10.29.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 10:29:30 -0700 (PDT) From: Shuah Khan To: shuah@kernel.org, Liam.Howlett@oracle.com, anjali.k.kulkarni@oracle.com, naresh.kamboju@linaro.org, kuba@kernel.org Cc: Shuah Khan , davem@davemloft.net, lkft-triage@lists.linaro.org, netdev@vger.kernel.org, llvm@lists.linux.dev, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH next 1/3] selftests:connector: Fix Makefile to include KHDR_INCLUDES Date: Fri, 28 Jul 2023 11:29:26 -0600 Message-Id: X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772689783344613596 X-GMAIL-MSGID: 1772689783344613596 The test compile fails with following errors. Fix the Makefile CFLAGS to include KHDR_INCLUDES to pull in uapi defines. gcc -Wall proc_filter.c -o ../tools/testing/selftests/connector/proc_filter proc_filter.c: In function ‘send_message’: proc_filter.c:22:33: error: invalid application of ‘sizeof’ to incomplete type ‘struct proc_input’ 22 | sizeof(struct proc_input)) | ^~~~~~ proc_filter.c:42:19: note: in expansion of macro ‘NL_MESSAGE_SIZE’ 42 | char buff[NL_MESSAGE_SIZE]; | ^~~~~~~~~~~~~~~ proc_filter.c:22:33: error: invalid application of ‘sizeof’ to incomplete type ‘struct proc_input’ 22 | sizeof(struct proc_input)) | ^~~~~~ proc_filter.c:48:34: note: in expansion of macro ‘NL_MESSAGE_SIZE’ 48 | hdr->nlmsg_len = NL_MESSAGE_SIZE; | ^~~~~~~~~~~~~~~ ` Reported-by: Naresh Kamboju Link: https://lore.kernel.org/all/CA+G9fYt=6ysz636XcQ=-KJp7vJcMZ=NjbQBrn77v7vnTcfP2cA@mail.gmail.com/ Signed-off-by: Shuah Khan Reviewed-by: Anjali Kulkarni --- tools/testing/selftests/connector/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/connector/Makefile b/tools/testing/selftests/connector/Makefile index 21c9f3a973a0..92188b9bac5c 100644 --- a/tools/testing/selftests/connector/Makefile +++ b/tools/testing/selftests/connector/Makefile @@ -1,5 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 -CFLAGS += -Wall +CFLAGS += -Wall $(KHDR_INCLUDES) TEST_GEN_PROGS = proc_filter From patchwork Fri Jul 28 17:29:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuah Khan X-Patchwork-Id: 127812 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp615887vqg; Fri, 28 Jul 2023 11:23:51 -0700 (PDT) X-Google-Smtp-Source: APBJJlG2fCkCqNcYun6+bCB607pPyQtbBxEHyCLwwcLbUk1lQznRc/kz/71K5zlW6eSnrURrueD3 X-Received: by 2002:a17:903:1d1:b0:1bb:ed65:5e0d with SMTP id e17-20020a17090301d100b001bbed655e0dmr2718630plh.56.1690568631306; Fri, 28 Jul 2023 11:23:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690568631; cv=none; d=google.com; s=arc-20160816; b=w+kpLk8S/qLs/b546/aIMJ2TUf/F33/zZW9a6BcAGwF2AvL1Ls/M1PfoNYi6/tUPwR Ao2vSx9/q+zUszAlmL92J2S12pbYBVBqwe9ifGLX8J8BYssL0+Drig/gnkf5A1Peod4K YTQ0ij6vSaysLK5Cb1o5+pzp27xUzp5UGvCmGOoPdDcWx14Y/LcqIUhua4y7zguLfka2 v7hzlpdTubjA5YE9z0NMSYd4g0asZj28UXdjjdDPTk2hBoVixagxghjlfJvB+RB3sAvJ 2Qdcf2V6YoyzlJWJIeDaClWznihygk8YyPWFGR8C25Mb2xTra8sbea88DgTdNlX5I8x1 oTjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KuA89WjH66+oRZgNKFoC7RQpjlgTsdzDJBprqnr0FHw=; fh=l/oUealUa4VFJ0aIVGOctW3sF8GPVBNsFSkLI4WH5kA=; b=PLSrRZdS0YceMbH2vVAgqDgFmTvUXzIlJIjxMsOZcrbIciirBE6ZcTnOVILnnPnc0y kVsr19CORCds6LN5y3AGmyl/d4Ss5+m1hRmLrM1v28rca/DPUD6j65oixV2BJoxRQ6RB 3r/A6KbVUwCJ6puscLa412DcC9s2510LIY21NuIctUKeyt0ahicsmJzCnLESU3+mRH+r oLtP3vQrT9YdnD1GV/b1Im8hJdGAXzcDCGqSmYKO5Xd8Am7nwxanFklEK2Z7yhXNqc9I IjEmOvPDPV0P74tQJQ6/QGR8wPBADiABZ970C48bn/V8hHiwERNHtPhRC1wOKutew72q pQUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=IAy+tr7w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kx15-20020a170902f94f00b001b81fe65fa3si3353413plb.569.2023.07.28.11.23.38; Fri, 28 Jul 2023 11:23:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=IAy+tr7w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234342AbjG1R3u (ORCPT + 99 others); Fri, 28 Jul 2023 13:29:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233756AbjG1R3f (ORCPT ); Fri, 28 Jul 2023 13:29:35 -0400 Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F7003A99 for ; Fri, 28 Jul 2023 10:29:33 -0700 (PDT) Received: by mail-il1-x136.google.com with SMTP id e9e14a558f8ab-348dfefd2d6so2041495ab.1 for ; Fri, 28 Jul 2023 10:29:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1690565373; x=1691170173; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KuA89WjH66+oRZgNKFoC7RQpjlgTsdzDJBprqnr0FHw=; b=IAy+tr7webKUVIYTbYZ3+jMG9e+SLvCy1lRwlIA6odcD7pfpmsLH4n/Zmptj2QKAN+ MjcbIvWBxeRLPNXObo+QhSNvUR5blz1BhmX5B3NYGTkyP7ONmVDuirYJxkDS8cx73hj3 Ox5zA+1aTG9Feo6KNRFjFnSS8qc0eIoTzcNL8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690565373; x=1691170173; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KuA89WjH66+oRZgNKFoC7RQpjlgTsdzDJBprqnr0FHw=; b=cAsjzcam1EIwVVvKZmIBwWrXmDzuDk1s+lKSptsc7TaX/kpF6eq4F7KKwj6GtzHKTs 7FbTAsV/c/DqwVNxuZIWUbRDVffT2xbkznBmYcge7d8qCBnB8g63ffiNcg+Z3Hec/IOr i0BRMX2nV0ScgGbiLT9hIdwlGaY3jEBX35bf4NWxoeHzJV4pTpOw13ReYxrNPFJqi9eN 0ORSuxSsGBh15QGzfj1bD+a3MypOHasmJUtNaejqj8HO6AczeLi3/pwHMYc2C8QkDiU5 8Dma+FW+zGpNxdzY6wPH88DKr3bvbQRSRFJkGaswvAa9pBMHa8tYQOhjol8w2w+Rg0lm QqFA== X-Gm-Message-State: ABy/qLZXuFwQVvzH1eoddbwwApsqYBCsdTpU9qn2tygQC0SNtA67U2si 6l35OTmBRKUo2ULaCwy7wHK1PQ== X-Received: by 2002:a05:6602:2b91:b0:77a:ee79:652 with SMTP id r17-20020a0566022b9100b0077aee790652mr339316iov.1.1690565372907; Fri, 28 Jul 2023 10:29:32 -0700 (PDT) Received: from shuah-tx13.internal ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id b2-20020a029a02000000b0042b37dda71asm1181050jal.136.2023.07.28.10.29.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 10:29:32 -0700 (PDT) From: Shuah Khan To: shuah@kernel.org, Liam.Howlett@oracle.com, anjali.k.kulkarni@oracle.com, kuba@kernel.org Cc: Shuah Khan , davem@davemloft.net, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH next 3/3] selftests:connector: Add root check and fix arg error paths to skip Date: Fri, 28 Jul 2023 11:29:28 -0600 Message-Id: <2c0ac97f9c8e6bd46b60854c136099c0dd4a09f6.1690564372.git.skhan@linuxfoundation.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772689692713183845 X-GMAIL-MSGID: 1772689692713183845 proc_filter test requires root privileges. Add root privilege check and skip the test. Also fix argument parsing paths to skip in their error legs. Signed-off-by: Shuah Khan --- tools/testing/selftests/connector/proc_filter.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/connector/proc_filter.c b/tools/testing/selftests/connector/proc_filter.c index 4fe8c6763fd8..7b2081b98e5c 100644 --- a/tools/testing/selftests/connector/proc_filter.c +++ b/tools/testing/selftests/connector/proc_filter.c @@ -248,7 +248,7 @@ int main(int argc, char *argv[]) if (argc > 2) { printf("Expected 0(assume no-filter) or 1 argument(-f)\n"); - exit(1); + exit(KSFT_SKIP); } if (argc == 2) { @@ -256,10 +256,15 @@ int main(int argc, char *argv[]) filter = 1; } else { printf("Valid option : -f (for filter feature)\n"); - exit(1); + exit(KSFT_SKIP); } } + if (geteuid()) { + printf("Connector test requires root privileges.\n"); + exit(KSFT_SKIP); + } + if (filter) { input.event_type = PROC_EVENT_NONZERO_EXIT; input.mcast_op = PROC_CN_MCAST_LISTEN;