From patchwork Fri Jul 28 17:12:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugo Villeneuve X-Patchwork-Id: 127800 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp595869vqg; Fri, 28 Jul 2023 10:45:24 -0700 (PDT) X-Google-Smtp-Source: APBJJlGAvcc6bOcJP1/sKGMju6s+qn7EFyZJsbFEsJSYybwyo3ww9jvHX7HGFGdRj3Eu5/6wl+lW X-Received: by 2002:a2e:7816:0:b0:2b9:5fee:6908 with SMTP id t22-20020a2e7816000000b002b95fee6908mr2538937ljc.18.1690566323908; Fri, 28 Jul 2023 10:45:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690566323; cv=none; d=google.com; s=arc-20160816; b=nNDk+8tciXwhrUcl6j4hcTmX+v/obd6I+GYLK2ux/BFNpbTrgtMETH/t0kUN6WK1ok V7ueHzU49FTPISalat1o/tZbK6p8ioFWd2dvA4cLXUIrZcrbk+cTJdG8FkHFRPkHBJCk 31GmnKIoxKgz2EG6jrnPnVX1t+HbtjCrBeTVU1Rkjbt3zVeTEavH0T1zA2RldCw4KC6Y sCromTIh6zESCcR/paePZVpPGhX9AJefjMfkj0D3cbvinvSYt1moVZopC2/ndpeejIvK ZoqQ3zzIp0hOKnypTGrTTAzeczLL3c8sTovo+g14eR7DRxfDJhG8wvSPmalzqHaLn5Jm msCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :message-id:date:cc:to:from:dkim-signature; bh=iapXccHtapXvoYza5A60N8Syh4OAAzH77Y1/wEH0vXk=; fh=6LhdUTwFsDk4MQCCbKOOS7PY1zHy93RXDm/uFHT4xt4=; b=Lj+Fw9wkg3qUR3hWQsld5GXlV30egM7oHGx0/qeHKqyLNjrHbU2CBAjPQCMdE3RTJ+ mi3UbQDmtuG9D7t4blxIG4bF5z/wy/98BdfX/gJWgp0n9Ewvnz0gUaZ1gyTLukDtVJGR ZtvSDtaboIFFd/iaQhSImolIv4majPzeIkBglSKEbnESdrIOEjshKdLnj+YPOn8UlO1q VCav9s5SPIh3ssnu0SaYjFqAMMi/49BczcMRhG65nYseRQiEvw7gy/E1nsv2nGqEG9D4 4ycY9cJw/mel58ugsojNnv9wtvTohVUxtTWh4LDrC7EVIf1kDMY23U10ZVAhQr7a2fiX B+ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=I0VWY96J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c8-20020a170906340800b00992ae2a902dsi2842852ejb.786.2023.07.28.10.44.57; Fri, 28 Jul 2023 10:45:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=I0VWY96J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232239AbjG1RMp (ORCPT + 99 others); Fri, 28 Jul 2023 13:12:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231792AbjG1RMg (ORCPT ); Fri, 28 Jul 2023 13:12:36 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C466035A9; Fri, 28 Jul 2023 10:12:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Cc:To :From:Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=iapXccHtapXvoYza5A60N8Syh4OAAzH77Y1/wEH0vXk=; b=I 0VWY96Jm2YDqvFYQSB7OI5DXRYWy7LOpq1Ke+wKgqqr+Y7tow0tB3yUWkuOLthqrsDaLWjJnZ1huM xbXMA/qrT85Ez5dRVcrL1Xbl3lp/85pSVERXmZuVeGT5s0KZNqf8sJzNISb1zmxUz0AnmqRU8EH51 LjlOdGXfEKBPdEUU=; Received: from modemcable061.19-161-184.mc.videotron.ca ([184.161.19.61]:53782 helo=localhost.localdomain) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1qPR0u-0003RD-Nz; Fri, 28 Jul 2023 13:12:29 -0400 From: Hugo Villeneuve To: Alessandro Zummo , Alexandre Belloni Cc: hugo@hugovil.com, Hugo Villeneuve , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 28 Jul 2023 13:12:12 -0400 Message-Id: <20230728171211.3016019-1-hugo@hugovil.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 184.161.19.61 X-SA-Exim-Mail-From: hugo@hugovil.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Subject: [RESEND PATCH v2] rtc: pcf2127: add error checking when disabling POR0 X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772687273772873668 X-GMAIL-MSGID: 1772687273772873668 From: Hugo Villeneuve If PCF2127 device is absent from the I2C bus, or if there is a communication problem, disabling POR0 may fail silently and we still continue with probing the device. In that case, abort probe operation. Signed-off-by: Hugo Villeneuve --- V1 -> V2: Removed error message --- drivers/rtc/rtc-pcf2127.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) base-commit: 3c87b351809f220294aec3c0df7b078ff5c5b15b diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c index 78141bb06ab0..3387afe93417 100644 --- a/drivers/rtc/rtc-pcf2127.c +++ b/drivers/rtc/rtc-pcf2127.c @@ -1192,8 +1192,10 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap, * The "Power-On Reset Override" facility prevents the RTC to do a reset * after power on. For normal operation the PORO must be disabled. */ - regmap_clear_bits(pcf2127->regmap, PCF2127_REG_CTRL1, + ret = regmap_clear_bits(pcf2127->regmap, PCF2127_REG_CTRL1, PCF2127_BIT_CTRL1_POR_OVRD); + if (ret < 0) + return ret; ret = regmap_read(pcf2127->regmap, pcf2127->cfg->reg_clkout, &val); if (ret < 0)