From patchwork Thu Jul 27 18:05:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sohil Mehta X-Patchwork-Id: 127116 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp1314748vqo; Thu, 27 Jul 2023 12:20:42 -0700 (PDT) X-Google-Smtp-Source: APBJJlGXuzCvz1sreLAT70MGn8TL44Pgsk0ZqOnzU63LCpaZ62Hfjawlt+RWx2AuixKOeAHuDkwR X-Received: by 2002:a17:906:cc4b:b0:992:33ba:2eb4 with SMTP id mm11-20020a170906cc4b00b0099233ba2eb4mr104715ejb.71.1690485641988; Thu, 27 Jul 2023 12:20:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690485641; cv=none; d=google.com; s=arc-20160816; b=ZGLG+2yTfdgsZJe2QFJ7ZqbkzJ5GcA2zCXDyZsGz/s4RaAgRmZHiHrSmzjD9oxz2Ye qYFpPkfST293gXjr+vsVbGNwGtbC/52+ysYshSydnVlWgTlzAvAnW9OSRGMbGuerlAaF hLZMvqX1nqvhrC6XC7drneb1tat6BrMJHx904Tl1deKXKvLosYXOMMycLw0BtRSlwY3s qDSoRzanfIeOlZhCRA+yugask9UDf/SREUHwFnWcu98v+hNcWwS3IUZDVDP8PRr0cBp/ lkrDhjrsN3do+iAH28LUxEEwNKx3tqrvvGL9bjHSGw6XFwQs0UZH8A894MhjszFqlVly 61SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=93E33ZKfAl5JJkvyPzORYbXlY6B7AsRtnJA2pSsZ5Ec=; fh=+HHxJj+jtdJUKsrKMnpt0SoOHEFfnZ3HUVGrTHJPU+Y=; b=Y+pJpUTW06RWXtr/12xUddvRSefeMqAdDXOebiJWU6rvGRpWxIkgwUTSGIcaRFT8k2 oCQrf0FnZQJEv73gP7r2/i1YsasR81zTpaeILxPwW4p5t6j+1CfG31REN5fDDkHT6vrQ ev7bIPwGAYWDtxm68AmZQKyzkMbz8ZLnM1GKkdWm8/CUTUNy8uMvsnGPIlCfICvVAnlh Pq1eZnz7U8TFnHKEajcfak42DBSFCRMnif+jxoAtUUfRhc2xJlHCDaySWtaSXiDevDuo 0dDppgWqm0TkSTEUqgLXWsMXkT3QxHWVyBmEjQfMAHvXzolE69OonFedM0/pmJ1fSvka lIWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gb9JxKAL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y5-20020a170906558500b0099bc8f939b8si1514840ejp.265.2023.07.27.12.20.16; Thu, 27 Jul 2023 12:20:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gb9JxKAL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231287AbjG0SGt (ORCPT + 99 others); Thu, 27 Jul 2023 14:06:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230230AbjG0SGr (ORCPT ); Thu, 27 Jul 2023 14:06:47 -0400 Received: from mgamail.intel.com (unknown [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F07652D5B for ; Thu, 27 Jul 2023 11:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690481206; x=1722017206; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pNajP0H5SUJ9f+Q1Onyg09lY/pVe/W2pk6K32ziRX90=; b=gb9JxKALS1REZGkMaAFDjgpsW3NvfF0YzytTfFV/dkO+q2XV8cFVZcZE 1lvy/+uRP6S9AKLAM8gvQRp+MkAW7jx/6Nryy6cStYMqYoRdBpQ7DV8ke xd+N610z0p9MQsQQcX+aNWQg6sFMzMJqiXg0Zs3ZTNzg+3SUSzxsg+QZm sO51Dkq+C89cMvBErz2BrWwbDy9F8gaCPVBNDVoHedcFG7Ig2tKMeqMwe bEyalnvN97A5lwgBEdfhT7+ny3X4pghX99e//+/b2ZvcTqTyBc+B1H8FD td/dNMvd0DWWy/4r7rkd2OeaOpc29nMmyPe7YO1X/KmqL7g0057UV1gLE Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="454760087" X-IronPort-AV: E=Sophos;i="6.01,235,1684825200"; d="scan'208";a="454760087" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2023 11:06:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="870523921" Received: from sohilmeh.sc.intel.com ([172.25.103.65]) by fmsmga001.fm.intel.com with ESMTP; 27 Jul 2023 11:06:47 -0700 From: Sohil Mehta To: x86@kernel.org, Thomas Gleixner , Peter Zijlstra Cc: Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Tony Luck , Sohil Mehta , linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] x86/smpboot: Remove a stray comment about CPU hotplug Date: Thu, 27 Jul 2023 18:05:31 +0000 Message-Id: <20230727180533.3119660-2-sohil.mehta@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230727180533.3119660-1-sohil.mehta@intel.com> References: <20230727180533.3119660-1-sohil.mehta@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772602672358442687 X-GMAIL-MSGID: 1772602672358442687 This old comment is irrelavant to the logic of disabling interrupts and could be misleading. Remove it. Now, hlt_play_dead() resembles the code that the comment was initially added for, but, it doesn't make sense anymore because an offlined cpu could also be put into other states such as mwait. Signed-off-by: Sohil Mehta --- arch/x86/kernel/smpboot.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index e1aa2cd7734b..6a09a021b534 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1614,9 +1614,7 @@ void play_dead_common(void) idle_task_exit(); cpuhp_ap_report_dead(); - /* - * With physical CPU hotplug, we should halt the cpu - */ + local_irq_disable(); } From patchwork Thu Jul 27 18:05:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sohil Mehta X-Patchwork-Id: 127109 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp1294927vqo; Thu, 27 Jul 2023 11:44:39 -0700 (PDT) X-Google-Smtp-Source: APBJJlHHToCF1CvbwOtcGZx2dJvIax1+YtNZkTTR9z9XtJt3RzRalOUJpuhdpbbsNT259ty9nBIU X-Received: by 2002:a17:907:2ccc:b0:99b:484b:21b4 with SMTP id hg12-20020a1709072ccc00b0099b484b21b4mr224777ejc.8.1690483478811; Thu, 27 Jul 2023 11:44:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690483478; cv=none; d=google.com; s=arc-20160816; b=wGXN7pva4Hfwg2piC1slznO07EFV4vVbY940Ad3e0uFsKDsCHP6EsGLmkCYxt6NPUf BYUJSHnjSo1oTBnksDpZX8a0l853wA8CxsaVo5a/VauU4rqRXRuzfTAETSIZNZmrOh7Y F6flvvtU9hoX5ZlgsAv4vRmsv2iWDGnHJpEWjL7v8k5joz9Ifn07Z9/VUdj4f+Txt5H6 jDrBhLSIy3yJ2hPknbCJ5NrdoHz2VPP9XkJ3C5YHP7YvBghMGb+QT4W0oQBGZ0FkTkNS dVBAlAKXDS+D+s0SjkNV0c3eUSTBowj4JRrhqJs1dyYi0Zzs6oVaxMCcXA3g/gN94hNU qELw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=v5f/eizfIA9R5PoWEHLXuy4rcOyJd+4nlHpxQgpOnGg=; fh=+HHxJj+jtdJUKsrKMnpt0SoOHEFfnZ3HUVGrTHJPU+Y=; b=fHchcI3TD/Ta2MCeEkHkWcqhVzh3AZKFcSG5rsXbizLp5gunL4BcKUmJuaFTqgc94t UEmeJX2BEF0WRo4AY2eLod790l1L0ZnTf9Be/KBY6lQYcC+BfOlwEzT14WfffXVzDyvT YQo8wxwg6SzBOtrvO0QMnFZB0jDVaP30udhil3xUSGoS0rniM0xS3dvS+MVdDLn7DsUZ MVQsKOILow/ryS4rNUsISgGueoLCzXAUowWU5s8mv3rRCzQSft/MYuIy+UqQPZp/j6eD wOnpujQZUZnuXoH49dtlXraQcdC9CyjQ4lXE5XNNLBI9m63TutsD5ucmabv3prNdXzJy /l5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Z5kXAlFT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a12-20020a170906684c00b00992a91b422fsi975186ejs.41.2023.07.27.11.44.12; Thu, 27 Jul 2023 11:44:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Z5kXAlFT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231361AbjG0SGv (ORCPT + 99 others); Thu, 27 Jul 2023 14:06:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231293AbjG0SGt (ORCPT ); Thu, 27 Jul 2023 14:06:49 -0400 Received: from mgamail.intel.com (unknown [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5818D2D64 for ; Thu, 27 Jul 2023 11:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690481207; x=1722017207; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mr2dxah7WXzCzQIlxM3ZK1C/zanGAvJYwpX4ZaRJNIw=; b=Z5kXAlFTeCxcI3A5C9P8JmJNk3KAFwbXDbDdFsjlnXcoubk0mbJG9+hE 30+S95MdB2Gqz9r8KkBWcyOxyzpPmj/lwHqOIV4uKWBkKC9Wxcq2jsYZL v36XflXWBEdBnNHu30YUSIqzapdbvWq9z3GAKTm9tSNqzEPdz6TFZLrqu i5/mSrA/9LAMH7/Xq+XAh6831J0SFU5WA99QjfuM9xEraVWQcPsyPcN6X c7cvxzlj6BCY2oRCBMY9r9kN6cDffrsyMjTzaRQa97GMmLdYphNXCIu2v 5gxFCXZjXe1A+EAluIS5J80vJLr5nZ64y05s+0wCN//irCoqEnI3pdM0G w==; X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="454760096" X-IronPort-AV: E=Sophos;i="6.01,235,1684825200"; d="scan'208";a="454760096" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2023 11:06:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="870523924" Received: from sohilmeh.sc.intel.com ([172.25.103.65]) by fmsmga001.fm.intel.com with ESMTP; 27 Jul 2023 11:06:48 -0700 From: Sohil Mehta To: x86@kernel.org, Thomas Gleixner , Peter Zijlstra Cc: Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Tony Luck , Sohil Mehta , linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] x86/smp: Remove a non-existent function declaration Date: Thu, 27 Jul 2023 18:05:32 +0000 Message-Id: <20230727180533.3119660-3-sohil.mehta@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230727180533.3119660-1-sohil.mehta@intel.com> References: <20230727180533.3119660-1-sohil.mehta@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772600404376164709 X-GMAIL-MSGID: 1772600404376164709 x86_idle_thread_init() does not exist anywhere. Remove its declaration from the header. Signed-off-by: Sohil Mehta --- arch/x86/include/asm/smp.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/include/asm/smp.h b/arch/x86/include/asm/smp.h index 600cf25dbfc6..094f31d3f950 100644 --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -132,7 +132,6 @@ void smp_kick_mwait_play_dead(void); void native_smp_send_reschedule(int cpu); void native_send_call_func_ipi(const struct cpumask *mask); void native_send_call_func_single_ipi(int cpu); -void x86_idle_thread_init(unsigned int cpu, struct task_struct *idle); bool smp_park_other_cpus_in_init(void); From patchwork Thu Jul 27 18:05:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sohil Mehta X-Patchwork-Id: 127117 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp1314903vqo; Thu, 27 Jul 2023 12:21:04 -0700 (PDT) X-Google-Smtp-Source: APBJJlGjDOjKeOZXwzmInQbhcRnBBmK9RG8j/fS+OgwOf9Yvpbr5nM62Dw5BEeHplyKrlosUZ7Oy X-Received: by 2002:a17:907:77d1:b0:997:bb66:3ce with SMTP id kz17-20020a17090777d100b00997bb6603cemr115580ejc.7.1690485664614; Thu, 27 Jul 2023 12:21:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690485664; cv=none; d=google.com; s=arc-20160816; b=EE2Qoz5gR363c12rsSnZY50R6KzkvY9B7ItVO/4XMmB2yPUN2jUmbbsEH/gqE3zSDl mcnfWF57gD5HIIEuVFvN5Su/Tm0oMKkE8XKzw9EiFjVSgxA7fgfE8H5cEAjrIRcrmVxI KP4J1vE84eNDUl3ASCgAfPAiv5ihRU59icaxdlpFA7sIfrX0mw9kKwpxph7g5sMcRszr f28GO2B1lJkhmSKdnbATB0oeZ+NTy4DoXqRmpJnR/5Q2Zg41AkiyCkUGjjTyzVUT8teh 7DTMbuMufO0NBkAYKhkrBFghA4JpWxJOTZXNhpA4tvRJgfiwcG+1OkixwTjJhRyV+ouG 0xYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DM065/ncGmCub/RxQusJo8EU3MiaupdxZslkWj97N4s=; fh=+HHxJj+jtdJUKsrKMnpt0SoOHEFfnZ3HUVGrTHJPU+Y=; b=FsUTdHahw0gf3PrmumHSdnN2qGRyC5Y9+MXIL6DcwISWuIPyx30NVzBJTvIH76VKM7 lgtFJ6KBO/sjP1ZujPOI20ket0V6sDuWIteZj3PrivB4ux5DaHX9/Gk/+LN+xE3lLFmg XB7IATCLXpd/aErJRfLVnkC6qV6hSbYY3/xgMTzWIpLvWpEJNrxGPpkGgRuu+0389loO guYbglxHp9T+O03l0fYwt6AM4zahD4ru6LcUjpE4q9yKzQt3Pd0ig/QTnJLyENHrup73 g1OPU3uISWV1srOU9OGl2kPx42gsE90C5fSl4KxNoyxWS79aDluO31Q2PaDVZ1c2jgq2 10Kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=SW0M6hxc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p2-20020a1709061b4200b0099351214a94si1495829ejg.648.2023.07.27.12.20.39; Thu, 27 Jul 2023 12:21:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=SW0M6hxc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231642AbjG0SG5 (ORCPT + 99 others); Thu, 27 Jul 2023 14:06:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231386AbjG0SGu (ORCPT ); Thu, 27 Jul 2023 14:06:50 -0400 Received: from mgamail.intel.com (unknown [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C92A030F4 for ; Thu, 27 Jul 2023 11:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690481208; x=1722017208; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Ou+7XfN+1f2cTllTnn7hZn4iUyiMerEMeSBG9j8AO/g=; b=SW0M6hxc7TN5go3Ly3D+W3VhLhFLPGwznFyYOqD8aexHfkstqKKLp+9/ HcyD5o7sBDz9YZAY8YTnWoIMG+FQ0C1tpT9stjWJdlX1TcwmAbJO2Woex T6uA5YJnmN46P7+0eu5P1uU6KmrD97BKDjMXSrWpH1nDF8hPsQ1htCVdX 4S1uPTAeZs+nPG9CQ5BTp7V3F+SXGoZvAQW2Gu6bQTdnH9jc+NmiFLRGX NjdtIVvPyEesQmTN8z5FmLT/QmivjZnoqPT59SeNsUxss4p2rG5/Ff460 noATdy0FuyKhS1IWsPVqjpJTZfpu3KUREXT1Yc+bapIWAW7Srulkb13lp A==; X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="454760103" X-IronPort-AV: E=Sophos;i="6.01,235,1684825200"; d="scan'208";a="454760103" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2023 11:06:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="870523929" Received: from sohilmeh.sc.intel.com ([172.25.103.65]) by fmsmga001.fm.intel.com with ESMTP; 27 Jul 2023 11:06:50 -0700 From: Sohil Mehta To: x86@kernel.org, Thomas Gleixner , Peter Zijlstra Cc: Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Tony Luck , Sohil Mehta , linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] x86/smpboot: Change smp_store_boot_cpu_info() to static Date: Thu, 27 Jul 2023 18:05:33 +0000 Message-Id: <20230727180533.3119660-4-sohil.mehta@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230727180533.3119660-1-sohil.mehta@intel.com> References: <20230727180533.3119660-1-sohil.mehta@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772602696101320911 X-GMAIL-MSGID: 1772602696101320911 The function is only used locally. Convert it to a static one. Signed-off-by: Sohil Mehta --- arch/x86/include/asm/smp.h | 2 -- arch/x86/kernel/smpboot.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/x86/include/asm/smp.h b/arch/x86/include/asm/smp.h index 094f31d3f950..cf7217ad5701 100644 --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -134,8 +134,6 @@ void native_send_call_func_ipi(const struct cpumask *mask); void native_send_call_func_single_ipi(int cpu); bool smp_park_other_cpus_in_init(void); - -void smp_store_boot_cpu_info(void); void smp_store_cpu_info(int id); asmlinkage __visible void smp_reboot_interrupt(void); diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index 6a09a021b534..28c590b4b1b1 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -422,7 +422,7 @@ int topology_update_die_map(unsigned int die, unsigned int cpu) return 0; } -void __init smp_store_boot_cpu_info(void) +static void __init smp_store_boot_cpu_info(void) { int id = 0; /* CPU 0 */ struct cpuinfo_x86 *c = &cpu_data(id);