From patchwork Thu Jul 27 09:05:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 126920 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp1029212vqo; Thu, 27 Jul 2023 04:30:59 -0700 (PDT) X-Google-Smtp-Source: APBJJlH8/WqgZ4Qv0il8yT85SUbotezyX+Eyx14FHPS7am2lQFQI3H5Xiaj4tGw/AUvVE4p+Q8qw X-Received: by 2002:a17:907:78c1:b0:993:da87:1c7b with SMTP id kv1-20020a17090778c100b00993da871c7bmr1815114ejc.10.1690457459256; Thu, 27 Jul 2023 04:30:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690457459; cv=none; d=google.com; s=arc-20160816; b=Ssj+gKxROHZo5Aj/RmkScsTl7i+71x97txYCvV728vXjTeqTXXKNpIqDOSmjGs603q O/mW7hM+vWgKov7EUrY73RtVVBhweYKMTZydZ5HjHdagL5U0QTqnl3PUm+eB7Xjzmtrf Va/OswY1ZQAFaoFgHoJYhjIhGN5Ru7cZfYhcuGiTjqstomvGf+FsFyy6KpReeaxA2U32 ClRMWKZK96akMq6zPRRj9ue5qknMz+Nlx2p2W24F1CP/U0sweQpENAmBIh9lMHtO+EXV lqct3BW8cwA3wXvnfoJ7WeVvzvIV0FFJ/CSVcOo8iXMOoNyX1heUUQwwN1+3/K2VADoF RG6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=v7HncDghM6f/KAxAkWxOEKG+UyL8AA2Lp8+vRdjueuI=; fh=mHuK3kXs+d4uNof//jCCmVIs+fgEngzCt5jHvNFj9Fc=; b=aQB12BlF+uBAEmYCyVmTOzS7hv2JBSnGBL2tiNlZ1p8uE/uApunZBqckdhkkjuD1n/ Y1KToe/3wSqOYsdGVKwMswC7iIXyKfF8R3zctQ0mZ60dRyaprC+ilUwpnNuTdZO1E08c KsvKycQ8rwMrbjGmJbWcjwb9b3QmIWf+bBHAR0xZcZoSSGfMdxC4lozu7u4r1uM6If7j oHxi4IHShpMZ62mW2o89g/RiCK5UodNALll5a0GAeXKCTD43fap3CiUEN9H0j2ynabrE J9ZyeDT3cVB1r82ytroKBaF+pK7IKI00mkA+WVZCyQfqASTxkTCa3oQZYrp28tjO2c+t 3KIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ip1Ud8RX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c22-20020a170906695600b0099279b2cdd5si757240ejs.825.2023.07.27.04.30.34; Thu, 27 Jul 2023 04:30:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ip1Ud8RX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233920AbjG0JO2 (ORCPT + 99 others); Thu, 27 Jul 2023 05:14:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234677AbjG0JN0 (ORCPT ); Thu, 27 Jul 2023 05:13:26 -0400 Received: from mgamail.intel.com (unknown [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D114B449A; Thu, 27 Jul 2023 02:05:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690448704; x=1721984704; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=T+ltj6/n0zItDURuD6zDq9RQiKC3xwEfEl0V4qLQniA=; b=ip1Ud8RXkfTLVAGOPqQ7Qi4pVLbS09NzArxcaf0r7ZaN6qOOctFr8+Rh RLggmbWIFzWB1Ahly9vth/JcGlOglWf1mfAV9nbTcv1szzM1XuvzOLEjm 4z9yMsaY4VsmDh1/OVI2x+TUeBW8+aQhpa/Z3qrcRR3motIwUjbW08unb zrhyvRPsOxR8frR1D/NXb2FCf1nRBAxa9+Lbw1hsztRaULLv01xgykmG/ 9Mwl0kziqF+g4+nOYPOgkNeKE8ejIkjjJxYQDBNEzhBFr4x818D/PCiOy DDSWvdnIayEjvo/6mcrbpOJz2eHWZ7BgbJzcZA5rSw060JoLg8gGK0Vwz g==; X-IronPort-AV: E=McAfee;i="6600,9927,10783"; a="365716691" X-IronPort-AV: E=Sophos;i="6.01,234,1684825200"; d="scan'208";a="365716691" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2023 02:05:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10783"; a="1057645029" X-IronPort-AV: E=Sophos;i="6.01,234,1684825200"; d="scan'208";a="1057645029" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 27 Jul 2023 02:05:02 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 9195724F; Thu, 27 Jul 2023 12:05:11 +0300 (EEST) From: Andy Shevchenko To: Greg Kroah-Hartman , Tony Lindgren , Dan Carpenter , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Jiri Slaby , Andy Shevchenko Subject: [PATCH v1 1/1] serial: core: Replace strncmp()+strlen() with plain strcmp() Date: Thu, 27 Jul 2023 12:05:07 +0300 Message-Id: <20230727090507.81962-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772573120998786032 X-GMAIL-MSGID: 1772573120998786032 There is no sense to call strlen() ahead of strncmp(). The same effect can be achieved by calling strcmp() directly. Replace strncmp()+strlen() with plain strcmp(). Signed-off-by: Andy Shevchenko --- drivers/tty/serial/serial_base_bus.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/tty/serial/serial_base_bus.c b/drivers/tty/serial/serial_base_bus.c index 6ff59c89d867..bd056e6dca2f 100644 --- a/drivers/tty/serial/serial_base_bus.c +++ b/drivers/tty/serial/serial_base_bus.c @@ -21,9 +21,7 @@ static bool serial_base_initialized; static int serial_base_match(struct device *dev, struct device_driver *drv) { - int len = strlen(drv->name); - - return !strncmp(dev_name(dev), drv->name, len); + return !strcmp(dev_name(dev), drv->name); } static struct bus_type serial_base_bus_type = {