From patchwork Tue Nov 1 13:48:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 13673 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2977787wru; Tue, 1 Nov 2022 06:51:33 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4j2zKfI1wBwaoIiWJ0elUEK0OvP7Al7VYtNdGvMDGJWL5jte3PO4SpvKz0vMWCuxFkStLM X-Received: by 2002:a17:907:3f0c:b0:78e:2090:6924 with SMTP id hq12-20020a1709073f0c00b0078e20906924mr18814008ejc.332.1667310693123; Tue, 01 Nov 2022 06:51:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667310693; cv=none; d=google.com; s=arc-20160816; b=XqYGKX0ie1kjf/gnoDU/luRzw929ImJ9mzVY3j0k0qY8mj4xub1RMMAJKo5OMYt5Ca JpKrqfJ9e4IpsSkC/KbSAL2NHJdpeZVRtammDq7lMiR+yw+j+HdhR2sDPW0rX5eRiEXf DtiADTu+61w6FMFiRL5JhbY1uOorg51tz4z/IaRVhQI+eYuvtj36s2C4cHzKR/FcEWEU ekR2CqXFoi7ldsyuZG7yMJcVOKYtiDNxe21iyzRFbczUug7Fz1QTMLkDy3QFYxy0jGvD pqc7s3FUwJswqjh8Xvk+rKhTFwRzeoVGUDUp3GfYmDiCyJs5xJ6cyBCXVtcf1Hd51WhT 4Bug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=oY3AjGucgSMFZNkasXHZboSxo7WQkXHy3cf12jBk9o0=; b=lGk2pMbn3w4EGjI4Q+j8L4acWeMOVuo75UnYNd8PWhJkZBLpAB/v/czFvXXaAZdTem TEANmQayPXivycDWGUyEDXQ/+xiPH6S8QTe7zkukUXSE5rNiWOla7b9Rv8w+YQ1HZPmS wl2EaFZvVepPRvQ8/73DIGib79qw35LckOZ7r+SDQt7Kc3TvTDtsCFEOv8sBEiq84SmV /hchV6dF/oOYvmABaRv7uVr5t92Hzm7BMx29u/a6CBTdW9G794lxO++X1sH0mTFeGcJK S3OOu6DD3B3n7b8cqpgBaitNlNocDbkUQDeL4uyytJ5fuCLdRcQ5+1UiEJMwY9Yhurh9 fijQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=h0ytcWHL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jg36-20020a170907972400b007add8ec38aesi5725709ejc.424.2022.11.01.06.51.08; Tue, 01 Nov 2022 06:51:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=h0ytcWHL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229991AbiKANsX (ORCPT + 99 others); Tue, 1 Nov 2022 09:48:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbiKANsV (ORCPT ); Tue, 1 Nov 2022 09:48:21 -0400 Received: from msg-4.mailo.com (msg-4.mailo.com [213.182.54.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29107A7 for ; Tue, 1 Nov 2022 06:48:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1667310493; bh=FNdZHPIXSMqReTu7V7OLhEbcfqLKVeX8EB+0vnG4PBo=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=h0ytcWHLTY4pkEjjk22m33rTbMiwNeT/jOaOedq7rv0tk7di1ZMX9TjE2sfoO1aMw 5AE1DenTbi+E8LDHHMvaXR5qyTGXOKJ8HLGNUpIXK5rWDRuB+WwInyNdjWpf0bSLyU /8pP+mY+4p08j08SMNi5COMGMDrhLsBZ2xA1P5o4= Received: by b-3.in.mailobj.net [192.168.90.13] with ESMTP via [213.182.55.206] Tue, 1 Nov 2022 14:48:13 +0100 (CET) X-EA-Auth: PONAtjAXCOVWqqpb0fs+8wLWjA/64MWw6vvfq5B0q/Z5Rz/CGiHLJLNDNxnbOIx3Zx1nilKCZZAeewY7zlSTvcQIWt5TMSEA Date: Tue, 1 Nov 2022 19:18:10 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/7] staging: wlan-ng: Remove unused struct wlan_ie_ssid references Message-ID: <6e39ef59d01d65a1e179f6aecfbb0d68b81fa257.1667308828.git.drv@mailo.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748301977375897326?= X-GMAIL-MSGID: =?utf-8?q?1748301977375897326?= Pointer reference to struct wlan_ie_ssid is added as a member variable to 5 different structures. However, these references are never used. Remove such unused struct references. The cleanup also renders the struct useless; so remove it as well. Issue identified as part of coccicheck based code analysis. Suggested-by: Dan Carpenter Suggested-by: Pavel Skripkin Signed-off-by: Deepak R Varma --- Changes in v2: 1. Include additional code clean-up opportunities and combine changes in a patch set based on impact areas. 2. The patch changes are compile tested only on X86 arch. drivers/staging/wlan-ng/p80211mgmt.h | 12 ------------ 1 file changed, 12 deletions(-) -- 2.34.1 diff --git a/drivers/staging/wlan-ng/p80211mgmt.h b/drivers/staging/wlan-ng/p80211mgmt.h index 1ef30d3f3159..dcff56d18498 100644 --- a/drivers/staging/wlan-ng/p80211mgmt.h +++ b/drivers/staging/wlan-ng/p80211mgmt.h @@ -225,13 +225,6 @@ struct wlan_ie { u8 len; } __packed; -/*-- Service Set Identity (SSID) -----------------*/ -struct wlan_ie_ssid { - u8 eid; - u8 len; - u8 ssid[1]; /* may be zero, ptrs may overlap */ -} __packed; - /*-- Supported Rates -----------------------------*/ struct wlan_ie_supp_rates { u8 eid; @@ -319,7 +312,6 @@ struct wlan_fr_beacon { u16 *bcn_int; u16 *cap_info; /*-- info elements ----------*/ - struct wlan_ie_ssid *ssid; struct wlan_ie_supp_rates *supp_rates; struct wlan_ie_fh_parms *fh_parms; struct wlan_ie_ds_parms *ds_parms; @@ -372,7 +364,6 @@ struct wlan_fr_assocreq { u16 *cap_info; u16 *listen_int; /*-- info elements ----------*/ - struct wlan_ie_ssid *ssid; struct wlan_ie_supp_rates *supp_rates; }; @@ -407,7 +398,6 @@ struct wlan_fr_reassocreq { u16 *listen_int; u8 *curr_ap; /*-- info elements ----------*/ - struct wlan_ie_ssid *ssid; struct wlan_ie_supp_rates *supp_rates; }; @@ -439,7 +429,6 @@ struct wlan_fr_probereq { void *priv; /*-- fixed fields -----------*/ /*-- info elements ----------*/ - struct wlan_ie_ssid *ssid; struct wlan_ie_supp_rates *supp_rates; }; @@ -457,7 +446,6 @@ struct wlan_fr_proberesp { u16 *bcn_int; u16 *cap_info; /*-- info elements ----------*/ - struct wlan_ie_ssid *ssid; struct wlan_ie_supp_rates *supp_rates; struct wlan_ie_fh_parms *fh_parms; struct wlan_ie_ds_parms *ds_parms; From patchwork Tue Nov 1 13:48:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 13677 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2978477wru; Tue, 1 Nov 2022 06:52:53 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4ZgPAFnuPIdwzhp5paX067Fae15/MlyOCDlundfhi16V95W66i5hiHcktf43orXwkg8dMc X-Received: by 2002:a05:6402:11c7:b0:462:549d:fbbe with SMTP id j7-20020a05640211c700b00462549dfbbemr19065818edw.199.1667310773537; Tue, 01 Nov 2022 06:52:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667310773; cv=none; d=google.com; s=arc-20160816; b=XEq8L9TP7jUsb5ry4LvlkNR7p2VhzrFsOmkcGfU5IiB5i20JxzInD/EoOiwR3R/yW1 JZsgnhC7GP8wlbzHNq+wW6QFBqzvSXhDaymydHg/JN8eWyOM5ek1d4ZiH1B8FdTEml/H yXmKViClEiLkuGwk1LdlbUgsbmuSbGx7A7CHvACaBA9MGRYeexpiIEJb0KMMReCsoDKT P/aXEk2wTlTMCu+ofb1G8pRDp9BtigOyqaOpdDixXF0q5w1R5jfwzbN3I4RgvjYduuiJ 3NrEyovLQNt3FHshEw8DXfNkH70zaaZqAt2rpYNMLHKQJE+WArA8cyKuw3/6mw9yuyf3 C4Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=xfGlS7cEqANK7fPw1kzGECSFzTYGDPgu22Q8i39orjE=; b=RVBbjobceyg/NXdSQ9LgBgkl/PHD6qHvDkQID0/MYDC7rm6izvaZXVI02y11DqL4lL IiiHJ2pssPFIv+rIC2srIDTV4vBwoSIjDaUqgS437wBQdThDWdI897zY+1V9qjmj+RCT iCTURNCHmTzei4bRt0QjIaC1CUkbOAhvNPExUHxwf3HWkx922E5ssooAqu4s2pyQdLnN fkxw41uCql0ZoeewA3USkUnwgIymY2ATQgK7LL0X7CtVuoNiyab9nTjGphxd49eaG6zQ IO77zEN+jUd+IW9tI+2aJMjKKuoHbQWbnRP3pJmLDU2bNbaQBjEjkCFLMoJzdXXKPdNh PGwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b="fVcb+/nu"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f13-20020a056402354d00b0045cca8f9a0asi13007679edd.580.2022.11.01.06.52.29; Tue, 01 Nov 2022 06:52:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b="fVcb+/nu"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230100AbiKANtL (ORCPT + 99 others); Tue, 1 Nov 2022 09:49:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230082AbiKANsy (ORCPT ); Tue, 1 Nov 2022 09:48:54 -0400 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5844A64DC for ; Tue, 1 Nov 2022 06:48:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1667310519; bh=vD5xPP6rhDMyEPUB2EJfYmq4IJWWiXIGuVb0HXRZWT4=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=fVcb+/nupJ7AhmJnZetNK34/9sZngg5xfUJsvcaYThBAwhncmsYLqdFmE5XItZ1yp h+O9SuSPXpN+fOD4lSZF0bo30/fA36OtRLLHISFPXtk/uBqN423wJLLC4QCfPRD5R2 WeoXRd9xg13Tt/G2PPHucnD4a4EaTNf9355JLqpw= Received: by b-1.in.mailobj.net [192.168.90.11] with ESMTP via [213.182.55.206] Tue, 1 Nov 2022 14:48:39 +0100 (CET) X-EA-Auth: X4pN+7UwV7tuIgo8s4NSyRI91QHFNeZwe3Lbq6lEeocWM1koDQGJMOfbBYzQ20847gAz1Jl7Tuk5oWFzZrXgTyHCm0VQ1Fqw Date: Tue, 1 Nov 2022 19:18:35 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/7] staging: wlan-ng: Remove unused struct wlan_ie_supp_rates references Message-ID: <370feb1f300896af66fa1c443d3ad19dc8934be3.1667308828.git.drv@mailo.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748302061533668919?= X-GMAIL-MSGID: =?utf-8?q?1748302061533668919?= Pointer reference to struct wlan_ie_supp_rates is added as a member variable to 7 different structures. However, these references are never used. Remove such unused struct references. The cleanup also renders the struct useless; so remove it as well. Issue identified as part of coccicheck based code analysis. Suggested-by: Dan Carpenter Suggested-by: Pavel Skripkin Signed-off-by: Deepak R Varma --- Changes in v2: 1. Include additional code clean-up opportunities and combine changes in a patch set based on impact areas. 2. The patch changes are compile tested only on X86 arch. drivers/staging/wlan-ng/p80211mgmt.h | 14 -------------- 1 file changed, 14 deletions(-) -- 2.34.1 diff --git a/drivers/staging/wlan-ng/p80211mgmt.h b/drivers/staging/wlan-ng/p80211mgmt.h index dcff56d18498..536794bdd1f0 100644 --- a/drivers/staging/wlan-ng/p80211mgmt.h +++ b/drivers/staging/wlan-ng/p80211mgmt.h @@ -225,13 +225,6 @@ struct wlan_ie { u8 len; } __packed; -/*-- Supported Rates -----------------------------*/ -struct wlan_ie_supp_rates { - u8 eid; - u8 len; - u8 rates[1]; /* had better be at LEAST one! */ -} __packed; - /*-- FH Parameter Set ----------------------------*/ struct wlan_ie_fh_parms { u8 eid; @@ -312,7 +305,6 @@ struct wlan_fr_beacon { u16 *bcn_int; u16 *cap_info; /*-- info elements ----------*/ - struct wlan_ie_supp_rates *supp_rates; struct wlan_ie_fh_parms *fh_parms; struct wlan_ie_ds_parms *ds_parms; struct wlan_ie_cf_parms *cf_parms; @@ -364,7 +356,6 @@ struct wlan_fr_assocreq { u16 *cap_info; u16 *listen_int; /*-- info elements ----------*/ - struct wlan_ie_supp_rates *supp_rates; }; @@ -381,7 +372,6 @@ struct wlan_fr_assocresp { u16 *status; u16 *aid; /*-- info elements ----------*/ - struct wlan_ie_supp_rates *supp_rates; }; @@ -398,7 +388,6 @@ struct wlan_fr_reassocreq { u16 *listen_int; u8 *curr_ap; /*-- info elements ----------*/ - struct wlan_ie_supp_rates *supp_rates; }; @@ -415,7 +404,6 @@ struct wlan_fr_reassocresp { u16 *status; u16 *aid; /*-- info elements ----------*/ - struct wlan_ie_supp_rates *supp_rates; }; @@ -429,7 +417,6 @@ struct wlan_fr_probereq { void *priv; /*-- fixed fields -----------*/ /*-- info elements ----------*/ - struct wlan_ie_supp_rates *supp_rates; }; @@ -446,7 +433,6 @@ struct wlan_fr_proberesp { u16 *bcn_int; u16 *cap_info; /*-- info elements ----------*/ - struct wlan_ie_supp_rates *supp_rates; struct wlan_ie_fh_parms *fh_parms; struct wlan_ie_ds_parms *ds_parms; struct wlan_ie_cf_parms *cf_parms; From patchwork Tue Nov 1 13:49:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 13680 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2979154wru; Tue, 1 Nov 2022 06:54:08 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7SDZHH/DFYs09O7PTVOpi7ulR3J8dUnoN4EY32086caper/qj99RD2bLTeucct/xvE3xcW X-Received: by 2002:a05:6402:718:b0:463:275:4753 with SMTP id w24-20020a056402071800b0046302754753mr17001653edx.160.1667310847850; Tue, 01 Nov 2022 06:54:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667310847; cv=none; d=google.com; s=arc-20160816; b=sNpTbtK4Haglhk44dZ4ysPpyxLDajcYK6tCfDCBLCzdyd6E34OCDbGjy+iLkHuh6Oq t9htuz5IjuvKgZ6UhXlIkslpmLSHektJLPE2jjOAAW9Kkv2Z2ru5FqRnar3nibA1Rc7t XLmIwES1iMXKFMdNeChrM2LzQQIPZ7QAZmqUJ2o3fB+UgYzmUIYyTb3UByydtQ8vgAAu jhD8XQ/8BJC3SmqQKFxSL+vASyTjSyTyNvS6Bit/fotm0vll18JHNDA1PgbOg3s95Byr nzr50Dq/nO11OWJ9wgfdKsAjq73vITavxOldjRyQiVovi0Z6HtStFjLyKWiwQXm7g7aM Zdmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=ImkROb6VMESw0Ts90uPIj5PfTCehE0u1wRnI0hymNFg=; b=azIvjYNwDP1LQJi0B7Ndnqike53dm6A+dHJmfCQpwCWnKpstTZ+3QtYJh12YoZHZDU 5fMdVrXAOZivVMlwAiuZNf/Hx3jVc4QCPIlwy1bL6CRUK5f13bDEGcidn4Ygc6FG3+Ka yi4Mdx0Bt6VU6lTFdWJvGCY4MlkxD63Yo4bI+EZmVr5gNSIMuouObLuseytHE6Ao87l/ atA7a4HVF99GF03SJvDq62FUdSQ1vv3SwJbNZNAdyxvtqZBZQlWGr9iU857mbhm0eZ3k eQ7b9nj99aQ8VN03PDyF4rEo3atXuccSQzBRJ3uZFTJsbvFGs4ws19b5z8ws3AX3sv5k PQcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=DPOe8NTG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g13-20020a056402320d00b00453b9f11b56si12096864eda.261.2022.11.01.06.53.43; Tue, 01 Nov 2022 06:54:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=DPOe8NTG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230158AbiKANtc (ORCPT + 99 others); Tue, 1 Nov 2022 09:49:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230180AbiKANtX (ORCPT ); Tue, 1 Nov 2022 09:49:23 -0400 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B8726540 for ; Tue, 1 Nov 2022 06:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1667310549; bh=vFzpmBoau7NBl7FFTlmZYFwyYNbzqXjwJoyGzhQ4sDE=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=DPOe8NTGgDw6DENTKI2h+HFxSxlw2SNLglRET2d/j2LL38nDz9MOmBZYOCTJseT7Z DGvZsdmgbj7RgxGC87zlbSRSrYy3vLAYawlpka1LCMkAJM9oquaf2cMmGkCUlmE8IZ wsuDSA/zkzkWqLCLxa6ZIICZyfrWr2T/1Q5j2atk= Received: by b-3.in.mailobj.net [192.168.90.13] with ESMTP via [213.182.55.206] Tue, 1 Nov 2022 14:49:09 +0100 (CET) X-EA-Auth: m4kbEFhoIEjDxdTr7Dx+G1fH9jl1AA03O/KmMzF+amilm1q+pNst2gH1Zw2gw19RPWicZz0R3CJzQnchs6LjAeOi4oRIlVHt Date: Tue, 1 Nov 2022 19:19:05 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/7] staging: wlan-ng: Remove unused struct wlan_ie_tim references Message-ID: <36834007587a2e0ef7a782f5919f3a4c756b7840.1667308828.git.drv@mailo.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748302139437316726?= X-GMAIL-MSGID: =?utf-8?q?1748302139437316726?= Pointer reference to struct wlan_ie_tim is added as a member variable of a structure; However, this references is never used. Remove such unused struct reference. The cleanup also renders the struct useless; so remove it as well. Issue identified as part of coccicheck based code analysis. Suggested-by: Dan Carpenter Suggested-by: Pavel Skripkin Signed-off-by: Deepak R Varma --- Changes in v2: 1. Include additional code clean-up opportunities and combine changes in a patch set based on impact areas. 2. The patch changes are compile tested only on X86 arch. drivers/staging/wlan-ng/p80211mgmt.h | 12 ------------ 1 file changed, 12 deletions(-) -- 2.34.1 diff --git a/drivers/staging/wlan-ng/p80211mgmt.h b/drivers/staging/wlan-ng/p80211mgmt.h index 536794bdd1f0..d95ffe0097e9 100644 --- a/drivers/staging/wlan-ng/p80211mgmt.h +++ b/drivers/staging/wlan-ng/p80211mgmt.h @@ -253,16 +253,6 @@ struct wlan_ie_cf_parms { u16 cfp_durremaining; } __packed; -/*-- TIM ------------------------------------------*/ -struct wlan_ie_tim { - u8 eid; - u8 len; - u8 dtim_cnt; - u8 dtim_period; - u8 bitmap_ctl; - u8 virt_bm[1]; -} __packed; - /*-- IBSS Parameter Set ---------------------------*/ struct wlan_ie_ibss_parms { u8 eid; @@ -309,8 +299,6 @@ struct wlan_fr_beacon { struct wlan_ie_ds_parms *ds_parms; struct wlan_ie_cf_parms *cf_parms; struct wlan_ie_ibss_parms *ibss_parms; - struct wlan_ie_tim *tim; - }; /*-- IBSS ATIM ------------------------------------*/ From patchwork Tue Nov 1 13:49:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 13674 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2978170wru; Tue, 1 Nov 2022 06:52:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5rzyIFVaErp2npfX+AOm7blPH8AX7EGu1//o05ugHx4s/7WNAJQNWKyel8cBwU14S417DY X-Received: by 2002:a17:907:210f:b0:78d:20f7:1294 with SMTP id qn15-20020a170907210f00b0078d20f71294mr128043ejb.442.1667310736557; Tue, 01 Nov 2022 06:52:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667310736; cv=none; d=google.com; s=arc-20160816; b=NEbnam3Y1UpcYEtxcz0jdZO7iETmg3pBzKVd1yfMc8Tg2UNYIOGOrMvcyBtUzFZgcq 8lVVOU3UDQ8+HSXUbaUQZnUqaivA9rXr8lIwXfaQGuNlt4hbw/qZTAqUP46S8AYMuuIQ Me0pbKE3zoIpcpwIYoFD8w4IX7325oONo1hENBLIC4mC6fwGhhzYi1LFr2eLGy1pd5z0 RERoZcoHZUKiUTlV+JXMvQwo7Ynrks3ZFgI1tknZNC6Qrj3pqWWwv36Dy39lAy/EYpXD GGwnixGveN8ZAl432tkqU9sVFZLKBPrPWERXJdA3t6Ay+yhPGf7DMkzOomGTAkaoRtZE vDfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=U38kfOh0JF0Y92GZMH6SvzrXPNiYnJlLsEK4J5eBLgI=; b=uQ5z5wVYZ9xjx+L+NgIL1YZMwMXNKIsMfXjf5O7lybIcQ1Xxg593X7jHzlv26js8PE qoGLF0aS2ISaxlZ34fXV/aE3YjyCbnQhtBG05UvS3JjalzkmoUQs5yLSOgDjKwpHq8ox EmTjnKSsL5nCvrmyEcqjKI6dL0nfXmYmMQramUzxCIXgryQL++Fp+EpZx4AiW1ddD62m Pd+YKcEuO7uIdPUHxGoNF4L0cQAzpzE+o0sv7HVjv6AY4UtdsipUpbR3d2XL7hr+S9H6 RYVN71X7Dnx6n0IM5oFNEgtt6+eCA+D+Kv3pMjegj2wtQsqYgtDPrYbJag7edkSPUmfE deMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=KaFOj9jQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qq17-20020a17090720d100b007a0b8eead9fsi9043642ejb.60.2022.11.01.06.51.52; Tue, 01 Nov 2022 06:52:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=KaFOj9jQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229528AbiKANuK (ORCPT + 99 others); Tue, 1 Nov 2022 09:50:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230138AbiKANtz (ORCPT ); Tue, 1 Nov 2022 09:49:55 -0400 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CFE41C121 for ; Tue, 1 Nov 2022 06:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1667310573; bh=YqDTb9YthK+f5gOGsv+KgABsraC6uIX0b8maMGYNFJM=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=KaFOj9jQ8iO9FyTZo+JvYbqOsfuKwJhsUd8pflLTJ+7lm/zZJ9LW0/ohu4NAUzFD4 zA1uUt+ssNH5ppvove9WZ2fvE8YhgaGUES7//DNpZhuWBsl3ixMrQbXP+LKvusGan3 Xc/532AKC16p5M2RjtftgXSRv3JVLUgllE1C5ABM= Received: by b-5.in.mailobj.net [192.168.90.15] with ESMTP via [213.182.55.206] Tue, 1 Nov 2022 14:49:33 +0100 (CET) X-EA-Auth: XE2K7QgmM9ENyzefGEIHGiLeNNWaodO0XceUBUiw1lnmYFPJbnJ3xq6xR5z83375JTmC4NM2pLOGPu2b1kV5xflX/vLhdMXr Date: Tue, 1 Nov 2022 19:19:30 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/7] staging: wlan-ng: Remove unused struct wlan_ie_ibss_parms references Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748302023108324788?= X-GMAIL-MSGID: =?utf-8?q?1748302023108324788?= Pointer reference to struct wlan_ie_ibss_parms is added as a member variable to 2 structures; However, these references are never used. Remove such unused struct references. The cleanup also renders the struct useless; so remove it as well. Issue identified as part of coccicheck based code analysis. Suggested-by: Dan Carpenter Suggested-by: Pavel Skripkin Signed-off-by: Deepak R Varma --- Changes in v2: 1. Include additional code clean-up opportunities and combine changes in a patch set based on impact areas. 2. The patch changes are compile tested only on X86 arch. drivers/staging/wlan-ng/p80211mgmt.h | 9 --------- 1 file changed, 9 deletions(-) -- 2.34.1 diff --git a/drivers/staging/wlan-ng/p80211mgmt.h b/drivers/staging/wlan-ng/p80211mgmt.h index d95ffe0097e9..816b25641f5a 100644 --- a/drivers/staging/wlan-ng/p80211mgmt.h +++ b/drivers/staging/wlan-ng/p80211mgmt.h @@ -253,13 +253,6 @@ struct wlan_ie_cf_parms { u16 cfp_durremaining; } __packed; -/*-- IBSS Parameter Set ---------------------------*/ -struct wlan_ie_ibss_parms { - u8 eid; - u8 len; - u16 atim_win; -} __packed; - /*-- Challenge Text ------------------------------*/ struct wlan_ie_challenge { u8 eid; @@ -298,7 +291,6 @@ struct wlan_fr_beacon { struct wlan_ie_fh_parms *fh_parms; struct wlan_ie_ds_parms *ds_parms; struct wlan_ie_cf_parms *cf_parms; - struct wlan_ie_ibss_parms *ibss_parms; }; /*-- IBSS ATIM ------------------------------------*/ @@ -424,7 +416,6 @@ struct wlan_fr_proberesp { struct wlan_ie_fh_parms *fh_parms; struct wlan_ie_ds_parms *ds_parms; struct wlan_ie_cf_parms *cf_parms; - struct wlan_ie_ibss_parms *ibss_parms; }; /*-- Authentication -------------------------------*/ From patchwork Tue Nov 1 13:49:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 13676 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2978393wru; Tue, 1 Nov 2022 06:52:42 -0700 (PDT) X-Google-Smtp-Source: AMsMyM51T2QedIhBbxilA3FWMZMeLcFbFrhxW0JUY+F5o4+7au4FI6C7RYYEL+7x9cEbmVcFCCXm X-Received: by 2002:a17:907:a423:b0:7ad:b5f1:8ff8 with SMTP id sg35-20020a170907a42300b007adb5f18ff8mr15889452ejc.241.1667310762288; Tue, 01 Nov 2022 06:52:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667310762; cv=none; d=google.com; s=arc-20160816; b=xkfY895LscdCke3UiTn83FrxQ0hsXHMu6xBP/z1D+tgczz7NPXwl+4EKps6/f21NEo mAdzDErb+9vWjWThPseIyK55tAl/zyeTNjIapkik654tfFFN7FrsdGzfNgr/sriB0x2t hI1V6J+Num9V4Ajy5NdWitbXH7Ykajqp6QZUc9kCPMMKeJ4YcaKQWNJlUM5sABLmg58K YXTI4av1IXix8UDsbv1CH5GNn8zlUzxDGbFfyALMUBKvFP2gJV2stDo27dZKeKqTtn86 0vnazEWScUiLuwbuZ33Q1zwWuz9A3jNoXrUMfp1A2JdOl9yJCdTN8ZtzExAZnkVZl7mJ +4Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=/8NaNHh0ObMxKID8oPRTejrQNGKmGChb/y2aR0FOgCs=; b=fA0qPyCz2KXOfgujjecmk7VtHq30YuNSIB9Gif4pj+cQO1kQ3Oe34HZuzjpIOOeApL wriEFZZ4UPShQUSExHmAws6ez9hXl5pTkMLpbhHsmUZsfczqzBaYwOFBLbbcbEgzx0mK mQZa+/ycTrVZQOpndC0tY4T9zY9VaoMo/Vg5wX5bTiKDWWUcGASr0mfSm+5XfglCv4DM hiiBCVfQGVd6zcGNfMhNzOARTDfbwShm0S5FMWr3bkL7+4eOeWeVA0jXKISM0uwmurhB Xw48e2j4NdgGpH2ugrgIMDDRtDMHzkf0APttdzZhQoN+KfhvrA8okhGIdXBQPwFfSjVM WRDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=gK9A2sJR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s4-20020a17090699c400b0078d4cf8de04si11755894ejn.380.2022.11.01.06.52.18; Tue, 01 Nov 2022 06:52:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=gK9A2sJR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230072AbiKANuX (ORCPT + 99 others); Tue, 1 Nov 2022 09:50:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230122AbiKANuI (ORCPT ); Tue, 1 Nov 2022 09:50:08 -0400 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BA44614F for ; Tue, 1 Nov 2022 06:50:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1667310597; bh=8G8ijNpzwZYatDZANaufMBhLpqqvE5uH9B3jRw4pOhY=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=gK9A2sJRRps4UWAIDEHosJmKh9OD7mP3p0gT9bezi4UTuzaAKiBEZaIoHGofN0NuL Cb+v7BwGGrmF+xZJ9s0drzohIy6G6e1YInWzk1ZmlQHQ6gKZhSzGS+MUnQYo0e6tLr nhdIM37Wiv9n/FIbhoHU8rF7eUzlDeJD8Dd/ofog= Received: by b-1.in.mailobj.net [192.168.90.11] with ESMTP via [213.182.55.206] Tue, 1 Nov 2022 14:49:57 +0100 (CET) X-EA-Auth: erc4JnmKzL1p+tdhqH73lJrMemUhI3sHaSNaLbA9SpuJm69EGX8ipr5WtgnlWcNI72YacsbfxkMSKIccpnyGFcZZZiD7bJJf Date: Tue, 1 Nov 2022 19:19:54 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/7] staging: wlan-ng: Remove unused struct p80211macarray definition Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748302050069179595?= X-GMAIL-MSGID: =?utf-8?q?1748302050069179595?= struct p80211macarray is defined but is never used. Remove the unused struct declaration. Issue identified as part of coccicheck based code analysis. Suggested-by: Dan Carpenter Suggested-by: Pavel Skripkin Signed-off-by: Deepak R Varma --- Changes in v2: 1. Include additional code clean-up opportunities and combine changes in a patch set based on impact areas. 2. The patch changes are compile tested only on X86 arch. drivers/staging/wlan-ng/p80211types.h | 6 ------ 1 file changed, 6 deletions(-) -- 2.34.1 diff --git a/drivers/staging/wlan-ng/p80211types.h b/drivers/staging/wlan-ng/p80211types.h index 6486612a8f31..b2ed96960413 100644 --- a/drivers/staging/wlan-ng/p80211types.h +++ b/drivers/staging/wlan-ng/p80211types.h @@ -231,12 +231,6 @@ struct p80211pstr32 { u8 data[MAXLEN_PSTR32]; } __packed; -/* MAC address array */ -struct p80211macarray { - u32 cnt; - u8 data[1][MAXLEN_PSTR6]; -} __packed; - /* prototype template */ struct p80211item { u32 did; From patchwork Tue Nov 1 13:50:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 13678 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2978507wru; Tue, 1 Nov 2022 06:52:56 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4ePMUDT+qF9GzyipKZiUnpUY+h9Kb22TNjhmuvLhwFrlSpe7sAHcrquu3AxcjaiDHT/XM3 X-Received: by 2002:a50:ce1e:0:b0:463:ce89:d0b with SMTP id y30-20020a50ce1e000000b00463ce890d0bmr839932edi.145.1667310776747; Tue, 01 Nov 2022 06:52:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667310776; cv=none; d=google.com; s=arc-20160816; b=CedYf3XE3xMNGgekmM064voXx+9XrODUsU/xGTMEJbrqUzTheE0oL1x4fUYRajBWb9 wtkjs7FFBrGHfI4SW2lJLFhJvF+oXyukSJxpAC3BEiuRE0iUzIbj83tPr4M1TPUZe+PY HsLJJjTQUl08Y+iKFw+y32vzZ8kF6F3d5RuEvJdr1oNIaSDsfUNyUxRvFQvRRI4x5AZC JcPcjn0SkXaCIgIeTN5zLDzB9xmMzfOgSXud5uhW5sASHsZuGam5h6NEaT5RHhZR3stR hh4NalJZthkAoKjIEbcugiUOlfRHlx8vHXDpovc/Xu1ghIRHmNfkE8BTll+IvNtoXEg+ KiHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=pLOGO+l4F5NL1AX6UxS1r+++i4Gakr3zU6PUeKnI+e0=; b=RLHGix4X3w5duXeDcW26RDP8+k7tCBGkv7TfxV9j890Ryah9OVH2VoxlPysDQIzx0e 98O1bJKo2MNE3iRzqvMw0+pcv1arMGpUQg++iOFp10n+y7wHcV9s8ODyd9Bd8nBSDK68 W2+8NWHEIH68fpRnXbX+ed4hpp9QXw0fU+nWrDFz8/qeWJMRanud+PHkLRW/eLswCXik anuaXhBb/z3jbjiBkkNzJEcyzeLyimMryTEv7wJBxt3hXAd7sjjCHDll2fxwlR1BwYFI PctXK9lJ8oXvSl3REyIeD9Zfxeto7lIslkrQPpNWRYuGG1oXBKcEMK2TnWOvtJm1RJ+W 6t6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=VExi3kuq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sd24-20020a1709076e1800b0078df948151esi12958769ejc.946.2022.11.01.06.52.32; Tue, 01 Nov 2022 06:52:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=VExi3kuq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229941AbiKANud (ORCPT + 99 others); Tue, 1 Nov 2022 09:50:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229846AbiKANuZ (ORCPT ); Tue, 1 Nov 2022 09:50:25 -0400 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76D7C617E for ; Tue, 1 Nov 2022 06:50:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1667310617; bh=XmP1+R7p/DnWE5QzKvv5uzhyseayhrVNsX9HWBGsGr8=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=VExi3kuq/HmPb0/aDWSXNQOY7ISbyBbW5d+yK/DcBRJJbrcicNKbfVEnpQcDo9LWC OKD6Pn7tR1b5UM93MgwQH4p9YDr8/vkFxYSY3joD3Gp8io459DD5XSsisSzy9d1hp/ Uaf+yt33pz5i2snxiBKpsRjMBPnA6wS1tGQu/PZw= Received: by b-6.in.mailobj.net [192.168.90.16] with ESMTP via [213.182.55.206] Tue, 1 Nov 2022 14:50:17 +0100 (CET) X-EA-Auth: gOpbJ+yZ/65L/9kxRhFEwwz17m1XTt5yz03Fd6XsbTcl10l1/WuCWkGYjjQ3rWczKNL8G2kBfpJrudGWB+4lLwoE5KQGl5/e Date: Tue, 1 Nov 2022 19:20:13 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 6/7] staging: wlan-ng: Remove unused function declarations Message-ID: <09e2af8d702e33c15ed9f655b0a1190b4e8bec86.1667308828.git.drv@mailo.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748302065023548167?= X-GMAIL-MSGID: =?utf-8?q?1748302065023548167?= Several functions are declared but are not implemented or used in any part of the code. Remove such unimplemented function declarations. Signed-off-by: Deepak R Varma --- Changes in v2: 1. Patch included in patch set. 2. The patch changes are compile tested only on X86 arch. drivers/staging/wlan-ng/p80211mgmt.h | 22 ---------------------- 1 file changed, 22 deletions(-) -- 2.34.1 diff --git a/drivers/staging/wlan-ng/p80211mgmt.h b/drivers/staging/wlan-ng/p80211mgmt.h index 816b25641f5a..da824bc36365 100644 --- a/drivers/staging/wlan-ng/p80211mgmt.h +++ b/drivers/staging/wlan-ng/p80211mgmt.h @@ -449,26 +449,4 @@ struct wlan_fr_deauthen { /*-- info elements ----------*/ }; - -void wlan_mgmt_encode_beacon(struct wlan_fr_beacon *f); -void wlan_mgmt_decode_beacon(struct wlan_fr_beacon *f); -void wlan_mgmt_encode_disassoc(struct wlan_fr_disassoc *f); -void wlan_mgmt_decode_disassoc(struct wlan_fr_disassoc *f); -void wlan_mgmt_encode_assocreq(struct wlan_fr_assocreq *f); -void wlan_mgmt_decode_assocreq(struct wlan_fr_assocreq *f); -void wlan_mgmt_encode_assocresp(struct wlan_fr_assocresp *f); -void wlan_mgmt_decode_assocresp(struct wlan_fr_assocresp *f); -void wlan_mgmt_encode_reassocreq(struct wlan_fr_reassocreq *f); -void wlan_mgmt_decode_reassocreq(struct wlan_fr_reassocreq *f); -void wlan_mgmt_encode_reassocresp(struct wlan_fr_reassocresp *f); -void wlan_mgmt_decode_reassocresp(struct wlan_fr_reassocresp *f); -void wlan_mgmt_encode_probereq(struct wlan_fr_probereq *f); -void wlan_mgmt_decode_probereq(struct wlan_fr_probereq *f); -void wlan_mgmt_encode_proberesp(struct wlan_fr_proberesp *f); -void wlan_mgmt_decode_proberesp(struct wlan_fr_proberesp *f); -void wlan_mgmt_encode_authen(struct wlan_fr_authen *f); -void wlan_mgmt_decode_authen(struct wlan_fr_authen *f); -void wlan_mgmt_encode_deauthen(struct wlan_fr_deauthen *f); -void wlan_mgmt_decode_deauthen(struct wlan_fr_deauthen *f); - #endif /* _P80211MGMT_H */ From patchwork Tue Nov 1 13:50:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 13679 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2978673wru; Tue, 1 Nov 2022 06:53:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4KXhfqbYvdzqaziNt+v70ToTiJfnrMb8TI1d+hSMwTk9bjYBwTSqO1lAa20sxeG9CBkYCZ X-Received: by 2002:a17:907:2dab:b0:78d:fc4b:7e31 with SMTP id gt43-20020a1709072dab00b0078dfc4b7e31mr17539872ejc.531.1667310796675; Tue, 01 Nov 2022 06:53:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667310796; cv=none; d=google.com; s=arc-20160816; b=sHd/wSLBjz52wUXlgI9ek1zfhULA7CeV50F2rJEOE1h5WiWbFQADAkwP72hkbG8DV8 S2V/vlJHL+NAmkSOCwmg1j5beIR7rU+haLbzMxezP2CzjOZKozbgP+Vbw+Gr79x6ECkS IuNE1hfRH+kogYKXAGxDE3FBIOyUUlifXpdWTVn+wHFRy9eWus6r705S/TYv9oX3cL1T 0iMkr1YUlAwJp+a8LjymbnZ8i4rd3OuSdQ3o4BeihDcMc3dpjqVYsxJiomI8qpNEfBR0 tbUpQp6koGMdutgYXuYRxWxKJy6PKUwaGM07zFPkDkUt9zHg9CJpDmaaJBSiips5end3 OIBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=ygGDvP+Z+nt0tLsIr3jzWTbkMcU6FMP+LnmoKo0vxIc=; b=iV02XOZMG4m2EG3985KPd08b7CO/ab2QuxfkrtPVinly1m7TZ8aYPuxgRY8HXpNTuv X+cysneI1PHU3qcsVW9gAtKQZ4Fe6WVtFNA90sub2znrVJZYNuNvCCOm2JjfusBZII3f KRZaHYz++weSueE05b74jZrt0PsY/bnluBktcSLAWIZr3UeJY2EE6x3rB4UE1Y+tnFSq u7Yg+idvls7IIUuiIXY3Acf/9oaacfUJVs0uIYLOGYcElpCvWSCk6yUndolm9UHjiRcA RjyGBhgXyamFSluwKzQT/jyEH4TJqudLT4Ka20E4cZuFm5hugx6q2BJrsVl9PZzUWc+N zfmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=ltyc73j5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k11-20020a50c8cb000000b004612915d21bsi9785135edh.276.2022.11.01.06.52.51; Tue, 01 Nov 2022 06:53:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=ltyc73j5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230035AbiKANu6 (ORCPT + 99 others); Tue, 1 Nov 2022 09:50:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230026AbiKANuv (ORCPT ); Tue, 1 Nov 2022 09:50:51 -0400 Received: from msg-4.mailo.com (msg-4.mailo.com [213.182.54.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F72364CD for ; Tue, 1 Nov 2022 06:50:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1667310643; bh=USjeNcCx3bKCWp1/y/3F0YEXlmi+d+xrsqntzQAAIuE=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=ltyc73j5xfmEKOmB0bE/6N77T+aYVv2O2BJYHvKj/RX8v+rGpa6W2dxcjISjgPIg+ rJH7N4/Trn8utK3XHYPqVUcqnyJfRXHHeKfwfERG4yn1bsu1yG3m4HJBweNHuuJQZm H0CdcL3Kx2hOjfd8X2q/YPhE+ELBXk//kB4TnNGo= Received: by b-2.in.mailobj.net [192.168.90.12] with ESMTP via [213.182.55.206] Tue, 1 Nov 2022 14:50:43 +0100 (CET) X-EA-Auth: oXOBPTbXohD6WcpPQ6XB0vpq2jc20zZGMZstWPBGQ1ywl9oI5zOEJoNMBDVYHgNIY9Di6kzuuT9L0+eg/2IoEyioeYgxNjrP Date: Tue, 1 Nov 2022 19:20:40 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 7/7] staging: wlan-ng: Remove unused structure definitions Message-ID: <74a79ea400ec26624e445692f3353424fb6fc29e.1667308828.git.drv@mailo.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748302085796182744?= X-GMAIL-MSGID: =?utf-8?q?1748302085796182744?= Remove structure definitions that are never used in the code. Signed-off-by: Deepak R Varma --- Changes in v2: 1. Patch included in patch set. 2. The patch changes are compile tested only on X86 arch. drivers/staging/wlan-ng/p80211mgmt.h | 232 --------------------------- 1 file changed, 232 deletions(-) -- 2.34.1 diff --git a/drivers/staging/wlan-ng/p80211mgmt.h b/drivers/staging/wlan-ng/p80211mgmt.h index da824bc36365..fc23fae5651b 100644 --- a/drivers/staging/wlan-ng/p80211mgmt.h +++ b/drivers/staging/wlan-ng/p80211mgmt.h @@ -217,236 +217,4 @@ #define WLAN_SET_MGMT_CAP_INFO_PBCC(n) ((n) << 6) #define WLAN_SET_MGMT_CAP_INFO_AGILITY(n) ((n) << 7) -/*-- Information Element Types --------------------*/ -/* prototype structure, all IEs start with these members */ - -struct wlan_ie { - u8 eid; - u8 len; -} __packed; - -/*-- FH Parameter Set ----------------------------*/ -struct wlan_ie_fh_parms { - u8 eid; - u8 len; - u16 dwell; - u8 hopset; - u8 hoppattern; - u8 hopindex; -} __packed; - -/*-- DS Parameter Set ----------------------------*/ -struct wlan_ie_ds_parms { - u8 eid; - u8 len; - u8 curr_ch; -} __packed; - -/*-- CF Parameter Set ----------------------------*/ - -struct wlan_ie_cf_parms { - u8 eid; - u8 len; - u8 cfp_cnt; - u8 cfp_period; - u16 cfp_maxdur; - u16 cfp_durremaining; -} __packed; - -/*-- Challenge Text ------------------------------*/ -struct wlan_ie_challenge { - u8 eid; - u8 len; - u8 challenge[1]; -} __packed; - -/*-------------------------------------------------*/ -/* Frame Types */ - -/* prototype structure, all mgmt frame types will start with these members */ -struct wlan_fr_mgmt { - u16 type; - u16 len; /* DOES NOT include CRC !!!! */ - u8 *buf; - struct p80211_hdr *hdr; - /* used for target specific data, skb in Linux */ - void *priv; - /*-- fixed fields -----------*/ - /*-- info elements ----------*/ -}; - -/*-- Beacon ---------------------------------------*/ -struct wlan_fr_beacon { - u16 type; - u16 len; - u8 *buf; - struct p80211_hdr *hdr; - /* used for target specific data, skb in Linux */ - void *priv; - /*-- fixed fields -----------*/ - u64 *ts; - u16 *bcn_int; - u16 *cap_info; - /*-- info elements ----------*/ - struct wlan_ie_fh_parms *fh_parms; - struct wlan_ie_ds_parms *ds_parms; - struct wlan_ie_cf_parms *cf_parms; -}; - -/*-- IBSS ATIM ------------------------------------*/ -struct wlan_fr_ibssatim { - u16 type; - u16 len; - u8 *buf; - struct p80211_hdr *hdr; - /* used for target specific data, skb in Linux */ - void *priv; - - /*-- fixed fields -----------*/ - /*-- info elements ----------*/ - - /* this frame type has a null body */ - -}; - -/*-- Disassociation -------------------------------*/ -struct wlan_fr_disassoc { - u16 type; - u16 len; - u8 *buf; - struct p80211_hdr *hdr; - /* used for target specific data, skb in Linux */ - void *priv; - /*-- fixed fields -----------*/ - u16 *reason; - - /*-- info elements ----------*/ - -}; - -/*-- Association Request --------------------------*/ -struct wlan_fr_assocreq { - u16 type; - u16 len; - u8 *buf; - struct p80211_hdr *hdr; - /* used for target specific data, skb in Linux */ - void *priv; - /*-- fixed fields -----------*/ - u16 *cap_info; - u16 *listen_int; - /*-- info elements ----------*/ - -}; - -/*-- Association Response -------------------------*/ -struct wlan_fr_assocresp { - u16 type; - u16 len; - u8 *buf; - struct p80211_hdr *hdr; - /* used for target specific data, skb in Linux */ - void *priv; - /*-- fixed fields -----------*/ - u16 *cap_info; - u16 *status; - u16 *aid; - /*-- info elements ----------*/ - -}; - -/*-- Reassociation Request ------------------------*/ -struct wlan_fr_reassocreq { - u16 type; - u16 len; - u8 *buf; - struct p80211_hdr *hdr; - /* used for target specific data, skb in Linux */ - void *priv; - /*-- fixed fields -----------*/ - u16 *cap_info; - u16 *listen_int; - u8 *curr_ap; - /*-- info elements ----------*/ - -}; - -/*-- Reassociation Response -----------------------*/ -struct wlan_fr_reassocresp { - u16 type; - u16 len; - u8 *buf; - struct p80211_hdr *hdr; - /* used for target specific data, skb in Linux */ - void *priv; - /*-- fixed fields -----------*/ - u16 *cap_info; - u16 *status; - u16 *aid; - /*-- info elements ----------*/ - -}; - -/*-- Probe Request --------------------------------*/ -struct wlan_fr_probereq { - u16 type; - u16 len; - u8 *buf; - struct p80211_hdr *hdr; - /* used for target specific data, skb in Linux */ - void *priv; - /*-- fixed fields -----------*/ - /*-- info elements ----------*/ - -}; - -/*-- Probe Response -------------------------------*/ -struct wlan_fr_proberesp { - u16 type; - u16 len; - u8 *buf; - struct p80211_hdr *hdr; - /* used for target specific data, skb in Linux */ - void *priv; - /*-- fixed fields -----------*/ - u64 *ts; - u16 *bcn_int; - u16 *cap_info; - /*-- info elements ----------*/ - struct wlan_ie_fh_parms *fh_parms; - struct wlan_ie_ds_parms *ds_parms; - struct wlan_ie_cf_parms *cf_parms; -}; - -/*-- Authentication -------------------------------*/ -struct wlan_fr_authen { - u16 type; - u16 len; - u8 *buf; - struct p80211_hdr *hdr; - /* used for target specific data, skb in Linux */ - void *priv; - /*-- fixed fields -----------*/ - u16 *auth_alg; - u16 *auth_seq; - u16 *status; - /*-- info elements ----------*/ - struct wlan_ie_challenge *challenge; - -}; - -/*-- Deauthenication -----------------------------*/ -struct wlan_fr_deauthen { - u16 type; - u16 len; - u8 *buf; - struct p80211_hdr *hdr; - /* used for target specific data, skb in Linux */ - void *priv; - /*-- fixed fields -----------*/ - u16 *reason; - - /*-- info elements ----------*/ - -}; #endif /* _P80211MGMT_H */