From patchwork Thu Jul 27 10:11:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 126601 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp799419vqo; Wed, 26 Jul 2023 19:38:01 -0700 (PDT) X-Google-Smtp-Source: APBJJlEh6jA66pMp7CVIrcIf6si/AVwXXByAbfout9fO2qlyB8145mgDGB4qY4pmCS7/OOc/10Gw X-Received: by 2002:a17:902:db09:b0:1b8:8dbd:e1a0 with SMTP id m9-20020a170902db0900b001b88dbde1a0mr4673748plx.13.1690425481489; Wed, 26 Jul 2023 19:38:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690425481; cv=none; d=google.com; s=arc-20160816; b=sqkV9XRMWDVNauCQdeT1sGmk2XWseefcwq9wDUn+vWvfI89TB7YJTNU49Jd1g6GwEu dzBUxy1PFia7OEVXtmfDPeW6dHjEf7paPmB/sx1i46q5/ytKvTdrIaoDfL4PFSMPBL1Q i8WNhYhWzl26VC56NjDFovvSDxgMQq3WojFI9qE8inENy0DGhLxsPb/i3omnQ5dx2JAB tDYXvpIIHsozmExWpLDwbXIWIrxllo15pLHG+96oKGDRFN7tB1TkpxZqClxq3p/0OuXd aV0wgZcSErdRbu40lny1uffZj/hlhlYnqfDTUPWzPddOsOG8QHvsL7ZE5qNdU3IPJKSU hDvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=AT+TkJ0t8sbXbp5Ac7Da9/z3RuRo3VvY3na+hOomYEE=; fh=dVycksmN17cf7BqV4+IYfCGSbODTxmfwLJU+hyctj/c=; b=gdx4TQNbKQ3QyveccXvAlYfdFnM6a2drpiD21FmMC67Ta5PMEUpM0NpBPG8P/BOnh7 CGEzQjKi7tspK1OpPjwvwS6+UAlTKi+yPfbP9RzjWE7reDUyfpLT+f08SpTvSAeJrAhl 8hvr0rihrp1ZVd9lKUyai6D8Q7kYknWoYNQPuWzY1wxhpFmCggL9oGJx1375pviSF1IU pS4UvDZ6lKwgBeQ3x1oMqqvqAXsFlc4lswGSVHLoQAROkYdPVVBPOun/fwNwravuhgf/ oEwSzFm98XBjtVBJ/OY4I+PsK5umTjJ9pLF6eQMKGcJe0AbP+fN6hI3Ag1BCbuBRJ2ES 9vgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d22-20020a170902729600b001b9d34dbf63si374476pll.375.2023.07.26.19.37.48; Wed, 26 Jul 2023 19:38:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229889AbjG0CKt (ORCPT + 99 others); Wed, 26 Jul 2023 22:10:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229539AbjG0CKs (ORCPT ); Wed, 26 Jul 2023 22:10:48 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7059A19A0; Wed, 26 Jul 2023 19:10:47 -0700 (PDT) Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4RBDgs3YptzLntD; Thu, 27 Jul 2023 10:08:09 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 27 Jul 2023 10:10:44 +0800 From: Ruan Jinjie To: , , , , CC: Subject: [PATCH -next] media: rcar_jpu: Remove redundant dev_err() Date: Thu, 27 Jul 2023 10:11:28 +0000 Message-ID: <20230727101128.2752153-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772539589535005054 X-GMAIL-MSGID: 1772539589535005054 There is no need to call the dev_err() function directly to print a custom message when handling an error from platform_get_irq() function as it is going to display an appropriate error message in case of a failure. Signed-off-by: Ruan Jinjie Reviewed-by: Geert Uytterhoeven --- drivers/media/platform/renesas/rcar_jpu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/platform/renesas/rcar_jpu.c b/drivers/media/platform/renesas/rcar_jpu.c index 2b8cb50f54de..2c01bf14ccb4 100644 --- a/drivers/media/platform/renesas/rcar_jpu.c +++ b/drivers/media/platform/renesas/rcar_jpu.c @@ -1601,10 +1601,8 @@ static int jpu_probe(struct platform_device *pdev) /* interrupt service routine registration */ jpu->irq = ret = platform_get_irq(pdev, 0); - if (ret < 0) { - dev_err(&pdev->dev, "cannot find IRQ\n"); + if (ret < 0) return ret; - } ret = devm_request_irq(&pdev->dev, jpu->irq, jpu_irq_handler, 0, dev_name(&pdev->dev), jpu);