From patchwork Wed Jul 26 19:10:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dragos Tatulea X-Patchwork-Id: 126548 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp630954vqo; Wed, 26 Jul 2023 12:55:55 -0700 (PDT) X-Google-Smtp-Source: APBJJlE/c2BA9LtlbgD6tn6TuBf6Rizdjd7WkrCscrfjIURVvLxOyzoqzhbisTiwT4go9h5AZXI9 X-Received: by 2002:a17:906:8a4e:b0:974:1e0e:91ee with SMTP id gx14-20020a1709068a4e00b009741e0e91eemr161226ejc.13.1690401355328; Wed, 26 Jul 2023 12:55:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1690401355; cv=pass; d=google.com; s=arc-20160816; b=g5Mf8lufQ1jPXmPcSr28PioXR0iLJtvtJ6deWOYCDJsD1p/Ug3X4I0jYq5WXIpWMdE aiprTe4EdvB1x+4UAt1qbg4iJ7CvTjeB6Y82NUUIteYYLUGaPJRG/qaiG5ZoLyT3w2y4 h8mxCjVSj4Au2bF4jua7fLKduiFgBFdqqrySy9QMM1xIrzlRhBSDDzETT5+ZB0KAjQAA akTQsnMXe4MmprKXpkxkoFEDxnkJC4OUrwuB4wGhKbbok+oERbKb64Ddt31Rz5UVM1pB g6r+xxtmYtbkrS4uQK0Zqa5h0vBzgBYTDyTzadEQIpa7liZQlao3tdWKCZoqQ6W9X90N xt8g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=50uyCv6q9T5xOO82OAidZLM3ZMIb/RAddhyEUMSBmYQ=; fh=CaYCj+opwk7bBKnINuw7tP1HQMQNmPKMOqu6q617PaM=; b=xGos7FNa/AZssu08HMcMn7RPxdGCkOF8wBl9/FqlNzCkssJGkCue+MUbUKRFDJl+L5 3zs35UcDmcJIRgkZRnPn/K7A+Qli/4Gguzr55rBQ6e6b9sbCpAJRH4zi40V92XyCZQNz v4dSTuwW9iCQgBqMsumx1rRiBmmdYppwC2kRWPQg961BNk0LpBKz11GGoyDR3TpPAhHV 5MnZQGeiPHXaaYhlO/kOuUQBvrpfg8BNnjCivw+stT6qjtXLNOKCzq81STOSUZ5xXzuI i7Cy4ngfwno8Oq384MKZHAoyfvZ1uKjKR0SBFELdVL8ggtupEX4ipVdgi+Uq7YVKRY6A nhUA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@Nvidia.com header.s=selector2 header.b=TWP2Q+VR; arc=pass (i=1 spf=pass spfdomain=nvidia.com dmarc=pass fromdomain=nvidia.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=nvidia.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l11-20020a170906644b00b0099bbc5251basi1718518ejn.92.2023.07.26.12.55.30; Wed, 26 Jul 2023 12:55:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@Nvidia.com header.s=selector2 header.b=TWP2Q+VR; arc=pass (i=1 spf=pass spfdomain=nvidia.com dmarc=pass fromdomain=nvidia.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231485AbjGZTLK (ORCPT + 99 others); Wed, 26 Jul 2023 15:11:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbjGZTLI (ORCPT ); Wed, 26 Jul 2023 15:11:08 -0400 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 518651FF0; Wed, 26 Jul 2023 12:11:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bP5sJNAtBaTNkwIdKThs15/jGeRwM6wdQ3Px/QxJsqsEoWNvxCTKH5GPcd2GZyszGoCQrPJ63vbNDZE/01/cMN9fLRL/OkKlC5CWy4KgNcfgIbJSBf60ckdUxOINZklz81Ym3fv7PPOwkXRQqcyGHIO/xbWrPwqqlFOjYWtkqG6mPOD3KGs+7UADw8HXVJ3m3blmzaLtxl45g0tbylU0QwaI9ZWDddoQ6T5Z5y0xSAYvsa/LCNYV6r8UPxqU9VXil01YEWInkvCdhFmV/1KCzu8JZFD/dO1tNfhGtzwRD+kCh0G+COWYHS7GT2dFYMIy8estb/xWrBByGWHwBZHSnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=50uyCv6q9T5xOO82OAidZLM3ZMIb/RAddhyEUMSBmYQ=; b=k77huHIFPjT56yF4fyB2TcuGGGv4qzwY8vs48cUgZDRrReDwezKm8nS0ONQad1LBjSdQVDSYLKMktZdDP9VeN9n/HRjZkO0UMZbGxMzKLbYBilcPGpTN51ls0QMRQD+seVONGWCxSWDit+o/tTgxkZ8BSfY4LTa9jNR9F39yPUc7CsdWQAn8XgknJfuWwcQKl5PQtPJGemSRegY17NCdVs1qAygUBt97ctKBYefbcXLk9B+nzyLL7ogGi/9vFjFh853d1CnRr8NHyMRMnP+5YfirvsH7INtUtWP0kifPul3geTqfEQFs+2ys8V9ChC26yC1PmL8tdguex5XXEWUZOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=50uyCv6q9T5xOO82OAidZLM3ZMIb/RAddhyEUMSBmYQ=; b=TWP2Q+VRyceh8lwKIGill+aJk9bglUi2zNAk97X4ZAu3sIYeTthtyRRykzhxVnwXQESt+iRg32cL1XNCXTpzb7PAvvr/Cvodh0UD0fsGCJZWeseKTtdQDvB9Cav3uZidbhDtnjREF8k9yM9m11P6SBMbmEZ5b+kGFEeOQOLlDbUGnM38rmH7TInXxMGMhyioSMu0i6acvHS0asrattvE5UIn+Ul1q4JTwYLb0Y8ooTZGTBUHW77/acffJSbKwqqwIFj9C3xC62eXWuUk5NjPFpUXbKca+nIeW/GcvlIZD9OVYAGmcahQz5SY/D4WxRlrXpgjfbiXFqY4AXu48WPfhQ== Received: from DM6PR07CA0114.namprd07.prod.outlook.com (2603:10b6:5:330::29) by CH3PR12MB8306.namprd12.prod.outlook.com (2603:10b6:610:12c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Wed, 26 Jul 2023 19:11:02 +0000 Received: from DM6NAM11FT023.eop-nam11.prod.protection.outlook.com (2603:10b6:5:330:cafe::b5) by DM6PR07CA0114.outlook.office365.com (2603:10b6:5:330::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29 via Frontend Transport; Wed, 26 Jul 2023 19:11:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DM6NAM11FT023.mail.protection.outlook.com (10.13.173.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29 via Frontend Transport; Wed, 26 Jul 2023 19:11:02 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Wed, 26 Jul 2023 12:10:48 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Wed, 26 Jul 2023 12:10:48 -0700 Received: from c-237-113-220-225.mtl.labs.mlnx (10.127.8.12) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Wed, 26 Jul 2023 12:10:45 -0700 From: Dragos Tatulea To: "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Xie Yongji CC: , Gal Pressman , Dragos Tatulea , , Subject: [PATCH] virtio-vdpa: Fix cpumask memory leak in virtio_vdpa_find_vqs() Date: Wed, 26 Jul 2023 22:10:07 +0300 Message-ID: <20230726191036.14324-1-dtatulea@nvidia.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT023:EE_|CH3PR12MB8306:EE_ X-MS-Office365-Filtering-Correlation-Id: f8eb4417-d055-4fee-2870-08db8e0c0deb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 74GP4BmmHalZbLu1QKQ+gdUsGwSDweK5Nqf02rmjLLA2zd+gtag3VahrcKcUg/6ZVw2A6QXzi/ADNIlSxP5bk2pl+ASGzbo9IViGUfjDsEqNOSP399UNv+wKIVP0SBX+ziV4HxWHHSWrrgJhbGWTsMpD64aV2D4v2uo1uqKhqyss4aVBLMsEV1hOZKHfmMA+HBD6JuP/5sM6Fs2Bpzbyox7tP2c61hc2V8rXbqhFukp4YZpo3rTByMdw8M/2ioX26JErdvlXquD7nSaV55Shf/q0/jbYUtZiV0oG3GnsDtqekBV+kFaBpFUpUNkn8uP00cnxs53FAfhD6r0oN2OUZAFrxi7UjInVEbXsfwV9lEKoZSBLdkWd/pF5ehU4evPzIWtfi3fOWYsC47G6oByozMg8AEft/G6fQUIoGP5xrI9OuB+p3isAfRWArNyn3MVV36p/Izj9pEu/fdw0EHXdPnzgxZcxgg3ATaFVtwfS9+h8ZabFj32qGWBjxyyYxVVjyw8dKhOI4AdHvuqooRXnNl4j4w3IIr+8eJCmQp0VJyHyCjddGcx3XINTUpD7PCDVkC4goC23XJiOjxVxC+syw/yiMUCYykTqjjYA4xVy8fSvm2S+HWZyEWvqoYgTvcU817XJde1ndnAEILBwMuXVsBo+j16BAlf8Hq2KGCEBsGHvNDGbz/m5Pqbdp7UiaDMTF3wy6UmYHq6cNOpgqPGw9L4245P5/TtXFhassDDTVUgxYi1zZQX4jeTSFk3oDK+m X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(346002)(136003)(376002)(82310400008)(451199021)(46966006)(40470700004)(36840700001)(7636003)(336012)(41300700001)(26005)(36860700001)(478600001)(86362001)(36756003)(4326008)(8676002)(8936002)(70206006)(70586007)(186003)(316002)(82740400003)(5660300002)(2906002)(40460700003)(110136005)(2616005)(47076005)(356005)(54906003)(426003)(1076003)(40480700001)(6666004)(4744005);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 19:11:02.5917 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f8eb4417-d055-4fee-2870-08db8e0c0deb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT023.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8306 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772514291725417741 X-GMAIL-MSGID: 1772514291725417741 From: Gal Pressman Free the cpumask allocated by create_affinity_masks() before returning from the function. Fixes: 3dad56823b53 ("virtio-vdpa: Support interrupt affinity spreading mechanism") Signed-off-by: Gal Pressman Reviewed-by: Dragos Tatulea Acked-by: Jason Wang Reviewed-by: Xie Yongji --- drivers/virtio/virtio_vdpa.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c index 989e2d7184ce..961161da5900 100644 --- a/drivers/virtio/virtio_vdpa.c +++ b/drivers/virtio/virtio_vdpa.c @@ -393,11 +393,13 @@ static int virtio_vdpa_find_vqs(struct virtio_device *vdev, unsigned int nvqs, cb.callback = virtio_vdpa_config_cb; cb.private = vd_dev; ops->set_config_cb(vdpa, &cb); + kfree(masks); return 0; err_setup_vq: virtio_vdpa_del_vqs(vdev); + kfree(masks); return err; }