From patchwork Tue Jul 25 14:17:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Patchwork-Id: 125664 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp2511191vqg; Tue, 25 Jul 2023 07:30:07 -0700 (PDT) X-Google-Smtp-Source: APBJJlHINYSGM2mFRvWRLx7NsUDJ0QYCRLpvlEpjgKfuUcCDGhZ7qJqY6S0eBv204Bkft+rSH+np X-Received: by 2002:a17:90b:388a:b0:268:a61:ba86 with SMTP id mu10-20020a17090b388a00b002680a61ba86mr5188220pjb.16.1690295406754; Tue, 25 Jul 2023 07:30:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690295406; cv=none; d=google.com; s=arc-20160816; b=V78vHltNiOXSGBQ0GvNNJshveMj7KHCtxDzZ4kWvcv+WSpxNqgUGsvD5GOAbq9yHMC IhV2opRKJmsUbHJSplxuJPWhc7hC1o8u3ZeKU5YR3elQNLZ6kuy5K30tmJk3/kn6iTKV Vkb/F0A0PaUIVI/Bwp6L5Sr3lDkqEwfGaoKeOMlX2QJkVSMyO9GWWWAB6udJLme1yKYd n31eHPJ6joYyg8UR3oU3p8lLj3uUigSzOxGbRMBn7B/4s1vag+qrw7oCSlc+PfO4HM9o 3vr9AhTGDDquCZlWCl8eJicLzCnFCXfnaNRVO4s+J1hoZw5hH//jJjAKGgsQZ/gZf6Ir AqlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=Yc4H+0G+6pbyEOqSql7utPUvhs4BREL4FC5e6Cqe0wI=; fh=98ldnqYmygHFAu011R/YTI1xSjEYMq+glb2NLK4SXpM=; b=fOv08Owrvu0ez+AyyDC4Bn5Ldn/Uhr7K6HWqT0xorfG1CQ3TyjhlsyKAp6Cbw3Nw4t lRBJnppPXXX5dKX2zisG2+umKT+CYpEKjStOCJcn9vAuCqO3XBkLRMrJjRggZHLVvhwI 388ZHtpbld5/nTakmZoNQzOyW4dplZrqX4bo/0PVE1II4C8lIWQMoDnbSo6oPi57B2P+ 5JcXXQj5NQruPOCqjN5PydR3aTGeQAEodCw6n8VbM52WlFFkCl9A7AE8h6Ae+PvEV0ZK WtNZT8ggdvh+yoIIyoM6hdisxLbYZ8Mebn2cMlgTC3DMg/UTZuM3xOra3J+uJVuezdGs bUwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@weissschuh.net header.s=mail header.b=hZ4Dq9Jt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z12-20020a17090acb0c00b00267b5046410si13916623pjt.81.2023.07.25.07.29.11; Tue, 25 Jul 2023 07:30:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@weissschuh.net header.s=mail header.b=hZ4Dq9Jt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232706AbjGYOVH (ORCPT + 99 others); Tue, 25 Jul 2023 10:21:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230474AbjGYOUu (ORCPT ); Tue, 25 Jul 2023 10:20:50 -0400 Received: from todd.t-8ch.de (todd.t-8ch.de [IPv6:2a01:4f8:c010:41de::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76FEA2697; Tue, 25 Jul 2023 07:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1690294648; bh=6N3Sq6NeH6BbaiavR7O3xkbcCrkvZ1yXDKwPR9c54IU=; h=From:Date:Subject:To:Cc:From; b=hZ4Dq9Jty0CBm1B7i/IztsQxrb73cmHBaM0NYBp6fvT7DGdtx4mBfmmMS14ZkvrRv ppxfYAfBsRvn6Ys+FkI1lEnTclH/udPHoMyCawp4j4ds11iUF4x6qMKGIwe6MQaCPy S2JRsDZ8eJaxyi3f7dj4asyV+jEMrXaeyLkATuVY= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Date: Tue, 25 Jul 2023 16:17:25 +0200 Subject: [PATCH] mmc: core: propagate removable attribute to driver core MIME-Version: 1.0 Message-Id: <20230725-mmc-removable-v1-1-b2e0c4f18e6d@weissschuh.net> X-B4-Tracking: v=1; b=H4sIAHTZv2QC/x3MQQqAIBBA0avIrBPMsKirRAvTsQZSQ0EC6e5Jy 7f4v0LGRJhhYRUSFsoUQ0PfMTCnDgdyss0ghRzEJBX33vCEPha9X8iVcdboGa0YJbTmTujo+X/ r9r4fQjtuzl8AAAA= To: Ulf Hansson Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1690294647; l=1153; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=6N3Sq6NeH6BbaiavR7O3xkbcCrkvZ1yXDKwPR9c54IU=; b=ccSN6txL/80O9P0/RQTEBgYopVxGhLEMhnyOhucPYN3wxQW7b+nj4Az6lPuzFezzvZvisQThA DTD/f6hfMyGC1EklsVkc0zaRopPw7Ki5/6PnPxDhwo+zFkoxk0MG8db X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772403196431482376 X-GMAIL-MSGID: 1772403196431482376 Userspace can use this to distinguish hotpluggable mmc devices such as sdcards from non-hotpluggable ones such as eMMC. One example is the lsblk tool from util-linux. Note that dev_set_removable() is not related to GENHD_FL_REMOVABLE which is not applicable as per the comment in drivers/mmc/core/block.c Link: https://github.com/util-linux/util-linux/issues/2379 Signed-off-by: Thomas Weißschuh Reviewed-by: Avri Altman --- drivers/mmc/core/bus.c | 3 +++ 1 file changed, 3 insertions(+) --- base-commit: 0b5547c51827e053cc754db47d3ec3e6c2c451d2 change-id: 20230725-mmc-removable-5cfdca9ed062 Best regards, diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c index 2c3074a605fc..0af96548e7da 100644 --- a/drivers/mmc/core/bus.c +++ b/drivers/mmc/core/bus.c @@ -310,6 +310,9 @@ int mmc_add_card(struct mmc_card *card) dev_set_name(&card->dev, "%s:%04x", mmc_hostname(card->host), card->rca); + dev_set_removable(&card->dev, + mmc_card_is_removable(card->host) ? + DEVICE_REMOVABLE : DEVICE_FIXED); switch (card->type) { case MMC_TYPE_MMC: