From patchwork Tue Jul 25 11:48:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijaya Krishna Nivarthi X-Patchwork-Id: 125584 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp2432978vqg; Tue, 25 Jul 2023 05:29:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlEY0AKTJJ2KuxAmqFJuP2OZCNj/ZCINh5qsfmESf2D0UKslhqQF9HciTj5FkVwztarZvSxO X-Received: by 2002:a17:90b:4d90:b0:267:85ae:2367 with SMTP id oj16-20020a17090b4d9000b0026785ae2367mr12368990pjb.12.1690288149239; Tue, 25 Jul 2023 05:29:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690288149; cv=none; d=google.com; s=arc-20160816; b=Y9Gu5q04+GrPZ2qQs5+UkQkaLAHcSJkkD4smrNBtdQzu+sLKHAmpIcLtgwvdvKzHeG Lwh33IVfbmkeE2giiQbyMNhay+MZqgFDf1sYi8hlASYEWtjLc/d9YNYBrdx0dVUu6VQA 6hJ6K2wNAhROLrB1/Ccf8nVa4BSQ54xLMY7v0EahM0Udjb4TyaSuseQ+Cn0fiAGQZY64 S2kXLKHoKQzzuV4Z5NzrQfnBECs2+/KJbgJPdQh69S/FI63HdOwBECy9ThelGXP6C9zg RRTlvYve4fPOY50t8onUJG1DJk9k/tD9LGuhaIq75+mnnsLJoc66BQvJEfxwLOe5x46e 21BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=Y8buMMzhQ7FtSPdJ2/drbMy2Q2nEihK3vxgah9dupxs=; fh=sUt3fW9BcxbpVnL4H4NNbXPdlBxkplNtYqeLoxhn71o=; b=avGHJ/2TXX8i6riuZFsXwaIR1eKMBYXvkRtnxqu44/i6sH6/gijDSi9RNNGpRBfDxA 6PkmkEZMDx2k4B+qjvADscWbjlpZvqV4RvJd+WA5TUHBf3n+4YYHqoOkOxpYpUtAsiog O42QZSXZcfDR92vWCgjq5zWyAQW51U+7hGPIvCWYYUNhmo9TLI0MVBzssvYV63604rGM l8Dzv2yR6HWrSInLNUFJiSH9LcKlbZDyS+uaiOCAUouoDDhBE0PqHyNX9sPSfqLukyOi 1Q8aB/+48Fs86WNarR5/qCZhV6W8E97Qj8HOF5CKO4B/hkJgPuOrcwv1zs+YwLyl2EOL wCNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=hkHCdqjn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pi12-20020a17090b1e4c00b00262ef440ed4si15036895pjb.27.2023.07.25.05.28.55; Tue, 25 Jul 2023 05:29:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=hkHCdqjn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232831AbjGYLsv (ORCPT + 99 others); Tue, 25 Jul 2023 07:48:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235128AbjGYLsZ (ORCPT ); Tue, 25 Jul 2023 07:48:25 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 868FA10E3; Tue, 25 Jul 2023 04:48:24 -0700 (PDT) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36PAVCh6024633; Tue, 25 Jul 2023 11:48:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=qcppdkim1; bh=Y8buMMzhQ7FtSPdJ2/drbMy2Q2nEihK3vxgah9dupxs=; b=hkHCdqjnspq/GdYZCqNQ9aVpD4kz5JCSt+zXwexp2MegcVRo5Rm9uCeUYGpxr+8RonVb /8duf56r6CGvhyGdvy4QIpOzPgP6deXEuPWJMUexIbEhLmzSyybzS6Su2OHHw9xoLAKq KI2jmWBcW2qBTxjLz2udOQsihILwwe8E6ZHSUQMfrjh8Tx29i7bGNAiznWMG+y2nEr0W rUKmURbZQRWAAWgzj/VqoEaWVPT3HplaRfUY9nM1gVglX8v+5bpOeLp4j6s1gqNgf0SF z7qjzF/Kei2LQXYnVtOnR4gQMw43jahXiYvHkJT3wFcPU1OwPW93MvemN5yqgcO+Q6Ao PQ== Received: from apblrppmta01.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3s1qastu83-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jul 2023 11:48:20 +0000 Received: from pps.filterd (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 36PBmHpj008447; Tue, 25 Jul 2023 11:48:17 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTPS id 3s086kv0y7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 25 Jul 2023 11:48:17 +0000 Received: from APBLRPPMTA01.qualcomm.com (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 36PBmGgU008439; Tue, 25 Jul 2023 11:48:16 GMT Received: from hu-sgudaval-hyd.qualcomm.com (hu-vnivarth-hyd.qualcomm.com [10.213.111.166]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTP id 36PBmG9F008437; Tue, 25 Jul 2023 11:48:16 +0000 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 3994820) id EE50A3434; Tue, 25 Jul 2023 17:18:15 +0530 (+0530) From: Vijaya Krishna Nivarthi To: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, broonie@kernel.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: quic_msavaliy@quicinc.com, dianders@chromium.org, mka@chromium.org, swboyd@chromium.org, quic_vtanuku@quicinc.com, dan.carpenter@linaro.org, Vijaya Krishna Nivarthi Subject: [PATCH 1/4] spi: spi-qcom-qspi: Ignore disabled interrupts' status in isr Date: Tue, 25 Jul 2023 17:18:06 +0530 Message-Id: <1690285689-30233-2-git-send-email-quic_vnivarth@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1690285689-30233-1-git-send-email-quic_vnivarth@quicinc.com> References: <1690285689-30233-1-git-send-email-quic_vnivarth@quicinc.com> X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: J95l_wAvZ-t56Eurjd4jWKpSBQFejlIy X-Proofpoint-GUID: J95l_wAvZ-t56Eurjd4jWKpSBQFejlIy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-25_06,2023-07-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 impostorscore=0 mlxscore=0 mlxlogscore=258 adultscore=0 priorityscore=1501 clxscore=1015 spamscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307250103 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772395586192529625 X-GMAIL-MSGID: 1772395586192529625 During FIFO/DMA modes dynamic switching, only corresponding interrupts are enabled. However its possible that FIFO related interrupt status registers get set during DMA mode. For example WR_FIFO_EMPTY bit is set during DMA TX. Ignore such status bits so that they don't trip unwanted operations. Suggested-by: Douglas Anderson Signed-off-by: Vijaya Krishna Nivarthi Reviewed-by: Douglas Anderson Tested-by: Douglas Anderson --- drivers/spi/spi-qcom-qspi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c index a0ad980..b995542 100644 --- a/drivers/spi/spi-qcom-qspi.c +++ b/drivers/spi/spi-qcom-qspi.c @@ -603,6 +603,9 @@ static irqreturn_t qcom_qspi_irq(int irq, void *dev_id) int_status = readl(ctrl->base + MSTR_INT_STATUS); writel(int_status, ctrl->base + MSTR_INT_STATUS); + /* Ignore disabled interrupts */ + int_status &= readl(ctrl->base + MSTR_INT_EN); + /* PIO mode handling */ if (ctrl->xfer.dir == QSPI_WRITE) { if (int_status & WR_FIFO_EMPTY) From patchwork Tue Jul 25 11:48:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijaya Krishna Nivarthi X-Patchwork-Id: 125564 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp2426577vqg; Tue, 25 Jul 2023 05:17:40 -0700 (PDT) X-Google-Smtp-Source: APBJJlHcK/V/U6OCKFcp2M4A0cfMlKn31+rK9PQH3gwYSzaZS1KFGB+L1qSsZv42iEZ58ng+rJ7r X-Received: by 2002:a17:907:2cc9:b0:99b:415f:2e4f with SMTP id hg9-20020a1709072cc900b0099b415f2e4fmr12817466ejc.57.1690287460403; Tue, 25 Jul 2023 05:17:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690287460; cv=none; d=google.com; s=arc-20160816; b=hLDKgdnMsMXMyeG9mtv6xEsu0oGxAAb8SOqCWHC2xL50i5HmMmFAIwabnBhN1LcESL Q9cVbGj0tv8xUeNrUR8k/qw8OwqurwsbrtaBZSNW6G400MAWsiAi24F3Sx5e7vBl2YFD lWpb46u8/wy1m65UmvIHCRwME5nwmhXmKB7WehP1npFF6luXnHrIbTJKi4ESpP1jXwf3 bUxDfY92tjjhDyNIk64yqZz3IGRJpoizLBclpNtP7BCSRwWLQhmveGMsjd78a5484rPk IrfvJba2KfHVID6V1akYDjvmyCGpe6WSMJTcZNjNn3OO32Na5nf1Paba7WJgXZmhhGd/ jh3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=sod3msRdmmhbk+9MCJa7CBZD8q/hqXsIwy8V3MMLdzw=; fh=sUt3fW9BcxbpVnL4H4NNbXPdlBxkplNtYqeLoxhn71o=; b=occa6LpQEtUT0/cOoQIAPKjEY9jDeqIexBM7arhkiem7Iag54Eql5NxjLgSrjBt7nE +tqRvHhS6vMjDJztqPgy0fRUGvospfJ4iI9RMIZB+X7ksuwXUOreazuxVVGPHjEdUtKV 9rmyhQrVDI24ovh5Cqd7Tb5LPkostJwdUF3ByCMOMVV4FZImuNUCrZwI+VVKukf98PUh Lctb+8oM2bkGKYj32fWPQ4P3060aL1TvEsqpyK4YLi8KIn8PemaU6XHgFhEuo7fc1kAr wICJRKhZyFkE1hvbIvoXOzps+w4qswbQNy90s27d/IsRO/PxPPRFg/JU7X3KZ/q2hEV6 OIoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=N5VoduOy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i9-20020a170906090900b009827e17b069si7999529ejd.1029.2023.07.25.05.17.15; Tue, 25 Jul 2023 05:17:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=N5VoduOy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232834AbjGYLsz (ORCPT + 99 others); Tue, 25 Jul 2023 07:48:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235135AbjGYLs0 (ORCPT ); Tue, 25 Jul 2023 07:48:26 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C05F10E3; Tue, 25 Jul 2023 04:48:25 -0700 (PDT) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36PBl73p019214; Tue, 25 Jul 2023 11:48:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=qcppdkim1; bh=sod3msRdmmhbk+9MCJa7CBZD8q/hqXsIwy8V3MMLdzw=; b=N5VoduOydDWrgFNK7hgjfTYyBhlcuM0Q2TWFWsQtLjexPqE79vimJsOwtg9kySALBC3q Vi5Zlb+PdX0NK2iwgozXfVnefhhG9cAUU1cMyfsasta9CqwSFXIJBVJ3VtIsMDRd8+TP wLZhPF13Epb636I+n/dO5iUm7KvRKhpa5fSdEFyRJq43K3ALWf30jD37+k7LcujO5Qej heIXrLXrgrLa5AtdcAXipk3AU58Etor4zUrGLOkATLFgHDu1mZvcecNg6Es33SQ7gUc4 jm0j6aGqjP/r3fIQWkjkbZp+TJT6BY+z2v4LUu7Aae6vOqoPkd5Sp6guJIx6JRRiej8X Mg== Received: from apblrppmta01.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3s2dqag0bv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jul 2023 11:48:22 +0000 Received: from pps.filterd (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 36PBmJ5F008462; Tue, 25 Jul 2023 11:48:19 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTPS id 3s086kv0ye-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 25 Jul 2023 11:48:19 +0000 Received: from APBLRPPMTA01.qualcomm.com (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 36PBmGgW008439; Tue, 25 Jul 2023 11:48:18 GMT Received: from hu-sgudaval-hyd.qualcomm.com (hu-vnivarth-hyd.qualcomm.com [10.213.111.166]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTP id 36PBmIwi008452; Tue, 25 Jul 2023 11:48:18 +0000 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 3994820) id A4A0A3434; Tue, 25 Jul 2023 17:18:17 +0530 (+0530) From: Vijaya Krishna Nivarthi To: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, broonie@kernel.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: quic_msavaliy@quicinc.com, dianders@chromium.org, mka@chromium.org, swboyd@chromium.org, quic_vtanuku@quicinc.com, dan.carpenter@linaro.org, Vijaya Krishna Nivarthi Subject: [PATCH 2/4] spi: spi-qcom-qspi: Use GFP_ATOMIC flag while allocating for descriptor Date: Tue, 25 Jul 2023 17:18:07 +0530 Message-Id: <1690285689-30233-3-git-send-email-quic_vnivarth@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1690285689-30233-1-git-send-email-quic_vnivarth@quicinc.com> References: <1690285689-30233-1-git-send-email-quic_vnivarth@quicinc.com> X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: pG_7Nw6ndLAkMfrzn6JktmmFzHT9TSgt X-Proofpoint-ORIG-GUID: pG_7Nw6ndLAkMfrzn6JktmmFzHT9TSgt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-25_06,2023-07-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=692 bulkscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 suspectscore=0 clxscore=1015 spamscore=0 malwarescore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307250103 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772394864159020808 X-GMAIL-MSGID: 1772394864159020808 While allocating for DMA descriptor, GFP_KERNEL flag is being used and this allocation happens within critical section with spinlock acquired. This generates a static checker warning. Use GFP_ATOMIC to prevent sleeping; and since this increases chances of allocation failure, add handling accordingly. Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/abc223e8-44af-40bb-a0bd-9865b393f435@moroto.mountain/ Signed-off-by: Vijaya Krishna Nivarthi Reviewed-by: Douglas Anderson --- drivers/spi/spi-qcom-qspi.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c index b995542..b938908 100644 --- a/drivers/spi/spi-qcom-qspi.c +++ b/drivers/spi/spi-qcom-qspi.c @@ -308,9 +308,11 @@ static int qcom_qspi_alloc_desc(struct qcom_qspi *ctrl, dma_addr_t dma_ptr, dma_addr_t dma_cmd_desc; /* allocate for dma cmd descriptor */ - virt_cmd_desc = dma_pool_alloc(ctrl->dma_cmd_pool, GFP_KERNEL | __GFP_ZERO, &dma_cmd_desc); - if (!virt_cmd_desc) - return -ENOMEM; + virt_cmd_desc = dma_pool_alloc(ctrl->dma_cmd_pool, GFP_ATOMIC | __GFP_ZERO, &dma_cmd_desc); + if (!virt_cmd_desc) { + dev_warn_once(ctrl->dev, "Couldn't find memory for descriptor\n"); + return -EAGAIN; + } ctrl->virt_cmd_desc[ctrl->n_cmd_desc] = virt_cmd_desc; ctrl->dma_cmd_desc[ctrl->n_cmd_desc] = dma_cmd_desc; From patchwork Tue Jul 25 11:48:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijaya Krishna Nivarthi X-Patchwork-Id: 125575 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp2431601vqg; Tue, 25 Jul 2023 05:26:36 -0700 (PDT) X-Google-Smtp-Source: APBJJlEalAD7M5YO/ZMsb/BeC+vJwKkz7Ch1umAWaB1KlKyl8Mb3wc+3NkqPBmcSAUpSfcr0Xalv X-Received: by 2002:a17:903:2447:b0:1b7:f24c:3b9a with SMTP id l7-20020a170903244700b001b7f24c3b9amr17414728pls.47.1690287996225; Tue, 25 Jul 2023 05:26:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690287996; cv=none; d=google.com; s=arc-20160816; b=jyISrnXQyouQlC2rtDDxnADJ+n03QLcaXfdMVB6u0vuGR58iyNdg0YgWl0n36x5sIF Cb4XcKBRylB50/Eos8JJEuUUQkhrE8WrQg488o2vLuDgKdXrp8oYXNOj4wbpMc5UuE7+ zFBmYydCsrBjFPNX75PDvXImB5dNtjphPClp9k4BYjtCt01PMaf2uj5eRv1KUPGGFS2g IGVxrq+n8J2h7z+UOb53SpISH6hHgd0Y2ogWKsAQZy2qME7ElyZr08Djeir9hoqzAmcl 1BEM6RfOHN/Ox0w+Bo/zSnW4M0bRqg2wTv0jyy2VsrQAop1xJJ8Bs+acCvmwS7sooArU ZJEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=cxS/vjm5g4KmLmNLXOOC61HZLgtcILclQ/JcLeOPzHQ=; fh=sUt3fW9BcxbpVnL4H4NNbXPdlBxkplNtYqeLoxhn71o=; b=jsUEF1mwsGpyHhsN8WnIi6XvOI63Y+FZbAxA4sUAtLLS2vJNNeK9mKgG1MbmjHu97d UwrlqdIxoXFm+x/w6fRrioPI3F+kZpvYOppgGXZKUDhuoIrEs9zsB2AbNyDJj68FFU18 4F9erltSFebaDJcW/KWThLgQRqgIX0wQgGoFcYdUqe1LvXRjDaE8qbDcZNbcxoVf3iWI QRoH8n3r1LQoD0zmmwaf9CBuouyeiLKzk8P6ZUFK0wcW4LXHw5dyn5eeKipPWeesee1L 5OgWzHoEJH0eH1nFiQ827VlqejfYwz9XC9RUdKaKYUYYltdJ50XBiftiCk+GwiX5MXbD pXYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=diPzOX4s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b17-20020a170903229100b001bba040f034si5111229plh.354.2023.07.25.05.26.22; Tue, 25 Jul 2023 05:26:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=diPzOX4s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233281AbjGYLs7 (ORCPT + 99 others); Tue, 25 Jul 2023 07:48:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235147AbjGYLs3 (ORCPT ); Tue, 25 Jul 2023 07:48:29 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC64C10E2; Tue, 25 Jul 2023 04:48:28 -0700 (PDT) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36PAqb77003492; Tue, 25 Jul 2023 11:48:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=qcppdkim1; bh=cxS/vjm5g4KmLmNLXOOC61HZLgtcILclQ/JcLeOPzHQ=; b=diPzOX4sQonsbZukUXtqUmS35PA2rBrR2Pp8oRt/mcEWt1FZ69VZvytF6vHwWHAVxyE3 WdO9lKGyGht9PmOGcimJtoBGgACztqdi83DXsEokad0xcDpy/X4wNL2bgWxg3+An1SCg jDu2rrXtRZ4B9WW9jtbrBl+2BAzIagd9vP0sEfyEl2BcN3EKFEmkDOo7mXS9Q6SiSykF Skdsa0RnrXaBN2bmZ7UHtKZ+UQALxvLM/b/otYoLTFwDB8Qvm3J6V+k4GFD83Eg2Q7na iIal6itycj4BhNdKwbZ0WEZYM9usLbmNe8ArqWucIdOxQhLeuoUr4s6t8EU4eUHmfZ8P 3A== Received: from apblrppmta01.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3s1qastu87-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jul 2023 11:48:22 +0000 Received: from pps.filterd (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 36PBmFHo008429; Tue, 25 Jul 2023 11:48:20 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTPS id 3s086kv0ym-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 25 Jul 2023 11:48:20 +0000 Received: from APBLRPPMTA01.qualcomm.com (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 36PBmJP2008468; Tue, 25 Jul 2023 11:48:19 GMT Received: from hu-sgudaval-hyd.qualcomm.com (hu-vnivarth-hyd.qualcomm.com [10.213.111.166]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTP id 36PBmJPH008467; Tue, 25 Jul 2023 11:48:19 +0000 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 3994820) id D386C3434; Tue, 25 Jul 2023 17:18:18 +0530 (+0530) From: Vijaya Krishna Nivarthi To: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, broonie@kernel.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: quic_msavaliy@quicinc.com, dianders@chromium.org, mka@chromium.org, swboyd@chromium.org, quic_vtanuku@quicinc.com, dan.carpenter@linaro.org, Vijaya Krishna Nivarthi Subject: [PATCH 3/4] spi: spi-qcom-qspi: Call dma_wmb() after setting up descriptors Date: Tue, 25 Jul 2023 17:18:08 +0530 Message-Id: <1690285689-30233-4-git-send-email-quic_vnivarth@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1690285689-30233-1-git-send-email-quic_vnivarth@quicinc.com> References: <1690285689-30233-1-git-send-email-quic_vnivarth@quicinc.com> X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: gM2cr2YF-Bc1Y3t5_xnulY8HwPepCVfj X-Proofpoint-GUID: gM2cr2YF-Bc1Y3t5_xnulY8HwPepCVfj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-25_06,2023-07-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 impostorscore=0 mlxscore=0 mlxlogscore=729 adultscore=0 priorityscore=1501 clxscore=1015 spamscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307250103 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772395426073145571 X-GMAIL-MSGID: 1772395426073145571 After setting up dma descriptors and before initiaiting dma transfer, call dma_wmb() to ensure all writes go through. This doesn't fix any reported problem but is added for safety. Signed-off-by: Vijaya Krishna Nivarthi Reviewed-by: Douglas Anderson --- drivers/spi/spi-qcom-qspi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c index b938908..d75234d 100644 --- a/drivers/spi/spi-qcom-qspi.c +++ b/drivers/spi/spi-qcom-qspi.c @@ -443,8 +443,10 @@ static int qcom_qspi_transfer_one(struct spi_master *master, ret = qcom_qspi_setup_dma_desc(ctrl, xfer); if (ret != -EAGAIN) { - if (!ret) + if (!ret) { + dma_wmb(); qcom_qspi_dma_xfer(ctrl); + } goto exit; } dev_warn_once(ctrl->dev, "DMA failure, falling back to PIO\n"); From patchwork Tue Jul 25 11:48:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijaya Krishna Nivarthi X-Patchwork-Id: 125580 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp2432363vqg; Tue, 25 Jul 2023 05:27:57 -0700 (PDT) X-Google-Smtp-Source: APBJJlF9JXzBFHj3sxqBrKYPpWgu3CGdDXOW92AQy0R8vpcwKzpQ2ImJvDVJmWt4zL6i/P6hYYuI X-Received: by 2002:a05:6808:1514:b0:39c:59e2:dd79 with SMTP id u20-20020a056808151400b0039c59e2dd79mr14358592oiw.36.1690288077576; Tue, 25 Jul 2023 05:27:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690288077; cv=none; d=google.com; s=arc-20160816; b=DrunDR0e9PkwuLgp52y4/iA2W0wSd2I8T8jSVi0lWw1RJdLquExlXBZeeABz855gsQ 8D8ZiMdqlfKOR0KyuV5HswBkYzegc60wGnAV8So4xMEMXymil+W8z7xVYfWV9ac0endi IPygF7PMkkHm1/be5cLgHne7TEWvXjR02W5eX9ds23h1yUTODSsCfYKTBZUIhQvMIFBp CO178Ssg3nAAhdGfmJgPzat27Z9SQGoyDCee5YAPR28DjXjrhJ4hxz+O/XDIrPEXo5pv 3rupkK9bM1YmUlgMiZVK7GW+YSCobPlYT4RlJurTs/wWObPrCrItjRbS8aFZrlbQPgx7 sXIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=3e0b7EvvEVtXP6Zq2CP3Qw3EoqOYKi7wp2ZLSG6MY5c=; fh=sUt3fW9BcxbpVnL4H4NNbXPdlBxkplNtYqeLoxhn71o=; b=JzBp5B8qPfpaZISi8yMScYe0NvlqIb87XjauE+iZKtYubyejOHWXPPYwWtgVVtI+FS D3aO+zQAyqU7eU1rLjDsrDk2QV1XWr+Ba2bRFWdkElbYdTzEGJ8sK2RsKGEBJjtiNknC D1saLF3VA/4UVXqnKy/ce/XYk5q0eN9/fZfzWwuFUobuG/xTWyrGihMfhaRFWfKT/aRg iRahnZSusV/eoRZ850hvW23PNIfbZK/WPDafGBfq2hUKbOpIpyjHe9EVDGu23EWX6egi CHrAICLaDMUnMGnw8PAxn/YNFuE/OoiyCtIWK56uTS9B4LnFyip9EzEhDvLitQPdr0T/ VkFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Svy1parQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x9-20020a170902a38900b001bb821e394esi6915810pla.319.2023.07.25.05.27.44; Tue, 25 Jul 2023 05:27:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Svy1parQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231516AbjGYLsg (ORCPT + 99 others); Tue, 25 Jul 2023 07:48:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235151AbjGYLsa (ORCPT ); Tue, 25 Jul 2023 07:48:30 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96AD1E74; Tue, 25 Jul 2023 04:48:29 -0700 (PDT) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36PAVuMd013198; Tue, 25 Jul 2023 11:48:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=qcppdkim1; bh=3e0b7EvvEVtXP6Zq2CP3Qw3EoqOYKi7wp2ZLSG6MY5c=; b=Svy1parQ5axKRJZK3rvr8Wg0JNL0bpCmqAaDxcRt/7u14LaDZVT7dZSQ3RNVIcowdM9F X2UqeOJ9XD27JdtHN3VgideIRtRXNAmkzzPj4BdT8/tfRnod+rnjhPNA7Rdzvjay/Uyy 7V0HlcNIbKmaxUsQeuZbuZ+hkL+GfqR8la/WXTzcYyJCzKYv+nI4iFGVMUMrYszVFky2 zcLX1YgeGQ+HZbukrOUZ+Ne2VwEbCuVpn9lWiyrgxNcug/PYBcVZwah7uwZKrc/Krcn7 8MpGKH/u2rLB9GZUHmsac4WUpUBJRjfZtOe8tJPQEEsuY1kkSDN5hrof9dwG3Tu/8/5V uw== Received: from apblrppmta01.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3s29j5gjse-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jul 2023 11:48:24 +0000 Received: from pps.filterd (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 36PBmLsH008490; Tue, 25 Jul 2023 11:48:21 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTPS id 3s086kv0yu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 25 Jul 2023 11:48:21 +0000 Received: from APBLRPPMTA01.qualcomm.com (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 36PBmKi8008485; Tue, 25 Jul 2023 11:48:20 GMT Received: from hu-sgudaval-hyd.qualcomm.com (hu-vnivarth-hyd.qualcomm.com [10.213.111.166]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTP id 36PBmKii008484; Tue, 25 Jul 2023 11:48:20 +0000 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 3994820) id D6CA13434; Tue, 25 Jul 2023 17:18:19 +0530 (+0530) From: Vijaya Krishna Nivarthi To: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, broonie@kernel.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: quic_msavaliy@quicinc.com, dianders@chromium.org, mka@chromium.org, swboyd@chromium.org, quic_vtanuku@quicinc.com, dan.carpenter@linaro.org, Vijaya Krishna Nivarthi Subject: [PATCH 4/4] spi: spi-qcom-qspi: Add DMA_CHAIN_DONE to ALL_IRQS Date: Tue, 25 Jul 2023 17:18:09 +0530 Message-Id: <1690285689-30233-5-git-send-email-quic_vnivarth@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1690285689-30233-1-git-send-email-quic_vnivarth@quicinc.com> References: <1690285689-30233-1-git-send-email-quic_vnivarth@quicinc.com> X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: znj9Rg9zXRfC7u0xWKRV3DrYy7bjHiQO X-Proofpoint-GUID: znj9Rg9zXRfC7u0xWKRV3DrYy7bjHiQO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-25_06,2023-07-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 adultscore=0 malwarescore=0 mlxlogscore=688 phishscore=0 clxscore=1015 mlxscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307250103 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772395511457536738 X-GMAIL-MSGID: 1772395511457536738 Add latest added DMA_CHAIN_DONE irq to QSPI_ALL_IRQS that encompasses all of the qspi IRQs. Signed-off-by: Vijaya Krishna Nivarthi Reviewed-by: Douglas Anderson --- drivers/spi/spi-qcom-qspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c index d75234d..b56cb16 100644 --- a/drivers/spi/spi-qcom-qspi.c +++ b/drivers/spi/spi-qcom-qspi.c @@ -69,7 +69,7 @@ WR_FIFO_OVERRUN) #define QSPI_ALL_IRQS (QSPI_ERR_IRQS | RESP_FIFO_RDY | \ WR_FIFO_EMPTY | WR_FIFO_FULL | \ - TRANSACTION_DONE) + TRANSACTION_DONE | DMA_CHAIN_DONE) #define PIO_XFER_CTRL 0x0014 #define REQUEST_COUNT_MSK 0xffff