From patchwork Tue Jul 25 11:40:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naresh Solanki X-Patchwork-Id: 125581 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp2432587vqg; Tue, 25 Jul 2023 05:28:22 -0700 (PDT) X-Google-Smtp-Source: APBJJlEsKe1jakK+sh/2YcN2hNyAUi/hiTSak+WGlhPtmBBanMwB89o7VoCAlKLeHQhgdHYaSPLi X-Received: by 2002:a05:6808:14c8:b0:3a4:3837:3d8 with SMTP id f8-20020a05680814c800b003a4383703d8mr15829835oiw.47.1690288101737; Tue, 25 Jul 2023 05:28:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690288101; cv=none; d=google.com; s=arc-20160816; b=yCgwwIBdykVDW31nQ3jOSEOyYig71BS+xjIg+S9B2WrGAnI6fmrYsqYoTVa0ULrRMz fMAwXePymauPJ+hwz8TeZiZZwm7pQqAFNp7J3C/WF7CmnHQ23PAyXf1HRZkERdON1kFh tboBMxHXtYnmIPxETNi8op85OGden73CSYxs4dm3tGvITuiqOkJjqXajY437wcTZDN3T rStQi7xJrkgdV4hDQScfBt55EEzNXeBLUeRv+bhryjkjIXUXwLkE1BC9klEUTNJHYHKf rHi0LIjT+zdIHnoKScit/vW2NM5yBvOw+qkngegCsMomDpLdmKbsqH3DcMHrTaG/hJed zdBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=OCWWBBRJa0PORsLtnTWiKQp9jCoJ7Z5w0rr05I0MhAM=; fh=c41JQuk+nRm2/L5vSP/o/dBL6DeRDfOi96hZy55RLIM=; b=w+gbT0rC0Aswt+hK0d9T9MWW4C3GEucoTKb7nJnf4h82vEtFTxUlPXJj7qOt2WHcoY qSitbGhFNWX51jyLNj7AdsS8uECG0CBCMgtbL5nG33r7N786u11+F0OwD6q2vxMWVAhO yTNNRO/bxGbtc16lstRmyVpPSxh706CLIxQlzf5UEubVz1AE6euKSs06ZEjh4G3pse3a jQvvfHT4E1DTLeQ4D8TJku2O7lRnl0K4MjPe6mg91wKHwiE6cerTsXOeOKjXrmhz/TGQ FkBQv3OFbS0CbJlsLAXqiUGkwk4jfNe811Obc8J+WUYKRnA7vQUpOFiF0PkkxuIW1j+P lThg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=A65PLuZv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k18-20020a6568d2000000b0055fedbf226esi11039156pgt.674.2023.07.25.05.28.08; Tue, 25 Jul 2023 05:28:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=A65PLuZv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235027AbjGYLlE (ORCPT + 99 others); Tue, 25 Jul 2023 07:41:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234967AbjGYLku (ORCPT ); Tue, 25 Jul 2023 07:40:50 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 530CB1FCE for ; Tue, 25 Jul 2023 04:40:35 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-98de21518fbso900289766b.0 for ; Tue, 25 Jul 2023 04:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1690285233; x=1690890033; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OCWWBBRJa0PORsLtnTWiKQp9jCoJ7Z5w0rr05I0MhAM=; b=A65PLuZvDWSYYYDsjc1F+ZXpzZI+oamgjXR5RgxTp9cRoQ9Dne5I+Jh8psRSH78myb A7gqN0mwwpj20DcWesnpkiRR1y/0oDoxMW2YQF6jriAms+leXGFKjnklt/4wJaInyHnD pANYTfJu/uKiRwA8tPws/g+LXN+6so5TwwTgN30x8YjP+2P4iX0Bf5VzI49W5Rey7lcA m+dK9+9YHD//oL23pNz9tydLv7vA2IQtnvHSTwKcSe98dC3zblljuMHuDEsOVINXb535 AI/BqWNjgFBPXrudag3p1/C1VjTcqKp+5yXHOVTkDkb3pRnZ1VohwoBv+4VrR4mJoCB8 HKBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690285233; x=1690890033; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OCWWBBRJa0PORsLtnTWiKQp9jCoJ7Z5w0rr05I0MhAM=; b=gylwpvEV8SjfYj4pdTdRLFA5b0z16Z6bbnIOWqFQH884lmHtkioQ0b/2QtM7YAKEO0 5SYX3C6BLguZu8Viov65Qrxj0FwEGVLwiiKRMLIFrDsUll2fz9mNttkwbpIXpLeMOsxP 2DFZmMLG1MncLx5eYoCTiXjkjKbexamsz7M/uU7Voc3IryT59Nb1ZFbBhL653yMoSMum tiqq3t9fw7KjB3Kw0/GSdB4WRieu0n5/eZnXC/jdwXjJT0PNLShasUZ+O2pYaMP5Q9Jq xHxacssrwXnW3iVWEtjBXJio7uAD9vMc3D5+8YwY9z5T1rkdcrq+iir2pgzAT41yLY82 BTdA== X-Gm-Message-State: ABy/qLZLSnX9jEGuZUDJNk4CcyqO7LDOku+3aCutwLrQxmUs9VajfA8g GtWqzNbvBSK+T7diz6kBQMrT1g== X-Received: by 2002:a17:906:9bdd:b0:99b:4e75:52bb with SMTP id de29-20020a1709069bdd00b0099b4e7552bbmr12428460ejc.69.1690285233475; Tue, 25 Jul 2023 04:40:33 -0700 (PDT) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id d6-20020a1709067f0600b009925cbafeaasm8088206ejr.100.2023.07.25.04.40.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jul 2023 04:40:32 -0700 (PDT) From: Naresh Solanki X-Google-Original-From: Naresh Solanki To: Guenter Roeck , Jean Delvare , krzysztof.kozlowski+dt@linaro.org, Rob Herring , Conor Dooley Cc: linux-hwmon@vger.kernel.org, Patrick Rudolph , Naresh Solanki , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] dt-bindings: hwmon: Add Infineon TDA38640 Date: Tue, 25 Jul 2023 13:40:26 +0200 Message-ID: <20230725114030.1860571-1-Naresh.Solanki@9elements.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772395536327731258 X-GMAIL-MSGID: 1772395536327731258 From: Patrick Rudolph The TDA38640 has a bug in SVID mode and to enable a workaround remove the TDA38640 from trivial-devices and add a complete schema. The schema adds the custom property 'infineon,en-pin-fixed-level' to signal a fixed level on the ENABLE pin and to enable the workaround. When the ENABLE pin is left floating it's internally pulled low. If not specified the driver will continue to use the PMBUS_OPERATION register to enable the regulator. When specified the driver will use the PMBUS_ON_OFF_CONFIG register to enable the regulator. Signed-off-by: Patrick Rudolph Signed-off-by: Naresh Solanki --- .../hwmon/pmbus/infineon,tda38640.yaml | 50 +++++++++++++++++++ .../devicetree/bindings/trivial-devices.yaml | 2 - 2 files changed, 50 insertions(+), 2 deletions(-) create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml base-commit: 55612007f16b5d7b1fb83a7b0f5bb686829db7c7 diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml new file mode 100644 index 000000000000..520112e4e271 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml @@ -0,0 +1,50 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- + +$id: http://devicetree.org/schemas/hwmon/pmbus/infineon,tda38640.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Infineon TDA38640 Synchronous Buck Regulator with SVID and I2C + +description: | + The Infineon TDA38640 is a 40A Single-voltage Synchronous Buck + Regulator with SVID and I2C designed for Industrial use. + + Datasheet: https://www.infineon.com/dgdl/Infineon-TDA38640-0000-DataSheet-v02_04-EN.pdf?fileId=8ac78c8c80027ecd018042f2337f00c9 + +properties: + compatible: + enum: + - infineon,tda38640 + + reg: + maxItems: 1 + + infineon,en-pin-fixed-level: + $ref: /schemas/types.yaml#/definitions/uint32 + description: | + Fixed level of the ENABLE pin. When specified the PMBUS_ON_OFF_CONFIG + register is used to enable the regulator instead of the PMBUS_OPERATION + register to workaround a bug of the tda38640 when operating in SVID-mode. + If the ENABLE pin is left floating the internal pull-down causes a low + level on the pin. + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + tda38640@40 { + compatible = "infineon,tda38640"; + reg = <0x40>; + }; + }; + diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index 6e24c4d25ec3..2b1fbb2a672b 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -151,8 +151,6 @@ properties: - infineon,slb9645tt # Infineon SLB9673 I2C TPM 2.0 - infineon,slb9673 - # Infineon TDA38640 Voltage Regulator - - infineon,tda38640 # Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor - infineon,tlv493d-a1b6 # Infineon Multi-phase Digital VR Controller xdpe11280 From patchwork Tue Jul 25 11:40:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naresh Solanki X-Patchwork-Id: 125541 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp2409286vqg; Tue, 25 Jul 2023 04:47:42 -0700 (PDT) X-Google-Smtp-Source: APBJJlEO1H7ZiceW2KDhwSTWkxmHRFUdLraC13xFZHOlko+DEYDTRPlklm6pbhxpVIfTrNKPZEVA X-Received: by 2002:a05:6512:32d1:b0:4fe:8b5:588a with SMTP id f17-20020a05651232d100b004fe08b5588amr776144lfg.57.1690285662715; Tue, 25 Jul 2023 04:47:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690285662; cv=none; d=google.com; s=arc-20160816; b=irnmWW/k1Qb52syCsbwb//zuDG1vy2JvMsaD6Byzyc03L6HAiSzv9kj8Syvu8mzekb 7LJNQZcssUxS4vNnsHmnKbWp1uNWNf5pYT2bAXjUTXl1bulqugKXBAVZVWEf2WjIEGOB dVgJ1rFkDXafK+sJzmfoQPvDI+YeTG7E9zsxrJbQUHTBhPvZDnOJPDmcgOvKRt8wo0y8 GPJq6ypb7y39TCePCiO89fLz1rqIh0v7zSeWGmrbELjvfUwfGNDehtwN+b+dzWr/vKVM 9xtdVGpXqzdBQNKHhdZXdBtpH7THO4a52+0SrYqhnesHkhosfVUJYD0HJD0EeHajK2Gs g+dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4EsAms/GBsK+1iUec9cOrJls/H2UjnYhAk3txEAwGRk=; fh=/6OmkISz2jasWA5ktD7Ct/RQ5jfIZG0BSS+/WFT7oFk=; b=tPK8Ia2lQEBGZBXWSSdjPL1Fm6nU3o/T8KtduCpIX9pPXZJ/Ry36Y7dK+Fvs8Sd/sR 3pOMmZkpU+Ea7lnU5XymEUxRa0WJN0jaxGE2xogz9AQ9UQXdnJr91pj6UKTRwKkGBhfo 7Y40gICls6x0eaaageSC3oUdvBRbkQAqlo3GdqhWnftj501hCuCnTES8hxmh+nO13/1y JtxMzmZrA9ugr39ptWh/3TnFVWaErs0b506MRtxbgNUHBtBXtEuJWLXpM9KSuxytDs35 XWLAEV81vTbp/IaFOUSG51XDu7ZUUp8Pcub2xBr0baQCMgUc11Rzowx1yTDGmif3GKHC bUnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=cYToPYjk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c19-20020a170906341300b0098dfd35276esi7962749ejb.1055.2023.07.25.04.47.18; Tue, 25 Jul 2023 04:47:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=cYToPYjk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235018AbjGYLlC (ORCPT + 99 others); Tue, 25 Jul 2023 07:41:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235014AbjGYLku (ORCPT ); Tue, 25 Jul 2023 07:40:50 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 329DC1FD0 for ; Tue, 25 Jul 2023 04:40:36 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-98dfb3f9af6so923097666b.2 for ; Tue, 25 Jul 2023 04:40:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1690285234; x=1690890034; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4EsAms/GBsK+1iUec9cOrJls/H2UjnYhAk3txEAwGRk=; b=cYToPYjk35PirQBwQx8NE3OVoFdb2pztaQ5bfC/OWBAdEiyHG2ot3SaseXH3+8zh/s zeu39mYeFkkyabzPpyRttmL4hapAwNo8OEKlRmb1geJTTieV2esQtH7w2lEp9cEzvCHR ir1XdGJCd7UWDP8mlJlFMczth2qG7Ibif4ZSWQ56oMuoUVujyOp7UxTeLsgwDHorGsyN gWsTLFNDQAjeLSjqyxooiHyMRFlpdReL3dUJAVTHnZoDotCXA6Ht5mBMJINufi+R0hr/ i0qyhLOkNuYkVEDRM9yEpHS8+i7mPFzzYB9cSBaqOoeSAPEzcjAtfgjhI1x1EICLzAAf DmJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690285234; x=1690890034; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4EsAms/GBsK+1iUec9cOrJls/H2UjnYhAk3txEAwGRk=; b=gGWpdmP5/E+c8qRacUwPNwCBDLeq1ALBPG6/tL1Wd9e5yYBe1b4tpCWGrdVpQvusnv BK+qn2a9HYl9FzmzyYn9cMWEgWeWiGfEJcMsiOrfF6/OKiUM4ArFXTGVxpIh+oZPYplQ 3SRYcE+Drfw0xMemkCHZQdKIYbgsOeqylWRpKNPSHRKoiJ+FI/I9QVntHsnzEFhzIOAH yl0U3nqE5bulNcCB9g5rCA9+obLvIoxcjRRtQQxyX07voesRCZehmCEeju+XqAlClCrB 1sTX2Yv0IvhB3xqqDVkiCHyDvV5swKTP3t8+TTMli+JDgRVbda36E32ldXfJ1PkOe3Aw mXnQ== X-Gm-Message-State: ABy/qLY92KH3tJjkSNMnztBid+I7r24c+IJF/gXtEFFqVBpDWDg8lemR Slu+Nn8UWQQFEv0Z1h2PSHwCXg== X-Received: by 2002:a17:906:318d:b0:99b:b2fb:27b3 with SMTP id 13-20020a170906318d00b0099bb2fb27b3mr1323318ejy.41.1690285234773; Tue, 25 Jul 2023 04:40:34 -0700 (PDT) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id d6-20020a1709067f0600b009925cbafeaasm8088206ejr.100.2023.07.25.04.40.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jul 2023 04:40:34 -0700 (PDT) From: Naresh Solanki X-Google-Original-From: Naresh Solanki To: Guenter Roeck , Jean Delvare , krzysztof.kozlowski+dt@linaro.org Cc: linux-hwmon@vger.kernel.org, Patrick Rudolph , Naresh Solanki , linux-kernel@vger.kernel.org Subject: [PATCH 2/3] hwmon: (pmbus) Add ON_OFF_CONFIG register bits Date: Tue, 25 Jul 2023 13:40:27 +0200 Message-ID: <20230725114030.1860571-2-Naresh.Solanki@9elements.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230725114030.1860571-1-Naresh.Solanki@9elements.com> References: <20230725114030.1860571-1-Naresh.Solanki@9elements.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772392978588093079 X-GMAIL-MSGID: 1772392978588093079 From: Patrick Rudolph Add bits found in the ON_OFF_CONFIG register. Signed-off-by: Patrick Rudolph Signed-off-by: Naresh Solanki --- drivers/hwmon/pmbus/pmbus.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/hwmon/pmbus/pmbus.h b/drivers/hwmon/pmbus/pmbus.h index b0832a4c690d..7a28bac7f171 100644 --- a/drivers/hwmon/pmbus/pmbus.h +++ b/drivers/hwmon/pmbus/pmbus.h @@ -243,6 +243,15 @@ enum pmbus_regs { */ #define PB_OPERATION_CONTROL_ON BIT(7) +/* + * ON_OFF_CONFIG + */ +#define PB_ON_OFF_CONFIG_POWERUP_CONTROL BIT(4) +#define PB_ON_OFF_CONFIG_OPERATION_REQ BIT(3) +#define PB_ON_OFF_CONFIG_EN_PIN_REQ BIT(2) +#define PB_ON_OFF_CONFIG_POLARITY_HIGH BIT(1) +#define PB_ON_OFF_CONFIG_TURN_OFF_FAST BIT(0) + /* * WRITE_PROTECT */ From patchwork Tue Jul 25 11:40:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naresh Solanki X-Patchwork-Id: 125582 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp2432762vqg; Tue, 25 Jul 2023 05:28:44 -0700 (PDT) X-Google-Smtp-Source: APBJJlG2wgyqZxyRVGlXdd/X1w+Il9kdqONKhE3RBRYgToaQnnOoJluyRyNR2cc51HYTo4fhdMYZ X-Received: by 2002:a05:6358:89d:b0:135:51a5:4da0 with SMTP id m29-20020a056358089d00b0013551a54da0mr8807786rwj.1.1690288123753; Tue, 25 Jul 2023 05:28:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690288123; cv=none; d=google.com; s=arc-20160816; b=ATljmBNsBDYFcZ6u1b52xV5kxXjIwyQocB784pHeT4whOZUqfydn59aMsLtzOoJbMM fLAzWXTooZ/J9AXey2wvQlBAgExq9uTucgGyk6+kcg8YKwoiydmjiH2mD0l3xfcBQGhS 6JWIWPqBUMFj7MHl3PvlLPDrf5a01cafOfMJy2MTJI+PKvSFOiZgQ8BFmiwiexRn0aGN 7ZraRbUD2CdqhoIbfTUUQY52XGZXq9P02X2+ydXo53LmmqJYOznmH8TeIwUfN0KBX9ov zo8ly7YH9OjPkr/ZoFyeoHC+j3HxSZju67RxCYaVCU+POB5GvxrjF+XgK58h+ynR49k8 Ofcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AhNRFqKFycYKruMGsOn/+moIjC44ZjyIo8XOGyCOCbo=; fh=/6OmkISz2jasWA5ktD7Ct/RQ5jfIZG0BSS+/WFT7oFk=; b=VjNYA03V9wX55sWNd4LfWFjauaBUZ6O6aXtmdbTPY6jjfF1469DX7TjMLHaY46019e 8kTvipI4AcFtF1kWejAWvtW+mHTv0X/gi+YPu1wQywZHnO4QKVKLOKUNqtuJpoG1aK1h Gs2xpR2QmIlTwROfnqLdJ0BBmRgrnJz/t/sdYBw9HjVk/x2YAx4F8+cP70YiOEJp1hnT PW34E+8ebbSVTeBYEmuWWf/wGcd2N5DPopueQmezBVmVZCBbsXJGBChsrX0lblju+VF+ uA50oqTX2c7go2fZ/RdCZGus6MTPrJmDU+UVAyQNr1v/BdUJ93Qyb2sWo0g6caN9KTNF Agmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=W2qr9bro; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m68-20020a633f47000000b0056387b40586si9110118pga.422.2023.07.25.05.28.30; Tue, 25 Jul 2023 05:28:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=W2qr9bro; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235032AbjGYLlG (ORCPT + 99 others); Tue, 25 Jul 2023 07:41:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235024AbjGYLkv (ORCPT ); Tue, 25 Jul 2023 07:40:51 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8EBB1FDE for ; Tue, 25 Jul 2023 04:40:37 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-993a37b79e2so863768266b.1 for ; Tue, 25 Jul 2023 04:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1690285236; x=1690890036; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AhNRFqKFycYKruMGsOn/+moIjC44ZjyIo8XOGyCOCbo=; b=W2qr9brom56oLdtsCeuu9GTb8LiKF8Rmiyb6kPM5pb4gsnB1NMl/kBvG4z0HQiFyWi wcrClJsqLQTy8wIFPOp5VbuInGicV4S5RseU2Gb94+uX+6v2Zt0555n2P9WSO8/IaElb cbqPHTwMNEkk9OmFPNJwtTfhmm7m2lLJSwfTRkE0J8MoXPAe3skVCjhmoqncJpmBl1Lr fL05Q/A3IodQggCnh72C/zDDHPJWwH4sI2EvbTC7MabLDtmdffdAkkhf3SZt6zDx8dnV hvYP2JxodPEFQawW+88ZveccEvZ2aVX6Y1Y6Klt+QWyvKfePRwlS9LiG9fS0QI6yI/ri 6PKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690285236; x=1690890036; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AhNRFqKFycYKruMGsOn/+moIjC44ZjyIo8XOGyCOCbo=; b=S1cdOqg2vFlcYMb8vwfBAUepoibX71o9qAxko0XfN65siwP8J1PHqTePAobuZkGgvf jvrWQXdm64AGsVe10EqRabEDUqLJ/FMFMlI358+hs1b8TKs2a9MLZn+jDEkIAKksYXkF 602+enigwVGAKFZCyNvMb8A44VAam7iKlLMNd7EHYjDXj6g/o1XSJt45LW21E9vOaqwS GbGgvmlJYE9BzhxxULtoHOyv6Rhf6X7r0uwtnn5k247UoMhMft+pJ2+lKplBXBZk45i8 d5MRuU8EKgNWyRw535XDhgqvDDs6T0f2r+Tw64B3byrXjDtiVjivwsGF+gvB38JI8fko YRJg== X-Gm-Message-State: ABy/qLbH81iKe4cTPADs8ICm0DHU1dCc+Z7VgWhZXRXEBkfi9qreyX9/ L0QH3CyfUa8I6vgTb3UDSwoT/K5ZW5fJAHmAIVwQs/gE X-Received: by 2002:a17:906:209e:b0:993:d617:bdc2 with SMTP id 30-20020a170906209e00b00993d617bdc2mr12718738ejq.75.1690285236112; Tue, 25 Jul 2023 04:40:36 -0700 (PDT) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id d6-20020a1709067f0600b009925cbafeaasm8088206ejr.100.2023.07.25.04.40.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jul 2023 04:40:35 -0700 (PDT) From: Naresh Solanki X-Google-Original-From: Naresh Solanki To: Guenter Roeck , Jean Delvare , krzysztof.kozlowski+dt@linaro.org Cc: linux-hwmon@vger.kernel.org, Patrick Rudolph , Naresh Solanki , linux-kernel@vger.kernel.org Subject: [PATCH 3/3] hwmon: (pmbus/tda38640) Add workaround for bug in SVID mode Date: Tue, 25 Jul 2023 13:40:28 +0200 Message-ID: <20230725114030.1860571-3-Naresh.Solanki@9elements.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230725114030.1860571-1-Naresh.Solanki@9elements.com> References: <20230725114030.1860571-1-Naresh.Solanki@9elements.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772395559298876260 X-GMAIL-MSGID: 1772395559298876260 From: Patrick Rudolph The TDA38640 supports two operating modes to set the output voltage: - PMBUS - SVID Due to an undocumented bug the regulator cannot be enabled using BIT7 of OPERATION(01h) register when in SVID mode. It works when in PMBUS mode. In SVID mode the regulator only cares about the ENABLE pin. Add a workaround that needs the ENABLE pin to be left floating or tied to a fixed level. The DT must contain the newly introduced property 'infineon,en-pin-fixed-level' to enable this workaround. The workaround will map the PB_OPERATION_CONTROL_ON bit to the PB_ON_OFF_CONFIG_EN_PIN_REQ bit of the ON_OFF_CONFIG register. In combination with the fixed level on the ENABLE pin the regulator can be controlled as expected. Signed-off-by: Patrick Rudolph Signed-off-by: Naresh Solanki --- drivers/hwmon/pmbus/tda38640.c | 95 +++++++++++++++++++++++++++++++++- 1 file changed, 93 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/pmbus/tda38640.c b/drivers/hwmon/pmbus/tda38640.c index 450b0273fb59..9d3b89d9845c 100644 --- a/drivers/hwmon/pmbus/tda38640.c +++ b/drivers/hwmon/pmbus/tda38640.c @@ -18,6 +18,72 @@ static const struct regulator_desc __maybe_unused tda38640_reg_desc[] = { PMBUS_REGULATOR("vout", 0), }; +struct tda38640_data { + struct pmbus_driver_info info; + u32 en_pin_lvl; +}; + +#define to_tda38640_data(x) container_of(x, struct tda38640_data, info) + +/* + * Map PB_ON_OFF_CONFIG_POLARITY_HIGH to PB_OPERATION_CONTROL_ON. + */ +static int tda38640_read_byte_data(struct i2c_client *client, int page, int reg) +{ + const struct pmbus_driver_info *info = pmbus_get_driver_info(client); + struct tda38640_data *data = to_tda38640_data(info); + int ret, on_off_config, enabled; + + if (reg != PMBUS_OPERATION) + return -ENODATA; + + ret = pmbus_read_byte_data(client, page, reg); + if (ret < 0) + return ret; + + on_off_config = pmbus_read_byte_data(client, page, + PMBUS_ON_OFF_CONFIG); + if (on_off_config < 0) + return on_off_config; + + enabled = !!(on_off_config & PB_ON_OFF_CONFIG_POLARITY_HIGH); + + enabled ^= data->en_pin_lvl; + if (enabled) + ret &= ~PB_OPERATION_CONTROL_ON; + else + ret |= PB_OPERATION_CONTROL_ON; + + return ret; +} + +/* + * Map PB_OPERATION_CONTROL_ON to PB_ON_OFF_CONFIG_POLARITY_HIGH. + */ +static int tda38640_write_byte_data(struct i2c_client *client, int page, + int reg, u8 byte) +{ + const struct pmbus_driver_info *info = pmbus_get_driver_info(client); + struct tda38640_data *data = to_tda38640_data(info); + int enable, ret; + + if (reg != PMBUS_OPERATION) + return -ENODATA; + + enable = !!(byte & PB_OPERATION_CONTROL_ON); + + byte &= ~PB_OPERATION_CONTROL_ON; + ret = pmbus_write_byte_data(client, page, reg, byte); + if (ret < 0) + return ret; + + enable ^= data->en_pin_lvl; + + return pmbus_update_byte_data(client, page, PMBUS_ON_OFF_CONFIG, + PB_ON_OFF_CONFIG_POLARITY_HIGH, + enable ? 0 : PB_ON_OFF_CONFIG_POLARITY_HIGH); +} + static struct pmbus_driver_info tda38640_info = { .pages = 1, .format[PSC_VOLTAGE_IN] = linear, @@ -26,7 +92,6 @@ static struct pmbus_driver_info tda38640_info = { .format[PSC_CURRENT_IN] = linear, .format[PSC_POWER] = linear, .format[PSC_TEMPERATURE] = linear, - .func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_STATUS_INPUT | PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP | PMBUS_HAVE_IIN @@ -41,7 +106,33 @@ static struct pmbus_driver_info tda38640_info = { static int tda38640_probe(struct i2c_client *client) { - return pmbus_do_probe(client, &tda38640_info); + struct device *dev = &client->dev; + struct device_node *np = dev_of_node(dev); + struct tda38640_data *data; + + data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); + if (!data) + return -ENOMEM; + memcpy(&data->info, &tda38640_info, sizeof(tda38640_info)); + + if (!CONFIG_SENSORS_TDA38640_REGULATOR || !np || + of_property_read_u32(np, "infineon,en-pin-fixed-level", &data->en_pin_lvl)) + return pmbus_do_probe(client, &data->info); + + /* + * Apply ON_OFF_CONFIG workaround as enabling the regulator using the + * OPERATION register doesn't work in SVID mode. + */ + data->info.read_byte_data = tda38640_read_byte_data; + data->info.write_byte_data = tda38640_write_byte_data; + /* + * One should configure PMBUS_ON_OFF_CONFIG here, but + * PB_ON_OFF_CONFIG_POWERUP_CONTROL, PB_ON_OFF_CONFIG_EN_PIN_REQ and + * PB_ON_OFF_CONFIG_EN_PIN_REQ are ignored by the device. + * Only PB_ON_OFF_CONFIG_POLARITY_HIGH has an effect. + */ + + return pmbus_do_probe(client, &data->info); } static const struct i2c_device_id tda38640_id[] = {