From patchwork Mon Jul 24 13:59:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 125006 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp1818122vqg; Mon, 24 Jul 2023 07:00:24 -0700 (PDT) X-Google-Smtp-Source: APBJJlFEr4loSM/0uFKiC+l1zxH/KL45X4a4yRUqgOmDKu1w6AZ4gICM3wDSagKQHcIXXRwFW/zz X-Received: by 2002:a05:6512:12ca:b0:4fd:fac4:2016 with SMTP id p10-20020a05651212ca00b004fdfac42016mr1339231lfg.31.1690207223666; Mon, 24 Jul 2023 07:00:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690207223; cv=none; d=google.com; s=arc-20160816; b=BBXSGdhNHG8ic2vlniCaBQL8hWqZlGv+4UPyd731yR2fxj6E3vA0nwNTRWMYMMKkq3 bjQ/2EYFRwdYvNEHNdlQCpIq67RtEb8eu//XIUSudFEY6Q3Jl9uGsQQleqiUMHoe7Pj/ ni32cuo9HrCq66CBVZG0DJ9CxGd9h6UqWlPp+AME8LGIzdXwHk/DQsVk+iGfeoO3NmVp 696+m7H2TWw3EioMleuZXXpn8fH4KKrP9a+fvGNcRoA03Y4Wm9aEFlBoqYDiocGS5StN DW1awNSKQzAdOJxSrqxufGGbRw72Nh3iAgb+kUbdawHRVFQyDS1yZV4dp5lWFSxL76r8 7rUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:to :content-language:user-agent:mime-version:date:message-id :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=kmddzoIgl8uUJmdUqzMdqTI4ROCB+sNxfO/xpcrVlTQ=; fh=M5qwlmhoC9OW65qhxcbZ1oi6Och98fkiOGD1Iw/ypWA=; b=IE1QHaWLDA3EiTgLxNkF91kBCrZcROtTCfns0fnz46McRTue63fNnio+le2FJzOqQM Vih34T3iNHxD5RJBL31EyX4k2FYOruTeGsvKGFJJdoXoRB4SB97logDyYX3TVpoyc9T/ wZ6PeDBfTHDaXLVksLDpM5U/q45kcSCysWBBJ0leMV0f+JZbYi23fsZlOK81RJswjqAH rRyCBkplCyUuNQ3u5PP5w0Aygna3I7GxhceJPMOcxuv24qVaMYjpKaTVzGfsH9Oq5Aqd V+wWRi3prtotiN0aJguVBTZogv1UaodeVeDkIievaMiPjZAtwE3ItAA1tdUQV5IkuuSm SIDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=eaZEA4Sb; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id h2-20020a50ed82000000b00522294d0aa0si2255709edr.590.2023.07.24.07.00.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jul 2023 07:00:23 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=eaZEA4Sb; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EB9113857BA4 for ; Mon, 24 Jul 2023 14:00:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EB9113857BA4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1690207221; bh=kmddzoIgl8uUJmdUqzMdqTI4ROCB+sNxfO/xpcrVlTQ=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=eaZEA4Sbw+LKgJd/yq/XTiVfSHniVRzWonE1HXVd3I1SSHhDdCEFhh3s3Mgx5HKET xV/coXpGCLzp6Szl4ovg0ycXoOcE/MbsSYzlqUzMDyCYtiK7wY6Kdb+h4T8oj64EJd mQNHwBgdPrm6/ixDNGnAPFgxcLD+3rZ96IMa37lM= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id 9D9683858C5E for ; Mon, 24 Jul 2023 13:59:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9D9683858C5E Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-666e6ecb52dso2365011b3a.2 for ; Mon, 24 Jul 2023 06:59:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690207170; x=1690811970; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kmddzoIgl8uUJmdUqzMdqTI4ROCB+sNxfO/xpcrVlTQ=; b=gv1zMDuzHyyA9jJSpNDxAdy23zxE+50ly2Hxra6e0tZHbDm6xzPlgZrMVsHGHY+Px3 QlQYtEQVh7KHlGcIdu223UJswyraOc42lXs7i/tCnEyVI8SE7u0l5iBdkpOl+73/yX0r KQJbQ2y98irl37GNsQSMbsFgMHt8VYglgVcSbPJY/87OW6MtlN+i9PHTTZ8mk56SzHy1 /xi/MT8Va4p2j6YzSuH3rNIBflhoAQyAIZXmc/CuC+Zj9HspXeIFVeQ+NJ3WhGiqBnzS WVcRY2CWiNRlkeP1Y4OXDXPfZuc+AD4UG06iux3aelBBMadLnW0WzNtUZc05K9WWtIe2 LHng== X-Gm-Message-State: ABy/qLZxzQprOlfnhDzzCnKHzXqPCHLhVPf05BnfotTIEYAIcMU+KJvH NoLWMQ5ub/rtR7PufKZuOcrDt4WjiQJT/Q== X-Received: by 2002:a05:6a21:7890:b0:132:cb97:83e2 with SMTP id bf16-20020a056a21789000b00132cb9783e2mr8271678pzc.50.1690207170149; Mon, 24 Jul 2023 06:59:30 -0700 (PDT) Received: from [172.31.1.103] ([172.56.168.196]) by smtp.gmail.com with ESMTPSA id g20-20020a62e314000000b00682b2044149sm7729382pfh.4.2023.07.24.06.59.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jul 2023 06:59:29 -0700 (PDT) Message-ID: Date: Mon, 24 Jul 2023 07:59:27 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: "gcc-patches@gcc.gnu.org" Subject: [committed][RISC-V] Fix minor issues in diagnostic message X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jeff Law via Gcc-patches From: Jeff Law Reply-To: Jeff Law Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772310729831174387 X-GMAIL-MSGID: 1772310729831174387 This fixes two minor issues with the recently added warning about too large VLEN in the RISC-V backend. These prevent the RISC-V port from bootstrapping as both Andreas and I have found. Specifically we'll get warnings for the use of '>' in the recently added message as well as using "can not" vs "cannot". While these warnings may seem annoying, they're in place to make it easier for the translators. This patch fixes the message in the fairly obvious way. Spells out the greater than and uses cannot. There's a similar issue in another recently added diagnostic that I'll push momentarily. Committed to the trunk, Jeff commit aa1e2d543869a07580f9b2112f2d7367f83a6753 Author: Jeff Law Date: Mon Jul 24 07:56:36 2023 -0600 [committed][RISC-V] Fix minor issues in diagnostic message This fixes two minor issues with the recently adding warning about too large VLEN in the RISC-V backend. These prevent the RISC-V port from bootstrapping as both Andreas and I have found. Specifically we'll get warnings for the use of '>' in the recently added message as well as using "can not" vs "cannot". While these warnings may seem annoying, they're in place to make it easier for the translators. This patch fixes the message in the fairly obvious way. Spells out the greater than and uses cannot. There's a similar issue in another recently added diagnostic that I'll push momentarily. gcc/ * config/riscv/riscv.cc (riscv_option_override): Spell out greater than and use cannot in diagnostic string. diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc index 332fa720f01..941ea25e1f2 100644 --- a/gcc/config/riscv/riscv.cc +++ b/gcc/config/riscv/riscv.cc @@ -6713,7 +6713,7 @@ riscv_option_override (void) We can only allow TARGET_MIN_VLEN * 8 (LMUL) < 65535. */ if (TARGET_MIN_VLEN > 4096) sorry ( - "Current RISC-V GCC can not support VLEN > 4096bit for 'V' Extension"); + "Current RISC-V GCC cannot support VLEN greater than 4096bit for 'V' Extension"); /* Convert -march to a chunks count. */ riscv_vector_chunks = riscv_convert_vector_bits ();