From patchwork Sat Jul 22 12:17:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 124311 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp804942vqg; Sat, 22 Jul 2023 06:29:44 -0700 (PDT) X-Google-Smtp-Source: APBJJlGqnV9c3NAU2F6/FaFomAelwCcqhUDgHajfK7kHXBo0aFtaYYLj25+/QbP1sQHfVZhEhT7I X-Received: by 2002:a17:902:a609:b0:1b9:de75:d5bb with SMTP id u9-20020a170902a60900b001b9de75d5bbmr5205602plq.7.1690032584211; Sat, 22 Jul 2023 06:29:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690032584; cv=none; d=google.com; s=arc-20160816; b=RxdEdz3QbTlTEw+9z/AVxtp39qtOIxxjQsMYRTqv8xIK4TGP1zgsWrCKXL+r3fWA4H EJni2ODgOu+JxCsTXoHlopjx66hosoOURZ4NOfAeo3SIl89Y++oPatArRqd/SMBmBqxA x1+Z9n18ZbT2PtOpm7YwLb9GVxlvVwUF4YdVaS6Z5EfaebeJCdWILM9IHKKYzd3IGnBq 8wKAYfTw5Awxw9ZwYpnzEdQr8NnN8a7jXLNpVPBQyX/9fs3ocniGkJ/DvDl0eeRh10k6 g9++65FK8xwzSgOI9llYUxZeD2IoTgFg9r7pd7nAeGgfc5yD13i8g/kk6kza8j7L5u4X nZgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ILLgpy5dIr0Z3/YUCdwsp2YqhUyEPi8q24EqLCuiREc=; fh=0wF5EaWROVR5L/uLEzKU7BJpmGtNNKvZ4t5gNBHtG7M=; b=Kztcnuiam8HGgSx2359eDU6VX9RxPTzWIrjCP+McOENzIL+q+5PB5y9ImMzNMOvZVv OBIDxs2Yzw1zca26d7JpoawPS1jhMwZFpLFBeVuD2KDK7G8RT9W5ysieNeDYrVItCa7E xakHKLIetyOp/tAlMU0u0QyAAxHbwAlsXPcY7aZqnhL2ilTNm8vs4ABesXTbU0mrxIxm qGdeHzHTHZRdbrCqIj5pvKNesKyVZjNhSs2U25gr7+hmAquX4fHoIm8ko2Cx7PIYyqbQ YpK932/yUijPWI1XZ/SvMYQ802aEwUPM2ksAnpr/VLYFlDObhXQRG22p7u7dHKiNHYG8 ez/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=v9KVvLrd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x11-20020a170902a38b00b001bb809b68a8si1440776pla.229.2023.07.22.06.29.22; Sat, 22 Jul 2023 06:29:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=v9KVvLrd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230323AbjGVMR1 (ORCPT + 99 others); Sat, 22 Jul 2023 08:17:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230260AbjGVMRZ (ORCPT ); Sat, 22 Jul 2023 08:17:25 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFBA4E5C for ; Sat, 22 Jul 2023 05:17:23 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-3142a9ffa89so2469099f8f.0 for ; Sat, 22 Jul 2023 05:17:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690028242; x=1690633042; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ILLgpy5dIr0Z3/YUCdwsp2YqhUyEPi8q24EqLCuiREc=; b=v9KVvLrdQL96VPifVk0GGKQlLpFKHR9J8RApAIbIJ0DkoBLZKsc8KD851rmi0ncTw0 2a7ogbPTqkHFKVZLLkgXS5RTdvz8p3ff0F0c5TGNoSr3GzFTPfycZfFJPWwcczH4OhY9 zze7WUy0AVHlf92hIirYOaqKHKRJIywPeZV5YgnGyqE6YTfXkDUglOqzDBljmr+4aTd0 Baq18q7Gl5cHpZhoHv4J2j2Dpu5q0jBkb2u4UfBVkrrB2H5AcfR8vZSZezHne306xNQs uA/L118caSpP95/TWpyL2RLL7bmkCwjHCjX+lbYQuJfPD4veIVK+COXAb/3CNa4KM8n4 ftmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690028242; x=1690633042; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ILLgpy5dIr0Z3/YUCdwsp2YqhUyEPi8q24EqLCuiREc=; b=c0AQk/qIje6lbvW3xUlIjtRdZI1XhVNIksk8xgOi+XYg4K3GIo7ejK2yhj845vXBmG o0M5m/qR3zLIYeVPIn9MYIBJBrwrjWB6rFiTWIRvetijwkE0aE63/KEb9h2TH93G/pJj bxWcKFy/DcD3l9ErHdrf8z0HffNrK2UOsyeHFKMKYSWQdvjsO2FLWWO+/M38exHbwPZZ AD+7CHd7HYw+78rjgFrok1qb7XCYO9sUD4fDtWfQE+ZWGSuCyDntqoEY4vrhefZ/IJd+ I96BJVCXgd8BRRve1i4Vvg9BalvwoWCvtbk8AUZSSpyLOTWN2VhuRimjr/ChXpKyzAqs 0E/g== X-Gm-Message-State: ABy/qLb+72YmFNPX4UpOmFNJkWGPPRkZXnKUvAXRbPXAOTT3MyV9a114 6m+ReLDtmsKv9Q7gSoScFs9toxQEiYYgCowNzJI= X-Received: by 2002:adf:eccc:0:b0:313:dee2:e052 with SMTP id s12-20020adfeccc000000b00313dee2e052mr3917087wro.26.1690028242400; Sat, 22 Jul 2023 05:17:22 -0700 (PDT) Received: from krzk-bin.. ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id h18-20020a5d5492000000b003142e438e8csm6779086wrv.26.2023.07.22.05.17.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Jul 2023 05:17:21 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 1/3] ARM: dts: samsung: exynos4x12: replace duplicate pmu node with phandle Date: Sat, 22 Jul 2023 14:17:17 +0200 Message-Id: <20230722121719.150094-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772123906035143007 X-GMAIL-MSGID: 1772127607346663417 Devicetree for the FIMC IS camera included duplicated PMU node as its child. This is not a correct representation of the hardware. Mapping the PMU (Power Management Unit) IO memory should be via syscon-like phandle (samsung,pmu-syscon, already used for other drivers), not by duplicating "pmu" Devicetree node inside the FIMC IS. The change is not compatible with older Linux kernel, which does not parse samsung,pmu-syscon property. Signed-off-by: Krzysztof Kozlowski --- Changes in v2: 1. None Depends on: https://lore.kernel.org/linux-devicetree/20230722115441.139628-1-krzysztof.kozlowski@linaro.org/T/#t --- arch/arm/boot/dts/samsung/exynos4x12.dtsi | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/samsung/exynos4x12.dtsi b/arch/arm/boot/dts/samsung/exynos4x12.dtsi index 84c1db221c98..4524c1e6bb2f 100644 --- a/arch/arm/boot/dts/samsung/exynos4x12.dtsi +++ b/arch/arm/boot/dts/samsung/exynos4x12.dtsi @@ -516,15 +516,12 @@ fimc_is: fimc-is@12000000 { iommus = <&sysmmu_fimc_isp>, <&sysmmu_fimc_drc>, <&sysmmu_fimc_fd>, <&sysmmu_fimc_mcuctl>; iommu-names = "isp", "drc", "fd", "mcuctl"; + samsung,pmu-syscon = <&pmu_system_controller>; #address-cells = <1>; #size-cells = <1>; ranges; status = "disabled"; - pmu@10020000 { - reg = <0x10020000 0x3000>; - }; - i2c1_isp: i2c-isp@12140000 { compatible = "samsung,exynos4212-i2c-isp"; reg = <0x12140000 0x100>; From patchwork Sat Jul 22 12:17:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 124321 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp822596vqg; Sat, 22 Jul 2023 07:07:11 -0700 (PDT) X-Google-Smtp-Source: APBJJlHVe+sJmBsNZAIg/HnskipolSi+TjP+gYAHhvk/6fOFYaRZoPKE/oeuDnGLS3J6ARROzoMc X-Received: by 2002:a17:902:da8f:b0:1b9:e8e4:620e with SMTP id j15-20020a170902da8f00b001b9e8e4620emr3613631plx.47.1690034831149; Sat, 22 Jul 2023 07:07:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690034831; cv=none; d=google.com; s=arc-20160816; b=q0GgALB1V1wfeDIklXR+NDT8dDcUcaVEcWOkqO+7M/kXmxpXKWHYNnpXpQUFMZS5Kr FsKKwiGmSudOv8BnuYiM9ynI4Cu4EVSpMpbXz9xypFSXRWWg8plgiseRsYue7/Mxo5Es SPlhLSXMDnlDQga5bWYpjIqhiIKiYzvVjYauqsyDRNCuqDJsX8T8mmTbm+fPwpEWC4z2 kPez3BmXhzqMD2j1C30fuM7Zpt4PoO+EdxxAo+CKAi2lYMFmG4G0JNqn4yv8I0y63Cei 0+bzVmzslnU38QqMbUtux+aZjqV8SqzcvEBO9TCeYyTDCNryvReyQ54bNCe0nX9ETMSb T2ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fzCCL/QHPaw4sOON9/9YW1a3AVPo9H/0EcWqe0BqQA4=; fh=0wF5EaWROVR5L/uLEzKU7BJpmGtNNKvZ4t5gNBHtG7M=; b=IxQBghrDztefNV4KD+1vH4MzpokDU6zFGEBGNYR2MnH28vUV6otcT8HyXlK014UFId 2hqr5lDQiPLH7QRNsNqIdkDutCtGPj91atber8uDZIa2gkyJu6hADsVFGfyjAKWE1Mb2 jSSDT9UX5vZfpQHM3arT1DwTOQdozLUlmzbklwiPntzqknRZlajehGaL2NZuQTlPqqmr lCwSfVFzwrZgtLD6Y3EdQMkbWT8eRpLLCwcHeWXxoLvgEX4r9HuqkgcQPtlfzrmmM7vb rxPl7U1NUqIUa8NgMBWXMO0KDP59TLqZoVCrAePmITtNJ0+djPyxehNu8ykXIK/WGOcZ Q/vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KcjAsxLD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q18-20020a170902e31200b001b828f8dd13si4854728plc.340.2023.07.22.07.06.58; Sat, 22 Jul 2023 07:07:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KcjAsxLD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230353AbjGVMRa (ORCPT + 99 others); Sat, 22 Jul 2023 08:17:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230337AbjGVMR2 (ORCPT ); Sat, 22 Jul 2023 08:17:28 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B1EFE7D for ; Sat, 22 Jul 2023 05:17:25 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-31297125334so1706707f8f.0 for ; Sat, 22 Jul 2023 05:17:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690028244; x=1690633044; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fzCCL/QHPaw4sOON9/9YW1a3AVPo9H/0EcWqe0BqQA4=; b=KcjAsxLDRfcWfgJAPvAYKOKLTmabjVf+76yuJ/5PFqX/RyyjyK25AkOObuZXuf70ZX E0AH66ROiDsl6quRTmowUWN2jnV2f0jdnne7uDJhFz93/MONZkj1kWbyhPgiGYj6k2K7 i7xQ7KnbmcWg/G5Uf5+fsXFSfJ8IRg5iLfamhcg0kWIyUagVCcc6MCqKhMS5in9J5Jdv b3zTmr9hphV9r2JeljT6GQzC6KN5gmZ083blbEKLGq0hLZJGRjzj9gDTQwEIWfwmfnfh nfhB2iGVxuDy4/BYe+EArDVHrN8hoRP0315lqQEYaJsl0sD9NrKMk5lgUJ9T/rQ4M2Ca xRAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690028244; x=1690633044; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fzCCL/QHPaw4sOON9/9YW1a3AVPo9H/0EcWqe0BqQA4=; b=RLxo3ANbCF32NP5Z8nkKxFIRvUQVqcxIo2DWTuu8KK3by3JaJ/NHcGxKJvGZNcVCkQ bYCn3ZPV6/0f6A6betN+hpFqwgiPXR9YRot0ubxTnxfnzs3aIpHHvRk9C8MuPVRIXxKp pmyj0V+3VNIAqRYWsrKve6i3z3l36KDvYwqpeX+Xf7M9ZNfyizV9wD5dHRSmdKPodxFd 8ZsZkiggvN7dHhYH6Gj4I1zAbQUGMT1GNtd6BSkn1gVBtcGa1IutJXPby2pHcyk4gHeZ USQsjiCvNDQ2kFNKp3nUeQBsMxS/ugChpZ5dEMirgCa8DLyOOviRL98NJyGKlx8JLe2A vnFA== X-Gm-Message-State: ABy/qLZ07ju6HBwD+yBjn5jQXcokVaGfGUJ5fUYTH/uhoE3eGUyVMkTH nOzxCsHcBfN4l9AzS3yTDBiBiA== X-Received: by 2002:adf:eb03:0:b0:314:1228:c4c1 with SMTP id s3-20020adfeb03000000b003141228c4c1mr3805261wrn.23.1690028244127; Sat, 22 Jul 2023 05:17:24 -0700 (PDT) Received: from krzk-bin.. ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id h18-20020a5d5492000000b003142e438e8csm6779086wrv.26.2023.07.22.05.17.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Jul 2023 05:17:23 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 2/3] ARM: dts: samsung: exynos4: fix camera unit addresses/ranges Date: Sat, 22 Jul 2023 14:17:18 +0200 Message-Id: <20230722121719.150094-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230722121719.150094-1-krzysztof.kozlowski@linaro.org> References: <20230722121719.150094-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772129962890703605 X-GMAIL-MSGID: 1772129962890703605 The camera node has both unit address and children within the same bus mapping, thus needs proper ranges property to fix dtc W=1 warnings: Warning (unit_address_vs_reg): /soc/camera@11800000: node has a unit name, but no reg or ranges property Warning (simple_bus_reg): /soc/camera@11800000: missing or empty reg/ranges property Subtract 0x11800000 from all its children nodes. No functional impact expected. Signed-off-by: Krzysztof Kozlowski --- Changes in v2: 1. Move ranges after compatible --- arch/arm/boot/dts/samsung/exynos4.dtsi | 26 +++++++++++------------ arch/arm/boot/dts/samsung/exynos4x12.dtsi | 17 ++++++++------- 2 files changed, 22 insertions(+), 21 deletions(-) diff --git a/arch/arm/boot/dts/samsung/exynos4.dtsi b/arch/arm/boot/dts/samsung/exynos4.dtsi index f775b9377a38..7f981b5c0d64 100644 --- a/arch/arm/boot/dts/samsung/exynos4.dtsi +++ b/arch/arm/boot/dts/samsung/exynos4.dtsi @@ -203,16 +203,16 @@ dsi_0: dsi@11c80000 { camera: camera@11800000 { compatible = "samsung,fimc"; + ranges = <0x0 0x11800000 0xa0000>; status = "disabled"; #address-cells = <1>; #size-cells = <1>; #clock-cells = <1>; clock-output-names = "cam_a_clkout", "cam_b_clkout"; - ranges; - fimc_0: fimc@11800000 { + fimc_0: fimc@0 { compatible = "samsung,exynos4210-fimc"; - reg = <0x11800000 0x1000>; + reg = <0x0 0x1000>; interrupts = ; clocks = <&clock CLK_FIMC0>, <&clock CLK_SCLK_FIMC0>; @@ -223,9 +223,9 @@ fimc_0: fimc@11800000 { status = "disabled"; }; - fimc_1: fimc@11810000 { + fimc_1: fimc@10000 { compatible = "samsung,exynos4210-fimc"; - reg = <0x11810000 0x1000>; + reg = <0x00010000 0x1000>; interrupts = ; clocks = <&clock CLK_FIMC1>, <&clock CLK_SCLK_FIMC1>; @@ -236,9 +236,9 @@ fimc_1: fimc@11810000 { status = "disabled"; }; - fimc_2: fimc@11820000 { + fimc_2: fimc@20000 { compatible = "samsung,exynos4210-fimc"; - reg = <0x11820000 0x1000>; + reg = <0x00020000 0x1000>; interrupts = ; clocks = <&clock CLK_FIMC2>, <&clock CLK_SCLK_FIMC2>; @@ -249,9 +249,9 @@ fimc_2: fimc@11820000 { status = "disabled"; }; - fimc_3: fimc@11830000 { + fimc_3: fimc@30000 { compatible = "samsung,exynos4210-fimc"; - reg = <0x11830000 0x1000>; + reg = <0x00030000 0x1000>; interrupts = ; clocks = <&clock CLK_FIMC3>, <&clock CLK_SCLK_FIMC3>; @@ -262,9 +262,9 @@ fimc_3: fimc@11830000 { status = "disabled"; }; - csis_0: csis@11880000 { + csis_0: csis@80000 { compatible = "samsung,exynos4210-csis"; - reg = <0x11880000 0x4000>; + reg = <0x00080000 0x4000>; interrupts = ; clocks = <&clock CLK_CSIS0>, <&clock CLK_SCLK_CSIS0>; @@ -278,9 +278,9 @@ csis_0: csis@11880000 { #size-cells = <0>; }; - csis_1: csis@11890000 { + csis_1: csis@90000 { compatible = "samsung,exynos4210-csis"; - reg = <0x11890000 0x4000>; + reg = <0x00090000 0x4000>; interrupts = ; clocks = <&clock CLK_CSIS1>, <&clock CLK_SCLK_CSIS1>; diff --git a/arch/arm/boot/dts/samsung/exynos4x12.dtsi b/arch/arm/boot/dts/samsung/exynos4x12.dtsi index 4524c1e6bb2f..b4b5e769145b 100644 --- a/arch/arm/boot/dts/samsung/exynos4x12.dtsi +++ b/arch/arm/boot/dts/samsung/exynos4x12.dtsi @@ -451,14 +451,15 @@ &combiner { }; &camera { + ranges = <0x0 0x11800000 0xba1000>; clocks = <&clock CLK_SCLK_CAM0>, <&clock CLK_SCLK_CAM1>, <&clock CLK_PIXELASYNCM0>, <&clock CLK_PIXELASYNCM1>; clock-names = "sclk_cam0", "sclk_cam1", "pxl_async0", "pxl_async1"; /* fimc_[0-3] are configured outside, under phandles */ - fimc_lite_0: fimc-lite@12390000 { + fimc_lite_0: fimc-lite@b90000 { compatible = "samsung,exynos4212-fimc-lite"; - reg = <0x12390000 0x1000>; + reg = <0x00b90000 0x1000>; interrupts = ; power-domains = <&pd_isp>; clocks = <&isp_clock CLK_ISP_FIMC_LITE0>; @@ -467,9 +468,9 @@ fimc_lite_0: fimc-lite@12390000 { status = "disabled"; }; - fimc_lite_1: fimc-lite@123a0000 { + fimc_lite_1: fimc-lite@ba0000 { compatible = "samsung,exynos4212-fimc-lite"; - reg = <0x123a0000 0x1000>; + reg = <0x00ba0000 0x1000>; interrupts = ; power-domains = <&pd_isp>; clocks = <&isp_clock CLK_ISP_FIMC_LITE1>; @@ -478,9 +479,9 @@ fimc_lite_1: fimc-lite@123a0000 { status = "disabled"; }; - fimc_is: fimc-is@12000000 { + fimc_is: fimc-is@800000 { compatible = "samsung,exynos4212-fimc-is"; - reg = <0x12000000 0x260000>; + reg = <0x00800000 0x260000>; interrupts = , ; power-domains = <&pd_isp>; @@ -522,9 +523,9 @@ fimc_is: fimc-is@12000000 { ranges; status = "disabled"; - i2c1_isp: i2c-isp@12140000 { + i2c1_isp: i2c-isp@940000 { compatible = "samsung,exynos4212-i2c-isp"; - reg = <0x12140000 0x100>; + reg = <0x00940000 0x100>; clocks = <&isp_clock CLK_ISP_I2C1_ISP>; clock-names = "i2c_isp"; #address-cells = <1>; From patchwork Sat Jul 22 12:17:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 124320 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp821772vqg; Sat, 22 Jul 2023 07:05:53 -0700 (PDT) X-Google-Smtp-Source: APBJJlGugweKZ/ELMF4bp4ju6fZXAIzvY1UF0L1Bu8EVoLIN2DCXQFmJpnU1HPOtFrPJHEFoSMUi X-Received: by 2002:a17:903:11cd:b0:1b8:2ba0:c9c0 with SMTP id q13-20020a17090311cd00b001b82ba0c9c0mr3260429plh.59.1690034753394; Sat, 22 Jul 2023 07:05:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690034753; cv=none; d=google.com; s=arc-20160816; b=bDUBcSi+fQ1YmdSp8EfVbgwrSH725QpCZnjrXHGEx3SUtCmrE1W6GYExplR8c6UotZ 3NwWGO5vPgbY2lVHjrLO6Yckz22ZIuyjk3yPllx8HWehjj5ZRvjsuk6y1QAfd22WXOo7 HhjH+A52rMGPNo5umQNQKBV146unVkZy3w6MkezHtGhZJhbqieFcDHgT/PaLQIC47Ytx pp1PBRgMAhllfit+G1Q/K5devwNiT7W5kC0r9rhKKycPqN+7B1hccBZSCotpClnJvCnK WHir7PP7tobsdNwSEqTP2cW697VcqmLFtoSZ2WnfdnAHnd90yQzinFGqP0pC7ZHgxWcj c3DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tYNA0eA6zTpIVrLQIQILDRIMWUDj6tQ3eTCKjVqejNg=; fh=0wF5EaWROVR5L/uLEzKU7BJpmGtNNKvZ4t5gNBHtG7M=; b=zOqdWhMupfKe4K88hej4KAtAUmeaIhACu1JXiEB11Fl8eQXj6jE2XdiixBytBlAOPI XtMVDUWIL4YGksYeIokGslLd/kPmp67wH1wHTmOn9lYrtgzQw4uEnj8aMgEnzw0DaJRY 0KbdyF2aUBARjN0ynBT7BDkKe3lz3Jwn82qLFEet9HldiD99RRriufDeJHpN73rjKTAP a/bc5URmIsAVMo/EQ79n3tQgqimi83p3Xe89Kpl0LHdqdrCQRoeFSU+OIkeCqXHPqfee iWqpwdvmxBd+0Fh3ERHj8R56RJLpGQ3IhH9QC+Y0rXlNINGpx5cCxHE1x45myDeaIMP3 PIBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lTGur3Hj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b9-20020a170902650900b001b7f4696a2csi4770630plk.347.2023.07.22.07.05.37; Sat, 22 Jul 2023 07:05:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lTGur3Hj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230368AbjGVMRc (ORCPT + 99 others); Sat, 22 Jul 2023 08:17:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230340AbjGVMR2 (ORCPT ); Sat, 22 Jul 2023 08:17:28 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A62210C1 for ; Sat, 22 Jul 2023 05:17:27 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-3110ab7110aso2414883f8f.3 for ; Sat, 22 Jul 2023 05:17:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690028245; x=1690633045; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tYNA0eA6zTpIVrLQIQILDRIMWUDj6tQ3eTCKjVqejNg=; b=lTGur3HjPh+24Q/GOoLXJK6GH1QbnIUwPqJ93LQdr9XSyYWSyqiUIuUbtUHFvkIAer uF8oWzeUakeP//THm9J2kIR8ZRCY76uNjhIgUvsjY8VnfRkDFFLJ2YokaYz9JjcSqCM4 EUVsRTnQeIaIcRVSXb0B15DBr7VWGkGS0jG9TJ/Z/MOqQkQ4IEprYHbx6AnpinUXwfSN zTSTjkN+9oSPFS4wGmg+F6wpeZyJP1RKlZMTUxKgltYi4HPFa6nbWdoi9iKDq6WkSHSy jF0MUXuhRWPrexaUgLU70gyCilPjcRKQ8d0CFltTAnhkygDbG6DnxCEP5hxxCAVI+4aV XsoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690028245; x=1690633045; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tYNA0eA6zTpIVrLQIQILDRIMWUDj6tQ3eTCKjVqejNg=; b=Dl9bnWdM+aMOu1z/FFsrJ6mzCPMoAS1b9CB1w/ol4ywUDdjOLckLP1I+hXuCAH6+UF h6j3PFF/Og4y3Vkwkii4LTs7dNxxY27VCrVqATS46LV2tBD2Cawa5McilyCkFDcRY4Y/ HHI8z+4N6zVvZbtiM1tt38quyZTBv+JqTnALWxEdoJf00HaPmwmk9pqYud10mX1ub6fh wM8O/Gytl3Np5JXB9lieWjbvcb7B4+/hlocna8ZslbLA2KVvZ4R7trr5Nz6ZByZsAcO+ kZKxlA9K1gcKXmnlHY8kXILbQzrjHL8i54opJeIs1GcRAVWb+dGmeBv+EE5tIb+xx8Fc JmYg== X-Gm-Message-State: ABy/qLbUfRoQEleoYMtjzp2fdSDgveDR8e/NQSgaAREugW2c3X6yxw/J DtXMaFrZR0nn/hj16jR4+r+Fgg== X-Received: by 2002:a5d:49c1:0:b0:315:9de4:92f0 with SMTP id t1-20020a5d49c1000000b003159de492f0mr4219589wrs.5.1690028245712; Sat, 22 Jul 2023 05:17:25 -0700 (PDT) Received: from krzk-bin.. ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id h18-20020a5d5492000000b003142e438e8csm6779086wrv.26.2023.07.22.05.17.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Jul 2023 05:17:25 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 3/3] ARM: dts: samsung: s5pv210: fix camera unit addresses/ranges Date: Sat, 22 Jul 2023 14:17:19 +0200 Message-Id: <20230722121719.150094-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230722121719.150094-1-krzysztof.kozlowski@linaro.org> References: <20230722121719.150094-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772129881300572035 X-GMAIL-MSGID: 1772129881300572035 The camera node has both unit address and children within the same bus mapping, thus needs proper ranges property to fix dtc W=1 warnings: Warning (unit_address_vs_reg): /soc/camera@fa600000: node has a unit name, but no reg or ranges property Warning (simple_bus_reg): /soc/camera@fa600000: missing or empty reg/ranges property Subtract 0xfa600000 from all its children nodes. No functional impact expected. Signed-off-by: Krzysztof Kozlowski --- Changes in v2: 1. New patch --- arch/arm/boot/dts/samsung/s5pv210.dtsi | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/arch/arm/boot/dts/samsung/s5pv210.dtsi b/arch/arm/boot/dts/samsung/s5pv210.dtsi index f7de5b5f2f38..ed560c9a3aa1 100644 --- a/arch/arm/boot/dts/samsung/s5pv210.dtsi +++ b/arch/arm/boot/dts/samsung/s5pv210.dtsi @@ -549,17 +549,17 @@ i2c1: i2c@fab00000 { camera: camera@fa600000 { compatible = "samsung,fimc"; + ranges = <0x0 0xfa600000 0xe01000>; clocks = <&clocks SCLK_CAM0>, <&clocks SCLK_CAM1>; clock-names = "sclk_cam0", "sclk_cam1"; #address-cells = <1>; #size-cells = <1>; #clock-cells = <1>; clock-output-names = "cam_a_clkout", "cam_b_clkout"; - ranges; - csis0: csis@fa600000 { + csis0: csis@0 { compatible = "samsung,s5pv210-csis"; - reg = <0xfa600000 0x4000>; + reg = <0x00000000 0x4000>; interrupt-parent = <&vic2>; interrupts = <29>; clocks = <&clocks CLK_CSIS>, @@ -572,9 +572,9 @@ csis0: csis@fa600000 { #size-cells = <0>; }; - fimc0: fimc@fb200000 { + fimc0: fimc@c00000 { compatible = "samsung,s5pv210-fimc"; - reg = <0xfb200000 0x1000>; + reg = <0x00c00000 0x1000>; interrupts = <5>; interrupt-parent = <&vic2>; clocks = <&clocks CLK_FIMC0>, @@ -586,9 +586,9 @@ fimc0: fimc@fb200000 { samsung,cam-if; }; - fimc1: fimc@fb300000 { + fimc1: fimc@d00000 { compatible = "samsung,s5pv210-fimc"; - reg = <0xfb300000 0x1000>; + reg = <0x00d00000 0x1000>; interrupt-parent = <&vic2>; interrupts = <6>; clocks = <&clocks CLK_FIMC1>, @@ -602,9 +602,9 @@ fimc1: fimc@fb300000 { samsung,lcd-wb; }; - fimc2: fimc@fb400000 { + fimc2: fimc@e00000 { compatible = "samsung,s5pv210-fimc"; - reg = <0xfb400000 0x1000>; + reg = <0x00e00000 0x1000>; interrupt-parent = <&vic2>; interrupts = <7>; clocks = <&clocks CLK_FIMC2>,