From patchwork Tue Nov 1 02:17:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Li X-Patchwork-Id: 13500 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2677357wru; Mon, 31 Oct 2022 19:21:55 -0700 (PDT) X-Google-Smtp-Source: AMsMyM55C26lbuTjFoQwXT+dP8+/+frctEmOvTziELGVI9/d9pKlQbpzq4ZjKzLSHL4bfkZBqGG8 X-Received: by 2002:a17:90b:1bca:b0:213:c9ce:dad4 with SMTP id oa10-20020a17090b1bca00b00213c9cedad4mr12424456pjb.205.1667269315631; Mon, 31 Oct 2022 19:21:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667269315; cv=none; d=google.com; s=arc-20160816; b=Pl18OUzD/ssSuGOxg9DgdfnirGRh+FSvY5AOo9xaKfFZ72Eg6Z+fl9mBxcRLtHTUn7 Z8wjIA8jNQwDUIvNDIQgb/2jvQiXpj/aw/0+WWaQB66isycE/Ew3cXd710kG/csED80K /We788cJXMQF18IkOekds7Z8FHlYc/lW2x+ySxFveWsGj00pgvpqYhExqFmVAOao82Fi GKTPWY8IYmzV3CUWZFjlIhR5KRzu1lgoC54hkU9ofLm6MFAcW3RTFPdk6k3mvQUwNTrB EgZwnDzKLhJkSefZvz9PUzQFjxC9oveFdHEHKyjR83ijnNWAHCTYlKjFehhvxHkt/dIE jVBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=m4eosF+C60aANXpvhOfRgCQPHlCnqdoQ4hePi2hawvU=; b=TwPIqrwli4JOgo+MJA7Vhv13tqoZ0lIQ40gYK8XGOQrbr7rrojs3XLviQiPXrNxU6k O4p1tXSSSsrp45HLdg4XlX1k98XrapQ/6Or5xB71rfBPQT7GwoFTajHcxObxq1PFduoT YfjveP8QX6vzNNYs46PYzRth75kc5VKEwuUmqCgCfgPLDaXNYq6LMm7ULWMBsYkzgXhE EITqYjTTPb0OC8uAeFimQ38pGUajX+IQCs+kU93yQfxGx2nnn8nyEE9o7vQlie237a6A 6DDCD8do+qd2HHfGCYzlQptwgG0xNL42j+BA4Q7IpQ3MtYn8WC3Xj4h4MNcenVyA2mOh A82g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o22-20020a17090a5b1600b0020a613f8c79si9124666pji.129.2022.10.31.19.21.41; Mon, 31 Oct 2022 19:21:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229651AbiKACST (ORCPT + 99 others); Mon, 31 Oct 2022 22:18:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229867AbiKACSI (ORCPT ); Mon, 31 Oct 2022 22:18:08 -0400 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6A511788A; Mon, 31 Oct 2022 19:17:55 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0VTaUC86_1667269072; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0VTaUC86_1667269072) by smtp.aliyun-inc.com; Tue, 01 Nov 2022 10:17:53 +0800 From: Yang Li To: clabbe@baylibre.com Cc: herbert@gondor.apana.org.au, davem@davemloft.net, heiko@sntech.de, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: [PATCH -next] crypto: Remove surplus dev_err() when using platform_get_irq() Date: Tue, 1 Nov 2022 10:17:51 +0800 Message-Id: <20221101021751.89362-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748258590132723566?= X-GMAIL-MSGID: =?utf-8?q?1748258590132723566?= There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. ./drivers/crypto/rockchip/rk3288_crypto.c:351:2-9: line 351 is redundant because platform_get_irq() already prints an error Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2677 Reported-by: Abaci Robot Signed-off-by: Yang Li Acked-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockchip/rk3288_crypto.c index 6217e73ba4c4..9f6ba770a90a 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -348,7 +348,6 @@ static int rk_crypto_probe(struct platform_device *pdev) crypto_info->irq = platform_get_irq(pdev, 0); if (crypto_info->irq < 0) { - dev_err(&pdev->dev, "control Interrupt is not available.\n"); err = crypto_info->irq; goto err_crypto; }