From patchwork Fri Jul 21 09:46:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123739 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp100690vqg; Fri, 21 Jul 2023 03:15:30 -0700 (PDT) X-Google-Smtp-Source: APBJJlHwf9kxoBegeERbmO124hzutKxn9HcJemYp+qE44Z9h5kuRVt15WfIWwYWgFzCZ/SqruCqH X-Received: by 2002:a17:903:11c5:b0:1b9:ebe9:5f01 with SMTP id q5-20020a17090311c500b001b9ebe95f01mr1976636plh.19.1689934530460; Fri, 21 Jul 2023 03:15:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689934530; cv=pass; d=google.com; s=arc-20160816; b=iwYPPGIs7o1+1iffveVt6il64dBsQwZN3dRbfhgjauitws9RfYbYt6uQ6FHP/YOzUE xU+CWUvR+eQFOFWiOr3QjRU1x+JhPtG6acDdXsquLlW+0juIUKdn8P01qM6OzkS9Hrz5 8elBuouEeadnJ7BKfAJ4AvMwLNzdvQwOQsD/1OQilSfq+OkmFl6Rtp+iFvIV08fd9I20 Ozx+f7zMgl5CLDPvqrNfsTz48oXO+bonl3yFy1VMBIqoQKtCIpOQdstjQMAydnVTRgC5 RYVhGmJKYM/9WMPdp8tQsqXXmQzrYexpW3z04IZrW1PZkb451xvZJ2j2fnHLzANQyrjZ vcXQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :message-id:date:subject:cc:to:from:dkim-signature; bh=gxSaJcUJrOhYfCgqHyxB2Dz5FjATs5FXCAzpxy8vL+A=; fh=W5R8GLqMLQzWLtsksSQ/SV0LRpkJLRiXBKjtiKwZvFY=; b=RP2HaEqJVaUJ1xcVLD97A+s2nKQQ0DbPOK+u5h4qrFKnCOPfBCWmsE4H5oJAKXSsFK WxC32UjTHGn/OpN2/L4RW7//flv023LDEB8DG6ROZDjqG/6SCiHnZ4W+fDQ3r6VwKEMi Fs/LlE5l6pCpVxlR1JfN+qXBcbX/2LvRvcy5L+qVQAEwX5nAWU5Uny7xIEXJ6b0AC6cT 7nhzW6xIUZyDEzX0tGJSEcTINpSE806/Xx9Ud6zczqr3Q+0bmcEL/MfwzHH2582xJkU5 kn4/XyZNZjV2+yfX+Lj//QU10y01osQosIDE+iOWE+FWrFglvXL6nz+cnYxgiyldKH55 j2PQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=LIlmhHl4; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o8-20020a170902d4c800b001ac4f733007si3042720plg.549.2023.07.21.03.15.14; Fri, 21 Jul 2023 03:15:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=LIlmhHl4; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231293AbjGUJrL (ORCPT + 99 others); Fri, 21 Jul 2023 05:47:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230237AbjGUJrH (ORCPT ); Fri, 21 Jul 2023 05:47:07 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2095.outbound.protection.outlook.com [40.107.215.95]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AAA72715 for ; Fri, 21 Jul 2023 02:47:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZF9tVg2gJqNJ+PZrKIQ71MJ+og3AinHuKx932B2I1siTt58soODavXoiJMnBKA5bGjWtOl37C6YZHdf110F8AF2CBrmnG8WLhLh9rb4F2Sj6chsv9LJhljQ+nt4rwABBkqN2vfz3sRXbiBRY23bZriq4pUfbSUoKgft7qOV+VTFGNgyQxZxjPbVRp5N2wHCSy9CsxSz6TE9Jnoabuq58bHbh95Q77bnGtm828sA2gXOvUPE+zfhK43pVANoAKji2vHksV3oAjjPPsJJN23D7ImRRIPrJE71/1c2691mv366mhPQjyp7jXsyVYb0QAr5vigpfDK6sIsSY4wjBWMnhBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gxSaJcUJrOhYfCgqHyxB2Dz5FjATs5FXCAzpxy8vL+A=; b=BCicPA6lCdQAYIdlHzrApMGxMY/fw5uqrOP35LnlvvAQStKz1czH5m4/ISno3XdH+ODDRjJkKSMfaxgaaGQb30SDnBdQwbNwqqhhsWOIrZswzQidyDV2cBYy2FSQuwh9XfRQbUlG3sT3iwvAERXsQT+Q1tFH/Q4CLQVrdEQmCgqEr7ntKaxoAIh76HcdpKplP+KyArScwQb4AthmtvrkYDsqTtiamWSHzhdD+6a75ueoKkA0R8beeoD7GEPHXGmx3AvkEx60p351SJ/ac0fSKDzYUbXy6WxGYS8uJKb+/6HeE/8KPowSCiB7Ic2H599zOKU63cIdOEgTCc1/adbj6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gxSaJcUJrOhYfCgqHyxB2Dz5FjATs5FXCAzpxy8vL+A=; b=LIlmhHl4RwO7jdDkbLswj1Cn7osX7s44UC2ka54T7KRE3sVlMd5h9usKb3lO3TLhLCyavOcKSLq/zs2sILowp/JGT6BeM36YgtqHhFbG7+ZhrQgknrbDNKcRwmpbe2TeH4sxIH3SJi5C/kBksRBctEnAwY2YH+co0ZW8uE25wHkMPeFnPj6LGVrXS8PhEvpXt4AkykakaG3RQ7fENkZ01c9+3KXIUGEDPl+Cnx8kKMbxKAAoz0RCQpozRgPo2K1b5KhtBJi8gevc15FWbFOYKHERZpxY5bY4LR9lyufwlQMtCeETX4SAB0QOYQouS7dDRi92uTTCmglR7dXxcbVqpA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR06MB6789.apcprd06.prod.outlook.com (2603:1096:820:ff::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Fri, 21 Jul 2023 09:46:56 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:46:56 +0000 From: Yangtao Li To: Thomas Gleixner Cc: Yangtao Li , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , Geert Uytterhoeven , Jonathan Cameron , linux-kernel@vger.kernel.org Subject: [PATCH v5 01/22] genirq/devres: Add devm_request_threaded_irq_probe() and devm_request_irq_probe() Date: Fri, 21 Jul 2023 17:46:20 +0800 Message-Id: <20230721094641.77189-1-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR06MB6789:EE_ X-MS-Office365-Filtering-Correlation-Id: 297f9694-3ab4-41b7-0ff1-08db89cf6b7d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5X+wXCgtxZSOyFtPTy8zq8sNdGDL07VuyNexTis2Y/rERr1+WKzEtrCO2Bz908CxTEI8Jz0ulQMgWxtCEJvQzQtQzMXmVW5SRlWZelgrRaizY3QLFuOjbGX9s9+UW2lS3nW4UAHb5/+9vo8Ql852ocJKppom2cf5WSfHQuu2TqtcrSP0vmzSl24dyog/vcK/zVgnBlgW4eiUDj2yTmOYs2GFJrjhEyX+1ckyWn0hvfS2iV9x3c/Sz8vtX4SzCbLVnpnX9au8IF3eyqZyB9i1BHv96GcqRogsoEVzohUkkSGsguL0pkI2tJgOYcAMYU3j0T8bP3vCT2esGhNuJphZYez8FAGegusQSn8APdZjN+GI2AHgQT6XRZNRvPhyD9dduqm7/A0d7XQJTSHmJj9CJ+3fvJimZNMgDHmTVwVIzGgq8qp9wKNDptuqZWN+bbTO6Qlb8rgusgtTC8r5L8GtXXxu2mtKyaS8rWeWdvXev8HY9UW1lJHeasEz1R1NLdyjsn2jgOKP1iPYvdCWaHt3Oj7Uk/zf4QlvQ0Q5urcTVNdp8MPuWY5JP1AUOtw62tXfUs8Z5QrXGnFa45RCL5GzKiX20kNVSPZhlb7FJoUEknCyCwGPxoqKWy7MS55Beht5 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(451199021)(83380400001)(66574015)(2616005)(2906002)(38350700002)(38100700002)(66556008)(316002)(66946007)(478600001)(6486002)(6916009)(41300700001)(4326008)(6506007)(26005)(186003)(1076003)(66476007)(52116002)(6512007)(54906003)(36756003)(5660300002)(8936002)(8676002)(86362001)(6666004);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?PSj2txUzA5xCf4VNwOAer9NcU5z9?= =?utf-8?q?IEblANid66YiLfOXFrl5JRwHRFTQImNPCIIm5y0JnhBF28BXWpRRZBEb/CAiMmiZI?= =?utf-8?q?Kk1xo7do/uMKq7y7YVPpGhBQa0yPer7dfvvX/w6cCdxuizD8k1xKwrL1ievneae2Y?= =?utf-8?q?lJIuH8woQk5FTDfa4tqDAssiXs4XpfGcGG7yQphRBc0e7pMbqJnj4Zdmct8PxVByj?= =?utf-8?q?v4M6d12XQfBOSn+iojbDpt4HMSAKNrwqG9mDC4bnvwP2aDWftjB9Rjm3fU4bg5ryS?= =?utf-8?q?BVjYPm99mTtsseqr+73hFkzRcVQIKv0N5L+NarHkNJttgELeVHv9ROxPnXL90B5+j?= =?utf-8?q?cS/EhnX2j5Pa4+yv6DcIx3myMXze2QhXb2gmUx9pdDq3tB97dYOPhLzua7VyvLq2v?= =?utf-8?q?Dl/nMEh6F+yOfvBvdPONY2uuOyv4erWg+eH8ChKkxwj29V3wSxuGV1vGuSOHWaRxg?= =?utf-8?q?a+mY6NBdwPDrOnT5msl86Zuz7dw0Jalki35+uXyDGkexY/lq69KyHemN+HNPkl8fT?= =?utf-8?q?LGsCWoJcT7Yhe92hWCw459iZEB1+UzZiO6JHrBGfqe2wvKQc2dwnJvGpN+oHejpid?= =?utf-8?q?O3Itef7b5ldcUwxP5fCiTCoxoSEPJro6eyMc95lIiQ/yeDs6nURENwspwFGny9qHG?= =?utf-8?q?1kpjyRAbUcvRcefLKE51lMlSXxiC22rtpWjtG2GSsAHHqTv/eywS1nakY4r7UOawx?= =?utf-8?q?RyLx/MfUKia5mHQmYIwYhQ7EVmR2uEt+Os4YlcsqjOlXKG8ZQydp2WYwRqTzA8ddD?= =?utf-8?q?i1WyRg2BXLGZ2m7A+XYnzDMdYeVz4FMIHHZGL5MIgawYk5vuh/pA0tNO4R5pSr2le?= =?utf-8?q?6KrzFtBqAw4Hs9W8yGP2DzzQsnUXjz+eDLvR4dxk9di45gV+4C6ta5Qm7+1aagBX5?= =?utf-8?q?E5ae+fg/cLThLqfZZR6fi7rFIBE2Db+xrxlhuI/k7+rZ0Du/8V3i5P+9f8sSfTbXd?= =?utf-8?q?slXixCCzuHJLgNAAoOFQQZtOovRBRe+G4JLB3JoHfRVKnmIcR/FifOsn0FzUFQZ/h?= =?utf-8?q?KMOZaJ5EN8c5PMTJchjXzulHPD8sh2G1XzbTXgSAUgUZm6VUXPdtlxtp69GIgdPIv?= =?utf-8?q?5aC8Xrz97Mk1+rjGWN/enjLHIXWhB/2wMKgTE6hUA3aEujM+L0D8Z8LwK9IWCcna/?= =?utf-8?q?FvFqVUOvtKNyQv66lzmA2A5JxZfKsEtLqoLKNjPcHM1m4BqOjTV6qvzAAYzYoY260?= =?utf-8?q?RXIRIbVqrI0XSeTDibv2Q9wKe7Optuv0RTmYZIEBvq0P3oNMxFaSzByoTfXYqkSuy?= =?utf-8?q?fI+ryKqcBw64RnmxCVe8ovmu5zUkk7s3akQkvy39erwMJTcmdC+/xvtxV3ssEv/zd?= =?utf-8?q?odw4HGjY8r0qz/zu1w3U0uRwLsu08dbTD74272JbY1nYoipzSkvq6TdVyVM7yiXhh?= =?utf-8?q?NK+jGXkLycQIrlkW97epJwZfGiUtwy4S/4tr6E0z8EuG4vbpsT47L0MXIoLFWiYEb?= =?utf-8?q?Yi2hCtelyIAHqaUBjpHzHAXHOGnygq7S1MjUzaYJ3/ckb/zUS56vtlkVFQe/h0+gl?= =?utf-8?q?LAfy2KbzczZk?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 297f9694-3ab4-41b7-0ff1-08db89cf6b7d X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:46:55.9916 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E7zPzqvDXuIn/GHACqUOFYygyiqikSHUEMzinnEq4hJD1Y6rx9yFX2DNytUP/6nvXghNGN6y5p+2xNNj4YrQzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6789 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772024789783552999 X-GMAIL-MSGID: 1772024789783552999 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So add devm_request_threaded_irq_probe() and devm_request_irq_probe(), which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Reviewed-by: Geert Uytterhoeven Reviewed-by: Jonathan Cameron --- include/linux/interrupt.h | 15 +++++++++++++++ kernel/irq/devres.c | 40 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 55 insertions(+) diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h index a92bce40b04b..60a3d3bdcf45 100644 --- a/include/linux/interrupt.h +++ b/include/linux/interrupt.h @@ -201,6 +201,21 @@ extern void free_percpu_nmi(unsigned int irq, void __percpu *percpu_dev_id); struct device; +extern int __must_check +devm_request_threaded_irq_probe(struct device *dev, unsigned int irq, + irq_handler_t handler, irq_handler_t thread_fn, + unsigned long irqflags, const char *devname, + void *dev_id, const char *info); + +static inline int __must_check +devm_request_irq_probe(struct device *dev, unsigned int irq, + irq_handler_t handler, unsigned long irqflags, + const char *devname, void *dev_id, const char *info) +{ + return devm_request_threaded_irq_probe(dev, irq, handler, NULL, irqflags, + devname, dev_id, info); +} + extern int __must_check devm_request_threaded_irq(struct device *dev, unsigned int irq, irq_handler_t handler, irq_handler_t thread_fn, diff --git a/kernel/irq/devres.c b/kernel/irq/devres.c index f6e5515ee077..40494eabb060 100644 --- a/kernel/irq/devres.c +++ b/kernel/irq/devres.c @@ -79,6 +79,46 @@ int devm_request_threaded_irq(struct device *dev, unsigned int irq, } EXPORT_SYMBOL(devm_request_threaded_irq); +/** + * devm_request_threaded_irq_probe - allocate an interrupt line for a managed device(recommended) + * @dev: device to request interrupt for + * @irq: Interrupt line to allocate + * @handler: Function to be called when the IRQ occurs + * @thread_fn: function to be called in a threaded interrupt context. NULL + * for devices which handle everything in @handler + * @irqflags: Interrupt type flags + * @devname: An ascii name for the claiming device, dev_name(dev) if NULL + * @dev_id: A cookie passed back to the handler function + * @info: Optional additional error log + * + * This is a variant of the devm_request_threaded_irq function. + * It will print an error message by default when the request fails, + * and the consumer can add a special error msg. + * + * Except for the extra @info argument, this function takes the + * same arguments and performs the same function as + * devm_request_threaded_irq(). IRQs requested with this function will be + * automatically freed on driver detach. + * + * If an IRQ allocated with this function needs to be freed + * separately, devm_free_irq() must be used. + */ +int devm_request_threaded_irq_probe(struct device *dev, unsigned int irq, + irq_handler_t handler, irq_handler_t thread_fn, + unsigned long irqflags, const char *devname, + void *dev_id, const char *info) +{ + int rc; + + rc = devm_request_threaded_irq(dev, irq, handler, NULL, irqflags, devname, dev_id); + if (rc) + return dev_err_probe(dev, rc, "Failed to request %sinterrupt %u %s %s\n", + thread_fn ? "threaded " : "", irq, devname ? : dev_name(dev), + info ? : ""); + return 0; +} +EXPORT_SYMBOL(devm_request_threaded_irq_probe); + /** * devm_request_any_context_irq - allocate an interrupt line for a managed device * @dev: device to request interrupt for From patchwork Fri Jul 21 09:46:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123742 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp100844vqg; Fri, 21 Jul 2023 03:15:49 -0700 (PDT) X-Google-Smtp-Source: APBJJlHy+Yc3z06Tg4cDcuDNXyU3aR1CqczxrwzYFBjuxt9CSC6PlMbjlNnLuO9qzUDWI+Lu+UfR X-Received: by 2002:a17:906:748c:b0:973:ff8d:2a46 with SMTP id e12-20020a170906748c00b00973ff8d2a46mr1444415ejl.3.1689934549606; Fri, 21 Jul 2023 03:15:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689934549; cv=pass; d=google.com; s=arc-20160816; b=O3/swazgPjOEn55dQoxo4nKO30ekJtPXRHqgbYkQ+L6/bv1i3CJ6XK1TB+prV74bnj mBxwBbNPpKI+WbyUv3DFgcoAwmU6qo0fgT5/1eDNIEXzF01L9TfuyFkQgs8kLGaw4Mkr vMm4lROKBmg0tqAsGHeU1qxSuxseMYiZ8/wGdAb6K1Ij41L0UAH8qCsqHGtprWEOwV/9 b+JxOYrcYMozhEU6ozCQ3zlQermdaxdSHJFg66b5TsNwWbxuhGNNaqZTKXkEhvonluWK rgtprG6X5aFuK9zDwiy4f2/4I8dGTG9jSbffigKFwsnjVo+6tuP7iZgIMxChpGZoc+34 ZuTg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4cslGBST80PBLFMrkaY/Jc9M1A0EqquN1GEpZNPex7Y=; fh=0SOMuHSJRJUal0e2QZYr0vChXTWHLyDZ7oQm5zYDano=; b=X/C6y7Lnh6GtH0hJRVT6r4k8c6L3t29d15UwUMGyAHas1l/Rf3isO215NKugzzV8Vu vI5aiay86wTGR+zdkfVw+9/NXf0D6z3fvupALQzHlUn9xtqb20fJfMdlDh/6r0jEecEf sKSVi18qU8kIJvUURs4wB/JGVH6qcA74Hw4b4BIK0hXkXloGUYvml0dWUetHbC3bIlli 5xl4hl4WAIoOjPpTz+Nle3XS0Z5QjCAff9gMEtQ/xgDimtPmoEWquC7oJA5kRW65Fny6 DX7Z5CQCTPrwHTr/mOZyLdnNRfuBHXMxRInoMyHrS9qbi1tCeDujUX7kG05ACPI49mum L6oA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=KiuBelRL; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v15-20020a17090606cf00b009937e7c4e50si1935025ejb.546.2023.07.21.03.15.24; Fri, 21 Jul 2023 03:15:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=KiuBelRL; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231494AbjGUJrI (ORCPT + 99 others); Fri, 21 Jul 2023 05:47:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231293AbjGUJrG (ORCPT ); Fri, 21 Jul 2023 05:47:06 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2095.outbound.protection.outlook.com [40.107.215.95]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A270121; Fri, 21 Jul 2023 02:47:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AUkcqD3NiZTKjp1xtzU16fhIaEr4bUOtV4T8Rh7TrRlfGgWfJBffyslg0xE9HicWdo0UZ3Dfj6w+r2yAt5C6Z0F4M31MWQIGuUOhsBFFS+lQA4ggdhufES7cb2MZ2LSYaBDHrA5Sqfp14PNCp50OVsi8IqPvjpcX/dDtvMr+vlQONxkL0VtpAtRDhmhKzF7noKG+WxqsrpivJUccg6ztFGg5LKhBvfKo5HmPk+12q0m/KmIkXkynFOBFHM3eQT7C16t5W75TzW/0E/14JDZ3ku6YTs4DwGmxi4cwykJXlWo0YAEPKMHWV/IIUuAqHNDLVNdDhXmOMMhFR9bbM8pmAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4cslGBST80PBLFMrkaY/Jc9M1A0EqquN1GEpZNPex7Y=; b=iJFot14QsAyv72wxSMx6hYjatkE58tdkJPlaRH65ekLppH71SS+gi25HMtuCETzps3Z1UHq9BdNogrNfcCWkR/BcHDmen6+KE5l/3Sg3Dj7KPbrErtIIN25SfcOLyoQswKkswO7timKaGcm5r76G8RroERVL56nuXeUiF1O4+RwWzkKytLxZLbKRKuYP3of6bekQHdnRzK+Um5vrnQGBQniNIAvRo3XwWRCS2FZJ4/kZUYnbgP1HtfA9UCpZusDxN6uQkiCiB65BsClfFVPvIc1nQ3DptQi17gEdx7LacKNKFPKujLhdkSltHHrtc3R37Sy114IB6LDAkI7un3t4Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4cslGBST80PBLFMrkaY/Jc9M1A0EqquN1GEpZNPex7Y=; b=KiuBelRL1XtxPBzvfMW2WALHrf5ChiaYMUGjzSc9PPGb/qwmHPomqFuXIidtuiPae0pEP5pgk2y2+A58syo3Phg/92rSsijld5Aq1ylj00PfAdSRsNP+rtov1Gluqj2knJeHKWmSxF2jwI7AdvTHibM3GzmzrIJa2M25qbQgsiO49CpOWA3e8ukujZchYPq4pLN1zZEMDJYlKQf6gyCCE+ej5+kukKIz+2QC02bAKBV6qP1jB9lyweAdnsaf6CJhh/RUy8G1slq2KsuCPnVhezBKMbwddgax7wLkAX1AJucHUFXLSwMZyEkCaRlg2DeGSSz0bsMASVPs0rQcPS984g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR06MB6789.apcprd06.prod.outlook.com (2603:1096:820:ff::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Fri, 21 Jul 2023 09:46:59 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:46:59 +0000 From: Yangtao Li To: Vasily Khoruzhick , Yangtao Li , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v5 02/22] thermal/drivers/sun8i: convert to use devm_request*_irq_probe() Date: Fri, 21 Jul 2023 17:46:21 +0800 Message-Id: <20230721094641.77189-2-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230721094641.77189-1-frank.li@vivo.com> References: <20230721094641.77189-1-frank.li@vivo.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR06MB6789:EE_ X-MS-Office365-Filtering-Correlation-Id: 96f6255f-4cc6-441d-81da-08db89cf6d4b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YkJVPqDdoPCaO/MbhkSoJ0LTDGeToK5sNowFuzka6xhjQZrlYcrQe8Qlsmy2ae4bygQe0LquxRngQoPxEh/yg2Rg/4n3rz805GVks1VA8gCKjSMMbSpm9FdJu02BzBYFLaZGXlq20h0Pw4/QK5nH5aErt9tuzVaG0Q1FwLiFABHn+n0gT6+urvMy7OQE2DxqN1NL9yFKTFOrAemI8h03eFq/QzVe/uY2c7jwIfpqJpoVLMv7Yq3clyz8jlqIGYFzEYAE2piZyoML0EU47mEsOArdmc8aLlD5Zw3e0+ZVQVL+o+joAi6+xuRWTTiv4+Q9pHSnvmoB5NMbvkFJY57mArOqFhAXpuTPF5KrzIWM8PqMe/Ag1DnDqiCnIUd12Jg/qWfyBPKCQU1PBP1MjPreTzeQ7Q61I597R4B3slPPDZzYXiZigT/kU5tTd4Y4hIhmna+DEd+mbU5nPklrcXSEwGW5I7m+MQSPHtftEZD6BV02vCVVwubqjl45ToZZp1KdViy77FFUy1U8ib4QZSznmgDa6iBmoSCkizGPh8DHK6plAY5LUnX5twfRT00V8YU95CvUzMKz7rBSD1518yqkWpXANK6ajJjBOgYX8x/yXn8lDIaGozjn5QdhyRRfngNe X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(451199021)(83380400001)(66574015)(2616005)(2906002)(38350700002)(38100700002)(66556008)(316002)(66946007)(478600001)(6486002)(41300700001)(4326008)(6506007)(26005)(186003)(1076003)(66476007)(52116002)(6512007)(110136005)(54906003)(36756003)(5660300002)(8936002)(8676002)(86362001)(6666004)(7416002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?x83WvHWsUhLcjonVuhlsY/RxgMQz?= =?utf-8?q?orCXKWkdm+S/mvH+HZLwT5FT6dv3Jxwj2MBgwEx44xvBUt2GCbnWeePGiF43WJtDz?= =?utf-8?q?AQ+PsOfo5ptdhe2hu/2y834AiZYJyy0r37i7NnpLDdZJ1At+zpl9L5NdyzUpJ8pdy?= =?utf-8?q?Le7iqOjsqtzemCIbvWPp4RWSZI+Onq2O3HNKt4hohsPt3GaY00KbdOxrpufd5OsFF?= =?utf-8?q?F2ZIAAnYYg1/+lMbz6AM/fqDB4Ct7IHaIoBH2I13Ovoqp0ugbKU+vvjvYlwR/UtpL?= =?utf-8?q?DmMo20E1j+DHfQRQ6qhJpnp5AiAEXngrEk8hZVJBtOYPpGG5ncOxaHLxEbrxkqlXl?= =?utf-8?q?4otnOQSmCQTds3Kx6X87zfsLZeK1f/FXQivyg4GBKUZCKagqzIpmU686qkZOIoSKz?= =?utf-8?q?sEdW/boVGS1WM5+T05ziNiPpNICGp9J3F9okQi/+y/uuCzw8NOcrkrrMXZOrTLfpK?= =?utf-8?q?P3Qz1KS1XBkhnFINNrGznadM+lXRM04oFaGWSYV/Y22pHueDotXCDMuFLGr8Pq3MG?= =?utf-8?q?KhbTzg+bJ90tEVSDHfHMGktuJwNj0H1fNmFp25dhAdbc6EyZQSUbs3hW2t/HmJePV?= =?utf-8?q?7yPJ3GQXJw/KZZnAXz0DU2OH+0yvfTvVqrznfKHZ30LCjudQvz0Y6GdzlKSCWF+Da?= =?utf-8?q?c1aa2PkokcH4XVKpDuGkYcSWdiUtpnZekgN5GjjaDnH16U+5METMrFoLWizRA2Bbl?= =?utf-8?q?T4egcSU5RfKOMKs5Nx6Z85U1jZhl3vLnWRf+rFD69ENX8Xzc6RpOqhX3Bmfi5jRM/?= =?utf-8?q?wh+afGaA28NW2Y72vjYVY7bevtVYH6iLAV1TJRQ39McvYTPC08PbPbTsrkg3KT3jw?= =?utf-8?q?SfJ6++voDhnkbTyz1mNL/qRyN0Ty0AyrosELx2NmTJKJeUxb6fPJrAgbg5RM8cIsP?= =?utf-8?q?NMfZw3Sw/1mHDo3WYzHIoYdb3kpnT0ArhLcTaLTGM/FLOtCcJ94bSul+84diOR9SP?= =?utf-8?q?XfWm9/r2/ypI/6hMuFKLIIguxcU1WUZ91O0a/sT1rPclqUsvON1Sn+U45o9YHj/lZ?= =?utf-8?q?qIdSPeRgiDglS8O/hR2lzUHTN6ePi/zZ/inIIrkLgS8ewtWjVPCY8OueG7zrp8n5C?= =?utf-8?q?6GnQYRAzzFas/0JkWMYzHlOdjg0YgxctyU7bVGTS1ZNgMDUFnEZxy/1E01VkJRBgu?= =?utf-8?q?apvrhJjouActPBd3+JWJh9H/xSspNL3ZMiMQ1ydEuDI/sQ/W8EhIpOwhyzw9ZsD8B?= =?utf-8?q?79U/Z3vBy2Pyb2vnSVg99l0HeRbDWtcx+VzD49SBb56YdA7gtAUd0f/LgXWY+JXaS?= =?utf-8?q?/7U9oo0TT3Ag+dxKhu0z5IVX+/v5RvO9yIMAlbD5umbzUGRhh7UyTHwLxnFjHJxmm?= =?utf-8?q?wX0b9d0Iqrqu0LD4ysc898h5bSQhyz1qL/CaCTUrN5N+OEgkC2rxDo0xz9ByDt50z?= =?utf-8?q?/s5ZAUgu91mL767/dhHU+ty9AkRicmdTSZiOyMsSOSn2wrVhJccLp9/pqjSNM5xnE?= =?utf-8?q?gUZVuBWeoCEGy+yFyiCzXP6LVkhaIsIE9tnCOAmCjoJYD3sad+wQeC9xEDOGM+rK7?= =?utf-8?q?yS4xR7jzVFGs?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96f6255f-4cc6-441d-81da-08db89cf6d4b X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:46:59.0249 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0pW2SSACajjScwYqnzDxFJFRqKjDgQGYKolViSop/ST3DOWC4v/rKKUARSTAiTCuB7XAzsu8q9fqHJj9nPYj0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6789 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772024810603769342 X-GMAIL-MSGID: 1772024810603769342 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Acked-by: Jernej Skrabec --- drivers/thermal/sun8i_thermal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c index 195f3c5d0b38..a952804ff993 100644 --- a/drivers/thermal/sun8i_thermal.c +++ b/drivers/thermal/sun8i_thermal.c @@ -512,9 +512,9 @@ static int sun8i_ths_probe(struct platform_device *pdev) * registered yet, we deffer the registration of the interrupt to * the end. */ - ret = devm_request_threaded_irq(dev, irq, NULL, - sun8i_irq_thread, - IRQF_ONESHOT, "ths", tmdev); + ret = devm_request_threaded_irq_probe(dev, irq, NULL, + sun8i_irq_thread, + IRQF_ONESHOT, "ths", tmdev, NULL); if (ret) return ret; From patchwork Fri Jul 21 09:46:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123709 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp91023vqg; Fri, 21 Jul 2023 02:57:41 -0700 (PDT) X-Google-Smtp-Source: APBJJlFFrIpU7P/GTbkYewUX8mcW4eXQJjVYrIDiKigsigEZw3qppoU83tMpyB3L+EG05akANd4t X-Received: by 2002:a17:906:8f:b0:96a:2acf:61e1 with SMTP id 15-20020a170906008f00b0096a2acf61e1mr1282664ejc.64.1689933460659; Fri, 21 Jul 2023 02:57:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689933460; cv=pass; d=google.com; s=arc-20160816; b=V+VuxqVvA55KRvzFmhra0ZOCvvkZUk5Z80G7MhQjqfCPtNXDV5ize+wU57vQUN7Onn EDvOJHKqDx3NETR1Wu2ebNPZbPgg8Un0ur6Pfn1fgKSuytS2/lM4ANQGajDlrrYLacOY yH2A3fALW3prwpJjQeUzl/mOLJ0lOc/HOjIZA1BRnXO/f3jHq6myvm/bIDzABqsObNYU f5P1YOjcwCMVHvazncNaQXBgoVSQBvsOssSnJKapPch2Fa7TiXqXyws72fXcYT3AqAvd /dhqPf2wilc7GAYqWL2yn+t8kTr58LqoyYvvrszSjgEjQ6MZqoZiK6EpIdhrz4NYlRVm xfsg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=f85Sj1Pf7S/hIg2p7O0a1eybgIjJgZrXjkRNBEWx7tE=; fh=t0bKF8TDHm2zqGW6x/Beg82VUEjuRqj0WcQHqaiSBSY=; b=lf/YePig9oOwnG8h+K3euWYus40ZozrQBaiOsVny773GhPJbHYMYAwGh/oqRsrjgUR tXe5xtaLddhx2zW8LCpsvIna2jJcj80uk6QMuspD4CR+bMSupZzw54C14go1bVmTMBLb e8nTWoFyYUMYal/n0VfIIIDex/jKLhLabUq7zsZA+eM76cIk2bcHAX7NTJLfn2RBlEcx /VoMZCQRK19QDwGxO06Sq7lkA44idm7S/MqzpFGl1bn7vXnOJ9JUJiKoEM37aSRXASDx hFNnGGVbja6WLdhvwybr8q8QgcUe9ZySXfvrMFPgFpa8AB1qO3AN5oosh1f9FP/E4xXl EUmw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=XFMFuqY8; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j20-20020a1709066dd400b0098d373fa9d9si2029254ejt.149.2023.07.21.02.57.15; Fri, 21 Jul 2023 02:57:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=XFMFuqY8; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231755AbjGUJrO (ORCPT + 99 others); Fri, 21 Jul 2023 05:47:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231522AbjGUJrJ (ORCPT ); Fri, 21 Jul 2023 05:47:09 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2095.outbound.protection.outlook.com [40.107.215.95]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAB23F0; Fri, 21 Jul 2023 02:47:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LRyhLoP5jNioHSxfmlweb6URpGHiq/t+DY9AVGWuOwU7vGvbYJhWydRsye586HES23fmo70HuowBoWGAdmgkcapBMn473EMJPv0oDH17fJKC07mGa+mg1ppTvXJrBv930cfrAXoMycDy3juUsLJ3x4ogVmObeZy9LY5J9sAcmREdSRvBP/6ZYMVLmiuB0i1b+X0/qvrnpK+YsECvLMtQ3MWovTl9a/Bw2J3lzb8WvyC8mYvlNB1Q4DZgeRokwjYfFQbfs88jbDa4lpmsGS0yfPhp/5S1dDpGTQt+5e8RPJxjxTfWYUoo0Obe+u9yHyiCyjvLZLt0sZTGdj+6RLNL9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f85Sj1Pf7S/hIg2p7O0a1eybgIjJgZrXjkRNBEWx7tE=; b=RIN2OBBZYp5JhS/28AhrmnuZRbGa4SDTVNoisBmZYMKbpNFoJN0rZayKB3cVLveFRG3PGyOFAU5GIH9AqogE0BuZ0B3+ZBsWI2SmyLSztYXUtbanI3XAR2xchvROxoqCXK8cAtCb2TazfI54c0g5lhn4LOBxP763YvsJpfSb+qxYlJuoco4gbjju2vOfYpxpXB/eMBgG5/9zzJxvNFgMDhq2YEZxJGYQa01ahVIl/f8/q33I5AaawQChjjshvadHxXT0nE4Mqbq0bf4/LoPlQMQ0uUZ3X/qvcmcJTKs82U7QwfbUJ3jHuzeCG3LVhRu0MKxZXfkVPYMFPprEfoLzGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f85Sj1Pf7S/hIg2p7O0a1eybgIjJgZrXjkRNBEWx7tE=; b=XFMFuqY8WkT9rBj0JJJaUFperO2e/CowUJVLfnor+j8GpNQrOMMFPLawcE1DVYNloXT3t5/L0/8Fc9HNCfz5R2acrE8ccAFOq2mNmt9UGiaT8ZGDL4RuFKiZrM0HM/8dTF3VhdxcbW8F6uJl5nZp/0VSP1MUTA3/giJsUW53a5oVTWFZk+t+glW9Sb/Jl3jVHHTFErvp6UWTQHe+CxajjKSREYwROYvmzeT1CBUNEo6QH73Y6qpZlzEqo8enD4CnmRxfZQBeSVQMhtn1K/VJzcsXjgiT/mc4RdwAF9c8D4EDvvnuKOMnB6n6SHbb6EOmEM+gVzs5DDg+CqzcxA6iXg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR06MB6789.apcprd06.prod.outlook.com (2603:1096:820:ff::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Fri, 21 Jul 2023 09:47:01 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:47:01 +0000 From: Yangtao Li To: Miquel Raynal , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 03/22] thermal/drivers/armada: convert to use devm_request*_irq_probe() Date: Fri, 21 Jul 2023 17:46:22 +0800 Message-Id: <20230721094641.77189-3-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230721094641.77189-1-frank.li@vivo.com> References: <20230721094641.77189-1-frank.li@vivo.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR06MB6789:EE_ X-MS-Office365-Filtering-Correlation-Id: 4def374d-d1b1-4a65-af29-08db89cf6eae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XJYYi3XonCH/O/pl/L40rEq4q21J+BJuETu3exDBCatkv9DqPm03JOHwfQrPtq/7oPFMPjTIGk5t+S5UHiT3GSGIMotcUnPwQfXofrHv9epVloi3z9+CcPjmQMOWq9Adxq3ZjoX6mwmyBFQMOiGfrN7CFrYsE252/z52LkJS/cMybbMIl7iIDGWFJtAk8Rj8q3HQ5ENLW31rSXKs8U1X7cJgkrqsG7keLuqRkh3h3ofpQ/7L1IB87PuELs8kct+g2gZpXyXWgFGqmc6p0l+8begsWfJXwN405/F8G2EfVELlrfR5Xi8Dl8qpPTgkwMO0zyO1rNb62cUw2A+zdfMjxN/WmrX1lkcJK9T1oq6Nwj7995lZCiEXvaWjePqcLaaBxw4EJ4ijIbQ9StngrbGHC3GcHMHTh5uyGe+xDVdlInOoQDzLUqp28VvZRok/r46S7GhuZAjQto00R45vDPJRXeAegHZZCGsP/XsxEFXATOyY6ofp1eWSrhzkgydAadBJv/tzTziSa/njEBvCT7XE2MB55noJ6so8kiRg3g6munpI1tF7E1buM7UzRDvnzmp/FMSpeJlvBj/pj/L1wcRAtZakYVqf+04kmKzW8AkeU9rFc6mCRoTwXg32EPlPSyaj X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(451199021)(83380400001)(66574015)(2616005)(2906002)(38350700002)(38100700002)(66556008)(316002)(66946007)(478600001)(6486002)(41300700001)(4326008)(6506007)(26005)(186003)(1076003)(66476007)(52116002)(6512007)(110136005)(54906003)(36756003)(5660300002)(8936002)(8676002)(86362001)(6666004)(7416002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?TNyTuHz/3WHQBddZxngSoyACN826?= =?utf-8?q?V5nNqcWtT/aBDRcac07fvTB3aVdAqcjSPuUIgU82kR6PV2iMgNE2l62O6bxMvo/R4?= =?utf-8?q?4Q2iUc13VlhdlwRoAnBPNDTGuhGGllRUc744jCGVBFhx/EOvxaUZ65NwNJvXPnXeA?= =?utf-8?q?XTW4B4gBZ/Jg9uinjFc9U0nAPAdfRMvGP4qfoDbrOBaNBXh2/DSrIXrUUxZlwYqTf?= =?utf-8?q?uWrYlq06gkwpZoNaeV0uMHeSHVkwpiJ8RtX882RXP8R3in6MulKXqFlLYVfgjA9lr?= =?utf-8?q?8hTrCmoHt9w/S84tBkabxYna9M9oIc4nYFyOs8vtSF2m7I4dmctaJ/p6DOMOoJLQy?= =?utf-8?q?iF61qU+PPyZdtQ0hFwnxWkR8fyMkoWu9dJBB0O02b9saC3Vxz1iA+IoPJu1svins5?= =?utf-8?q?IeeEQ+rZdljoIQk1QoVZL9O8m+TKMbpaAiln7viEySoxWV44OghnnDen+KoUdjnH2?= =?utf-8?q?OEnqVd87cCkgtUthVbBDCo9mfAdv1vFdJMRe3aJN8lGhEEtrqgm7X8JhcZ8AhEKnX?= =?utf-8?q?vkoZpuvX9SPIl4HT1CFDif3wGpbYAeDtEj7Xs2h+G28sPe59QeH2yvJj9OMUeeFIO?= =?utf-8?q?GDJqO7aVg68xfO9QEjUGVjxtxYxEbtsujAC4moNhbVy5Xtyzhgbwc+sz3+zHYUY0F?= =?utf-8?q?tHhU7bR/676UdmxIWhUZTbTg/5RuYOvRdPHrEZOj2NHzYDjJBs7l3IT10cZfuH55D?= =?utf-8?q?LbsCWoLeAE22vSRum+F70mrpUoLXOlcIbT+pePwuGEma4YTRTPVtSuA5ZeYUuZbs+?= =?utf-8?q?+G63OmqVw1w6YH9Pb2iuiNwzQn/8uhrQPrvW0Pupsdq3KNDOb+wKJBrYj/pcUDsNp?= =?utf-8?q?1FOFoiHAkheYALN+NRNlPXpXVCHcXno0sH9rhcZC6IRJBS6o2HmIa5h0I96GF654j?= =?utf-8?q?XiJPmu/Ycl3Shgnv27reT1i7DtswuRLIJLnsjtAJK9SYQVjR9DUM5t0iKEZ/2cBcT?= =?utf-8?q?yFmmI95M73ipaRfsu1PKhIohCKOTqzyju1OZgXRTupOlbT3fga/y6fns1eG+r3hEj?= =?utf-8?q?t2pg6aZfzvhjr5IxQFziL9Bqf1nrpFMuWxzkuY46+TQ78rEmbxmx9DZ4/11QzH0kg?= =?utf-8?q?vTTFBptrZ8HOFLBZTgXIPAtzovfHwXNoBSFt0K5on9jrTbNvc+9uaTrmqdwFN3SIC?= =?utf-8?q?KfBN8nripuuO1XioOGOeGYI1sBh4SZ9yvZk4Ukw7pwwKOkJgwgF3e0a5hlZx2QoFq?= =?utf-8?q?ZDX2hLsHFBfxexUW87pzKw8EWKjIEkFzWT2R62yC1PJf2cEe8SVZ5iouGxtesQaVR?= =?utf-8?q?t67R2JYRChdJExqREm+PubW/reXIeqYpOjgNNV7bvaG4EX8keCp8FPOU8pXN99oSD?= =?utf-8?q?DizNjFrqvmR0/AQDggJ6IZRwOgFcKYeD8hqiC3cbuFTv9dcdbFjVo07tqIan5j+Qw?= =?utf-8?q?tu0LoEfllkNT26Hx2F4JOKUkvjx4l34BLcvgdZC0XmExzwn0UpnazQW5v/93P47VX?= =?utf-8?q?gku/wXC4HLg7+woSZ4wI7p8Sji1VqA1s8rdQyMABuXr+Uhk7FMmoEsh4z/GDRqA+Y?= =?utf-8?q?0ILr4YqJ8UCL?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4def374d-d1b1-4a65-af29-08db89cf6eae X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:47:01.2807 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /gmYkR8dc9XF+qesatesHwZSGh2apvo7BaSLgRH+a0142eBL24znHvbuOSvRPGllviWQSR5vnZs2BBlXF7VYUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6789 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772023668614792833 X-GMAIL-MSGID: 1772023668614792833 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Acked-by: Miquel Raynal --- drivers/thermal/armada_thermal.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c index 9f6dc4fc9112..b7f549b6f825 100644 --- a/drivers/thermal/armada_thermal.c +++ b/drivers/thermal/armada_thermal.c @@ -913,15 +913,12 @@ static int armada_thermal_probe(struct platform_device *pdev) /* The overheat interrupt feature is not mandatory */ if (irq > 0) { - ret = devm_request_threaded_irq(&pdev->dev, irq, - armada_overheat_isr, - armada_overheat_isr_thread, - 0, NULL, priv); - if (ret) { - dev_err(&pdev->dev, "Cannot request threaded IRQ %d\n", - irq); + ret = devm_request_threaded_irq_probe(&pdev->dev, irq, + armada_overheat_isr, + armada_overheat_isr_thread, + 0, NULL, priv, NULL); + if (ret) return ret; - } } /* From patchwork Fri Jul 21 09:46:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123743 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp101015vqg; Fri, 21 Jul 2023 03:16:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlHvFSyZtQQDfOTOf+kZ9QnAk9t6sTqJsxM5afxDWDrO4zM3fkhSGv5ORkxO3GNgiqgE4w6G X-Received: by 2002:a05:6a20:9694:b0:137:63fa:2a17 with SMTP id hp20-20020a056a20969400b0013763fa2a17mr1314749pzc.12.1689934568647; Fri, 21 Jul 2023 03:16:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689934568; cv=pass; d=google.com; s=arc-20160816; b=yO7/EUifmftVWN+oKatJcPWQ5m4xBDTcohAFOqAHhqestYZsGSX/CCRjCpnqyH59Pi rrzQ5nq0rSJTw9VAkE7htQM9vfydfRmNPkpT2h/xCM2Ql6HCh7MuYk+EDtuLxtcDuxGP 6+yPGB8QhAdA8jHUopJJmOTvk0nHBAmgtMAzSEJLmOHFfbD/qZPQvpvwCjGFAH7pX3FQ E+d1yBPjLPDDuBmRnxqsKpRsO0joEpuuNBKDro14VkpD+M7H6vcVYDNdFqK3RNr8fuze aBXZ4C6/8OdY/SgPx/cRT3aZv7IoQ6jfmUnc5uNmiD5sP1JXQ0V4rvCpQ1enFdMj3eDj Ra6Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=OjfxK/rG41MW8xIM0n4h07DdTRX37piixiXYncIAkj4=; fh=fADlBFm3z5Kl1epeHwX5HN7QoBU/RjTs6Acse9/Zu2Q=; b=WxDzGzP6TJ2VgGRFm3gMyZd6MUVbMiNaG1C1DA/Tdsy+TI6mzfLjfHPhcua2IouW3P pRqISDtM10W6XEK/elx3K6OkChfun6h9PWjm7lBVoC053wctbhBR0pP/a2uMhfNWiA/z nPIwFuPE9SIKpF5G7Io/m6N/z/wfrScrJoiTan/mm2+2tnM6ePeKIpq5MXzxCvcHrqxx fd3XeVcpbZvwVm5sX3HgaQdvjU4S1M23brnn/3YnyMYcYxje2WtJ2N+fo8t+H04A1VDH Vv+eTWaQfKeQN3mQfD2SLvCj1vrJptz/EoOkWp0iuXaBcFtLV0d9tTDXe61T5dwFpUP1 6WNw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=e+8GAP9D; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cn11-20020a056a00340b00b006827c671c1asi2686923pfb.226.2023.07.21.03.15.55; Fri, 21 Jul 2023 03:16:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=e+8GAP9D; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231783AbjGUJrT (ORCPT + 99 others); Fri, 21 Jul 2023 05:47:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231555AbjGUJrK (ORCPT ); Fri, 21 Jul 2023 05:47:10 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2095.outbound.protection.outlook.com [40.107.215.95]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 871D4270F; Fri, 21 Jul 2023 02:47:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kDXd/CPMirmrO+1y5VAH2c7LX0EU8LQnpp8FpQH3y9WwiHimci7yC0RbSqvnTuGIiFEhQSBvZLUQJSIVCgsXnfAScACyWDuRD4+pO+dteVkbFARD+BM+MMk9a6MuUj9t57K45qO7ec0kqhk5s4LO6DEpdQGqj6AJlsGYuz0B16Za4aKKz8HLMyfHjTR5XC1/T3LsnAdxDQxQ4grpfkmP5zh4SS7L/ZbOkM70LfFU6zhbuRaoo220LX+b6oriZ32aTODsrDMK3ijb5EYbBejQSMt/vPQyAbGA2J5JeFxB+cFe8+oZA8V9jEmB8UWaLmF6vn+jRC8/XdeO3ANQmIlRsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OjfxK/rG41MW8xIM0n4h07DdTRX37piixiXYncIAkj4=; b=Ne6nVZOisOBoZ1H7/Yag2haTWq5quNDobNRcL1NAGihZCdvsT10TcGvviGGYkQeHLJvJCBroDRWlWBdMNob6OT81vC0rscl7txGcIn4PaqyHCvkhtmHio4fv2jGpt5tDQqmr0bW/N/Oj1YN5LinOHsC5gO49OSICu3SJMD5hxyaXGdFEhuw01Wn9Z/2BFY3RfbcR+l2B61xZzChpCDPR2yg5EHK3N+qxqA38TBzK2xDsCWoQ3bujH4IZTijBfrWprjaS1dCMNM2+FlCOTgiCSRhzrbtfUNhRLR77Tmu05kllfFq4iPUAywoR3QXZ5f/pU+2moUqr7Lx9/0/0mbyezQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OjfxK/rG41MW8xIM0n4h07DdTRX37piixiXYncIAkj4=; b=e+8GAP9DxQENM00UXpAQWRd2hHCR5SqBmD+Iwc9E1ooecbqOKto43uVdUfAUsaVWzGJ+NuAl/1sJowUoWF0UrRifOckhp0yQr/1YR4LGVs+15fDGzvcG348evNFz8n12PS5J6Bhn9waG3EYBRrC8OqsQGzKb5WTLouWTt601J1smK3IMxM+o9i9d9U8m7yb5AgPnSzVn86JT9Fe9KeotI3Uv/RIRXMOB5KUn6GEylabPUiXoMX2wRZF31X1LEKuj/xPzyn2EYT/vPTcAyiWZn0JUjEfpNHvlpDZ/jWei+Fo3ux6fTO2YUivw6fb+5GHnPj8hL/foTcY7g1c88Tfdrw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR06MB6789.apcprd06.prod.outlook.com (2603:1096:820:ff::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Fri, 21 Jul 2023 09:47:04 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:47:04 +0000 From: Yangtao Li To: Markus Mayer , Broadcom internal kernel review list , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Florian Fainelli Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 04/22] thermal/drivers/broadcom: convert to use devm_request*_irq_probe() Date: Fri, 21 Jul 2023 17:46:23 +0800 Message-Id: <20230721094641.77189-4-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230721094641.77189-1-frank.li@vivo.com> References: <20230721094641.77189-1-frank.li@vivo.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR06MB6789:EE_ X-MS-Office365-Filtering-Correlation-Id: 251298ff-5de7-4960-2ff5-08db89cf70af X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: csWfH3CDlS4Q/rOIrUoJlYR/FVBebOJJXmnfcteUKGJDSOXklyrRmk46RVkT95zga50fuLc/4+v7k5L2/FVvTQQjnnO+jXFO/8CgjnbqNwmTzXOrzCDyDWk6J5GXtupBPbW0e9kqH7UHBBQ/TDVmaKM3htdIiZ9GTd6FTG78OjQXXJ2j/k8JHAWz/xpc2TsMefVwrXcRiSNwrgsPqJq53ATcgCqR1xmbHGeJ1g+nGCzLCIfRQC2YX4gwSeGljdvagMe+KIHXAGES4XUoLQyj0N9WhdY5eGUhUDx+28gTuU49pODQihOuLdbMDPlWRLVwnas2WSuFw5Pc/Ar4ZDiQGsrs6kAsbF+sSEKj4M8Xl12FUKLDqcD3tc+lHCSJfB54SFRww8P7XWHRpVUr/AkOEMPbKhiPkqiI7wF9PKL6keFaOZzo68IJN+7L9bgOn6Kz7jQZ62wt2vFI+Wy8uSWPKaD/oi9NdXyp8sr5vZdj9VtkdWe2ihvsY0YNAtuGPinlj+qY87BRxVtmNbufUJw7qD+4ViLGRuq/rsnJ0Lf96Ty6JnIP/MQBe5KQk9Pid4sfZ+XABTHEB6iArmlcWaI9Tanf1nfBbVMAucn/NWIPYIUbeONe+wMPEZCE5UVk3cLR X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(451199021)(83380400001)(66574015)(2616005)(2906002)(38350700002)(38100700002)(66556008)(316002)(66946007)(478600001)(6486002)(41300700001)(4326008)(6506007)(26005)(186003)(1076003)(66476007)(52116002)(6512007)(110136005)(54906003)(36756003)(5660300002)(8936002)(8676002)(86362001)(6666004)(7416002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?pcJz+DlOsLYTMO72BSk1oiS1D3YY?= =?utf-8?q?Z61GcCQs2Rd63SS749EOiia/vlYnBbAj/2mB+GVksLEhhmYYo+JHRlZPenSpWNQ+o?= =?utf-8?q?ey/PHiYrGrCE5T8ci7kzcuS/eToWpwVl0u3+UC9kz89s9gE/ROPZtxBULWiCfUKIG?= =?utf-8?q?CHr4V8SqXiGafzosm/ZefQtZ81KfkBfDFJ6UvG9WrrGFbvPQ/wfqzUqnskhI9jm7f?= =?utf-8?q?4/sR3D9JfLa/WeAiYe4PINsIBmmvKSEONkmOjGmalZ/65B5NF2POw6j1rk3sZBP4f?= =?utf-8?q?09KWNIIKuoDGPw+a6chhcoeo6eO0kQrCmx/lO0ah4aBXUwX/i1SI9jbtbdlOUtgKY?= =?utf-8?q?Cny6YYNrsBMCl0/+c+3eZ2Nkq3HCGUkAw+BxkZmS6q5Z/9ZDvL1ql45b3jaXRbbYV?= =?utf-8?q?wnSEl4R/svvConOMispxuvzvXCzEmBSq0FZEP8PTJspiDJ0QZSrgyrpycET56KzBq?= =?utf-8?q?SyUTY3CBx8E7YzzJv6YRA2V37G+exhVcLrGt3tvrg+OlSyHeusDbBNp1ziluOgGTX?= =?utf-8?q?WQ9AcDcFHYyeu+g1+5G7OKdSXdYPmlXG8RHXxvv0TlPEh5QdSJAArXd36ASUsK49x?= =?utf-8?q?uQljoDS2VDu1K4CV9rbPLfoiLRwZhpn0JMYwTCvht2AHhJ3NcKEjOKICa9vHuicA0?= =?utf-8?q?XWW0MgEJ31c8MZKFq+DxgWWy9abdZCfSBoJDY7AJwM8IBd9JIhObrRk9O0MK3vSPh?= =?utf-8?q?v4L1e5/e1RfFWFoiWaDaQ2MjumQwyOafjjMvYS3RetyaYeOjvHVfnfyCZjaZbTnwc?= =?utf-8?q?uvI+fJCh/EawL9mSSzAkD9FUNaLquYr2ZkVp4pUMbbGlw3fSy9POannw5OEqpMwnv?= =?utf-8?q?herJcL35nhfNLNuybl1kRr6EApUpI+YhKr6YO4v4pc+lmVBKRGvVzSzGjB+bYwHY7?= =?utf-8?q?XDS3BoNnYhkjVQdAgX2wShWLrS1Wpt1EDYWS43zdajv/dX4WLOljSOjXW5r+xQLjZ?= =?utf-8?q?o52HPhiNSyA0a1RtELwE3/nRVKctQf6Vv5QBgxSkLZzu5KjU6lVV9CIEU4kORvUkR?= =?utf-8?q?5WPDKQZ4muPkq8heP+oL6hxqVg2cgnjMJMoVVGK+NsktrNOgK9r2dRGKzz5m46eiT?= =?utf-8?q?A4sgX8C8gl4K34b/d2ylMo69KjWmaF/WvLLCFFezEZPAE7Mjg/8v2jSmF00XLhi31?= =?utf-8?q?fr3iXGlyJI8flBrlNrcBnRc/WXnBfH+KGElwEfK8fMcLTfLW9ZWAUgV1eZNotoCvr?= =?utf-8?q?c+bznapA/6rEu3pDlD3HhWYFVjCdfMKKLE3xRg/9AsPt7QHIDkcqzqJ4A7p4xkzP1?= =?utf-8?q?ozu0nNdRhPRM3pLZY5iSjfU81aPpX7VxRx/k32cpMGF5lajZtJGwtdei+BhBsd7y6?= =?utf-8?q?aMzp01fpKzZLCbfl6LfSo4iwqqL+nTNysCdOPeId3+p1LGNLCAx/GMQyIDwktRr00?= =?utf-8?q?HkT9E/kE8hoTRwGNTsDrTGtG1HeUWiuC6oHkmN0Bpp/+3mRIzU01ROZ9RduehVUIc?= =?utf-8?q?3CD6pkLCkNLUVwFA5FMPyHwjos9t5sBRGfX3hp+9NRM4YhLBYdncHo8+CrujAL8fu?= =?utf-8?q?1EOa/9P5d/Bl?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 251298ff-5de7-4960-2ff5-08db89cf70af X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:47:04.6538 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TaILFn6eWtfhLoaQNiFFPimwnJpDkxzmQwFeY95M72/kvVNlMg30+EDAdO2nqaK2gxIVpSLc89Kz1oDPN+C3kQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6789 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772024830317877956 X-GMAIL-MSGID: 1772024830317877956 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li --- drivers/thermal/broadcom/brcmstb_thermal.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c index 72d1dbe60b8f..ea37e7ee688a 100644 --- a/drivers/thermal/broadcom/brcmstb_thermal.c +++ b/drivers/thermal/broadcom/brcmstb_thermal.c @@ -349,14 +349,12 @@ static int brcmstb_thermal_probe(struct platform_device *pdev) irq = platform_get_irq_optional(pdev, 0); if (irq >= 0) { - ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, - brcmstb_tmon_irq_thread, - IRQF_ONESHOT, - DRV_NAME, priv); - if (ret < 0) { - dev_err(&pdev->dev, "could not request IRQ: %d\n", ret); + ret = devm_request_threaded_irq_probe(&pdev->dev, irq, NULL, + brcmstb_tmon_irq_thread, + IRQF_ONESHOT, + DRV_NAME, priv, NULL); + if (ret < 0) return ret; - } } dev_info(&pdev->dev, "registered AVS TMON of-sensor driver\n"); From patchwork Fri Jul 21 09:46:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123736 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp100497vqg; Fri, 21 Jul 2023 03:15:07 -0700 (PDT) X-Google-Smtp-Source: APBJJlFvPF++pg5gwAdHeIXgMu+Cx9cba38COjwr8ZDoDp9zfDZLn7u3iFGZ6p+WRjsJM7ad/iCV X-Received: by 2002:a05:6512:3d86:b0:4fb:8616:7a03 with SMTP id k6-20020a0565123d8600b004fb86167a03mr1237162lfv.4.1689934507511; Fri, 21 Jul 2023 03:15:07 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689934507; cv=pass; d=google.com; s=arc-20160816; b=uWKWx1Gvbukwq8h0+wg0h40J0mz/MEoQr3m4TUpnwy22qoijEoY4N2HpKLeEVAB5nW gedwoNF5LmHIhLuO7tjbSqZGjsSh0M0qxDcZhdzvMUJbVrOMqhvXgNYmKItwVaSCKea/ L10ojQfITVZUzkNfHwb591IKwiPNk23CVMAYojzfn+QuslZj7ICmEfRpdxOI3qo8Auf/ xOsrFdbv8oGgRbygbSxCutrGZL4BkfATnpR9C83S+ZuEMuizNzIKAc8E3DlifvtFUAkH HyqWJMd28LrLeE/Yo8R1Pp5xAEdU42jnxRBqy9e0TgM8fV4bWjN2HJC4PTH00G+p/Z9/ i0rw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=iZN/WFcRaP+9FH5BrXgS8aXZCGQPSUC13FV+qNWDPYY=; fh=rOCi8f4S9lgt8FYmciyOdpqeSC132hytSY0T3bZgXro=; b=Ajiao0ou/0kNt5Bo2+F7Ya6iO+UzpzMxL3iGC6/wIDNZkCPKikLCT7RSAJNQuF2ioz qXrDmAHS/pbwnTBSvzbsirgtbvgQkMMk+BmTsloi4cLBBhS2X0O1Urizr8bc1M8b68xd l4F8EbaQf70Zt5eGD0IeTPfyf0S3LO3LX9TU4ZZD2yRsfwPn95UxDQhHcJvJuolPTdQ6 5uYvUDeaiN+kmDj9PZVUAK4s6168fmx9EY7B8zahhV/1Uw4fVKCeGKV/JMoDVFzHg+cE 20D1a9ZFLFEz+jGTUg/UKCMF7Q7Ed1XfhJaFKF2rFqKBcJUEf1gkVG2BTe1lx02q8WKE OTlw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=ep9CqEnu; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f2-20020aa7d842000000b0051e10e83750si2067941eds.294.2023.07.21.03.14.43; Fri, 21 Jul 2023 03:15:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=ep9CqEnu; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231608AbjGUJrX (ORCPT + 99 others); Fri, 21 Jul 2023 05:47:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231696AbjGUJrM (ORCPT ); Fri, 21 Jul 2023 05:47:12 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2095.outbound.protection.outlook.com [40.107.215.95]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8ED6121; Fri, 21 Jul 2023 02:47:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BlBnFID395hIWZq+tA4uOukFYY/FkZlzQBu5zT7tVw753PX1Mhl8sSR3dBx/RVzpGiYjD2rWZ+NBEX3quNO6+rWlNUOEgYsnWHL4m2gMVolNw6WAdgzRkp4v94eTV/T9RIscjE9vNxDAFKUC7Ci6m3uskBfqF4qvLoBPukAAXHg+Y6cwAnOe46Xul3XbkmEW1u+rNRyQ1ICKvrQp/d11Fjs09F+OZyH++eAMAAVoLccJKM623qD92AxNoryJ8uSCVsTH/AuApHEf4V8tK7tqfDh6jWwEnh4VL7HRkdaOHJJ6dJ/sk8sWn/DmIJzedjZetO1b9GMx8BVKOhxMkpnmSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iZN/WFcRaP+9FH5BrXgS8aXZCGQPSUC13FV+qNWDPYY=; b=U8uyrTNEWl0DaPNn1ufB8CWc2L1LtbjtMJs1Oco2c3tsmVq/EYJHqWUf3nBX99nblJcrMcfHZrypNlG5jllH+9O2MA8Y/uRjri7FnaOd3DpJuIrLn38p4SlkIOHIfabQ6Q5cNziRNjl2O9dtYw9XeOmyT+sfcmZdqyUyrHX2dNLuBhXTQVRECdfW7M/fmLXZe07HGcH+X+nz3+edIMP8S3771Jh+dvh/UI9gKLMYcvdYZd/MUYX5FEjMvW3w4ebUiL1nQoDqVV7kU7uKTmHJ1UZLC8HtgJwS1YJSHEOMvlTmmOT5Y1jY/KTErdyvRxcPi1Bx12M03+m+doTRMCzrbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iZN/WFcRaP+9FH5BrXgS8aXZCGQPSUC13FV+qNWDPYY=; b=ep9CqEnu0mGdkvWCRjA9ppnKJJ/8RruH02IhFwNlq2QTGBI7i9rSHhrOkwKqyvg8cQaX25hxUHUiOA7WFPZjQJYL3DBufGquc//l6ErW5DPjiMHsayg18MnmFWUL/yPYx8k/e5oE9Dh67mhpn5qoEvEWPbMZpED4JsIGD3QNtELTiQd/lratoa4uPZQRg4/WMVx4pmGcK9NmruLkH3pLgKa57AYYKWFnW11azTwz1IfbI87vUohoIf5EIPxtUbpj7zuUDPpFQ7M1rj/+JhOTWkak33ZEr+vmSfVfd859CHvvJAZWU4PIdW0r6XrTNTHHNlHe1mn1Jd54rwFiJjsLCA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR06MB6789.apcprd06.prod.outlook.com (2603:1096:820:ff::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Fri, 21 Jul 2023 09:47:07 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:47:07 +0000 From: Yangtao Li To: "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Thierry Reding , Jonathan Hunter Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , Thierry Reding , linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 05/22] thermal/drivers/tegra: convert to use devm_request*_irq_probe() Date: Fri, 21 Jul 2023 17:46:24 +0800 Message-Id: <20230721094641.77189-5-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230721094641.77189-1-frank.li@vivo.com> References: <20230721094641.77189-1-frank.li@vivo.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR06MB6789:EE_ X-MS-Office365-Filtering-Correlation-Id: 8586879e-d2ef-4691-cb8d-08db89cf7265 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N1R/WRYUXWBRTlE/G6rI4oDPrXXitKWVveITneUu59A89PbAwXLRDrsboXQb5ia+kPWCK7OCn8eKoxNNciLT88c/jwRpVRMKqdGH/lN1RJ2Y28Hl/oZ7YnpCqDR7Eq4PPwYNb15x1Inna9Dc3QBYy0wTmlkIkMroaMNxD9LghV4+sR6qoJYp/ov8FB3y/GBoduKl2spiMtozsG8s8XlKgGM/DR1Ujx6PQ4tiv2UnMvuqxGNpX0yGcgjLIVATPvRBrRGa5F54oMLrDm9pHM9f6qrFHWIi2m2LtNTTKtFnLpITIlSGaJoMo7fupW2hZalF6wDoFd2UxpSBtT1iVsfBW9R5BWv0mD57WJtFaiuMp/oOdGKm3fLBPpzQkmHsMis5umpPahRj4YBvuuOs62f/2EJH7PiosOl95mGXvrzjmxl4LYsi6l0VLObTcE5/Dpzm6jAYhBJz2K6lHBCZg6I/82EKZ5yCvP5w2tv2Yl+jpO7X+avFfTtb63+7/wwagj1ppL7IxzzHNkhPYZk/Fzc3BX0tbsfGff+wJfXU0R+eFXR2bSF2p/ImBYtFfAkHCPRvWoAHtVn1FvJ/uueRVrP7MQIqPMisoAdT/TbIsMM2H+UakNfkZpSedeFJ3pCRvAhH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(451199021)(83380400001)(66574015)(2616005)(2906002)(38350700002)(38100700002)(66556008)(316002)(66946007)(478600001)(6486002)(41300700001)(4326008)(6506007)(26005)(186003)(1076003)(66476007)(52116002)(6512007)(110136005)(54906003)(36756003)(5660300002)(8936002)(8676002)(86362001)(6666004)(7416002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?1ofWZt24utouz97Lh3DZE3SAEQ2D?= =?utf-8?q?hjX30ks2EC0HBzKCQT0OYpTNhDnrx2eDrie9jGdw66j4s35YdHoPYwpMQmnQDxOiG?= =?utf-8?q?IQmA9Fb1l+jAXFklIzU8jkVTyCIt1NNYPlyIc6VH7PyaAlgorTgy9C/Kb/3cAfnxG?= =?utf-8?q?rdYM6Xuq6owng3DTl4AAQdVPHOm/p97tj1sUirc3GuH68sD1aOZoEDeIrDAOmCl81?= =?utf-8?q?gsHnDJf6uf7OgtZxEbvbSUKKNsw8OJ7XlJOqYlBexgAzkwJdYuTIk5igS4TtsHJ5h?= =?utf-8?q?+7IRkB4QFhFz/jIGPT1fZaQtCM4ggqfQSqwz2RlxZVCQJ6NlzwSBcZH1TuKw5+Nu7?= =?utf-8?q?ywDxnipdxmzph9BDjgq2zCd91G2mvtVpiE/FEfAkjUWYtQVfjgmIOB1kqOiLVE/gN?= =?utf-8?q?P24v8fe77g+kceVWI4dSq/h/fn4qQ5K002th/CgSfzKM0AuQjlN3hoYbG98f5JJI9?= =?utf-8?q?XdhZzVe2L5lLRvDIpaglXcHAB84bGF+lDviYgux/r5LHauqPhN3lu9SLpxziOhl3Q?= =?utf-8?q?/DLqmHmm46ArqP4e0lAn83Bvcp6NKGX5c7gLntXSxqcN9evVh4i06gWBkFCRSXeeY?= =?utf-8?q?o2IULZnn5/18E9DFanEmgfXQUzDLUeYmlGPbJ7E6lUIf/nfVcusp2KjrVVg7uO+WV?= =?utf-8?q?vB09mgr80D8vWoMhwI98wrkpDTeZZs1JXtThLVii8w812s5Zu487lj1NbfUHDDrSU?= =?utf-8?q?4u4mfJQtkngQhxgFsCurvJbVR7srjztF3JOVrj9boHHdmEnxOv+zhQdCmthCqbI0p?= =?utf-8?q?6zz2XWyKZhahRmDY/R0PhEOB8P5TEjjZ47irgIenuFnNs/NU6bRzH3KabspkJ8oWL?= =?utf-8?q?xVhoB7leptjj3mSv01ts3ude2f9uB5rEQ07MJ34gpQbqU5l8LdITXjHMf/iRietpL?= =?utf-8?q?/rSGvehdkmCqh8jfFL/UaFFY1PEoCBHHo45Is1dHSAjX8QKMk1mchF8mswtvYFTxW?= =?utf-8?q?MtmIyibez02RGhTYV5Qea1TLMsv6Cq5x56FhXvq5LkNGfYIWxj2dnoDDmEL8r1p8f?= =?utf-8?q?cTYOq4y162e4zTDSAd1caUs2O5GstXwVvY1+y/g1qhnNcaeb44H7xymDHfA9aijuA?= =?utf-8?q?oyBeGl3WLPwTwoS/Il6M1gJkctqW7L4UmydnWpVMKIGM67enW2FLyWFOzR4JzeehX?= =?utf-8?q?XeP/6vYcsm5++T+vFYdSt7AVsaP9g6jPwKN3i2VWaK1cTlfXIW8nmVkYkonLWKKYz?= =?utf-8?q?TjHLBSgPLYhyt7IrC995nTH3Jcr24blBo4RLJvjvnevQL+HgH1Pp7WufVz9EH37v9?= =?utf-8?q?ZW2JDZoTU1aemmjfJ/Kn0094v1TsBfzUe7sEa+jKKUa3CSMrHcVdpfHzsUqK4hP4e?= =?utf-8?q?wYCHOkIGkgDuV6aFHwh4Ti6QCirF34YEmaRyWYTY1TJdYC4enxyrcfO95zTP2uptD?= =?utf-8?q?B4VQZ111ttLm8+lO3oAflfxfBAnpUEZ5x54cIHqSGXpxC5GDOauUpJNC2bHTPGMOT?= =?utf-8?q?4PtmyoLj15hmDcCGbaFvtUoZy7EvZLX1g3NzEvx8Us1YMXn1w9Ua1Z6Ao4G0v5Wet?= =?utf-8?q?W/2nDd9jK8DV?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8586879e-d2ef-4691-cb8d-08db89cf7265 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:47:07.4997 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wNW3TPwwtEjDrm5Rz4FYU65osTkUsFpEgq9VpYL5lhx99qUiQhIr9x+rwn/fyMoruybFom/egyYNNbnF3KJsDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6789 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772024765987207875 X-GMAIL-MSGID: 1772024765987207875 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Acked-by: Thierry Reding --- drivers/thermal/tegra/soctherm.c | 38 ++++++++++++------------- drivers/thermal/tegra/tegra30-tsensor.c | 9 +++--- 2 files changed, 22 insertions(+), 25 deletions(-) diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c index ea66cba09e56..3d144377d90a 100644 --- a/drivers/thermal/tegra/soctherm.c +++ b/drivers/thermal/tegra/soctherm.c @@ -1993,29 +1993,27 @@ static int soctherm_interrupts_init(struct platform_device *pdev, return 0; } - ret = devm_request_threaded_irq(&pdev->dev, - tegra->thermal_irq, - soctherm_thermal_isr, - soctherm_thermal_isr_thread, - IRQF_ONESHOT, - dev_name(&pdev->dev), - tegra); - if (ret < 0) { - dev_err(&pdev->dev, "request_irq 'thermal_irq' failed.\n"); + ret = devm_request_threaded_irq_probe(&pdev->dev, + tegra->thermal_irq, + soctherm_thermal_isr, + soctherm_thermal_isr_thread, + IRQF_ONESHOT, + dev_name(&pdev->dev), + tegra, + "thermal_irq"); + if (ret < 0) return ret; - } - ret = devm_request_threaded_irq(&pdev->dev, - tegra->edp_irq, - soctherm_edp_isr, - soctherm_edp_isr_thread, - IRQF_ONESHOT, - "soctherm_edp", - tegra); - if (ret < 0) { - dev_err(&pdev->dev, "request_irq 'edp_irq' failed.\n"); + ret = devm_request_threaded_irq_probe(&pdev->dev, + tegra->edp_irq, + soctherm_edp_isr, + soctherm_edp_isr_thread, + IRQF_ONESHOT, + "soctherm_edp", + tegra, + "edp_irq"); + if (ret < 0) return ret; - } return 0; } diff --git a/drivers/thermal/tegra/tegra30-tsensor.c b/drivers/thermal/tegra/tegra30-tsensor.c index c243e9d76d3c..dd4c2deba93a 100644 --- a/drivers/thermal/tegra/tegra30-tsensor.c +++ b/drivers/thermal/tegra/tegra30-tsensor.c @@ -593,12 +593,11 @@ static int tegra_tsensor_probe(struct platform_device *pdev) return err; } - err = devm_request_threaded_irq(&pdev->dev, irq, NULL, - tegra_tsensor_isr, IRQF_ONESHOT, - "tegra_tsensor", ts); + err = devm_request_threaded_irq_probe(&pdev->dev, irq, NULL, + tegra_tsensor_isr, IRQF_ONESHOT, + "tegra_tsensor", ts, NULL); if (err) - return dev_err_probe(&pdev->dev, err, - "failed to request interrupt\n"); + return err; return 0; } From patchwork Fri Jul 21 09:46:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123733 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp100131vqg; Fri, 21 Jul 2023 03:14:27 -0700 (PDT) X-Google-Smtp-Source: APBJJlE1zF4M/VVriY5RMHrO//OiyRJrnJQYtwyeuqeURlCrlL/NRfCoZg7LU+9rLqnC270RObi0 X-Received: by 2002:a17:906:8a54:b0:999:80cf:82fd with SMTP id gx20-20020a1709068a5400b0099980cf82fdmr1364083ejc.18.1689934466583; Fri, 21 Jul 2023 03:14:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689934466; cv=pass; d=google.com; s=arc-20160816; b=SK6dlGA+E7RrVMaBCXqMOfTVvrKibicZGWPJOOluUMcCj30bhLFhL7sNgHH08jHWB5 SDNXdhTlAcXahRSzrFCbHZ8me6xfhmq4DLuXY4Nenu+/r64IwtaGc6hn/bTfY9AmnLgI lx28bXIuX/kbyXVRSZMBfd60Tc51c1/5pBFn2uusFMivrLRfpP2Jytqj3gsEFop8mLe1 yz+jCxNFLuUEkZfZK/35y29q7YC4Pzj/Q6vVom8aUcV5BUL/yIX3VH/cQ1kxtr2cT7qp jsLYRJOAckJBwe4xJt+glmHXssVgj9tWgip6S2zwILWojnVwmk33eaQNSnr2U7tS6wgM 71gw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=OEGCtasWCOSsSknQ0GZz9Yd5JlWw//E0x5dPjE1KYLQ=; fh=YO7dzwI6zK8jP/zWXotBHy3qgCoa1CXMYZZpgV202FY=; b=gpC2s9z17E0FcJmEMP+cXjAE3EMjA4SqoWnXEDnUsOk4ZX+N2jMXcxA2mi4HijVn9U XWV2zccn+K/rWcG6PqOSQTBcm1IhSMRMZlm1u5bApIUqDziBS7qTQisG0vZnI2vRWJOM oqAnj5YsF3tCoM3sSM6rwRk1PhT+ix2DqgiZpEwC4Fd0gb2haHd7d1RmMWsM+c6wAez1 W6IvGJpE8aV1aDheWD8jVkKaXPfQDemvH825Gplh55MnW/b2NWoAqUO+bwgjokmySvtp +sJlcVRlb4VWRxbnwJG2S+vaJ1uGedzQdcCCY/ggKGKNtItmyqXF9Kt8srh60f4uiIH7 28Pw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=fx4kYkOZ; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kd26-20020a17090798da00b009888ce5d3d4si1856800ejc.436.2023.07.21.03.14.02; Fri, 21 Jul 2023 03:14:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=fx4kYkOZ; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231833AbjGUJrp (ORCPT + 99 others); Fri, 21 Jul 2023 05:47:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231804AbjGUJrV (ORCPT ); Fri, 21 Jul 2023 05:47:21 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2095.outbound.protection.outlook.com [40.107.215.95]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 130E030C7; Fri, 21 Jul 2023 02:47:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U2eNIq/WnazaKQTWORgJO/oL1lSpSx2MFwpQAo9l65CzMaNqeW/ASQBvC1VmU1UqUD1xGgJjWf5KZ3I6cvJRg9NzRg6V7vj25Tzn78ZfSBW/2ozUYNXgzfT4+WFnUwtZtL/gHmmfpuBozkSFaOvYhrEvDPXYn0YLt0jeCO1Qot1KE/jrmO6GSPW7IjOxwn8sAXvzlOvTMXoiD/vXox8ybA0z6xCJk+TukGCgjiXDkj2a6f3r2wxPLRkGOXv9FKvqXwg33BkNLOzRvQ1rPj4M4X1XBtHRUX6WWzI04SXFSANYlDWUokgHLGGjtu/9oYlcvFx9s1kK49ZzIkaCG6ujaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OEGCtasWCOSsSknQ0GZz9Yd5JlWw//E0x5dPjE1KYLQ=; b=VPS+cy1up6OuFUufLm1kbZcGcWk5jNiIrrT3Q2ucD4LbpxqV8m4pSwxBDa7EhbhF9zmwqPTVK8jYqrt1KiFjf71yn13A55zMOn6Kt80bszEtHbRZTtKQs6Tcll/g5fqaOTtcEDPIecY0knAfkd8T2S0YyCFs1/m/hfs6oodzp5aUna1CCM6y+NG3TkwDUhPfTSJBo208idz7yzMuMU2TrKHIjyp5rVbC3r3J7Rn47VsF1nglQuGSIaEAsvXCrm3XfbyLcUrQ6U5/kSZeuD5HA01Jc+kJzzqtU77Mq++9jwTAascsFZ6YZOR05mQizrssQHKsshZB3tH6M0czKQ0iNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OEGCtasWCOSsSknQ0GZz9Yd5JlWw//E0x5dPjE1KYLQ=; b=fx4kYkOZifPa/0KlMBxDl7LwrtimndrdTnyiS8ZtcIF5wk0kxVUDJVCrWTt3QHCucbVjsGXwNSaBOa80OK4SBoqS9EybEFT23Dagn/ZMC7Mnyb1MkYyBVo47vo65SQ0Nf0NJfgBl12u2FZ8bMc3ZT0C+8iCqtpeIL+RM4IZV1+pAFKEMKduUOOCsVZfKQFPqCvgDxFGAtlXQMFxxpxJ5C60ill9GX8H1DccTlkCFdTrTV+DGCS2IvMJ9Xytj6lg7XsZXXa81WB+Gvij0c1ZzbTpoimB9wlqynisDfaUu+QmU2+L83N30XT8fiEYE4RgPCfKhZMSjkobUaMcbyTwigA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR06MB6789.apcprd06.prod.outlook.com (2603:1096:820:ff::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Fri, 21 Jul 2023 09:47:10 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:47:10 +0000 From: Yangtao Li To: Amit Kucheria , Thara Gopinath , Andy Gross , Bjorn Andersson , Konrad Dybcio , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 06/22] thermal/drivers/qcom/lmh: convert to use devm_request*_irq_probe() Date: Fri, 21 Jul 2023 17:46:25 +0800 Message-Id: <20230721094641.77189-6-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230721094641.77189-1-frank.li@vivo.com> References: <20230721094641.77189-1-frank.li@vivo.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR06MB6789:EE_ X-MS-Office365-Filtering-Correlation-Id: 1c826e84-7bc9-4cb9-1992-08db89cf740e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mnMlm9bGtj/jWhIWppXFpAYUjCvwFErB2VVBRYGpvizB/QDSW7KCJVq3bf1lyMexkdpxr7Bcbq3crRWn/wc6BUxjFdkZBMPExb84Lm+Awoz11AcVxUb72STe1N4Lgf/XtcgjT4TJ4uB7vZ/duw96cKYPdWNPoriBXbO5mxwkzScUsKl0lpZhtwOzmQihLpdQqujN12Ae3FvyjA7q5xoTHroEHs1Xk5NbLLNPDpmq7VDHDxdKbNO7B3JFCUHnl7ixiMynEgNDiKmVDzGiT0jRlI8okXkqNagRDlFnRgkHhJkwzSK2wC/kgAMyiQwANtWyY9BAti0D8m5c0SKJQ1dStUGxrpkSgKedW1Pq8+di4Lv2xzyyRw2eyLjKol+WeiwvJe6TXRjo4ljC+4iAcC5C+pV1QlqYm8G0ZZdJeIPSKdI1gDk5U538AMskqzaokML47wflAF2LCR5gZnTm47j8MLRAa2Unnl06Oexm8+r6u8WbTnPuYkwvbsQ9kdmK1QDoAO+zi1ikc0y8s5B8C6F3UAcZT8HhRy21AdFyOr+DH1DmUs3BZgPbiBuW1nt/2Ts83W3aXuM0Q/qXR7LvM5BEEFnGkMob+ZEs8X4JFze1UC7wQmZc47vieZZDuhq7829F X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(451199021)(83380400001)(66574015)(2616005)(2906002)(38350700002)(38100700002)(66556008)(316002)(66946007)(478600001)(6486002)(41300700001)(4326008)(6506007)(26005)(186003)(1076003)(66476007)(52116002)(6512007)(110136005)(54906003)(36756003)(5660300002)(8936002)(8676002)(86362001)(6666004)(7416002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?2NKEr39uN2Wv4JZHezP+D58SVxGE?= =?utf-8?q?b0t271iy9OoSG5HF2S4oIYbe0NvF4t60a0kLHlE6Bnsxm7WQMk41T3UUaUlhK6cIg?= =?utf-8?q?bVFuN7XFVUmmC87zrzqEPCKD88QbF6SwXhdtmNKLqlUClHCrg4gNA7kBS5t1LEb2k?= =?utf-8?q?cCSKPwIdelxu4mVOnRyec4CqJt0NSy3I1hUS/a7wiSM+KquqMK7cf4w+YbTfEbtYp?= =?utf-8?q?MdZAp/pvAo/QoNJZy8mKTQnyZ4ttzbziKVerFyS9CKYYd7C/I6IKnnK/polVA2cop?= =?utf-8?q?lWhr4qyLERu/wKit4XbPaDfMNRbY2DwbqaRJ++bl1TKNNLKrio0cvSFk3ZgN/7/nu?= =?utf-8?q?5itq2v5ZGw6G3nfCO+Fb2z6hbA2Kn6SFE8RH64DlyqKxRrHgJ0AcDkiNUFMqSCj0i?= =?utf-8?q?sLcPS5U3W4wBkD3eZgmwIfUcweecdLuwagXOrMyIyX8PTR1YLqQwfmqzMIUOpghDm?= =?utf-8?q?vfLL81cGN17LbUL3XHodojxt4iLPJdgonVb6qQ36yskAUYhtqGsce9lmdgmjzToAZ?= =?utf-8?q?+F8o0kNQehiVf38jTRoSKaG9fXegVSjeK5O8TZzhMGltBtmzWYBt1nDUo9xFl3kzi?= =?utf-8?q?GujFYAV8DkHZp75FpHfT87dJGzJS/0x2mF8hK8hU476cVVJtj65Z853voV5LT5QOz?= =?utf-8?q?1vYeBccX4JloGwO83KHG6rCs2IRtud4GFJ7kgZIMeqndR9XbfKg3o/ApklBjiICgU?= =?utf-8?q?dg0QYkBIRArv4rDsh9jKBq1jtxY4jaB9uv2wzMof7/KyGE+yc9V66hskTTkMQMQF7?= =?utf-8?q?rnxK5RKz9S8eFUt7ujNVUcXLoUw9b2cO3tmW9LUKG3YE3FUy6oP8eGmfNl/rLIhO+?= =?utf-8?q?O/Kbgay6udSvMH1+KKXBSeHOgg8W5bzAxFmvEnTBDRk53xMpgk/GIC2/HtG2onESq?= =?utf-8?q?jslqS0Ty2/PgmeFQhr7guyBMhaYAofqEWGxsig01FNq2+s4lgz1pRnS8CPkRpZBWd?= =?utf-8?q?FITGbw/PpYD37kr4LFx5KGx0Q9/njt6oBX9f+nZ9YsMcV/HgCl2Vn5+FnQuFaRlhL?= =?utf-8?q?EXFxj65Mbn9hQCWPOFSuAGj+ipHnlsGphpx98rgjXBok0im82CmUVI++3oR5CEMxg?= =?utf-8?q?ynsy4e72N/P0bjYDoDq6wqiBNZX/Dk0gd6bnRSgEZF1SeuDzLGD0kRakPzJXF0Xy2?= =?utf-8?q?7f4Ce6y1tCEJwzMHlVNFrKqsTvS2B9FLgbaG1SRGnouaCBNDFPZNq42gsXL6kXiLa?= =?utf-8?q?vJbHEa3L8364LaDjGT1b9D5I++yuBgdqbA1GR5G369x4+KRHeaI55f+1Y2EcskLmX?= =?utf-8?q?LNDkAu/bQ2fT08budwlVlKEZSS3Bd+hALIBxu5WWHS4VJzUMuC4SdqbaAoR43totG?= =?utf-8?q?fyJjBrZcJKL+9xWuqhZyyRhrtgvSYw3zszk20vnKIK+h4JeVjAytW6T8qClLpcKgq?= =?utf-8?q?zILYCM7fqFsdwRIY7z1155Ib/XQ3nm78gRxQo+2roC0DK1WM0rVLhgEdy6ekAv0EE?= =?utf-8?q?mmVDeNsOm0/qKiyUyW6t8N+kmallGvFr71VIwt6ylqSaja0jnSEkg4eNrVEugksog?= =?utf-8?q?TuGBDxIs35KQ?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c826e84-7bc9-4cb9-1992-08db89cf740e X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:47:10.3028 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rueYrhLiUgrUucvyzkb4TPktGJja1cwq8WVjB2LGMxeNlOuVn4nePFmOfhFz1dBZ5OFc/DifCkArw8nu8UmcQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6789 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772024722907989467 X-GMAIL-MSGID: 1772024722907989467 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Reviewed-by: Dmitry Baryshkov --- drivers/thermal/qcom/lmh.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/qcom/lmh.c b/drivers/thermal/qcom/lmh.c index f6edb12ec004..48a14d7e8bf5 100644 --- a/drivers/thermal/qcom/lmh.c +++ b/drivers/thermal/qcom/lmh.c @@ -207,11 +207,10 @@ static int lmh_probe(struct platform_device *pdev) /* Disable the irq and let cpufreq enable it when ready to handle the interrupt */ irq_set_status_flags(lmh_data->irq, IRQ_NOAUTOEN); - ret = devm_request_irq(dev, lmh_data->irq, lmh_handle_irq, - IRQF_ONESHOT | IRQF_NO_SUSPEND, - "lmh-irq", lmh_data); + ret = devm_request_irq_probe(dev, lmh_data->irq, lmh_handle_irq, + IRQF_ONESHOT | IRQF_NO_SUSPEND, + "lmh-irq", lmh_data, NULL); if (ret) { - dev_err(dev, "Error %d registering irq %x\n", ret, lmh_data->irq); irq_domain_remove(lmh_data->domain); return ret; } From patchwork Fri Jul 21 09:46:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123708 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp89352vqg; Fri, 21 Jul 2023 02:53:18 -0700 (PDT) X-Google-Smtp-Source: APBJJlH7UVAleOy0Kpcx1RwxWFZLpXQQN/W7sGGD2GcPinrO9aCf2t416Q4lnnuPPCX2R+lC3C61 X-Received: by 2002:a17:906:10cf:b0:99b:4210:cc79 with SMTP id v15-20020a17090610cf00b0099b4210cc79mr1308706ejv.22.1689933198527; Fri, 21 Jul 2023 02:53:18 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689933198; cv=pass; d=google.com; s=arc-20160816; b=lH2HarN6SD2vN1CxoZ2JT6Qje5xljgQPhwzquSt6jHJp42HOzt3VfM4SrNFPMttZjN +rGjUFeciaT6kfjS4mlxzJxKYxypbRXAdKcN61PqcOvo5lC80/ac+6sRz1IUSGHwdvRk eMKy5gs+Bd8YxhtTE5f2dg76fUXDMBbd4zZ2eO/XT3wHJSrm76JuNBw52Is7aR0ARdkS ugnfW8ZmqFsX1Y2bcdLjaiFk7iJpH+YxFt2UfTMLqHaPRZyGd811d+MxyzkakBMT5BB7 Mw3sFGifHM5+OHn2UMyJ6RXy6iuINNC6uVpd2ZEi8Av4sZ4A/69on9W9qdjEQCpT0Miz 1XGQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/+gwW3HWoFbyKNr4P4zmQsQ0AWdekKwoDQhwbjDld4s=; fh=KTv2T1r/QNJZkf7UmS3j/ysaXQ+6ICZoxyH0IbK8Eew=; b=sIIbKrX3ZEcESUl/BT/HNKdGXyEjqHcgYwW4cihe1sn4ZcH8e2uGqhgg8RxWqbE7dn mEYVDdCKrKQb4SrgeQ6fet2+/vjk2jYRc1kldT+WHoTiccW2rw3OIEGAt78svf6Rp9Zp 3w8WQ5QnRVyrgCsmMFGvSuHwJwVakLlENCNrKXPqxcSqITWq3rq9zoY7SfMjY783mrt8 3qCpL23yMfOfT/XFWBjBoM4eqb5Fnqcd5Z+D0wcEinpGjD+4ZZM1FSbNqu+FJH61HiZb 8RmuLUCvH4IPKXrA7S3CcKpCvdAB2UIM0E3Fo3DKhXJO1+eGr2581saDzxz6KswNP3td lFFg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=cF2JDo5d; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b19-20020a170906195300b00992550ccfa2si1905612eje.273.2023.07.21.02.52.52; Fri, 21 Jul 2023 02:53:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=cF2JDo5d; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231854AbjGUJru (ORCPT + 99 others); Fri, 21 Jul 2023 05:47:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231818AbjGUJrX (ORCPT ); Fri, 21 Jul 2023 05:47:23 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2095.outbound.protection.outlook.com [40.107.215.95]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 498D930D7; Fri, 21 Jul 2023 02:47:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ICrn6L49WCKH73MWdY9X3Eh7bGowQFLSJKr6iu5vDdcvTsC4aGJGRnqJg4CXywLs/bnbIzNFcZfqbGYGT/CYO2kcByD2fhuQyG0jD53QZE23uew2CXB8SqDsRaR9jxb4EGvfubMH8OZqOBvcBQBhzEaQEE83lnf6EvmpH0NJHYelJKm++uw+EvMUhLKG09EGv4o3zB4REMtnx7WUofoCeSUk+3dRWW/HphX1iK+6kg3dRSXh9/BrkLg4bmqlcH8dYJoR9bEIqiVlvAZqNFrn9bKY3oGgJ17AhFSHJ7/HKts5PrGA2FYxHvX1tUGpBsg88tWIdkUhAPjIt7akz0srAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/+gwW3HWoFbyKNr4P4zmQsQ0AWdekKwoDQhwbjDld4s=; b=J2X/hCcddxm6sMaBw++W167h2z/j3UKMr0CnULfgtGFLwbNWZAoiaRmYs+V4QhKFa+w0HeCzFBQyRAjU03VL1nsJ9qs3rw+z3Je4xZFgT6lIJcNk2Cgjo4J77JD38Z/bJtd8IlkDcH8Zo5JCy0aiSNSjzPvjoattLCGCpUGTxm7SQlWX/AJnuUasvDRtVQFyXDbJcdGz+PS2Gpy5cNiiozR5HFw/fSBxeHj10n33E0qJWBb3uvc8zNH2iBQXRQW9zavrMcNEo/thYy3qWKV5vz+TyBFaY0uK2s4Uip7UP0CLo46R+v4fqJxZx2IruMU17ml/TZ2KwlkT8WdW65MiCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/+gwW3HWoFbyKNr4P4zmQsQ0AWdekKwoDQhwbjDld4s=; b=cF2JDo5dPh1vPk+ZMHECqPCMHysej4t8qvwFlUK7Pc1+9z1CIbWZeapFwF/Du5Nq96jYnPSp/8DoSzmgVcyi8U+GPDL3KgIKMe+2HMAd8JQZjt+7w4ZU/BzGJqL8nJo4N305nV5R6YjdO1BOtnPn4HDwLG6Eh4noF9XbgR0SomNKWjtdhms/4DczdQi7aVEaeqpiEl8LK87Nrd2w0PbgXEMlJRfBwD5YlLcOx/9jD7QDAM+kHPg6+vpShUg3dUT5JgOa2gixaVYpX4l71KA0mQhSc0npFg41RJW3bWMJV76P5jbxexxIozqpZOsmoDQ8J4QBW5tsMvC4B4sa3EiU0Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR06MB6789.apcprd06.prod.outlook.com (2603:1096:820:ff::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Fri, 21 Jul 2023 09:47:12 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:47:12 +0000 From: Yangtao Li To: "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 07/22] thermal/drivers/db8500: convert to use devm_request*_irq_probe() Date: Fri, 21 Jul 2023 17:46:26 +0800 Message-Id: <20230721094641.77189-7-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230721094641.77189-1-frank.li@vivo.com> References: <20230721094641.77189-1-frank.li@vivo.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR06MB6789:EE_ X-MS-Office365-Filtering-Correlation-Id: c0dff76a-c25d-482a-d2c1-08db89cf755b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3Nf+mI4/Mbgb4QIPpg+NgXypRZOsvG9mTHKTYKoRjvR9DdmfEaP9Tqeni/OMV/tD1GQRL2C9u8iArqBTnqzJk/o5qVcXpJBXIpbO9wcNneFs8W8la/JntM6wPCTZedM6NCBQjHpurQgHEcPH2CKZN4P4RNdgHXuqpQIonqLvkr8XTW7S34VNtlPxrxDxQsQ6NgXFj5U1UI/HGnYKJE9VK9i9NnGLusO8RUXy4L4HkMUxXzTqp2q5fnP1DxCzw4NB8uc15MwJzu5vYfdMd6X+hxhBpAs6e4LXEJ2GCBkHJoMkHhOWtMqXR+BM9+is3xrooCMNd+hEqmye643dunzVY/1txENvQtADY4UHDOA1CNLZZGdcJxiHKTE9uuhUDRXURRRtZrjJkOMznjO9CtJ1MfXhicz/ZLySV5b6jv7y38nq3jaORKNm4gw8dJsQB7HRGb/x6ICwLWFhM09Q8fNmk2ECL9OnWNyqX0jNvpU9r63VAcsOFM+co5j5WLtLioIyJkevdGKSXVisLWN1YUffggobRtFOFdlKAetCTGZAmDGA8lhzDh1lYCtRk6RR+44pIC4BsiKbd9KPcaVzMGYMkAY00YItLE0wZXihigMS3wZPP1oF9jTd7odq6VKOQEWT X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(451199021)(83380400001)(66574015)(2616005)(2906002)(38350700002)(38100700002)(66556008)(316002)(66946007)(478600001)(6486002)(41300700001)(4326008)(6506007)(26005)(186003)(1076003)(66476007)(52116002)(6512007)(110136005)(54906003)(36756003)(5660300002)(8936002)(8676002)(86362001)(6666004)(7416002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?JJtNRdPnjeHhGEFa7uR6tMU7MWZr?= =?utf-8?q?lssM4WYm0EAtv3AapwbNUiAfE5GeOLQNNGVBknZGsIsBJwIZXYl3x7msrtBjuvM57?= =?utf-8?q?tLEtb5a0qYoJZNFju8pe7tjIZVyvnjYErTRVBOgT3yqvbMANLvNUtSoP7Xw7JmD42?= =?utf-8?q?HD1bEUaqYdwZ/ZTqG66BbfTDTq6yYyt+HAj5KYpnwUqCgssFSmxV8T8lexmvo1Ik5?= =?utf-8?q?U7qrOz9uwgiZgv823tvf2bmVTvEw9D4R1/+NJiSQoGDfRp8irVLno0tH3CzO6stRP?= =?utf-8?q?u2ebFX335EyhpljSJ/Me1HuIFAiuHpP+NpZaAejLs08rSEo8XA4WxwANfv0AYB+j3?= =?utf-8?q?+KgiD1YxSJow2eH+rbf7Tg7+gITHQc7vY5uFo9GnJ6Z+sHGtuvFPHUs46bSU+0+ov?= =?utf-8?q?gXXU9x8nXyHJguRNCU/I/A9BMcz5toRblVZSW49ejVvTOQgRTWsElsPj/Z6twF7D3?= =?utf-8?q?80uKav5faK3GeF1LJdf/136JOHT3RTGMvHQS8PTZr177GxifTx4KDogi+fwiEboSf?= =?utf-8?q?eZ85jScNGYa4VvTxaggoL9oDJzS1qVhmJGiApndxJVhEFhSe7D4W/dpexBmW95H33?= =?utf-8?q?SHi1Y9/Cekg6kiukzXSc3dJAj3wweU1RFdfgUpI3nITAQM3OEb1fZEyA82eneX9H8?= =?utf-8?q?sYGeEavYb4RXftmbZGTGBPaFuhQt+F7pprs7ONpE3PPtv0HIj3wOVr30qZ/ww5PiR?= =?utf-8?q?oYiqsEK1zBC7tthyJ5PbvqRdQ+UwgslJNmlZSeB+6AxF/LdAMkvTN2JCwuxQxWhAa?= =?utf-8?q?JOZRksz7iebYgXsHxpGJuMJeOto8w5+HCDxoIjtFAzjyB4Bb7h2NLcVs7n8H7NbRa?= =?utf-8?q?LgSWpaMn+UdhGurjzEk01+t7NjlUz2+tQt8hBFdhJpDuUwr/d6rKnBPpBXBNpRnQQ?= =?utf-8?q?nHieOl4O6weonFKOoZyCz8VJgsEWwqLZQgM7qsirPTcf/4nz7UZBsCK42z1w2r+t5?= =?utf-8?q?x+yRsTDhK+ZtYuNcA9wGbJzYBcQJQDtweNTI3JMLNnchUQ6B30xKBb9j7xzNJx0HE?= =?utf-8?q?EOTkcxQN8CfZMeEDzhQzyefx67abfls4BVbVtfCq42KpPttiyzllVsMBaRuVqk1JU?= =?utf-8?q?UNNev+/ldhCdGncVypq5vtJduoh0tieYJisoDRGgzKVB8Aht/eUtdXpaQuak4AQBc?= =?utf-8?q?NjjxaDbuRQQ/hNFaow4FuqKn0JCDj7RFyQyy4xW2pFxUXXaUY1Osn9Kp4Cbn0tq+B?= =?utf-8?q?x7NX0jIypp1T3l2FS2OxXB+dbIVaQMs+Ga4KcBTVkf7ZoxjkEWc3Ddxs8sQ4NL3NM?= =?utf-8?q?84OyhvLuigwztcTtPz/dalNBNb2IYMziOvkdiZ2NUqnaFWj3smlltg8Vr9SHEIF3n?= =?utf-8?q?1PGvS+ctNGWmn0HWtk4XenBW6sBm6TX4btClb9TFnqLNo/sXbKpG28/2+NSNZxssu?= =?utf-8?q?pkkINd7NgGe9XdxiBAVP4g1/mrWTQI26S9YLcz5CWaFcalRn0sHNNCEv1yUlj6okC?= =?utf-8?q?Cc2sEtLmiH/QWRlfY+j6soa2K3HcHIC0QmObPDTIVfZMi1AyveMO0/1vtXw8Wjucg?= =?utf-8?q?77UhzEncDIUy?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0dff76a-c25d-482a-d2c1-08db89cf755b X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:47:12.5246 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ImTdWJDZnd6c63N6ido1LZwl/uxovGBRTpXyATl+75blg+1emqIuXEp9ritOH+qTmWmts/25B4FOyfuFnECZmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6789 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772023393575110290 X-GMAIL-MSGID: 1772023393575110290 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li --- drivers/thermal/db8500_thermal.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/thermal/db8500_thermal.c b/drivers/thermal/db8500_thermal.c index fca5c2c93bf9..0ef8fc2eb4a1 100644 --- a/drivers/thermal/db8500_thermal.c +++ b/drivers/thermal/db8500_thermal.c @@ -164,25 +164,21 @@ static int db8500_thermal_probe(struct platform_device *pdev) if (low_irq < 0) return low_irq; - ret = devm_request_threaded_irq(dev, low_irq, NULL, + ret = devm_request_threaded_irq_probe(dev, low_irq, NULL, prcmu_low_irq_handler, IRQF_NO_SUSPEND | IRQF_ONESHOT, - "dbx500_temp_low", th); - if (ret < 0) { - dev_err(dev, "failed to allocate temp low irq\n"); + "dbx500_temp_low", th, "temp low"); + if (ret < 0) return ret; - } high_irq = platform_get_irq_byname(pdev, "IRQ_HOTMON_HIGH"); if (high_irq < 0) return high_irq; - ret = devm_request_threaded_irq(dev, high_irq, NULL, + ret = devm_request_threaded_irq_probe(dev, high_irq, NULL, prcmu_high_irq_handler, IRQF_NO_SUSPEND | IRQF_ONESHOT, - "dbx500_temp_high", th); - if (ret < 0) { - dev_err(dev, "failed to allocate temp high irq\n"); + "dbx500_temp_high", th, "temp high"); + if (ret < 0) return ret; - } /* register of thermal sensor and get info from DT */ th->tz = devm_thermal_of_zone_register(dev, 0, th, &thdev_ops); From patchwork Fri Jul 21 09:46:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123725 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp98953vqg; Fri, 21 Jul 2023 03:12:03 -0700 (PDT) X-Google-Smtp-Source: APBJJlF0zbTTE0fDgs1pqoDc6KMYy6JtbcmZpIISNPn8UB7/HpscDctAapKnMNBxqXXCNo+LudvJ X-Received: by 2002:a17:906:3154:b0:992:ef60:aadd with SMTP id e20-20020a170906315400b00992ef60aaddmr1641937eje.13.1689934323569; Fri, 21 Jul 2023 03:12:03 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689934323; cv=pass; d=google.com; s=arc-20160816; b=boFs6mX1oDblbL+i/JCXh7mYOLFelRxmL9yd4hJDUhOD9rBDAmUv/gbB2njWdt9IIv 3onZDV7x//acACH0/D/X0mONlBrpGVKmGudBvbERyPWv0bFQQDzHmtpKq6z6qArOYbi4 Rv7sXh2uOeKcwmkjTO/wIyk43BcBNQreAmGViCaAKfCJkZnumzvxTW6GEvXe1VZWxmzA teweXu9aZ8jWuvInbh0JAyahr68XzMhPYEuv1FLWu4QT++zyHzn+2uigB+aPDxNMla04 YVU17j2xh1qtqkpH7zpOqQMrpwZP228oarv1P/CTuBm6xVNNwe/9CnMwc32TL2nlmLTT +KHg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=UC+Tw9tBAxhMQXbL/7pWy43tyxpZDYL9sm7HLlbfqK8=; fh=sxeFmz7RQjjQwqLws0K8rtszMe5WKHMoJMYolzjKDqo=; b=ruRWMViTHBOEYGXi2FH7LlCD+M+aclK2jdrWjlsNbMLfevPgta/5FB4SXAXpp01Zgd JVkgJPjBRzOLBqgRMvhtx4/cXLEvUswRhENitcovKevgbmQSD41jiP4IoCrCcRfOoh6c qjaHpR9tYGN1iDkzoejLfbeO6BXLrKC4z9/1Vb8ISszTw/ZD5UpUW0raHu3+8Dd3rxYo Ud3vkXFVO+ApBJqdXnyEVK/mptYREBnr4opNw55YLYgBiTwt60JZ7IMVa08YNHetD75X Ao4h4w8KAJ2//xL+lgT99nzQMPE7tdhNdXzQsMQsaxeQ2Ng9qJiSm6K7zzAZGtmHoemZ pMuA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=kGuPR3cx; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qt10-20020a170906ecea00b00997ea7d6656si1967753ejb.628.2023.07.21.03.11.39; Fri, 21 Jul 2023 03:12:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=kGuPR3cx; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231847AbjGUJsX (ORCPT + 99 others); Fri, 21 Jul 2023 05:48:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231845AbjGUJrr (ORCPT ); Fri, 21 Jul 2023 05:47:47 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2095.outbound.protection.outlook.com [40.107.215.95]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91AB5359A; Fri, 21 Jul 2023 02:47:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZsE54HUe2/tiVY/iyUUv5v0xH4hcc5AEYZWgDdu8T57e81yCrCnALRMeaYaQ8arBy6SLV8KdQJlKY8O4U2CJA/YaK6s3ce0Uhr/Sjy1VDcdZMd5qmjx/DCdyxabwtNAhs7Zw/cZjWz6BwbH6A+0FHG4d//ay42yHxoL75UU27RdvlTMgSe60fBc4IRkAsDc5+glHZaLMPk2GYQNou74NOLGbrEkjhdJZhH/FBA3GE2T4fg4br4m8rFcLz3XB+qGzUObGERIPJYbOueHeDRqifWycBwlkPZqR/3NdZpYwxsZgc4SmQVFkVmqtOEPeFfjNzvyJJBDr5/ReSYmrjYWoTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UC+Tw9tBAxhMQXbL/7pWy43tyxpZDYL9sm7HLlbfqK8=; b=ckixOFQHaWJm/O6wB0XGNLTScDRqgxqMku4RcbTipvwJYC5PClU1aocrHVFTR+GULvhOntQ2wIUiw4Wg21qfRWEBAjp/xQksQm9mD03iI5PpsZb5bVOGAf58LPaq5WDGvD8wQ/t20VAWO4FfrYuXGZ+VWH12PKmdJX8aE0ay1cPHZX4037J9gtrWi126PifEr4SWZDUwGYlXQEbhJE/eRrAgQwbi3NiIWPHWXp5okqFNX5kZjpdn5waml7eD/Q1x7wO+TfTTwzVOfp5w9Tz6/pYzGEho/7L0EOXv9JFINFhMzvjgTdPVvzzRR7ErqXpEtAG1xWHCiGCzwXYQm7FL5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UC+Tw9tBAxhMQXbL/7pWy43tyxpZDYL9sm7HLlbfqK8=; b=kGuPR3cx1/zZEg2RiiMeJXtXBdhkZGeYvWSkQB1s8ox86hp5KIs0FN35THD1tyL5bHb4CvFSoziYF/X1XX4hLkLDsj4w1pKI4HjZrZ0N329nTkQVgh7FPW5/xaqe3uShDhPUf+dcG8NyJx8aoNg6+9HeD2/Vz+0t0DVFDULFM2x+9QB0jF0fD3159/tR6ARjLjbIz1n4NUvT4utRlc4lRUFFIMdWZ3WMN32IUAHBpwsZgLffKwBukwWNTSSfEWtlzrJVJmudTyAp7/YuC8RZgSxegMA1cI4GmYw4fHiQZJL+h4sgVH+H2twV2t4J3uKxznrcSjc9YbLzk1ao67DrHQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR06MB6789.apcprd06.prod.outlook.com (2603:1096:820:ff::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Fri, 21 Jul 2023 09:47:15 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:47:15 +0000 From: Yangtao Li To: =?utf-8?q?Niklas_S=C3=B6derlund?= , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , Geert Uytterhoeven , linux-renesas-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 08/22] thermal/drivers/rcar: convert to use devm_request*_irq_probe() Date: Fri, 21 Jul 2023 17:46:27 +0800 Message-Id: <20230721094641.77189-8-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230721094641.77189-1-frank.li@vivo.com> References: <20230721094641.77189-1-frank.li@vivo.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR06MB6789:EE_ X-MS-Office365-Filtering-Correlation-Id: 735b28f0-2ae7-4018-3897-08db89cf76d9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iabuIMEDtyVit7Z+kgPtdxxo64epokqH1k85JJcJZsghZgffTDzc8dSJ8KlChLVcGajRE2SwMQGMsDezXUIDXC+C22NGZm884n33DgG4nsKN9mOYHWh/Ti4Tdf9flJ4cFyZEjsTOKMyeFzl1FpCoJb1kifb+LxclLI6yWiohQPwu5rvjW7HMvxRmuNW4gxVXh+6P49K61fpfGaSs/s0do6z/MyPLhQMavVkvN0kcFGdHM1/bzqG9PNo4XUOF2NqM4Fhe0dTjqpOlPn84/h9r78cPiu5/+dy/eQipUtZ05fdohtclMPLOt+BaKQOmTO1JOxC+m5eI2eBVl04vVRyPWstkWvCkqM3GnROYl7CI5MuY9jwt2XBKBB+089Vpq17KDgkkdUQqaEbvkvfjY4LF++n3avgTLdALrzz73x2fJCIS9Po0FZCHtrFR2MKvCZRk71Z4hF3xYHmkWesG2GxKH3tnLiywlEbeBbexuxFWEtHr017CQnGd7nfyVWv0RJnvwLmF+OGWgQmPylleI9kD9ApImihmrpCd87sx1I/bLRz9QEtbRoeDcYVCkxReGnHKwUY2W8Unoeul7+32YXpVRWhF1cexXS04LcCt+FsY8p2wiiGz9hQ1F9UYBLASm5yt X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(451199021)(83380400001)(66574015)(2616005)(2906002)(38350700002)(38100700002)(66556008)(316002)(66946007)(478600001)(6486002)(41300700001)(4326008)(6506007)(26005)(186003)(1076003)(66476007)(52116002)(6512007)(110136005)(54906003)(36756003)(5660300002)(8936002)(8676002)(86362001)(6666004)(7416002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?XjuJiaUwwveBcFMAspYNdO+pm+2E?= =?utf-8?q?XHEiWgksXDyFsNXH5ABF3b2X+/0x1Ghr51nopxRk0e68b6QPsN2oQrPkUmwtso14w?= =?utf-8?q?D6ZSJLiImO+7s9t0r6BEWT2TktW9oUqiYWlbdS5jc3X/9VVg+M1lkeZv3t6DiRdYN?= =?utf-8?q?VEVXfr53uKVccS4Aw2v9W9/g0RWX8ZRz8i3m7xd6gtxKblOGceJ+pVJiVOjiiIyU+?= =?utf-8?q?V4P1RFCPwTuf4XTNInJbwdtippPWF4nc1kx2XanvsmsfvFDyISsjDZEcS24m4VTBX?= =?utf-8?q?H0S6ptlfo5vWpanvmT7JXgjmIV8nVPMl11E5KSdrNgEHn/pKjSPAzwWJgStU0jpDl?= =?utf-8?q?xbeBVSyuK3SemXSAqF1y4pukltR7673FlwEdOfsdPrkORHOyMd7CdTQwXMmkurI52?= =?utf-8?q?1pLbog8goH+EY/EXp7rXrN45HR7qx/jaN8JsJY/0t41Q7RDCt0BKpDmPmOutlBefG?= =?utf-8?q?SMRz7XFof1oqVbZjLUmpkxfUg2xOgfFWsRp6l0902tTTq46eXxJ9UP20ir/b+vGGs?= =?utf-8?q?QQzlmTQIzAZRAqkNZOmWy3DkJ1NlqiPnOdQQuEetThdrOHuOYXxhuV66Sq8OcTdvj?= =?utf-8?q?L/3pujCx7VFiola/yBoV9YfMr47w8q7asGMdMihhms1smp6JGzdQ3hKps0/qKi2w9?= =?utf-8?q?hhm75hpKTPB4r5yQ0714CV9KKmQARJn8+IQvHYK/+RR06E5COmNfvCy8gPI8Sxa7c?= =?utf-8?q?lYLu/RNLlHk/KROGWaNoYruag84HC0sB/h/8pFZ709SiNfuU6/NVt1Fs6PTOqwoMC?= =?utf-8?q?nkFLw9Sg1MxBrOhxwwyVyeAFldT+VfveNNwYN/GWPG7WHu6cGFkVAPbjI+cj5jBeE?= =?utf-8?q?YcXTyn4Jd7KNE/EOnfRlY4m79LILwjFNjfgnSWxZz6Sf8rj4+b2kLhRRbSp21TS2t?= =?utf-8?q?omSNuJb3ZIqjIZvVl5gL3T/Jam7wgVIJqBORPXlrszVkvFviyYfqnA8iRI18tdmm5?= =?utf-8?q?ZKww5p3+GZItvta13r1jp2edPwPFzAjo0ry/8fXwu4oMmwuslYCJbFaTgsNboJtkd?= =?utf-8?q?F+YE7cVIDAl+8PFdLLyUiioeo24xEj4F+lx1zUFqMnLBW883yDCiN9cvQg9aG+RFC?= =?utf-8?q?F9wSVwIzhUmhIgz2bUiSienysQTWFV+WVhY/oqiwAX8TUuOZViFq2r7Y8zDtA9X2E?= =?utf-8?q?95JbdvGc1Hy1HQzOYbeHIuvtrbBClNm0d1XaJHRgxxqTo/N/Km9arK6YyLiHVSmWz?= =?utf-8?q?hojvVvhuD6ehgTR6fF8Gw5eTrHacbIYFri5rIAj6rVHw9+VW3UUlVaJFmdtj8/cV8?= =?utf-8?q?IOX3gn0HgV47OM/+wFW3zFQlb3ZdPOhY7D28a8Rz8ksO/gd464GzjwlqoXGgCqy/S?= =?utf-8?q?WrZc6BABbY3AgV/gq4Ka6DXJSWSYfxccfdTpP0simBNC+hNgHw+xoqzsLeSQe2n8Q?= =?utf-8?q?xCGxuG6MBDvcJHkVMM5SyTmuaEkbVSF3NTRxcI7XZmAUR9u1C8MNjXOHTsTI3fRBm?= =?utf-8?q?ddr4sYXzEUnNHNsygVup8c6OrSsrbS3cbmyMxYsHZcLPmz+xUmo8DGVAGemiJTMb9?= =?utf-8?q?zlC+gkbTrSwA?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 735b28f0-2ae7-4018-3897-08db89cf76d9 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:47:14.9940 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gTEUwsAhi3qp3oxLpuhxlw+dBc+AfnajAD4A6RlUoI9Y++6hRVK1+3peal+cz8vP4h5UjbWxrn3vwgDXjt9Jxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6789 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772024573243267121 X-GMAIL-MSGID: 1772024573243267121 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Reviewed-by: Geert Uytterhoeven --- drivers/thermal/rcar_thermal.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c index b8571f7090aa..56f3983dcd5f 100644 --- a/drivers/thermal/rcar_thermal.c +++ b/drivers/thermal/rcar_thermal.c @@ -446,12 +446,10 @@ static int rcar_thermal_probe(struct platform_device *pdev) idle = 0; /* polling delay is not needed */ } - ret = devm_request_irq(dev, irq, rcar_thermal_irq, - IRQF_SHARED, dev_name(dev), common); - if (ret) { - dev_err(dev, "irq request failed\n "); + ret = devm_request_irq_probe(dev, irq, rcar_thermal_irq, + IRQF_SHARED, dev_name(dev), common, NULL); + if (ret) goto error_unregister; - } /* update ENR bits */ if (chip->irq_per_ch) From patchwork Fri Jul 21 09:46:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123706 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp87982vqg; Fri, 21 Jul 2023 02:49:50 -0700 (PDT) X-Google-Smtp-Source: APBJJlEOzwmmu8ift8+gTxxbMRcAzqeDxz3y6/9qilgsUw9TNOZrJECSSMZnXyw3obk4Z9tGMhbH X-Received: by 2002:a17:902:e5ce:b0:1b8:b841:3ff2 with SMTP id u14-20020a170902e5ce00b001b8b8413ff2mr1308951plf.64.1689932990479; Fri, 21 Jul 2023 02:49:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689932990; cv=pass; d=google.com; s=arc-20160816; b=MaB9fIjUZDOG18HNFGB1iqp7hzmUB1HgPlfZxtMZMowvB8WXa/2NPCil0fyjqWcUga 7KTSNW3VWnYZo/9HftkeA2TM7WEglFaARkCJNj58ZVnGj0epzSVz28zR+gpjcV40hpVm jqAXe+AZAa85gzpoxELvzgM0Gw0q6Dy7iEtAVHZhWPMG9+wHxMXfoYQ5ePhBZJFFoRrM Cut/lbBANbnNFXDyelnCVxxYOwwphrTNJPpp+PAs141Tlllry/rm1bMn2kBgc5QLh8Qo +cPFeYeCHyVskPAGUIjxlAQ9s0bZlCwLm2dm9F1ycID4jMYW59x2uKwmDGOfnlrYBANv iL+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lGhadKGMb1A6nuEIHOjE9NtutBhspKIwNkhmP0V70x4=; fh=kvym5B1qy3FUwfZXIsHgvODoj526Lf3pQG6p1d5aviw=; b=VI1vMZXDuMAOEy4IyBvv5pHn9x69eN1eQZyCLKWa/FIp7JJCRI62VAb+EvcyqCPVke GaUBCG3B9ArsgXE5QhIfRYWqZFHOiabS3U5GTlb5XHPXQDhnOFUiDx8yw0y12J0vAohk k3p3NEkshhbZ1z3OOB3L4VPsDxSWcpGnCBgwllAwwW6WvYFjXOHbzHw+8M8wJtcnyT8e jVnojVlmS9ZulqyI3Y75fWiATGs+6Uj6gbCCXIWsXX1ucspAsAaN3fkLmE5biFgd7yil woXDYJBBiSV+PS+tdtC4Yg9ouuYPMPmfwYHlqHmkE/1/aWT/5X6spNO1m8R5e/6ksirn aWIg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=X+sBCMev; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e9-20020a170902e0c900b001ab29e00303si2513379pla.426.2023.07.21.02.49.35; Fri, 21 Jul 2023 02:49:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=X+sBCMev; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231866AbjGUJs0 (ORCPT + 99 others); Fri, 21 Jul 2023 05:48:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231984AbjGUJsD (ORCPT ); Fri, 21 Jul 2023 05:48:03 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2095.outbound.protection.outlook.com [40.107.215.95]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8E3D3C03; Fri, 21 Jul 2023 02:47:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mY1qTVsoJH2z6vvm5lUuy9OS/o4MZCin4OsdqiraRmSWX304TK3DCOJpeR0bGH3U3rIwvYHfvJ6VdiC5j6hwlvrXOv7sz/mwjxwoL9QaYcM5G3Klv3YMI93Mq/HYqWspPHcgCQCWx+xMYBPLoyXyfpHLmb1gWN5KFtNEqFXDT5i7T0QcRxqiiXjfEOi4IRPPncXApai65kfodCRZbhSuet1ssp1OfZ0T96Yh6R175zMs3F8TqPHcJLiAOZmuOMGxenRS0IOaakp4KHdPCkgyDgA6JReatfhDUzO32b6y1permb1oRNRTSHUY/y4dWsJ2RA+T07BViZwSMm19DsLkUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lGhadKGMb1A6nuEIHOjE9NtutBhspKIwNkhmP0V70x4=; b=bcfrIHxU2PTogKS/KzUziprUHMBbDxktaiR8rOQ6ifSk0q/lRRxul9+dvCQYmL1kRSLnBmcGUeOsdHX3gOpAF5mEUzz1sBFvhqxgf9jFKNPJ2Ns6UW/fqp4cni4h9L8zZbbnpmiT3YYc4P9u02ItUJdyWwvrKuBe2WXmhSULcAwSbaVyrYBk6miFCg7/XaEoGrsy+J72QekVDw3QN7nBTql15iIT5R36B/WfiynkC0HWwZimj0D3o/YOZu5BGfldEn7+18xRLHlW0qwJ3Do95B0Rc0eTqtND4s6gPrm1ThSVURWlYTkFpzBScPnM4f0uMdTMR0pX7liVG/ycx0UgpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lGhadKGMb1A6nuEIHOjE9NtutBhspKIwNkhmP0V70x4=; b=X+sBCMev+79DSn634Jp7QAcdTitTxF6/mepxBjbpaLw72W1f2U9FtTGz46ltkuy2yun1iuIVZgzhNEmMSOWpPG0Xhc3OZ1qqv1Ckh2mGBDMMz4QBB7ofTAYWARY1RXWrZd2UJpTuurEycQu5WHhfl+JwQergT42h91J48lrXALf0RucKUsqpGFsbgbP4v4NctgGiyifSJxjcff2LTuHXODh6abmdGQxpW2unuVJ980Ct731yg0uWCwTCmRDZ0oIpYgL3tRJ+4MCTsUV2ZGDQlN/wox4oKm0bbrRNGsMbEbsVzuB+vYQT/PA8jD+9yKai9IhQ2imWFGvXQSIZXdSeAQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR06MB6789.apcprd06.prod.outlook.com (2603:1096:820:ff::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Fri, 21 Jul 2023 09:47:17 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:47:17 +0000 From: Yangtao Li To: Amit Kucheria , Thara Gopinath , Andy Gross , Bjorn Andersson , Konrad Dybcio , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , Dmitry Baryshkov , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 09/22] thermal/drivers/qcom/temp-alarm: convert to use devm_request*_irq_probe() Date: Fri, 21 Jul 2023 17:46:28 +0800 Message-Id: <20230721094641.77189-9-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230721094641.77189-1-frank.li@vivo.com> References: <20230721094641.77189-1-frank.li@vivo.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR06MB6789:EE_ X-MS-Office365-Filtering-Correlation-Id: abdbf403-d44c-4de4-ad67-08db89cf7888 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ByFKIY58ETlxR62LHxf/7uxPL6Mhmt2eMYkXod9unv1x8txr9IUN1SnFUNUDRC7IRvjbgbM0qRmIMmTZzTzfIZDOQg81O9lq3qWZZ1FKGLdkHNp/1iJ6PDLT6QxKAWWk6EI8sqAcg+PMDX53kchfsTScqsa+dN3N0f892N3cjxr6pxDF9NgFLCPh9Koxmb66AWrXY+IrGzrnQVU7tm8SQAgINX5OCdnq+044cRbghVPbS+EYxNIuGxKSKiYblMUrrY+x96UWsdoaUaQT+FIvNnNnYSKC735XGHRq07au/boYLtQoed9N7dyLWYRWSYyeTbA/DibBeqBHVxxf8x+Jcvdfd0t0F0x5eq6HLEsHYuzeNngl6mPT1epHA5U+6a2wurgN1qzwsi+KqRYYhuK1649vvS2QSEYsXuxvL+0lB9TbwyH7kH9IZSDqbENhsIrow4CWJxHB4VZB2D4MbxvEfhXaqrdVbqw7ODmu2sZQTneO2LiDGe5u2iiIWRyy6gcIIKWooVNLSo1/iYqLzNDzhAce6XNQLcE0VzPp4Tx69aC8bKg69/PfPsfQBFqI47jKg4zB+s1agvGL/f2qhQFP4eTD9BcS9n3Xc0OC8aWZIcQC2ygB7lMWa9dcpnMhlhdp X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(451199021)(83380400001)(66574015)(2616005)(2906002)(38350700002)(38100700002)(66556008)(316002)(66946007)(478600001)(6486002)(41300700001)(4326008)(6506007)(26005)(186003)(1076003)(66476007)(52116002)(6512007)(110136005)(54906003)(36756003)(5660300002)(8936002)(8676002)(86362001)(6666004)(7416002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?uF1j74hN07qs0YlRcX2549EbIxHn?= =?utf-8?q?h5B8r0sY7zrErmFPi8kipRUVL2AL6OHLrkXBg5xEc26263u1TyrXOwiUhIFxhrzcd?= =?utf-8?q?My2vnLd0hUB9tjfnfgWHRF/yJRF6/1WJqykMI9PrZlxzNOuxQkMtLPEu33JX1exxU?= =?utf-8?q?EPLAFObUx72D10QlEo0bG9fuAcD8YK7jg9fdoPWo53DFn1QT668hpoSZ7jQGd9zD7?= =?utf-8?q?MdWLgM/q9diM6vg2qj4uyCM7O0pktzuO9xTGZIQOcTmR8/a6NqB5SPVly6lfdmKGH?= =?utf-8?q?b2FMSx/lSkNAvXA6UsniKWbPRsiRsrBUVYcPHvxLcgSRovP8mCy6Lvvvb2hCbYik4?= =?utf-8?q?iIwlH0jhixVX4ddgf3EyiObAHQhBHNurDggiumsL48USokNUMNJc0Mdi+lO4wOQxG?= =?utf-8?q?3m5SyESl8YVnFtyp39w1Uy0vQsmSoA5YnrMAZDTm5yaWP2yPx2VFLO/6IeT0ajDZY?= =?utf-8?q?fb2FwgrxH8fLQwObXW7z/SciVbgQTaPJxpoZm7MRJedqlFs4zfmZ9nVt76a95AF/D?= =?utf-8?q?M2UWgGCJfOtjhUaNVKm12HWrrSQf+JpzwIdx6VEDEe2o3bw38Gz8s7VHAdWuahE9y?= =?utf-8?q?CgkzMIyK2DoctwUnFqHc2IbJdBAMDwM/CW0PfN+iKaJtZizw1+EHe1VqtJ0aN9AUX?= =?utf-8?q?tdkIDfclGk430eYV2GHaWogbdujhPCeQefqGRFUHaATEHGgNTOnOwe4Tl6bh+P8Gw?= =?utf-8?q?7Z3o3zN2m+2ACRfkRdHE3FIRFz91GekabWwIn4qCJig386VWtE6hBTZ9OSCLz8zuK?= =?utf-8?q?4QBVuE/ZHlv3HFkU2eZMFw9Zi69wXZvQz5gmqLJqfL7q/nS2R8olICDOJUY7FhzQK?= =?utf-8?q?p8+m97owHe/qax9aZZDx3x23fJx7tk8d+Dz6rgyNo0xxuokSz0/ZTjouz4uHH7PQt?= =?utf-8?q?pv6pAXFeMCHhvmrKdF9L8Sc00qrdgkOMXLpekIvq9H4Bqa7o6A1/9kSOeI646THkM?= =?utf-8?q?qzezXVl3I3baK3ZakzmyrufPetod5i9GlvnnlC/o/WZu+sHimg4eHPc3v++AkLPhy?= =?utf-8?q?SilHLwwXIFXVSx/Sa4DT4gW7mnz73r8V+n1Y9Dj5altkHsHaHLkIpd9KkvEfsx5/0?= =?utf-8?q?wZ60d1dDamCXLB2s0slFO/ZXup/s2XUih4N7Dg/+4PVbI4u0DUQFSAW0lmp/jHT3G?= =?utf-8?q?C3uIaathCqHEzuOMo1Eh/o6bWPN0tuWdzxz1xzWxtza/SbQ/mvbKEglNEm+EGkqUE?= =?utf-8?q?Ow01E3Qi9EcDQao3gg3lGid7BWBOJ81Unz7ZXP5wpQIHSeiA/VMC0c+mTgDX4n6HF?= =?utf-8?q?SPqhYWsVg+UMXTBxBlsx7c/2AIWBTeCf1kr8m6TYj/4UD1ifjVWkDPxGtQbBYYtti?= =?utf-8?q?7dqI1cU/3vN/ZD//8XFZpRZGmAjPy4hTgd2KF/mQ0KNVPPzEjYpbHXbjQrNGWPgG/?= =?utf-8?q?t6ZZ4CcQA/ZMYX/mUBQF1W6EmpIjQam+A6Lzz0l6PdtTrDJ7UUziC0WxH1xkAcVRI?= =?utf-8?q?HR8nsedvyF+0RO+p6vZRtI8op/jckXANtvQkG2rI1v9/JFN23cMxqJiVYbgFj8nXA?= =?utf-8?q?vDJFevg9tg5l?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: abdbf403-d44c-4de4-ad67-08db89cf7888 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:47:17.8103 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ++9dHGbQ94Ijt/IFm8e0+JlgYXnRFbTGg/Eoyv1hXlMSTloCqdJTpXQFf90A6lJCKV6LoNPPCZKL+JwDkJWazQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6789 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772023175593863802 X-GMAIL-MSGID: 1772023175593863802 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Reviewed-by: Dmitry Baryshkov --- drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c index 0e8ebfcd84c5..1b4a7eca181e 100644 --- a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c +++ b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c @@ -455,8 +455,8 @@ static int qpnp_tm_probe(struct platform_device *pdev) devm_thermal_add_hwmon_sysfs(&pdev->dev, chip->tz_dev); - ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, qpnp_tm_isr, - IRQF_ONESHOT, node->name, chip); + ret = devm_request_threaded_irq_probe(&pdev->dev, irq, NULL, qpnp_tm_isr, + IRQF_ONESHOT, node->name, chip, NULL); if (ret < 0) return ret; From patchwork Fri Jul 21 09:46:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123730 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp99697vqg; Fri, 21 Jul 2023 03:13:30 -0700 (PDT) X-Google-Smtp-Source: APBJJlHNx2zcDcot4diRVduJcZ16P/Hg+/jUQHkSM6FKAm2fwUQJQws7pKNchc9S9hyxz/ErnW51 X-Received: by 2002:a05:6402:6c6:b0:51d:d568:fa4e with SMTP id n6-20020a05640206c600b0051dd568fa4emr1029718edy.41.1689934409983; Fri, 21 Jul 2023 03:13:29 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689934409; cv=pass; d=google.com; s=arc-20160816; b=YsQwmH4myXQPUCGN2BP30ZZzCwJcV8ehMQzokHxMZ0oMGr9VOy1mAKq6yZ2P5PCXNd S8mXSnqvRp6PJryh0LoZvz9AH6BrV6i+DkqO+sXFr62TAvTb3p3oePKbiA0IWrk7+BiG v23mw44d8ZX/tpdb4fl8kjNcCRpenXLfrUtrn7TndRW2r5aiw9UnYlFrQVJ5Y8LhKzV7 Q/cs/MzMnXUnUkv+reWeNM411Mq+o44Mv6HhUPOyWmjzPVdl6qPzkI3UXc5DODAP42dH IWg7lEfsvLmiux0SBJkZZWW0tfZhjgAWsYkiFgGfnXza4H7bIDU2mTqcUKepfsa7VwCj o+Pg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=CLDhRPJ94KJ9YnANj8lefH54Ay4lhdCGR4Yz4x9Uz7Q=; fh=KTv2T1r/QNJZkf7UmS3j/ysaXQ+6ICZoxyH0IbK8Eew=; b=xZ6YXabyLWoQ1InmesF4frKUPDkcAmZADd9YVazVznkkAxIcgoLvYSrT5U2991BIdo MxDsn9PaVsjdwkB+jVCmdAFz4L/fI0pk52BsLDyA9CkLua++tcMkPIK6rrXoihJKrtrx CawjH88OVeThCYo6gpNyMLYr50z3DM9JVGmwjdiX3wVyW0CdU5ukR5WnKGUsUm9mEzE5 jBOMrQoi6R60IFnFzT6JqrnCjCvWXzBxXeJB9q0fORzbMXGREpfo2vmRwHX70dvJqbzI Nth0nw9Fb3sDwycj3CKJ6zwPCG4cvVSPDI1bnsBr2m1xlzB+DbmDgaTfLnuo+bejPgXx dNiQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=BSZ52gzX; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r26-20020a056402035a00b0051e034292f7si2107013edw.147.2023.07.21.03.13.05; Fri, 21 Jul 2023 03:13:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=BSZ52gzX; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231873AbjGUJs6 (ORCPT + 99 others); Fri, 21 Jul 2023 05:48:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231830AbjGUJsW (ORCPT ); Fri, 21 Jul 2023 05:48:22 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2112.outbound.protection.outlook.com [40.107.215.112]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57FC530DA; Fri, 21 Jul 2023 02:47:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ggBM+bqdfFHPmeWa/kBYl3IqgGG0WXW+VfsAEUwa39ct9DB4NVCkDPEpDluL9NG/tUxcVQM3nYo6kxeQaE6jsjlraHeUeHvtdKsRxrn8ZfOf+uop430CgF7eGOW9IbzMABnOU7hh7cQvNPTpxxfbR/aYohQqj/exoiXqbZaIsHqqKHTXVq6mwg+qG7yYDd4hf+3dCGKUmiQY1NXD/A78vzDgKbROWIEIPy+I/0Bx+jP+q05zt6jZadA4powd47Hr16TFOlrhF+rv9SlVaEgQRNgoD8urdlQdGGDSrMMthFWzmK+sl3IvsX+4ImziJi5w9lI5Bf1eW7aCUVmWrx2log== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CLDhRPJ94KJ9YnANj8lefH54Ay4lhdCGR4Yz4x9Uz7Q=; b=n5V+T6dLeAhl8mTtGCEhlCwGYHoOYZO4uTCqtl8O4Q8Has+59uaXmJprLgmOPDwIxI4isqnT8GRDxFzYtiycb+l5u0wrNvTKpZjWGPFwe/eMzQ2TvLtODPHc63ZGMcpsItEfXxr5y0ORcE8Mp2X4GJXWtcAhrwMSedn7t6N99aJTqobVjk64FQAdPS7TrwwrlOFbCO9/vj0rjX/h3xsLLi5m0ecpMPEJCPHf6E4YsLb6L5mYhA/R6P3WaQFAL6jLHSBzduzUXv0PxLW2ZAlro3mhyaD6DyiTJjvF8CDJlJmQ6iRgdRoMdhA2co1S5X3Wo7zy1MenS02rkNJnxJ/l/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CLDhRPJ94KJ9YnANj8lefH54Ay4lhdCGR4Yz4x9Uz7Q=; b=BSZ52gzXGJDO7PUwNkRSAiPx0o+deyRFm/crRhHu3eVjAe2tloasBCiEb2gdvn3zCAumn2KPevKcWivK+TwYhjTC3oZ0Y+Ta5N1dDOiwZy97z6AtDDDCDQpaZP15VS6KD51fiaRlxUxANWjIUtWVTp0R0BA1G6yTwctUNZjIFv1AxOh5dU0xJUJONw97qOwne/2piHsOfenevPWfp8YHxxvu7Yh44Ps7X3q9pRs+XSIDwsEDemZukXr3nuLOSRJJAYhqDVRiMmpnD3KjpFqS1qremp3X/7xkA09oFugLVTXRlEo9uYkDn6gTdNDDCSCdU4OlSJEC0T5QVVtuoMNsQA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR06MB6789.apcprd06.prod.outlook.com (2603:1096:820:ff::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Fri, 21 Jul 2023 09:47:20 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:47:20 +0000 From: Yangtao Li To: "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 10/22] thermal: intel: int340x: processor_thermal: convert to use devm_request*_irq_probe() Date: Fri, 21 Jul 2023 17:46:29 +0800 Message-Id: <20230721094641.77189-10-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230721094641.77189-1-frank.li@vivo.com> References: <20230721094641.77189-1-frank.li@vivo.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR06MB6789:EE_ X-MS-Office365-Filtering-Correlation-Id: 8c6eccb2-f36b-44e4-6689-08db89cf79d6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gGvDbGfXi4aorYe+CUHUkREmGZ3vrj0uMRcCStlCVG+bNEsfZEO2pfJ+3Xkzh4c9mTyZ0LObPNNhnIPYNthkgo8RQZAvmbT+oMb8y+m6rvE9eMBHikaCXWPIBWioIaES1v9vOHkfpECN2I2r2dZ/Wa15vwY4+n/FS/BErYoDFtr+m3MDvex6DgZkTKx4YVq8Exz4JRnmHBQfiGPilbhxAsfnHMBxrNsHXmiTqzIBx5i2N6q9aj0hbD0khCh7Wt59ct0d+g/ABY1juvIi1OEszsTUOlDsgC7mhu2HX9kkXBLEYmIUMQ50P1KBbw0OT995ooHjuX2iN3ROTPIXjEokbcT8EoPSbvJ5PigqD2opHdD2tdHcdtLaGlrGYg+Z6JB796eTniSmCtiRp2NpNT7pRioP1a4xeqasOVk1/va5V4yVbtau4sT3o6SPAmCYsi0P4sDTKzSuCa6tZn7VDCFKXkCTlNg640whva41YhnQroghjqKIQHKP1z/bDCC/A0kJBJ5PmfTrk/rXW5a9c+qTTrvdnsaDN4rJKAR/tYO7b85UUzFeg/tHkzmrd0dsl5X3YhwYiMhoIA/t/7SA8qhnE8jtinMMikxGn43Et6uyy7R+03H7uVRYwJCgCPmu0i1M X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(451199021)(83380400001)(66574015)(2616005)(2906002)(38350700002)(38100700002)(66556008)(316002)(66946007)(478600001)(6486002)(41300700001)(4326008)(6506007)(26005)(186003)(1076003)(66476007)(52116002)(6512007)(110136005)(54906003)(36756003)(5660300002)(8936002)(8676002)(86362001)(7416002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?7Quv2qskArCkEI1EbE8BS6W2CT0p?= =?utf-8?q?urSkC83rMB+D0ASZPzbiPDwPzd8hW9GmV9yeRV3+Y04uJqnxPVIGrba/WFyIRrL/H?= =?utf-8?q?941Hy+0+DugCPUpusFO6YNcKyQGKc29iI0U2slJPGFiV28Uvbqgzbqjfnco5o7V1/?= =?utf-8?q?Tgjm+uY9g5bYStKqJniF5dwkjyHU1inX0tCXhTE4cdRUExWo1+ScouMnNMDDLk1ky?= =?utf-8?q?TreMzaHTcb3udcdZW5J1cXbaUq+m7nVV7EOr2YgWklexBC6oAGDjhAJo0TW+rhvus?= =?utf-8?q?Rv45JqNy9ddUh9N6JF3Ro3VLVGOU6miEFs1cdfgP+beYApaibUr65yxJ8R+T4X4Sj?= =?utf-8?q?18mnU365tTpLklXIyvC5UiYiPlb8fT+FafUO78Q0JCyRxYTlPAp0tDsS4PHns6S51?= =?utf-8?q?RHUuDjo8fRSRwjmK39b1/4pN6r3XJvIiM8aHHWFJWSBgMGGLvizHSpbMCt4CszJPr?= =?utf-8?q?cacuDNDESP3+WLK9Kn6BwWy5X4pILhRPT09wFmGKToQLF0csjkosOqjGk4oHlx0o2?= =?utf-8?q?V+O34ErW2ZwjIC6DMdN0Jr0t5ghDm/vteaN+/k5qSbLzU8xqSYhKpmzUrYAThy4JW?= =?utf-8?q?Ka9JbYCG2WXdvJ6Qnau6DZCv89PRXDtdi1fdCpmAaR72lE08pG7Kn1BnJYxqUbp6H?= =?utf-8?q?9H5Mc5R2za/AKaXiqB+7kx3fgChx4WlWE0yWnt3NkqC/tm6P1ocp1J2wdhYe4jA9u?= =?utf-8?q?U/XCUolBMe7f1Yx4G56swDeISsUD3GZTNNNFbNdR3A0t+MMjxBh0wM5QSCS5a4e4Z?= =?utf-8?q?P8J+2VXvdph6v1m3uUtCD46oOZWkNhFsF9vxathSv87YT1yuvwI6Gyq2pQyY7m5Hf?= =?utf-8?q?hwAjZrcP7ax/rlsOjUTqGVGMbHhDcb5Yt55NP9wx2WsuaH418f1zsDs2+HQpqyyp8?= =?utf-8?q?0VW9m+H8VHzSjl7NLWw4eFmyXW6+boaZvBGCVuObK1UauqCC/iRRyiCAjIIjgCJSM?= =?utf-8?q?ZordBzJD2Pnou4NsFK37mTLZhzPoqWYZ87ueApTHPFArxS3u0+qWvXTzW/i4U9s8C?= =?utf-8?q?y4oDGpFLryUqTtd/DKbw8eghAeAeu9zEW9QdXD1GDRx7qySBj/kKZamAQqu5ipqnN?= =?utf-8?q?qKCWlEKuV3apmGxRLOzXvI96t/fDTCPM3uxY097CVHjW600V3W9xSli3DLvznmHDL?= =?utf-8?q?zJi37s+xgB3RHzRtc0i7K8UWoiFLtFoywiLTfrHZHwEu+oAc5QfVLDILUHv+4xRR1?= =?utf-8?q?Xko+onB+r7jPM+VjLJfhn5flwVfnThBYIvmXqd1eTQmIAQUa66K22jB9/vbKZ8k0y?= =?utf-8?q?Mi86JcPBPkmK8+4narTjuluaHqn1eIaiEMxchkK1DOXr2zqZD5si0WXEcXNLAitcB?= =?utf-8?q?vd3lbvcR9+lnX6VT8Gqgr6wtf0NTygicc3KPHM86GlLKDTg8Uxaxi+IYy0gklLcN1?= =?utf-8?q?RKNeNF+UVsKH0b0kF843vb1Sb7+96HbxEC8j//eS6Oc7fT1ppL+KU2OckzuQ9bKjy?= =?utf-8?q?QbkGvtNS3rBtVmn6hptq88o5KIhWlgYCo9iiVe9V1S8xvEzppwxANyYsT5GWR0SPU?= =?utf-8?q?Q3LFCwsmsGqP?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c6eccb2-f36b-44e4-6689-08db89cf79d6 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:47:19.9843 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IzftlrL+dayb8x4C5+NMUQSSJBChHW4uGfhD2tVFifS8msJgeix7MIp4/JSNudi+nLuWcM/bz0bqJp1jaFrgTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6789 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772024663976388965 X-GMAIL-MSGID: 1772024663976388965 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Acked-by: Rafael J. Wysocki --- .../intel/int340x_thermal/processor_thermal_device_pci.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c index 0d1e98007270..ee766904b314 100644 --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c @@ -258,13 +258,10 @@ static int proc_thermal_pci_probe(struct pci_dev *pdev, const struct pci_device_ irq_flag = IRQF_SHARED; irq = pci_irq_vector(pdev, 0); - ret = devm_request_threaded_irq(&pdev->dev, irq, - proc_thermal_irq_handler, NULL, - irq_flag, KBUILD_MODNAME, pci_info); - if (ret) { - dev_err(&pdev->dev, "Request IRQ %d failed\n", pdev->irq); + ret = devm_request_threaded_irq_probe(&pdev->dev, irq, proc_thermal_irq_handler, + NULL, irq_flag, KBUILD_MODNAME, pci_info, NULL); + if (ret) goto err_free_vectors; - } ret = thermal_zone_device_enable(pci_info->tzone); if (ret) From patchwork Fri Jul 21 09:46:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123714 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp92362vqg; Fri, 21 Jul 2023 03:00:35 -0700 (PDT) X-Google-Smtp-Source: APBJJlHB1CE6OyW5hRshsa3kQAOjqSFf6Y4JqHXRq7amySvE35eR1PfjwwXWyJvAskwYPWRHu8pp X-Received: by 2002:a17:902:dad2:b0:1b8:76cb:c6a4 with SMTP id q18-20020a170902dad200b001b876cbc6a4mr2839505plx.21.1689933635608; Fri, 21 Jul 2023 03:00:35 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689933635; cv=pass; d=google.com; s=arc-20160816; b=RHZMgs+1lAEc7pUDDKAJlx18mxL39ctzzfPxAtg6gacWBSEOPmQpttRE9MnDdxF7ab vssLXvre7G/9aoRc9N9KlXuLjbPWYbpcQKcGq8MdywcVIHZiiE9MDe5WTjyNYoDfTTTo QBfOWjCPEVo0oMsqVTFmBS33tky/oy3O3QICStFwvHIM977Fi8lknrOd2IZm9yNwNvqE yTa/ba6PY5TXIrVh/vw0P3Z4GaKyy0NSjhYCDcNPlDxpPNOjbzL5c7bqDUOsnZBd4Wy6 93mpZ28hKKfOuX7EaGmkWb3/iyR2qvRJ8LguPbrqoZ0YQye8s8w4bWdDRK5DDT90RWea lr7A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=izFgSNRGswVrvbWqupaMcttliD0G0cUdm7n6fKfxdI8=; fh=9l4jrsSHyS68V2wntipVw1TlkFTVvLOwXnzO6qLLzSQ=; b=cawapIB/f1qPU7uBvCpDi2L8UIUw2odU2/rZUSZQdxB4ySHvPvaLxAESBoWYiDuFpW BANqdr/If+1NQaVY67WelHdLk6UPYIm2VeF6me2gGztvdAqHPbrENGm6SqVB81xDx20o xjlrYEBoUwjPUM8+1BVrS9YIDLd7WMSC1mc8PyAApkAOymN7bgNn3IhqRGfTG4UREXDI GZAd8F3UksY8JBBi5AMpWjF3veff04KGDyg0GIoRyTSiTk2KmRNLBQ5d6xsFjG0B2UkT VUCOmfQyrqzSqQ3H5ImDKEh4+J3sy8GmEP8WGtVQOJ/zi1AeR95ojlaLtPLbXLNeusHx ly3w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=K6dNsgHZ; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u7-20020a170902714700b001b7ecbbaa13si2511188plm.152.2023.07.21.03.00.21; Fri, 21 Jul 2023 03:00:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=K6dNsgHZ; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231928AbjGUJuB (ORCPT + 99 others); Fri, 21 Jul 2023 05:50:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231962AbjGUJtY (ORCPT ); Fri, 21 Jul 2023 05:49:24 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2119.outbound.protection.outlook.com [40.107.215.119]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A30FB3C15; Fri, 21 Jul 2023 02:48:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T2Bu2rAg8A/6NkmmK9oioxIYDuaiRclYMdhO4opH+NweLRn65QlEcVkrr0dLedcH7b9iVTTgtAcEs2vchZE3TLBBFqEcu8AaEpRM8Ji9y1y34sGIn1jZQkmqyDXFfrTSm3H+nj4BOXTkws8lCnmmtwCKPEI5pvAHJhpcJDIm/HZ2BBnDbRw9nGdQ3n1H9GkN3WRmoE0daxjgFZdR+vD1tHw3+OcndLUc1FUSX7lGjG9tlADtwcri3d40I94OfUEJXDelyzckvQk/fUs542eaJUp2rHnakDww5pGCYLFyUyQCTW9Mm65D5GKBAuS+2Rk8ae92uIkVql9rPjHgshRnAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=izFgSNRGswVrvbWqupaMcttliD0G0cUdm7n6fKfxdI8=; b=ND5iQn/zWgbaLBRfWYdwaIVt9yVZIvCqjCcc3yOfKh8DwMHk8dp64ImRWiNTy3uB1+0x1A4i3fGAjM2SDBkD/3hoFxeLQmFGiLNw35er2oEvWipyOwaVzR7+tPPdICBNTnX6lZ88SJ1+/+4gpm3WpM7w63FuNjKKaUiOI7CZjf7Gy2LOhlF8HvstLoq3hCS70NVac2u/5kFYS+TKw65wmmqwWuh+BPNC4FgwZN9X/XUhzNj/MUsDqSMjlXN+sRHgSQ7MxHhphTn7z9odeByPYBU4d7tWgTqjUMyET13qe+jNz7+9m3+WmgPr+Q1yOTC0hJFkFIQAcZaa4dC+DqMZ7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=izFgSNRGswVrvbWqupaMcttliD0G0cUdm7n6fKfxdI8=; b=K6dNsgHZpXs6I4Z4Pgto0mACUwSiRC7eLCZgLc5JR6J6BPOxGZpluVePxi61HVcQG9yYEXadFNEFnSnf/SjqRvfzSnOlOztS1G37UEzi0r+wGrnA7XlRfoCDSi/YKSniwM+0otsYcx5z1qaC4ZIKz1Gii8D9zglSf7Tiodbu0Hb2xU8woSzH0exjVvy0MxxLkSo5LXtHJekMRVMBQ0JxBb1skR5qpCrNahnbGKWvXRcltCFSPCB8mJZpVeQzOXiEsRjCOcuS0AKzVJKMuTTOcSb352fUVKEWdCMNqgZbmAVxzTJ4Cr4KNV3qGlUCyxoPy0NGb6atCUB21zv+a697yA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR06MB6789.apcprd06.prod.outlook.com (2603:1096:820:ff::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Fri, 21 Jul 2023 09:47:22 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:47:22 +0000 From: Yangtao Li To: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Alim Akhtar Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 11/22] thermal/drivers/exynos: convert to use devm_request*_irq_probe() Date: Fri, 21 Jul 2023 17:46:30 +0800 Message-Id: <20230721094641.77189-11-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230721094641.77189-1-frank.li@vivo.com> References: <20230721094641.77189-1-frank.li@vivo.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR06MB6789:EE_ X-MS-Office365-Filtering-Correlation-Id: 0357db02-0714-443d-f01a-08db89cf7b79 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: emk92A8G4Bu7gMFUnbodr9nLJUxYzuUwkYSvPoVRUKZRVSUrF7RFdvZg8w4VWtU9malvJcGTc+ept5A63CmlN7yA+9WxgptNquq9B0gEKfXsk0/usS6Wkr6ND9aQXCi1l0suMzQEbuXNsZ2OARQzTApcr+SmDBA1WRkb//kv90u1IYyow3S680DuiaG4jWPY56B2fyHG0bmAoeWUQIlgKOpUxgFH5lsJuUjctNascUnptddBVXvjQ7mi6o9qq4d/tzEqXvijCqcm0H8a+IfPxMY6h4t0v1Bj/A1PeqBRqmSwk2qX7YZ47LretDO7m4lXR8O/URiFgjRj0m+fhqkIjW++iozjIORjF4ChIjUWt1/3GO6GYBP0KFjNDUhcx9RRp6WquHaci7WgPPtvg+tMVLqRSSR5Nub8hgr8x5Mor9vkpc0vhgHCZhPULdage/UO2dr7F6NSLCyMeIHmU+V+3J+7z1zpvbxSgh5BMSTPEt9ITnlS4pA1uccBROC+UD2iNMnZ6015WfjAo+ij2G167rb9kSUC1bDpsTnyuca3OIUAIeH4qV3czn3pvSpUmrpv6F1xaz2q64F9FM7cnEyVMTj6UmqhkAnt/gHUKaZhtcjO8mQwW652Vq2LlyQ2+Wuc X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(451199021)(83380400001)(66574015)(2616005)(2906002)(38350700002)(38100700002)(66556008)(316002)(66946007)(478600001)(6486002)(41300700001)(4326008)(6506007)(26005)(186003)(1076003)(66476007)(52116002)(6512007)(110136005)(54906003)(36756003)(5660300002)(8936002)(8676002)(86362001)(6666004)(7416002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?3bEQ8q61xVPp5PfNDuVSCnyLsc/l?= =?utf-8?q?yq31CbfnshHuq59sqkBT+qonAwqJZ/7eq7QvgVTjDWXZmjkH0nwejAW2PxT8MHFEV?= =?utf-8?q?hxB5ACBcYi0V/eVY5atkrb3LRVM8FDd672gHIuvM7//4J39AZKjVI2sQ/Pc6ruI4P?= =?utf-8?q?mHQty67csHYAHVwc6S8X3+nkRYrRtFu3Df77R6CVXaR9mH/IxaYgwiIGR3xhHHS+N?= =?utf-8?q?DJB0Q6jU3XJeVRBykXutaEpyFuyxVbuFWGmxQRqFKTsSDVGO798vXLQKNC71sEN8v?= =?utf-8?q?ats+/aLGJBJr3RqLWZ1Tff9ONYuq7GVUjsMy1ERA226d/6+GiQpvl2Bm8tLI7RePX?= =?utf-8?q?xAvf3GpFvUVBstLnZiyBVRVVREBkUopZFneFb3sTu1Ob93pn8OZIuz840Hm5/U47w?= =?utf-8?q?oWhpTfKLhoCJ2WaT8MP+Yf9t/k+JnajHgjVLdSqLtnAXi2h70u4gjfjBT45aH6TSQ?= =?utf-8?q?vF2mZmskZzE266bHZdaQBLvvbwPfCSAMWGsSCpUprdNmxcFJDC5Au0e4SV4U5Y/3V?= =?utf-8?q?M1u6topYhn19L/ZcRBLUKInkq+5Zwks6ihN4CDp2P04iKRlGUWHa6wVWTD9sV8wXA?= =?utf-8?q?V5gnjTm1hHsmfEmxHUIRruFff3ZAk5H3YQnRfBcD9vix+fwjCnqFF8anMWn9NV5yH?= =?utf-8?q?8LrWNx57AA3IBsnXl04/p1lXws0OxWQFXdRQIDIHKZe1dgf7tkOO71llNl4iDFSiN?= =?utf-8?q?OzzpAR14+NRJVF9ShvVttuzcWSqbQcuPrvgbMyVT/9zRmDvhBIAHDn23z1AqGHpy5?= =?utf-8?q?JmtlbtjW91bu3+RJliDhrOIg9T/DfyRGJh+b6A2RM31f24yec44PVlhG6mWSMbgHz?= =?utf-8?q?UIBHSicRxZJ3GUjzsbFVJv2zVbUNjnHDCm/eLnBbdjPP8l2tUEmj5eMRFzqKC2D4n?= =?utf-8?q?Bdw5EkxCTKuf0l/AJhoOnxXo58rwCS/nQBP8bqX+hgX/riv3xxMDWbjxXnscKWuym?= =?utf-8?q?7ZmQtifD8cauN/pvpJM/kcYipX2Fm1Y9M8gTsNY+U6LvMKjCCjzfcqjJ3E/YnLmaA?= =?utf-8?q?0rtAGP8zf0p9nFy7BX5wb7PHOmEplGyy23eek7AYP0KprZn7YyivUBJWMuo/wGfaP?= =?utf-8?q?DQR+lUDhqxHpgciZhCESHVRniLJhRC5QkusGzwULfpcUJ5LSzRcaMG8WbuwxpYVuP?= =?utf-8?q?uOa95OjyuFar3XplHhfecwSJ3FgEFqrytoRkqBQ9AgTD57rTGtc6te5JrEScc1qYS?= =?utf-8?q?7h++zFQP0U74ReFoC8IN8gSrftVG5nUtLTub16PdRUGJSGPXly21fvX4o+t+fSAOB?= =?utf-8?q?9ONL+HKRrYf5GVey2XUgB3AOQIVC01tGYOTQ0TiThKIYpEV0rPC5nz8+xW9WxMwSH?= =?utf-8?q?PMTm9Qy4DbDtDTqT1UrNsx07bHFe0WXTl86NkDZK3eb6IuevAiARjTrjbAc/JGQzn?= =?utf-8?q?tfcimeTLRGYKEVKgDeDVUKoPPARQCkCOaQbmANFhpgGi4Bcai6iancTo+GSLUexkn?= =?utf-8?q?7uoIADKN65AvKXYnXBpsORi5MAOYIBIkR0OVIMCtLqSZ2j1z391R5s8UZTiT03c79?= =?utf-8?q?R8FBMDKFEre4?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0357db02-0714-443d-f01a-08db89cf7b79 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:47:22.7518 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5EVO4XBOLeE6hIhifWu7A/5dRljc5ycb2D+y3S65tEwJfgHbAjtkuZ+Kskou6Pv4lbiYeUo8SBO+S753utvyBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6789 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772023852334366713 X-GMAIL-MSGID: 1772023852334366713 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Reviewed-by: Krzysztof Kozlowski --- drivers/thermal/samsung/exynos_tmu.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 45e5c840d130..697d2fbdb1bf 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -1100,12 +1100,11 @@ static int exynos_tmu_probe(struct platform_device *pdev) goto err_sclk; } - ret = devm_request_irq(&pdev->dev, data->irq, exynos_tmu_irq, - IRQF_TRIGGER_RISING | IRQF_SHARED, dev_name(&pdev->dev), data); - if (ret) { - dev_err(&pdev->dev, "Failed to request irq: %d\n", data->irq); + ret = devm_request_irq_probe(&pdev->dev, data->irq, exynos_tmu_irq, + IRQF_TRIGGER_RISING | IRQF_SHARED, + dev_name(&pdev->dev), data, NULL); + if (ret) goto err_sclk; - } exynos_tmu_control(pdev, true); return 0; From patchwork Fri Jul 21 09:46:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123721 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp97848vqg; Fri, 21 Jul 2023 03:09:47 -0700 (PDT) X-Google-Smtp-Source: APBJJlGA6ZpWMyMvCpHxhrLEaOWKeB1B5liHDBxeiSSapBuhDkUmB+9yIhJk8lkG9o6h3Sq4fXbn X-Received: by 2002:a17:90a:6342:b0:263:e814:5d0f with SMTP id v2-20020a17090a634200b00263e8145d0fmr1186069pjs.41.1689934187565; Fri, 21 Jul 2023 03:09:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689934187; cv=pass; d=google.com; s=arc-20160816; b=U2InpxQfA8Mc//gihNzkcdP3NBo2Sni4o3O+u0DdwA6pY0zjMI/qhABC4Q2HXDSOfz 9D18vCAN8ctXv4Yk7DaChAXXrIn6rp6w0MHd9uNiTFGFW3D6xnHC2JnnLv9Llqp/ClgH BpDO4FjaOG9WxlYkwc9LN0K98kNy68PcsDB+8zU/gHAOWHnDqSYElV/p7ln42ql2gl6y /tCljRZ/6tKyJrAON8/N2vUtR8kDJIhqtaxqKYIWFQ9Z+fNvxA6FaJ2+JVfoNxULO/Um ephZVnnZ5CBm/BD282sqSO0LHy+ut3PDrLksQ6ah4aVflDKw0k9UQU07qCF8yesvzCND om3Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Q2g69HSmEHuTTYKyKe+Ic9ejjUzfByis+TpAlcnSq4U=; fh=KTv2T1r/QNJZkf7UmS3j/ysaXQ+6ICZoxyH0IbK8Eew=; b=Uv6Ks9NZnpMK3qNjhT4fX+oxx+Qm0ZHwLfDCnZiNYHrkYMvYWHESt0oSAYgLrU0Ght 88N51qlVyyl6LfVC1jiDKlDDDYJ7qRdn/XdrVSi9FQHbLRSm1ncAK+ntWGr+gSnYHHHj rBToKukF5lX4jRv6uPjtjbLDCwKaA2PxTrGRDPzKXp/b90OE3bkEeVp1kdWvvYwDsQ/k 5IibNI/EID/4sqG/OjHc8DOywLdVkGNbh/CVpUodeeYgTgd5aQwb797l2pQn0ZsoTn6S P0DJCbcTJyRMT3GBB0WuaEGiRqak6uqXjwpcWJd77Udklhjd5CoUJtcS7eZOrwBie1aV VOxw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=YTb6enSV; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o8-20020a17090a55c800b00263a923c189si2906273pjm.100.2023.07.21.03.09.34; Fri, 21 Jul 2023 03:09:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=YTb6enSV; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231915AbjGUJtW (ORCPT + 99 others); Fri, 21 Jul 2023 05:49:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231908AbjGUJsh (ORCPT ); Fri, 21 Jul 2023 05:48:37 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2095.outbound.protection.outlook.com [40.107.215.95]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D0B12D7F; Fri, 21 Jul 2023 02:48:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AAlvYNOHbLRWL8dkY+rxaIkaylhb9PZ+z2o+5wurx8Hv7qgyZ85exdWLRFYlJlBMzSfo2CRljWRJcPPtcM01/0k5ooGQWZYgWrFmuDseiS0yqgzE+tGh638cC+rkHteO34r/CW6FDO4IcyyJpxvXgBEmRdAxNEUyWtAB+Ahe+BXuslLs73VVIKA3n9rUtovnWTqk2nNu2Gws9KVRvbf+Fjv46MXg2kNKzt3eAej1tjWGsnvsF2dEqvaJ1Wp1V67CVvMu6FWwrY5rDWc2Kd8Vc52ADSjAG6ipgqd0cqN4CEi+5MsHIYP+dxNI9kyT05Vx2YzP3iZLGHw3KLMLJ5AjEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q2g69HSmEHuTTYKyKe+Ic9ejjUzfByis+TpAlcnSq4U=; b=kZsKGoO4Q4fhuhAEoJzNR/2PMJROpaBDPllmeHrVDKB7xnrlKInRj+o/BPemzKtYrenwnQORgKjTXPG3hcCpoJ+Al7GVxUVgvLTbIATSpfGY1WbK6/kVxhblsppKUN+oV+52V8BCo1dx/rLqT30J2Gy3si18eSUqhuP6pu6K+Kt383VFHz3ycJ04MYta8Wx9EPyrtkr2CZbuXkp7pBWMdYtK43uExFSXcZp9NTsau+eqU9c3KOHYsTbhbL5ZdMuew0OdubRuJORfAqMYpvT4pmTckcUXHCNIe9R8ivLjLrMhLAFemju2Kv/4pj4Kz5b3RINS5pZ1P4Ry3j39u87Cpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q2g69HSmEHuTTYKyKe+Ic9ejjUzfByis+TpAlcnSq4U=; b=YTb6enSVBUaz+anOhpMDaLr+55YqGeXHhuNnCgZ2ki7Db5AOVri/B1zUuBWny/HyRQPFqFnYbM79fzC9cF9FZb0b/z8txIv15AxN4FBXPulcrUYSmTtOBuWXwOrTA2JLImVEGFphBOt5/Pd+btTouoVeV1lVvF6/ngjZTOz51wW3IrH3ETqZwa1ByOa8QurqZoGwVp4//h/q+hb8ZQdXJ1ludefNzqC2lj172wZexfsIwrlkM6FgKBqtpR4qqYlj027rxYbGC8sV3UNzLRRrW4ElVe8dVWospzAFXKrVrFQnTC29BOzAihTVxv/k6kJZDIuluA/8CKVUW6y3o4ydvw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR06MB6789.apcprd06.prod.outlook.com (2603:1096:820:ff::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Fri, 21 Jul 2023 09:47:25 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:47:25 +0000 From: Yangtao Li To: "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 12/22] thermal/drivers/hisi: convert to use devm_request*_irq_probe() Date: Fri, 21 Jul 2023 17:46:31 +0800 Message-Id: <20230721094641.77189-12-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230721094641.77189-1-frank.li@vivo.com> References: <20230721094641.77189-1-frank.li@vivo.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR06MB6789:EE_ X-MS-Office365-Filtering-Correlation-Id: cb0de5b1-2c60-4176-d00b-08db89cf7cce X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A94iBdEAKMIA9jAfumInEJw6Gxgt23CRzdQ8Cenkvwd/do5Y1Y9LG98albR70c0NFvKxNZ4ugQ8pHXnmm7lxEMhxur/8wOjZdNe1VmjAaquXlOmOm1JrlxM/u/YwMI5jt6zv6o2f66D5AHFnQn2efP4WJM3cVyidgdjrEwAl2sc/FqwrsUYc7E/g2swqku2YUbafxxrNA+3s8TLkFgImFBfDJuqEYh7N7nwgDs/b7tuOj98Gpv6OF5BxHg6V9CkfInG3+OmYQVOKdL9YJpiWvBHloz+cs6lPGh2eQ0MOFbtxQkUaAEClR9K89qh8pez6UW9axK+Y5n2fojjKCdKFX80jJZEVgK2FKInQneqdPHZzdPBl+SSLLKmFIIcD4/SztxX8wCkDokm29EZu1CtFoQrScwArYSz4Uyo4tb4fR+M4bk2LskLhxnBkYQ8M9BOluWKOemiiLVZjNpOcX9Qy8ExBBj+O/XNgtY967FWPZDQUK5xs37sV9p0LhDn9r8eGYN7GWEJXR3UyiYxuaAmj/V1J0tDQOHoOhBEVnxuTkK82G1zFk9s89KqnDgabH2Owevb2ffvdpA/SHZmybtMa6JebAsAhpT6/t4uz2syaOIvFD7TZNw4qrhibjRtRLo5T X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(451199021)(83380400001)(66574015)(2616005)(2906002)(38350700002)(38100700002)(66556008)(316002)(66946007)(478600001)(6486002)(41300700001)(4326008)(6506007)(26005)(186003)(1076003)(66476007)(52116002)(6512007)(110136005)(54906003)(36756003)(5660300002)(8936002)(8676002)(86362001)(6666004)(7416002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?pGKIrrhK+MC+k/RXR4YyS7KDDxYY?= =?utf-8?q?TnmfgF624DFw1fDl45gHEF2InPoQf8WWH8i9WXF2zlUDxGemxjakILE1UZnLVN2+6?= =?utf-8?q?hEtFqYOfccvQplakcIDN9jA+hH87XJbQx10uDL289eb/kUdG3NxEiZR1bOLENKtbV?= =?utf-8?q?eN2TqpSJHvaatxbo+a6MdGSS4E9ilfotwwcLAG27jepLYifNrpaGc3xZxtYVYBdLL?= =?utf-8?q?hRRBpuy55HgCahw7GIWCyQ96lypFyeD4I352VQ/0r0DpeJ1vkGr/OoTpcdXB+26qH?= =?utf-8?q?dz5KlEGK8gM0+jsf5lV8ZOj/bMxTipgJWDd9Mak8IBb+/zvvAHNYAPmdzEqv18RX+?= =?utf-8?q?UPfcB1JxZsaJJ6XR+foSvtcE/ZiXDcUGJS65+tZAGFuRFaywa3CY4KFtovbNzwobc?= =?utf-8?q?dELLNx5/48HKHix/DZS+HNqdGAvCyew/1xx+oECoU2BulowOMZ6+rLjDj7cr6bA6l?= =?utf-8?q?PMLN9sjTUPgvRqLaJ9HdVldCZde5roe3nFHurae3m20yQA740PV0w1UQgF1qLFSoj?= =?utf-8?q?RlqSQActkNlLUSp8I4+/nl4TGBN00erdxYHOVsidtv18KbRnZ3hUOpEuWCxC2mCft?= =?utf-8?q?uJWE0fzzzRsfW1VT7bAkuixDwVCDsSVVSPp78UmA5sU9bs/6gz16n2Hh/848TsBPT?= =?utf-8?q?WdDtd0P7n0CFEdcW3JRXoZ5usp+ZdGPpH4kAkqFGC8KbA8fYm6vL5IxGs3+/vqk2S?= =?utf-8?q?TGGkcEO+/v4Qe7hr7RIaQhWjn+MvHYfq8NziYCkBjbG1XcxJoZisUoRV0OeXeV56S?= =?utf-8?q?PWmHyCsFmEQXlSdgCgw7nCn+IH8YRD+j8/bpRBzWTuB0M8dPLvCwABPk0oH33kJbL?= =?utf-8?q?zTr7ftwVPDKvOn+pJkm3zXsHPgahTyUCM4A+NFv84RnVprhIyqgrp1X1dg9gto7b7?= =?utf-8?q?j12+4TXjwqI53/GngbTXJHO7YDMVZiKbrR62NirK9qJJLxEy3ARyknWI2krPAVFZX?= =?utf-8?q?oxftHbg7qCVVvcHpPeEOn5z7Zjw5qZC2j4I1S7XgXtp8WwXuY2GO99tQI+fTpHIlo?= =?utf-8?q?ySd4vuWVSbwpQC17HVRhYYzAaNKCdRy+ZgWOiVpfQFZFfbvgb252cxQtmJUOINA8E?= =?utf-8?q?RfIu8X+Z0bctCrOrF3h5Jznc0U+2rogDNfMfZSdsv5ezoUcdshcZgd+4CUwkJTqgt?= =?utf-8?q?aqSWuZ462wIC0B2iBgs9S4Bxrk9BAxKU/n/r3mLoX8/Y2XgrUpoYl7joUHbaDLZf6?= =?utf-8?q?8HyXOPZNT4qILuGxas50siKLJJxQXy83p8t3J5GqdMvG4NlLia/TfUSSDLDhZU/d9?= =?utf-8?q?dmqNfn9xj+yxR4THMRwdg158T2jvHDcLH05+ThFnNx95kAyh3nWeYCJQvoJAVwidn?= =?utf-8?q?E4iqWq0pmoAUXBcXzbUqPWCZudkWgrGCDnF4+1A0NoUodgpw5CyVbviNRNWr1IWAi?= =?utf-8?q?//LDu8ltUAO8zLXM8a3d0JJWcPQDQrl0tj6pJ6cOEVWu9itOwzxsMfcM8Y3bTvq9H?= =?utf-8?q?3Zt3dxfHf3y4o65HCXCabvK5QvfLs/BqQ8MTwi8LUG8CxnKjQnEbpO8plqJx9szzg?= =?utf-8?q?ISLrcqNlt3gT?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb0de5b1-2c60-4176-d00b-08db89cf7cce X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:47:24.9605 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z7S/F4KsXjcZwEmXyB3eJXKExHfOhS+U8UsY7mMnYWZqkejnM8pEXBTfvZGUJTFBwspFpOjjBIu9xhIs05xw1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6789 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772024431099975850 X-GMAIL-MSGID: 1772024431099975850 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li --- drivers/thermal/hisi_thermal.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c index 3f09ef8be41a..ee5f50fb2b68 100644 --- a/drivers/thermal/hisi_thermal.c +++ b/drivers/thermal/hisi_thermal.c @@ -576,14 +576,12 @@ static int hisi_thermal_probe(struct platform_device *pdev) if (ret < 0) return ret; - ret = devm_request_threaded_irq(dev, ret, NULL, - hisi_thermal_alarm_irq_thread, - IRQF_ONESHOT, sensor->irq_name, - sensor); - if (ret < 0) { - dev_err(dev, "Failed to request alarm irq: %d\n", ret); + ret = devm_request_threaded_irq_probe(dev, ret, NULL, + hisi_thermal_alarm_irq_thread, + IRQF_ONESHOT, sensor->irq_name, + sensor, "alarm"); + if (ret < 0) return ret; - } ret = data->ops->enable_sensor(sensor); if (ret) { From patchwork Fri Jul 21 09:46:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123720 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp97720vqg; Fri, 21 Jul 2023 03:09:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlEYq9P3srUH5dTPcb+v4MuiGr71yVUOl7g88fq2BRd5Azwjfg++44HKQcDWCYsQ+TJGfjrb X-Received: by 2002:a05:6358:6f85:b0:134:e458:688d with SMTP id s5-20020a0563586f8500b00134e458688dmr1321250rwn.15.1689934171850; Fri, 21 Jul 2023 03:09:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689934171; cv=pass; d=google.com; s=arc-20160816; b=XtXOY1GOZ6PGLDFQ7zRk/50KXCuJwPJ/vGiEoyHTk2RVHsIC4iQEvzZ0u4aRgZjztM GscEmf7bsPpr38rrvUGJQv7/h/SXIEs285bKHG3ZXPiGZ3+4aYfGYxkllG957FyxaXq/ UrjyxmyhPUkJLS8/ksUUKsdHEU7tzLstqq2Fe/nHPihQdppasCRrzuoJTX2X05C1gOVN Q+Ef04E+XITFj4hCthF8EeD7D90ifA/xXXiSf4kSPK4TTYImNYSPytQA2nuqnyjHD8t9 e6sVTFjVS9o833JPhJqN/VGHs7Qy25B3nwgV6dqtUccb12JmQAL3pCnK1iwDzydkGO1U zA7g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=N03nusCUS3siQa14uFSaE/KiicaLWmrEtJVE7dkAQQg=; fh=CnR8Syx3nO9irsCtZbaMtkSEmTMFu3PAABqjMiP67T0=; b=NMRA+EVIwhSdWQmZoXTgI0mUdKIcccqwGFAPtv+zm2DI0GcWdqff7oqyDdt75ZLK4a 7FDThcrQuCBaix8Q+3dppVdC2kW3A/xTJr84GeghrH2ZrSF8xzrIbTtv30Hii3jwTEEB ATmq2QC4bIPPX6EAFJl9mBOqpvDPWr2VGPq1Q6ZlOkgDNft4QTcoGP4+8XqDDvi6F0U3 vyyT/X7URXLBSqEtlQroaPzVl9JHSnyMttbkToNCX225hzXIrx5LWOiSsc7e52MZwytd +WU80fr8N4VBoXYFaVvydwWYUP9UWTWoieYFCFWWxNVyMqb+L4X4b7IbptnHyPh3WgWr QAtg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=YmBKuiCv; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e7-20020a63ae47000000b0056345699503si2595646pgp.2.2023.07.21.03.09.17; Fri, 21 Jul 2023 03:09:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=YmBKuiCv; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231830AbjGUJtn (ORCPT + 99 others); Fri, 21 Jul 2023 05:49:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231842AbjGUJsy (ORCPT ); Fri, 21 Jul 2023 05:48:54 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2112.outbound.protection.outlook.com [40.107.215.112]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B05343AAD; Fri, 21 Jul 2023 02:48:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KnbokOjhOVtCzeTlxV/MiMVcrCx6WzlGT6gdTYl0h5PGmxdNB0sXlYn50aksdYEXZ8H3MndA3E9MmdDaYHRfJqZgY4SJNjjZmR1xji95d58IE9MPpADbQCkLIGOnjx5nIHIa6I9gjSjIueF8S1PA0fQCypxyXAp9x4eFrsX47x+43eWimc/tqsydCb5DseU2XT5YM21YiXzpQfROxFyQ+BSQBDMN8S1bVgI8jz8IJdGpTyY95bk2Glj+6C+EBOeuywiGj2q6O8a/n2tV9u2djp5ZSLd5agOsDEfdEzCN3mhp9snHD99s0F0XCo2f2sQQHC9Vf0/03QYx3DaB307kWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N03nusCUS3siQa14uFSaE/KiicaLWmrEtJVE7dkAQQg=; b=LrAHWHmEeSNXRkuD4wRPGMHsqFDa//bxSNhCqQgPah9G9LuIVRU6wSvSOx1Nn5B/5ErYkFGTL9T6jGLUJdemaSyG2hrMg8rTa7oSVktYQaKpwshkvfgaI4GVD7lIiu4aKAEB1slNkW+F/cMOhBgq9xg6s2tdu5x8yLhQl597RMzbgyzDcULqzvpyZqOnc1zCucuFYpux+3xL/aoUAzbADH3GMN14Oa1ey8W0CAdiOEJlXf3az3Syx1f7fWxK2Q485C9d7/JOXI590k4beTtGBTSwuk/5bXIVqYzDnmRWVY+k7wYMd6etC8QvHDcrmoH7qwWGFlRD+8b55DyXJBv63w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N03nusCUS3siQa14uFSaE/KiicaLWmrEtJVE7dkAQQg=; b=YmBKuiCviNQBuNCuzg+QTbpGCyUE+jyOIL7F3SS1ND8w3sLMMSRppFhQj3s+OfekMjh0oY0e8tpzA9/Yrif8DwJKM3wUSaudAVvj2yB6LEBZMNX9Y6/TCq1nkhksI0am6utH8ns0wRZCQ2x2C5Ff4PLP1V6+dPQzk0yA9uPVUknR3KpvNs8HK0MamPYtKiHKInZ3GVzV8em+c/g89nyxmx7V4cEmCX76r6RGWwbLrj3tV25M1QyyfyB1D8rk7khbbhEccIDWOhqxX+QKB9GosnLERamGomXYO16afyY44C1MlaUwfSVBM2NbV9cjC0SjUylPfdzqrQ6u6ecWo06uKA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR06MB6789.apcprd06.prod.outlook.com (2603:1096:820:ff::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Fri, 21 Jul 2023 09:47:27 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:47:27 +0000 From: Yangtao Li To: "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Heiko Stuebner Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 13/22] thermal/drivers/rockchip: convert to use devm_request*_irq_probe() Date: Fri, 21 Jul 2023 17:46:32 +0800 Message-Id: <20230721094641.77189-13-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230721094641.77189-1-frank.li@vivo.com> References: <20230721094641.77189-1-frank.li@vivo.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR06MB6789:EE_ X-MS-Office365-Filtering-Correlation-Id: 48502543-e9ab-4a7f-0f0f-08db89cf7e45 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ukcEb0DILkyCxXqQHdNv7ekvSDDN/IrjTYQ6bMeJpKOdrfo8Fsk3R21A9yayXa6DM8Cgcwne+5rOH2Hk0jVOISLDX+MjssZ+416rtntKXsRVn+SFU8lHmT+gnMrh6cfa/7A1az7SDuEcbMTOBUyWu2gsmCEuB6D3+9PQ8LQRhaQ4/cglfnSfB9GOuh8P1RkxH0NbDa/76cVmPbqlJinrLysZN1sv+4aSyOVtWcYSmjbgfiv5al1AcnEiQ8JjZGsg5NddfDyacN3/VxR7Ud0J2wD+SdBA/abrOJpV3k9Q5+CR8r1zUrQBuo2IjWsaaAKWKxZjfF8KkFpEJay2J830Uvlgj9rpGbMvgukRKmBeHVBltVgzE3wRz7TJWfAeO5p5HV7+3p/BJeyr6PrJAaJx2vYuvXNFtef9iLDlRy2xOMG4M59BeXqVpJ9UuKMuWNmFagwnIKgPZ8UMlVvMjaGLlZMhqh/5XDjNplzCT9hR6GrMT/LpX26zvPFkYwYZ3fNceS6e7LHSGbwNcMYNRqNEWR6iKv+4VNoNqlLiqevBClkPhzUgGyIUqQWzE8XayPPNSBr14gPBSh4QqRm0UcKBPJVSS/Qd9Sl0Db6OvHapsDR0vDuAIAdZnF+HDDuk9Vd/ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(451199021)(83380400001)(66574015)(2616005)(2906002)(38350700002)(38100700002)(66556008)(316002)(66946007)(478600001)(6486002)(41300700001)(4326008)(6506007)(26005)(186003)(1076003)(66476007)(52116002)(6512007)(110136005)(54906003)(36756003)(5660300002)(8936002)(8676002)(86362001)(6666004)(7416002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?QcpomNZZEPC3zGuzBEjUgBAvbOg9?= =?utf-8?q?HtFcGhK97/PwXViQ1sbJ7dT8n1lBpFckkUapW2bs00a1dQc/StuQ9ihHefUgdR7t5?= =?utf-8?q?Eyastexp+8WGjW5GTV+c/0JcnEnNNCj7D1Fv02qUa8xDH23MPLOkxcZ4tLGrMfWbs?= =?utf-8?q?nOni3D807T+mIB8R3TeL1mCzFO7dgnRfzuhSsyC+3NNoFQkdwLVMqhagweYQpR3Op?= =?utf-8?q?fi7IclJyc/65avCJWDSsetNUV4/IeUnVL/hqFKpEI6LRCkwQFnGG7hH5tX3nkFylu?= =?utf-8?q?oOhW7NF7ckV3mOvi9TxTP5hqrRshuBNZHbn5Q0ZPxYgaceyCfn4n8K2Q4UBOImDLp?= =?utf-8?q?77J0QOo/sZggiKdmluI4Sx+4BXwmeEcBZReE6DO0WBlPyyOQ2/T1Uwk2szaDOGROH?= =?utf-8?q?Nm/inFZDJQpaulUYvXB62PSg2AA0XDdnos1NgeTn3cKYoFTGc2L+09OPKZrPgVcJ9?= =?utf-8?q?CB6QnCfTUC106HBD5k6nWklgFUiWFPjxmVj+Em6ITZ1R0e+cIiG0YRfaAqbXb04/K?= =?utf-8?q?vdyp8O/Gc7k6pdTA/Rf1BlegncQrom3MmPBJq0Vm/OZozSJOSSb/SKb7dMQ4q+Iia?= =?utf-8?q?Q1py0fVqF6C0k0UfH2f3JYcfBGmDOd3fo4Amo0FvUvXq4PCEmIiYuYDJ4+KaUwCIN?= =?utf-8?q?Jkk9mg7T4PzCA3FzyCjM4lWeWVCyj1XrNylPaSt5F7JHnyU4aIhiVVUAWle3EMtec?= =?utf-8?q?eXx68EULKNxz21pkfv3BIbZYcqMM3g6yeoSyUCFVMg5+7VAwbqd/Dr1E4NznEZwS8?= =?utf-8?q?eDjmwtQgPDr+OV0gt2UH55Zme8LRgu51c5iYtzcApOQrvLGldUIN/AH12/IwDLfLx?= =?utf-8?q?aqBL7S5VRkQOtl488Ul7z41XsxougFcHqKY7WcYAgS9XYMra1UVi+eb/o9ESk3Jy7?= =?utf-8?q?R5UcGAuIfRtFM1kiIKgZ8oZSyLjZV4izqKgUrDP28dsZgyuCFPXcQz0JVde2lWfCC?= =?utf-8?q?ZJx+BOkrEVy+0lSmvzx3QDyU90W54MddeeA9kguSlM+EjjNlUQ8Nau0QFO25owEdh?= =?utf-8?q?YxyfFNRMhsgXXOuKusMr2V+2yPgWiD39uRAOxO/TEk9c9riJ6WRY1XOAKuEd8OyXI?= =?utf-8?q?3nIooqPcvytqJV86Cp0NsitQdeXBliqFDymn/0xvgkPt/81L+qA6ORjbZO8weqALy?= =?utf-8?q?KHCh4vB/7Tg/jJr3zltZAfvf2ZmZZBPiMHqT0uBfBVDkglNcJfCb0tDFhRvG3BPVO?= =?utf-8?q?4D4Cj+YxnxkvYxpg6YRq3+HQtrcPygN3Otm6IpE2dT+D1NODYDbZh4blJVed/lKKg?= =?utf-8?q?FXKqAGFvzd2EjabNWCAfZgbfO5v+l1Rno9PJfuqY/6Ubk1DlrlSkg2GQgd8GL11TX?= =?utf-8?q?/d7W12A0HhikrYJQyCvRTwx+7UniIHnqjdhzGU/Tv1pNEok3KuLMTNO7brkgvXB08?= =?utf-8?q?dg/G7Xhi/QxESlcd42A8smVbCMc5vhcFggDbLedF4ac7zarW201xXI14t6gwQnkPl?= =?utf-8?q?pQkSdMDbNXqlNyBQtOtUNU/nJa7CCSJNfshHF/x8YKOL+FQj6DBQ3UjR7X1GNrhkb?= =?utf-8?q?lfcry1zTNR3T?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48502543-e9ab-4a7f-0f0f-08db89cf7e45 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:47:27.4223 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 98HfIkJnvUzbfPH/v6gTYOVZQe3WuIa3X3f84vvDHhlKY925sYAuXfUsOSZdLQXXVot0RLeLfsFL1rbwny6f0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6789 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772024414044508841 X-GMAIL-MSGID: 1772024414044508841 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Acked-by: Heiko Stuebner --- drivers/thermal/rockchip_thermal.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c index 77231a9d28ff..11061f6ef323 100644 --- a/drivers/thermal/rockchip_thermal.c +++ b/drivers/thermal/rockchip_thermal.c @@ -1577,13 +1577,12 @@ static int rockchip_thermal_probe(struct platform_device *pdev) "failed to register sensor[%d].\n", i); } - error = devm_request_threaded_irq(&pdev->dev, irq, NULL, - &rockchip_thermal_alarm_irq_thread, - IRQF_ONESHOT, - "rockchip_thermal", thermal); + error = devm_request_threaded_irq_probe(&pdev->dev, irq, NULL, + &rockchip_thermal_alarm_irq_thread, + IRQF_ONESHOT, + "rockchip_thermal", thermal, "tsadc"); if (error) - return dev_err_probe(&pdev->dev, error, - "failed to request tsadc irq.\n"); + return error; thermal->chip->control(thermal->regs, true); From patchwork Fri Jul 21 09:46:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123764 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp110818vqg; Fri, 21 Jul 2023 03:37:24 -0700 (PDT) X-Google-Smtp-Source: APBJJlF48ZgtkRH9ekITOEd0xQG+QzKB9dVBUISjfkZAwh/HSdQ1aOFnMl9wzIyxKm4oTXzL29Hm X-Received: by 2002:a05:6a00:134e:b0:666:8403:9f4 with SMTP id k14-20020a056a00134e00b00666840309f4mr1664211pfu.16.1689935844484; Fri, 21 Jul 2023 03:37:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689935844; cv=pass; d=google.com; s=arc-20160816; b=WhIH+ol/AUFBbyZTEjubQQyMdhk1QDMQ24Z7Iu5nwwjtXydDQz6Nf5kjENzGgQ6+bU JxjfiSDKrfNznfouc6femh0heqqdp6iaxKWfqMt8mShjWE+M43yZs1En8YUy7CH3aNOI TTawhAK6GqgivItkuNpXHgoHDD2sYWrvBrFdr9uZVYkaWakpVKDlMr1mXNf/Cb7FY4Xt JXoPg5e+lNemzg/5D/Hm4JYbOfBHo2yFR/Y10U1XUdGaPMHjXAbGxteA4Zs8QFC83qx8 i9RmRCBWM4C9scp+se0W8MWXPGHP2GFqeiFDZb/YRWIEfWMbuUmtkyWWsN5WpyO/EfhY YwOw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=pvlUx4SI67RgVseXdZyvUk2DPAtSbRfR6U4Mi2B03kI=; fh=sxeFmz7RQjjQwqLws0K8rtszMe5WKHMoJMYolzjKDqo=; b=fa32tJ8uSdcTcjRjDbza1iX3rbmDc+y17pFvtDC6WPVON8jCaUYCUqEOjprXAxZ8lo 3zVMA5PfxAqtLyM3gV8x50N1JkzSrWPTWinaeu0+i8t1VmMw0chfVJk0A1/TEQDOmVT6 deAMr0PF1OKoIeUh8iZCkNhv6ZON7Gdc33B/cSvSqpqJDoT1enVyNfCzFr21zyCEFLXC Z5bMl2N7Jza0bFiA5gqBTqP5jLIPPhtn5K01uOZ6tRIVNzSFCcuKoS/tYnJBGZZq1bZh 6PyoYG0WijCzOOKPwu6CRjr3XNBZ1R9rm/Gjarq9ZJ/ZJCJ2PeNxHPWS0HDXZWb8VKl6 Nbcw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=UO3AkBA8; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bx7-20020a056a00428700b0067b8602aa15si2812871pfb.135.2023.07.21.03.37.11; Fri, 21 Jul 2023 03:37:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=UO3AkBA8; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231938AbjGUJuH (ORCPT + 99 others); Fri, 21 Jul 2023 05:50:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231922AbjGUJtZ (ORCPT ); Fri, 21 Jul 2023 05:49:25 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2095.outbound.protection.outlook.com [40.107.215.95]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1415D3C16; Fri, 21 Jul 2023 02:48:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kPFvUYegnG5ozoxKyBEMTaD9W/enVEZu5/0zXSHGktpLCTch4I/tCcYbhnPSdvEkKKZYsfcnwn/NfY3LQ91AkNnTsveje9Ljff9RtWmY//J/yMe/yTVtu9gYx80tWBnekuTw+rpefJE2ZeTBw79HJgrP9a30r5Lrg8vqMRLcs0/rKYbPJed2mntGI8dDPNLjfvLozTMpomjaAdI93laepATwKcpghbfMhMykC46Ep9OskhnPScRGLzuyCQhn884R+0jao/oasrH4a6P2cx5wQamj0EoCBxWyVcj6z/RX37VaT0aw+g9VZBw0LZpac3ups/npq5ItoDegC+ygdkOgkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pvlUx4SI67RgVseXdZyvUk2DPAtSbRfR6U4Mi2B03kI=; b=MuZwVfKqCT4z/Dg2qluTfZQxB+P7Kw2gd4Krq0MYRgEc3sa3HQmFfKl7XrO4OVA+/zfPl4X2qG4vnL/4c6IalBko6SniPLH6djqEupUUHCc7bk2ppBYdu2q+UWxBpt1ZZgOA1jknGFqQ4JdyDm0pJ530hogXNsRkq0oea2Dy81HDr792e8elN8+Ovy8whLsd2dg2TAT2QRBEHsTyJYpU03oUFPDuNIxldNJPd8Vslg3SPqdq2GCDRUqpTq3FS4lIQMhwox1e18flwfM1m0SjcmQK1tr/TdoaPm7s2Op80nPZMG0pZV6sjRM0aAWlhB8ThxGKBRPbxMlexnrEb6wW7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pvlUx4SI67RgVseXdZyvUk2DPAtSbRfR6U4Mi2B03kI=; b=UO3AkBA8A7TeezaYOAAsCt4TPkTigpciotg0Fq9ZWryUvjHvVqYiN712Cs6FWCLpEujeFXlIpUyZYbwa0TAZJ62mf/UEjuyTRZG3Iho0uxH718K/oF5nVoP+Wl5PfUkgnDJa/C5WTkg4RrFF7bc0c6ztUZZlP3PlLSOQXAa8z6bpAV9gItLS/qijLjQfCDHMeambaf+IGwDTYydSZ/Z2HEY/PFnfzzxkSWzen3Rd+5+/SHg2tspJh9eLORljVwpMmV+hqEjdQqV5eLGCccBEbBtJtGny8OQTomnF53pOQjwCP9rCTNSRKeP7dTxYuJYjh2EjEfMN30vs2YIQH0PlgQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR06MB6789.apcprd06.prod.outlook.com (2603:1096:820:ff::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Fri, 21 Jul 2023 09:47:29 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:47:29 +0000 From: Yangtao Li To: =?utf-8?q?Niklas_S=C3=B6derlund?= , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , Geert Uytterhoeven , linux-renesas-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 14/22] drivers/thermal/rcar_gen3_thermal: convert to use devm_request*_irq_probe() Date: Fri, 21 Jul 2023 17:46:33 +0800 Message-Id: <20230721094641.77189-14-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230721094641.77189-1-frank.li@vivo.com> References: <20230721094641.77189-1-frank.li@vivo.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR06MB6789:EE_ X-MS-Office365-Filtering-Correlation-Id: ef273c35-cf6d-42e4-ec06-08db89cf7fb8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bbklQOWFMHFTb+hMH0tsGtZSvFKEPRSkYo5sonnhbJw9ZuiWUuR2TPTwwRycjNR9gUOj29SyOfz42yMpCtTSavosMfpRu67Ctc+YrCBCMOESsPsiOY6A6ujKM6PafSiXtwYC0vEoC0x34NWFq2N1lM6FKJouFE4WsV6JMaaHHbpKkMoHNRKw107AlbpPKFq/3dGL2CTu+XWiOYquJuP6VB4RFrQaKCH6gA2y+KzDs9PyLbNPvNnkdR5akFv9VwlNSjgHuzSvefE615cIH+ZsA++86TueqAc4et0JX756MnR7v+EwbW7CgIx8yZXneHD3kIuapUHAyUrcSRgV6+p5g3AQROObceXBnT63WJwyoOSnaISK7D29sw1xeWmmCqPmVyEFWWE6i1Cel0umBPE0Qzq+G06r0XHgWdYwgm/zCXCWjEg0QFxnpmV+NOMAO2gK4BHonm9ujjX32K+IehIE9E+t763WEERYFjVhNWU7Z4xHNO/RJAWzzyyy0X+c3kydQ0I8CRFo6YRal8Lhk3OPaPE1vXKosKveBpBSX4BUvPfMaJnq5HygkkM24Z8zSveV/g3NhYad/eKW7xM32z+adSyYeu2N+Cxmneif8L4jq+PNon/+HVYZz0aBhPNEt2ax X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(451199021)(83380400001)(66574015)(2616005)(2906002)(38350700002)(38100700002)(66556008)(316002)(66946007)(478600001)(6486002)(41300700001)(4326008)(6506007)(26005)(186003)(1076003)(66476007)(52116002)(6512007)(110136005)(54906003)(36756003)(5660300002)(8936002)(8676002)(86362001)(6666004)(7416002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?stpRONE1nuHggfB5b3QvnBC8Kz8z?= =?utf-8?q?SP3Nl0z+ihD2bxvOS9t8xlYglik12Yx7KXhhJdmjPWqmp+vGrp01Er7IAIGuW2EaN?= =?utf-8?q?puurNDO8BnHp3q5eLP3h0VW1MqYu8ASIW+w6L0XGsySbfkCp2GKQZhrwHZ9oATKvm?= =?utf-8?q?8P6WquYlzuXs58g7M61Br5E2pnzW3S4GkURpa7RjxrSrHIo3Cfu2koX/zjyyLr7Fg?= =?utf-8?q?YEKBecYqHIRjvi8zJ0aQHifv3IpBM1F+EZYRuPIlRgzBH6lpZabJKr1ognR8JqUjc?= =?utf-8?q?iCtAoZQuX6dOJ+FQbONElsPNDF/noOsOgBJdQTa7lPIcaVfpOcZK7USttTXJC0Uhm?= =?utf-8?q?y54fTyaBIVQrm3R8nbhVKeHcQaE225yJzVY3LuBK+VEYoboLaV6gEzSEJc1IGZ3T0?= =?utf-8?q?g3EOseSfMd6mG+A80yjNl7fYrRfoMJGDQRwoY2+lDSyscwyHeJ1lQanACUAXg5Iph?= =?utf-8?q?ja/gxtahk33uzlWEhELGlsVpfkmytUwaVmL61mqkmteRK//m7UKFgS0n7DauMF8qy?= =?utf-8?q?pzirIQQUNmnT3rGnv56m3XnXY96WzwQxputBf3G2d9E56Av1NLRUOthmUAelq8BkU?= =?utf-8?q?+ckMNhn26y8V69rYaoSEBvZqhOafGcgsLQwYlgUIK0DVSD/h5d/FLkIyZKN6b/zyq?= =?utf-8?q?TjbcAkZe0xvLqKhq8EyfAZUVRc9GIfX+0rmbVF6CdZ5qY0nysJl8QSysfIK9AcUDi?= =?utf-8?q?8QmGkvbMPjqXlNFJYAjX2Ff8r3JMS4fqtX6kgetXEOJue5wPbVY4SIRiD4prGF+BZ?= =?utf-8?q?Y2uevO8+GPyVUGc9zY7kcECFT9HW4vGFokyFUXQosz2ZKjtvqz6/BRJL+KUPjQzFi?= =?utf-8?q?e1CCoAjc6EP4jRiGzKTF3Ma0mOF69uv3dCHSyb7UT11b7m3rjLLCXsh7V+3NrQbyC?= =?utf-8?q?Ly3kf6560t49I2YvxG5wovjKfoa3v9CR92ULAqtcQBJkt1ois4aVhJ/0foIgwNY9q?= =?utf-8?q?uNEt1707Pe33kPhnF3MAgNyOGj9NfM20nU5KKm/A4Mkjas7f8QJiGBS1TJnfHrHY5?= =?utf-8?q?AZg7K8CA4K0RU9CxFntp3OSfD2OqR2EiRNLZniIawVutge7pQtxmLUQ7yBwmWRTze?= =?utf-8?q?YFHPYT37PNwTghwrW/lbDwsoDEi6f7gTYunMYo2PiJaIZzeaohQHbgQcKecznJ+cr?= =?utf-8?q?gjR5pZz1IM3i1zVj52BdsFbAEhZ7HR0dJsvPEwlKvV5HPHbg4qAXqybKWS5rPHnN3?= =?utf-8?q?PqD4PXGx+2673Grt9hljspW4AZev7Rko02feBppMZgsOyFH34/ae87VVRJVFrcVXP?= =?utf-8?q?w7qXABjyBREDbV5Dq9s/xM3ayUwGMCMMUBFZRYfnebkykPMoAPZSxfZBtKmWPNe69?= =?utf-8?q?24nSh1NjiefQvN66zgGDyvqE3nC6BJ5kIpTIgqfDa3I10hEoQ30xlHCzn+gKwV7k6?= =?utf-8?q?pquZOqAerIN4kJMfn3zpoAS0b4NQ/XLSujKMeL7LezUkHk/XIcXu2AM/XmqsZ4BVH?= =?utf-8?q?4zzlJGhHcUwmGOsjvrbXP7hVWeI8DUe7/TtQ3MDPZQsGo7B9jYPObygvzD4gcHzaK?= =?utf-8?q?brXwgqiMannZ?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef273c35-cf6d-42e4-ec06-08db89cf7fb8 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:47:29.8570 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xGN7Hd2CeDPR3JKR1SDX9PyDx0WOrRiiLZ//Hm4HWjfYNb63aNGFnyF9adEK6lJLNtqb+L4NI10DCXBA0TJ5pQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6789 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772026059165038134 X-GMAIL-MSGID: 1772026168454219016 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Reviewed-by: Geert Uytterhoeven --- drivers/thermal/rcar_gen3_thermal.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c index 9029d01e029b..ff9cd43e1881 100644 --- a/drivers/thermal/rcar_gen3_thermal.c +++ b/drivers/thermal/rcar_gen3_thermal.c @@ -467,9 +467,10 @@ static int rcar_gen3_thermal_request_irqs(struct rcar_gen3_thermal_priv *priv, if (!irqname) return -ENOMEM; - ret = devm_request_threaded_irq(dev, irq, NULL, - rcar_gen3_thermal_irq, - IRQF_ONESHOT, irqname, priv); + ret = devm_request_threaded_irq_probe(dev, irq, NULL, + rcar_gen3_thermal_irq, + IRQF_ONESHOT, irqname, + priv, NULL); if (ret) return ret; } From patchwork Fri Jul 21 09:46:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123717 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp93840vqg; Fri, 21 Jul 2023 03:02:36 -0700 (PDT) X-Google-Smtp-Source: APBJJlHb71htcQwNnld0neSdfUJUbAGfmRQDSG9+nqc30QmzB4Goa+pOkt95Bj865jUysOlN/KHC X-Received: by 2002:a17:902:e811:b0:1b1:9218:6bf9 with SMTP id u17-20020a170902e81100b001b192186bf9mr1461783plg.43.1689933756156; Fri, 21 Jul 2023 03:02:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689933756; cv=pass; d=google.com; s=arc-20160816; b=DoRv54wOShXWUmwRYzDJJ22QQ82vijGS1g5oS//3KH3ABtKdRcqmO5ojoKj9Vbc/7L VMmNuAQAQP3SkoXTlhXSCMZ2pWkjKOMhuzVeJLVZMRISJUUAQKpv93pmfiWSauLjJCBh kO/zJG4dX6raC6XWHdayscWsyReQJ5Y0o25E0osvto8FdjiQtecFVoTmpEwNK8cUy/SI GXxHaTmpcOfmzEqv9T7gbxFuc3Z5sZDQI1bTsjuzaBn0e2cffYnnarctlNYzrXrCZbAG Wksk6KN66BFKLz6H8m9pOdlsDDJ33aUOrzDrW7SZC3t3an9S1uyLa5kOVgmqpCWELLa6 d8cw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=MeiyD3bTqLrfzoM7xfEdmd/j0Zm3deDKudXtSJLhE+I=; fh=Oibj40jLHRVC1CNBeqF4vFAnoRGW+CfBwUQE6oRh3ds=; b=QWovlB4GOoOHX1wbx2CzdqwZKqUl8gvr6rnEkxU/gmSO40XIA4HGRf2UL/YGCalKM+ 1EpyYOx/w/SIAB9LBAjt1gn1WfdPtHgvtiVhHr199q9POMYL8feuRCHupQ0RQCCgQpZG zmt3CwHr/XtOj9lVUuU07xZ+3E/9muCkLFvBDCCABufxCOWb2vG7nWONZQjrydgoQ2pi HNjcm+iXwzuknzEmiwOE/4u8P3sjKykaph+S29HS4HcnjsNHF0+j8uFSaMmK/PtkJuTG hin7jfoQpJKN2SkP3eBhUIlZOQ9clZJGbu9GA0CAQlljNjj6UmOVu30BSZ9hKoX3wxF+ 7cVQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=nRJX5RyM; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d10-20020a170902ceca00b001b878feaec7si2942262plg.203.2023.07.21.03.02.22; Fri, 21 Jul 2023 03:02:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=nRJX5RyM; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231899AbjGUJuf (ORCPT + 99 others); Fri, 21 Jul 2023 05:50:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231890AbjGUJtz (ORCPT ); Fri, 21 Jul 2023 05:49:55 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2112.outbound.protection.outlook.com [40.107.215.112]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 429AE3C3F; Fri, 21 Jul 2023 02:48:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N+lVj+3eWb+bFCcTtJGts6pIaz8UCVsGW2cV4r4z66wXOvV8kwujLa4OG6QjihqMCg84zxeVq7RpChisu6uwc6w7/GxaOIzBk/lWgHH0amIc9HD6TJEuGx2YRcZIbPhoFxXdXxV/Oo3nJYFpjVjqVTNalaw/tf3pqTAdofwZGFwKSQ+DPpS705GI1uYPGYGFFYw7sqKo9EafoYU2Dxa++hTJbbtnbUlWJRcTQ/2UMsjiYdTLKak2DGTWIihKN91mYfMD4pON4nEuYWswF9orHBnJoDtp9qNtrUGnSBayYB6Pj3VRENcIGYeT4v44dnGX0hkF70NeUs4vRCoyke2BRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MeiyD3bTqLrfzoM7xfEdmd/j0Zm3deDKudXtSJLhE+I=; b=WCpqD2AEpT8/3olPfwTv5xk6ScKgb5hubI2/D5DTPM9X/hts5vp6CiuFxer+axzVVBKvBER3UCOJWSSX+eCMaZpUouzeryb+TL5XYIHXl/1EVLoN8SNkksQcqVzaVJJQdkhQREmpapbbfCwd0vJqWLBNZdjEoAWliAWJfmlaRyIpamxgZcMalHfzsGXAO2MDJSH/5SRVSXP4VxfC2xPLPUeXRiaAFLWzDW5XMoTx7GBecM5EihfBI5Lx3E/dHYSpaQyviqtk3B5G+cMRmF6aJORHyYvPoz3yCZ0h+uCT7LGRNFtT8wqALvhHZg8Av+pwOh5N1TPLiV2URyMoRMXU+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MeiyD3bTqLrfzoM7xfEdmd/j0Zm3deDKudXtSJLhE+I=; b=nRJX5RyMKvOloZaQkT9IEwsGRUR+ybLYByRN+fBaBtxjuoHil+hXmT3eMWSBYM+/D0AK+szA6eschxIU6MW/cBzP1xgfEzFoUQR5aROrycb5nrP/RhRp4Ktjdl5ELrB1vYj6IwwLBc3N1IRPBTVfSAUmuru7LcJoCT4QlLOsnKPRVPRHqDfXmyGhwp4ttCGj12gx+OXGdZq/xHT7gOn1BvEsGdX+vL/g+bEF1EA+ADCJJD8LcWsF8RNHyKgn6h74STBNYgw+dE6gcTGsVEIFHwxzNBuluPz2YPKDNbW7wjTpdXZAqkngMluKHXV3iV8RvBUB4q06GABgXcTcj9r0vw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR06MB6789.apcprd06.prod.outlook.com (2603:1096:820:ff::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Fri, 21 Jul 2023 09:47:32 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:47:32 +0000 From: Yangtao Li To: "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Matthias Brugger , AngeloGioacchino Del Regno Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v5 15/22] thermal/drivers/mediatek/lvts_thermal: convert to use devm_request*_irq_probe() Date: Fri, 21 Jul 2023 17:46:34 +0800 Message-Id: <20230721094641.77189-15-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230721094641.77189-1-frank.li@vivo.com> References: <20230721094641.77189-1-frank.li@vivo.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR06MB6789:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d904bc8-9024-4a37-107c-08db89cf8179 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t015E/Zo7+fHIPTgrQeNUiz6oINhAOxuanpCEG12+n3L75kBoK1fbHoh8fPKZI86I2iPRcVjV0aRHUd4YUCmcXgLbmBmyatqGBfW17z0wlpW/lbq/vdNpFspZklKY7WzpsOa38fwrQZTNlg+24RvxhY3tF0PlRbd/3O0uk6Mtdx+ZI0XOKgc8Khzuz52zEQZJesncrP4dW3rmQAIbF+Lhit5XdbF27HFyUlgqZcDugpSulK9kSg/i1OIWU6nVGkf87ZEFcZ1rkQdxFmqGirW+XWYZA5tqttzF77WZWrENZtkDGKN+CtN/IJbDi9WLNUZTT+DObULU32/lwam5TDS/TzIRtZQb7bz9BX735zN7VXNpMgL0SmNXBheOuFVSCDIg3vjsHwoqKV/epQf+LZj6An35gbOYQ/w+a3LPcF4YORwjnOAP1Oqh9hqtPlYt8rbrekZyEyV1MKz/X0PO1SPYmgNqLQoBIO6zwZE+3G8BYV7pyZEEUjNj52/Q7PjKKRzvuCMjPwexdrjnxyqf+5hxwb9D9Seh92qgXJdtPnTyMmMxfeqPgHAa4DnsHT1a1OhXN+wwkIJWIrlfOYsjID+f2t1kMUr2IVr7InhhLbiNasVMtTdISrDHPgHm1fhQ9cm X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(451199021)(83380400001)(66574015)(2616005)(2906002)(38350700002)(38100700002)(66556008)(316002)(66946007)(478600001)(6486002)(41300700001)(4326008)(6506007)(26005)(186003)(1076003)(66476007)(52116002)(6512007)(110136005)(54906003)(36756003)(5660300002)(8936002)(8676002)(86362001)(7416002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?G3huFiEpbDUEDqdsJm3YdmUpaqAc?= =?utf-8?q?SNzbb0a0PGlOKVNyInplVUqoWUpd5QJkup+QFqmtDrG+A4L8KKRaMRik541NeGUK9?= =?utf-8?q?QM8mNb/tt5DbcpFL7YA+rr+rIe1cdSMljYlC4jdoptnG26+LdRt6QFovxstSnv1yZ?= =?utf-8?q?nm8xl/sOuMtBtj5GOJbNJPsjDiwXse2hDb75aO0XLNsPeZH/zoI9hY4RQ7ncZLeDP?= =?utf-8?q?BpllTu7S06zu1SLmfu6jq/7EghfVvDl+tOTzfQ6P0Dety/zyNBpLanxB1ZDKcTyBH?= =?utf-8?q?eoYPZTa/0ZaHNgewIK8XQM+hqYaFuHiwAKvoeYE8KCy3FcP3w2TNbrv+GYnHnprU8?= =?utf-8?q?PGYoNScdUHQHiY8YSl+uxXmUKXdC18WK8zkeWo94f9VkVUS3GpWhyY2kWJM1KPTPp?= =?utf-8?q?X7DLyb7MQiJnq7aQ3a9knILE96djpGDIGRGurwfuWBFQuRhh6fvYAaN6AYEbfTX2V?= =?utf-8?q?a7kkwqld8Xoyx4es46d1Ohbgw9ML4YDzu36xW6Yf5B88/WlSn6tDtVgYDeGF8SaaU?= =?utf-8?q?09C+RiVtusC5wQOBYVhJPevLneBxXZ/FWMTSJhJ5ls/95etSQRJKnA/dZWQeSKIN8?= =?utf-8?q?EPMBfa7xUx4fY7zlVFXh9AlMmBzAuWHi/vUdLeBM00bdPiGw+G9zpFUq0yl3463Cv?= =?utf-8?q?I5FQyh70jT08hH04ITDmkMPxowQ9fDGmZHlkZCZ+1oPSTo1EemLLcgf6r4xcVdfIr?= =?utf-8?q?3t3kZcuLTTolAMkxJ+TwnWBC/BgGjDjuEV+2to8fcKy4CfkRE7xh6Cq88g4Ywdz/A?= =?utf-8?q?MuG1dXCtRwAyQHvLlylNot2qVOAdG6adypaimBf7XYnAWnlex6bJ8mQ3SnMO2maBS?= =?utf-8?q?GoMkCbbkjvfVRfYbt9ZyCTjctoQI3cWa3ScfOQ475VoWJ3P+KZ0v0lbtMIXWpAB/b?= =?utf-8?q?ycKqk9MGRg03LMuh1TfQISU2YEy7HPXhyiU5qbjxiZv6LT6J8vcha4vpKohnDJasc?= =?utf-8?q?5eIRYcGSeMCtwocpDNy6GZ4QjrlZ5D/K2k/3cun7YMWg3o9Gi2sGEzcfY4SmZTXSp?= =?utf-8?q?HroMAybkiPc/eqGs11cQHY7acPNSWhAyeDpXshsTk24NL/FXDXI7sYqlu67f7OYV7?= =?utf-8?q?TxfxQHJ5nnMvtvr0OBBFwCpALx/A/46T5QwGGzDC3V7eSVXegj4s/JuRrPLvuFLR/?= =?utf-8?q?KGLt/6FulGpHWr/JnxpTMLga8w4WB+TYtLqmW5R2j8c9uTBc3As2+R2CdMm9e4yxq?= =?utf-8?q?fTQipALLrMSAeOGCqvYQiEzNH7ThXAqR0kcX108wcg2+e1TFq31WiEWeXuZBXp2nw?= =?utf-8?q?6/9pCy38ONmpc+A+AMR1bqpd4CybUDcYLehqMtM+s+ioOt7xJqaHbOqFrGQgdXw9G?= =?utf-8?q?M8Tuw7FQnYF1FhIxzDfu8I2RYHopJ0p8eFrmt6rHvYdApWFh8JZBPlXqlY1mZ1i/b?= =?utf-8?q?caa2+iFU7cwVJqquZcqXc2DNAoIGEhpafND1ZOuQjBnpNiEz7yVIdcCxwI/3bHgHI?= =?utf-8?q?ty5CuU+nwoDESffQhlgKzqZL4VCcNOuJjqawIYLzwpl8T5gkpjKVqFPlNKLSAzOkX?= =?utf-8?q?J4mJDe4TuHC0?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d904bc8-9024-4a37-107c-08db89cf8179 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:47:32.8010 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iTvBotaaKSb/ON42nH/mgAJX+8h/eVhrzkoDGf+xjt2N8yJI/UorZQbPb/ITZlLEPRRcww4xieqye/X4yakTUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6789 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772023978106397784 X-GMAIL-MSGID: 1772023978106397784 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Reviewed-by: AngeloGioacchino Del Regno --- drivers/thermal/mediatek/lvts_thermal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c index b693fac2d677..1e12410820df 100644 --- a/drivers/thermal/mediatek/lvts_thermal.c +++ b/drivers/thermal/mediatek/lvts_thermal.c @@ -1148,10 +1148,10 @@ static int lvts_probe(struct platform_device *pdev) * At this point the LVTS is initialized and enabled. We can * safely enable the interrupt. */ - ret = devm_request_threaded_irq(dev, irq, NULL, lvts_irq_handler, - IRQF_ONESHOT, dev_name(dev), lvts_td); + ret = devm_request_threaded_irq_probe(dev, irq, NULL, lvts_irq_handler, + IRQF_ONESHOT, dev_name(dev), lvts_td, NULL); if (ret) - return dev_err_probe(dev, ret, "Failed to request interrupt\n"); + return ret; platform_set_drvdata(pdev, lvts_td); From patchwork Fri Jul 21 09:46:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123719 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp96605vqg; Fri, 21 Jul 2023 03:07:30 -0700 (PDT) X-Google-Smtp-Source: APBJJlHtp4AmfT5+oc/xSdc9QxpuDS4V2Iw85O8swhBMEO/nitKt558Blb7zBnlc6oOzI1hZmsIf X-Received: by 2002:a17:902:f68f:b0:1b6:6b90:7c2f with SMTP id l15-20020a170902f68f00b001b66b907c2fmr1558184plg.55.1689934049867; Fri, 21 Jul 2023 03:07:29 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689934049; cv=pass; d=google.com; s=arc-20160816; b=m0RN9xw+vrnFNzO2ZEYG8aH2WgV5X1A6qwtxq7NYB/jukgEZpzH4ZMn61qkA37H7QM Ajk33nfn3vmbeRDOFf9bFNSHcdOQ9SsVhkvb5AOMibO6metWKVYkaU1cL75yxTvtndaj cqjJ77ozsfxSjOaME2k5TyPINfVoy+xJGhypSg+hCulLh2eWgSrG586liVVYpK347ZTp aDWpB4Ev0u8wKk9tVSoGIjYLf2x7cXOlnnV2rCE/jodaX2sj2NWMhpkx8sHBzzHASHeD VzcuF9FL/YSwE4ur6sulet9AwFNmhUMfSwjZKcW6TcANaJxmZdjptVZIK466nO9f2uSA 2yaQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=f4bfb4yk8VVql8CBIboaJds/47jikygD97Ynoj6D92M=; fh=KTv2T1r/QNJZkf7UmS3j/ysaXQ+6ICZoxyH0IbK8Eew=; b=ZoZSdwA+MGFgi22zA9x1xYItHQYLODOfyey7IJXLNfgxu7Vh4AZh3zycYtXxIuyCla znPylttzhbiCHyinw+TA+Hu+hSqf0R7y5Rf4eUZoFn0z3P4Jb9ymNIE5y4jmuka7lH6N /4MP37KKuddWUSSj+Dc5eWFGFHNtzXwcOL79qQTewPtbvs8C20BfmCVo1KekXpMQ3LcQ vDm/sluwl+c7/DhQr10toewrKmVB+YheRK5PFExJlUDnfLANXtEYG0qMHofcUar2F0h/ +4n32+XzGhtPdwxr/w+msDbDGHOXj6kB9kB9xaf4QH2Io4lvc0gvNwb0F1g17TCJrUAG AnhQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=dnnKKBLO; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m3-20020a170902768300b001b035ce0649si2648010pll.372.2023.07.21.03.07.00; Fri, 21 Jul 2023 03:07:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=dnnKKBLO; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232023AbjGUJuu (ORCPT + 99 others); Fri, 21 Jul 2023 05:50:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231822AbjGUJuS (ORCPT ); Fri, 21 Jul 2023 05:50:18 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2119.outbound.protection.outlook.com [40.107.215.119]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EC844220; Fri, 21 Jul 2023 02:49:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J43RpKt4DRzZ7yOxVN9y3MgwYBWFbX2tH8eAl/7XdwNMzjTpgCC4EICZVVDnNU2qk4mZKf8Jw60FR+dubR6MUPlkklnSpsyDlCxBdbaq9hkSmlsWCxGjC4CcWbW1ClEjDMw6i8y13xuyzRb5VTWG8FmTBb3bOPIodkdvYPOpQn3FRdufbj8qefUauAbkGFyNVys6lOqWow9Lv5IOgHlSSKYA5OEDSfMZOKkW7CSygMXkdrVwUsxhjzZuvnXMtJ/7yrft0rPvKY0Ws481XQTIZlpGIXriIjlzOhjsG403wCcvv7pQhPZn+5ZWAtsFtkbRT3ZA1spIJoncfnuWGKkplw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f4bfb4yk8VVql8CBIboaJds/47jikygD97Ynoj6D92M=; b=bZo1qAAcMO6KhjoLfNW/o9Oj1skYQ/Akx/kw5pFjTxFWnsI5YKh8vEMMWCiRMfp/US7727c+U+WViK2TKwDzf5iweYZcwNqbao2Krls+M1hRCd5fdingjLjgrNNWdrkEOJeb8Q/cNnROJDpLbyuocxbLRefrHbHEXtsjKQUQDye19cqTHv8UntPH/xP1BgAm4lykfGOfxzdLcO2WcIEeRLOPUnoX4rAhJbazwio0ukrchiG87DBzFKWBg1bfVbxKJyQ3e57OF0EI0dBWnmLlY6MdYtRpQFgKeT0R+BjSYb7M93FWCPERxVMpB6QuRWt4TmudRT7bhna7VJCMpU/r/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f4bfb4yk8VVql8CBIboaJds/47jikygD97Ynoj6D92M=; b=dnnKKBLOvkjihUG90bDE71v/OBJS0X566qXj11vWSsMEnnUfPo36m7VEixLFmq12OsblsyGelu9dnjVp99ujhSM+W3SVY+P2wlZ+gZNk6VX6Rc5+FgOQKp2KuRvkcGQ2pNba6AaxR3N3x6YcmHNOGeIjR8J8iKWcznoiABqco5y7Dlu2yMAr1kWhe/Vj1T43p2iSy3I9IFTQGdN+X0hw98kpCxw4H50xJxxmik0tkn2Xmr+c4NrllWji3sRHaVLFLK0xmiU0W38oexps7uXwXZxH5eg57Xc1TksW+OQ1wNu4aUTiPZduxjCe92BrF3TqvuQPXNHGvse6s11iRbzxGA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR06MB6789.apcprd06.prod.outlook.com (2603:1096:820:ff::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Fri, 21 Jul 2023 09:47:35 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:47:34 +0000 From: Yangtao Li To: "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 16/22] thermal: max77620: convert to use devm_request*_irq_probe() Date: Fri, 21 Jul 2023 17:46:35 +0800 Message-Id: <20230721094641.77189-16-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230721094641.77189-1-frank.li@vivo.com> References: <20230721094641.77189-1-frank.li@vivo.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR06MB6789:EE_ X-MS-Office365-Filtering-Correlation-Id: 54eaae52-7f4b-4efc-0536-08db89cf82c2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mrjw952keaR9LHfNm1FjYtJ2bgUpy/RDKZ5P75vKFScAmbDLZN7IpooC+JoSdBORrvV2jci8jsZHj/uCno7dZ0F4NeYb2DiP03hOtkvPgkdbBCTjT5l8gTxxTbOiwiV41Ve6XCErYqjDFabQo/MwUEl1ISPWpLkv0dyE1/uU1enmg9k/MglS0q+wpRyGpnRBBwfP6enDlAz/kYCiPlHyDwfRkF+c0Yqw3VnklvYUJqKOyZynwU6sh3oZ8xr6lqClaiHkUM1XxgBY9oAA8SO8Y54CmbX7t8p7sBmteWAh6UGDHqs2hVNCLl3zZfA/enNpEJ+2EGJeHFtCQR5lOUln4CjTQ9he4bC5V+n4matfRVxswm7UKXuyJzX2YE3qDoBeiqWWv8GFuEfu7hWZXzcM6A0vC7/TzBSvZSA0VAee+DB9g5H+nYZJDOemHX3VOPAZy+bHS+FJswgae1VxCqdKwQ6BJhez1Tkoj9DqSOSicqEX39jG2MBFGuZ6Sc2rQLPQjM28JcBhmdWjZVOy3q530OYWldsUB2BsWBYPUWs4vCZc35UAHVB/HDCdy4pqpeHU/eOYACsKMwQHUo4G6W2lXiCmTruk5BxwzD/iAd+NpaXfOjjzP00v9bN7yRu3D2L+ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(451199021)(83380400001)(66574015)(2616005)(2906002)(38350700002)(38100700002)(66556008)(316002)(66946007)(478600001)(6486002)(41300700001)(4326008)(6506007)(26005)(186003)(1076003)(66476007)(52116002)(6512007)(110136005)(54906003)(36756003)(5660300002)(8936002)(8676002)(86362001)(7416002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?6SHKl2amuMQC0zaHdHkMS0WGCZ/E?= =?utf-8?q?dqaqC5wAvPCo9ZglKMXN0yl+TCnC0+wxme2VE7Mep+hG+E3JB+F/klMfjRvBMaCt1?= =?utf-8?q?jME96BGgebzH6g8ZDxV35yUbGndvhKgEop+8FFbFnpKzp0s3G1PNMh739rXiRVi9T?= =?utf-8?q?91pPzEBx9Z9Mo0YgLBmzU0q4/kQ2l9PASymGCJIPgTWCtqfvTCohDgwAPsMdSG48/?= =?utf-8?q?9bFaiWK97w8mjck+mGmjdlFMW4NrXDC95Fz8VleJ+FryizysBn1GOPbemnqROhnt8?= =?utf-8?q?qXisi1lnvUZoxd5Usob5SkkfumYftNOSUVt2LdzydJq/3IkyIopU8RDxHuNH7f7A2?= =?utf-8?q?h7H1ZOdqZiTDI2AGDwjinYmV/utqW8IiBjbrhTe14Suh22kJbkHauJujRycyIAOv2?= =?utf-8?q?kLRspJCRJYfXBwuw5RFk2uBqMJLvRQb24a8T2LfbMLb4F0lwCBnTMGHSDkOrQYrap?= =?utf-8?q?uAn1xNp7JPae1cV7ZGGcDdqjozEV0Uz+plYrxcbNJIkB+D18mS1fmw0yjjadrDOEf?= =?utf-8?q?/VqAGd2KIvJgHpp7MMTxAa1s4yJV5QyiHW33KbFt0H5WEAcz0/n72w5qK6GMaV+uI?= =?utf-8?q?yN3g/l9/tSSYTpFjyNoV3qPTP0mpSZ1mhRZofu7zAG6DI1P2klfHFPz5QXYR7GOLf?= =?utf-8?q?j7dYMHtRpB0Qdyk6wcq3FLTIuhs5dVug1HiwNOAi4S5auaAzo5dNUlw4SbQP79FZa?= =?utf-8?q?OFM9E4kRkKUIlv7kGsoCxl9J1igVTuQ/ayoxNndm3mSA4XTRIuf7MEOmTQLv7rqsS?= =?utf-8?q?sagR8tc3NAe+43tEZiWDMw+ei8yjx746hsoyVCN9+MUFkLhK9VSATWg+n1/vbywlV?= =?utf-8?q?DdcLjFqYYxRaP2lNT8ECelsE6o48g44WOw+l5rPM/Cuf93Af94z4OyF6RRoXfEAs1?= =?utf-8?q?NihlB3aGYWmCjmhVRqi5VAb9RAMc7m7CELE7bNcatGM3pTK9nR5KGKxrFZefaGGfy?= =?utf-8?q?whDdavOyZc4KButHTWTUB8XONGmhYITlDGsVBSJ6HLmsqRB2rzXIsOzZHOSRDgffF?= =?utf-8?q?Lyv1DMgUiq6em51ZiFRA7kwVVns3ot3dKcKocqjkVocb93031b/bf1GM9uEmYrhxk?= =?utf-8?q?0LLJZuNUQ1jGeBBJTGBjjutrUGxGpiun0lhbh3AqNz8A3qPHU0rtJWoSM9JgIdKYi?= =?utf-8?q?Qt2YQqYy6RGxB+vn73fGgVooLT7V+0yEsFc4otqdxU5kr9gdlPr0sKGtnoGPtBVfp?= =?utf-8?q?JqpbMnHXm2m06zd9ZJEomiZf5NgNlhnGmkjazTTYUe1bIenVT3ZLwuHGB54zaaIQb?= =?utf-8?q?NeRy1KjzuDTBbMiMwb1dEzje8aSsCsJOzW+8MMMpxrOoa/7S5VL/hOlf/d127OV6H?= =?utf-8?q?qW1s0kQcb2A2rQt3FZvkpLhX6iDekbo4XMowjjWhwya/vdSndQlunw21skmFkt461?= =?utf-8?q?o9gDWwo8MnqUclg1uJlKknbA9OewNKklvJL7HpGN3ViMWEjmvDmqIX3+LEp3cMtmv?= =?utf-8?q?b2swWKVg9Ik6nhrAPZMj30c6t+p2D4lb2Wt3OCWvE9id2+eaS9hMRUqoPwrRr/vZZ?= =?utf-8?q?y2qyBeyK5jrL?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54eaae52-7f4b-4efc-0536-08db89cf82c2 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:47:34.9390 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hPReEiJND1ptIyymzFa/lkGX4NU7ll0E1KKVpG+b//GAxdCgThRqrlCglyx7/om2NvTTJuhBUhrOnPCKVTzwzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6789 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772024286474527770 X-GMAIL-MSGID: 1772024286474527770 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li --- drivers/thermal/max77620_thermal.c | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/thermal/max77620_thermal.c b/drivers/thermal/max77620_thermal.c index 61c7622d9945..92289498fa17 100644 --- a/drivers/thermal/max77620_thermal.c +++ b/drivers/thermal/max77620_thermal.c @@ -121,23 +121,19 @@ static int max77620_thermal_probe(struct platform_device *pdev) return ret; } - ret = devm_request_threaded_irq(&pdev->dev, mtherm->irq_tjalarm1, NULL, - max77620_thermal_irq, - IRQF_ONESHOT | IRQF_SHARED, - dev_name(&pdev->dev), mtherm); - if (ret < 0) { - dev_err(&pdev->dev, "Failed to request irq1: %d\n", ret); + ret = devm_request_threaded_irq_probe(&pdev->dev, mtherm->irq_tjalarm1, NULL, + max77620_thermal_irq, + IRQF_ONESHOT | IRQF_SHARED, + dev_name(&pdev->dev), mtherm, "irq1"); + if (ret < 0) return ret; - } - ret = devm_request_threaded_irq(&pdev->dev, mtherm->irq_tjalarm2, NULL, - max77620_thermal_irq, - IRQF_ONESHOT | IRQF_SHARED, - dev_name(&pdev->dev), mtherm); - if (ret < 0) { - dev_err(&pdev->dev, "Failed to request irq2: %d\n", ret); + ret = devm_request_threaded_irq_probe(&pdev->dev, mtherm->irq_tjalarm2, NULL, + max77620_thermal_irq, + IRQF_ONESHOT | IRQF_SHARED, + dev_name(&pdev->dev), mtherm, "irq2"); + if (ret < 0) return ret; - } platform_set_drvdata(pdev, mtherm); From patchwork Fri Jul 21 09:46:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123729 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp99636vqg; Fri, 21 Jul 2023 03:13:22 -0700 (PDT) X-Google-Smtp-Source: APBJJlH8t57mFX4q5bAevJMFYwrWwO3tYo0zeNJiEVkMfa4O8KU11BEVpKGvI/jMsdHZQKHzWpJU X-Received: by 2002:a17:906:8468:b0:991:e17c:f8fa with SMTP id hx8-20020a170906846800b00991e17cf8famr1273185ejc.61.1689934402189; Fri, 21 Jul 2023 03:13:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689934402; cv=pass; d=google.com; s=arc-20160816; b=wEeq1zAWEnhUa1n9FEm/g5NN29DBkYdR47OhV0RTxsFDjLIhDFDwhv+CL+tcKXjCmf 3DVu1FQUZ12k4zpU8wmMcsbRqtIoXNSaCcMf8E++oMxoP91p2Q2CyGUwQ5O6xtWnxguj 2cYknh37Qs0eXCcS3FuH4ErFddUj7KvO2f4JZbDy3JtOHh/L3Ehz8tRTcSNtTOaCGOnV TYEz9I/ZExI2t9F0WxewsKxkepbYkfj/akr+upUJXdx1Mi/B3GrN03+CyrVsuLYDOS7y 8+9lcIeJykzrJfIFicO1tvYCkTbrN9WXegRGBfAKCokGQYzHuojs2UkoFE8B6mMhSR5B R9HQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=LKc+TavFd7Ci1xyoSggA9UVGFRc6ndR0B+ijlcDKBLQ=; fh=KTv2T1r/QNJZkf7UmS3j/ysaXQ+6ICZoxyH0IbK8Eew=; b=ksNq9OTOb8ILhTu1KfyP+Onp4QvLhBoeYfhHxecQXO+Nkg0GjTRLNr9pmfMP3VR3r9 K0QztlbgGuc/LGukrqzIjNxbD4zj+JiDoFZJafV/l77TpqTZ02AgOwomeiMt1bkFVffI A7++EqURgbQgn5+xBWZiazYWVI/e4xqkAX9rsGitEa+e22qL3AEOy5Mg8/Ucqn7I3t8K HxrTbjbr++N/3YElSdneTEvHjuPC0xngb20lNsZ7Ant3q1AgtRtRZ8tySRdOa/4XX05v 2Oq7Ny57SFCc/bhObNJb8/ZhNb9PaE9lkntg9mWSO7CMgn/gpwJ9zHg+xrfnY5Ibu8VW piPA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=S4UIcSfi; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f16-20020a170906049000b00977eb8d769bsi1922674eja.289.2023.07.21.03.12.58; Fri, 21 Jul 2023 03:13:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=S4UIcSfi; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232029AbjGUJuz (ORCPT + 99 others); Fri, 21 Jul 2023 05:50:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231942AbjGUJuT (ORCPT ); Fri, 21 Jul 2023 05:50:19 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2095.outbound.protection.outlook.com [40.107.215.95]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02C1A4222; Fri, 21 Jul 2023 02:49:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cqaINiKihsksGuzffqa/5orRhMAzGaDuCXo47dXRyUF7JnuXx0kWbbyILUWhOlkt5RknTiBgLapi/5QzTPIpKd/ob8L4yg8SNlbZYEk96dGKuezweUOEo6Tr6h+Zx4SbIzSWMI3SduqgkRvlkXzHwfSrQ5WQJb8WyvkA6i+IOaCMnDr82gzgzswwYWdD3/WAyClH4HQFVG6GH6FTpZubyUKwt1CtF2aRP/xSOkl6SemP1Hs/TIh1US9+biC8Vi9LztCOSo+6oMTU8QEXsTxDjWPdGgsRM3E7hiuoDMtHo6vsDIlYruSWpF4hcwtvdbDl50eGCNLdoNss0LGYrVfgaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LKc+TavFd7Ci1xyoSggA9UVGFRc6ndR0B+ijlcDKBLQ=; b=YklT5ULoEoc3vlSR05cN7cSYJcSuYqbBYf6V+XSdKogjK6qiufiEQGBDGjYMCrU0oSud4gfux3xLIND6UwtqPBv5sPEnz04Y1JErG6NyW+gwZoWAPwLgz1yx6pXDt2ffeg8Zgnk55QXW0HtVyENMUMaLuMY2yYPIpSEbzroPitpSoLvVOFDrG7boOO7vhbjbFUmTJqjHDak4re/oyW0I235Xaa1fzB/h+5ZWl5LH2Lxnpmpw4f5s3A1QFFjlN4GusgRx/IXTKXe9R7OboHKzIfuwrFGrx+WktXm9w2iv1Srbcdc7HL+46ut94IOfuMpnukJkz3jzIJfO0tPmfk16Ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LKc+TavFd7Ci1xyoSggA9UVGFRc6ndR0B+ijlcDKBLQ=; b=S4UIcSfipj0LXdlHupYKxylrjpB/8UItARa6GgK9KzKrW+72yqxQ8pmDqAzDszam70srLQt8WrGujiaKpJv1Lu6XcfEscXbIRorvNtxop5s3oeKEkUEOrlQ8r9TQ8zdiu8JTyv65yd6UdFHUB4F8r2lgwLstfRUhSa4iBVAd/vJduzL0su0S8J34NYc/8S7qo2FlIbQwHS6iVRc0IUGH3VZucXuWcEcLYT3gfg9Gp9+sNJPZihiTW1+hWG00JYw6k8qOEqnPDkAYjVh+mIh0CNWEUSyncrXPDKQav9F2Oih1edv9GVrI5AT6HoGNMaS+5NpkyLX2C2ZwALjXCjYyww== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR06MB6789.apcprd06.prod.outlook.com (2603:1096:820:ff::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Fri, 21 Jul 2023 09:47:37 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:47:37 +0000 From: Yangtao Li To: "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 17/22] thermal/drivers/intel/bxt_pmic: convert to use devm_request*_irq_probe() Date: Fri, 21 Jul 2023 17:46:36 +0800 Message-Id: <20230721094641.77189-17-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230721094641.77189-1-frank.li@vivo.com> References: <20230721094641.77189-1-frank.li@vivo.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR06MB6789:EE_ X-MS-Office365-Filtering-Correlation-Id: ffaa159d-3b1a-48ea-d30f-08db89cf8403 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +PGmhYBPSC8kHw55zlzS4NYAsJLkhO6VmXZTcB+vfVDtSNGJcPY7C3YiIeEytVjsk6Gu6sxINH8XBldrCGlfj+Xjeb7tiaZQMH75KonUFkxqSOt8b9ojBo/TUKWdXLkelSCiZTIVfTyhFvs7mQ7LcKSo5wuqeDPPZq7Mw3LWKuC1y3NCdbodTRh5eZH+coB/j0CnDsgCfUELPJmnYMWGi2F2gKW1rJvCIBAclMJg0ArgUEt6b5GIjlDsbIO4yh3xD8FKHh31HJI3VIRpaPUK8EGlh2aoH2cbU3XnXyg2EVgG2fdlbX8SkRWIR6mDjhLLDRUkxboveMXlTkMrGj6q5cOK9+qb4G+NrbKCmHsXdx9NlRrdmzmNDOaybXwtKAV0iQtNdPjEKP8I5GV9jCbm+7tTSVARnyusHVhcCLyAVplebPlK8mfsbQcjJsvk18t6y53BUlESwLBmct3suJuPIU7vLzSKx2eDjAdj4XI+l9lgMxwa/twOeDa7puG/pUm+wlL9olU8nD4J048Hn2+ta8jZQ4Me+N5EyHIJP9ZuCf8c7FqgFPdX9VRfQb0KkpT9fKM5+p/oB4lElvVMGkT97QksBCLQZZYlGgbbrbHixJV2yvKe+TrVuIfYAm8/OCDT X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(451199021)(83380400001)(66574015)(2616005)(2906002)(38350700002)(38100700002)(66556008)(316002)(66946007)(478600001)(6486002)(41300700001)(4326008)(6506007)(26005)(186003)(1076003)(66476007)(52116002)(6512007)(110136005)(54906003)(36756003)(5660300002)(8936002)(8676002)(86362001)(7416002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?5TI2xB5HjnMMaKFGlHPkqtPYNOh4?= =?utf-8?q?Noq6+P7My8rIlRgXsaG7l8hYCQzdzNdwWXjE9HlpW9KWo3LQdSxKKXjgdd3CFC2GH?= =?utf-8?q?T+JffCc1mq9nLVg5dF60A1WqLQC1shHfVpQfaUG3TxqfyBaLbu0uvdBmFIgjX1Ihq?= =?utf-8?q?pk4GRWT3xA0+thFQwGF9j8vcX+dz09eY1w1gjReQ+RfKUlTOLUb4Bcci1n2ommCAJ?= =?utf-8?q?BoIATdzQ22tJC4nogsmu+2KLImuWJ8FvJnb4VskrCbaThJ0H9P/0smZteb6NHKAmP?= =?utf-8?q?SOcjBDewPVB4APylTxJsjOvEdw8/NLaLZrdwUULSuwYF19WOU+GHeYuoPhbOUuhnk?= =?utf-8?q?kFt/Holcj7sfkuO6hSJq8oaZCBm08hoES8QU12roj2ZaKeuQnbCfetho+0hcVKWGI?= =?utf-8?q?CFpYIkYRVOF5q0OglODlnBt5G4YY4IxYzP10tOMo+pDE+5f7av+6reegBV7LZDogr?= =?utf-8?q?ulOC4PnD+SDu9DSVpBXIwwtHxpGHhRTAaaeMIFJTNe+0euJeWK3VVWy+lnipyrjM5?= =?utf-8?q?sbe2PYPs0PVwhQhN3AMyHhhUT84YM0dGxcR+IXdqESmHUyKT+N+FfBi7GgRJbiB+P?= =?utf-8?q?2wQdoKHYtwF0V5w3H2BqPeL0DG8ER/+BkwFVOi/bRQHPJ5pm4CMtYHvHKLJLAf3Kz?= =?utf-8?q?qG3e0ClBWVDam1olL2rgBKStK+JCRaRsd05Ofwwom4SsUJAcHKA42QdInupWTb2DJ?= =?utf-8?q?uuB3aEJ3Zu5lrMpz+3Gmz8ecGaOnnoMQWWo1SgRKhom8BanXdPvDMHItsLUnwd5Mf?= =?utf-8?q?olcbMc7a2KB1UjHrKQVim9A9HAeMZkX5dYHasmTcgzdnJ4eRhx4dMCeNTwVLJvoMo?= =?utf-8?q?xh9WbEXNpiFqttyLLewrdaZMrxjjT6EUqDUc26LcdGkU+qaTHreAtmtec0wvKn70/?= =?utf-8?q?AiWiloxfc3eBK9Yv7rZ8WRFFjM5aIZTHXarW7n8pxdgwUnyaPlj893vMgtvN7rpzJ?= =?utf-8?q?UCWnQP7eS1c9fu8QpwU7F7K1r53gjiw1jxrOt5ggUH9Wbi1bg88bcbukRoWIAz51/?= =?utf-8?q?kEkU5IHiFsvUz6otQlZXV/0c5xnjABNxpGd8cfewMQ2XFBg4yUVY6Lq7Z2ulZI4xl?= =?utf-8?q?ZJuBDo3SXcShMLJyjTRXCQuYlXA3en8fpRbUeDc6MbSVC8FH0cY0GF26jY6+qyxpp?= =?utf-8?q?NmbZ1YkpBo9VGMDR4hs0mYZJsASdWNH3RbxLLZma18ofG6x7gJC8gKu6WrUiZRVee?= =?utf-8?q?gijyVwg7UdwyrXtBlTHG9ias5Uda8PROEBCev4NyRtt8cQH1DsqxByFopGLYXa2Ro?= =?utf-8?q?VgS/YFu6JcayX+mTw/+a6ZpvfZgOKd7Ax4xm3gHATsLAc4aLK/DyB+2/QfGa2aAay?= =?utf-8?q?4lGOZc0AIp2AWTiqc0K/QVhGv/gjfibVLOuIW8VVvkIXQjTCxb2yG5PLOsH9316/w?= =?utf-8?q?xg7QtFxsk1DxWLahHVHs2OhH0QBur17ylIdYgsUgIsEQUgDnMtxwzSlYYx+Io7yks?= =?utf-8?q?Fi3M1CVwEvBAGaPM59pKpiibkmOq9u3T/DEmzzhnizgyY5AtdaRhNHjPq2JSWgvg+?= =?utf-8?q?MaLDNLoZ+M84?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: ffaa159d-3b1a-48ea-d30f-08db89cf8403 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:47:37.1054 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cHAJRwKDLNhJZYqTT9f1rEEeDQ2U3uoNf1gmtYLHNdqZKI/8Y7DmyvXjizsWw/EQn7ohcc4n/XWYTC7HeTWDqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6789 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772024655897622095 X-GMAIL-MSGID: 1772024655897622095 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li --- drivers/thermal/intel/intel_bxt_pmic_thermal.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/thermal/intel/intel_bxt_pmic_thermal.c b/drivers/thermal/intel/intel_bxt_pmic_thermal.c index 6312c6ba081f..1bf3e6bf8052 100644 --- a/drivers/thermal/intel/intel_bxt_pmic_thermal.c +++ b/drivers/thermal/intel/intel_bxt_pmic_thermal.c @@ -241,14 +241,11 @@ static int pmic_thermal_probe(struct platform_device *pdev) return virq; } - ret = devm_request_threaded_irq(&pdev->dev, virq, - NULL, pmic_thermal_irq_handler, - IRQF_ONESHOT, "pmic_thermal", pdev); - - if (ret) { - dev_err(dev, "request irq(%d) failed: %d\n", virq, ret); + ret = devm_request_threaded_irq_probe(&pdev->dev, virq, NULL, + pmic_thermal_irq_handler, IRQF_ONESHOT, + "pmic_thermal", pdev, NULL); + if (ret) return ret; - } pmic_irq_count++; } From patchwork Fri Jul 21 09:46:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123722 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp98003vqg; Fri, 21 Jul 2023 03:10:05 -0700 (PDT) X-Google-Smtp-Source: APBJJlEilpkeZb0Ku9Lb7fETDiuzfajhLB16nLUK4T7EX2s9ZkR4UjGk1TYYQXNxH/W/IokOG5e4 X-Received: by 2002:a05:6a00:15c9:b0:67e:18c6:d2c6 with SMTP id o9-20020a056a0015c900b0067e18c6d2c6mr1843806pfu.5.1689934205513; Fri, 21 Jul 2023 03:10:05 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689934205; cv=pass; d=google.com; s=arc-20160816; b=NadPu9iMh6MTdUTrVVC7OHjOiJbrPO0wzVKXlPscKTqg1kTnDAwLmD/VkRkiTQkXKw jUNCS99xYfAHpUN9kIr+acWsbaa80ixAS17yxKC21DRcmK3q3rjHhxlwibOciW2oHa1u 7XT1rP8nuyNh69SmezFXVWmKlDadWRsHas9ymJSmpCqDcjSngI/ZZpD2DGVYYi/hQi9R ffiVNmgYIfort+BOpMSbAYIaCmEBUjrAFI6y9lA1FIJ3Ez84eM0wg3AYXQ+tUzOE9CNK hDnx99waEJEhIuA2IpQuTyz5FQwaictRgrQozIi4JC9FfcSmwk2JEVjzf9fu5Nve3DJt vaFg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=q+TzYuEeTgIKdnKfQ77B8vedEfB0P2/z7sQrh3Z4zJE=; fh=8Zzvw/eTUuxAjDvMUtsP0x+Qkw83CBIjC1nKrfItm8A=; b=T0sGc4tCP2yygdSJ/JMOcbRr2Pxppi0Gv3PTRoX7fhxwGdy5rkJx6HKrqqVT9puItE B7MwG7hmYCkih0XWpM4ozmnjIpSoNRzz7/gm8lTDew64Q0NRnbMgtVg5A6PfSQtB/Vkd xRzlwHYUb+QNduCwKrHsE6FYJvgHfSgpqfQdZwLXM4R0CDniVvXOmURO9KcjPEeXO1yW UGwDnOuR5LYk3mqhQx0Q9QR4v+NrpwwBcMJJ1WAquO9zWuwww/yR120sJOvswDpNCKd9 lDlVaO4AXCGN3p3OCfmtOOdFJhYqUvXwph4rGfGWEKZljaj1LcXxAUGOXSLUpPQAZPaf YY7A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=qfcHrklT; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fc41-20020a056a002e2900b00653b5ab16c3si2804557pfb.265.2023.07.21.03.09.52; Fri, 21 Jul 2023 03:10:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=qfcHrklT; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231858AbjGUJu1 (ORCPT + 99 others); Fri, 21 Jul 2023 05:50:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231952AbjGUJtl (ORCPT ); Fri, 21 Jul 2023 05:49:41 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2102.outbound.protection.outlook.com [40.107.215.102]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 677D230D0; Fri, 21 Jul 2023 02:48:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V6wlzlGQPvtMMyFqjjrmiYvHtVLAZ1aCeWbkDzsK7Vn8V0priy9jgG/qU0M2pvjp0YXOglaghury+lfYAsx53Nhh3QrYRPEMgdQToGhAze7IEESbZ/rZvhm1GnAVgPzlzR0bEgKwCO3w8jvuwgBASm4S4l8U3MeNEaQEUkMg/miBUR+AyMyqG5ntZnEW8l9LsVEpanwp0Zk2Qgy9aSjYrtiEQqjsE9ltTJlc/fKIaTJYr+vaNgEsopbVciPt6Ox3F1fxOBSZP5V6RLtA4JTatvh7v2r0QPqsOlzZSFBSEOXHQKH27L8HnN/7kaGcgAlC+lR5mOnMouLTe57yJcxnSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q+TzYuEeTgIKdnKfQ77B8vedEfB0P2/z7sQrh3Z4zJE=; b=JVQgROdNkBp2PKh0grjhUy+F6cDegVgT/ijW8wOzGgQjw8etkfa+W67oceX4ULcPfv7LwEAaGIihpTLiGyuakWSQx8/VbbsTjjhg171N83SlgCny74Ehpz7LHYwX7pxkfBkgVwSDj3OKRQ5T3S5cOsm0gWwDQKS/HR5rEb578E9d9dfoOGdlsvtuYl2HnKUeeuNQT9Z8o3GKI61IO0r11ACpxDHbD+a0v9cvuNtmEnIdmW9+87l/+SAGGx+PhfiBqPwSodN39pcQWPzTOoJQ0HDeU5RS6S5okpBaWxaqfAAHn06h59rLjpTEr8FAEip+xAh7r7UaDa5YdDg6QgJhCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q+TzYuEeTgIKdnKfQ77B8vedEfB0P2/z7sQrh3Z4zJE=; b=qfcHrklTXW184EA90QgOV1RDHJpntKHaG+564U4M5St5ugEuR0m5OMWRPh6AooN7IbLq5ZQc41W/8iPrxRUHcG2P0bZU+vAWakaChBKqu8OeqOfcjZOzsV6x0xQDS87E59AaqCU0/OS9l2z0kWS4iV/ct5DmiNAHqkxlH/zdt49k+GFtpt2qiAoIrWTxDRPi09awjePWuDBGGur2nkEadxKMpgS1UoKjJNTU+zqi6QJE3ms9KyoVPVtoOFOQrgJzrGV5c4RWP/w7LAS39+T5951ve17d1w7KkXsKGvz5lmzT6a/Ondmz2bZ2bX84Tu2nFgzHbPFm/14IDB9FXtZfSw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SEYPR06MB6311.apcprd06.prod.outlook.com (2603:1096:101:13a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.28; Fri, 21 Jul 2023 09:47:40 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:47:40 +0000 From: Yangtao Li To: "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Maxime Coquelin , Alexandre Torgue Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 18/22] thermal/drivers/stm: convert to use devm_request*_irq_probe() Date: Fri, 21 Jul 2023 17:46:37 +0800 Message-Id: <20230721094641.77189-18-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230721094641.77189-1-frank.li@vivo.com> References: <20230721094641.77189-1-frank.li@vivo.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SEYPR06MB6311:EE_ X-MS-Office365-Filtering-Correlation-Id: 25dd82d3-01c7-4f43-e2d1-08db89cf85cf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ty5Gj0IOo+nnkQtTl6AOhfhcPMvlwZ6WVnhHrYNVE9iFMsTqS0/Weh/6mv6mk19sLje896WMO/SDCMZ/Z3Z8I4nLqNgYl2IiUePmTPHM5Knw8N3B2j5qpucWDOnHTPIUPLOKlk/7pxXiPOfiLAUd1SMiR9NmpwGtTlGvJkTa1yVtcBTzCuDkGYF3AOEn9Zl7cTn1h04DhFjPYQst7GHd5bA6MPHHSvcXZYQDh6GV5pMS0IJLwOaYQSBRyRsqkGOoXXkv4hzmYo/caNgw28UAtFrqtIYEe3rAHxrT7bj6c4ZqNVLcDFcX7hnReWHvma6Y5o1qZkDXXTTkbPFvhZ9/6+Vt9bE1qhat/2Jqn9buRnsl78JySBi6Y3QNICb6aBjARuZUJELKPG5k0OamAtW+aKfP5YRJAO014V6xn/YzeC/mLmzEk5OOZ22URwL6PEPX189GNqxttNzRHSsO7y5UuxjOQ0ibdzuHgdgt2CeVCQagi9AP+1FjosCJkQ9Htiw99J9AhmoE+rCjLDDVwsJqOry5Hyu8mZyd0+tTvfSp3A3vW+Z95nbW/ukBEW5qGfeiHCqs0FNi4u5MtgetnerpG+Y3HsM1X6g9Q8PT03NqfsSkGcE38RT9adb6uG3TG528 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(346002)(136003)(366004)(39860400002)(451199021)(54906003)(52116002)(6486002)(6666004)(478600001)(110136005)(6512007)(186003)(6506007)(1076003)(26005)(2906002)(41300700001)(316002)(4326008)(7416002)(5660300002)(66476007)(8676002)(2616005)(66946007)(8936002)(66556008)(38100700002)(38350700002)(36756003)(86362001)(66574015)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?1cFhDDgPherQwVI1kkzkJNu07tKA?= =?utf-8?q?0c1z23Mekni1l603FRHn4JlAYj+b6nonsZ4ljGXXJn5NEe9jJvGM+NUfHshKLQDW2?= =?utf-8?q?QPyAmmFKrjZ7Xr4pn15hMcmpqUMSlHcRY9Rf/Nsgg51Qa2RGoBvp2sMybFrvJUZxi?= =?utf-8?q?v5Nc72at/hV7Dv0qH2SEPDZV3C88KV1xKhSXqXmcan7NR7aEko2Ey2M8Axp6telZ8?= =?utf-8?q?B9RF6YuB+M+uxxxMONHSo8YlsPcaEHayfmyTVFquZXAdKdDG/vhjtYJyd3v93HitB?= =?utf-8?q?D9/nj3qnxIbOXehjodTAvwu2mcYdaovSysHXKWgetFJmuxF9T4yx/0NHKukTI33LX?= =?utf-8?q?H7GmqOtk329TOH5IqEE734HOHr+2huF0cfOZpAkWxJK8PMJFTZ1BkQRXZ31Xopzyp?= =?utf-8?q?kmHVRLMySKvQkENMBaHtilLo1uWBN+jWLNXWOEN0B9ZkM+AHHzZIugFUSeuaz3Jfj?= =?utf-8?q?PYSJJ4zh7u9MjTaUwR6Nlw01kYI6Pgpg1SSYFA6yCLKYsmm2VC/FSsGP2gnU0NBhW?= =?utf-8?q?4QLoWHWTVS6A7OHgaQzgG4xOze5/YSy3aeIsi1u29miPis3P4jvVt/EY13ZGiMmpt?= =?utf-8?q?fTNH9xjDvVSwpiQZlInn2GSoIiInzFs5kuoQYcAw1sC+5y1UjbFSsjiDqLlVnKSCJ?= =?utf-8?q?9M5z2XD6FFTK909l3QLz4hfqKVvSML4EVdmoc32Zi5t1CYRsbBniLzg4xM8YnT2h0?= =?utf-8?q?9U/gEDQTDH/8nldp6Y6PRobVK52npYtI3vNafmBCkKyg91EAuKL3CKvYELv2zd4tY?= =?utf-8?q?chUSmtp1jxo4/QXqLYn1VQdw/SwTaQfrsSCEN6wMCVHQwMomikAeW8HT672SwhOL1?= =?utf-8?q?/m6oKxWNGx2rvdtONDQKbUvtmVEm8/620GuntZRGpthUTa7Y5BpRkeRhldB1P3ZoY?= =?utf-8?q?8VRxd845hUKGyPwyh55PGIF5CQOeDWoMDbxiJQ+nAUeWkGn7tBDn9K4AxbLhNkHBk?= =?utf-8?q?T42ki4drCAFTNJGruyulVlmB/paF09EBJHenGvH/zIJ/JhNERe4tNGj0E7rOtZXhx?= =?utf-8?q?y+2TwILghaz57izX2mkEjymHsRnNFlhTaCvzNW9lkaNqGurY5r+Ng8nQlWHntvW+h?= =?utf-8?q?rG/vvp/v6PllQFzdI02wU3aTUXLDFmvUJ9uns3Lk9aoJTjrD68SQS0wH7G6LEGOZU?= =?utf-8?q?bigmJiXVQEaCjPfoNDZCJ/FtxULEpdHPyJ9eFv/EWdaxrZriSW51LZ4XY8jMqZLw/?= =?utf-8?q?DpLKEKZKTTbJ1jEsMsosS3TY+2/AW71TYadzKZjIU/L6f1uxY9wYNpuyigTv9aGVG?= =?utf-8?q?5NUPKbvIRVqj4n6sJRqX54Cqq/lmxHfRJUSpJWwQ0U6dSRAaE7gEU7qjn7ZvNtlGN?= =?utf-8?q?Frg6kh1/+VfgFcoCXcE+z2cNem7CB0zJSYvXxXf749SLIckoOSCuOnTlsD+f36mj+?= =?utf-8?q?6BArdFSik/uSOnJZeC1WhCMdS9FzOTkD9b2dSzpVNymYU2cU43Dcul+xT9Om5FtTS?= =?utf-8?q?m7bf2fvVAenOUJ3mGd7aMMD+33n0iyUe0v1FKlsR+pciL2hBmyRMTiNKLYoWcFTmY?= =?utf-8?q?MWkFDzVCIfO6?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25dd82d3-01c7-4f43-e2d1-08db89cf85cf X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:47:40.0831 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YxNfBV1HrrqXpF3MlG4NPuTs8lJNpDnAqWpncJfNAMW+b4eoJfsMkfkREzmvv3sv+TI9Y3d5g8Kkqolt+tK6Ug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB6311 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772024449918678910 X-GMAIL-MSGID: 1772024449918678910 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li --- drivers/thermal/st/st_thermal_memmap.c | 12 +++++------- drivers/thermal/st/stm_thermal.c | 13 ++++--------- 2 files changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/thermal/st/st_thermal_memmap.c b/drivers/thermal/st/st_thermal_memmap.c index e8cfa83b724a..40bb318b5489 100644 --- a/drivers/thermal/st/st_thermal_memmap.c +++ b/drivers/thermal/st/st_thermal_memmap.c @@ -97,14 +97,12 @@ static int st_mmap_register_enable_irq(struct st_thermal_sensor *sensor) if (sensor->irq < 0) return sensor->irq; - ret = devm_request_threaded_irq(dev, sensor->irq, - NULL, st_mmap_thermal_trip_handler, - IRQF_TRIGGER_RISING | IRQF_ONESHOT, - dev->driver->name, sensor); - if (ret) { - dev_err(dev, "failed to register IRQ %d\n", sensor->irq); + ret = devm_request_threaded_irq_probe(dev, sensor->irq, + NULL, st_mmap_thermal_trip_handler, + IRQF_TRIGGER_RISING | IRQF_ONESHOT, + dev->driver->name, sensor, NULL); + if (ret) return ret; - } return st_mmap_enable_irq(sensor); } diff --git a/drivers/thermal/st/stm_thermal.c b/drivers/thermal/st/stm_thermal.c index 903fcf1763f1..6a36a7eab9bd 100644 --- a/drivers/thermal/st/stm_thermal.c +++ b/drivers/thermal/st/stm_thermal.c @@ -387,16 +387,11 @@ static int stm_register_irq(struct stm_thermal_sensor *sensor) if (sensor->irq < 0) return sensor->irq; - ret = devm_request_threaded_irq(dev, sensor->irq, - NULL, - stm_thermal_irq_handler, - IRQF_ONESHOT, - dev->driver->name, sensor); - if (ret) { - dev_err(dev, "%s: Failed to register IRQ %d\n", __func__, - sensor->irq); + ret = devm_request_threaded_irq_probe(dev, sensor->irq, NULL, + stm_thermal_irq_handler, IRQF_ONESHOT, + dev->driver->name, sensor, NULL); + if (ret) return ret; - } dev_dbg(dev, "%s: thermal IRQ registered", __func__); From patchwork Fri Jul 21 09:46:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123723 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp98715vqg; Fri, 21 Jul 2023 03:11:30 -0700 (PDT) X-Google-Smtp-Source: APBJJlGI/q7aqC2L4vnTr10JQ9WWdtRumnS4WulzOOyFwrmGnTDAbiuoYfCAYNSM/hhUtQzXq8Q0 X-Received: by 2002:ac2:5239:0:b0:4fc:6e21:ff50 with SMTP id i25-20020ac25239000000b004fc6e21ff50mr936645lfl.55.1689934290365; Fri, 21 Jul 2023 03:11:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689934290; cv=pass; d=google.com; s=arc-20160816; b=NoiUelfaLD/Ts7412xoN9XJAHHvxE2stA/ivxvlUNkoM/FKX8lf4HxvEjCgL1ryFlN Ep5HVbg4NU3Ac1dH1vcINsxHgaMnym92eOdr6J9JMuUFx0aF0mIM48CjD2LQBrTz9rXM ZOBlcSdskPY63QkD+7AQFYpfQ8w/D43dHtyih3YCGOHnogUKLY8eqhq44nNt7JEokO/y dE1QrrvEeDSaP8lSauoKUvrJYzOD2grx/YGmitAeeprI91HETuNvnTgS7nw6EQzmTzkQ pQbqgGqHgYpSkyfO1jf+oLe2yh8LJj1yfAt8pLw9ONpadj9hdGMhpSdIU35IQ7FdLAZc N1Og== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=U7xJSqPC6R6oyLUW7A4Grg9gjrzZA4zR9DzCNmCHg5k=; fh=YO7dzwI6zK8jP/zWXotBHy3qgCoa1CXMYZZpgV202FY=; b=JJdqrbaJbyVERUFm+zaf9CprrS0/zGfoYyZQSNEkvKOaX7x5MaLENfS0AB/NGqQ3fO fikxfluOEOYp3LKB1DvKBg8hYAVSqTzy7TmecX0eS3G0CPSYiBUnNb8JAFrlgU1mTzf1 bsgPFj99F0jULDuS5sMrcWdJslefZYeF90rzzoCEosxxgky3rXJ5kYVEl/+0iAQEUSbC Cliq/NZghlJacUrZOPKfxtQUqEV82iumtLv6q+a31gnrorfdw5IpNl0p+568bmSeuGwZ ZeQMYdM9nN2rGSHyMFcmy7qkcBE/3HS/9hgs7JxS7DFEQP7nyIwneaUqH1ZKn/4lwdz+ t1TQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=Vfg0VrrW; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i21-20020aa7c715000000b0052193eca237si1871213edq.263.2023.07.21.03.11.04; Fri, 21 Jul 2023 03:11:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=Vfg0VrrW; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231925AbjGUJt1 (ORCPT + 99 others); Fri, 21 Jul 2023 05:49:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231920AbjGUJsl (ORCPT ); Fri, 21 Jul 2023 05:48:41 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2103.outbound.protection.outlook.com [40.107.215.103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 842BD35AD; Fri, 21 Jul 2023 02:48:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cl6BYj2ZKDT13HtNKI9yGBhjEtIAiezQo3eg1rPA1STUYfy90inWB5xHGvcSs/WXuXOGaq53OoO3hzYBQMnlygCUhdijnE0K7qd2MCGhMOl29T0GqzzdBvyPIIKF8HMYeHtsxp5VhMQxEkzkvdV8Fsbvb63LlIDfoAgRw0Mr+z4bp9/XqyqVHpsN2jy16XU2LB62e359LpRPXusOw7Nh0nsiVOT+4azodiVqSvzfPUIdPsQw7j/EqWYihDNHthwgxl8nRo+nynxaFOuAJj1P5+Z7Xh5ghMOJ2sXVIS+U4yuWUcFGPxktSbHGCyn0X2i2LT3eaTulSAD56Dv3PTIyvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U7xJSqPC6R6oyLUW7A4Grg9gjrzZA4zR9DzCNmCHg5k=; b=jq8eToF4MZRlz/OyWTgVXDOwilmP70wYhKfo/zktwWJ9b9tVfFcb9JPo0VIeAF8OkJbhVgfRTvsLwC+xcec2d3ix8Mz+I+63NKMlyd+1/XsFvLPS4z2OlvOW8v1V1/dKTaPdwaK12okR96ePMrHu4sqamIAXx14KZfFPXHgDbN2qkNIzkhrsUcGzzsV3+vxGhg42uZT7IS0lbnbPJarZG4D4xV3gyLuaStUcchrKdTK1adQZ1dJQ7AAXd9Y+K6bP1alkwaoerIpR+6GCzVzyJZmIETkwiGyIbLN2stOdHVyYqqpXv3eRQAhMXYEj5Ax/8+5seLkHFaaMNPssxhwe0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U7xJSqPC6R6oyLUW7A4Grg9gjrzZA4zR9DzCNmCHg5k=; b=Vfg0VrrWIQ7lE4EPXt51RC8KzvDDG6MXA8DOv8YPcr+6tEMh94myt9tTymy2jInrzEaW/1dsbqIhDo5ip82QZjmybaJ9CoHMUWDvbsXum4fPu5lZaXc6J70caWWl5MbjY3/9Sb9quK0kchmra2kx0goOZOFb5nOTWkYdM/7SQ6xPf6wImoWLO7nF1KdxzTIJeIu0kiqQdulvSh5XT0C0bps4JH+lrZWw44srL1HwdtK+pqP0Zz/CGXyKUTmWaPc0sRsTtZ8OSEq0Gr4zi38Y0oS4ZfZfENW3EqE5OTtslAm5x6ydMF4pYb1xBOTNeRAerLXaR79XHlM1lwpzthmVuA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SEYPR06MB6311.apcprd06.prod.outlook.com (2603:1096:101:13a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.28; Fri, 21 Jul 2023 09:47:43 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:47:42 +0000 From: Yangtao Li To: Amit Kucheria , Thara Gopinath , Andy Gross , Bjorn Andersson , Konrad Dybcio , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 19/22] thermal/drivers/qcom/tsens-v0_1: convert to use devm_request*_irq_probe() Date: Fri, 21 Jul 2023 17:46:38 +0800 Message-Id: <20230721094641.77189-19-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230721094641.77189-1-frank.li@vivo.com> References: <20230721094641.77189-1-frank.li@vivo.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SEYPR06MB6311:EE_ X-MS-Office365-Filtering-Correlation-Id: b39fc405-4e07-4457-1c11-08db89cf8784 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OzMUkSUhbywZQpA3N8ZR+aY4fuifa+oAlXbD0967Ts5nBmreNKTjHsJCNKlboBzljeZyZJd4KNbSAGg7vBv4pwqBkeZoYtxhAAo2rHPx0TWQWIk5u0FUUEqXB+QbnIb+ICfcnp1YboQWKuvqWylNU/dmop/1nkHAHHhtcb76zcJkqWSar49plXTHBqhv53kpI7W0ROTC1Yb9sbFkpPR1nEhANfKR+0HI4MseKbrDJCDuZmTSQtFhG598NdHAtdToiwH61f8ANlFCPZ+zgr1muC6lhUlA1Bg4bq+4nTqRMhM0yYe65oQjVtHrCzAWeDmNtuinIHfczxjMaKpWWJMiDENpo187Rdw1s4gPk2Vu/0uMAC9MqIIIodG5KAnT/voK1UB/pe4ssSbMASN312e91xBbjRX9smShEWCD0f+YsOF3DrLSL3/oEZMimvHE0IFn7+yukiub3kgZy3Gaj82qYHJNUBHX2enJW8kBIGab0YOibhoLPH7vd4BuwEVWCmNNXw4JTJG5P5bDdniCUtqqxfuhL2YzYQy1249ktZ0FjCjSErgGgoR9A7u+Ld21kj9lSZR1MQ+CIRLdy055mXRJy1n+3fti8G64G4lABWrARxtElSiZdxsH/eq3OEJbxuwE X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(346002)(136003)(366004)(39860400002)(451199021)(54906003)(52116002)(6486002)(6666004)(478600001)(110136005)(6512007)(186003)(6506007)(1076003)(26005)(2906002)(41300700001)(316002)(4326008)(7416002)(5660300002)(66476007)(8676002)(2616005)(66946007)(8936002)(66556008)(38100700002)(38350700002)(36756003)(86362001)(66574015)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?c3FJWAOQkscS3nq1q6u/QcueG6dj?= =?utf-8?q?t3+RVDw061xcefO0B28MxbteeuiTo0G0ch/VBLuQZdRzsS3h1CW5rsAvE5jMa5jbF?= =?utf-8?q?EDWsZ9e5jx5y7ROcCvMlpjkmb3XFGPacRmA3Tx4Iq2hzBdWE0lN+niwduSGZgcZGv?= =?utf-8?q?+hVxuby5cuQXrIjaV8CX5TGUhbrFBlglyfO5ivy4lvR+JJyETmz9cyP/vQrJA9ubw?= =?utf-8?q?dDiksG5pyClq8chw1jJVNsoXyswibjr4t44/jU3qRzCq5ysRjx0ymsVpAef/tE90i?= =?utf-8?q?qKafRSBROIBQBmlVMo0qHUAUFcow5H5vniLabVCvEuskJczisG5USrW7IKe0vZJCd?= =?utf-8?q?klMTjCObmu25YikDQXmwGbhnq2/Xfo3V5WDqmv1slmpEXr/54XqY6VYlQ33Si1yDH?= =?utf-8?q?fuDFj/yt1JuWVAjVFjevWIrHBOZOPlVHWh2Gb3xlZJz9SG9r+qJICl/XYU7gpPcje?= =?utf-8?q?rHc00GpDC1Mb7biz2oDIJ6oUsOJoXz3fR+f9xMWmOdCL+e8SbafGSHNN3OXUg1zsn?= =?utf-8?q?eS14hr++EVESJEobsNuZlIsBcB/jNFc4csdZy/k73BkIY/OjD/CPNbE73kkr2WH0r?= =?utf-8?q?Mmwt+L790hsuimzkGxZRgk5mP66FvQYcJOeO0/xpzRWKn7Gfuv+FxgP34nSMdf+No?= =?utf-8?q?5UArcJ/DhLkPbeg+0OfOvvuN3ylAitFVDHKSixQG5sgJm1s9fUqaQKgoRs6DU/qUK?= =?utf-8?q?1saKk6bKhW27p1hWbuTSiHji2O8rGVY0BCP7spNsJ0LGleSk56CKFd9Wldrl7WNjD?= =?utf-8?q?7dnKqKBH6H4P0PlRPpkl+iApdZc2B4pr1OKRlixPDX6/2XOGT98X7EkXAK5OzO9LU?= =?utf-8?q?F5zVkCT6mm6aEEtp24OJjRFxR00WNQ9MOrUSZqsnRbT//fho3nNiWCG/skRT5ZabC?= =?utf-8?q?6NXtJOMOkojLDWq3DWjMuPzoisEZIGMqMGcqv8e6gl2DsEIEHr4W6J10ip61l78n0?= =?utf-8?q?OFkRi5wxQq0tgSzeCbnt5Lx3tjCaW+zRMiat+tW/KA/2a3WCQbUpqvEtQ5R5ywZJG?= =?utf-8?q?G7pqhD933R7+qyurooZGBPzWf4axKlxkS0gbVeGnOJCLmDQNEPjzicAC7mAT8dbUs?= =?utf-8?q?oYUaJbVa9ceRDY7nV6z5f76Kr/BvMqh98jcf9k4fMxiTZ0O9UBET4PbwL7FMgQj0Q?= =?utf-8?q?pHvuq5ifjhqJmcKX9n6zZbd2TlwXi4t8/hgKIIL/w0EIU3kJmCHyBn77911o9vwLR?= =?utf-8?q?z2gOA7Kq/wgvNG2sv30/P7sCfwgrElJQ+g+51Oss1kg0EQl4+u1LiuxYKCeyO2TvS?= =?utf-8?q?yY4K6gbqrS/4PwvAHoK7Dz6tf0nkry/7K1RsCzky1ChiIqKx0Brg+tNOMDsUVSCtQ?= =?utf-8?q?BHue24JtVaC+6paVLMN3jiLClQa9+sl0FUJ1sQXuc8XMe3jKOH3Ug9bKj6hoeYuR+?= =?utf-8?q?9LKxlQWKb9GKn1VopTYPH4IRQ3xiDspU3cY/Nm5SFCzLfzWV1zk7cTaQdSkwNcbhC?= =?utf-8?q?H1tOBoSdqS8sTjlGfGv9p97MdOuvfwg4SMuMVJZdJOf16KecCpI6B0sKQyfCsThMk?= =?utf-8?q?US88D6r3tJuV?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: b39fc405-4e07-4457-1c11-08db89cf8784 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:47:42.9298 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vRDRWDI9cXvvvsa57ELLKLgSYKtxp3ZD32Bm1yRVSh5N4a+si+9iS+XECjHeHa9rTBmUkXIsaOsXamLXH9mkBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB6311 X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772024538123908693 X-GMAIL-MSGID: 1772024538123908693 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Reviewed-by: Dmitry Baryshkov --- drivers/thermal/qcom/tsens.c | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c index 98c356acfe98..d4528d36c085 100644 --- a/drivers/thermal/qcom/tsens.c +++ b/drivers/thermal/qcom/tsens.c @@ -1171,21 +1171,18 @@ static int tsens_register_irq(struct tsens_priv *priv, char *irqname, } else { /* VER_0 interrupt is TRIGGER_RISING, VER_0_1 and up is ONESHOT */ if (tsens_version(priv) == VER_0) - ret = devm_request_threaded_irq(&pdev->dev, irq, - thread_fn, NULL, - IRQF_TRIGGER_RISING, - dev_name(&pdev->dev), - priv); + ret = devm_request_threaded_irq_probe(&pdev->dev, irq, + thread_fn, NULL, + IRQF_TRIGGER_RISING, + dev_name(&pdev->dev), + priv, NULL); else - ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, - thread_fn, IRQF_ONESHOT, - dev_name(&pdev->dev), - priv); + ret = devm_request_threaded_irq_probe(&pdev->dev, irq, NULL, + thread_fn, IRQF_ONESHOT, + dev_name(&pdev->dev), + priv, NULL); - if (ret) - dev_err(&pdev->dev, "%s: failed to get irq\n", - __func__); - else + if (!ret) enable_irq_wake(irq); } From patchwork Fri Jul 21 09:46:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123726 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp99143vqg; Fri, 21 Jul 2023 03:12:23 -0700 (PDT) X-Google-Smtp-Source: APBJJlG3wRsdz+9895NaecnDO9tUSy5E3HL6lxrI4LeKOY6sjhEhcSPR1SlFF7Il5vsZbOBaYqIV X-Received: by 2002:a17:906:305a:b0:994:1eb4:6898 with SMTP id d26-20020a170906305a00b009941eb46898mr1338795ejd.9.1689934343067; Fri, 21 Jul 2023 03:12:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689934343; cv=pass; d=google.com; s=arc-20160816; b=RI5eWq64rmI3QYBas5jxnpITWj0WgBIgJK2HwqlwI3hKDmfjP7MICiBkokFOw0sMBt 5iLLNx3AQKkT+oVhv4nYdTngtSKl9feXwgYBknzMbV/6CWQskyu5mN+mZNrIcQPyt+M3 kDq6SJJpD53zHh7tJkC6GYdvwQUcSqPDCh6P1njG9bjn+jLNInLXk7HNgxQvjbkypBTV XfLv/RF/iJmJb1VeugpiNakGrBMwIAXZlzwC3QSh8Kumiyk8P/abYSPIb4L9Cs437wD6 Hg1T4dgHbCJUPyzUwGNx0Vom+yIUV7/3ID7eMYpnNlOraYR387N2cUWIIZA9u8DMuCmr bPNA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=uDVGgpitxTT4QdqfnkpzTt8ouLLBgOS6RWAujk0isLI=; fh=kvym5B1qy3FUwfZXIsHgvODoj526Lf3pQG6p1d5aviw=; b=NONLZWltlyF0A0Y1Nt/wggWcWpShHnpCN1qUvFSSuBQ8vMkgxYzFo4GmbAL7nhJ+uq uQEvh5mFwSyy012lmwm5ZLZ/Dz6cAmBRQXkx7fqrcJN7ubgB9T3QaiQHPDExiDGdf6Su S1afdy6cJ1w7lO+YjRIc7anwg9gj99shltQmF00XDjCm9+LyV6wPd5cxG+7sccnhp08c 5OEL4evDe1iLYpxFFOlXcYr9crRzI7XiSZp1tJq3L5Pz5z3CRXWtv7e4i00OG1SUyHnn oRQHkVKxN6fcU1WSKaNtjBFOLw9L20/bq2/zSah4wZSePH7AdEqoXo2vm7sz6L0Ddxex Pxsw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=WMNetiS9; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kd26-20020a17090798da00b009888ce5d3d4si1856800ejc.436.2023.07.21.03.11.57; Fri, 21 Jul 2023 03:12:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=WMNetiS9; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231998AbjGUJuN (ORCPT + 99 others); Fri, 21 Jul 2023 05:50:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231822AbjGUJti (ORCPT ); Fri, 21 Jul 2023 05:49:38 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2103.outbound.protection.outlook.com [40.107.215.103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A2C13C1D; Fri, 21 Jul 2023 02:48:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XaSvtVA8WOU9YZTnb9NU4Cbw3W78DOV1+OdVlVuZ0ky6WIAy3TLk+36ijwKLToONA4hF9G9BAoHte2S0TzVeSDLk4wzJah5vF2bEZ1Wf350WQeV52m1o01ALJQZSM904JEZ1+/qvVRdIGqn3tSl46/h/RK3VUlesGbAN31gCamJpNA+rySUIcvoutmE12PWc1fSx+tYetiSBDJSEqB7BKLLKXSoO46AGnPXqp7oNwMpzJVQZsCRfHsTkuj08rxvnNbekZ08qsSQLxLwqxHklGqfRNjgHcnPjbltO9xkU9yShI9mvrZ2+GsK4pfv8eyDNoh7pQIzU8rkKt1KCa1V8zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uDVGgpitxTT4QdqfnkpzTt8ouLLBgOS6RWAujk0isLI=; b=C5CbYOSjPBsoBhb4e0e39IyZEGIU/Yvo6a9Sk/fqxi5X42XJwQHmkFkA9jcFTDFne2X+WGtLEMhC3j21cAZwzsk26Z8XCL/tli4AyrefuVn/crvfYvq63MhOSqlVHiyu+9AWK8vMQVpSv16GQohdNTI3thmsX9gIe7M/YsPjEjHFT2hxiVSouIg4dvV8enWS/di3Keo9Smk2KFiU2ExMJjiFz5HkignF1ItiQfEprpx7NHZYQKoIfVoO0sMP+itTtdsMgaDbHXAzncz9cDLMe1XjDc+vcNzuZFai/NBp/p6iTAf17YVKvYkAWFE2OlhPD5KJsqF7XENfYoJqhga0Hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uDVGgpitxTT4QdqfnkpzTt8ouLLBgOS6RWAujk0isLI=; b=WMNetiS9o/NWbhoqQeem0ItQ5BWoNQOPMaAH9bY2v7qyIKjUsw7PprP8f1DnMf7LUEhg1T3ltH4Z+9P4f6WAf9UnCZgesms7U7EwMN0nx5+UVIPPn3TP3h9zIvQlNPm6qe4WVgSB7/5YKWMmu5pFwJ7he3q+rb+6tc8wWiGI4HfUYzNNOVxi0B1a65/CLyifTRlN1kGdE2wwAQPlPiQpf7EvEi3S/KOz5E1wxuzCwzsFBl2PWS77kTlnBx7Mtbu91uKmK0l/2FbJTEjWaDChTEBh3vZ+Lpw6x30fwGjWugvC9EG1l+4jTVWkuZHDLYwiPRV9HEoggcnZXRL8loF61w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SEYPR06MB6311.apcprd06.prod.outlook.com (2603:1096:101:13a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.28; Fri, 21 Jul 2023 09:47:45 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:47:45 +0000 From: Yangtao Li To: Amit Kucheria , Thara Gopinath , Andy Gross , Bjorn Andersson , Konrad Dybcio , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , Dmitry Baryshkov , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 20/22] thermal: qcom-spmi-adc-tm5: convert to use devm_request*_irq_probe() Date: Fri, 21 Jul 2023 17:46:39 +0800 Message-Id: <20230721094641.77189-20-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230721094641.77189-1-frank.li@vivo.com> References: <20230721094641.77189-1-frank.li@vivo.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SEYPR06MB6311:EE_ X-MS-Office365-Filtering-Correlation-Id: 8dac6673-6c6f-4d9c-f323-08db89cf8935 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: srgO8q0mpqgKBoKgZ+JcioeFAfus8MhZERhiFSAF9zqjDEXLhewOFSxvd11NCi+wWLIHSNkeAV1kq9DoElEzO0co2NewFuAuzJkvtc9gO4aZb/qYdKbmqBOAyGhZgUrAj2XvVhBuwDeMAmoJwehkYVM69LBjewtkAM6F3GDz6eyMrgR7P9Y46ZNjBtim2YNnH1+pOA5NRW37LpRiF/v+lR3Vw/wQDjCVANzJam77RxqSv88la1cTSN/XSXRU+JxlIzCVBFEek9inJLS+EpiyszWraug1j8SwDBo9oLVJ/fCaSSMTcKSEvDJNsmlCRaHL1wJQDyXFzTjn8h5QBT9l9jR/2EOzIMnPyunzkmmBewkVi3e/LYYzhWKr2HQg+69MXBf1umSfHvJ6zmWswu/LX4i29lWRIW2fpXVif1ypckQA4xxlkniIdTVV1cHBek2FH97FRFRRC85CzjLkcpvbUSpj2YeHVdweF+D5P6QXaihNpgcPF8GErsQdOvLPtN1rp6jqZ0RMgWVDvUyU5GPL0PExUBggCmHi436x3g5U9wEzYnGKlfG6bq47rmPKv4mSRtODiNQDrCQqxNkXuaFIMOfZxwloWMnORwpw21Ik/zTuSSLLM1Er4eZbabwKTjCk X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(346002)(136003)(366004)(39860400002)(451199021)(54906003)(52116002)(6486002)(6666004)(478600001)(110136005)(6512007)(186003)(6506007)(1076003)(26005)(2906002)(41300700001)(316002)(4326008)(7416002)(5660300002)(66476007)(8676002)(2616005)(66946007)(8936002)(66556008)(38100700002)(38350700002)(36756003)(86362001)(66574015)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?baGbr84sBQMasjgrtsPf7wNtk3XT?= =?utf-8?q?C63lQqVg0CjTufJTx+YXovorPkFx0SLw++9NuJxfc55W22taExAN26jCazgU18dg3?= =?utf-8?q?kWTbpJDHMPxBo2gHFij1GkeHH+H/aGpvdHAjdB0u+VLEAEjHbsmpGzlQQ/ihcWP5l?= =?utf-8?q?x54KFQWYI/UzXfnbw5l1ecPrA83fYsfgs5hfyclc23Rrb3WIwN8kmLBsGOc8YlACe?= =?utf-8?q?bQp45JCTw50sp7pLeq6hY9FF36mnNKKZFejO+DItxGPG05kZVC3h2eVP5MNGgXRn4?= =?utf-8?q?HLl8Y8jNKyGkfipPo6zoiHZhy2T/+q+XOp9hcyzuwLAuaLSHgYhZRPT3JVJuc3PQu?= =?utf-8?q?J4T10eMz0s4o5VUS6oqpZ3nkfaqpaBF705WFYbOdItonLp6yS9bBmA+8JzUGu7OUk?= =?utf-8?q?JCAOjr/LW6ARbMbpPP86os1GvC/OXGI/HOBYytdfqMZaomhvh3yYiSPj1GmpDaygp?= =?utf-8?q?0fR8tLi+mxT9onqEFZH2SDwgRUSTEcjgWNC8bNgv28E000K8n/OQU9AyVrgsd9xu/?= =?utf-8?q?WDzbCrFjiEeL7kWsIfSPieRUl5QnzjqAhdWzUAwokC6OkbFasPNB5m/AgV7BPBJBs?= =?utf-8?q?WxShCQ6Du1biUg5OQlIbAvw4uVxJYgcaxH3fRpwSOCWKqM6azc4hU3ZecXDMxV64c?= =?utf-8?q?VDFr15Mm59KTbhNfEWcY8T8Xp0hb+jLP3TgezPCNjUlYJQ1Hk51TfLrQN+UF8wNoI?= =?utf-8?q?BDAkRUR78GM45AtcBuyT53FvsVjka5BkCfaJ4DsHGQEwlk52Qq85ioHqbWrv0LT4h?= =?utf-8?q?mvDJsQGvFhDLgUIh6iqM87aPjIovg6eb99mFnyIl8tOlt1ZevmZ7iqi2Oxdqmpc+B?= =?utf-8?q?wuYCy18Gw6Oy805ciEzuTBQMeur6F2fc+n+a3b2yDR37c7AuwdZMw0ExBr0ARvLe4?= =?utf-8?q?IOOq+LJvJjgb024YWxyIlWm6YFysVP/CKXh4q/N0q2M9L/ZS+1j5+NDh882kXho6e?= =?utf-8?q?mUvbfKGtDCCL5HRQ0SQGeLToMcy/mxjDozMcve/fNfFpPgHOIOVhub/KVyNjcr+TJ?= =?utf-8?q?isF2VWwbNsmnjpTmJuqIYHm2EtMAzHfb3bqDzhGHEaJ/sC/hSSzswkuS8dCgoLF8o?= =?utf-8?q?Ms83JfWGjqF44GAJ0m4SxCishU1pwg9uOkD/Afsuq4E/RCKk9q0RLatk56TLQrD2z?= =?utf-8?q?6NP+5cJGC/LVw8FHT2GrdueS0YN6pOgGFTpmuKUXW4UCQeDwgvM62As4iytZf45US?= =?utf-8?q?wA1Xci1qaMC63dBsroRbDREX8y549io9bNdcWnx2/d9w9R+LOTauUuXMoJ4CNq//f?= =?utf-8?q?DEotF1ORmASKAZdDFzFUUaU7FnEQklsAsRbdfiLvM5bA1+LI+eR1DHwZSfxtG1Db2?= =?utf-8?q?WwQCi3M8y0B+i0dQd4t47bJdygeTJRE6sc/Xy4rP5utb+X40RR82zYEchFjEHaeXu?= =?utf-8?q?FIiVd5gTWVI+6GYkiLAWKdj46BYTyCvwm+KVfA0CGvWBUiKR3TOp4okoKZDcdGEov?= =?utf-8?q?Ffd7MlnXdXi4RluSyCyunEZ2958zb97nccCtyxLszP2fL/7uWxgNUo+vLQfADWszf?= =?utf-8?q?FQ9CWUtDYigZ?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8dac6673-6c6f-4d9c-f323-08db89cf8935 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:47:45.7886 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bln0xofjKsrV1z3kn7cqGyKU6+dlyIcvr24REKgnsOO169NSSeYnIuf3p119QYN7cZ423FF/o/ubVHa3XgOsfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB6311 X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772024593330052294 X-GMAIL-MSGID: 1772024593330052294 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li Reviewed-by: Dmitry Baryshkov --- drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c index 5ddc39b2be32..90d46dc60806 100644 --- a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c +++ b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c @@ -1044,8 +1044,9 @@ static int adc_tm5_probe(struct platform_device *pdev) return ret; } - return devm_request_threaded_irq(dev, irq, NULL, adc_tm->data->isr, - IRQF_ONESHOT, adc_tm->data->irq_name, adc_tm); + return devm_request_threaded_irq_probe(dev, irq, NULL, adc_tm->data->isr, + IRQF_ONESHOT, adc_tm->data->irq_name, + adc_tm, NULL); } static const struct of_device_id adc_tm5_match_table[] = { From patchwork Fri Jul 21 09:46:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123713 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp91980vqg; Fri, 21 Jul 2023 03:00:04 -0700 (PDT) X-Google-Smtp-Source: APBJJlGh5GADJb8oKGI6nortSQNQHisaVPGrfrIIvPheyJ05aV8gBt8X3rsFHkDNXxzWFDXV7gOW X-Received: by 2002:a17:907:7750:b0:992:a85d:278b with SMTP id kx16-20020a170907775000b00992a85d278bmr1131546ejc.59.1689933604533; Fri, 21 Jul 2023 03:00:04 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689933604; cv=pass; d=google.com; s=arc-20160816; b=JSNNE/i7tJHAh9L0ZCjKdpjBsbPP80MqRcphbaa6lDfOhuljq3gvkW/Ey+Q9aSLi+R X+6WGqEx7hri+tZTunJz+vOAwfrmYMbps2XVJQBTV1OdRYQUf3ewooREntbY98sKVNjM Qwwc0ORU00tFeiZiomHesl6Y/F4lHAoi31+SKknG/MWVB+fRc/qL39QUvCB5qtts5yNl xnCk4bG0GKu0QgdHDUXxe1yDlywFOkaOW2O5+2tyMUR7sobWSrug31m7Xf4BRuWTdWXR NcZkUzQpfCD4Dplsti6pCnFH8KbR4YchB5IHjjAASzds5O7RaL3BRxuBgIV9g0+7gsv7 VoiQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=eHS28mIWTpLDBdxBKQHMC8i2TLY/+VTjWtqoEmhSPRU=; fh=AD4CoxQWdgI7p7+N5rkrKbUXTxbis0AReCDws7kMtIA=; b=0tuVykkmJFaAv/tA0ZkGB9w6WBKv6Kt/RKU6jHNvgl2xglo5MogKRJdwvbAHx7nIw8 abrPnezDVZmFdbdb7BTTV58tA4GmFl/PNs8xqhjQwF4G7xVSgU0NWvo9KoFH20TdhKNF Ej6JnUAD1i9rfDamhxhVRRuUgaL6HEFnSWM0LThj5vx9rCcvH5o/X2XK3tW46IZfgrsx GouZUuEQMYHj5hiCweTP4s2oF1C8qfXbm+8NB957m/5bDifJ8gbJzhkBB0PQ/iLdaYUM iRlX0MO2yI766GAND485EZV1rbjVYPw0IZpEPnvcf2LKAE0Sf7OqUyKfki8TcUrcWt0X R1MQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=IbkHq7Bf; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k6-20020a170906970600b009930d603e75si1729833ejx.905.2023.07.21.02.59.41; Fri, 21 Jul 2023 03:00:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=IbkHq7Bf; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232011AbjGUJvH (ORCPT + 99 others); Fri, 21 Jul 2023 05:51:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231954AbjGUJu0 (ORCPT ); Fri, 21 Jul 2023 05:50:26 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2103.outbound.protection.outlook.com [40.107.215.103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C92D422F; Fri, 21 Jul 2023 02:49:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YxRsoKYW3nNSXUTcM/j5I+PG5P+DRLcNK411qzLRjqo0Y+dsN/ko7uAZenqFhPZrHvfgYXNOaQesqvl7Zjv+4hb0gKSsyNG4OJ2MJOggGXwBkC+PqXVmUovUc5YMKOS1gNjlhhhbsz6TZmOEurScHULpGNGvBXB0ABsv7Xe+Rnc35dy0L9qE7xkR0mya7H3G+ARZudLex69TYLgNfTpo6QLgFsCpHYBrdZz//IN04iuMeb4hDVxxyii4+FGL0GGSq1gll7NWAp4mUcogCgRWekGACUncPpsif0OcnMQCFi7/JEx+W0gCs98i4WxcvloRRMggVwh9v3vxqyPljP49zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eHS28mIWTpLDBdxBKQHMC8i2TLY/+VTjWtqoEmhSPRU=; b=jCSG6QiL9blOnMDXr5v2mdl8tFsHfWVov+vl3KEkUdZRPzuJ4rvmZvSDrvb8yyjp/x7epiGKE6ZnWEyxtCIWZUvSFONEvz9JQCHQhuYWkgdKXHAF4eU4U7mGp6hmUDIVHFvRZ8XCXgFznQ+IACrytpZTIrJry0rkEtWIVv3RMXoqfX57Y+OEAFdCkhmir7c1Rs61iX47XMlXKkKewIkxIpkhmnPLEwuonXESJszCjcI1SB4xaXViE51zc4/nROqF85o4j/7t68ntPyOUFwnweA88CzKruOCTqLXWGT/ce5gEu6tsvxsmybkj8SONIPEHArdOSblqvTmdi/uZ8Ie9KA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eHS28mIWTpLDBdxBKQHMC8i2TLY/+VTjWtqoEmhSPRU=; b=IbkHq7BfobddcTlHXGVM/i+yMmYSr+nP+td3bEIQh4g0LsSFetF5m+R5X0sL4uuxgAc1LYHz9RG5/MHZHmUILDVeUD3rH4Vh45/PfV4L1r+BUNDrxl8JPxJSva9pDd/4EbJbkdHbam40O6cSChny2GF9wzab6QG4g7c03QUwztBcxmTSOuth86hT11rIXlPWbi1ihoZqTgOl+jAX4H7D9naxWHqXd9uHpR2PrMjKAsyjfDA6Uir3kiLooFa0qvlxfwzZYJK/hLHjp5riG00Irf9eUTsIHISZZTSTCuFV2vZ4t/D+AhRo0pe1I+rDwni72tR/PbxPlsv564h3XdyeHw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SEYPR06MB6311.apcprd06.prod.outlook.com (2603:1096:101:13a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.28; Fri, 21 Jul 2023 09:47:48 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:47:48 +0000 From: Yangtao Li To: "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Kunihiko Hayashi , Masami Hiramatsu Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 21/22] thermal/drivers/uniphier: convert to use devm_request*_irq_probe() Date: Fri, 21 Jul 2023 17:46:40 +0800 Message-Id: <20230721094641.77189-21-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230721094641.77189-1-frank.li@vivo.com> References: <20230721094641.77189-1-frank.li@vivo.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SEYPR06MB6311:EE_ X-MS-Office365-Filtering-Correlation-Id: dbaeeaca-81d0-4696-f6ba-08db89cf8ab0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b9hKown3F6RSZNmgshSHLy5Z0ABtWj82TsNLfB+Coyz/d5NzSDIEAUlXJs1bIYPhustjlkrVPlWPOSAwUW5gnjxjaIIotLASkhCbV7HetWmLo66Fx/nf/OBtm5BTGNiwL9t2MwDoj8j3Pfab4ZhabL36Rt3BAIn35S0lMY/rjIHZdIEz1OCAs2OZX/ctL+Tdno0IJK8tPv7DclYYqlLCpSgyZT/6QZJ+lBJ1mpF7sTP1DPolerGpvYSs0O78ps9X0eQUlYrfKxHu2EnuakHZvA9SWYfU4EdMElCeMqP46x3OUFdX1OMAvKOsQl5iud+rifiqxIFR07fgjn8oWvrFwJba6agVQuQOtx+J2+n1Y913kBVkQdwb07zzipLIR7/0s3ueOrvH6ghRtLuIunQOtAdX3kQpxbOY72JBaM3F3/H6z3QdSmziqYnhjB5kIGGnY7C4pqqng0RMZPGqZvVcbzMPvlQj2/1bNl1DhNWeYdBuV3ErPOlu+HACWlGvVwxBjxCWRvstpaFfOAIubssl+PBX2tEnWWT15POOjD1nVqFl6G3pwmUiSg8NKqpMCfM7u37i6uoZ84MydNnKXYPLvvj3VXcUsHJdkfnZr5xYMNKvdEoOBIJZsdi2AEYZBFPm X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(346002)(136003)(366004)(39860400002)(451199021)(54906003)(52116002)(6486002)(6666004)(478600001)(110136005)(6512007)(186003)(6506007)(1076003)(26005)(2906002)(41300700001)(316002)(4326008)(7416002)(5660300002)(66476007)(8676002)(2616005)(66946007)(8936002)(66556008)(38100700002)(38350700002)(36756003)(86362001)(66574015)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?OXfhg35g/oSt9Jrywn4q/pMCFgp7?= =?utf-8?q?KcvPNbyxc0rQUCKV5PBcKMwQ5WoOUowQUqJr7iDuPWiSJBOUcT3A4nD0Ut3kfFeJl?= =?utf-8?q?Huew9mv2ANPVOgbZlYZ868WYqnAYF6suAZIu3w8cyU4OUExBoZZtFYmiHvc4PMj8X?= =?utf-8?q?ApPJtFAB7rzxeNEExDk3eDvLERD1xos6zoyfP0PsQLtPAe8SD5GQTXfsb1hBCdgJ5?= =?utf-8?q?A3e3w7AvGvVqPLPZFaqkdZCacKP7Omp71/ZBijM7MvhogVCw2XN8T6WuNe6JhtxvV?= =?utf-8?q?r+EHIYZ0SZWyHKAMnz9o17+wHD+EGfStLIJTAqCszMTAmxYFKl8s8x6Pgte4XmfHu?= =?utf-8?q?dsw7O+TlBPuGoPqcJUAvbNTP4HtGXl46LOZKbC4AyvRS3LQGv3TSX5OB4kasBzB5g?= =?utf-8?q?brfHTwdnOr71GkHmrxFHQTngUXmNAFnzkeiMpzYIFufwIFa8l57RIsoMxInLUyS9I?= =?utf-8?q?3lN6mbljNglGUKRdXQ9vbhOZLUKFQrGL5o2XHRENadJh/qM9eYrYCAv4ZIymSwlJ5?= =?utf-8?q?/YL2Cs0zQayDF4wz0ToLQK/1MHQv1BJj41MT4hgPQBS5EfbY849bhF4dZhUpINovM?= =?utf-8?q?Uv2HH9xZFRIno8v1wAA2qnvubBlGXPX2gTbWqiZGBMX/5RVzga9vG2YbxOLW48cq1?= =?utf-8?q?EJ7vMg5TH4+1vqZ8AWuTwdnrNKvXtf4rALPSTYCcfqEc+WZ+B4oX7+gGAL3LmJx9s?= =?utf-8?q?3RTp+xqMm0/XEvGhdJCcJid6ufHRrnXlbjmhvssf15oK9uiyjyLscZMDZFhF95VL2?= =?utf-8?q?SVtlkY2njXg8fChH0qXI6j2LxZ6V4liiqoc4R0pszcdRDOgZ2IFyjCgWQ0D6dXnmI?= =?utf-8?q?8k4mWmRJb4JlZ9xM58Y7BSDJnOLnp/sObW9XzKykjnxdZASlyAihRjN50hMIzH0Xo?= =?utf-8?q?hSVeyfYYoBlx/MyIuFC57QFO5ayF3+c+La5mq+sD4slgYf8SqREcAiFDQ6CPIm4b2?= =?utf-8?q?8iy5wIgybwhBT/wHl12eY99OqfN47g79FwulmvTMD6DedlNCa3CNTmMROSSWAB5qU?= =?utf-8?q?IgAUjdJYnIMXzdUEQpUJE6zl6G6bkHeZ7ejX0FHo4vZ/00Y043bS9sJyV16dhKoZd?= =?utf-8?q?uznD6H7fwHCg2la9eLQ0Jq90SIVHXht8UBXmfJxvQwEbM1RWC4uO/VD5Q7baQ2RYA?= =?utf-8?q?k6xYhAq7rLjb3LYlINP/AfMIoau6I5MtQhKRsg3xNbAi8EEGUkb9XmDboyTBcQvfr?= =?utf-8?q?HMlhf5o3Q9KIxSSvBOhp5pOQVBuo+wgoNvA7Vf02ZwSB831QMTxyCSK2TO5BnCVVo?= =?utf-8?q?Qydf3/L5ufbTUE8Zj1Vatlu8atzvnRj6Hf/TRRp73OlA9NNNGfW35XOSEhSbVxtS3?= =?utf-8?q?YfvvLC4ysvYV4wbFAe4GX6pOXJ7aZuMe0OqpyMoIxj7tFaI9JMbaJbya188il14vM?= =?utf-8?q?SFSbOs63eMjNmKNJHOotjbcb21vt1zP4hg9PtPuLrboHzg/HcDE+JtMSqlzbNCO2j?= =?utf-8?q?NFZrL4/fO5K5gaWGoxomc0i1Kjq8A+RjZUXOG8YC9XwfAUlzGTE0xYlvN6nNfJpNM?= =?utf-8?q?y5a5nwN48TYE?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbaeeaca-81d0-4696-f6ba-08db89cf8ab0 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:47:48.2912 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Bh0wLh0RJiWX4xyqZblVpaFfaJMAYdj7hRaUOEBc/6amhXXzRY1vE5rhyDct3LmUaTNDQz7J0bT+8Kn1D2Ro/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB6311 X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772023819304551768 X-GMAIL-MSGID: 1772023819304551768 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li --- drivers/thermal/uniphier_thermal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/uniphier_thermal.c b/drivers/thermal/uniphier_thermal.c index aef6119cc004..34d8eb2138d3 100644 --- a/drivers/thermal/uniphier_thermal.c +++ b/drivers/thermal/uniphier_thermal.c @@ -278,9 +278,9 @@ static int uniphier_tm_probe(struct platform_device *pdev) return ret; } - ret = devm_request_threaded_irq(dev, irq, uniphier_tm_alarm_irq, - uniphier_tm_alarm_irq_thread, - 0, "thermal", tdev); + ret = devm_request_threaded_irq_probe(dev, irq, uniphier_tm_alarm_irq, + uniphier_tm_alarm_irq_thread, + 0, "thermal", tdev, NULL); if (ret) return ret; From patchwork Fri Jul 21 09:46:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 123727 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp99237vqg; Fri, 21 Jul 2023 03:12:34 -0700 (PDT) X-Google-Smtp-Source: APBJJlGXX65FK/HxrEHQ1dMjoKHorwvq/VJod5DURUEV37Xk3V0My7wBqGnT4j5S8YzxXwvj3vo3 X-Received: by 2002:a17:907:94d6:b0:992:13c7:560 with SMTP id dn22-20020a17090794d600b0099213c70560mr8112445ejc.38.1689934354471; Fri, 21 Jul 2023 03:12:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689934354; cv=pass; d=google.com; s=arc-20160816; b=lmntgWSC07siwVW/7mphXtXxNvWBounjDbsj8c3Sci+tVf/VlHZcJ/byI7RX4Daxiz YJTv2p5GyRnUtfepUBRIpTeWaPv5xuCZXktTRNI2M5jblX/RuJasNg385faDUyJ6uh+9 JelECSC5mhXgCt3+xHx3SgcW9NnsrT8qMRNChwQZVV0livMiImgcBuMqjVEA4V5ml1kU EUIIYdZyVnpuY5Now7ZG009USiPFvBDilyEjLtrwBGaknHj06HO0jJxI4of7TkpbbnW2 kl/7QoxNkqmUsp6HpBa6U8r1jVffWbFlnp5YeAwSkt81frd2O/GGsXHwA0ed15+FYt8Q /60g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fIbTe94tJb+c7Hut//D6DIRJqgxdHnLzwdkufWRqizI=; fh=hJWu5E8n5R01lKxwZtJh1RYO5G8RLxFZH+3ru/WgKGQ=; b=V9yOyppBtA4h0A//rXMA+5UG9KSdOJMGmzushS0CP84kAf4yIjgZG+BqIbbDdiyvOe HRlgJQFc+2lDENItbqpm4ZjNXU71H3w/QKJwaH/x+ExTIhK7Y7RxQg1s8+mV4k0HayT4 wkKg/TbR8awPSJEJ+X8AkVHnkt0dCF10tv6M6Q4yLw6OTEFyB/1yIeQR40LT6/1U8923 jMNAuPzSQQlt6DV70Ihazehg18TE61EJGWFw1qP0gAA5vGlJrYPBk9Wf849RRk8qxFWh TkogBBakdeM0DdXFHqohv9qVhj9WPfUNtkVOD4tEf5pnofpFDJv+zorcDGArcci/3ZL6 0Y7Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=YfLqnjU7; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i27-20020a1709063c5b00b00997cc1ef3d3si1919275ejg.375.2023.07.21.03.12.10; Fri, 21 Jul 2023 03:12:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=YfLqnjU7; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231855AbjGUJvL (ORCPT + 99 others); Fri, 21 Jul 2023 05:51:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231976AbjGUJu3 (ORCPT ); Fri, 21 Jul 2023 05:50:29 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2102.outbound.protection.outlook.com [40.107.215.102]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0683A4480; Fri, 21 Jul 2023 02:49:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i1X9y9FcNNu/kjf/1setfIQ3zY07e2hMPNQhzMkbjMRBjs9PWUpvLAa1O6mN0PH3m3sDtyulsterfmTjx7eIDtXhL2ONqGardJaX/i124yCWr26/tXGc7jyL5PARLU8DsK7ctHUt1AQ8tbTYfOXt4k47wDeI+FosnPSRY3R6PX31O2SJlQtKcvQ7ljWvrAMjgApwJNzT6SNpEkN4W2AcwkISC5uuBMxtpyT+TJC7A+MpF+7HOIj9chrSVXUEl/NzSj7Vldj/id8zmnIqUNndD1yuLHqFHjXU8AiWitOFDtE1UuujRxMIq4VkVxWkJmAe+pQPSOMYLKFCaw21qjvdsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fIbTe94tJb+c7Hut//D6DIRJqgxdHnLzwdkufWRqizI=; b=OxLzCYm9O98vAmE18D4z3fGsPw2CghRbp5nI9lzxB34ffyoUbkTZG2oR59/PLvwm/0s53ullYaTrMwNNRP1E3/pVsZFdOSiA3fg61yfMkRZiTs8GWXZLzHiNPQ9+QGbwHirBHZqWT2vuRSqkiXwmuFMoZBrPg5K+DYNk7pY6va6X4hY7MgW+M9is60/t2490nmEyy+Bd2kw6uBAxWN/sR6msQdAdNaqH0ilS0YKEpUQPhIAvlcMldnJBtyZxNyYR0MbIcIzp9T9N5WOtPBJv2Ytc3fLUidnjtJfjuHT6pcy/ZmA7D0VLuv3iPEo6eVs/IFuarHCrX4Pf97rAimeXpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fIbTe94tJb+c7Hut//D6DIRJqgxdHnLzwdkufWRqizI=; b=YfLqnjU7d0ZgjnPx6Goh2df6H0perLUo5GqPhjXYBeRZwTP5SwtaTd80O9ttxW9miD489ghMngkpoipGYRvdwplxONFyaS2AWT24xNfSDdwY3xTxalTeRWgrNy3a45pMKiPR3A3INGOu2+pJe0zXJU+Zj1lC+3y3l5ySFzUoJojssEqdiQ8l5NfKqZGcYEJn7Mb+DUC1F1ZRizIsEYbZUwLeMK8Y/DPSY5r6YLk/NEoRtuzC7LcwPwlMjNn96AhlFKELmGDZ//qDqu8UvCOx9RQ037G0TSXebYNWiULAaSgKufQ54aTRRcgGFVmsoOv52qYtm9f6seYmDnmy4nBT5w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SEYPR06MB6311.apcprd06.prod.outlook.com (2603:1096:101:13a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.28; Fri, 21 Jul 2023 09:47:51 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 09:47:51 +0000 From: Yangtao Li To: "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Cc: Yangtao Li , Thomas Gleixner , Krzysztof Kozlowski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , AngeloGioacchino Del Regno , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 22/22] thermal/drivers/imx: convert to use devm_request*_irq_probe() Date: Fri, 21 Jul 2023 17:46:41 +0800 Message-Id: <20230721094641.77189-22-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230721094641.77189-1-frank.li@vivo.com> References: <20230721094641.77189-1-frank.li@vivo.com> X-ClientProxiedBy: SI2PR01CA0031.apcprd01.prod.exchangelabs.com (2603:1096:4:192::11) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SEYPR06MB6311:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e42cdd8-88c2-4e7d-1846-08db89cf8c90 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fWDUlaltgJhgCnQKW/leisz7mhcwSFLJqiRPwHMzPdZ5GiWwdZEPzAQ6J48RJ6tKro9ie9UINTgmR4JQiZ6hQDboQ4IIS+nHs8SPah/eavS587oin/YnhCmDWLD6K4CE3X9NPAerVJR6qAaD98F0Zn+mit8iMCgiv6sPT41LtTLHm+UXXcXfG80AmUcZoa8j6fShetkB9A9exzDRNlszjDZwoEh7Gp6vpq1lJnaubW+UZSbB/7ph9+dpRWmcXiF/xoLSdSQA5sFY0KGrygLbSUYT8pic2VlelWXqdZsQaYH159SXJN43MmND+tMYQc5/2fSH47OjjgLY+c1k74+dIQ172A9IS4bXATzwqsUguCHtQvpWHjzKhM93cM+RE1pUVCtGoq/ovsAjC5xu+2zjYgUJ+QXOYiNUsytBweq77vSQ+LsmXy6BKF3ZF/Bo7BSzXde3DPwCg+gYfvHe3+SVwniPQ1HfY4m/K26ADmr2MxivARD7aUTjTaYtnhrESiIC/u2IItLtlLk6t6JYIJbOaDMc8y6eDUvI3wO6kcTrmBHQrBO2b/HRKL5rzuc2kYrB1de/3tryZbYPUigR6aQ6hgcJ531hIZlQFxC+Pn7Nw1Ge4kJXL6TrNtpYOnrLLtK9 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(346002)(136003)(366004)(39860400002)(451199021)(54906003)(52116002)(6486002)(6666004)(478600001)(110136005)(6512007)(186003)(6506007)(1076003)(26005)(2906002)(41300700001)(316002)(4326008)(7416002)(5660300002)(66476007)(8676002)(2616005)(66946007)(8936002)(66556008)(38100700002)(38350700002)(36756003)(86362001)(66574015)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?j/lit1x+XffgJMhwl/844lV+xZkp?= =?utf-8?q?vM7jGGRION3+sfvvNcDZxBA9JEYosr6QAtB4Z9jPGWpqa9BMRp4k08/HSvrnmrDsz?= =?utf-8?q?jy7z6sCnxw7ea7c18C2a2CQaohrbh3Z/NS++mOBPvW9414kkk7oYRCLS3LlKOp3vk?= =?utf-8?q?Uh4C/Wfa7wyIK4RjZhO6rogdCCBgMh0siamainECUO6NAIgngy2HmMFZqqJkvcpVI?= =?utf-8?q?OvFwgRwLqlLYhPZKaLjhiVDB9zSV/qQp57sJcULETSrNMMn0qoYnNOhtZPOGyu8MP?= =?utf-8?q?mGhwdpMdslLmLvWdAAGFdaAeImnXBi0Vjs4aFwL14FsdtFfLOlxADh6ropI6F+Squ?= =?utf-8?q?PaFa47ZyaIsE38Hdq0KQwQYYJa0/psKgpaX9WcX1REJw+572HEMPeFkK4WblLWN8W?= =?utf-8?q?/pib0ebIYBi/qaU1AScvO1YzziAXG6/HG/Hh9SNkbbG5QmF+/fIbZn78ZPr1rrxwH?= =?utf-8?q?ILrH+NP+cToxff6+t3ASAGmtQmjthlrw63X2/2bsovUMCk2I0ydrVJAppkWkBY9LR?= =?utf-8?q?ZZV4vju1bQImAjvpgc3EZuIlbrgr2fvy21oavWdsJQWnjaVj7Q+5W5jHikeP1LYzk?= =?utf-8?q?tN87zQjrgdo0Vq9sHApbyKTLr9W6lCinJK3sB4l/gSfZCNtT61JRNHwW54AUPI0Kw?= =?utf-8?q?IGgfooyw088Ezl2wtjIYkenAS2wDOTHnoSeRKvgDRWkGpzvl07b4TPW/1pAb09nr0?= =?utf-8?q?fLDLm65hdgqifeksFJOg5VMsFhjPQ14E8z1kCgLz8TVkP28WsoJnMMThxeSy8t/12?= =?utf-8?q?OhOVqs3LeRAYQDQh9zU2xiGghanMiquq76B7QktCVYSI1guElQfEIlHK2X81yqo7f?= =?utf-8?q?ejrmh0jsgaVGB24/Iq6hKhHdvQSe3USkydAujvzwqfZkpQJKwduDmgd4LacAMpO2H?= =?utf-8?q?tdpfw5z4C801flSJIXsKq47o276Sjx1pRi5NzoI7uUYLCioOEwbfJfqMAOB9GMOtk?= =?utf-8?q?xoGuxuXB9C7wEZ5T19Xb48sL1UobVtukvENezN6L8HcZ9J+MG2ATpYVP4AruhKYb7?= =?utf-8?q?pVhvZRujbZZfzQt/cuMP2RVCNtOT7F69jyAVBRURvYlnihZu2S/Zsx0RBzoxhAVbv?= =?utf-8?q?UtkkjMuR83Uj9TUf/jZaxGAV7+GZrco97BLzMvWjoE1ZkfCeHvaCoKghin9ZvvWaK?= =?utf-8?q?hzOZWdvyLwgCjP70VtYeEP8EKFyo3qlZQqOy/DjzYHKM1RP38Z3jvS5Unf/qWZZpC?= =?utf-8?q?GF3AyTRgzeNQ6imHlNCSsrnC5DsuTNDpbIKnul+Q5OvYyQXxfgACwVs9BKUe8Sjdc?= =?utf-8?q?QXbJwaK+ksxxdj/9nHmNv+3j6HblVkNBaow33+6Bv49Evl2bu4m8SPqBTVcthhCxR?= =?utf-8?q?bINLAjEdNmCQcLBOBmZ4b/niRHYoehT+XmdhU+8PeFyEzcFb/C8F5aQmvq//stIGg?= =?utf-8?q?zKQ+tvjdwTuftQVl4f1VsFe97x5Fv767/N9VRQSD8HlFnpNnIUiL67omqwLgDfi7T?= =?utf-8?q?uMn6f7hDvlDWAtco1t0tUJRgi2P/Z+a5FHeSql7jagxK3lfd+I4ZGtAkwAKsSUyVB?= =?utf-8?q?DiWsnScTSB40?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e42cdd8-88c2-4e7d-1846-08db89cf8c90 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 09:47:51.4455 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P+mqNAlShJxMX1ySgcwgYiTsVmWdSj4jbn3SSliafoG+HmcsCinI20aXBLVnIoTQT4k7d9ZtwwJ0cNlbj08KWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB6311 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772024605748642450 X-GMAIL-MSGID: 1772024605748642450 There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner Cc: Krzysztof Kozlowski Cc: "Uwe Kleine-König" Cc: Jonathan Cameron Cc: AngeloGioacchino Del Regno Signed-off-by: Yangtao Li --- drivers/thermal/imx_thermal.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c index a94ec0a0c9dd..3131a09f9906 100644 --- a/drivers/thermal/imx_thermal.c +++ b/drivers/thermal/imx_thermal.c @@ -746,13 +746,12 @@ static int imx_thermal_probe(struct platform_device *pdev) if (ret) goto thermal_zone_unregister; - ret = devm_request_threaded_irq(&pdev->dev, data->irq, - imx_thermal_alarm_irq, imx_thermal_alarm_irq_thread, - 0, "imx_thermal", data); - if (ret < 0) { - dev_err(&pdev->dev, "failed to request alarm irq: %d\n", ret); + ret = devm_request_threaded_irq_probe(&pdev->dev, data->irq, + imx_thermal_alarm_irq, + imx_thermal_alarm_irq_thread, + 0, "imx_thermal", data, "alarm"); + if (ret < 0) goto thermal_zone_unregister; - } pm_runtime_put(data->dev);