From patchwork Fri Jul 21 08:07:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen-Yu Tsai X-Patchwork-Id: 123670 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp65149vqg; Fri, 21 Jul 2023 01:59:00 -0700 (PDT) X-Google-Smtp-Source: APBJJlHZQO2+Xp9WfqBFIJLgidjh6qG28TkhnCXcDJAnd2OOHNWH8TYgb4JTxqRgZsaMKUqD/A9I X-Received: by 2002:a17:906:9bd2:b0:98d:9655:3fac with SMTP id de18-20020a1709069bd200b0098d96553facmr1083264ejc.71.1689929940406; Fri, 21 Jul 2023 01:59:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689929940; cv=none; d=google.com; s=arc-20160816; b=ncejhbKPWliUR2Sx37gKQJxFxdFMCgMmSDENVM6ILmoqb/UtD5qj5vOQDkYFfhBbz6 z2wfzrHJBLuXqih6hS54BMtsHtF/pzD+BHYeDwdp5GPQcRjeVrhcLdENZI+DyEjGRRw3 UPB5u9yxk2xXQoQvoWqhGRwnLtNJJrlxkRTYPDiB1Qjwwg+pu95R7ryT6WVXkOVD9Y35 KM1Aj3WgNOOdoTd3H9ddpzhlrwy797a7pTTwngMUesr8WJ45r+13ORW4i0i1h7E1VFGj PyFFNmcA4WZfu6E1ukTAGWZ69YPVTKU5oCTTWjWe4MaHCo8vpFGjmDDnKfznq/GqS14v msKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NqcAnVxpvMo7IksBTYj7fHRMjHClyEVoFOPZWnp2zrc=; fh=VJ01W5r8lnAG5bxIKoK7gZ7nUj903k7qXzCTwY8Msq4=; b=YL+BAGFz2Y0Sc+b/y2Ps7phQqBO2tibIF+DDMFs2hrk7QcmbimjHYBMkjkyBphK+bD bIplY7UQPENNbttRpweH/dDWlUsl1ZAuKb5OyMX/i5Mm8fl8C3LkdMxdZGnnX1VZ9fIP h0hdq9IlCBbfkN6oVgGy/9/JuiQeq0uLuTtW9hzthAdZsxxeZichl3FqjEYPA2A/FaK1 x2K1HiHp0Z/Ss0CB7tykvTXIb+/JG2nMP5paaCXK6BKG6TpB5DzQlAE7+Hlq33IVPq3b Xo8VYr5wX2QtX0HI0+cdaeooe7PW8ccLehYs9RRr9iYABGwZKI5EF+cknmY2bA3U0lfg ETug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=FiaLlQpG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n1-20020a170906118100b0099381745ba0si2080722eja.156.2023.07.21.01.58.35; Fri, 21 Jul 2023 01:59:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=FiaLlQpG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231419AbjGUIIT (ORCPT + 99 others); Fri, 21 Jul 2023 04:08:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231377AbjGUIIJ (ORCPT ); Fri, 21 Jul 2023 04:08:09 -0400 Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C25D273A for ; Fri, 21 Jul 2023 01:08:08 -0700 (PDT) Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-579dd20b1c8so17508717b3.1 for ; Fri, 21 Jul 2023 01:08:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1689926888; x=1690531688; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NqcAnVxpvMo7IksBTYj7fHRMjHClyEVoFOPZWnp2zrc=; b=FiaLlQpG+FX04kcW5hPzlM69UWqegsCa8SHht89DbgfZwxyZ2NPixF4HZ+bjd7wy80 w0A2C7YWmkD11MfX3bs7qVweeGnF99K6lmjgksE4chTNdK2n/UggSDKHtaI5ZUbxNNPO 0aCkJQsa5a3qlFG5A6KhT+53F03Rt19zOX/BM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689926888; x=1690531688; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NqcAnVxpvMo7IksBTYj7fHRMjHClyEVoFOPZWnp2zrc=; b=FZhHZI6xXXPDLiBRtrTC5b2YsGGYAtW3lqRv0PRcFSzwxMoD6Uv+MmgaVK1tkzFwui QOZq7iDaQisJ0ugC1tsqEtw0v+8UM7Fh6XDNbOHrKrhCZu+sdieVhMB2PRx9O2DYNlCF LRBlTKpI4a7fFlfhZDV7jKTUimTtjOat7K3SFa1Z0e87pzFyjDhBRXsVZt7W+Qxzjomu CS7DR/HTO4HgSoe6IGvfd7Syw7JRGuL1+zFdTiLKg93IqZ9Uj780Honm9h8xr9jtCtEW wpbRpipECcPKbxP9PdXSuEeC5WD63Eife/Flf+/Hobi0kHvN+Z2SW+NSQoCZ3BobF2Ik DHMQ== X-Gm-Message-State: ABy/qLaQ26gUaxqtph105trmaYzuZNOE+70FQ/8NHQpuZPRQqWfvxJrM VCN2V7DXR+vxDcNfcpoLn82Tsg== X-Received: by 2002:a0d:d6cb:0:b0:561:e8d7:ac6b with SMTP id y194-20020a0dd6cb000000b00561e8d7ac6bmr1388896ywd.49.1689926887693; Fri, 21 Jul 2023 01:08:07 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:6d86:d21:714:abab]) by smtp.gmail.com with ESMTPSA id o10-20020a170902bcca00b001b850c9af71sm2740294pls.285.2023.07.21.01.08.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 01:08:07 -0700 (PDT) From: Chen-Yu Tsai To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Brown , Liam Girdwood , Matthias Brugger , AngeloGioacchino Del Regno Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/7] mfd: mt6358: Add missing registers for LDO voltage calibration Date: Fri, 21 Jul 2023 16:07:42 +0800 Message-ID: <20230721080751.2012318-2-wenst@chromium.org> X-Mailer: git-send-email 2.41.0.487.g6d72f3e995-goog In-Reply-To: <20230721080751.2012318-1-wenst@chromium.org> References: <20230721080751.2012318-1-wenst@chromium.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772019976876869483 X-GMAIL-MSGID: 1772019976876869483 Most of the LDOs, except the "VSRAM_*" ones, on the MT6358 and MT6366 PMICs support a finer output voltage calibration within the range of +0 mV to +100 mV with 10 mV step. Some of the registers for this function are missing from the register table. Add the missing ones for MT6358. Signed-off-by: Chen-Yu Tsai --- include/linux/mfd/mt6358/registers.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/linux/mfd/mt6358/registers.h b/include/linux/mfd/mt6358/registers.h index 3d33517f178c..5ea2590be710 100644 --- a/include/linux/mfd/mt6358/registers.h +++ b/include/linux/mfd/mt6358/registers.h @@ -262,6 +262,12 @@ #define MT6358_LDO_VBIF28_CON3 0x1db0 #define MT6358_VCAMA1_ANA_CON0 0x1e08 #define MT6358_VCAMA2_ANA_CON0 0x1e0c +#define MT6358_VFE28_ANA_CON0 0x1e10 +#define MT6358_VCN28_ANA_CON0 0x1e14 +#define MT6358_VBIF28_ANA_CON0 0x1e18 +#define MT6358_VAUD28_ANA_CON0 0x1e1c +#define MT6358_VAUX18_ANA_CON0 0x1e20 +#define MT6358_VXO22_ANA_CON0 0x1e24 #define MT6358_VCN33_ANA_CON0 0x1e28 #define MT6358_VSIM1_ANA_CON0 0x1e2c #define MT6358_VSIM2_ANA_CON0 0x1e30 From patchwork Fri Jul 21 08:07:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen-Yu Tsai X-Patchwork-Id: 123648 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp49981vqg; Fri, 21 Jul 2023 01:20:43 -0700 (PDT) X-Google-Smtp-Source: APBJJlEDZKXGI5cmeSOtZU2WfMipdr2V9UycITVk8JAjqOSVsvfIcWbH3T0FmhwSNvJz88K7+/9t X-Received: by 2002:a05:6512:3e5:b0:4fd:ba81:9d43 with SMTP id n5-20020a05651203e500b004fdba819d43mr768202lfq.56.1689927643320; Fri, 21 Jul 2023 01:20:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689927643; cv=none; d=google.com; s=arc-20160816; b=jXPn/mQhCWKKdWBqcEjtYdRp+D9mkMDPZ21OjM/nJ6X8t22vtl1EInWNEVJRYl4T5t 232HDbRlMvYoEbTvB/Oz41VRiJm9aA4XBKlgsRI7aXyOr7E10wyUZTotObOeP6gmawBC LAADzFDE3mHrLVL6w1oU2eh/lkSqgLdq5ZeR/ZlI1kMPsQZqY3nyt4wHCMC54eubSNn0 WXOH2yJdarxGGcizQgO7FlmnNo/rfMYo/XWSdyhMX+2wxHcfQDKQtvBC238cfp2UH+vB AvLk/had7hym8Dy/00I0CQLf+qy23pEQBowYNY7bSjOffLdsTxqRP5eejvB2G2D6b4kp RPlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VIWYt/VUR+LWe3Ym6ggQYemB73LQMpv4Ia87+08eNu8=; fh=VJ01W5r8lnAG5bxIKoK7gZ7nUj903k7qXzCTwY8Msq4=; b=z2isHa47mK+X17jBC2apjQOHYmWQSyH5e7zgIALFvleBwUYF3j/gxi9SckyzIowenK 2qI3sVrHDW93VhSnpWvn5R8t6QvLy6/GOr2yCHAU+nZ/9WfvK2QJhOQwmYL1NBb0b30f mJnHxNvGNvUNwq4frodeZxfiRaKKrLtyYPtetM1NgkJhuqClvDAFi75awNKfqVXjJnWy GZ+DWt2QD6z2AItxuhTuoAFgq6U2jAMUKTPgd9tjUK/f6lwzFLGkrQtCG6mI8C7n7lew WJ+A2FfTc4xbJSilm21hqq4PQ5mSVOh8ujy82p1l8WJaYa9F1ttO9jFiz5UgibdhhI2G /VwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=mOqIIVg9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f2-20020a50ee82000000b0051a53f2684fsi1967256edr.576.2023.07.21.01.20.19; Fri, 21 Jul 2023 01:20:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=mOqIIVg9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231421AbjGUIIW (ORCPT + 99 others); Fri, 21 Jul 2023 04:08:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231362AbjGUIIM (ORCPT ); Fri, 21 Jul 2023 04:08:12 -0400 Received: from mail-vk1-xa2a.google.com (mail-vk1-xa2a.google.com [IPv6:2607:f8b0:4864:20::a2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDD982D50 for ; Fri, 21 Jul 2023 01:08:10 -0700 (PDT) Received: by mail-vk1-xa2a.google.com with SMTP id 71dfb90a1353d-4814505ddbbso732160e0c.0 for ; Fri, 21 Jul 2023 01:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1689926890; x=1690531690; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VIWYt/VUR+LWe3Ym6ggQYemB73LQMpv4Ia87+08eNu8=; b=mOqIIVg9BcpADuYEnhsJwNphrOGgsZ/jx0kH+3BSYoXkYKZWwTzoWjv28ReLmi9Hp5 fu1Wwau6EMEiARv3e8CYbk+7qFAmYEI57cpZWbaGQn+h1+V3JoGukF52RG5fy7ltxenJ O1SF2oZuyLhxYpQ0yxCuGKxdEvMBZ1CGPiaN8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689926890; x=1690531690; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VIWYt/VUR+LWe3Ym6ggQYemB73LQMpv4Ia87+08eNu8=; b=cn+MtFNOpVJUDm3ulTAofLMQhQFzmL3TjMVCDUmXz01nkuzIi7gzDrNxcvS5Tli6GC 2zgrs1TVTlRJbonCIUOYw3jCgvHPp1JLeIMvBqJg1wavchpxIZqbTO9nb+G/aCwSw384 62WFcNs0AKuFl+1NbiuhuOaVOWQtdFuaUL82khse4kpUmizVlOrxYeQgsX7aJ8jVd9Oo yB/qUbkesVRKwYz4C9QBpOLGgB31bLAnMX+7apS9COyxRsYgg41Qftr1jhZ0hQGP+Dbe 2qugG+UkqxyKU88Ww91vWbU0lbgXtyeqzoeudRPbQ04ghXqZjCIQMPWOOEnaWMv5QuZN 5pyA== X-Gm-Message-State: ABy/qLaetDInG7n1/I+ZoKZG5omjCHRoyWXtXKsbTSpD9oJnos0QYGME yzklm+QRTXWSZKKD5PWC9eqtcA== X-Received: by 2002:a1f:3fc9:0:b0:471:cea:3d62 with SMTP id m192-20020a1f3fc9000000b004710cea3d62mr698570vka.2.1689926890023; Fri, 21 Jul 2023 01:08:10 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:6d86:d21:714:abab]) by smtp.gmail.com with ESMTPSA id o10-20020a170902bcca00b001b850c9af71sm2740294pls.285.2023.07.21.01.08.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 01:08:09 -0700 (PDT) From: Chen-Yu Tsai To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Brown , Liam Girdwood , Matthias Brugger , AngeloGioacchino Del Regno Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/7] regulator: mt6358: Sync VCN33_* enable status after checking ID Date: Fri, 21 Jul 2023 16:07:43 +0800 Message-ID: <20230721080751.2012318-3-wenst@chromium.org> X-Mailer: git-send-email 2.41.0.487.g6d72f3e995-goog In-Reply-To: <20230721080751.2012318-1-wenst@chromium.org> References: <20230721080751.2012318-1-wenst@chromium.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772017568783597606 X-GMAIL-MSGID: 1772017568783597606 Syncing VCN33_* enable status should be done after checking the PMIC's ID, to avoid setting random bits on other PMICs. Suggested-by: AngeloGioacchino Del Regno Fixes: 65bae54e08c1 ("regulator: mt6358: Merge VCN33_* regulators") Signed-off-by: Chen-Yu Tsai --- drivers/regulator/mt6358-regulator.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/mt6358-regulator.c b/drivers/regulator/mt6358-regulator.c index 31a16fb28ecd..da6b40f947c4 100644 --- a/drivers/regulator/mt6358-regulator.c +++ b/drivers/regulator/mt6358-regulator.c @@ -676,10 +676,6 @@ static int mt6358_regulator_probe(struct platform_device *pdev) const struct mt6358_regulator_info *mt6358_info; int i, max_regulator, ret; - ret = mt6358_sync_vcn33_setting(&pdev->dev); - if (ret) - return ret; - if (mt6397->chip_id == MT6366_CHIP_ID) { max_regulator = MT6366_MAX_REGULATOR; mt6358_info = mt6366_regulators; @@ -688,6 +684,10 @@ static int mt6358_regulator_probe(struct platform_device *pdev) mt6358_info = mt6358_regulators; } + ret = mt6358_sync_vcn33_setting(&pdev->dev); + if (ret) + return ret; + for (i = 0; i < max_regulator; i++) { config.dev = &pdev->dev; config.regmap = mt6397->regmap; From patchwork Fri Jul 21 08:07:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen-Yu Tsai X-Patchwork-Id: 123659 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp53635vqg; Fri, 21 Jul 2023 01:30:06 -0700 (PDT) X-Google-Smtp-Source: APBJJlGiSZ7GhSTXBawERWlytq5Qlp2O1UDM0vL8vQNX/kMl0SlQtAzeGZCteEm44ZP+iz8adjTe X-Received: by 2002:a05:6a20:728b:b0:133:7ad8:71b5 with SMTP id o11-20020a056a20728b00b001337ad871b5mr2814631pzk.0.1689928206501; Fri, 21 Jul 2023 01:30:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689928206; cv=none; d=google.com; s=arc-20160816; b=EkVUut7f6dU+CwLqv7leRCUSuDtW2jzAwel0v8tWEvpC0WvqF55Aq6ZBUIBpfc6jjc idmzwWgsfT57nKdl4t6PBdn5PBfz/F/wT7VJKa4M1mRqrShLsxjlU+QsIwWZCvDCl+aA KiEZ0HEv4+IIos9EJlIZ1S/Q6FP1mGRZ6vuC60DFgxiC/L5eNnUXQf7L/ipDyxBi9mr/ QJt1YeP4jg8FKRaPLg4U9dLMuFpky8OtR2hRsEFrxdGP2XEV+twgDdd506wN64bWUbbr E92NHPsPWdcYt2+0cvxgNylEwdWfg/sfDgdklQ7NihQoP6mc4az9ouFQRBBkqUlQDvh3 Y7lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mjm1htpsgUdaRZcHsGo757GH1rkymaOgiUPQg9DWT7s=; fh=iOmZFAPjJaj3RDCjm/a5vTxH/GRq1KLUFMrVkLL4jqI=; b=X19Tl2hgb0mcJdk2gMtQX+LB2TusKXRS/N2Lk+SBA8qnz5BkU2o/lFtjKt7Xjd0Cnw qgfbfBas8zXU6uXS3SyCtB6JYkpIkRx+DE5Qi9qO9AY3rZsxuecBvdP/MtF6XiKra9dO FpqA9WzAIgVxJZkWxHX+LYCASxsVEXNQkFKl29vzgyxODVW0ViqokXuFIq3EKE/Qmgua H5qyYxys4mKx3rTwkvmlhaECVXJVMjBjY7VmO5yip6VG+0wMHQ+H0Ydz/5reu4qYxom/ yA/7z3cNhnDGRgB5ZbEQiloB0gV5HyenD9Zs95HXjX8bXIt0LJ8lrXcHQD0zD4pPnF/R h32w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=apTJsacQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n7-20020a6543c7000000b0056387def1cfsi487676pgp.48.2023.07.21.01.29.52; Fri, 21 Jul 2023 01:30:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=apTJsacQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231437AbjGUIIY (ORCPT + 99 others); Fri, 21 Jul 2023 04:08:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231404AbjGUIIR (ORCPT ); Fri, 21 Jul 2023 04:08:17 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA17430C4 for ; Fri, 21 Jul 2023 01:08:13 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-2633fe9b6c0so1954250a91.1 for ; Fri, 21 Jul 2023 01:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1689926892; x=1690531692; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mjm1htpsgUdaRZcHsGo757GH1rkymaOgiUPQg9DWT7s=; b=apTJsacQxezIERIOQSQqwO451/lek2u8gXH7fZL0cfCdEDjzED1YDa2Baxbhk9Skr8 08FwwyQ/l7u4oL/MEXt8tamuL+5yYji/Mqu99B67oXI7wh9ZmE0PRft4CzhT55XJMN3A dwc5kMyE67C+0BtJfA5fjkXw4DR3dkg7NWXhw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689926892; x=1690531692; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mjm1htpsgUdaRZcHsGo757GH1rkymaOgiUPQg9DWT7s=; b=RhAz7vx3TsseaAqWe+v0KP/52XP4GnTLpIvdwE74az414jeTvddfgb4PjV5YG2BLIa P1AjI1L2OTlf9VrxihaZFTJIlXu8CJ3MWGQ7UOwy21AWG6x0i0GXiEwFXF9oxGxhhfDx DVD7hWbDjUmkQDLlHx7dGusWVS/wl2bV6lXwG7+l+8CTAYMnBE8/8UNv8IW2M5w19puW s2DrcXnJPuxvGnXMEelSJA1Aoz3QAcR5I6MEAEpHcYvRsfrNh7PCjoYMtdUQqv10lKgo v0cdQqr2T52o0j2IM73ZMFq6+sHGDFzk2z298VBWIJWToviitVulaie2PGtHxgGUW8pu GT9Q== X-Gm-Message-State: ABy/qLZRqnp7NXRVTXyE5mp9Dn+DoL1wLg3J1sBoEAvrefTOVA0+t66A zkVhB+BCK+F9Mbrk6OtAg9r82g== X-Received: by 2002:a17:90a:64c2:b0:25e:f696:1cf8 with SMTP id i2-20020a17090a64c200b0025ef6961cf8mr1951333pjm.14.1689926892623; Fri, 21 Jul 2023 01:08:12 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:6d86:d21:714:abab]) by smtp.gmail.com with ESMTPSA id o10-20020a170902bcca00b001b850c9af71sm2740294pls.285.2023.07.21.01.08.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 01:08:12 -0700 (PDT) From: Chen-Yu Tsai To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Brown , Liam Girdwood , Matthias Brugger , AngeloGioacchino Del Regno Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Fei Shao Subject: [PATCH v2 3/7] regulator: mt6358: Fix incorrect VCN33 sync error message Date: Fri, 21 Jul 2023 16:07:44 +0800 Message-ID: <20230721080751.2012318-4-wenst@chromium.org> X-Mailer: git-send-email 2.41.0.487.g6d72f3e995-goog In-Reply-To: <20230721080751.2012318-1-wenst@chromium.org> References: <20230721080751.2012318-1-wenst@chromium.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772018158940369227 X-GMAIL-MSGID: 1772018158940369227 After syncing the enable status of VCN33_WIFI to VCN33_BT, the driver will disable VCN33_WIFI. If it fails it will error out with a message. However the error message incorrectly refers to VCN33_BT. Fix the error message so that it correctly refers to VCN33_WIFI. Suggested-by: Fei Shao Fixes: 65bae54e08c1 ("regulator: mt6358: Merge VCN33_* regulators") Signed-off-by: Chen-Yu Tsai --- drivers/regulator/mt6358-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/mt6358-regulator.c b/drivers/regulator/mt6358-regulator.c index da6b40f947c4..b9cda2210c33 100644 --- a/drivers/regulator/mt6358-regulator.c +++ b/drivers/regulator/mt6358-regulator.c @@ -661,7 +661,7 @@ static int mt6358_sync_vcn33_setting(struct device *dev) /* Disable VCN33_WIFI */ ret = regmap_update_bits(mt6397->regmap, MT6358_LDO_VCN33_CON0_1, BIT(0), 0); if (ret) { - dev_err(dev, "Failed to disable VCN33_BT\n"); + dev_err(dev, "Failed to disable VCN33_WIFI\n"); return ret; }