From patchwork Thu Jul 20 11:53:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 122969 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp2872526vqt; Wed, 19 Jul 2023 21:14:13 -0700 (PDT) X-Google-Smtp-Source: APBJJlEyihYlVK88z0/FELloyLjlhkDCefhhcoEM9hCE1HXteI0DnMQEVOULG0LiLWlzzdVKHf5G X-Received: by 2002:a17:906:11a:b0:98d:4ae:8db9 with SMTP id 26-20020a170906011a00b0098d04ae8db9mr4252947eje.19.1689826453110; Wed, 19 Jul 2023 21:14:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689826453; cv=none; d=google.com; s=arc-20160816; b=XiIcZbGBh1/xS1yLwJRskIu3XeE2lb7M3rNBkeas6SDFyo7BRtgYLghB4PS2fqEuyN rBV4f7Zg9Mn6L1QX0VLCODhrZ98ZMIvSitkxBRZIt1ZzWk1/SsVwUQQsY4vxdZM9QoJZ HMeqnwGnnEraNnwhCfWgZ9CpMhkn8lDpS9v9aNxm4wafhlpjuTZg6PqB9gYKQwOQJ7pa VlUcsNBgxgkIFivWCN6xS5dfgnLIShPVx74msaM+mF/SUwzNAPD8nkA3SsP/7r0Yljqg axaAp7UASyBfXI1fgXxxkWRDrEdIgMMyQS+ftQpgyH10EnAY+OqgL4GhnGRcbNcGOgqa 3g3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=2OaR1HEq5K6X+gQotTWPsxBi3ZkT+prDMGdYBql2c6M=; fh=Gzi1aFpH4bsuJxl33dRilzaRcjMW8JVkCVkQbG3Bsew=; b=S0Jm1io2C+MJI2fsd3iyjqqrod8nHVN+X+Om526v7lu0lxS7WCcV/N6sFrwNt4ypJ/ VtiyS/e5pmWJdY4MgLzyEm3f2P9XK8sTxaNi3L/CrBBD/U74tJkRiw6VNI9R+o5S/jyG o5tgtQQiRA8568Va8cnRt1uiW2Iar+ypYzlXLpzoggB1yZiScS1q+kM7SPjeAS4PlX/I LGp+FRa14on47x04KruNJWlyy2YLmNRwB0TLSt5wtmx0tPeCt1vHasHBeUewalxZVy77 bEX/roIpChDuQf8BLdQad7zTTBgZ6boOFCUQCiW2lDCb85COm2buhJLYH1MqeohXS+rr fTIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qq17-20020a17090720d100b0098df03ffa69si70385ejb.421.2023.07.19.21.13.50; Wed, 19 Jul 2023 21:14:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229797AbjGTDx1 (ORCPT + 99 others); Wed, 19 Jul 2023 23:53:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229550AbjGTDxX (ORCPT ); Wed, 19 Jul 2023 23:53:23 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39B2E1FDC for ; Wed, 19 Jul 2023 20:53:22 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4R5zLQ6vdzz4f400C for ; Thu, 20 Jul 2023 11:53:18 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP2 (Coremail) with SMTP id Syh0CgC3q+mtr7hk4qk0OQ--.49914S4; Thu, 20 Jul 2023 11:53:19 +0800 (CST) From: Kemeng Shi To: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: shikemeng@huaweicloud.com Subject: [PATCH 1/2] mm/compaction: correct comment of candidate pfn in fast_isolate_freepages Date: Thu, 20 Jul 2023 19:53:50 +0800 Message-Id: <20230720115351.2039431-3-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230720115351.2039431-1-shikemeng@huaweicloud.com> References: <20230720115351.2039431-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: Syh0CgC3q+mtr7hk4qk0OQ--.49914S4 X-Coremail-Antispam: 1UD129KBjvdXoWruFyxZF4fAr1xWryruw4rKrg_yoW3Jwc_JF 12kr1Yy3WYvFyxZFnIka1Sya4UKa95Zr1Igw4rW3yjka9YqFs5WF1DZr1fXanIqa9FgFnx W3ykAF1qgF1akjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb6AFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M28IrcIa0xkI8V A2jI8067AKxVWUXwA2048vs2IY020Ec7CjxVAFwI0_JFI_Gr1l8cAvFVAK0II2c7xJM28C jxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI 8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E 87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64 kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm 72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYx C7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_ Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x 0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8 JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIx AIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7sRET5lUUUUUU= = X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771911463256145810 X-GMAIL-MSGID: 1771911463256145810 If no preferred one was not found, we will use candidate page with maximum pfn > min_pfn which is saved in high_pfn. Correct "minimum" to "maximum candidate" in comment. Signed-off-by: Kemeng Shi --- mm/compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/compaction.c b/mm/compaction.c index eb1d3d9a422c..c0d8d08fc163 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1526,7 +1526,7 @@ static void fast_isolate_freepages(struct compact_control *cc) break; } - /* Use a minimum pfn if a preferred one was not found */ + /* Use a maximum candidate pfn if a preferred one was not found */ if (!page && high_pfn) { page = pfn_to_page(high_pfn); From patchwork Thu Jul 20 11:53:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 122970 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp2872863vqt; Wed, 19 Jul 2023 21:15:16 -0700 (PDT) X-Google-Smtp-Source: APBJJlGhVI/rGvO0GFeLDqAgkkv953+/8xV47ATM38LGMtLo/Jth05uoxuEo7TwFUmO5WSJ1Btmw X-Received: by 2002:a17:907:c004:b0:98e:37fe:691b with SMTP id ss4-20020a170907c00400b0098e37fe691bmr4728662ejc.34.1689826515954; Wed, 19 Jul 2023 21:15:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689826515; cv=none; d=google.com; s=arc-20160816; b=aTgDcDrlqT4vpPD0zXadLhcmV1LF9DNhD8IiokuXRQpHYHfVekveT7A0v+MDNc4Jzn nxXbuvtS5U8PQeG4cpRohkL7EXRhiQB4qPBH9wFTftS2aVwUx3FiWfnCi4PtbPbX/WZ0 /6NkN6WozdYwsrSC/Sy9Sp1fH+1w7vdIMSpBonKiaFveK58xqZB+kgRNalcSg2fquKmg BsEL/VSqp9QMCSIXjopuDs2PguvaTPGF+qruI0X0KunGlBVrDA1JBuXcn19n6KL30bul w98N2DZVLeyNT1lG8TPth58EX0w/lNq2AChC2ARyN3L4ce9aM0YWzU9+ObRrPdxdI5TF we+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=WVMmoiJzELriBw3CsenVp/obquKL0A8EdlDn3IZr+M0=; fh=Gzi1aFpH4bsuJxl33dRilzaRcjMW8JVkCVkQbG3Bsew=; b=T+nD28eo7b7QMA1VOm8dk/9FhhCDRxfzIGmB2SUftpEq+rzDkxtS3Y68/cshWUjI7U BiLa+g8D17+sbaaEdyzIVNmnmf8DpXBlxZ01S1v+3cWU9sjbd0Yk23D0QSEOrI3A93vm 7vkIIZzeVv/O7tOG7y31oifekjzjdAtOms/J58O0uKg2bx1PS80cJGRVkJkjFT3IqNPq z0CsTfmfX8egwPijGw2PIw+QELyDLZ58lvtVoTC7Uc/mvTFS/zF9TZyK+/4KNWDS/4OG 8iu0Q2+KwwNV+pDIxp21X/oKWIseK2X62n9lMP6VufCSZu2glE60Alutp4GN3S9qDmxE elDQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f7-20020a170906824700b00991cbb3d4a6si83560ejx.115.2023.07.19.21.14.52; Wed, 19 Jul 2023 21:15:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229960AbjGTDxe (ORCPT + 99 others); Wed, 19 Jul 2023 23:53:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229592AbjGTDxY (ORCPT ); Wed, 19 Jul 2023 23:53:24 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AF491FF9 for ; Wed, 19 Jul 2023 20:53:22 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4R5zLQ6spsz4f3pJg for ; Thu, 20 Jul 2023 11:53:18 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP2 (Coremail) with SMTP id Syh0CgC3q+mtr7hk4qk0OQ--.49914S5; Thu, 20 Jul 2023 11:53:19 +0800 (CST) From: Kemeng Shi To: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: shikemeng@huaweicloud.com Subject: [PATCH 2/2] mm/compaction: avoid unneeded pageblock_end_pfn when no_set_skip_hint is set Date: Thu, 20 Jul 2023 19:53:51 +0800 Message-Id: <20230720115351.2039431-4-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230720115351.2039431-1-shikemeng@huaweicloud.com> References: <20230720115351.2039431-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: Syh0CgC3q+mtr7hk4qk0OQ--.49914S5 X-Coremail-Antispam: 1UD129KBjvdXoWruw4kWFykZFy7Wr4rCr4xCrg_yoWfJrgEqw 48trs0ywn0yF1vvrsrZw4ayrWjgFWDAF17K3WktrW2yF92y3Wvvw1DZw13urnxXa9rWwnx Ww1kZF1DGFya9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbqAYFVCjjxCrM7AC8VAFwI0_Xr0_Wr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r1rM28IrcIa0xkI8VCY1x0267AKxVW8JVW5JwA2ocxC64kI II0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7 xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2 z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4 xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v2 6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6I AqYI8I648v4I1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAq x4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r 1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF 7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxV WUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjTR QSdDUUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771911528663730375 X-GMAIL-MSGID: 1771911528663730375 Move pageblock_end_pfn after no_set_skip_hint check to avoid unneeded pageblock_end_pfn if no_set_skip_hint is set. Signed-off-by: Kemeng Shi Reviewed-by: Baolin Wang --- mm/compaction.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index c0d8d08fc163..9b7a0a69e19f 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -458,12 +458,12 @@ static void update_cached_migrate(struct compact_control *cc, unsigned long pfn) { struct zone *zone = cc->zone; - pfn = pageblock_end_pfn(pfn); - /* Set for isolation rather than compaction */ if (cc->no_set_skip_hint) return; + pfn = pageblock_end_pfn(pfn); + if (pfn > zone->compact_cached_migrate_pfn[0]) zone->compact_cached_migrate_pfn[0] = pfn; if (cc->mode != MIGRATE_ASYNC &&