From patchwork Wed Jul 19 19:20:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Polacek X-Patchwork-Id: 122769 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp2653246vqt; Wed, 19 Jul 2023 12:21:55 -0700 (PDT) X-Google-Smtp-Source: APBJJlGMDbIX4RLOEorypkzCkaUJLll+A/BI4QBS4RJOFNyiTmr0+L+dupZcQM0hhJrbAJdNmiUV X-Received: by 2002:a2e:3c10:0:b0:2b6:d8cf:2f44 with SMTP id j16-20020a2e3c10000000b002b6d8cf2f44mr648713lja.13.1689794514988; Wed, 19 Jul 2023 12:21:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689794514; cv=none; d=google.com; s=arc-20160816; b=C1n3HfCrVXuUAi5vBzPwL6ir7ZZg+assi8nuVKGoBuo5I8cXJGunF+qUxTS4puwWR4 RV5shDZtIHeQKJY0uUhIUam39359twkPxn72x8b4rIRSE57yRkXX0yBr/zE/ZYsgggNN VJYb23bunvDCMEkTm1E2fRv9W2tnWJ1ANrBsax0Owy4EsOVo7BqnpJ/JbNqoCKAQDwfp KKDV/MBEA6cw9Y2e+jnGPM7vGPtVk63JwPOH3ZrBfdqn9oGPDXcBL9nEHTOiitdOAz4G tn7cNUatEg4LLnm5//3pP1n+qGiLwKJ1VkGYdYOi4Y9bUc29htnIrMZp28+6nrJ8dB8s 4hxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=q4cm+V7AjhtR4ZMvNi29+esmvGrzPqd9uIldFvl6UiM=; fh=kNmS2mlzpUT76AmBO0Fe4g4eh3Wmp3HQAPt13Lug46g=; b=xGoWgg7z0If3aI7RhEcnZyyxqzA/NUv1deFmdUGhXUacwedUpVDPYl2R6rcvFoNRo9 RxS0MpsL/dVmnWUQ8Ut3eTlfDfGnnSD3EagvJRTXtloay9rhnTniZpkkx7h7C/PCtPEB qCft2rCa33VWlclxoeK1rFIIB81rgeLeb30d4rDn+E+SOv4YxkNE26XcUAY3BAwU9UtZ 1jAlx6SjSmvgGSKVq9IVDrLBkn6qd3Es2yXohsQojrF8bgKBqIE8/w4DCd/sJxOf4BTx W5ia85HzPJhzz0+24mRfPBBAe7lcasIwV12Qhuuzca4O3Fee8pRAdMkMvAYOzugnMEBh GxWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="Sc/NL3WS"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id ec9-20020a170906b6c900b00991f1e4b03dsi3220581ejb.406.2023.07.19.12.21.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jul 2023 12:21:54 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="Sc/NL3WS"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A1B0D3857001 for ; Wed, 19 Jul 2023 19:21:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A1B0D3857001 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1689794503; bh=q4cm+V7AjhtR4ZMvNi29+esmvGrzPqd9uIldFvl6UiM=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=Sc/NL3WSSd/zctaSb9mz58wF126DvdCBye+gn0+ll+VzO7QmNB7y465LYqDtV+gYb SwOxSuUdyg1mfsZYa3XS2swooNRW+ElThRMhh2F3EkLbMUYywriB7sSZwmBshNrofZ oRk1DALJwnI8mYVBPUnRdlFF4iAw+L9XT4RUTdcw= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D30CF3858C33 for ; Wed, 19 Jul 2023 19:20:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D30CF3858C33 Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-252-sqOxklmGPLmGX_O2cV49Vw-1; Wed, 19 Jul 2023 15:20:56 -0400 X-MC-Unique: sqOxklmGPLmGX_O2cV49Vw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E69CF28237CB for ; Wed, 19 Jul 2023 19:20:55 +0000 (UTC) Received: from pdp-11.lan (unknown [10.22.9.157]) by smtp.corp.redhat.com (Postfix) with ESMTP id BF8B31454142; Wed, 19 Jul 2023 19:20:55 +0000 (UTC) To: GCC Patches , Jason Merrill Cc: Patrick Palka Subject: [PATCH] c++: -Wmissing-field-initializers and empty class [PR110064] Date: Wed, 19 Jul 2023 15:20:47 -0400 Message-ID: <20230719192047.449259-1-polacek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Marek Polacek via Gcc-patches From: Marek Polacek Reply-To: Marek Polacek Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771877973783232409 X-GMAIL-MSGID: 1771877973783232409 Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? -- >8 -- Let's suppress -Wmissing-field-initializers for empty classes. Here I don't think I need the usual COMPLETE_TYPE_P/dependent_type_p checks. PR c++/110064 gcc/cp/ChangeLog: * typeck2.cc (process_init_constructor_record): Don't emit -Wmissing-field-initializers for empty classes. gcc/testsuite/ChangeLog: * g++.dg/warn/Wmissing-field-initializers-3.C: New test. --- gcc/cp/typeck2.cc | 3 +- .../warn/Wmissing-field-initializers-3.C | 48 +++++++++++++++++++ 2 files changed, 50 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/g++.dg/warn/Wmissing-field-initializers-3.C base-commit: 2971ff7b1d564ac04b537d907c70e6093af70832 diff --git a/gcc/cp/typeck2.cc b/gcc/cp/typeck2.cc index 1c204c8612b..582a73bb053 100644 --- a/gcc/cp/typeck2.cc +++ b/gcc/cp/typeck2.cc @@ -1874,7 +1874,8 @@ process_init_constructor_record (tree type, tree init, int nested, int flags, to zero. */ if ((complain & tf_warning) && !cp_unevaluated_operand - && !EMPTY_CONSTRUCTOR_P (init)) + && !EMPTY_CONSTRUCTOR_P (init) + && !is_really_empty_class (fldtype, /*ignore_vptr*/false)) warning (OPT_Wmissing_field_initializers, "missing initializer for member %qD", field); diff --git a/gcc/testsuite/g++.dg/warn/Wmissing-field-initializers-3.C b/gcc/testsuite/g++.dg/warn/Wmissing-field-initializers-3.C new file mode 100644 index 00000000000..a8d75b92bd1 --- /dev/null +++ b/gcc/testsuite/g++.dg/warn/Wmissing-field-initializers-3.C @@ -0,0 +1,48 @@ +// PR c++/110064 +// { dg-do compile { target c++17 } } +// { dg-options "-Wmissing-field-initializers" } + +struct B { }; +struct D : B { + int x; + int y; +}; + +struct E { + int x; + int y; + B z; +}; + +template struct X { }; + +template +struct F { + int i; + int j; + X x; +}; + +int +main () +{ + D d = {.x=1, .y=2}; // { dg-bogus "missing" } + (void)d; + E e = {.x=1, .y=2}; // { dg-bogus "missing" } + (void)e; + F f = {.i=1, .j=2 }; // { dg-bogus "missing" } + (void)f; +} + +template +void fn () +{ + F f = {.i=1, .j=2 }; // { dg-bogus "missing" } + (void)f; +} + +void +g () +{ + fn (); +}