From patchwork Wed Jul 19 15:23:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 122693 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp2524062vqt; Wed, 19 Jul 2023 08:39:11 -0700 (PDT) X-Google-Smtp-Source: APBJJlENX7eCl/+UB5IPpcOkvUulQ/68aWst153oui8nXC7bSQrZ2/UJa8zkUN23Yqw/th5LrwKQ X-Received: by 2002:a05:6a20:914e:b0:133:902:29b with SMTP id x14-20020a056a20914e00b001330902029bmr21673304pzc.13.1689781151580; Wed, 19 Jul 2023 08:39:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689781151; cv=none; d=google.com; s=arc-20160816; b=OQH1vASJW94Y+VXx2BwN/2LPtA9IqZuN8kAw5pk7OP16MXor2T36yuq1/yrcAGfni8 S2fKVNKBqpWBp0/TKoQh4w5Cxo5KgpeXtgGyVu1oXrqNgLCApLx43eR4XxTD8lPkuuiB KGu1b3qpNIiAUPYPyNk0LKfKn/dco2Eoh7ldP+K/HtZBMbgylixpX5b7Ln6pAoTDSUcX /JdQ4STT2wz7OKmaGcmYwi7fg1aRnz0Hf58/nc7JSdRn76RkKDLuD+UnuYZsWqSU7L8g wVGE3QvdEvMqMsWI/zR62xwKCQYXJfmwrG9sfTIH5JIbPhQcIvqeaL0Wq2Des0JKQvhw LIbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Fypsv5e7WPaytJEiBv1U9t8CRt0kSNLLiI9i0lFiSCE=; fh=B9Grum8er3YGN/ANly65KHXDMyNNklVBX7WL6Lcgx/M=; b=mQ6nGFiKszQsHDh+IUXTHSUKY+QH/+A0V0VLLLraVviefdAfdyeOPP81svtTAjiPiH jVtdTu0geQuV7F9PtvyzWZiGfhY5e8UumMsZzKc7dLZzsqkuEMtzHYH9qMndpoXdvc6Z T/fmbKb7I62DhNIOv13bYvg1gul+ycrub8O7shSkY/L3JL7Zddyl6/OB7BVEKv+/3qIo 9l2a+sKjsscb8hVowt4OT+S9URM5kESRycMxxoNVzVWW5/pHiiMekBZd9gE6O5XNZMqh 9hk74cRHmmiUwuh0V0RhWN4slz3i134raRUwmR53Hk/oC9NSCpOPGRZ9Rw4BzAyoQa9p 3HgQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 2-20020a631842000000b005572d25a921si3609410pgy.419.2023.07.19.08.38.57; Wed, 19 Jul 2023 08:39:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231723AbjGSPYI (ORCPT + 99 others); Wed, 19 Jul 2023 11:24:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231754AbjGSPXy (ORCPT ); Wed, 19 Jul 2023 11:23:54 -0400 Received: from baptiste.telenet-ops.be (baptiste.telenet-ops.be [IPv6:2a02:1800:120:4::f00:13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FC6412F for ; Wed, 19 Jul 2023 08:23:50 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:51f7:4083:c317:cdf]) by baptiste.telenet-ops.be with bizsmtp id P3Pg2A0062xuRWb013PgBF; Wed, 19 Jul 2023 17:23:49 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qM91W-001tXy-4l; Wed, 19 Jul 2023 17:23:40 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qM91g-001Bji-55; Wed, 19 Jul 2023 17:23:40 +0200 From: Geert Uytterhoeven To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jonathan Corbet , Laurent Pinchart , Kieran Bingham , Jyri Sarha , Tomi Valkeinen , =?utf-8?b?VmlsbGUgU3ly?= =?utf-8?b?asOkbMOk?= Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Javier Martinez Canillas , Laurent Pinchart Subject: [PATCH v3 1/4] drm/todo: Add atomic modesetting references Date: Wed, 19 Jul 2023 17:23:34 +0200 Message-Id: <6809d0fda0716892cbccf0ee272481032251026d.1689779916.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771863960929348015 X-GMAIL-MSGID: 1771863960929348015 The section about converting existing KMS drivers to atomic modesetting mentions the existence of a conversion guide, but does not reference it. While the guide is old and rusty, it still contains useful information, so add a link to it. Also link to the LWN.net articles that give an overview about the atomic mode setting design. While at it, remove the reference to unconverted virtual HW drivers, as they've been converted. Signed-off-by: Geert Uytterhoeven Reviewed-by: Javier Martinez Canillas Reviewed-by: Laurent Pinchart --- v3: - No changes, v2: - Add Reviewed-by, - Drop double space after full stop, - Use footnotes for references, - Remore reference to unconverted virtual HW drivers. --- Documentation/gpu/todo.rst | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index b05b32c12975559b..b93059e384128904 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -49,14 +49,18 @@ converted over. Modern compositors like Wayland or Surfaceflinger on Android really want an atomic modeset interface, so this is all about the bright future. -There is a conversion guide for atomic and all you need is a GPU for a -non-converted driver (again virtual HW drivers for KVM are still all -suitable). +There is a conversion guide for atomic [1]_ and all you need is a GPU for a +non-converted driver. The "Atomic mode setting design overview" series [2]_ +[3]_ at LWN.net can also be helpful. As part of this drivers also need to convert to universal plane (which means exposing primary & cursor as proper plane objects). But that's much easier to do by directly using the new atomic helper driver callbacks. + .. [1] https://blog.ffwll.ch/2014/11/atomic-modeset-support-for-kms-drivers.html + .. [2] https://lwn.net/Articles/653071/ + .. [3] https://lwn.net/Articles/653466/ + Contact: Daniel Vetter, respective driver maintainers Level: Advanced From patchwork Wed Jul 19 15:23:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 122684 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp2516308vqt; Wed, 19 Jul 2023 08:26:53 -0700 (PDT) X-Google-Smtp-Source: APBJJlGG12op13gk9rDPYkZ+QalolReVNvGZYDRhEBjtaIyGF45fen3O2UcR5zZFRi2DMKZ1fNM+ X-Received: by 2002:a17:902:e812:b0:1b8:3936:7b64 with SMTP id u18-20020a170902e81200b001b839367b64mr3666011plg.1.1689780413467; Wed, 19 Jul 2023 08:26:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689780413; cv=none; d=google.com; s=arc-20160816; b=TqyyPnE4MI3W5Ni+L/af5hKZue8iljE7/RBBjHKvYF2R9HTAFVqTK5tPjwejRHR+l1 wFEQcFogyV58JcZ4qYs0ng/REtMJ4lmYqUCkpshjY13NJUv9WaAMyVAxuSRRb4QhyKhe 6Wy8NYj543LH3SMVj8ep2HQ0zdFmZIePA4iYvvcpLoOrh4RK1W9WadjiUrWu7NN2zcAu LoL4AtmoXYF/ZSRExhqIHWfKKxHvOaYC5HefZBAfgNlwECFTfmRKphQIzmbeyoLx4uPs WwwGtZp9aAPGCc7Nk67Fju2kAFgbmsEBLzDTWOztw+JAhaXEmomoR5H+MhVetKzgYAKu TIAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=kxdpCRQ3AlbtXAik2Vxmxzb6THFKiNP4moBlr24L/Bk=; fh=gpg5ZK7FlLyqDLYY0f6auQmv7Nbp0xxHOCgKJ8Z5MuE=; b=UwLlL/n2GC79p11pyFo6rKHMxQWko4zbGYA0bseU9rlfRIFO3inVcm+y7gAA401Fux 6PBcqvu3Dj1TrmNBpTDY0x+nHx6qkBsRPRs1JGnmgc5vLtz2LKDkVYgTT8E3J2iYmttN Oig0FRauqWakhF8mxCc7U1bQNniPNlLIKm6hfpqmW4qGT9wfTnOJngyqxndNvAs81Lci y8usY2A1Ayu5t2aATFOECq9kuNSNqQ75zvV680uXn3th0B/P3/WFqkO23mtdqty8P0YR qQntAF55cHqiBRa3VLV/BkIRQHF7JIjXN5fPtIWFXrpG/Id8ubMM+PQqmnRGB/DWN7ij HiRQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p18-20020a170902ebd200b001b3f9cedbb7si3646032plg.398.2023.07.19.08.26.40; Wed, 19 Jul 2023 08:26:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231783AbjGSPYC (ORCPT + 99 others); Wed, 19 Jul 2023 11:24:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231735AbjGSPXv (ORCPT ); Wed, 19 Jul 2023 11:23:51 -0400 Received: from albert.telenet-ops.be (albert.telenet-ops.be [IPv6:2a02:1800:110:4::f00:1a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07DD4E60 for ; Wed, 19 Jul 2023 08:23:48 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:51f7:4083:c317:cdf]) by albert.telenet-ops.be with bizsmtp id P3Pg2A00E2xuRWb063Pg27; Wed, 19 Jul 2023 17:23:47 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qM91W-001tY0-5d; Wed, 19 Jul 2023 17:23:40 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qM91g-001Bjl-60; Wed, 19 Jul 2023 17:23:40 +0200 From: Geert Uytterhoeven To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jonathan Corbet , Laurent Pinchart , Kieran Bingham , Jyri Sarha , Tomi Valkeinen , =?utf-8?b?VmlsbGUgU3ly?= =?utf-8?b?asOkbMOk?= Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH v3 2/4] drm/todo: Convert list of fbconv links to footnotes Date: Wed, 19 Jul 2023 17:23:35 +0200 Message-Id: <0761f98d3b6f8df9eea977eae063e35b450fda9e.1689779916.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771863187205826925 X-GMAIL-MSGID: 1771863187205826925 Convert the references to fbconv links to footnotes, so they can be navigated. Signed-off-by: Geert Uytterhoeven Acked-by: Javier Martinez Canillas --- v3: - Make main text read correctly when ignoring the footnotes, v2: - New. --- Documentation/gpu/todo.rst | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index b93059e384128904..f2a4f6f90c54eefe 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -756,16 +756,16 @@ existing hardware. The new driver's call-back functions are filled from existing fbdev code. More complex fbdev drivers can be refactored step-by-step into a DRM -driver with the help of the DRM fbconv helpers. [1] These helpers provide +driver with the help of the DRM fbconv helpers [4]_. These helpers provide the transition layer between the DRM core infrastructure and the fbdev driver interface. Create a new DRM driver on top of the fbconv helpers, copy over the fbdev driver, and hook it up to the DRM code. Examples for -several fbdev drivers are available at [1] and a tutorial of this process -available at [2]. The result is a primitive DRM driver that can run X11 -and Weston. +several fbdev drivers are available in Thomas Zimmermann's fbconv tree +[4]_, as well as a tutorial of this process [5]_. The result is a primitive +DRM driver that can run X11 and Weston. - - [1] https://gitlab.freedesktop.org/tzimmermann/linux/tree/fbconv - - [2] https://gitlab.freedesktop.org/tzimmermann/linux/blob/fbconv/drivers/gpu/drm/drm_fbconv_helper.c + .. [4] https://gitlab.freedesktop.org/tzimmermann/linux/tree/fbconv + .. [5] https://gitlab.freedesktop.org/tzimmermann/linux/blob/fbconv/drivers/gpu/drm/drm_fbconv_helper.c Contact: Thomas Zimmermann From patchwork Wed Jul 19 15:23:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 122697 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp2530827vqt; Wed, 19 Jul 2023 08:51:17 -0700 (PDT) X-Google-Smtp-Source: APBJJlG6TL6tAUZKhhtPwiqcdgTIB5dLKb1GZIhNYXF1IKuZMvd4HbALOucKlZoFjoFycAVm3heL X-Received: by 2002:a17:907:a08:b0:973:cc48:f19c with SMTP id bb8-20020a1709070a0800b00973cc48f19cmr2847661ejc.56.1689781877366; Wed, 19 Jul 2023 08:51:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689781877; cv=none; d=google.com; s=arc-20160816; b=a0ejbcrzvl/mZDdDHqf74j549yzuwAVjjGCAjf6t8VU4t2qnTmkft37SqNpJD94IOU P+8LBZltYW/djLW09NPwkjBCg7eATHRcF0y/RiObsLUNpViumF8PfgsAp8FrSq8edJuj +4WWXzUkWjd2H6vz+3LBG+zGZ5kRfbAJslkCUotH++T0Hk4pSkWBNIE6vy5B1OR9Bnr/ JZW3il02rRIJRap9L4sHGJYPEmarxCdRpL9HhJur1HatR8i/HypA8P5bb6u84VpuuS9P ttF025t7x3sn1fj5UcIGDptDlc44ZB2GTcNtCwA5dnybvx854+Kv03G4O3GWPeF2U4me FhPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=jAl2DgNoRCE/4Hr8lIIqV3D6tRjIvqaXB2goIwg0LQY=; fh=/hP2kfddezKIGYZI83W+FIStOWdwYZPtudEasjPyKJ8=; b=G10QxGRJaNIRX66CaACMQOOa/1fFQ/xuAQnCgG4z8Zz83w3cBLz9ZGuVd76i5fRkOo RqHHvcFT9bKUUGhPfnveJZaKi4jxietma0+ZkLQ77RZhPu+JzNnEM9j/01a8D9dM17R8 6OmOY7o4aDJ7SzGM6MSsPIrzh6CtSC3YYga88sAc5F3HeUT6rt/KANtAHfAzZAWeCZv/ Q/GnC2reZ+gqsXvDb4owHcASyhlOeTxU0IEaqkFbvUhLN5VZ49yd+gpNjsv0otAZ5Uos KZNDcvIOXUdxcc8RDbvJbn+8XL7DodramBggQ4KWP2/WHS/JkfungblIXpxGkp9+snDX 3pMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z24-20020a17090665d800b009935d9765fasi2774089ejn.1013.2023.07.19.08.50.43; Wed, 19 Jul 2023 08:51:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231825AbjGSPYL (ORCPT + 99 others); Wed, 19 Jul 2023 11:24:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231777AbjGSPXz (ORCPT ); Wed, 19 Jul 2023 11:23:55 -0400 Received: from michel.telenet-ops.be (michel.telenet-ops.be [IPv6:2a02:1800:110:4::f00:18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E544ECC for ; Wed, 19 Jul 2023 08:23:51 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:51f7:4083:c317:cdf]) by michel.telenet-ops.be with bizsmtp id P3Pg2A0082xuRWb063Pgqa; Wed, 19 Jul 2023 17:23:50 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qM91W-001tY8-6V; Wed, 19 Jul 2023 17:23:40 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qM91g-001Bjq-75; Wed, 19 Jul 2023 17:23:40 +0200 From: Geert Uytterhoeven To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jonathan Corbet , Laurent Pinchart , Kieran Bingham , Jyri Sarha , Tomi Valkeinen , =?utf-8?b?VmlsbGUgU3ly?= =?utf-8?b?asOkbMOk?= Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Laurent Pinchart Subject: [PATCH v3 3/4] drm: Remove references to removed transitional helpers Date: Wed, 19 Jul 2023 17:23:36 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771864722134227773 X-GMAIL-MSGID: 1771864722134227773 The transitional helpers were removed a long time ago, but some references stuck. Remove them. Fixes: 21ebe615c16994f3 ("drm: Remove transitional helpers") Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart --- v3: - Add Reviewed-by, v2: - Drop "first part" in drivers/gpu/drm/drm_plane_helper.c. --- drivers/gpu/drm/drm_plane_helper.c | 12 +----- include/drm/drm_crtc.h | 5 --- include/drm/drm_modeset_helper_vtables.h | 48 +++++++++++------------- 3 files changed, 23 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/drm_plane_helper.c b/drivers/gpu/drm/drm_plane_helper.c index c91e454eba097942..5e95089676ff81ed 100644 --- a/drivers/gpu/drm/drm_plane_helper.c +++ b/drivers/gpu/drm/drm_plane_helper.c @@ -40,8 +40,8 @@ /** * DOC: overview * - * This helper library has two parts. The first part has support to implement - * primary plane support on top of the normal CRTC configuration interface. + * This helper library contains helpers to implement primary plane support on + * top of the normal CRTC configuration interface. * Since the legacy &drm_mode_config_funcs.set_config interface ties the primary * plane together with the CRTC state this does not allow userspace to disable * the primary plane itself. The default primary plane only expose XRBG8888 and @@ -51,14 +51,6 @@ * planes, and newly merged drivers must not rely upon these transitional * helpers. * - * The second part also implements transitional helpers which allow drivers to - * gradually switch to the atomic helper infrastructure for plane updates. Once - * that switch is complete drivers shouldn't use these any longer, instead using - * the proper legacy implementations for update and disable plane hooks provided - * by the atomic helpers. - * - * Again drivers are strongly urged to switch to the new interfaces. - * * The plane helpers share the function table structures with other helpers, * specifically also the atomic helpers. See &struct drm_plane_helper_funcs for * the details. diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 8e1cbc75143ef216..8b48a1974da3143c 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -77,11 +77,6 @@ struct drm_plane_helper_funcs; * intended to indicate whether a full modeset is needed, rather than strictly * describing what has changed in a commit. See also: * drm_atomic_crtc_needs_modeset() - * - * WARNING: Transitional helpers (like drm_helper_crtc_mode_set() or - * drm_helper_crtc_mode_set_base()) do not maintain many of the derived control - * state like @plane_mask so drivers not converted over to atomic helpers should - * not rely on these being accurate! */ struct drm_crtc_state { /** @crtc: backpointer to the CRTC */ diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h index 965faf082a6d1acb..e3c3ac615909474b 100644 --- a/include/drm/drm_modeset_helper_vtables.h +++ b/include/drm/drm_modeset_helper_vtables.h @@ -59,8 +59,8 @@ enum mode_set_atomic { /** * struct drm_crtc_helper_funcs - helper operations for CRTCs * - * These hooks are used by the legacy CRTC helpers, the transitional plane - * helpers and the new atomic modesetting helpers. + * These hooks are used by the legacy CRTC helpers and the new atomic + * modesetting helpers. */ struct drm_crtc_helper_funcs { /** @@ -216,9 +216,7 @@ struct drm_crtc_helper_funcs { * * This callback is used to update the display mode of a CRTC without * changing anything of the primary plane configuration. This fits the - * requirement of atomic and hence is used by the atomic helpers. It is - * also used by the transitional plane helpers to implement a - * @mode_set hook in drm_helper_crtc_mode_set(). + * requirement of atomic and hence is used by the atomic helpers. * * Note that the display pipe is completely off when this function is * called. Atomic drivers which need hardware to be running before they @@ -333,8 +331,8 @@ struct drm_crtc_helper_funcs { * all updated. Again the recommendation is to just call check helpers * until a maximal configuration is reached. * - * This callback is used by the atomic modeset helpers and by the - * transitional plane helpers, but it is optional. + * This callback is used by the atomic modeset helpers, but it is + * optional. * * NOTE: * @@ -373,8 +371,8 @@ struct drm_crtc_helper_funcs { * has picked. See drm_atomic_helper_commit_planes() for a discussion of * the tradeoffs and variants of plane commit helpers. * - * This callback is used by the atomic modeset helpers and by the - * transitional plane helpers, but it is optional. + * This callback is used by the atomic modeset helpers, but it is + * optional. */ void (*atomic_begin)(struct drm_crtc *crtc, struct drm_atomic_state *state); @@ -397,8 +395,8 @@ struct drm_crtc_helper_funcs { * has picked. See drm_atomic_helper_commit_planes() for a discussion of * the tradeoffs and variants of plane commit helpers. * - * This callback is used by the atomic modeset helpers and by the - * transitional plane helpers, but it is optional. + * This callback is used by the atomic modeset helpers, but it is + * optional. */ void (*atomic_flush)(struct drm_crtc *crtc, struct drm_atomic_state *state); @@ -507,8 +505,8 @@ static inline void drm_crtc_helper_add(struct drm_crtc *crtc, /** * struct drm_encoder_helper_funcs - helper operations for encoders * - * These hooks are used by the legacy CRTC helpers, the transitional plane - * helpers and the new atomic modesetting helpers. + * These hooks are used by the legacy CRTC helpers and the new atomic + * modesetting helpers. */ struct drm_encoder_helper_funcs { /** @@ -1185,8 +1183,7 @@ static inline void drm_connector_helper_add(struct drm_connector *connector, /** * struct drm_plane_helper_funcs - helper operations for planes * - * These functions are used by the atomic helpers and by the transitional plane - * helpers. + * These functions are used by the atomic helpers. */ struct drm_plane_helper_funcs { /** @@ -1221,9 +1218,8 @@ struct drm_plane_helper_funcs { * The helpers will call @cleanup_fb with matching arguments for every * successful call to this hook. * - * This callback is used by the atomic modeset helpers and by the - * transitional plane helpers, but it is optional. See @begin_fb_access - * for preparing per-commit resources. + * This callback is used by the atomic modeset helpers, but it is + * optional. See @begin_fb_access for preparing per-commit resources. * * RETURNS: * @@ -1240,8 +1236,8 @@ struct drm_plane_helper_funcs { * This hook is called to clean up any resources allocated for the given * framebuffer and plane configuration in @prepare_fb. * - * This callback is used by the atomic modeset helpers and by the - * transitional plane helpers, but it is optional. + * This callback is used by the atomic modeset helpers, but it is + * optional. */ void (*cleanup_fb)(struct drm_plane *plane, struct drm_plane_state *old_state); @@ -1295,8 +1291,8 @@ struct drm_plane_helper_funcs { * all updated. Again the recommendation is to just call check helpers * until a maximal configuration is reached. * - * This callback is used by the atomic modeset helpers and by the - * transitional plane helpers, but it is optional. + * This callback is used by the atomic modeset helpers, but it is + * optional. * * NOTE: * @@ -1326,8 +1322,7 @@ struct drm_plane_helper_funcs { * has picked. See drm_atomic_helper_commit_planes() for a discussion of * the tradeoffs and variants of plane commit helpers. * - * This callback is used by the atomic modeset helpers and by the - * transitional plane helpers, but it is optional. + * This callback is used by the atomic modeset helpers, but it is optional. */ void (*atomic_update)(struct drm_plane *plane, struct drm_atomic_state *state); @@ -1376,9 +1371,8 @@ struct drm_plane_helper_funcs { * has picked. See drm_atomic_helper_commit_planes() for a discussion of * the tradeoffs and variants of plane commit helpers. * - * This callback is used by the atomic modeset helpers and by the - * transitional plane helpers, but it is optional. It's intended to - * reverse the effects of @atomic_enable. + * This callback is used by the atomic modeset helpers, but it is + * optional. It's intended to reverse the effects of @atomic_enable. */ void (*atomic_disable)(struct drm_plane *plane, struct drm_atomic_state *state); From patchwork Wed Jul 19 15:23:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 122691 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp2522688vqt; Wed, 19 Jul 2023 08:36:50 -0700 (PDT) X-Google-Smtp-Source: APBJJlFVOova3XCTFRr5wRvCImFqtLaZjSKObeQNhhpoQXNx3rVcMF6ciVrqL9WpMkT9I+aIfdXm X-Received: by 2002:a17:90a:98c:b0:263:f674:490e with SMTP id 12-20020a17090a098c00b00263f674490emr3211235pjo.3.1689781010059; Wed, 19 Jul 2023 08:36:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689781010; cv=none; d=google.com; s=arc-20160816; b=ECRrFpu7uPiNVPRZKA24aNiEvINXW3emUomUdvnk65q5R7oIk7yHyH0nlZ5BfD1d/I vwKxy8HXoIokXd6Uz2LxNjx8NzssO2gjRJpc7rH6Eaqca0048dPi91Pb9Hsj102I01kp 3hI3ytPjfpgtNckhLCcanBCiRuxcHf+Noe7/1GB3HWJBAKI3C8IrNlyG7IYfm9e1Q6Tp 6euDoIg//qqSFRWgHx9XmLGdsMydJ0NQsR4mXTPkNNUikV1u6OxY/hvLAxB02yCS2tiV mLmjp65Qh7BXLAEhcPkr6Ucv0cVGkFwbpHzmJskt22lrq9/6XMThhnwCu4kyycamz2xJ +vMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=oAHrb3G0iYZ1UFwA46VJuFA3D6b8ZRRS/gQvBkamWdg=; fh=/hP2kfddezKIGYZI83W+FIStOWdwYZPtudEasjPyKJ8=; b=V6MbxVgz1mEDJTA9FHklECq/dlkU01sxtVj/cdLZ2qtIbdAT7PaE69i24v0StFGMhL JV5Z3QxD+qLbthztyfOHM//8wQbpQjdf7SsDJ36TgjVZ8hhnxiaxAigk1d9R46IeXSo+ u8O0eflpA6UPFDcVEkVI9LTVHEbOIVOjCrc5hlj51HDyV+zvS0LPxY/QVnKH34kFGd4Z EjYin/X8Nq/oT2sqUSDD/5wxMYKvWNbeZGv0K913M7A4AoyCuk2jZD0fZK2cZhx9c6Ba aZnUNM2GAWVaimjkTIbErHbhERS/2/JQUP2JAtNYbppUVEAcVyKbzWvc/sawn5F0oVhE D9ZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gb11-20020a17090b060b00b00263ffb07fa9si1515962pjb.95.2023.07.19.08.36.36; Wed, 19 Jul 2023 08:36:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231804AbjGSPYF (ORCPT + 99 others); Wed, 19 Jul 2023 11:24:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231733AbjGSPXv (ORCPT ); Wed, 19 Jul 2023 11:23:51 -0400 Received: from xavier.telenet-ops.be (xavier.telenet-ops.be [IPv6:2a02:1800:120:4::f00:14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACC2510D2 for ; Wed, 19 Jul 2023 08:23:49 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:51f7:4083:c317:cdf]) by xavier.telenet-ops.be with bizsmtp id P3Pg2A00E2xuRWb013Pgqz; Wed, 19 Jul 2023 17:23:48 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qM91W-001tYA-6y; Wed, 19 Jul 2023 17:23:40 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qM91g-001Bju-7o; Wed, 19 Jul 2023 17:23:40 +0200 From: Geert Uytterhoeven To: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jonathan Corbet , Laurent Pinchart , Kieran Bingham , Jyri Sarha , Tomi Valkeinen , =?utf-8?b?VmlsbGUgU3ly?= =?utf-8?b?asOkbMOk?= Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Laurent Pinchart Subject: [PATCH v3 4/4] drm: Fix references to drm_plane_helper_check_state() Date: Wed, 19 Jul 2023 17:23:37 +0200 Message-Id: <8bb42a92fc20e3d11e5847e7f15a47c687b73104.1689779916.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771863812641277310 X-GMAIL-MSGID: 1771863812641277310 As of commit a01cb8ba3f628293 ("drm: Move drm_plane_helper_check_state() into drm_atomic_helper.c"), drm_plane_helper_check_state() no longer exists, but is part of drm_atomic_helper_check_plane_state(). Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart --- v3: - No changes, v2: - Add Reviewed-by. --- drivers/gpu/drm/renesas/rcar-du/rcar_du_plane.c | 3 ++- drivers/gpu/drm/tidss/tidss_plane.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_plane.c b/drivers/gpu/drm/renesas/rcar-du/rcar_du_plane.c index d759e019218181ce..e445fac8e0b46c21 100644 --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_plane.c +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_plane.c @@ -600,7 +600,8 @@ int __rcar_du_plane_atomic_check(struct drm_plane *plane, if (!state->crtc) { /* * The visible field is not reset by the DRM core but only - * updated by drm_plane_helper_check_state(), set it manually. + * updated by drm_atomic_helper_check_plane_state(), set it + * manually. */ state->visible = false; *format = NULL; diff --git a/drivers/gpu/drm/tidss/tidss_plane.c b/drivers/gpu/drm/tidss/tidss_plane.c index 6bdd6e4a955ab3cc..e1c0ef0c3894c855 100644 --- a/drivers/gpu/drm/tidss/tidss_plane.c +++ b/drivers/gpu/drm/tidss/tidss_plane.c @@ -38,7 +38,8 @@ static int tidss_plane_atomic_check(struct drm_plane *plane, if (!new_plane_state->crtc) { /* * The visible field is not reset by the DRM core but only - * updated by drm_plane_helper_check_state(), set it manually. + * updated by drm_atomic_helper_check_plane_state(), set it + * manually. */ new_plane_state->visible = false; return 0;