From patchwork Wed Jul 19 13:08:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 122628 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp2453216vqt; Wed, 19 Jul 2023 06:51:14 -0700 (PDT) X-Google-Smtp-Source: APBJJlFU4BouDWwIKjrai5jIVbINsXKy0USOD1O58AJXyWdXaRdslM26SH6kb8M0pXP2RWUaVm+d X-Received: by 2002:a17:902:e5c2:b0:1b8:aee8:a21c with SMTP id u2-20020a170902e5c200b001b8aee8a21cmr2703957plf.31.1689774673651; Wed, 19 Jul 2023 06:51:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689774673; cv=none; d=google.com; s=arc-20160816; b=EwXJk5oaNKK+w0qMfHGD23BhRc4q/2mSXolAOke8YY0rCIq9H3HtpXNTqnr78Ok30h J7jODUrMv8HpxAvJd1og1hl9YPBZQFtnYB5RbW+s42YZ+AuqiioLHxzsMjtZl+4elwGc B6mpU2y+2HRQ/KBSnA281LjjjX8+F1Mmv8WbzG3XxuzTqcnc83sJuoKgCjiQtkGg+AgU thOXgJh/TGTP51jesy/Msv54ynVk9KFH/2DxEXMvb7KfCCXEthRPY200iv7PBAtjfp7p WgmspmC21jNOLSJ4LVbT+wDfMlNRP9/i12aJHZN0XVTtCQU9EH9mdoR8U/Heh1fYO2Nx z42w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=8OI8bKb2C1Ic+WA9syeLIr/xGoSN69peJU8MqCDQ2VM=; fh=JBtLc/ZE1v1HaikvtNoGwladNSbLN6ixlwjgDJF+esQ=; b=lGEyaRN1IP8FgDhSV3dwXekIO6Ss2XCy0Iqtt1D1Ruo1V6qBWG7igMCo1n2nJJXkxI JrGk2ihvTO/E2iwku7GmTXZPvbVtsNxd+YTd4rNsvFv2S4imRH29JxcEYnPMHZYSZIGl PUvk0+6IBKm5edSF55Qp83Y3weYpAmsaojabBZQ8z7QUdKJNrQ1qeamqdb9lK7EfB/8f FJqihd5WZZ9LzQ6MEJqPXqfzdJ/VhwdxD69qb2Brc3z0z/7SiFyRUNw9UJBTxD/kAK5q GY3zULr3RxooMUV2RNl2X8+8hgP+U8UySnNO/nvXpSwe+xN+7q+Z4N4whDbXCJrm0iHd kjwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AIHV9nDx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u17-20020a170903125100b001b89bab468esi3687735plh.107.2023.07.19.06.50.59; Wed, 19 Jul 2023 06:51:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AIHV9nDx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230293AbjGSNIz (ORCPT + 99 others); Wed, 19 Jul 2023 09:08:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229732AbjGSNIx (ORCPT ); Wed, 19 Jul 2023 09:08:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 433F5113 for ; Wed, 19 Jul 2023 06:08:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CE0F461638 for ; Wed, 19 Jul 2023 13:08:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1798C433C9; Wed, 19 Jul 2023 13:08:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689772132; bh=2AeP1o2C0s+VtApribmRvaqu3jF42vhryG4ijMmv2go=; h=From:To:Cc:Subject:Date:From; b=AIHV9nDxCVaxPnNI+SDmaRrWI4nURA9lMT6vJL5B4yMGXuon3wVEXexvNQyP0Yyin aXaFsGLqKuNOAVOlHldfIDydCH/LJExbaax0LwS+IZEG+JyFfRd8Zn2eh5EpT+NGZG CyHQGcuy1bpTzDQGNQAXzvA9flK4Rjyymr1poHUlV+DYhh1LBP54/Q8DMXE4Z6FRmi 8J8ChaxiPtyt4wCXRbiHX3dIj1h3+wTfPHy5uBJSKpHHP/MDtfEmn6PBszHGB1jfg4 Ns1DrHpcZMkN5oelIou64RvukNB1AZ2mTfGtGmZnlyHdFuiPiWaEx+0SwfdH6S09Fp DP07jt2vx/cyg== From: Arnd Bergmann To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Syed Saba Kareem Cc: Arnd Bergmann , Venkata Prasad Potturu , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: amd: acp: fix SND_SOC_AMD_ACP_PCI depdenencies Date: Wed, 19 Jul 2023 15:08:37 +0200 Message-Id: <20230719130846.633701-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771857167962519204 X-GMAIL-MSGID: 1771857167962519204 From: Arnd Bergmann The new PM functions require code that is part of the snd-acp-legacy-common module: x86_64-linux-ld: sound/soc/amd/acp/acp-pci.o: in function `snd_acp_resume': acp-pci.c:(.text+0x23): undefined reference to `acp_init' x86_64-linux-ld: acp-pci.c:(.text+0x58): undefined reference to `acp_enable_interrupts' x86_64-linux-ld: sound/soc/amd/acp/acp-pci.o: in function `snd_acp_suspend': acp-pci.c:(.text+0x89): undefined reference to `acp_deinit' x86_64-linux-ld: sound/soc/amd/acp/acp-pci.o: in function `acp_pci_remove': acp-pci.c:(.text+0xec): undefined reference to `acp_deinit' x86_64-linux-ld: sound/soc/amd/acp/acp-pci.o: in function `acp_pci_probe': acp-pci.c:(.text+0x26b): undefined reference to `acp_init' Select that Kconfig symbol as is done for the other frontends. Fixes: 088a40980efbc ("ASoC: amd: acp: add pm ops support for acp pci driver") Signed-off-by: Arnd Bergmann --- sound/soc/amd/acp/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/amd/acp/Kconfig b/sound/soc/amd/acp/Kconfig index 9e31b5d167908..631cdf96d6376 100644 --- a/sound/soc/amd/acp/Kconfig +++ b/sound/soc/amd/acp/Kconfig @@ -30,6 +30,7 @@ config SND_SOC_AMD_ACP_PCM config SND_SOC_AMD_ACP_PCI tristate "AMD ACP PCI Driver Support" + select SND_SOC_AMD_ACP_LEGACY_COMMON depends on X86 && PCI help This options enables generic PCI driver for ACP device.