From patchwork Wed Jul 19 11:38:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 122568 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp2373587vqt; Wed, 19 Jul 2023 04:41:50 -0700 (PDT) X-Google-Smtp-Source: APBJJlFwBKFMn90X5XVkJr/MoD7nc9J+nHIy7AesUMfxPBVQ2VbPNLh28Qgv2Pz+V8JdjQb/uvbR X-Received: by 2002:a05:6402:691:b0:51e:45b8:b0bb with SMTP id f17-20020a056402069100b0051e45b8b0bbmr2054219edy.22.1689766910786; Wed, 19 Jul 2023 04:41:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689766910; cv=none; d=google.com; s=arc-20160816; b=pkRugDV/5nAEoFTQB+ebch2wIU6v8kksBSHuzmw7Ew98cvCCRKsNVmosQXAhcCtyZZ bTkvPLaB7rM/fyINLz4JDEcgkW+XVSVhN5MR/WLXVqTdkE9pMw/Fuumtr1Vw6zjjAWep v2j0tFXR/siSlc4nzufv92rTBsI+4Y4fzH/Iu0MtmqOQAwotghE8Qb+DMIr8hVwzT+E/ AQwn4beXPbSyU+mmvGuZGLzSvk8CizPTXTlqwCHUi+loNGO8A43LJmn2Bc2pxR9B7lGD jeRgQqtudqx8Bd6Ni53sKOprZAcgPm3j7XogyxuhQCz9l5am72iEwBe1gEPrPw4fLrUZ O59Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:to :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=CGDRquJjYEA74LC1UUJwXelqfiMDrEGgvi9asiQqwWc=; fh=sC8lnOfyH6gL5FYlMbZ1VDz6qVPMj/3ViLJWKNUCUgQ=; b=kEO1shiakJc4gs0/LKpAFnqr5pTo56ADfsIWHh77hZpPGpNCaNfCktKPZ68+hfp/XC bSeQsBufmax4Dy6/G8gCPoIepGOHhj4qelTuyCWucecbixcWJ3JDNz59+QzUeypNRyi0 0nLxEH1+yBpIoD6ysshJA/CyXofNa966y1RzAkwGiXATnRRA+5eB+caSEBG0sYD4GgaX I4q1NkQyjsROt3GFcrvIfb4ms1+aaFG5ZDSApRB8NW2b19qGxYd/IHjUjtmVJGqTa4qW NzICuCFECd/Ds/qwx1XaW2l3uQw2T1Q3ixJNJmcx4pvWClLnSrC22pXTql8tgnTZIBBU woIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="Icf/KCuC"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id j4-20020a50ed04000000b0051e0eba60bdsi2954036eds.456.2023.07.19.04.41.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jul 2023 04:41:50 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="Icf/KCuC"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 646C23853D33 for ; Wed, 19 Jul 2023 11:39:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 646C23853D33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1689766783; bh=CGDRquJjYEA74LC1UUJwXelqfiMDrEGgvi9asiQqwWc=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Icf/KCuCDzQFu8MBPX8gd98yXUV6tPG7c7XHe9o8CDi0mCT8DO7ioskxU/0RS/Rxh n/XJHHMWiXG6pyZe5FnENELl5rCKu2oWNCMmn0xi0zR7yWT9mAcVBf1c5LjmYfEJJH kkGB4hPDGD4RF3JKpFv3pdInXIn3OiWivpkOEIPk= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B611D385C8B1 for ; Wed, 19 Jul 2023 11:38:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B611D385C8B1 Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-444-mSYZE6OXOtyCkUgG4ysmjQ-1; Wed, 19 Jul 2023 07:38:31 -0400 X-MC-Unique: mSYZE6OXOtyCkUgG4ysmjQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B93253C13516; Wed, 19 Jul 2023 11:38:30 +0000 (UTC) Received: from localhost (unknown [10.42.28.140]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7FCC51454C20; Wed, 19 Jul 2023 11:38:30 +0000 (UTC) To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [committed] libstdc++: Avoid warning in std::format Date: Wed, 19 Jul 2023 12:38:17 +0100 Message-ID: <20230719113829.2510208-1-jwakely@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jonathan Wakely via Gcc-patches From: Jonathan Wakely Reply-To: Jonathan Wakely Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771849028112255271 X-GMAIL-MSGID: 1771849028112255271 Tested x86_64-linux. Pushed to trunk. -- >8 -- With -Wmaybe-uninitialized -Wsystem-headers there's a warning about creating a string_view from an uninitalized array. Initializing the first element of the array avoids the warning. libstdc++-v3/ChangeLog: * include/std/format (__write_padded): Initialize first element of array to avoid a -Wmaybe-uninitialized warning. --- libstdc++-v3/include/std/format | 1 + 1 file changed, 1 insertion(+) diff --git a/libstdc++-v3/include/std/format b/libstdc++-v3/include/std/format index 9d5981e4882..9710bff3c03 100644 --- a/libstdc++-v3/include/std/format +++ b/libstdc++-v3/include/std/format @@ -610,6 +610,7 @@ namespace __format { const size_t __buflen = 0x20; _CharT __padding_chars[__buflen]; + __padding_chars[0] = _CharT(); basic_string_view<_CharT> __padding{__padding_chars, __buflen}; auto __pad = [&__padding] (size_t __n, _Out& __o) {