From patchwork Wed Jul 19 10:33:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 122562 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp2371878vqt; Wed, 19 Jul 2023 04:38:28 -0700 (PDT) X-Google-Smtp-Source: APBJJlEBQUmct/6Tl9UlP2j7p21GKEX5of/XIKorsGHkjFI9hie3dLtOSOmlf5orgLRL9f+o5KDN X-Received: by 2002:aa7:8891:0:b0:681:3ed2:b493 with SMTP id z17-20020aa78891000000b006813ed2b493mr16058709pfe.26.1689766708379; Wed, 19 Jul 2023 04:38:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689766708; cv=none; d=google.com; s=arc-20160816; b=ONzFMg0JFX+cDKUXorPGHn1EB0Ml+QA43YkZVjChNk3h3TR0W72Z0eLe5MmJjm+143 2hudT9HK0NI8henHJAW0ElVumb3tIFyVT5gFOlUkQxFkZznmw5Vp+gNmpZzmIMuuBc8r C+X6U3VL47T0nPYmfB/Qpuk/M8QmuwkIXzPekfA7ijyYv3cjsSpXGcdLTe3mjKJuIRpX 4NJjQM4IfAmCvPxItl1CJ9u9zX8R3c5AjijFiIWXwlflZ5zPaklsMhX7auhpn55gcDF5 8drqxZWfuL8xK2R0c31YeE1YhmNO/xDJmfsJFEx52XihlW6rGbM9KpczbwAjtIT3JFGJ MHnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=VXj5YGAc3yTaYjQDt+pu+QsTbsvPJHMLueGYcTvQb+0=; fh=aqkEY2RpuxXFyC0qkWRr5fbrtQUKFVEqB1qIdp6d7Ps=; b=W+39PAHmxzxYjRdu+8GxqmDbDNAEg4+bsuK0rTpOvjmTAR0ieqvCGkNe4/4hUIAsER yNzPBY4CnA9Wrhx7MQb9KO+NTXMDLWjogWrIRIc/lK22wcM6Z1Raoaap5FsoXnGFMAsK U9ngGGFe6uRZ/3eS0whcNXLazN/v8qMXrsKJNIoE+2clkWd6g32VTRIVclmuWE2eARp3 4zPWymw07YqZ+xOsZ4UrCMcga9uiHxJNLCY1JXqf1zwPsMECS7rFzJ93CSv8PUgj55gr ffSesfEdcL9WQtdywQPCLnRL3Knm9Fx83pi8nklNeQMqMUvio6lfbaUWnbZ3VJSUSagI Odyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=DjurqgxK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s124-20020a632c82000000b0055c875bed32si3456935pgs.706.2023.07.19.04.38.15; Wed, 19 Jul 2023 04:38:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=DjurqgxK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229450AbjGSKeA (ORCPT + 99 others); Wed, 19 Jul 2023 06:34:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229638AbjGSKd6 (ORCPT ); Wed, 19 Jul 2023 06:33:58 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EF7A18D; Wed, 19 Jul 2023 03:33:57 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-3fbc63c2e84so67087965e9.3; Wed, 19 Jul 2023 03:33:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689762836; x=1692354836; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VXj5YGAc3yTaYjQDt+pu+QsTbsvPJHMLueGYcTvQb+0=; b=DjurqgxKYZebo4JylN2vIh/fMENaVlf3jotRX8Jg7yXtW/SC4/fmqteKIL5pUDwRT6 qUiuO9hCCAo7SZpXqJZT6QWZq3rQCFFm3GzgMJkWYYta4tF8BK+NExIKw3RHwNbzV0m4 aimjZNFIJBteaTAmumlMqFjcDuXPnqDCrRMRFhvKB9DuPSZm5PgGuqGL88ly5WXcSGZO u2+zqv2maZfybRpyWkYBTHdEId0lrMrpeG4Hq2SMkCibTL1VcBaE/SMzkFVxZ3cmYEJB BKdiLAYb4dt6xD2czd8Gd2uBS0tjfiTZSA2u+5SupPo2nhYUOmkBVvcnvkeKjbt1wX/M T3XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689762836; x=1692354836; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VXj5YGAc3yTaYjQDt+pu+QsTbsvPJHMLueGYcTvQb+0=; b=gv29pkW9+lno6YiJNecGHrsrNNfRSqBBnkNw0C6K+8KXV/sTWj829d175nmuGHIyE8 DOpiTV9zxkJG5230nYMkZjk2nuP4pqVj8R1HhG4PaPEZBwc2k8ZDDi8ILuSjO+LKf7Sl uGNcdJj3RSn4eZsOGDtA1o7rMGcThol/qnq90FOvxFi2VcBY4XObE5lS/BU8cSJjs6iT 0pHW3JTOZS7/bkjcA+SxM4CymsIbTUCVndwqR/b8I3e9jaQYd7a+k0CCtwdhXoHV4Rne 9ifm3dN6XXyKN9HHuCj5yYrFOaxnt3aGn8Da+r890/SxChvQc/yuBHhJDk8jS2oTNBN/ jq4A== X-Gm-Message-State: ABy/qLbRS8fGIftUMZmhKqnkVFQu6SJS2FPQqdkSuXjjRYlCoElRB5W1 pZgjsbu+QygCHXUJCglq2zXP/r/7K6Q= X-Received: by 2002:a05:600c:2150:b0:3fa:8fb1:50fe with SMTP id v16-20020a05600c215000b003fa8fb150femr1749513wml.15.1689762835416; Wed, 19 Jul 2023 03:33:55 -0700 (PDT) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id g8-20020a7bc4c8000000b003fa8158135esm1377185wmk.11.2023.07.19.03.33.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jul 2023 03:33:54 -0700 (PDT) From: Colin Ian King To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] mtdblock: make warning messages ratelimited Date: Wed, 19 Jul 2023 11:33:54 +0100 Message-Id: <20230719103354.2829366-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771848815930426801 X-GMAIL-MSGID: 1771848815930426801 When exercising various dev interfaces with stress-ng the mtdblock drivers can be (ab)used to generate a lot of warning messages. Make these rate limited to reduce the kernel log from being spammed with the same messages. Signed-off-by: Colin Ian King --- drivers/mtd/mtdblock.c | 2 +- drivers/mtd/mtdblock_ro.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/mtdblock.c b/drivers/mtd/mtdblock.c index fa476fb4dffb..9751416c2a91 100644 --- a/drivers/mtd/mtdblock.c +++ b/drivers/mtd/mtdblock.c @@ -262,7 +262,7 @@ static int mtdblock_open(struct mtd_blktrans_dev *mbd) } if (mtd_type_is_nand(mbd->mtd)) - pr_warn("%s: MTD device '%s' is NAND, please consider using UBI block devices instead.\n", + pr_warn_ratelimited("%s: MTD device '%s' is NAND, please consider using UBI block devices instead.\n", mbd->tr->name, mbd->mtd->name); /* OK, it's not open. Create cache info for it */ diff --git a/drivers/mtd/mtdblock_ro.c b/drivers/mtd/mtdblock_ro.c index 66ffc9f1ead2..ef6299af60e4 100644 --- a/drivers/mtd/mtdblock_ro.c +++ b/drivers/mtd/mtdblock_ro.c @@ -49,7 +49,7 @@ static void mtdblock_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd) dev->readonly = 1; if (mtd_type_is_nand(mtd)) - pr_warn("%s: MTD device '%s' is NAND, please consider using UBI block devices instead.\n", + pr_warn_ratelimited("%s: MTD device '%s' is NAND, please consider using UBI block devices instead.\n", tr->name, mtd->name); if (add_mtd_blktrans_dev(dev))