From patchwork Fri Jul 14 12:19:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jose E. Marchesi" X-Patchwork-Id: 120445 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp2463413vqm; Fri, 14 Jul 2023 05:20:27 -0700 (PDT) X-Google-Smtp-Source: APBJJlGAyy6cFdAtUlFQxCOrLrSnYoJXHSiyFqgTgigFxiHUiQKdTBxudyBZq4gxC5BBujblPmb7 X-Received: by 2002:a17:907:d03:b0:988:8efc:54fa with SMTP id gn3-20020a1709070d0300b009888efc54famr2865455ejc.37.1689337227176; Fri, 14 Jul 2023 05:20:27 -0700 (PDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id oq24-20020a170906cc9800b0099309c64f17si9005327ejb.146.2023.07.14.05.20.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jul 2023 05:20:27 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=emDlRAmP; arc=fail (signature failed); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D53803858296 for ; Fri, 14 Jul 2023 12:20:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D53803858296 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1689337225; bh=wGG59NuzaQ3EoUwBOfWrw4EITss5RqQA3oh1sf7UgK0=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=emDlRAmPCQhe+d4cSWd0vD+boOpdPPZzLAMvukulm2wAtw64+wZhk/+GziNWaDsbR 1d9lop2VkZIlVe7zigHHab8fw97NWLCVGWlHQR6mTFqxQjlW6UFDbYdMx1S+M2joi5 9pRhK98/OzMQ/VuZ1M8nGlwgu6+lSEmr6yzOf7/g= X-Original-To: gcc-patches@sourceware.org Delivered-To: gcc-patches@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 1B4D13858CDB for ; Fri, 14 Jul 2023 12:19:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1B4D13858CDB Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36ECAfXu013323 for ; Fri, 14 Jul 2023 12:19:39 GMT Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3rtptx1d5n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 14 Jul 2023 12:19:39 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 36ECGbIQ008617 for ; Fri, 14 Jul 2023 12:19:38 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2109.outbound.protection.outlook.com [104.47.70.109]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3rtpvs26ye-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 14 Jul 2023 12:19:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B9acu3vbVLPFHmul0pJZJdZun7F4i1yjVADW4Vc6l8iABx7Z8lYqcYR2dBVqQWVg8sfl8vj2eKWaEWu5oOryZdQgfQxRprjZgajuCJtjYr4Jglmd2Nubosoxw3dsoZi9nTBEyq4QKdbqW250m45TMpc6tdiEan9lL9opaaRwQC6NfmYLEsnO+mqMiCNfanj36arjzROqOZEwkwQbPDEDfvTGmXq0Psyz6gAYLM7AHwx8n3BNbC9F908YSRn/G6pZcHFl+pP1e4DO4BCreft3DKuaRUz1iZ3PdKtmnb2/XQ2S0kNbv0//mhl8XxuPhnlX5Iqy7nMWpeFA4aoamTN3vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wGG59NuzaQ3EoUwBOfWrw4EITss5RqQA3oh1sf7UgK0=; b=i/HTQ7JgxKIXqIrb0ORTByrioRQoEfo6CuPJWLHj8kvmRKEpZgJ9ofbQsDqt0CJBbpyKV992ppPMofRTDMXY9sfyV9urvLChvXZvmvZSvEeqxVnJ1cT8owQnDYuYOyFW1s2VxCXvUZhe8vg3M7a2UrTZAB+kYFGOlN4h5NOMiktB9VNZzkXPMCCb6VkUOr2oWtm7417FZSN2MK5hY1V7OQ3l4x1ppEN/jroXe2H27aY8w2A/m1DYKQZm03bj7DFhuptdV/+tXDHtPzzqhpP5vnfDdjlHDBZ3wNBIo1bTF+ql0nvnWbcc+7ekvXm8TmrcBuqyvhllrvlEFrfXoiKH3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by CH3PR10MB6714.namprd10.prod.outlook.com (2603:10b6:610:142::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.27; Fri, 14 Jul 2023 12:19:36 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::b2d:6b7e:39d:eba8]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::b2d:6b7e:39d:eba8%6]) with mapi id 15.20.6588.027; Fri, 14 Jul 2023 12:19:35 +0000 To: gcc-patches@sourceware.org Subject: [COMMITTED] bpf: enable instruction scheduling Date: Fri, 14 Jul 2023 14:19:17 +0200 Message-ID: <87v8emptx6.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) X-ClientProxiedBy: LO4P123CA0386.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::13) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|CH3PR10MB6714:EE_ X-MS-Office365-Filtering-Correlation-Id: dfd6206f-e95a-418e-824e-08db84649607 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ze7UGsrgYBvtKo8/D3846kcLsU63hNPtlDDdG+eMcARJlB0GjrCzUOGWFUhcY37ZGx79Ui1xnJMekO7ikXbNLtxIhElI7nKOLjGtbmhmCxbeRgyr59K8Tw1yVmkH6BkWW5AR+W6qnah/DkAUVF0qalyCDEQZg1xsZSTqs3FoWkN31xUQoAe9ZLk0mVqpwu1+oZH7/aWPryk4v4N3Ucz/zBfWtAPNhulM/1lKbBCJDKUCC+YhG8ml5/cKPWzPP4afbFdwf4utslfC3Xsf/2zHWMy1XyaqvUpfIMDjrECt3GRBUqo5Ud+Fbe6PjPboB9Hf4Z+zk9/rSoHVTxxaAqzVtOLxgDMYFSVDdtU6r0DGzeXWMnWZX2J6X9zqq0wPGSouu9BZVQFkx3yHpSOHBdNTb7Md5xFWJjtLbw8vFTNIYH5qVX5TzvhEn/m8IqWAqfZ2O2Oljb9Fh98uxDmlpLagrXKxL0OzFm6AEgf4/wE+nfxNFGrGmtK2OuofJPzVw+svjkudG4Ql/2LCui7nnWWHEdt3A4uu5Se2pKgDuKIKtMvX5ZPG2oWbo6bePlxN+d0Z X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR10MB2888.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(136003)(376002)(366004)(39860400002)(346002)(451199021)(478600001)(6486002)(6666004)(186003)(6506007)(26005)(6512007)(2906002)(316002)(41300700001)(66946007)(66556008)(66476007)(6916009)(5660300002)(8936002)(8676002)(38100700002)(86362001)(36756003)(2616005)(83380400001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: mZVS4G5tE93AbDgP3i147uEiCUdLxne8HPJfjL6ZuvUeYBxai3Y+wwzeYBAHHORVBPO+5q7tXqbGzz3Eh9FP4dk9IKcl1BhIjKSO2WYUeEd9fBCq4HfCyOEb7Qr1WEi6S1ENBusINbVq6Tig7FeNXw0e2SPRvIj2ioOJwSfPhhQ2RpGSZM0lQeLVkH8uH+ZlnjGnF1Jj8P76pTfzabStaczPTjsg6mRX3vVIxdP42ub61f1oDkr0GBJjhTeC5RzXwpz/d63AukxJisYVunVPYJvNsSLZhXNh9B/2Z6JpO3mDqS/dHAtSa5PXGw2PU7SiRAwPYPI4WCzzQ1TPoI5qCjaivF92f4qOb18etDnhQ+TTmpnBYm3RDcLCzwwXycASCEVD74XalkaFDQHFRwDpiTbSh2bP3xFOb7OmbI5PbTbpd6H3PrlezC3g+lqTKfM+G39fmo6p782aLgmcdK2srI9sTan6HDU616hJxLHr1+t08sCa8l2pfEL8/A8KZX4gS6fG6LSwf2b9M4Ww3M2IZDizdyCXHPO7QMR4DJn8n8T9oBcV3LQolrEq48fUOwkwmJ0cnDNr9iIINifOXdJhyTt8umbwUhzGwf0D+OKJKLAgYqXXWRNfKRAmVIyKveoB/VgPk9zz/kQeyr/rwwykxQ+KCKizpGN28deTk00SUQIRxUfsIomyO6TLBbF/xRZXUF2vH3Gx0twDsGrTwhPcALsqqaVgoaUgCj/CmMPlcGwqEthmYzpXHI+SFygZQNGHzBsSSivfn0ku/75VTPV1N4tO7ULBbS9SafUNHfxQPZcySFuTKRkDk3i040eAB7oB08TOMK0vbBWWKGr0n9f67bnmI0WyUSqaeVwnFALvuXnDEeY9xiZu1taCppP6UOFTQ7uMDZ82LohmSgqUuEJCJQ4RSo37g2P247LSuJOczfJwuTxq2G9tRmImOyZZka8wWMuTwHlSENvTwIgs4+v7yD5WP3jcB0k2PM4uut+ScucNabaDnooy1V6Q/Yc2qWbk3LRq02sw4CcwJ4xxXweV75QDSk2WmGMDhcUy0fTWMOO7kN/NzscRMlIcEooi9ZfEIG42kJ0baUQAXcq8QOCwXklLJx5X4lSJ9FBudnlFn5JSerTCDVAxHrXtyCZChGsOD8N7wQepQISu/LA+wn6nzsLzqTJvPnSYeMp0n+DynVg2JEwaBhMnueLTcG+EProWZPPcOBN3AUHDfXhgX/5BftGkhEHohAliEDNMBmHTnKCjtKGsxA1sO7stuvdDNXjIr+ZCXyZLnwWVSUTEhyuajuEy85W6y2lC1fMErm5kvwPlcWGu8K2WUVV/IiOdh7lH6NvY6+11Gg1sdAOKfzFSo0YqsQfGfGlZVAYlxX//1FS52D4m14L9U7pwfNjq8HmMQPkgbbtIj4dKxlj9uAeuY8cxUE5G3pr+zd8wLPFUeO03Xmdkoka0swVaDlsdVsT0DlUWN5J9d/vF4uNieofk2F+/npo2ibpSSGGwRmCmm9pkkzrTn42+6NK3L0HIb6NQIAmSo+w5kjTaQ1LEAMjyPWExUY4uDGaolgqYkz3UyJ47Vrd0C8LvO59ABMYHZe4/vLLjQHQAAvj94qoGLjdUWA== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: BrJX+lPzkadvpbprvY9NlHHL6/fTRLhrrKh/tNrZn8PUhoEIZtJfWCI/i2SBKDyYtCPRwm4uED6IS9hEFxcRHHCH4zHz4vWSd1GFWrakBRKRUdRa74fbhiUqQjWMIwvFnMUfSyeKvQjRmMPz6QrWzyp3U69TqxgqSSoYuZXYCKg/a2vxWegCwRhZHPv8qtt9czYgUeseSwiPfIewj6bhL2m/2LSvsQDrUhCcxSI5HCZPEsy8q9Lx0n+9Cuy9//269QEtbjaxO0GxRef18aOVa4ZfGKqOw7naRasSD6vc6Vn4/pNsPnKAcFrUl9rrpNyIqQyYp1naIdsjcE/boez66glxrqm4e2JlDibiUmeYub9H/vGJiE0g70b622MTL+lpzoDD9FHQhsDOLsQaBPzQKY8RyRTSjy8EsEq9T1/78zly4qBrF17G1tfE5a9//e8XllDQeK2TNJzQV5+UFvHlsn76ef54BYHTZG4Qsi69eKUsV3dczfW3cjbQXMCQ0vv+/TfJj41IGQ3h0ozAnGiLC2EGK7UgTCJsLmnYPM+x9xaRuwrlLJGH5OSoZa2GZqNfvCxbVDWe9vZPZPqbKOWHPZo0+miUlX74w402gTl/yCKB8TSoi416Cc4ZB0IluXuLDK+MG9zOGRboEaIXxkchFs7343UBLZC7fTUtkoijAvpYcUEbgR7ttxipuPGK4PKdJ0m1Qk8kSXveqNVMrUj0MpunPybhHAGvVBHangWUJb2k8fbh5LuR0XOR77upN0JyTuErVOZgAyMzEmDiCy3jHQ== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: dfd6206f-e95a-418e-824e-08db84649607 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2023 12:19:35.4225 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hJ8GBr9gy82F080p2QmefOAWT9vdZWybEJV+D4w1nU33uFHMGZb7P4aPs5voRrp+rWWTsv+XmFG/vnGQYi+HXdmodpRvMcCg1lz5oeKVAdg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB6714 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-14_06,2023-07-13_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 mlxlogscore=999 spamscore=0 phishscore=0 mlxscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307140111 X-Proofpoint-ORIG-GUID: qVGerXdtQJBoT63ancv1x2-R2cU9reSw X-Proofpoint-GUID: qVGerXdtQJBoT63ancv1x2-R2cU9reSw X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "Jose E. Marchesi via Gcc-patches" From: "Jose E. Marchesi" Reply-To: "Jose E. Marchesi" Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771398471931006829 X-GMAIL-MSGID: 1771398471931006829 commit 53d12ecd624ec901d8449cfa1917f6f90e910927 (HEAD -> master, origin/master, origin/HEAD) Author: Jose E. Marchesi Date: Fri Jul 14 13:54:06 2023 +0200 bpf: enable instruction scheduling This patch adds a dummy FSM to bpf.md in order to get INSN_SCHEDULING defined. If the later is not defined, the `combine' pass generates paradoxical subregs of mems, which seems to then be mishandled by LRA, resulting in invalid code. Tested in bpf-unknown-none. gcc/ChangeLog: 2023-07-14 Jose E. Marchesi PR target/110657 * config/bpf/bpf.md: Enable instruction scheduling. diff --git a/gcc/config/bpf/bpf.md b/gcc/config/bpf/bpf.md index f6be0a21234..329f62f55c3 100644 --- a/gcc/config/bpf/bpf.md +++ b/gcc/config/bpf/bpf.md @@ -20,6 +20,17 @@ (include "predicates.md") (include "constraints.md") +;;;; Instruction Scheduler FSM + +;; This is just to get INSN_SCHEDULING defined, so that combine does +;; not make paradoxical subregs of memory. These subregs seems to +;; confuse LRA that ends generating wrong instructions. + +(define_automaton "frob") +(define_cpu_unit "frob_unit" "frob") +(define_insn_reservation "frobnicator" 814 + (const_int 0) "frob_unit") + ;;;; Unspecs (define_c_enum "unspec" [