From patchwork Thu Jul 13 21:16:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthieu Baerts X-Patchwork-Id: 120118 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp2111446vqm; Thu, 13 Jul 2023 14:58:14 -0700 (PDT) X-Google-Smtp-Source: APBJJlE13+nIXU/XNTsrxTM6gpvYwWa2An69HLG7vulfLuhNHhoHSOVeb+o0AFSebJePLDxLRBas X-Received: by 2002:a05:6512:3ba9:b0:4fb:8f81:4fe8 with SMTP id g41-20020a0565123ba900b004fb8f814fe8mr2375212lfv.46.1689285494269; Thu, 13 Jul 2023 14:58:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689285494; cv=none; d=google.com; s=arc-20160816; b=iuSygNuTSTd6Kf3w9SSnl+AvRgqaLCGn0Z7KCqu44apjm+NgVz+9AEqo4qs92wHoQq f4uJu2qHIn4CR9SO9ToRBNGBYpC4p1f53Y1NLYBt4Nih71+PKeFCqfzWKgMn16oH2Llx aI+PD+FuVW+s9wwNa2F0V8kzee0mj88ZQEtApDQ+79zX+KKR8nxKkvZxLbt4LVnVe/7d 6NLJPmxBWkLKk/7pHLHmBZ192sBCDq1Y1HVYwLmYDsVQuwzu0VI6c6oZ/lQOGUxRnoD9 xq2Cx0yRG4DXUzU1p7PFRKa4BQi/q0/uhsABRPP8Z3zn+V4Bwd3SVXMqyAcsurjARtyP O1/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=nYnx/VDo8lOzEkd9RFmD+hOFqRYo9o9+grAoqaC0M7M=; fh=h3LiGBUm6eulEm9fBUf+17++RIrJdMtcr/w/s+mUUDE=; b=DYS3n9DWyuEMcAWJErXnD5ugOTKBBjgxOdtHGYGbcIhYVTcR/gB2yM3/Xtm6OFVdsr nNaUnVOcAKpwKtrUnuk9DUayqKOU7Vt7ym7GnEN1uI1NEyDRGw6r0LefuyDSxG1beqoQ TeX93eZ5bLtr3MMzMm6BMOeDG4O7bSX6RdrCjl36HRvdHtWwpDyZ+8BCcN1jkunMpysZ CBFZ+wNW1D4S/gzE5ZNqEywo648mCdLXqsQi9QumM3k/+NMe3vnCjECxS8Poyx9s32J8 JaBdJPiPAqUOCJA5y+J7J01FSbSH9T6xhjHoVCgnL5J3Q0cuFXMDG+DNi8QU7wv0HK+S UO1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tessares.net header.s=google header.b=rLPmayOW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=tessares.net Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b21-20020aa7c6d5000000b0051a39840146si1550985eds.464.2023.07.13.14.57.49; Thu, 13 Jul 2023 14:58:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@tessares.net header.s=google header.b=rLPmayOW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=tessares.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230468AbjGMVRy (ORCPT + 99 others); Thu, 13 Jul 2023 17:17:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232469AbjGMVRt (ORCPT ); Thu, 13 Jul 2023 17:17:49 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5AAE2D61 for ; Thu, 13 Jul 2023 14:17:45 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-3fbc244d307so11159215e9.1 for ; Thu, 13 Jul 2023 14:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares.net; s=google; t=1689283064; x=1691875064; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nYnx/VDo8lOzEkd9RFmD+hOFqRYo9o9+grAoqaC0M7M=; b=rLPmayOWzc6g9V910/q65nAuOjv00BAzsVc6mSA3lR0UWmv1lKPpxAH2Aab7J0z+Aq DoZ3QmD9/bqByDzA8UvfhuoDOg0LF09+jj13aeqiKONl0qANDzxgLpwCoiQs5MwMCL/8 cdIXQ4Ed82QlAbNgMzo/kWfthEGfwBwUYbW3UnKd3BnRiPMNZu5fAAcM4f4NX117JN6Y LNXh3yiJJECnC+45b1CCU1L9/4UEAel3HQ0rXqRjr23xxQd6nh02TMvdV1OkGGhISXog JTJDvLxvlYAj+3bPRs1NH6MCSlJ9Srfe8p69z6lDtBxKExRFXlDJC6gaYtMj7ktSQJxh Mkew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689283064; x=1691875064; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nYnx/VDo8lOzEkd9RFmD+hOFqRYo9o9+grAoqaC0M7M=; b=Ci6cOvM8El06y0q4mSJkjg0fg9RsG1TDG9rtXIA4jzFkNcpEpXoiP0SJUSXxmR80MR /A0R0+xkEhdEOd95JGxtpBR1NCfA+RlE2YenUvB5780wund2s9wU+1IfJjzq/M7AH0aM pwZzLRTvKGDNZeR60rjs+3U8XNMnhd0d1YvX/muzOX6XcaQ0Pl9Nt7BsWTcILXvkG1Qi I1dbN+7PbsXDiOop0jSDd89kJ9kcSPhWQtvjN6sk6wpDhYGeGF1POpo8NhOCQsUHqLSm 9krts/1YjGqFqZ6vQ+Yjpzx91Tjofo9ZoUVjZxcvKENxVbaxqCGU2IfBBZ1JeBgPZIcC pMHA== X-Gm-Message-State: ABy/qLYZZhi88FgynQ5no8a8vdnrFCUO3JbJEVn8AYCGUza6ZWBEtGb5 RT+L1yRhrcRPZzcxSobP2Y+cQg== X-Received: by 2002:a7b:cc15:0:b0:3fa:9561:3016 with SMTP id f21-20020a7bcc15000000b003fa95613016mr2331758wmh.30.1689283063981; Thu, 13 Jul 2023 14:17:43 -0700 (PDT) Received: from vdi08.nix.tessares.net (static.219.156.76.144.clients.your-server.de. [144.76.156.219]) by smtp.gmail.com with ESMTPSA id m20-20020a7bcb94000000b003fbfea1afffsm8734136wmi.27.2023.07.13.14.17.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jul 2023 14:17:43 -0700 (PDT) From: Matthieu Baerts Date: Thu, 13 Jul 2023 23:16:44 +0200 Subject: [PATCH net 1/3] selftests: tc: set timeout to 15 minutes MIME-Version: 1.0 Message-Id: <20230713-tc-selftests-lkft-v1-1-1eb4fd3a96e7@tessares.net> References: <20230713-tc-selftests-lkft-v1-0-1eb4fd3a96e7@tessares.net> In-Reply-To: <20230713-tc-selftests-lkft-v1-0-1eb4fd3a96e7@tessares.net> To: Jamal Hadi Salim , Cong Wang , Jiri Pirko , Shuah Khan , Kees Cook , "David S. Miller" , Paul Blakey , Marcelo Ricardo Leitner , mptcp@lists.linux.dev Cc: Pedro Tammela , Shuah Khan , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, Matthieu Baerts , stable@vger.kernel.org X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1433; i=matthieu.baerts@tessares.net; h=from:subject:message-id; bh=aRf2NUlWpQteg42pbw7DyQllMQTrdJ1OPx8sg9BiW2M=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBksGn1E1CyU82GEtiTz9Kn3atBqLCeF8gHpWsl/ QfpMKoJ40OJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZLBp9QAKCRD2t4JPQmmg c/WRD/9f1JjmbA0ekElLhLbwzV9QM7ML9tP6qiaEiGIRxESQJvVnvwoBM74lJGLNLwoxh1RTPM7 BazpQpnWcvtP1g7+T5PLIajJ9xNxBasm+wLsssacLKdxMc4KkKZ9N4j4gg71aaWrNaM22Gsu9DO x5K148C72MuH7vzcg1qKfmSUl3nLkzB+FYCIoHLl7Rm40IWR3ccHOdiw1lkGoABBHCYzjMUZkSR 5HjtOkWwjuWMurPnW3JNrSYBtDszpC33kjxz9PJH6+mWYxG9f9YRMOX5+umyyTnRUeAQ6/78BBB X3Ux4Aa3T4g1AIlUFJls0Drv8mX4fkf0qfi+brN4XGI3KSq6MLVqdl6fCSnRbN5Ab4NhWw0ZqhJ SYcAiecUnZWjpz1GNOA9utPRGzEy+z4mXXKOjjLpOxVRahOMwjXzdYg03VaJ2EIH5nMTfwzL+Fv j4IPDaulMsxNThGDll6SSx9jjYM3IZYAk4Vv6RH6te9TiXmv39crSUJaCraIAYFS3t0ZDnXjIgQ OljCjFLAtHfBn6bj4Yu5MWLHiM0uXVHvUpljYAj/Rk7rGymqVpXmjUr4CbPTM1Dsor2JwGwzLR0 KghInxltcEu0T+ui9/rzcjCAr5SCzVGSzhBamCR3CRttgCxmGdcmEHtTOUuR6d0jOFK28wnNkRE zgAHC1Q6JIX0V7g== X-Developer-Key: i=matthieu.baerts@tessares.net; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771344226193208791 X-GMAIL-MSGID: 1771344226193208791 When looking for something else in LKFT reports [1], I noticed that the TC selftest ended with a timeout error: not ok 1 selftests: tc-testing: tdc.sh # TIMEOUT 45 seconds The timeout had been introduced 3 years ago, see the Fixes commit below. This timeout is only in place when executing the selftests via the kselftests runner scripts. I guess this is not what most TC devs are using and nobody noticed the issue before. The new timeout is set to 15 minutes as suggested by Pedro [2]. It looks like it is plenty more time than what it takes in "normal" conditions. Fixes: 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second timeout per test") Cc: stable@vger.kernel.org Link: https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230711/testrun/18267241/suite/kselftest-tc-testing/test/tc-testing_tdc_sh/log [1] Link: https://lore.kernel.org/netdev/0e061d4a-9a23-9f58-3b35-d8919de332d7@tessares.net/T/ [2] Suggested-by: Pedro Tammela Signed-off-by: Matthieu Baerts --- tools/testing/selftests/tc-testing/settings | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/tc-testing/settings b/tools/testing/selftests/tc-testing/settings new file mode 100644 index 000000000000..e2206265f67c --- /dev/null +++ b/tools/testing/selftests/tc-testing/settings @@ -0,0 +1 @@ +timeout=900 From patchwork Thu Jul 13 21:16:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthieu Baerts X-Patchwork-Id: 120116 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp2108544vqm; Thu, 13 Jul 2023 14:51:11 -0700 (PDT) X-Google-Smtp-Source: APBJJlFrABiVTXToO8BEu9WdNmaPiRJC7WaRtCXR0UnpVkD9xST4ku+cjOY8DtXPSEhdVh7ufQlv X-Received: by 2002:a05:6358:9913:b0:135:96fa:bff3 with SMTP id w19-20020a056358991300b0013596fabff3mr2843026rwa.4.1689285071139; Thu, 13 Jul 2023 14:51:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689285071; cv=none; d=google.com; s=arc-20160816; b=u4E5cWHgesewIgGu2ztb17Ef+Px3GpYq7o2p5y74Sy9H6Qt8TpiK/RQ+VprbPo4n+/ oCP8RXS90zuizFIuhi/EHfMacFHH5D3QCXZ0bpXdZFovRMz22X7sM7tZoKL7iTR2EOzG 2F8Z/fdydfHRY0NIGeAVizHcqd3xR46Hqi2RPm3ttg6DxgoVJkr67MbiZf6XX23cQgcf jE2XDh1d6BPcTactQ3Ip43goWYbaBYIMHQVh7H/foSBHrh3nJEHjErP+KcVgk2MEF5wJ HPlJFySKe+ewM1AVAYZdv2rASGyKshKvtQx+fnYceTnPKDFz1O3MjbdrYpdnzrJbFOeG 346g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=2VAWVwpGDXDMLo65Ubj9cQ9CL/GZFLpXbrG0guU8ZAk=; fh=h3LiGBUm6eulEm9fBUf+17++RIrJdMtcr/w/s+mUUDE=; b=aQjqQXma6AJI0T1JjoWHwZkIinJnCD7DoDpYrXn5pN6N4yXSD8cUCcGx3zp2/GL83v PJe4np4GdhDbxtGwwJyvjFBaoCWHlu+12bDuUEk4qCjC7BZvFofJUgKmfOiGmksKG5K+ R6R4B6cNzc7DWMazK+lY1hDSY2r9Y/X0qpmMFvKDbMyiQV1OUMhgQ5GiHEn6n14BrRS7 zIZuaVlFwHLPghfdlG0iaH0i0qP856kGp0GGriTLsCgrBSjETdfSBCnY19y1gMJcI88m NIYjKKRGJ4di6UlbdIL9oeiLCJX8RdKLhB0WXz1749V9jxq21u8gooRM5oF3MLsnNVj+ cxmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tessares.net header.s=google header.b="R1OO/MLD"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=tessares.net Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z17-20020a656651000000b0055b950821basi5595725pgv.181.2023.07.13.14.50.58; Thu, 13 Jul 2023 14:51:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@tessares.net header.s=google header.b="R1OO/MLD"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=tessares.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233484AbjGMVR4 (ORCPT + 99 others); Thu, 13 Jul 2023 17:17:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232788AbjGMVRu (ORCPT ); Thu, 13 Jul 2023 17:17:50 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C74312D63 for ; Thu, 13 Jul 2023 14:17:46 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-3fbdfda88f4so11173065e9.1 for ; Thu, 13 Jul 2023 14:17:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares.net; s=google; t=1689283065; x=1691875065; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2VAWVwpGDXDMLo65Ubj9cQ9CL/GZFLpXbrG0guU8ZAk=; b=R1OO/MLDlYuqf3n93Xf3dZ0JRKHT83rtvi6Aw9xfoACQknf2haLiKf3g1XekYARe+s zK0OwTVC9nFl5dK3x6irNe1Q/HtqnB8wAFyTNfMavMSP+wp7E3FZirFjt0SNTNKMkiTW 9CerwuZBtoCpbXVb2Kttpe+0YOmkatXWXMBfpEvu0ouB4Alxdw+NglTInaXbs7aIesQv J+n5pnG3Wt0JoO0/1LsrTCx5HpvEi2bXw+8itAL3hsLnH7tzLASdWDMdYetDS3lilaBX OOC9awSd1siy1lSSnOw4suFFY0jxhe4Aou2N2BNs5K7mGy5vUMgk0vdp5ueNMrIQRy2b 0aIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689283065; x=1691875065; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2VAWVwpGDXDMLo65Ubj9cQ9CL/GZFLpXbrG0guU8ZAk=; b=KFCNTEj99xqAs/iiqVEUGT+1tPFbemMgT//FOCa0TpqpqiqJhJoLodqk7Vv09TJIeB dft1NfDC7fy5x0pExf4qCYAzVsqISu+SwhhVk74AyEmdfwDUa5CVOahB4M4XkTKZIekC G/+hJnmfu4npHBsNFlv6IQE5NnMM8CY2HXSvAXTbaK9VSEMWNKcobk1fZ5ZgGkUQrwgM WGSbatmDOG/DcuyxvpGwq86xJtMPgmvkWtOu1VZ8dJbXc5V+uxA2t+xApVKoUufjHobi 9l4Mc+rEsurpEaPzA7dIcJBsOhFS/KC7+NOVJTjbN2ENt1cfk32B0F6lGboFKBaWqg5x 65cA== X-Gm-Message-State: ABy/qLbxOytyQtTMBC4W4/LxDZ63Rkyn7U83ZrJ7KY54XBM/P+5itR2r ib9JRj43D56nlRrWybDAv7sTFg== X-Received: by 2002:a05:600c:2141:b0:3fb:dd5d:76b with SMTP id v1-20020a05600c214100b003fbdd5d076bmr2479666wml.7.1689283065118; Thu, 13 Jul 2023 14:17:45 -0700 (PDT) Received: from vdi08.nix.tessares.net (static.219.156.76.144.clients.your-server.de. [144.76.156.219]) by smtp.gmail.com with ESMTPSA id m20-20020a7bcb94000000b003fbfea1afffsm8734136wmi.27.2023.07.13.14.17.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jul 2023 14:17:44 -0700 (PDT) From: Matthieu Baerts Date: Thu, 13 Jul 2023 23:16:45 +0200 Subject: [PATCH net 2/3] selftests: tc: add 'ct' action kconfig dep MIME-Version: 1.0 Message-Id: <20230713-tc-selftests-lkft-v1-2-1eb4fd3a96e7@tessares.net> References: <20230713-tc-selftests-lkft-v1-0-1eb4fd3a96e7@tessares.net> In-Reply-To: <20230713-tc-selftests-lkft-v1-0-1eb4fd3a96e7@tessares.net> To: Jamal Hadi Salim , Cong Wang , Jiri Pirko , Shuah Khan , Kees Cook , "David S. Miller" , Paul Blakey , Marcelo Ricardo Leitner , mptcp@lists.linux.dev Cc: Pedro Tammela , Shuah Khan , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, Matthieu Baerts , stable@vger.kernel.org X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1409; i=matthieu.baerts@tessares.net; h=from:subject:message-id; bh=5L5yVXJPUIN5mPcgi9qNT31nW3zr8gj1H+S+tv1zJXU=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBksGn1Tfm4gXr9yYcL0NutlcfJMBFjlfmCxUnB6 n3hJPa5tJKJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZLBp9QAKCRD2t4JPQmmg c1L4EACFKJywHSS8y1HqKPLTPlIicSUIMYCQxyOjN6qcNyMopaA+qlnrbtgOAj42KDFZu3MthgT mLS8Z1bhO8ogUW+ylNbMvJ7wOGQtJ0ktZG1fpw0rTBXzGxwo6ZC+D5mqg0txCZic4wzLrWdKLJv tFbqRXmbHZUbx+D84kk1vvRoZH7T8NNC1lhMs+HT7YnvAAM8rtuBhXS/qzi4Fg0LQNsonm89cs+ 0LuGqspqLGYmmYNgIVnjHat5a4PvhiigGFZUIKoxuvKYpqpomA1ABKuzW0sX83aaX1Y78HsB2kA Cgjz+uaWswRZLbbq4ZU4W2imaqYsIviuxUXXgoiN/I+NI0Wtea4EJU7U0VKosQwRVwdCId2xF23 1vZrhXoR7fh53jJ3xx5U9iOWD0u+tERIbKh642LijNnsPs/JA038YlnZGhabYTnX2PJrUDyVBKA fCRne9isCIMOkF6sTYeMkcyz8npORDs4aF35/TU7Tme/gU3alsPs0wshz/re4zOOdVVJ//soNRp fKVgMbKkvNrOKV6xIJQgQbK6EsPkTYBZHkQ3g+0n4TXpYMnRotatXkVvCmeDpHY5Mt/2FkjUWQI KsLLDiy3rxjp83IzCGzN6CwPCg3gmJ2y0e+yg2dc7U9Yw8uymMP2z+rUs3285uYSzL/gnTxVbmg 480Z9i9gDVEZiuQ== X-Developer-Key: i=matthieu.baerts@tessares.net; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771343782885187500 X-GMAIL-MSGID: 1771343782885187500 When looking for something else in LKFT reports [1], I noticed most of the tests were skipped because the "teardown stage" did not complete successfully. Pedro found out this is due to the fact CONFIG_NF_FLOW_TABLE is required but not listed in the 'config' file. Adding it to the list fixes the issues on LKFT side. CONFIG_NET_ACT_CT is now set to 'm' in the final kconfig. Fixes: c34b961a2492 ("net/sched: act_ct: Create nf flow table per zone") Cc: stable@vger.kernel.org Link: https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230711/testrun/18267241/suite/kselftest-tc-testing/test/tc-testing_tdc_sh/log [1] Link: https://lore.kernel.org/netdev/0e061d4a-9a23-9f58-3b35-d8919de332d7@tessares.net/T/ [2] Suggested-by: Pedro Tammela Signed-off-by: Matthieu Baerts --- tools/testing/selftests/tc-testing/config | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/tc-testing/config b/tools/testing/selftests/tc-testing/config index 6e73b09c20c8..d1ad29040c02 100644 --- a/tools/testing/selftests/tc-testing/config +++ b/tools/testing/selftests/tc-testing/config @@ -5,6 +5,7 @@ CONFIG_NF_CONNTRACK=m CONFIG_NF_CONNTRACK_MARK=y CONFIG_NF_CONNTRACK_ZONES=y CONFIG_NF_CONNTRACK_LABELS=y +CONFIG_NF_FLOW_TABLE=m CONFIG_NF_NAT=m CONFIG_NETFILTER_XT_TARGET_LOG=m From patchwork Thu Jul 13 21:16:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthieu Baerts X-Patchwork-Id: 120113 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp2101190vqm; Thu, 13 Jul 2023 14:34:22 -0700 (PDT) X-Google-Smtp-Source: APBJJlH0Ylpsw24Xg4l6sROReensdqiNvhgH2j6aaugyeElJuUUFMNyMcvC7lY7ONjraEMMHTNzI X-Received: by 2002:a05:6512:65:b0:4fb:c693:c73b with SMTP id i5-20020a056512006500b004fbc693c73bmr2303811lfo.64.1689284062609; Thu, 13 Jul 2023 14:34:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689284062; cv=none; d=google.com; s=arc-20160816; b=v9/HqnVH2svIIlx5/OdKZtBSfHRhGHV6je+kSHrMsIpJpArbTxA7ZLsfEE4hJuV+Sb zU9eJHs+evTCnIUSo8thn2cF7D2YFeMh7HPoKE53PvL51TFB3DjzT163c5Ar6QtTAeKH KO3+LdHifLfECMcPuJjWpYvWPOJO4QZaZtC5sJv6L+XAqSrA03k/6G+5L701Sk3SGO3u QR7Og1TUT1bDy91aBgeBFZW7oVKOBLeG2EokgeyvU7wTg7swyU7rUV38sPQdFnoeje3g fAzEM1M33J9BOxg71Ok7hhd0rEETHXFA/8R34AI/W9GXd8NpTqvAMTBSxIMQLWfE+j5f yr7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=TsJALsxCC7W/CAsd1l447Gkg4QP+b67KVu4aEHXx1H8=; fh=h3LiGBUm6eulEm9fBUf+17++RIrJdMtcr/w/s+mUUDE=; b=Ggzs0oTDU6sETI7RlQAiFVLWMKzFPmEHusvuSSHig+mYHXpMWRWCDyXldUsEdsbQip z3odVWXlVh9MW6xWzl5FsLDFZjek2zBeUj7ZioN5sOKo4FhQcMqBrQHQn+d5b6sAvQaE sIRUAbgNQZ0p7wUsfCSKdN029NlrvNhoznAohmsvyxFMyVsKiWfMqp7UP+748tolkm8b eV9eiLLTI1xWvtc8IiBKR2dPQI2G//wrXMD3CoXro5bKvQQ+i1vVQVnxzDfX+9643aJf KSZCCqxNUXAa57leR01TnBtPSAEp/CoW1dL5LrnNrtw79TV0JefvLh7fZhQitZw7zbSk McNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tessares.net header.s=google header.b=bt3cywbm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=tessares.net Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bc18-20020a056402205200b0051a200c2d2bsi8590377edb.395.2023.07.13.14.33.57; Thu, 13 Jul 2023 14:34:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@tessares.net header.s=google header.b=bt3cywbm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=tessares.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233934AbjGMVSA (ORCPT + 99 others); Thu, 13 Jul 2023 17:18:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233016AbjGMVRv (ORCPT ); Thu, 13 Jul 2023 17:17:51 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0F382D69 for ; Thu, 13 Jul 2023 14:17:47 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3fc0aecf15bso9988085e9.1 for ; Thu, 13 Jul 2023 14:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares.net; s=google; t=1689283066; x=1691875066; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TsJALsxCC7W/CAsd1l447Gkg4QP+b67KVu4aEHXx1H8=; b=bt3cywbmI2xlzlVR6vRTSp+EcwPMU/Po0YAkZsTxYd4qeBDWmBtWWW1L7ZLZu7/Rp0 /rorCNOUTXNVUWcLrGeCXbk9yTbznrWpdKIZ7g9alJTVVuqw2gcb2COuguuFWoQ4WVon 8Np8h5Mwx8NsaQNfcxYyX911xkWytdrDTsxbw4eODsgaFgUIe4+SqpMumx7RaLTQ5+8X MIOFF8AO8Bz0TWAlXVTJYgThE16Hn01Y+16mpzsUXW83Vbix9Z+QtRQAytDsiOD3+9vj z9e71xvYt+xLgB2ItMz8f8lLgv4n2Y8YAhJ+U0f4CoRe+c31H6HDYo85nab2G+EVApeg 4c9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689283066; x=1691875066; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TsJALsxCC7W/CAsd1l447Gkg4QP+b67KVu4aEHXx1H8=; b=XddKIPIo9pd/0EwjQlKHqVf2WCPNJQ9ERhNj1oEb6qE9YeFGRlhmRZeRZrOnbL7zjz 5MhaqDnsREHLGqLAMINkWWq+TBNafKNFnG9vFOqhd6wtGMkNFc0hWlJIWbG9oQMFPFGj xK9tyAVQTaZrFD5O8d+puh8YPdHSQtg38gMZT+X098X/VwDtIpNvjcDELJyANqYSfOSj /sQlHwb1UBl518DVuoF7pNls/AZ4OZStiUQzEcg5oaovK/cqJkk+X4ela0ncCsFBliHJ 9vPmfft+Te6TZIsstZ+kSzgkWHeqljnHWk6DPKoVbQCfbvsDaCvwUCZCUy8NX59h3og+ GG7A== X-Gm-Message-State: ABy/qLYlq5HCH/AX9EZ80Ti9qc6DjbEybRs4AmWRkCg6YNrbdz4G0XyL +mpij40Ez7dbQlsX36PB8KcYqA== X-Received: by 2002:a7b:cbc9:0:b0:3fb:e1ed:7f83 with SMTP id n9-20020a7bcbc9000000b003fbe1ed7f83mr2882825wmi.33.1689283066347; Thu, 13 Jul 2023 14:17:46 -0700 (PDT) Received: from vdi08.nix.tessares.net (static.219.156.76.144.clients.your-server.de. [144.76.156.219]) by smtp.gmail.com with ESMTPSA id m20-20020a7bcb94000000b003fbfea1afffsm8734136wmi.27.2023.07.13.14.17.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jul 2023 14:17:45 -0700 (PDT) From: Matthieu Baerts Date: Thu, 13 Jul 2023 23:16:46 +0200 Subject: [PATCH net 3/3] selftests: tc: add ConnTrack procfs kconfig MIME-Version: 1.0 Message-Id: <20230713-tc-selftests-lkft-v1-3-1eb4fd3a96e7@tessares.net> References: <20230713-tc-selftests-lkft-v1-0-1eb4fd3a96e7@tessares.net> In-Reply-To: <20230713-tc-selftests-lkft-v1-0-1eb4fd3a96e7@tessares.net> To: Jamal Hadi Salim , Cong Wang , Jiri Pirko , Shuah Khan , Kees Cook , "David S. Miller" , Paul Blakey , Marcelo Ricardo Leitner , mptcp@lists.linux.dev Cc: Pedro Tammela , Shuah Khan , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, Matthieu Baerts , stable@vger.kernel.org X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1295; i=matthieu.baerts@tessares.net; h=from:subject:message-id; bh=YxZMkeKTSYd/i12Y6hiS0Va0uPxVYaw6onSJrdJZ2xk=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBksGn1bBYwvMN9ZJOmDSJeapOx7V3gAfyEaaHiq u4fgEkD5s+JAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZLBp9QAKCRD2t4JPQmmg c/79EADA/xNSe+OXe+fAkOmIazz02wIFBl+djuhBXh/Wq7uTJ/wXX2LVXz7haAPg0yi452RyvW6 Y3umutQuwMqvWzIStUfkZHrvVTBjBp2u7zvgkknGe2hDS7tDLYXmbQ667Qs340s8OUMGqvptQk7 y25FKL03KNuLSokg0OhB1Dp1u9hAYsuDmp18420NV6kDA3jPi1WMMzd9FV0iajheLOgk3TM1/JM CmY1+0inJwGExfLshAmG5soMIwQwZql8d1Lq4lD4hn2tkfUPO5tsrcoOaj3y2rDxE6vECvC9sWI 3syinI2F9TgnuGw/+OXCL7GkqLbD/1ok/fTu0M2AQV1e6dOEbi4xTxMlqhAOYlqC48rsNVrwiIC 5xxByReFo7qwwKI9y8JVMf98hF04OY8vwow1gw/Cbwf15/GZpWnIWqFRfA9PrYpyxFs0iq4ASeL 6opLFLVqXBXpeOsySZvp6gl3GqxMk0oNCpDRg29Q9E8EkzzMlIjqJKZUsQnFvrwJOOKNPzi00cZ +AWTZiSk7qawGmeIBg1KKMdLx0xcG1puAieB1bzmmSB4ZXlR4aogcXkAE+ku92dZ6PYvTxdt8nt 2UUXOHdQmUX2S4etArxuBVMbnXQ7cHk7oHy9Fat5T/EwBWQK3QQiWZEmdI/qPOxJotVjg3ZIiaG r69EzqvS4gPH/QQ== X-Developer-Key: i=matthieu.baerts@tessares.net; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771342724974545000 X-GMAIL-MSGID: 1771342724974545000 When looking at the TC selftest reports, I noticed one test was failing because /proc/net/nf_conntrack was not available. not ok 373 3992 - Add ct action triggering DNAT tuple conflict Could not match regex pattern. Verify command output: cat: /proc/net/nf_conntrack: No such file or directory It is only available if NF_CONNTRACK_PROCFS kconfig is set. So the issue can be fixed simply by adding it to the list of required kconfig. Fixes: e46905641316 ("tc-testing: add test for ct DNAT tuple collision") Cc: stable@vger.kernel.org Link: https://lore.kernel.org/netdev/0e061d4a-9a23-9f58-3b35-d8919de332d7@tessares.net/T/ [1] Signed-off-by: Matthieu Baerts --- tools/testing/selftests/tc-testing/config | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/tc-testing/config b/tools/testing/selftests/tc-testing/config index d1ad29040c02..71706197ba0f 100644 --- a/tools/testing/selftests/tc-testing/config +++ b/tools/testing/selftests/tc-testing/config @@ -5,6 +5,7 @@ CONFIG_NF_CONNTRACK=m CONFIG_NF_CONNTRACK_MARK=y CONFIG_NF_CONNTRACK_ZONES=y CONFIG_NF_CONNTRACK_LABELS=y +CONFIG_NF_CONNTRACK_PROCFS=y CONFIG_NF_FLOW_TABLE=m CONFIG_NF_NAT=m CONFIG_NETFILTER_XT_TARGET_LOG=m