From patchwork Wed Jul 12 17:37:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fenghua Yu X-Patchwork-Id: 119321 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1334791vqm; Wed, 12 Jul 2023 11:24:42 -0700 (PDT) X-Google-Smtp-Source: APBJJlEbxp8wsb3uk3dQRP4PgZRqQigqzGfIq1lw6W4NzOORKna5GN1eBJd6CVytsHgS58YwxE+Z X-Received: by 2002:a05:6358:528c:b0:133:dd0:cae0 with SMTP id g12-20020a056358528c00b001330dd0cae0mr8902668rwa.27.1689186282048; Wed, 12 Jul 2023 11:24:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689186282; cv=none; d=google.com; s=arc-20160816; b=wgXQL4sMH+KJfA0+at6Maqj9KEMFAsMczWi+AqeH+de+CWScKUKhEYoRbHskNSc8nn iLfg1Z107jBbGdUlp9ers5aAUXi+z6hUr6+SJRzR2v7UP2+ey8b7UXnRJ3NuIMxmQq0+ CLfeAK3iSHIwxEWlu8NYbyY7EAHjmyjaZ7vHeehF8iBGIP7yonicjclO6uVlTyUtU2qd rEiUBBsPfYC0xKIsolidLjo0K4hgZVoYUTpkqtWtLCxAu2QpErRZGDkyHUvZOOFd7fSo Lr5B4hcrXBHN9O/GwqqnP7+U7LxaAv80fA6eRXRbeUO2Mt/zhTIcPmYVK0D35vZbjUys rNzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=kZZVdeiivVIhs8ze9d8LLHOV+LOF0u3a7vad4zvPZVI=; fh=w92u6ABreASBl73xQ0wRrUr+w3nOsDFSVztu0Enatl8=; b=VXANB8QR3dw41psBlU340GlFxhPyVel/DHyW5kVlxBtRaf3ArElC2LHmeoJtr7gTgc 1/4sv9OfS3MuISZnKrMffzhTkEBgQOGy9ipOWSduZ45JyJCywe12ueqk5zKhiB4TCdsj xKCLYyFX8yR7EMVhKKF46BobxLJvTF1FhD64j9rw2E+pxtSaFRL9/CB4afqoOiqpqwh1 Fl9rUC8PbMg0WRVkgagJYB9sO7I8vqk3HtClclyH0LIJWNoypZCmJGo4kVMa0GEfwl5P Qca0oG8YaLCypuF5Wze4dfWdA2nB7Tmz1bnDD3dI6rrroCPiBbz/Si+1aAWiXficfTJr GLDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kGZl6dRH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x5-20020a654145000000b00553b02a9a1asi3519978pgp.249.2023.07.12.11.24.28; Wed, 12 Jul 2023 11:24:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kGZl6dRH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230381AbjGLRiO (ORCPT + 99 others); Wed, 12 Jul 2023 13:38:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbjGLRiN (ORCPT ); Wed, 12 Jul 2023 13:38:13 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C22041991; Wed, 12 Jul 2023 10:38:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689183492; x=1720719492; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=TYhvma2gE7Mw095OVFE2jPkIF+FVK3/H6Q8d48I3RxM=; b=kGZl6dRHMITCv5MyeAikFBF9FAsmXM8vDG19MKVvxYR9NuopxGdI5eCa cVd+1KkFHJBHwVesbcpad+nLkp+7s4KBv+fJbrT/aRv5qROMK8Y+fpinS ybiKrx07L0F0n3Y+DTQYbBYZrjuDJGGz2WY2WO2OnTYTd++ZozDSP+P0j AS/Lty1+CB52/AySXZfqBEDcowoQpiRl8WLXw2kOU0tgZoGUjE9e3ZYGh HgF9zr5cuADL73Rq8+aBppAsXadTGMO3moUkRAzN1UfLgXi4BAlY8okLY JlDtt7zqx1APZwoB3IFrYSPTmLLvKWfVKsD8u5ITvrVnp0tSn+VAiUmlm w==; X-IronPort-AV: E=McAfee;i="6600,9927,10769"; a="345270611" X-IronPort-AV: E=Sophos;i="6.01,200,1684825200"; d="scan'208";a="345270611" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2023 10:38:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10769"; a="671949466" X-IronPort-AV: E=Sophos;i="6.01,200,1684825200"; d="scan'208";a="671949466" Received: from fyu1.sc.intel.com ([172.25.103.126]) by orsmga003.jf.intel.com with ESMTP; 12 Jul 2023 10:38:02 -0700 From: Fenghua Yu To: "Vinod Koul" , "Dave Jiang" Cc: dmaengine@vger.kernel.org, "linux-kernel" , Fenghua Yu , Tony Zhu Subject: [PATCH] dmaengine: idxd: Clear PRS disable flag when disabling IDXD device Date: Wed, 12 Jul 2023 10:37:56 -0700 Message-Id: <20230712173756.3434925-1-fenghua.yu@intel.com> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771240129582086637 X-GMAIL-MSGID: 1771240195109999868 Disabling IDXD device doesn't reset Page Request Service (PRS) disable flag to its initial value 0. This may cause user confusion because once PRS is disabled user will see PRS still remains the previous setting (i.e. disabled) via sysfs interface even after the device is disabled. To eliminate the confusion, reset PRS disable flag when the device is disabled. Tested-by: Tony Zhu Signed-off-by: Fenghua Yu --- drivers/dma/idxd/device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c index 5abbcc61c528..71dfb2c13066 100644 --- a/drivers/dma/idxd/device.c +++ b/drivers/dma/idxd/device.c @@ -387,6 +387,7 @@ static void idxd_wq_disable_cleanup(struct idxd_wq *wq) clear_bit(WQ_FLAG_DEDICATED, &wq->flags); clear_bit(WQ_FLAG_BLOCK_ON_FAULT, &wq->flags); clear_bit(WQ_FLAG_ATS_DISABLE, &wq->flags); + clear_bit(WQ_FLAG_PRS_DISABLE, &wq->flags); memset(wq->name, 0, WQ_NAME_SIZE); wq->max_xfer_bytes = WQ_DEFAULT_MAX_XFER; idxd_wq_set_max_batch_size(idxd->data->type, wq, WQ_DEFAULT_MAX_BATCH);