From patchwork Wed Jul 12 11:16:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 119093 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1080826vqm; Wed, 12 Jul 2023 04:32:13 -0700 (PDT) X-Google-Smtp-Source: APBJJlEkTbUcsfNvZL4Engky4UqpCpMH6GDsLT84EFnw3kdZAgVghx4O/WFlt/NQqgNSVUVKxhUl X-Received: by 2002:a05:6a00:148b:b0:681:6169:e403 with SMTP id v11-20020a056a00148b00b006816169e403mr18074485pfu.8.1689161533379; Wed, 12 Jul 2023 04:32:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689161533; cv=none; d=google.com; s=arc-20160816; b=iVLIr5O5/4TCPXbqFc56KiwZNspNVc0djIQtnVb0tdnzOC0JAik58IbvEpCVIsie4O oDVOTAM2WLHdxj7zyRYx5sU8JfZ0pJAXwK5zNuLD9n/woCaHaoAlwN4MCdQGRieF0A6U h01bNJSp+R/P+UgZYNHJifjJAXOa2usXlSsqH+lx1jag1DRTvQE/CK1NI/u+d/Z2fViY Na6VJLpKCJQgcuRedHT7FIJUQzLXQNGONunuwC9MlZyvOVcP7nJiIgR+Wwdmsp33n+nO T2Aljvl8coFJViU6o5DFVi9UTkc6gcaFIeBb088vhUU1RbvJJYTw99/il6a2GSwRYdkC z3uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=FkSZvqXJKAwrtyAebptmTGjUg+ibmOoVC6JufFbCKaw=; fh=dD5VRy62fGEC4qmQl5J3X6bNlUFi4ZQPLJ6+cF0aP94=; b=OT8KPvipIH2KB8zcrgpUmZyInYaNCCLL2Nix0Hk8Uh7T4mS0RiZNBrxecX/tbiYFsE RpXczDSPScE7g/XL2SAYmD84RSZVxAkTfpI6gqhbcMbm3fU6v15+frIPVuMAnyaagVLN T2cEjJFi1w4c4k++QWUFY6029raHLZ15g1dcCKPKaWj4IAJi4M5rIluEio2Eb7zvCaO+ FPh2fQ0foi6Zt9gZcHn3rO6sgEIJ5Eh2bsoJKcg574sGiBRIRj6WK7ONvboC3bLAjyS/ 6xi9I+KX11kBo/7D3aGwjLPeFjlgSom34tci7G/3mxw8eIQF2YzGDKhXgHvxL8dhuNsy FZsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JXmeMNc2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cg15-20020a056a00290f00b00668731a497fsi3062649pfb.44.2023.07.12.04.32.00; Wed, 12 Jul 2023 04:32:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JXmeMNc2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233030AbjGLLQ1 (ORCPT + 99 others); Wed, 12 Jul 2023 07:16:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233032AbjGLLQZ (ORCPT ); Wed, 12 Jul 2023 07:16:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24B54173C for ; Wed, 12 Jul 2023 04:16:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9F0586176F for ; Wed, 12 Jul 2023 11:16:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2981C433C7; Wed, 12 Jul 2023 11:16:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689160583; bh=g/lPF2Q6+m6/l+Vx14cbdCbMEjLRayxLuCbkQ3L/E34=; h=From:Date:Subject:To:Cc:From; b=JXmeMNc2ZfRO6RJZHPsaMPpw6zfp/m2jhTAOPuPnx23tpedMf5elkyZ4AQ0Z37GYB gk4ykvYRNzG80qHVGNsLKDNZ9M7kbfw9BUl3MO18Se8TmOgCb5Tz8kuA7P1D6636bV lUvg1awyEPzaVgxfkFQX4E6OUwz2Av59zviDD/iohxxvRonT/cNFMkNtBtDibot5qZ mV3oPsrOjwMhy/4XECSAMWh84G2uY++VmZBAjRNQDUrmYPVz5zRvjiradMN2BJFea+ ZGcOWFNNgI6iaobJFp96Pk30IkdMVwgs0y6Pd2DkipiNMDCvnOv2qsxbQl7PHGWMXP HS6lWtK/j3lUA== From: Mark Brown Date: Wed, 12 Jul 2023 12:16:16 +0100 Subject: [PATCH] net: dsa: ar9331: Use explict flags for regmap single read/write MIME-Version: 1.0 Message-Id: <20230712-net-at9331-regmap-v1-1-ebe66e81ed83@kernel.org> X-B4-Tracking: v=1; b=H4sIAH+LrmQC/x3MPQqAMAxA4atIZgP9QbReRRxCjTWDVVoRQXp3i +M3vPdC5iScYWxeSHxLliNW6LYBv1EMjLJUg1HGql4NGPlCupy1GhOHnU5Uhv1qvCbqHNTuTLz K8z+nuZQPul2Sd2MAAAA= To: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.13-dev-099c9 X-Developer-Signature: v=1; a=openpgp-sha256; l=1550; i=broonie@kernel.org; h=from:subject:message-id; bh=g/lPF2Q6+m6/l+Vx14cbdCbMEjLRayxLuCbkQ3L/E34=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBkrouDI8NOyrqsGzEeJY8gLZvKVkGeyDh1eRn7D gnHa3W5eNaJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZK6LgwAKCRAk1otyXVSH 0DrSB/9YctZRnKrg48Um3Nbv5sWzZro0vuiwu8xyWEE9gd03Ohv61ZKNzHw95j2r6EbV9ICcNfq X3VNlijIZStMAl7QDEPia74ODIozDSk7HTVHmLOFWYD79LpNxmvuyq8KSTFM1eHDQdxT5NGMTnr ab1iPhE25QqfZzvTrtWO7vnhge43bJsYu49HNcp0i7iWhcrlU1F0dpjXzykI8MZE/N6ogUE0+dO 0T6Rk520nmTuu5a4IaYjHK9b0bHGRgy7syE4wXK3syPspVDs8WTg8LqQzj57kgFK6wAVlVqg62d CzsNwXfT4Ksa4fNMlM3X5n8M+zBFk0uUhP9XJ9UrQxYuKU/0 X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771214243971733243 X-GMAIL-MSGID: 1771214243971733243 The at9331 is only able to read or write a single register at once. The driver has a custom regmap bus and chooses to tell the regmap core about this by reporting the maximum transfer sizes rather than the explicit flags that exist at the regmap level. Since there are a number of problems with the raw transfer limits and the regmap level flags are better integrated anyway convert the driver to use the flags. No functional change. Signed-off-by: Mark Brown Reviewed-by: Simon Horman --- drivers/net/dsa/qca/ar9331.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 change-id: 20230708-net-at9331-regmap-02ecf2c1aa59 Best regards, diff --git a/drivers/net/dsa/qca/ar9331.c b/drivers/net/dsa/qca/ar9331.c index b2bf78ac485e..3b0937031499 100644 --- a/drivers/net/dsa/qca/ar9331.c +++ b/drivers/net/dsa/qca/ar9331.c @@ -1002,6 +1002,8 @@ static const struct regmap_config ar9331_mdio_regmap_config = { .val_bits = 32, .reg_stride = 4, .max_register = AR9331_SW_REG_PAGE, + .use_single_read = true, + .use_single_write = true, .ranges = ar9331_regmap_range, .num_ranges = ARRAY_SIZE(ar9331_regmap_range), @@ -1018,8 +1020,6 @@ static struct regmap_bus ar9331_sw_bus = { .val_format_endian_default = REGMAP_ENDIAN_NATIVE, .read = ar9331_mdio_read, .write = ar9331_sw_bus_write, - .max_raw_read = 4, - .max_raw_write = 4, }; static int ar9331_sw_probe(struct mdio_device *mdiodev)