From patchwork Wed Jul 12 06:48:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Li X-Patchwork-Id: 118881 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp967202vqm; Wed, 12 Jul 2023 00:23:44 -0700 (PDT) X-Google-Smtp-Source: APBJJlEBj9sWgzGChBcbVAbLhEG2Tm7KgdqouJSLxI6J0eLLZr3aZ974KhaEsQFRCHlMnSCu8PV4 X-Received: by 2002:a17:902:a614:b0:1b8:9225:4367 with SMTP id u20-20020a170902a61400b001b892254367mr16615371plq.65.1689146623771; Wed, 12 Jul 2023 00:23:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689146623; cv=none; d=google.com; s=arc-20160816; b=GcU6LV4XE6csSTR8ub7QXAixfa0/87ggs7717bcrovU1EvCwlzBUIqxVBcnT5TM3j5 0wsD2kvE01Jk+KBgtWSkvSXpXuUUBBHyDX9SY4AIqjDHT6yGcscFqsP+zf+j9ABqhfQ6 +Jzp3SSrsdnpAVDr+4ieKP7WjYOkkv62aouOiH/pEqik5esiE44CBEY/dizMptoW9DSB VmZiX+1xBrilLk7K+IER6f+GaKrvhn13TLoa0e6TnKjXayK2Oyanq2KNIm5JeVPgK0b3 sCtoae13ZEyM2UPbOwaEHKT/3PTSHYzf3mrTF11mgXKMapVUZMuPfLNTQT+G1imHfInl Wj2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=OGJxkkGMv4pyxE5+FAh4L8+srFQJmXNAKijRBOh2Uho=; fh=M1UyY8hYEuUYghnrzpdPEfCaivQPIrv0W1Z57fHH6yw=; b=RqV79xHybRADG2CBASAXyQsRFsFA+5B9pmAl1ZmgFzkRU81wE43XYet5d4BvmgVahZ VXIuTJzYF8j4YI++wVAisH6+FDALjLJQ6+2yhzK6cIKZxcd3roQC8gsTKz75niNLz1RU 6G5ZX0bvJ7X+bTm07bOIw1Ac1ihgFw2zZBBXXMC+HINbTJQ7dhkhfNkhysi6FTTH2IeR pKCpHZPxV8xlavXds8VlDdjqT0maNk2gfEoHROl1NBpgpTnZs95otYOXTD2OYAxCizWI bB4fTTQayE5s/XgiPPD8PaZGL4KzHON+wgtdxehCO8EEHTSvIeDERBGQG7akAg2hKnCq vmIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id km11-20020a17090327cb00b001b9bebb66f8si2752231plb.367.2023.07.12.00.23.30; Wed, 12 Jul 2023 00:23:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231334AbjGLGsu (ORCPT + 99 others); Wed, 12 Jul 2023 02:48:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229660AbjGLGsj (ORCPT ); Wed, 12 Jul 2023 02:48:39 -0400 Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 828841982; Tue, 11 Jul 2023 23:48:37 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0VnBnpAi_1689144512; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0VnBnpAi_1689144512) by smtp.aliyun-inc.com; Wed, 12 Jul 2023 14:48:33 +0800 From: Yang Li To: stanley.chu@mediatek.com Cc: jejb@linux.ibm.com, martin.petersen@oracle.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, linux-scsi@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Yang Li , Abaci Robot Subject: [PATCH -next] scsi: ufs: ufs-mediatek: Remove surplus dev_err() Date: Wed, 12 Jul 2023 14:48:32 +0800 Message-Id: <20230712064832.44188-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771198610059737118 X-GMAIL-MSGID: 1771198610059737118 There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. ./drivers/ufs/host/ufs-mediatek.c:864:3-10: line 864 is redundant because platform_get_irq() already prints an error Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5846 Signed-off-by: Yang Li Reviewed-by: AngeloGioacchino Del Regno Acked-by: Sudeep Holla --- drivers/ufs/host/ufs-mediatek.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c index 786b1469eb52..b499eade957e 100644 --- a/drivers/ufs/host/ufs-mediatek.c +++ b/drivers/ufs/host/ufs-mediatek.c @@ -861,7 +861,6 @@ static void ufs_mtk_init_mcq_irq(struct ufs_hba *hba) irq = platform_get_irq(pdev, i + 1); if (irq < 0) { host->mcq_intr_info[i].irq = MTK_MCQ_INVALID_IRQ; - dev_err(hba->dev, "get platform mcq irq fail: %d\n", i); goto failed; } host->mcq_intr_info[i].hba = hba;