From patchwork Tue Jul 11 20:35:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 118714 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp748974vqm; Tue, 11 Jul 2023 14:22:28 -0700 (PDT) X-Google-Smtp-Source: APBJJlHvKdvrLmgDpxUfV7Fud2zTDHSXaUlwAxdrBlAQ+Htvcbdq2ipE48XXHq+mz3np0cB2aFwn X-Received: by 2002:a17:906:9a:b0:994:1956:2331 with SMTP id 26-20020a170906009a00b0099419562331mr2899604ejc.13.1689110547979; Tue, 11 Jul 2023 14:22:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689110547; cv=none; d=google.com; s=arc-20160816; b=OLEvzfUkWFbZ3/WEqRXuVUnql/gE1aFYDG4IIPda8sMdgS2sIPGkUD8gQY7zMf/LjM 5xa0fyF253qOZzNMbeYAMwdV61LN7KScx3jE2cCh0igUyWO2D33/2Vj9S1wHgQHq9FMD WL/PaofEXLKGViDz/5W7/fJuCh89UusW1rQ/zUg7Y9QkmiX1N6H2B3bkV7muXd22uIP2 wjNSsQ8UAJV2kFG5oVCIsSNiR8mas5VWYjazIsHluwvm1R/lAQCESzsSDWODolyUEKAQ OSoOkTvYjGKme1XVBQS7wTecbeMc5rZQ4QtIWeggzqiT8s+K2Mjx1AZklqrzZ18b/Ji8 RKWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DGh+uAGSNBabNs8otONzVd5nXL6Ue86FrE6lpV0zFTs=; fh=Wrx0eU9e8PjP+hpxVbWp9UHQJRv1Nm7z3/h6OVWHkvE=; b=RVHPK0LRGN/u6Xx7/hkxIk9rxkid8JXDKbJUQ829E0JvrwdF+0Hq96bsljZPreawQS DilxKCgrgBVXr+UDy5RFkKXthXQwJBTQ2TmkPznyQOLXz8bEHMMFQzT4/FejF87qz7qR PamLrkDKNfUMpMNtOHzIgDMh3QRs+YFe3+hfbgYmSFQt6gbxmkPgCL6RIMp4Q7aVbV6D ao+9Qrm7ZyXBhkeAmKous+QKs7/BIbeUk6ttUoMPJFT6F7AHBlx4lo7xQMvbTw+tYtfI wSATssFrGH8K3Zq6LGiKtUFHgdd+grd3tUlJ08AqsU27TxGwoAlAnqmQAgCN7dGwuONi B7zQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OArO2mzR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rs23-20020a170907037700b00988c552332fsi2671035ejb.300.2023.07.11.14.22.04; Tue, 11 Jul 2023 14:22:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OArO2mzR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231452AbjGKU7D (ORCPT + 99 others); Tue, 11 Jul 2023 16:59:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231416AbjGKU65 (ORCPT ); Tue, 11 Jul 2023 16:58:57 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5CA110DD for ; Tue, 11 Jul 2023 13:58:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689109092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DGh+uAGSNBabNs8otONzVd5nXL6Ue86FrE6lpV0zFTs=; b=OArO2mzRUq2d1CFg0i4WIQ5U3YuByW8RaWLGIKFJBVbRbjNs/7AsVnActh1bcApFbZlyTf iA4+ZnOQTbaXwzgiRhoMitrukylur3olLYwrHELMy9V3DXovDKOT+DpP4hUVgLqSXrGBqS skcqBbbMcaoKNztgJtlJyucvkZdnHWc= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-357-ucAPLURSP52NkkL9W8Wf1w-1; Tue, 11 Jul 2023 16:58:11 -0400 X-MC-Unique: ucAPLURSP52NkkL9W8Wf1w-1 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-5766e49b802so62819097b3.1 for ; Tue, 11 Jul 2023 13:58:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689109091; x=1691701091; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DGh+uAGSNBabNs8otONzVd5nXL6Ue86FrE6lpV0zFTs=; b=d7DqWwmqSJPbWTP2koUsSzJRMQv7YgeUnf88agzrDPXMenHIjYTASwoWbDniv+nDf1 Un8cPr6IoLPsIyvIemU20X4JvSbwWt4KArTCuRQ2xMLUnlYlMuPv5UryyNmUbMHUiNAI TaJjjsJaV+bRRu6jNAbLJhKma4ZsCq4IyD8jQisoq74IUbvSb7qp9w5Qg2Pejbe3LBZo uj/0E/bXNBMpI5KHd7msbBbUxomabcLlhDKGWTbzSGj4/306CJDg8XhRQ5S+2xnkN7kf XxQBJzmMagZ4Wg4CqzXwHMWOuK2IDJ6hFZgq3X+MKLCz8IRlVQZxSqXxlXbXVAFm22rp 25hw== X-Gm-Message-State: ABy/qLbaCxP1hjJ49Sklwql3U2+pVmuXS3RCGL4CGbyIKqL4TNH0fge6 9zQlhtZBHJEXovfYaYlOMwt5/MDZQqRnJGMkIHgF+mNI90etqTzhnrkdiWfSFM5UWYd1KMb++Mo XeYUuBS8gLD3G7iXANFwqM6/gNSlNrYnfqpAKAFG3YKZStd/kzTVgtpL8je4NGiRxiVAcZZ997+ x65ocr5YtC X-Received: by 2002:a0d:d851:0:b0:56d:5272:d540 with SMTP id a78-20020a0dd851000000b0056d5272d540mr15383351ywe.46.1689109090949; Tue, 11 Jul 2023 13:58:10 -0700 (PDT) X-Received: by 2002:a0d:d851:0:b0:56d:5272:d540 with SMTP id a78-20020a0dd851000000b0056d5272d540mr15383327ywe.46.1689109090644; Tue, 11 Jul 2023 13:58:10 -0700 (PDT) Received: from halaney-x13s.attlocal.net ([2600:1700:1ff0:d0e0::22]) by smtp.gmail.com with ESMTPSA id j136-20020a81928e000000b00545a08184cesm785353ywg.94.2023.07.11.13.58.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 13:58:10 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, mcoquelin.stm32@gmail.com, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, joabreu@synopsys.com, alexandre.torgue@foss.st.com, peppe.cavallaro@st.com, bhupesh.sharma@linaro.org, vkoul@kernel.org, linux-arm-msm@vger.kernel.org, jsuraj@qti.qualcomm.com, Andrew Halaney Subject: [PATCH RFC/RFT net-next 1/3] net: stmmac: Make ptp_clk_freq_config variable type explicit Date: Tue, 11 Jul 2023 15:35:30 -0500 Message-ID: <20230711205732.364954-2-ahalaney@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230711205732.364954-1-ahalaney@redhat.com> References: <20230711205732.364954-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771160781766295330 X-GMAIL-MSGID: 1771160781766295330 The priv variable is _always_ of type (struct stmmac_priv *), so let's stop using (void *) since it isn't abstracting anything. Signed-off-by: Andrew Halaney Reviewed-by: Simon Horman --- drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 3 +-- include/linux/stmmac.h | 4 +++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c index ab9f876b6df7..718bae6872da 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c @@ -257,9 +257,8 @@ static void intel_speed_mode_2500(struct net_device *ndev, void *intel_data) /* Program PTP Clock Frequency for different variant of * Intel mGBE that has slightly different GPO mapping */ -static void intel_mgbe_ptp_clk_freq_config(void *npriv) +static void intel_mgbe_ptp_clk_freq_config(struct stmmac_priv *priv) { - struct stmmac_priv *priv = (struct stmmac_priv *)npriv; struct intel_priv_data *intel_priv; u32 gpio_value; diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h index 06090538fe2d..c0cbcef1a2f0 100644 --- a/include/linux/stmmac.h +++ b/include/linux/stmmac.h @@ -76,6 +76,8 @@ | DMA_AXI_BLEN_32 | DMA_AXI_BLEN_64 \ | DMA_AXI_BLEN_128 | DMA_AXI_BLEN_256) +struct stmmac_priv; + /* Platfrom data for platform device structure's platform_data field */ struct stmmac_mdio_bus_data { @@ -245,7 +247,7 @@ struct plat_stmmacenet_data { int (*serdes_powerup)(struct net_device *ndev, void *priv); void (*serdes_powerdown)(struct net_device *ndev, void *priv); void (*speed_mode_2500)(struct net_device *ndev, void *priv); - void (*ptp_clk_freq_config)(void *priv); + void (*ptp_clk_freq_config)(struct stmmac_priv *priv); int (*init)(struct platform_device *pdev, void *priv); void (*exit)(struct platform_device *pdev, void *priv); struct mac_device_info *(*setup)(void *priv); From patchwork Tue Jul 11 20:35:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 118728 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp765808vqm; Tue, 11 Jul 2023 15:03:59 -0700 (PDT) X-Google-Smtp-Source: APBJJlGqWFYi9oLYH+krq3PoXjqBvgsWs8d6FgbaruRWL5f2eeSUrkb5AnMfKenF4+dmTz/kNutZ X-Received: by 2002:a05:6358:52c8:b0:134:cac4:b88f with SMTP id z8-20020a05635852c800b00134cac4b88fmr14893788rwz.16.1689113038883; Tue, 11 Jul 2023 15:03:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689113038; cv=none; d=google.com; s=arc-20160816; b=iO8nJZVDVQeEi/AAUrLyEnqJVg1RWZB9MZxmRKHNNIunNYiRCvGuCnqwSfnsfDN4sY ei9t/cQkgt6SNZRTMysbQj2QeZcFLVB0ukWSUzdQ9reMl2KjDGv+7De1AJgIex5II9tO Us9oGAfKAjK7YYfwB+bJu7bnPbBnRmAfR/gqZWm+4bhRPaZ2nZhm8bR/nbpvwZ0aWJ6n 7QBCkETkG6VxIq7hI7CxV7+aTge9emfZUWz1OsGS/+XiPkqyPn0lyBAJx5tjqAfsALgi evQpHfAeFL71k4/jQ6z5N/Ine5E26yE2/uFeSHN3qqje2onKSmJRVU92AzJaAkp4XlHp e3zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=jiBOM1KuLZEvS0bvIGnIKQCXCP0aV2NwdEa0u2AGH3g=; fh=Wrx0eU9e8PjP+hpxVbWp9UHQJRv1Nm7z3/h6OVWHkvE=; b=rmujEa/i5+/w8x6jFghPN3/xUFIpc/Ufc6t+ulS7na1LOX43XQyF+Hak8IgnuIZEx0 FzVcRY6sf2L02TAifwNFme/Pn4tswAPh18J/NiDwS4P/hv5dIVLGxeXgJ30aTrBeRN/9 GjyyYrShxaEEbVn41oYuH04eLxTg0vh59VWG+EKtr04bM0q4tj3qxxsU4xcT9uPIeDAR OdrOlfRxgovOq+2HID4fUcT/rgWUAqjPs9uXsYalQ70O4kXH5UkmX+L+/ofqrrb8DF38 lxBF/ui4qrJwsl/De6IAs7mZXkXQqneZHpZmDuGrc8W2GQ0Y282gh+icOcPLk9oGjoRi SgdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AWCIC7iZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b2-20020a6541c2000000b00553ad455581si1979802pgq.296.2023.07.11.15.03.45; Tue, 11 Jul 2023 15:03:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AWCIC7iZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231499AbjGKU7I (ORCPT + 99 others); Tue, 11 Jul 2023 16:59:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229742AbjGKU7E (ORCPT ); Tue, 11 Jul 2023 16:59:04 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F93210F2 for ; Tue, 11 Jul 2023 13:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689109097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jiBOM1KuLZEvS0bvIGnIKQCXCP0aV2NwdEa0u2AGH3g=; b=AWCIC7iZgMM4gxSEo5JVuLBoF8kebLFYBbML5+nUKK5KWCAtbSMMPO2a5EDFZBtCuNU2b6 Y5JTe9DdEHg9RGM08GmFYY8d32yciMsYaNZNk9fThrzeJJq6Hdzf+8rIJ9zlqOVpZq0+Hv 8lTIsCgv0MtrZA7cAAbd/M9ABTpWrYI= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-112-FB4yFPHPOjKdEjRLdDSumA-1; Tue, 11 Jul 2023 16:58:16 -0400 X-MC-Unique: FB4yFPHPOjKdEjRLdDSumA-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-56cf9a86277so68892817b3.3 for ; Tue, 11 Jul 2023 13:58:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689109095; x=1691701095; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jiBOM1KuLZEvS0bvIGnIKQCXCP0aV2NwdEa0u2AGH3g=; b=GNURucPaefzqDQ4Xxo852ZSbsRBqPMvj+X1mAORcywCaeixf0STUkV2hDCSCLRQnSc EN/gt4zDFkR++UKzXhgJSZTsOTB0PT0k7hEyoMcdvrjPxwagtuLXhFsd1hRhBaeEnKc6 UBUv8nV6Y/HRNR6JFeGGlvqC6HUNTJ2ylB3TUaV2xdUuSpBcyc3B+IUfbP5SICQy/A/H iUWvoj8hbYM1xhZm1mWwXkUPGpNkosNfPHpESgAa/PrUxbDOjzR5xWoPkeBrv17v6eYu dzEhp2omXJYNEftScIBhdeJGTwuLXl7SiuviVnfjETlV5sN2IMOsIiav1bqIO8gkK7IL FC3A== X-Gm-Message-State: ABy/qLa+E46n+Dd1+0DXcWQH+gfaasLOiUeRKZRMmD4c9pHtKvEr+Qh/ lUkTHMNFdrBqECzW2NSVid2GOz62zqnb7j3W4BioKwg8Y9kfdcLBVfubTO3GfIEeu7e2Ecx2fLj ForouAUT+XC9e8/b59pvd/fdo5aasIAbQhYxFL2KLLqVUkmWczsB3JAnrSKL02WQAUaTUtczxn4 W5jH3ywwUd X-Received: by 2002:a0d:dd0f:0:b0:55a:3ce9:dc3d with SMTP id g15-20020a0ddd0f000000b0055a3ce9dc3dmr16784179ywe.13.1689109095719; Tue, 11 Jul 2023 13:58:15 -0700 (PDT) X-Received: by 2002:a0d:dd0f:0:b0:55a:3ce9:dc3d with SMTP id g15-20020a0ddd0f000000b0055a3ce9dc3dmr16784156ywe.13.1689109095299; Tue, 11 Jul 2023 13:58:15 -0700 (PDT) Received: from halaney-x13s.attlocal.net ([2600:1700:1ff0:d0e0::22]) by smtp.gmail.com with ESMTPSA id j136-20020a81928e000000b00545a08184cesm785353ywg.94.2023.07.11.13.58.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 13:58:14 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, mcoquelin.stm32@gmail.com, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, joabreu@synopsys.com, alexandre.torgue@foss.st.com, peppe.cavallaro@st.com, bhupesh.sharma@linaro.org, vkoul@kernel.org, linux-arm-msm@vger.kernel.org, jsuraj@qti.qualcomm.com, Andrew Halaney Subject: [PATCH RFC/RFT net-next 2/3] net: stmmac: dwmac-qcom-ethqos: Use max frequency for clk_ptp_ref Date: Tue, 11 Jul 2023 15:35:31 -0500 Message-ID: <20230711205732.364954-3-ahalaney@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230711205732.364954-1-ahalaney@redhat.com> References: <20230711205732.364954-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771163393564170806 X-GMAIL-MSGID: 1771163393564170806 Qualcomm clocks can set their frequency to a variety of levels generally. Let's use the max for clk_ptp_ref to ensure the best timestamping resolution possible. Without this, the default value of the clock is used. For sa8775p-ride this is 19.2 MHz, far less than the 230.4 MHz possible. Signed-off-by: Andrew Halaney Reviewed-by: Simon Horman --- .../stmicro/stmmac/dwmac-qcom-ethqos.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 757504ebb676..f9e7440520fa 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -694,6 +694,23 @@ static void ethqos_clks_disable(void *data) ethqos_clks_config(data, false); } +static void ethqos_ptp_clk_freq_config(struct stmmac_priv *priv) +{ + struct plat_stmmacenet_data *plat_dat = priv->plat; + int err; + + if (!plat_dat->clk_ptp_ref) + return; + + /* Max the PTP ref clock out to get the best resolution possible */ + err = clk_set_rate(plat_dat->clk_ptp_ref, ULONG_MAX); + if (err) + netdev_err(priv->dev, "Failed to max out clk_ptp_ref: %d\n", err); + plat_dat->clk_ptp_rate = clk_get_rate(plat_dat->clk_ptp_ref); + + netdev_dbg(priv->dev, "PTP rate %d\n", plat_dat->clk_ptp_rate); +} + static int qcom_ethqos_probe(struct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; @@ -779,6 +796,7 @@ static int qcom_ethqos_probe(struct platform_device *pdev) plat_dat->bsp_priv = ethqos; plat_dat->fix_mac_speed = ethqos_fix_mac_speed; plat_dat->dump_debug_regs = rgmii_dump; + plat_dat->ptp_clk_freq_config = ethqos_ptp_clk_freq_config; plat_dat->has_gmac4 = 1; if (ethqos->has_emac_ge_3) plat_dat->dwmac4_addrs = &data->dwmac4_addrs; From patchwork Tue Jul 11 20:35:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 118715 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp750520vqm; Tue, 11 Jul 2023 14:26:21 -0700 (PDT) X-Google-Smtp-Source: APBJJlGT6gufsCpjkbCrV6eB497GE0o4BPWDaQU7OYEOMwR08fGdq26F5YWbK439sR8IjHiu/101 X-Received: by 2002:adf:fcca:0:b0:315:9de4:92f0 with SMTP id f10-20020adffcca000000b003159de492f0mr6258451wrs.5.1689110781600; Tue, 11 Jul 2023 14:26:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689110781; cv=none; d=google.com; s=arc-20160816; b=Jwzj4SUYkuK/4/TvjNlPKklxpaqg+i8sAmJWRefAYZ2YYTHntYMq6YKO/Bd1thEU47 y4axCWrL1aPhvoMn0QoiyiQqumB1llaku2EAyW6QPNqshxB5e8XlbsHaALYHw1ffuQey eLh8OjnFRNEi0o9EC8M2PRXCqV6cwmCKje7Dg+nkg4Legiwkj4p8h+QtML3vQt/8ykNb pYjRjbF6RQtt4Gq7fWDLPI81Wz8AbGBG2JoTwOj16WNc3i0oMMrZweGp/q++Mj+LOJYM eWVIBN1Jey7beyINIOQO1BH5//6+15hFeAC2cNiqAArAqwcAKkv/XlKnijO9VojPapfv wAAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=CvuwAv+s14TExJvbO2C4lPkzFf4n3yORaiUFHM896h4=; fh=Wrx0eU9e8PjP+hpxVbWp9UHQJRv1Nm7z3/h6OVWHkvE=; b=hHGYR15FvUVc/C4TjsIWYPqaQ4yGjyhATp6FcNGNZkLqCXSbFLcQw+RJaKPr8LRmor Krb2ZUNpCS5flWNn2X+Nev2luP9vYAJwIuSDxglKY74yCg2cbtae5cFdgWG3exKCfkIE 1GgSrqS+n6B5l/+Rx0VgN5WDyE22GtKr2mJy6i1cThYxSebUHLQujmO63fNqLKK91t7G l6xqx/+Thq91lWwVZKstw036RRoQXSwt+9THPy4Jec8pDwmBuDNLYX1/iL0Xr3NSUeKS fo3F8gusVXM29FCqC3sZYKapN0o4oY8L0zlZ9p7P7uV8C+n82uVR1HtALXXmWKpGAQ4e sCOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Y/Lgui9u"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x18-20020aa7dad2000000b0051e1c968863si2797705eds.259.2023.07.11.14.25.57; Tue, 11 Jul 2023 14:26:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Y/Lgui9u"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231534AbjGKU7Z (ORCPT + 99 others); Tue, 11 Jul 2023 16:59:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229964AbjGKU7U (ORCPT ); Tue, 11 Jul 2023 16:59:20 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE5861717 for ; Tue, 11 Jul 2023 13:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689109113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CvuwAv+s14TExJvbO2C4lPkzFf4n3yORaiUFHM896h4=; b=Y/Lgui9ubJXF5nrKscGx5T/loLitvsNg7YdCyZpCHDpKZCCs4GxDBYFuipnf6TSdz/HW3v FblgTQggCJgk2xEpu7mkTuVSKr8WFuAQq4tLdg5HqHljpmzFWaGovPs4jSpB5ZMCjupr0n ncJSdRrME9O5A90a30Ipvw54LS2bg9E= Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-DxIcTFoHPWiB8n97Hn9u2g-1; Tue, 11 Jul 2023 16:58:32 -0400 X-MC-Unique: DxIcTFoHPWiB8n97Hn9u2g-1 Received: by mail-oo1-f70.google.com with SMTP id 006d021491bc7-5667dddaa5cso3616678eaf.2 for ; Tue, 11 Jul 2023 13:58:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689109111; x=1691701111; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CvuwAv+s14TExJvbO2C4lPkzFf4n3yORaiUFHM896h4=; b=BDzmRirQZbNWY9OIHlMF2RKC0/0R3CS0MKih9+SDSo6ajG8Pp4H3xijqmCwkGjUUS9 KMNckmFD0wsfyQjqwj/cevRg3w7XBBtoDN1hjjsMANhgN6orbus2ThEb3k4mT3SmWryJ uWiFfMkA8Q8gtnQ6mNf8gyvPcMKXww3eocIrBiVfyVuNZnI+91AJE4kjJxyW6fNhEbm3 pz/EjRbHf0KzyC6HmX9VS2IviFjABT3HRDBS0mlQjt72gSAlo8nNInorJTMhGMaosMu0 CknXmWk7K4R1NANyqcht4RK4ay1VqUbKQNJUr13Jm/0DX81QwgjLWOiQcyuQ6rL8x5WU dokA== X-Gm-Message-State: ABy/qLZScGP5REX1IFuCxQUYQHzI8izeZE2Tpde9fkSbcp8h8ZkitUAJ w2H5KWRsy9CLFDsthnmoOky3TLKbUc3Ndzh4FxM7mL4ij5cSvHwC0vRgccnjNwd8NG9Er7KetYs glz2LQiCIVQzsTSebWUyc0LzPr31ND8/ewp5S07g9nBppkL4OxhKB5F4p7cIZl6BAQg4dkq4gIi HsUJSuo0K8 X-Received: by 2002:a05:6358:340b:b0:134:c4dc:2c4e with SMTP id h11-20020a056358340b00b00134c4dc2c4emr5573629rwd.23.1689109110832; Tue, 11 Jul 2023 13:58:30 -0700 (PDT) X-Received: by 2002:a05:6358:340b:b0:134:c4dc:2c4e with SMTP id h11-20020a056358340b00b00134c4dc2c4emr5573607rwd.23.1689109110337; Tue, 11 Jul 2023 13:58:30 -0700 (PDT) Received: from halaney-x13s.attlocal.net ([2600:1700:1ff0:d0e0::22]) by smtp.gmail.com with ESMTPSA id j136-20020a81928e000000b00545a08184cesm785353ywg.94.2023.07.11.13.58.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 13:58:30 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, mcoquelin.stm32@gmail.com, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, joabreu@synopsys.com, alexandre.torgue@foss.st.com, peppe.cavallaro@st.com, bhupesh.sharma@linaro.org, vkoul@kernel.org, linux-arm-msm@vger.kernel.org, jsuraj@qti.qualcomm.com, Andrew Halaney Subject: [PATCH RFC/RFT net-next 3/3] net: stmmac: Use the max frequency possible for clk_ptp_ref Date: Tue, 11 Jul 2023 15:35:32 -0500 Message-ID: <20230711205732.364954-4-ahalaney@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230711205732.364954-1-ahalaney@redhat.com> References: <20230711205732.364954-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771161026882376957 X-GMAIL-MSGID: 1771161026882376957 Using the max frequency allows for the best PTP timestamping resolution, so let's default to that. Signed-off-by: Andrew Halaney Reviewed-by: Simon Horman --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index 231152ee5a32..c9a27a71a3f4 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c @@ -602,6 +602,11 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac) plat->clk_ptp_ref = NULL; dev_info(&pdev->dev, "PTP uses main clock\n"); } else { + /* Get the best resolution possible */ + rc = clk_set_rate(plat->clk_ptp_ref, ULONG_MAX); + if (rc) + dev_err(&pdev->dev, + "Failed to set clk_ptp_ref rate: %d\n", rc); plat->clk_ptp_rate = clk_get_rate(plat->clk_ptp_ref); dev_dbg(&pdev->dev, "PTP rate %d\n", plat->clk_ptp_rate); }