From patchwork Tue Jul 11 08:12:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Xi Ruoyao X-Patchwork-Id: 118307 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp318671vqm; Tue, 11 Jul 2023 01:13:24 -0700 (PDT) X-Google-Smtp-Source: APBJJlEpNy4ftzvh7WH3wUv3vaztbGui+HDWjT/6TvoMdCQ10V6Tnr3XEAMwu3+i8Jv/1rrpt30W X-Received: by 2002:a05:6402:180e:b0:51e:e67:df4d with SMTP id g14-20020a056402180e00b0051e0e67df4dmr16370799edy.38.1689063203295; Tue, 11 Jul 2023 01:13:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689063203; cv=none; d=google.com; s=arc-20160816; b=H3sIYvOCV0wstxevbe6qqAayOtkO2WlK1Cqz5SdK7Px6KThmI5XEdgDOPQLW3YiWym PFthKqMFt2n4ELI84ii8CbmLwyp+Q2J1dyBEVD7pbXNAO5pu/Wtw4FBFJXxGgpZdK0J4 KOsISEZOfh2FG4IwGo4AnwL+diSDrlWoNK7UacWpGlnZ+8s8I8Hn0x7ldmHi6Rt0uSBW uhIvqTgV7qgj1P/4Jh9bI6QNiUmBwaLkRsWJ+9VPBJN6l6CaMveYMeuc4M0JUDfIHNOY sIcFKMDtoWuxRzcIMCty6Y9TBTj40yxE69kqABDsto/unLZwDu7zulEB65ZHOwzrYqwS wowQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:mime-version :user-agent:references:in-reply-to:date:cc:to:subject:message-id :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=+5XeLia7IDlZsqjX+99JX+OLmWqxOpTbiwNd2GGh0y8=; fh=sVfxoKcDn4dVZ1zSjuy/nM4pDBHe9zYe688xuHlnvyU=; b=0VEILSOmDQ6pAwmgOjOXxi/y6w8aoV5E99Kox6fQT5Myg0qS2kEZZ1PWc211I13rAs j+OooUnN+EKbIPTA1zWIjS+KvLddemawEAYsCRJxXrbYOM8I6y9BHmTRwUzZvQvC7Vkr 1zx8RusAglX5jD1ISVporyVu95RAUMpCj5ShQDweig/Li6qY1l3rXHTUTo4eIKq41Lzf gpBjRk+eN3Bmh+CQp6nGKP0PRl90pV2JO9VsMm3wc0xzRFpKD+IXY/ol7Gh9UfGetZ4o 93JbKvKWUDmv9SmXUSdIvWoWL12qJn0Pr0o+g6Yz/sgoU4W23UgMguVJQJKbvIJa+D8i 5ZEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=xpgfGw8M; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id e9-20020a50fb89000000b0051e10d0092esi1497092edq.485.2023.07.11.01.13.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 01:13:23 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=xpgfGw8M; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 222F3385771D for ; Tue, 11 Jul 2023 08:13:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 222F3385771D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1689063202; bh=+5XeLia7IDlZsqjX+99JX+OLmWqxOpTbiwNd2GGh0y8=; h=Subject:To:Cc:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=xpgfGw8MLvlKWlpBhhUViEc7EIcLA3B655/Eh/zASsuxQtS/r0p7uMIIEhcqGnUVK QuMulEwi7IS/3gYwDYAldkfupRIm9IwwOuBB6WtawxPiT6rm2sa12jJXbI8RSqi8S4 g5nCYjkjLPksxMEjOzmYZ6Jo32THmtHNW4xPTRQM= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id B6B823858CDA for ; Tue, 11 Jul 2023 08:12:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B6B823858CDA Received: from [IPv6:240e:358:11c0:7200:dc73:854d:832e:2] (unknown [IPv6:240e:358:11c0:7200:dc73:854d:832e:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 3DD25663DE; Tue, 11 Jul 2023 04:12:32 -0400 (EDT) Message-ID: <2a5b1036e11476a31c79b0c9d53cca3d7bbe7db2.camel@xry111.site> Subject: [PATCH pushed] testsuite: Unbreak pr110557.cc where long is 32-bit (was Re: Pushed: [PATCH v2] vect: Fix vectorized BIT_FIELD_REF for signed bit-fields [PR110557]) To: Prathamesh Kulkarni Cc: Richard Biener , gcc-patches@gcc.gnu.org, Andre Vieira , Jakub Jelinek , Hongtao Liu Date: Tue, 11 Jul 2023 16:12:26 +0800 In-Reply-To: References: <20230707131857.2386125-2-xry111@xry111.site> User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, LIKELY_SPAM_FROM, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Xi Ruoyao via Gcc-patches From: Xi Ruoyao Reply-To: Xi Ruoyao Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771111137235903262 X-GMAIL-MSGID: 1771111137235903262 On Tue, 2023-07-11 at 13:04 +0530, Prathamesh Kulkarni wrote: /* snip */ > Hi Xi, > Your commit: > https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=63ae6bc60c0f67fb2791991bf4b6e7e0a907d420, > > seems to cause following regressions on arm-linux-gnueabihf: > FAIL: g++.dg/vect/pr110557.cc  -std=c++98 (test for excess errors) > FAIL: g++.dg/vect/pr110557.cc  -std=c++14 (test for excess errors) > FAIL: g++.dg/vect/pr110557.cc  -std=c++17 (test for excess errors) > FAIL: g++.dg/vect/pr110557.cc  -std=c++20 (test for excess errors) > > Excess error: > gcc/testsuite/g++.dg/vect/pr110557.cc:12:8: warning: width of > 'Item::y' exceeds its type Ah sorry, I didn't consider ports with 32-bit long. The attached patch should fix the issue. It has been tested and pushed r14-2427 and r13-7555. From 312839653b8295599c63cae90278a87af528edad Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Tue, 11 Jul 2023 15:55:54 +0800 Subject: [PATCH] testsuite: Unbreak pr110557.cc where long is 32-bit On ports with 32-bit long, the test produced excess errors: gcc/testsuite/g++.dg/vect/pr110557.cc:12:8: warning: width of 'Item::y' exceeds its type Reported-by: Prathamesh Kulkarni gcc/testsuite/ChangeLog: * g++.dg/vect/pr110557.cc: Use long long instead of long for 64-bit type. (test): Remove an unnecessary cast. --- gcc/testsuite/g++.dg/vect/pr110557.cc | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/gcc/testsuite/g++.dg/vect/pr110557.cc b/gcc/testsuite/g++.dg/vect/pr110557.cc index e1fbe1caac4..effb67e2df3 100644 --- a/gcc/testsuite/g++.dg/vect/pr110557.cc +++ b/gcc/testsuite/g++.dg/vect/pr110557.cc @@ -1,7 +1,9 @@ // { dg-additional-options "-mavx" { target { avx_runtime } } } -static inline long -min (long a, long b) +typedef long long i64; + +static inline i64 +min (i64 a, i64 b) { return a < b ? a : b; } @@ -9,16 +11,16 @@ min (long a, long b) struct Item { int x : 8; - long y : 55; + i64 y : 55; bool z : 1; }; -__attribute__ ((noipa)) long +__attribute__ ((noipa)) i64 test (Item *a, int cnt) { - long size = 0; + i64 size = 0; for (int i = 0; i < cnt; i++) - size = min ((long)a[i].y, size); + size = min (a[i].y, size); return size; } -- 2.41.0