From patchwork Sat Jul 8 08:40:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Cercueil X-Patchwork-Id: 117410 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3790090vqx; Sat, 8 Jul 2023 01:44:40 -0700 (PDT) X-Google-Smtp-Source: APBJJlESDW2ZCpm02w5WHnOaFI4szkBv1NB8JSUuYye6izEsMa4l6BUkKoB8Mzfg6vOHQm7pDmKg X-Received: by 2002:a05:6870:d626:b0:18e:af01:ad93 with SMTP id a38-20020a056870d62600b0018eaf01ad93mr11172213oaq.58.1688805879970; Sat, 08 Jul 2023 01:44:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688805879; cv=none; d=google.com; s=arc-20160816; b=0EjOTeQFIvA87SoRmwa7sCBpkGi2ZC8vuZq0zcfF8pekxqW7bZYQ6nSzKzdJc4vh1h OA7cG/+R6BYJis370sBOMk35xLQ6ZKKoC09ddnongnVPsfMfM9V752MAQxRK7nioIlfN hN3jbLwnjOOD5TEkzTTZu/aT2lOXuTEU5m1JWreEmp81p4GAozUFpZOUi09SQaRVYEIc QHh0HhWx4gLfGWPN3uOJJ/LaHpbpKVfPMHDYHIg0bE++/qbgGYhXmrr1dAH+nx/KQTDf GxcGCLYyJgd45GxKJWt+Bmsdg/GvWI3py12EwRz6a1tkSTv+7X5GMCE4tDqCaxEgFCZb Th+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NhoqtqxyhPtY8CBHiEHyPDLJNhjPqQS0txLNegyEoqo=; fh=GfEWQRzWO44/ZqMRUP2UsrVMvN7HmpojWFUpmGyXMTg=; b=W04E4M8lM5j+MwdFeskeUGAcm7aKLVQe8M6f5s4dGmQazGfUj7KJ3E5RJKLFAQqSOD doxy59TkGli+7uYHnSdf473cGSWuGx3vFN1Hwnu6R3pQAqEfPGi1CTjr0N/krDAJb91Y rSN27a6uwHrqYiuuO/nQjG6EKAWDpz7VDslexAogIkO+g9m1YIxgK5mxWVtOz0e9633r upH56mWKClfJCCaLZo9+Nx2YoNzB1kMHL+RKXhAFKZNBwrJQj8nRUCtShF0UD6JOqzdQ Q8Ura2llhfimnVkKMlBGX9+gM++4Ccixu4VfXdM9bY/W6IlbD5wT9ZRXdsfoLMVWofJz KVXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=qpGNnr2X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id np9-20020a17090b4c4900b00263cdc45e8bsi4513616pjb.87.2023.07.08.01.44.26; Sat, 08 Jul 2023 01:44:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=qpGNnr2X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229899AbjGHIku (ORCPT + 99 others); Sat, 8 Jul 2023 04:40:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229723AbjGHIkt (ORCPT ); Sat, 8 Jul 2023 04:40:49 -0400 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18B01FF; Sat, 8 Jul 2023 01:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1688805637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NhoqtqxyhPtY8CBHiEHyPDLJNhjPqQS0txLNegyEoqo=; b=qpGNnr2XiVksOlNWj1Q+pnXybM//PE1W9vZvc0vlTKXAmf9O/Mu6NxHBtJgIsYSOz9hGLo z0+Gb7Nmmq6b9V6zv4xDoUIsYoP8GPhZn47yHI6HH4x9Fn8zUaAuYW1WeHx75DTAntw1Zv 5xnGtBGQtubzsAeJS38w5UhF2BWBUzA= From: Paul Cercueil To: Krzysztof Kozlowski , Rob Herring , Conor Dooley , Alim Akhtar , Neil Armstrong , Sam Ravnborg Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Paul Cercueil Subject: [PATCH v2 1/3] drm/panel: ld9040: Use better magic values Date: Sat, 8 Jul 2023 10:40:25 +0200 Message-Id: <20230708084027.18352-2-paul@crapouillou.net> In-Reply-To: <20230708084027.18352-1-paul@crapouillou.net> References: <20230708084027.18352-1-paul@crapouillou.net> MIME-Version: 1.0 X-Spam: Yes X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770841314425069862?= X-GMAIL-MSGID: =?utf-8?q?1770841314425069862?= I have no idea what the prior magic values mean, and I have no idea what my replacement (extracted from [1]) magic values mean. What I do know, is that these new values result in a much better picture, where the blacks are really black (as you would expect on an AMOLED display) instead of grey-ish. [1]: https://github.com/dorimanx/Dorimanx-SG2-I9100-Kernel/blob/master-jelly-bean/arch/arm/mach-exynos/u1-panel.h v2: Remove spurious new line Signed-off-by: Paul Cercueil Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-samsung-ld9040.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-ld9040.c b/drivers/gpu/drm/panel/panel-samsung-ld9040.c index 01eb211f32f7..f39f999c21af 100644 --- a/drivers/gpu/drm/panel/panel-samsung-ld9040.c +++ b/drivers/gpu/drm/panel/panel-samsung-ld9040.c @@ -180,15 +180,15 @@ static void ld9040_init(struct ld9040 *ctx) { ld9040_dcs_write_seq_static(ctx, MCS_USER_SETTING, 0x5a, 0x5a); ld9040_dcs_write_seq_static(ctx, MCS_PANEL_CONDITION, - 0x05, 0x65, 0x96, 0x71, 0x7d, 0x19, 0x3b, 0x0d, - 0x19, 0x7e, 0x0d, 0xe2, 0x00, 0x00, 0x7e, 0x7d, - 0x07, 0x07, 0x20, 0x20, 0x20, 0x02, 0x02); + 0x05, 0x5e, 0x96, 0x6b, 0x7d, 0x0d, 0x3f, 0x00, + 0x00, 0x32, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x07, 0x05, 0x1f, 0x1f, 0x1f, 0x00, 0x00); ld9040_dcs_write_seq_static(ctx, MCS_DISPCTL, - 0x02, 0x08, 0x08, 0x10, 0x10); + 0x02, 0x06, 0x0a, 0x10, 0x10); ld9040_dcs_write_seq_static(ctx, MCS_MANPWR, 0x04); ld9040_dcs_write_seq_static(ctx, MCS_POWER_CTRL, 0x0a, 0x87, 0x25, 0x6a, 0x44, 0x02, 0x88); - ld9040_dcs_write_seq_static(ctx, MCS_ELVSS_ON, 0x0d, 0x00, 0x16); + ld9040_dcs_write_seq_static(ctx, MCS_ELVSS_ON, 0x0f, 0x00, 0x16); ld9040_dcs_write_seq_static(ctx, MCS_GTCON, 0x09, 0x00, 0x00); ld9040_brightness_set(ctx); ld9040_dcs_write_seq_static(ctx, MIPI_DCS_EXIT_SLEEP_MODE); From patchwork Sat Jul 8 08:40:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Cercueil X-Patchwork-Id: 117411 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3790695vqx; Sat, 8 Jul 2023 01:46:24 -0700 (PDT) X-Google-Smtp-Source: APBJJlE2PEhPSn8fqFHXhuYi4F/y7M8iZjUs5Uz6ERrW6G2denRzpBNRf8dgF4BlrWqm+GwV49vN X-Received: by 2002:a05:6a20:6a1e:b0:12f:b678:92c9 with SMTP id p30-20020a056a206a1e00b0012fb67892c9mr14142155pzk.14.1688805984411; Sat, 08 Jul 2023 01:46:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688805984; cv=none; d=google.com; s=arc-20160816; b=SVsDW3hfi9SCmY89or8Lq6csn5LX5pU75zAZb7/qZKtsm+oxVxVsiT8PiVShEOsTcb ufpBXIiR/It1iYbFGBNDV/OuG+5XpHfDOR/FJin/BjJM3e2YsWfiTTcKMxfpO6Sr0Mvl CIdUtchYP7koYIDx229ABIYRJdZ4CPnluqFv4LgjWJQPbfHAC8xL0B+NrKJzu1Owpu5D ZDLqbDvMjXYBqHxpjN458MwU+JULB0QVZRFmMJGR7LdCK+OVW+dCmCSILd7/+YXjdb4R 57xgvFz2zShAbQ4k1LiKfXLgTHt6Yf+8m/hdxEi/Hi3QccOw/saDoN+DYksH9XJogra4 KGmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6+AqvnlESMt4eGXysB+WU7X0HzVbXxlbD86pN2OtT+U=; fh=GfEWQRzWO44/ZqMRUP2UsrVMvN7HmpojWFUpmGyXMTg=; b=JFwqBelp4FSPCGWTqhtQOQaqGqYNkTr1nNE9FWJdiOwN3/Ck7Ma7wA7qNzF/pHfHp5 qn9V8keBeSy9f5qEEh6b9ayqIbKlqx4qDDDiZGNodBvEko0NmX4f0d9jWzTtAf668ufe SVkD+hQu0AnLm8gIy9w7wFYujfdQrcXqBl8WFSftG6CFO9h3xM/dscgvl0C9AemD0Dd4 Z+OeypHwYQSd9UdmTGOSS7nmbBz+HqL9CQYU1xhCQ/sTvp+v4pByCAoE/+N5KX3xqZ3P n2Jk1o4g7qYWuh4aNTghddv7Rcw90F5nP//1kSXOjuf5jOBllusCvId4fN5PhARmE68g h51Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=JsxMJzck; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bv192-20020a632ec9000000b0054fd9e9b862si5511639pgb.232.2023.07.08.01.46.12; Sat, 08 Jul 2023 01:46:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=JsxMJzck; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229773AbjGHIk7 (ORCPT + 99 others); Sat, 8 Jul 2023 04:40:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229876AbjGHIk5 (ORCPT ); Sat, 8 Jul 2023 04:40:57 -0400 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEEB61FE0; Sat, 8 Jul 2023 01:40:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1688805640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6+AqvnlESMt4eGXysB+WU7X0HzVbXxlbD86pN2OtT+U=; b=JsxMJzckQmaOdeCcP31JQuVyvWP+HhcsEyUShqxfnLig35BdIwL/wTBtZWhB5LtEy097js cuLkcV+mVyOazDjsDHTHtJv527lJtX/3ObpoQWYoPtp1nPQA4c1bUb0ilS2cF1Ii5kXdxK japyWh109wRYEGhkst2nKHWeYYSnnc8= From: Paul Cercueil To: Krzysztof Kozlowski , Rob Herring , Conor Dooley , Alim Akhtar , Neil Armstrong , Sam Ravnborg Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Paul Cercueil Subject: [PATCH v2 2/3] drm/panel: ld9040: Register a backlight device Date: Sat, 8 Jul 2023 10:40:26 +0200 Message-Id: <20230708084027.18352-3-paul@crapouillou.net> In-Reply-To: <20230708084027.18352-1-paul@crapouillou.net> References: <20230708084027.18352-1-paul@crapouillou.net> MIME-Version: 1.0 X-Spam: Yes X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770841424203587642?= X-GMAIL-MSGID: =?utf-8?q?1770841424203587642?= Register a backlight device to be able to switch between all the gamma levels. v2: Remove .get_brightness() callback, use bl_get_data() and backlight_get_brightness() Signed-off-by: Paul Cercueil --- drivers/gpu/drm/panel/panel-samsung-ld9040.c | 32 +++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-ld9040.c b/drivers/gpu/drm/panel/panel-samsung-ld9040.c index f39f999c21af..ad5ed635f592 100644 --- a/drivers/gpu/drm/panel/panel-samsung-ld9040.c +++ b/drivers/gpu/drm/panel/panel-samsung-ld9040.c @@ -8,6 +8,7 @@ * Andrzej Hajda */ +#include #include #include #include @@ -310,8 +311,30 @@ static int ld9040_parse_dt(struct ld9040 *ctx) return 0; } +static int ld9040_bl_update_status(struct backlight_device *dev) +{ + struct ld9040 *ctx = bl_get_data(dev); + + ctx->brightness = backlight_get_brightness(dev); + ld9040_brightness_set(ctx); + + return 0; +} + +static const struct backlight_ops ld9040_bl_ops = { + .update_status = ld9040_bl_update_status, +}; + +static const struct backlight_properties ld9040_bl_props = { + .type = BACKLIGHT_RAW, + .scale = BACKLIGHT_SCALE_NON_LINEAR, + .max_brightness = ARRAY_SIZE(ld9040_gammas) - 1, + .brightness = ARRAY_SIZE(ld9040_gammas) - 1, +}; + static int ld9040_probe(struct spi_device *spi) { + struct backlight_device *bldev; struct device *dev = &spi->dev; struct ld9040 *ctx; int ret; @@ -323,7 +346,7 @@ static int ld9040_probe(struct spi_device *spi) spi_set_drvdata(spi, ctx); ctx->dev = dev; - ctx->brightness = ARRAY_SIZE(ld9040_gammas) - 1; + ctx->brightness = ld9040_bl_props.brightness; ret = ld9040_parse_dt(ctx); if (ret < 0) @@ -353,6 +376,13 @@ static int ld9040_probe(struct spi_device *spi) drm_panel_init(&ctx->panel, dev, &ld9040_drm_funcs, DRM_MODE_CONNECTOR_DPI); + + bldev = devm_backlight_device_register(dev, dev_name(dev), dev, + ctx, &ld9040_bl_ops, + &ld9040_bl_props); + if (IS_ERR(bldev)) + return PTR_ERR(bldev); + drm_panel_add(&ctx->panel); return 0; From patchwork Sat Jul 8 08:40:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Cercueil X-Patchwork-Id: 117412 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3795180vqx; Sat, 8 Jul 2023 01:58:37 -0700 (PDT) X-Google-Smtp-Source: APBJJlGb1sUQeXBCCsRfrDKvm/hqcOmiXLb40RKxEBaRqpPZzWy5Iui/TmtziASgr8b8GMMr3bAu X-Received: by 2002:a05:6402:1a33:b0:51b:df14:594e with SMTP id be19-20020a0564021a3300b0051bdf14594emr5415774edb.39.1688806716739; Sat, 08 Jul 2023 01:58:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688806716; cv=none; d=google.com; s=arc-20160816; b=EZObMMAa/bPfObPEe6JDKlXYD6IXtQqZi61PJZLXE0IMultaA6RNHBzapZnuhzIdnX WO5Bts4J//IU1gX208LG06WaWgS/qxe9kifICVyExJWw5AwJrCvdDPsldYJRKBN9KB2j mLUwfOJp86Y9PzXQ1lPGoWpeO9GgOqW48WBCky73C/qjCEOvYKL/raXB5vylyGonDfsN H4jL0++WmKW6osXBhDKb21w4uNke0NyNhYqP3BnO0rFJvnvDN6ZJx8hzyW59tlyz394X wFqzGqB5cO3WSrpvau/EX5G8kQrVW5AmtOfMPO1tcRgN0I4SUmCuoaUa6RGj4rmaiRpj Izhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WirPH1rGCBNSwdNcVLcYapLshg/0Im7Zm/a2Plr7i4M=; fh=f1Xbhg+XXir6LkY+JcvZdgC1ubfoYPkHOkuWGz1+t0U=; b=jjWPdQZhPZvZsS58OHxn4v8yfGRf//gbK8Ay2J79aBJc1l/4nZ+xemU+IWlqIWxdm6 +QaDHpqoOfYVfQWmH3/pH0VrqXZNtF1iRsyiUF+BDpI4b4LdNfDjNwPiXGYIoPs/rrzg 6Ih+nW4cWFClMqF0rWTd8s3aKMNYh0ts2VxBm0X2FxUJ8gJCUXMw5w/FpyUzVCiWkwDG XazDDKKAVkgTtKn561ZjgPPDjBY79N/l/ApxUScQl0yMZ5jEWUJORfLEl/AkmWK1J+yA c+gAzH7Kl+QeZrp3bMcvS6YQghhM3WaHlIQBF4itMI2gbGAptZel8EzTubm/PRXttAgN UBtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b="rK/oWbmB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b3-20020a05640202c300b0051de3779436si3163050edx.454.2023.07.08.01.58.11; Sat, 08 Jul 2023 01:58:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b="rK/oWbmB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229627AbjGHIlP (ORCPT + 99 others); Sat, 8 Jul 2023 04:41:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbjGHIlN (ORCPT ); Sat, 8 Jul 2023 04:41:13 -0400 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8B6A268C; Sat, 8 Jul 2023 01:41:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1688805642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WirPH1rGCBNSwdNcVLcYapLshg/0Im7Zm/a2Plr7i4M=; b=rK/oWbmBJv/Ltz0ypARywuPgkeXGSgrmc9NsjeXHTQ9BcPUDJwZ7JVLxiftY9etLvKoO7x BTN8Rmm/t1HYw83LCDLCI0o8m3mO1yPHjojz2lzjedEUaFzRBV4R7whXiN1U9L/M/lt7+C vEKakKwEMNOBH3p0yVtTDjFBKzOp2O8= From: Paul Cercueil To: Krzysztof Kozlowski , Rob Herring , Conor Dooley , Alim Akhtar , Neil Armstrong , Sam Ravnborg Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Paul Cercueil , stable@vger.kernel.org Subject: [PATCH v2 3/3] ARM: dts: exynos/i9100: Fix LCD screen's physical size Date: Sat, 8 Jul 2023 10:40:27 +0200 Message-Id: <20230708084027.18352-4-paul@crapouillou.net> In-Reply-To: <20230708084027.18352-1-paul@crapouillou.net> References: <20230708084027.18352-1-paul@crapouillou.net> MIME-Version: 1.0 X-Spam: Yes X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770842191781738290?= X-GMAIL-MSGID: =?utf-8?q?1770842191781738290?= The previous values were completely bogus, and resulted in the computed DPI ratio being much lower than reality, causing applications and UIs to misbehave. The new values were measured by myself with a ruler. Signed-off-by: Paul Cercueil Fixes: 8620cc2f99b7 ("ARM: dts: exynos: Add devicetree file for the Galaxy S2") Cc: # v5.8+ --- arch/arm/boot/dts/exynos4210-i9100.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/exynos4210-i9100.dts b/arch/arm/boot/dts/exynos4210-i9100.dts index 37cd4dde53e4..a9ec1f6c1dea 100644 --- a/arch/arm/boot/dts/exynos4210-i9100.dts +++ b/arch/arm/boot/dts/exynos4210-i9100.dts @@ -207,8 +207,8 @@ lcd@0 { power-on-delay = <10>; reset-delay = <10>; - panel-width-mm = <90>; - panel-height-mm = <154>; + panel-width-mm = <56>; + panel-height-mm = <93>; display-timings { timing {