From patchwork Fri Jul 7 13:58:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 117143 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3291635vqx; Fri, 7 Jul 2023 07:04:10 -0700 (PDT) X-Google-Smtp-Source: APBJJlHZQsPW8kh97ClAWd2ZLrFXTQmzsDZctlbPxFnmGjJRajweR8POehG6Iq+/2g4nhtkO6a5j X-Received: by 2002:a17:903:249:b0:1b5:642e:139d with SMTP id j9-20020a170903024900b001b5642e139dmr5393128plh.10.1688738650312; Fri, 07 Jul 2023 07:04:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688738650; cv=none; d=google.com; s=arc-20160816; b=DkMdgPfuj+0KOL86drBMMjw2dqeUu2HhhTWy52b34JlEpfLXhfyqTeL1W4RiGbGzK0 W9SOGccSdBQ8mmGhCv6g5X1WgmD8w52Ov6bcx6c5Uy80bGVIWtgMaE0g+5WdTU/WfJDr HfyEtuTKk4/bj1cs7BYQK3cUdsZJlHCsGpHr31rizKGjgQq4XZHxxvhP3XcoFwpUtbg/ F3BGNLVEU80Tr673qCv/4pRMUuPQIFzs79elAW8SKX7lorVjkWfoJW2lMAoTgVDkK7Vt 06VVkMj0X+JIO8SM687lIxd4LgVwpGN9nNtDcUD7EDrtzbmSwxNnzuzeRk9Th3MWctOb jlRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=MGtpw5Ijohgjr845woqe5tjbTFDfrclnX+uXDY4qJTo=; fh=iJCXvx/q4VcaO+2Is+LEQyK9cldWNVVgSrYDuvcEfV0=; b=jShsUPcppXgkZAvHWn6n4oj5WdOuHUmy/srOYlY7e1ALJB+afOg3wywwnyC20dmKjB 8wv5qhKGketn0UlCb+1qBeBbFoGQ3JD5poetSae2SWAdh56JmD3yWNiq/iH3HheIZ0u7 c3qFFUdWhg89SCaCboxK8IVaRDOt56IdYqJBH7tEVSSjKckWpIptlrOQ6go+w7EviZvP l5v7ZPwxn1+KmNNVDKCrk9wgHGkwJ653IkH+WNN/mueYfEOnmIXMZu9Ju9v5bLh2Q9oI Isvs3urzBW5WwFuli5+270xL6HqBX0AycLOZcklg667bZBnxuhUEsPGma+y+H6t6YUN7 VEZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BJBZAcSi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lg15-20020a170902fb8f00b001b69bc74fd7si2830151plb.157.2023.07.07.07.03.49; Fri, 07 Jul 2023 07:04:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BJBZAcSi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229747AbjGGOAV (ORCPT + 99 others); Fri, 7 Jul 2023 10:00:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232505AbjGGOAR (ORCPT ); Fri, 7 Jul 2023 10:00:17 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB2B71FE6 for ; Fri, 7 Jul 2023 06:59:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688738370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MGtpw5Ijohgjr845woqe5tjbTFDfrclnX+uXDY4qJTo=; b=BJBZAcSiy+0owhFXivnV6MZ0Fl7AmIiZxe/1Bn2g2ze82cMhIBNusJ3+WPlITRJehjDarU fGe/lLCENMxpuyzMRquPIyRJrhqRc6q0DhY8wlIWaRnE4HT+e8/YKfvF4FAQ9OkQlUIXpt Bs4d0k7KGge7mV+MT082soqDOBjHi2o= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-91-jdBeycFfMpWPcS0WdIfb0g-1; Fri, 07 Jul 2023 09:59:27 -0400 X-MC-Unique: jdBeycFfMpWPcS0WdIfb0g-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7A140185A791; Fri, 7 Jul 2023 13:59:26 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-39.pek2.redhat.com [10.72.12.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3BEDF2166B25; Fri, 7 Jul 2023 13:59:10 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, schnelle@linux.ibm.com, vkoul@kernel.org, eli.billauer@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, derek.kiernan@amd.com, dragan.cvetic@amd.com, linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com, linus.walleij@linaro.org, tsbogend@alpha.franken.de, joyce.ooi@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, tglx@linutronix.de, maz@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, frowand.list@gmail.com, Baoquan He , kernel test robot , dmaengine@vger.kernel.org Subject: [PATCH 1/8] idmaengine: make FSL_EDMA and INTEL_IDMA64 depends on HAS_IOMEM Date: Fri, 7 Jul 2023 21:58:45 +0800 Message-Id: <20230707135852.24292-2-bhe@redhat.com> In-Reply-To: <20230707135852.24292-1-bhe@redhat.com> References: <20230707135852.24292-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770770819015792577?= X-GMAIL-MSGID: =?utf-8?q?1770770819015792577?= On s390 systems (aka mainframes), it has classic channel devices for networking and permanent storage that are currently even more common than PCI devices. Hence it could have a fully functional s390 kernel with CONFIG_PCI=n, then the relevant iomem mapping functions [including ioremap(), devm_ioremap(), etc.] are not available. Here let FSL_EDMA and INTEL_IDMA64 depend on HAS_IOMEM so that it won't be built to cause below compiling error if PCI is unset. -------- ERROR: modpost: "devm_platform_ioremap_resource" [drivers/dma/fsl-edma.ko] undefined! ERROR: modpost: "devm_platform_ioremap_resource" [drivers/dma/idma64.ko] undefined! -------- Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ Signed-off-by: Baoquan He Cc: Vinod Koul Cc: dmaengine@vger.kernel.org --- drivers/dma/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 644c188d6a11..08fdd0e2ed1b 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -211,6 +211,7 @@ config FSL_DMA config FSL_EDMA tristate "Freescale eDMA engine support" depends on OF + depends on HAS_IOMEM select DMA_ENGINE select DMA_VIRTUAL_CHANNELS help @@ -280,6 +281,7 @@ config IMX_SDMA config INTEL_IDMA64 tristate "Intel integrated DMA 64-bit support" + depends on HAS_IOMEM select DMA_ENGINE select DMA_VIRTUAL_CHANNELS help From patchwork Fri Jul 7 13:58:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 117163 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3315785vqx; Fri, 7 Jul 2023 07:38:43 -0700 (PDT) X-Google-Smtp-Source: APBJJlF4OOEfYcmrBQnoSjc/J3PRZ7fjdRlm2/kAxBPfl6Dw8nP/4yDw4IvqAgajNbvfu1bOdM1f X-Received: by 2002:a05:6512:78b:b0:4fb:8aeb:d9be with SMTP id x11-20020a056512078b00b004fb8aebd9bemr4002087lfr.30.1688740723152; Fri, 07 Jul 2023 07:38:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688740723; cv=none; d=google.com; s=arc-20160816; b=rV7nlXV2txv1CpYKLXw0CC7Z6OWjdZktz0yAdIhpWKGksGoBpatkh2gy/5EH/DFi5Z Cvk8DeMRDOzvsIO/QXWf+Cv4gGnzJWqOEsdy2XXmR8eF6C8M/9Vyy8Nzh0c0DtouIib8 uyQku+2sCSDRjfKu1gFBkoFR+4Pfq6cZSTGseN5wLc1jowzhXADdzTxQpJz8fUjyENsx sR8dicDq3qmCn5nBzINpZ4YazDGc+oMojOSoYHagCsZUPAc1RyE/OSKT8TbrWxCahzn/ gmMHaUtsrRnyMykYV4+4Y1jISZc43wV3hf5YvKN4MBxRka2oC20RlrcbgWMjJrMX6yac uIHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=CxwA3DJ3ViKIdzagr2m8kE8L4GOotWrmViZBn3jHWi4=; fh=INcnS+yX2NBDfIB23aYzu5gfxH1rW6lB53wHwdUYBVs=; b=yHgL7y8vTXnQtv7QfKvcEZL/B7nsnWKGNRIGAspkb0J6zaDf3FllO652YCKIxYZt0u 2R94QhK5jV1fX43ZP8rIXMPGjAH//2sSXm3i0cxdZmgmjErntB3zxYJSEpcDuYIVPXaa X09MmCcsm17A55f+1whnmTFdqvX2w0FAnQVuRzCOYO4yEjpYOZSel5Yl+arLRE2cxIyE dem6S9Y6pe88dY9Pr10601ZxH8ZX9tRp5rYiohTYgK1qPVjdarwkRRvaZzJjvpCom3Ds 0JjpxgqXlM1VzBJGpNguTuFH1UGHJINKwOKpIok4UNQo0UgQ4Xt6CYo6028U3rf/B2J6 ox8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=E9ceHwCt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g7-20020aa7c587000000b0051daf7e6305si2350425edq.167.2023.07.07.07.38.19; Fri, 07 Jul 2023 07:38:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=E9ceHwCt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232566AbjGGOAh (ORCPT + 99 others); Fri, 7 Jul 2023 10:00:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232560AbjGGOAd (ORCPT ); Fri, 7 Jul 2023 10:00:33 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87578210C for ; Fri, 7 Jul 2023 06:59:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688738385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CxwA3DJ3ViKIdzagr2m8kE8L4GOotWrmViZBn3jHWi4=; b=E9ceHwCtwY9o96nGyBIRReCvNqol+0Okh2ul7hfLtrvb1B405HPNCXBCRdJkV8udr1wgY+ xIZWxE47i1SUA6ZcUFhcC5vgb6811iN3uV0BM8b2VNgPvLj9RmiIH6s14k408hsYBqP/EB GJSCnlpXCuqQs6IFwM6KQB0EB/HZx9E= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-660-K_nqMDSSN4WPFTDThD3jNA-1; Fri, 07 Jul 2023 09:59:40 -0400 X-MC-Unique: K_nqMDSSN4WPFTDThD3jNA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 60093856F66; Fri, 7 Jul 2023 13:59:39 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-39.pek2.redhat.com [10.72.12.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4677C2166B25; Fri, 7 Jul 2023 13:59:26 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, schnelle@linux.ibm.com, vkoul@kernel.org, eli.billauer@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, derek.kiernan@amd.com, dragan.cvetic@amd.com, linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com, linus.walleij@linaro.org, tsbogend@alpha.franken.de, joyce.ooi@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, tglx@linutronix.de, maz@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, frowand.list@gmail.com, Baoquan He , kernel test robot Subject: [PATCH 2/8] char: xillybus: make XILLYBUS_OF depend on HAS_IOMEM Date: Fri, 7 Jul 2023 21:58:46 +0800 Message-Id: <20230707135852.24292-3-bhe@redhat.com> In-Reply-To: <20230707135852.24292-1-bhe@redhat.com> References: <20230707135852.24292-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770772992458020191?= X-GMAIL-MSGID: =?utf-8?q?1770772992458020191?= On s390 systems (aka mainframes), it has classic channel devices for networking and permanent storage that are currently even more common than PCI devices. Hence it could have a fully functional s390 kernel with CONFIG_PCI=n, then the relevant iomem mapping functions [including ioremap(), devm_ioremap(), etc.] are not available. Here let XILLYBUS_OF depend on HAS_IOMEM so that it won't be built to cause below compiling error if PCI is unset: ------ ERROR: modpost: "devm_platform_ioremap_resource" [drivers/char/xillybus/xillybus_of.ko] undefined! ------ Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ Signed-off-by: Baoquan He Cc: Eli Billauer Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Acked-by: Eli Billauer --- drivers/char/xillybus/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/xillybus/Kconfig b/drivers/char/xillybus/Kconfig index a8036dad437e..f51d533390a9 100644 --- a/drivers/char/xillybus/Kconfig +++ b/drivers/char/xillybus/Kconfig @@ -29,7 +29,7 @@ config XILLYBUS_PCIE config XILLYBUS_OF tristate "Xillybus over Device Tree" - depends on OF && HAS_DMA + depends on OF && HAS_DMA && HAS_IOMEM help Set to M if you want Xillybus to find its resources from the Open Firmware Flattened Device Tree. If the target is an embedded From patchwork Fri Jul 7 13:58:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 117144 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3291976vqx; Fri, 7 Jul 2023 07:04:35 -0700 (PDT) X-Google-Smtp-Source: APBJJlHBlqwZA6D4Wt4mQYj8dek16l3Sds8YWKOfzUd+ZP2kQzH7r5f8o65uMozYuuA/t68I1Xym X-Received: by 2002:a17:902:b402:b0:1b6:a972:4414 with SMTP id x2-20020a170902b40200b001b6a9724414mr4126430plr.3.1688738674740; Fri, 07 Jul 2023 07:04:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688738674; cv=none; d=google.com; s=arc-20160816; b=jpol7NT9hFCR8ER7lkAN9M7vxwM0UrXvzoDAkPgbKL0rjBTDRgBSu5UbcWkkuLp32A eyGAsq8AhBUuo0+aWCLDiVnYN2JPa7lMK4pqf4fy/49o5W2Sssfqe81IeZ3HXIB8M4zR YvleRFdxZ5z4Qeiy8BJIEpvPgvJofW5Tli2JySc1bHehcrIuKK2k+uTOmQBWjl1tsRTa j8MjY9FqclHPZ10YBqekq0IngHlejsFrbVUq7QU5bmllpi/VWWWlIk/kUAzyPxMuRx0j SK4LPMCR5AOzuL7F9a5tQYlzgUIqoIXI/JUoijM++2E/1KkIUkk2Mdm5agU4dnw6YFVU hO/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=JY3wTP5/IT5Fuk6lBBENe/zUdzUPUkbX4RiZeJtGthU=; fh=INcnS+yX2NBDfIB23aYzu5gfxH1rW6lB53wHwdUYBVs=; b=00oMQ0O4RHEtZy033eOQAsnWb1zxNdRriw01WUM70/wH0uV0kWn9w3jH35qAVKAvlG mhDA2y3k4Dj2RDgPvtIyLLOKm8wMPd2ZH/O+2NAeR6WmCm1b3PljeSRBEGflyra+bJV6 3gkR8cRt1yCI4SSecoY9Qp8Rck4ixi1syIea6gd76UgPQgenJen5Xk+hzVfiX5/Ug/5n Ku9NpAChfGov99OHglsB7eREHFhEuttD0ISiZtASB+vrgVXvqqoD4qpiQhbwNQhendhx GmsFzFT/KdAQTmyD0HOjr5h+nc536IwZrMXeiveSN7VIgbQHJJHOBQr+7mBjK5i1KkG8 KTYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JB2MwhYb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y22-20020a170902b49600b001b87b716f87si3576234plr.329.2023.07.07.07.04.13; Fri, 07 Jul 2023 07:04:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JB2MwhYb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231950AbjGGOAw (ORCPT + 99 others); Fri, 7 Jul 2023 10:00:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232692AbjGGOAr (ORCPT ); Fri, 7 Jul 2023 10:00:47 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07FAC2108 for ; Fri, 7 Jul 2023 06:59:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688738397; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JY3wTP5/IT5Fuk6lBBENe/zUdzUPUkbX4RiZeJtGthU=; b=JB2MwhYb3QC5hAHEFw6rugZGalAldUZIXQF/mBZxJQEbcwIDvpI++y5lE1I72ra4N9zp8n MdZcWi1SoDUSMgfyuKW1V9f8MCPnnuYDPwXL9QoZSg/BzurPGu/vILJ8OP1nTAFs09idRf DC8+fIlOoghoJljcUgsfdmszz/43f0M= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-613-sTmYJ2YlOgSgjm1LqC6m8A-1; Fri, 07 Jul 2023 09:59:54 -0400 X-MC-Unique: sTmYJ2YlOgSgjm1LqC6m8A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3B5BB856F66; Fri, 7 Jul 2023 13:59:53 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-39.pek2.redhat.com [10.72.12.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 315AB2166B25; Fri, 7 Jul 2023 13:59:39 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, schnelle@linux.ibm.com, vkoul@kernel.org, eli.billauer@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, derek.kiernan@amd.com, dragan.cvetic@amd.com, linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com, linus.walleij@linaro.org, tsbogend@alpha.franken.de, joyce.ooi@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, tglx@linutronix.de, maz@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, frowand.list@gmail.com, Baoquan He , kernel test robot Subject: [PATCH 3/8] misc: open-dice: make OPEN_DICE depend on HAS_IOMEM Date: Fri, 7 Jul 2023 21:58:47 +0800 Message-Id: <20230707135852.24292-4-bhe@redhat.com> In-Reply-To: <20230707135852.24292-1-bhe@redhat.com> References: <20230707135852.24292-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770770844639412210?= X-GMAIL-MSGID: =?utf-8?q?1770770844639412210?= On s390 systems (aka mainframes), it has classic channel devices for networking and permanent storage that are currently even more common than PCI devices. Hence it could have a fully functional s390 kernel with CONFIG_PCI=n, then the relevant iomem mapping functions [including ioremap(), devm_ioremap(), etc.] are not available. Here let OPEN_DICE depend on HAS_IOMEM so that it won't be built to cause below compiling error if PCI is unset: ------ ERROR: modpost: "devm_memremap" [drivers/misc/open-dice.ko] undefined! ERROR: modpost: "devm_memunmap" [drivers/misc/open-dice.ko] undefined! ------ Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ Signed-off-by: Baoquan He Cc: Derek Kiernan Cc: Dragan Cvetic Cc: Arnd Bergmann Cc: Greg Kroah-Hartman --- drivers/misc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index 75e427f124b2..cadd4a820c03 100644 --- a/drivers/misc/Kconfig +++ b/drivers/misc/Kconfig @@ -496,6 +496,7 @@ config HISI_HIKEY_USB config OPEN_DICE tristate "Open Profile for DICE driver" depends on OF_RESERVED_MEM + depends on HAS_IOMEM help This driver exposes a DICE reserved memory region to userspace via a character device. The memory region contains Compound Device From patchwork Fri Jul 7 13:58:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 117147 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3296290vqx; Fri, 7 Jul 2023 07:09:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlHbyxNJbKK78bEShI7WkzrYc8BPU7lyF1MEyczMVW/MpJYvcu4RqgCXMqkNmw6f2/jGAPk6 X-Received: by 2002:a05:6a21:33a9:b0:125:c3f7:f863 with SMTP id yy41-20020a056a2133a900b00125c3f7f863mr13072444pzb.8.1688738971805; Fri, 07 Jul 2023 07:09:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688738971; cv=none; d=google.com; s=arc-20160816; b=U+BTrZBMPY3CQ7K5qvVnd7mZTmnDqR7XQpOmPzY6ehhUxvqX0jUAAuhImEN+QLAY0U B8nbVG/5ns6wT6WhA9IUJFQexLxwCPoq5h7rchgK0uYzfbxhS59Vkb3OcCMrZhga3Ne5 OEeWjUnXOgoK3VOQcLbxvhsaqPg1OO2o0ciiExigaKhL1oyaMgXmmTzsZXa1MtYTKLhn Qvrp0RM8LzDxni24WT03aqQ2N9DTDdEj08CV7+OeKFj4bhxtRbLfXzhD+91u3EUerLRK Y2raj1JgwAfx29k85zPDtK3s4eeMANJmTqttW+S2Vo3up2dlh6uXi+ll+fsR86Z/4JSm KQnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HPZ+j/W/x+bTEIUCrpmryT6rAOoCFvsSsqkhgyHlcOs=; fh=INcnS+yX2NBDfIB23aYzu5gfxH1rW6lB53wHwdUYBVs=; b=txfLCYXzIuAVSfbg+TjnWsoNTfUafUcF0fgi0DUNiFclnc6ppYVc2HftbM2vlykDuO OHbc4L4f7jgUDNj8jTh8T/Z87L+Y+QXZrGqRP7H1n1C5DkrVNmNvPcGjhrrrrCz3pIO3 P1N0AjC6hXtmg9wrAtTpy8DF+Uji2DooS2gbM/FBNiZ0PuDIwXkFiGBgOGHRlr0FM8eZ NpIsVdPyxTku2KyI9N6n7fMhS1eYeL38AG3FOUqGWq3O+QsvGilangSiOCEOX9Ts2EWx NzLivfNYza2MXkHjTup4xv0xqfSCLFFloebfRF1zFqdv3ez4aml5Jp2EE0hZdFQP5RW6 5paA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DLzUHdth; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j10-20020a634a4a000000b0053ff537164fsi3842237pgl.783.2023.07.07.07.09.15; Fri, 07 Jul 2023 07:09:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DLzUHdth; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232662AbjGGOBA (ORCPT + 99 others); Fri, 7 Jul 2023 10:01:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232560AbjGGOA7 (ORCPT ); Fri, 7 Jul 2023 10:00:59 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B093A2115 for ; Fri, 7 Jul 2023 07:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688738412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HPZ+j/W/x+bTEIUCrpmryT6rAOoCFvsSsqkhgyHlcOs=; b=DLzUHdthoOunr7DQLJbo1axZLKr+1dfnEDcNI29rNywV8FUAnGYqv3QBoDpXaU9yjilWmR eKj97judUHCVF/4R+QKrWovZLuph7TIIsWarCaASGCcwDvBP2jz+YfjPD9SSK2uuFT54Zv qyq5cmKUIWsEpbKDylgLz9Iw6kmodKk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-262-Y6FTdWTiNrKHrUZxO4Wg0w-1; Fri, 07 Jul 2023 10:00:09 -0400 X-MC-Unique: Y6FTdWTiNrKHrUZxO4Wg0w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A2AEB101A528; Fri, 7 Jul 2023 14:00:07 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-39.pek2.redhat.com [10.72.12.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 34C782166B25; Fri, 7 Jul 2023 13:59:54 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, schnelle@linux.ibm.com, vkoul@kernel.org, eli.billauer@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, derek.kiernan@amd.com, dragan.cvetic@amd.com, linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com, linus.walleij@linaro.org, tsbogend@alpha.franken.de, joyce.ooi@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, tglx@linutronix.de, maz@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, frowand.list@gmail.com, Baoquan He , kernel test robot Subject: [PATCH 4/8] pcmcia : make PCMCIA depend on HAS_IOMEM Date: Fri, 7 Jul 2023 21:58:48 +0800 Message-Id: <20230707135852.24292-5-bhe@redhat.com> In-Reply-To: <20230707135852.24292-1-bhe@redhat.com> References: <20230707135852.24292-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770771156295654450?= X-GMAIL-MSGID: =?utf-8?q?1770771156295654450?= On s390 systems (aka mainframes), it has classic channel devices for networking and permanent storage that are currently even more common than PCI devices. Hence it could have a fully functional s390 kernel with CONFIG_PCI=n, then the relevant iomem mapping functions [including ioremap(), devm_ioremap(), etc.] are not available. Here let depend PCMCIA on HAS_IOMEM so that it won't be built to cause below compiling error if PCI is unset. ------ ld: drivers/pcmcia/cistpl.o: in function `set_cis_map': cistpl.c:(.text+0x1202): undefined reference to `ioremap' ld: cistpl.c:(.text+0x13b0): undefined reference to `iounmap' ld: cistpl.c:(.text+0x14a6): undefined reference to `iounmap' ld: cistpl.c:(.text+0x1544): undefined reference to `ioremap' ld: drivers/pcmcia/cistpl.o: in function `release_cis_mem': cistpl.c:(.text+0x3f14): undefined reference to `iounmap' ------ Besides, many other Kconfig option, e.g IPWIRELESS, PCMCIA_PCNET, PCMCIA_FMVJ18X, PCMCIA_SMC91C92 which depends on PCMCIA also will cause compiling error if enabled. ------ ERROR: modpost: "iounmap" [drivers/tty/ipwireless/ipwireless.ko] undefined! ERROR: modpost: "ioremap" [drivers/tty/ipwireless/ipwireless.ko] undefined! ERROR: modpost: "iounmap" [drivers/net/ethernet/8390/pcnet_cs.ko] undefined! ERROR: modpost: "ioremap" [drivers/net/ethernet/8390/pcnet_cs.ko] undefined! ERROR: modpost: "iounmap" [drivers/net/ethernet/fujitsu/fmvj18x_cs.ko] undefined! ERROR: modpost: "ioremap" [drivers/net/ethernet/fujitsu/fmvj18x_cs.ko] undefined! ERROR: modpost: "iounmap" [drivers/net/ethernet/smsc/smc91c92_cs.ko] undefined! ERROR: modpost: "ioremap" [drivers/net/ethernet/smsc/smc91c92_cs.ko] undefined! ERROR: modpost: "iounmap" [drivers/net/ethernet/xircom/xirc2ps_cs.ko] undefined! ERROR: modpost: "ioremap" [drivers/net/ethernet/xircom/xirc2ps_cs.ko] undefined! ERROR: modpost: "devm_ioremap" [drivers/net/ethernet/altera/altera_tse.ko] undefined! ERROR: modpost: "iounmap" [drivers/net/arcnet/com90xx.ko] undefined! ------ Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ Signed-off-by: Baoquan He Reviewed-by: Niklas Schnelle Acked-by: Arnd Bergmann Cc: Dominik Brodowski Cc: Arnd Bergmann Cc: Jonathan Cameron Cc: Linus Walleij Cc: Thomas Bogendoerfer --- drivers/pcmcia/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig index e72419d7e72e..dddb235dd020 100644 --- a/drivers/pcmcia/Kconfig +++ b/drivers/pcmcia/Kconfig @@ -19,6 +19,7 @@ if PCCARD config PCMCIA tristate "16-bit PCMCIA support" + depends on HAS_IOMEM select CRC32 default y help From patchwork Fri Jul 7 13:58:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 117156 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3305316vqx; Fri, 7 Jul 2023 07:22:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlGa9T4SfrdGGS05OCWHvx5qpM8XvClVDeGIB5/bh8wHEMFzGxLRGDXHA1kUcV+ZQhD5kBpW X-Received: by 2002:a92:2905:0:b0:345:913a:41a2 with SMTP id l5-20020a922905000000b00345913a41a2mr5362634ilg.29.1688739729358; Fri, 07 Jul 2023 07:22:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688739729; cv=none; d=google.com; s=arc-20160816; b=M+pHu8/emWcSuML/dNp5j3cChCSfRpD/klyvWMBG+zMv+EyUq5h/bNCTBNYchoZvg7 RFQqOc55NJNNWOYIJ2nMhNxKhEHLogZ6TzROArj0r7NGYVcEpFU95DsrN31i1p8vZ0LC eRCSFWpP6ohGaD4vt2tAcXI+fTN6vyhsn/0usWsZap6bzVQFRVGdP0TlKvWKvjihU5uk hbmwcXcJD5/Hz8PeKldJSJ/41lf9u74Cp86Q0DFrAa+ADK5z21e+YBWvb56cBq47Qn0f Oh42qarflOMlYC5/CzTqwajcDaKyLDUHYqjh04qCaUiS6uNTW7kHVj+fVEpTNGUk5gcr tu0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tw4V2NfImeC5GfdO0ctBGdDxwJlMQmkR6fz8vyJ73Zo=; fh=e8la30POMJv1qx1/W6S4CNHyD9IRQbnZFyV8/PzkuTQ=; b=TKN9BNRQWtklqTVHQvJjDrBycTPxbeZxxyTY0TmaZx15WPdvmmeuI9SDK7sif3zdLF rWXSl+1FBa6SsCuCqCBFnglaZ0/wId0Vum5nD1qnqHK7ZN2L53yzkrmtt8gIEEAkg2B6 2P7Rzp+5Va9qDfErg/Sf2BURlBiXnC3/fR3RPou+q3JbDDVbS1UtyMuNMQ9Oz4ABVpi3 5373j61Ltli3Jyce93KkpQyYRTA2yGyoWRHEeOj64hgU96pSAeCJSP8btH7Hz0oixjTc pirTCrigx2Jo4RZWOYY4JI0NOVh4MsfCcv0vkSaWqSMqJ4bb93N0tw06/QjQw6pRIqhH e0yg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UPPXjdbI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u14-20020a65670e000000b005578c6a767esi3940351pgf.885.2023.07.07.07.21.53; Fri, 07 Jul 2023 07:22:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UPPXjdbI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232680AbjGGOBY (ORCPT + 99 others); Fri, 7 Jul 2023 10:01:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232664AbjGGOBV (ORCPT ); Fri, 7 Jul 2023 10:01:21 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AB842118 for ; Fri, 7 Jul 2023 07:00:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688738431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tw4V2NfImeC5GfdO0ctBGdDxwJlMQmkR6fz8vyJ73Zo=; b=UPPXjdbIQXYdlE1bYNesp3rK2OxkLMlv1WVvzYzaoioWtWF3l9J9XCLtTU9AVbTYcEek9i q8snyAxygq1uVhGcz6nsHFP5jbNNBxAw8Cm7YbJ4kdx8Cr9UgpQWYhwRNPOyjZaO3lhBrf eKdiz4A6NI+tp2ImGmYbVKlKqOPtQEE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-625-GcVuy2HmPeOr0kuq4Z8fqQ-1; Fri, 07 Jul 2023 10:00:25 -0400 X-MC-Unique: GcVuy2HmPeOr0kuq4Z8fqQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1BDDC88D543; Fri, 7 Jul 2023 14:00:23 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-39.pek2.redhat.com [10.72.12.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 594D02166B26; Fri, 7 Jul 2023 14:00:08 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, schnelle@linux.ibm.com, vkoul@kernel.org, eli.billauer@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, derek.kiernan@amd.com, dragan.cvetic@amd.com, linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com, linus.walleij@linaro.org, tsbogend@alpha.franken.de, joyce.ooi@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, tglx@linutronix.de, maz@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, frowand.list@gmail.com, Baoquan He , kernel test robot , netdev@vger.kernel.org Subject: [PATCH 5/8] net: altera-tse: make ALTERA_TSE depend on HAS_IOMEM Date: Fri, 7 Jul 2023 21:58:49 +0800 Message-Id: <20230707135852.24292-6-bhe@redhat.com> In-Reply-To: <20230707135852.24292-1-bhe@redhat.com> References: <20230707135852.24292-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770771950302355223?= X-GMAIL-MSGID: =?utf-8?q?1770771950302355223?= On s390 systems (aka mainframes), it has classic channel devices for networking and permanent storage that are currently even more common than PCI devices. Hence it could have a fully functional s390 kernel with CONFIG_PCI=n, then the relevant iomem mapping functions [including ioremap(), devm_ioremap(), etc.] are not available. Here let ALTERA_TSE depend on HAS_IOMEM so that it won't be built to cause below compiling error if PCI is unset: ------ ERROR: modpost: "devm_ioremap" [drivers/net/ethernet/altera/altera_tse.ko] undefined! ------ Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ Signed-off-by: Baoquan He Cc: Joyce Ooi Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: netdev@vger.kernel.org Reviewed-by: Simon Horman Tested-by: Simon Horman # build-tested --- drivers/net/ethernet/altera/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/altera/Kconfig b/drivers/net/ethernet/altera/Kconfig index 17985319088c..4ef819a9a1ad 100644 --- a/drivers/net/ethernet/altera/Kconfig +++ b/drivers/net/ethernet/altera/Kconfig @@ -2,6 +2,7 @@ config ALTERA_TSE tristate "Altera Triple-Speed Ethernet MAC support" depends on HAS_DMA + depends on HAS_IOMEM select PHYLIB select PHYLINK select PCS_LYNX From patchwork Fri Jul 7 13:58:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 117160 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3309267vqx; Fri, 7 Jul 2023 07:28:43 -0700 (PDT) X-Google-Smtp-Source: APBJJlEey2mkMg9Vq1FzF/dmdYdfYy9kwUTbDurkDTeKOZ7Vw4Zz9NtZdFnttsrAN+HVMx5Ldzcq X-Received: by 2002:a05:6a20:be1c:b0:12e:8769:557f with SMTP id ge28-20020a056a20be1c00b0012e8769557fmr3896346pzb.36.1688740123554; Fri, 07 Jul 2023 07:28:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688740123; cv=none; d=google.com; s=arc-20160816; b=nOuWRYtAfHXft/VTpb3H5pO7CXirUnXsEMaUiwbzKB9JdzFZxVjsolyp81OhxbZXDI lHXij5rIpwChwZ3QDUH+gQt2+kKvVbDmuo+EpExD25zFWLwm0u/efp6xeK42Vm93PS55 FTPmv3juzHlIHZQoreTUPpcjABGVJh1UAIxsv8phtYEW7Tt5bZ4O8oNMz8Umwe8Z9Xf1 wDwCZuBGdIBxGvwaZ3Ybf2iHxAbHGMWn4VfzR4sale53B46hNsqIN3b09jdUS89xdf1t +TmyhNtW8uPUjN7nVswuhDdRUYedZUv7i2H4EIPR6tKfz7PUVPvK5RHLjNFb50Sczv5S FN/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=CWfLRI5TOebRN6fQYNsjbIhOePrgTeydAOSGhfAOwjI=; fh=INcnS+yX2NBDfIB23aYzu5gfxH1rW6lB53wHwdUYBVs=; b=jQhrL4tkVbIPGXaX3a47t9Kk0lYHXDKDT26xhmILcCknT7WTg2Rv0r2Zul8zTxrSCp M2cS3Pu/6/fufNe6O8vz3/s1uPz1cOYPT9DldDXRm3ERfPhoy4kEt/ACnHqwUgDzEd20 Cw+iuGfOIn5MLuzbxqoeVvB6SSG+D2hC37NbVcmP8FSSlObjY6/XxAvyd1G834RVAT0+ 0gdj+byQGk3ikSYpVTbsr76rXePfohAg3ISTZta72mOiKyU+gxYoSkooonQq3nDOIQLL 0t2brFo9M+aMflHlG84mx9lJ7OmNv5g70VT8VK5q72huHYsjt3KVYVvNMymMHHbQy+eT pYCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iLG0Gn4W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f8-20020a056a00238800b00682b0b7ed43si4111921pfc.368.2023.07.07.07.28.28; Fri, 07 Jul 2023 07:28:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iLG0Gn4W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232814AbjGGOBk (ORCPT + 99 others); Fri, 7 Jul 2023 10:01:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232781AbjGGOBb (ORCPT ); Fri, 7 Jul 2023 10:01:31 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84D98212B for ; Fri, 7 Jul 2023 07:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688738441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CWfLRI5TOebRN6fQYNsjbIhOePrgTeydAOSGhfAOwjI=; b=iLG0Gn4WRZzU9/i6tvoMnwrpqmieepE1FLKegqYTSZUcIDzwZjoEq969ne7fZCUIZlXmHz Ei6LoJqhB4k1J8kgK0xPxlCr2byekdNWJXE/O1oSerdMUYQK4U97kizoyWwEycZjn0fu+e RsBOT+1T1zwnboHWEab8+hFZBmVkHZ8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-464-zGZQbIWXMSycsrfTt_BANg-1; Fri, 07 Jul 2023 10:00:38 -0400 X-MC-Unique: zGZQbIWXMSycsrfTt_BANg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0AE34104458F; Fri, 7 Jul 2023 14:00:37 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-39.pek2.redhat.com [10.72.12.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0FAD52166B25; Fri, 7 Jul 2023 14:00:23 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, schnelle@linux.ibm.com, vkoul@kernel.org, eli.billauer@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, derek.kiernan@amd.com, dragan.cvetic@amd.com, linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com, linus.walleij@linaro.org, tsbogend@alpha.franken.de, joyce.ooi@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, tglx@linutronix.de, maz@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, frowand.list@gmail.com, Baoquan He , kernel test robot Subject: [PATCH 6/8] irqchip/al-fic: make AL_FIC depend on HAS_IOMEM Date: Fri, 7 Jul 2023 21:58:50 +0800 Message-Id: <20230707135852.24292-7-bhe@redhat.com> In-Reply-To: <20230707135852.24292-1-bhe@redhat.com> References: <20230707135852.24292-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770772363398330464?= X-GMAIL-MSGID: =?utf-8?q?1770772363398330464?= On s390 systems (aka mainframes), it has classic channel devices for networking and permanent storage that are currently even more common than PCI devices. Hence it could have a fully functional s390 kernel with CONFIG_PCI=n, then the relevant iomem mapping functions [including ioremap(), devm_ioremap(), etc.] are not available. Here let AL_FIC depend on HAS_IOMEM so that it won't be built to cause below compiling error if PCI is unset: ------ ld: drivers/irqchip/irq-al-fic.o: in function `al_fic_init_dt': irq-al-fic.c:(.init.text+0x76): undefined reference to `of_iomap' ld: irq-al-fic.c:(.init.text+0x4ce): undefined reference to `iounmap' ------ Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ Signed-off-by: Baoquan He Cc: Thomas Gleixner Cc: Marc Zyngier --- drivers/irqchip/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index 09e422da482f..4b9036c6d45b 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -89,6 +89,7 @@ config ALPINE_MSI config AL_FIC bool "Amazon's Annapurna Labs Fabric Interrupt Controller" depends on OF + depends on HAS_IOMEM select GENERIC_IRQ_CHIP select IRQ_DOMAIN help From patchwork Fri Jul 7 13:58:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 117145 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3292684vqx; Fri, 7 Jul 2023 07:05:24 -0700 (PDT) X-Google-Smtp-Source: APBJJlHi4kEg+KcccUBDnXw/jKUkA7nCkCqeRZ+VHH09kdr4fiDM55qHdO5hNcjjk4Byzl9Hffag X-Received: by 2002:a05:6808:10c5:b0:3a3:eab8:8ba5 with SMTP id s5-20020a05680810c500b003a3eab88ba5mr2761053ois.27.1688738723868; Fri, 07 Jul 2023 07:05:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688738723; cv=none; d=google.com; s=arc-20160816; b=NHn2seYBOcFQwJtiTVh3RMIs3zf7RoSiq4fpFMs7YbxrU/GBi/WxjqbiewXgRPWhLr 5XQlhnz8XnQ4AziJZMyIJxpuIZKkKWk2cj2K3A9wniypSFrJNOyQ5xKqfiHO6+2T4jAH 8MB8VDPNHP1d6+2nCVnUdfRvkby7Soy8gSSHeO7RzEpA/10atpyJwgssLId8NS/Gr20j Ek95wcD7A5GGZKQHHm7WSF/r8Xa5tuNox/hsYfwEYSFtyQNLTB+lgfXrtt0DuB7yIpLz 1cuH1TMtJ5zE4iiPqwZOfrqqgLdVjHVE2HKFKq+vIxqZ6rftw1yhuirwj1vskJGL36wa s5CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Xp6rJXv98R80P+/7EHwV7cdYFXbRakzdmgAQwoPVD+8=; fh=kT+xCHyfFE7HW3Rm/A2+i3qoUdZMkJ3GNTp6wZtj+Pg=; b=SuwyDbYVbrDERx3hLH3CYUFUP0g3WgyRUXdN8G51LXv9Pk+JGOGI5vtKy0zvbowUTu LRLW2uhdPBqkq7KWW1tRga9v13sNgpKqMpx0ha7ipgBc3PW2ymb8npXSyjw2vk+WK0IM zw/4lJSwFUFDc/3H3HePKGi6+L2DiJPRu9zImomA8e6Tz+MajlSGR5OWWmdl8jknpGOg lTHVy9d7wcymJjowVTkwMx3EDX7ikVCcqcE3w4UAXPHCqihvxglKrhl20POWuTwTrKcK 27ijaTy2AYQwbZLlViEhoIsk8oHO/b4x0m762axWlATkLabyj4ctxWtTp6F2sUOdpjSW JZZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aPpOl3rg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g18-20020a544f92000000b003a3a706fe79si1690190oiy.303.2023.07.07.07.04.59; Fri, 07 Jul 2023 07:05:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aPpOl3rg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232827AbjGGOCB (ORCPT + 99 others); Fri, 7 Jul 2023 10:02:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232570AbjGGOBn (ORCPT ); Fri, 7 Jul 2023 10:01:43 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 365722130 for ; Fri, 7 Jul 2023 07:00:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688738455; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xp6rJXv98R80P+/7EHwV7cdYFXbRakzdmgAQwoPVD+8=; b=aPpOl3rgpFYjXvecHBDmebwHNGnxtbMauiJ3u32+0bus1Zpxao3TXLO2JDN4kyr+En1oud C2Rw/MxnXOActkuBN33EMHxzDHylxOq9pY/hHYDI8zo0MXIHuiO+MKZ84lb5M+wPTp8api giC2glbAha6wynSHMtsWSJgZOZBohkw= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-357-nvdKaUNuNZK_NsivSrgL-g-1; Fri, 07 Jul 2023 10:00:52 -0400 X-MC-Unique: nvdKaUNuNZK_NsivSrgL-g-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D30CF1C060CC; Fri, 7 Jul 2023 14:00:50 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-39.pek2.redhat.com [10.72.12.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id D64122166B25; Fri, 7 Jul 2023 14:00:38 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, schnelle@linux.ibm.com, vkoul@kernel.org, eli.billauer@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, derek.kiernan@amd.com, dragan.cvetic@amd.com, linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com, linus.walleij@linaro.org, tsbogend@alpha.franken.de, joyce.ooi@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, tglx@linutronix.de, maz@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, frowand.list@gmail.com, Baoquan He , kernel test robot , linux-clk@vger.kernel.org Subject: [PATCH 7/8] clk: fixed-mmio: make COMMON_CLK_FIXED_MMIO depend on HAS_IOMEM Date: Fri, 7 Jul 2023 21:58:51 +0800 Message-Id: <20230707135852.24292-8-bhe@redhat.com> In-Reply-To: <20230707135852.24292-1-bhe@redhat.com> References: <20230707135852.24292-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770770896135358709?= X-GMAIL-MSGID: =?utf-8?q?1770770896135358709?= On s390 systems (aka mainframes), it has classic channel devices for networking and permanent storage that are currently even more common than PCI devices. Hence it could have a fully functional s390 kernel with CONFIG_PCI=n, then the relevant iomem mapping functions [including ioremap(), devm_ioremap(), etc.] are not available. Here let COMMON_CLK_FIXED_MMIO depend on HAS_IOMEM so that it won't be built to cause below compiling error if PCI is unset: ------ ld: drivers/clk/clk-fixed-mmio.o: in function `fixed_mmio_clk_setup': clk-fixed-mmio.c:(.text+0x5e): undefined reference to `of_iomap' ld: clk-fixed-mmio.c:(.text+0xba): undefined reference to `iounmap' ------ Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ Signed-off-by: Baoquan He Cc: Michael Turquette Cc: Stephen Boyd Cc: linux-clk@vger.kernel.org --- drivers/clk/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index 93f38a8178ba..6b3b424addab 100644 --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig @@ -444,6 +444,7 @@ config COMMON_CLK_BD718XX config COMMON_CLK_FIXED_MMIO bool "Clock driver for Memory Mapped Fixed values" depends on COMMON_CLK && OF + depends on HAS_IOMEM help Support for Memory Mapped IO Fixed clocks From patchwork Fri Jul 7 13:58:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 117149 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3296925vqx; Fri, 7 Jul 2023 07:10:20 -0700 (PDT) X-Google-Smtp-Source: APBJJlHQvO77Fe8/XPhS+7Sg1MD+cS/0XEZsjQz6p97pasV819EUJw9Ap4IZu2TaHkoKoaT7u4i2 X-Received: by 2002:a17:90b:ecd:b0:263:a6a:49b8 with SMTP id gz13-20020a17090b0ecd00b002630a6a49b8mr3802047pjb.3.1688739020645; Fri, 07 Jul 2023 07:10:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688739020; cv=none; d=google.com; s=arc-20160816; b=qZ/WoY9/MNHe3UuY1DbfOA1rXVkE1KQJcKWIQnmLsTis+tM9hIWVdDpEO1kw4IUZKq zxJwE5Vnyt6vy9/8Lr+ocySCalRKW/QMjd+sx06XwGfTIEHUPt8nMxcJv92MRLtlTOsi vc7VIJAdgwFcNy6g1EDpOcfdRrGqMLwMH80RuatqUm3IRPL1stvv5qNM4gd4/LLIRIzH JokFupYidsQTHVEbCL2ViGeOCC03+FFjceEUIBl6DbCVtlrhjSixhdhgCm8UZMgw+e95 DlaX1BnSrbCrwloa8XgB9ZqiTZ+wEdPrWnAVGWAzpRKKpbm/w7eM+W3Yho+vEKtDAzrp XkNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hsDLZOIaMsdutOawC63k62k7hxKuoez0tGZig9GdB48=; fh=s/fXgexTPcP4+XqUU2/mFyLxLzfaGbIRMeOdno3aQeY=; b=bfPMDjn99zMpHx5t3O3a5PO1s0liU61+et+T+cv8wImq/fWkcLz0a/VhD8xfZKhJum z0sBfmy9CKSmzt6Dw3Kt/eawaGTyY9Tz50KoHRyAxHwRL/ogq6q8udh6q39rmeeL7RQi m7VBwnB96UFgqST5knSIUbbB4CY5YB3d5KZpneoIxbzkkzvWRIydgLewmczSQIkcHkds JziCMq0M07mPWanWyKfnNs6Z+HWIq6rwWh4XKlZO7dRkLvzriRJKSqf/Ru+TsKQcDgf5 aq4BejCGoMTvxjdIIOnR569ShGC2zEBL3TfpPg0ByzbDOZXDOSeGrvd2q7Rm4Tv6ryp5 zK2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ORn4zhRb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g123-20020a636b81000000b0054fd9f2dfebsi3861478pgc.704.2023.07.07.07.10.05; Fri, 07 Jul 2023 07:10:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ORn4zhRb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232799AbjGGOCY (ORCPT + 99 others); Fri, 7 Jul 2023 10:02:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232903AbjGGOCD (ORCPT ); Fri, 7 Jul 2023 10:02:03 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91227210C for ; Fri, 7 Jul 2023 07:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688738471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hsDLZOIaMsdutOawC63k62k7hxKuoez0tGZig9GdB48=; b=ORn4zhRb0jLa2A93NW/bhKRlAEMkfvB5lgoCFV8EAdqSIUp+OEYIs2I4zjhmVZGU80eTKi 5XKK3KDuQ32t3aG9/pHElhRILVziC1GgKFHXKgxyhaLrtKHzATj159cIvBsnqNWZu+IX9s OvBDyvdf1j9HOMTMLmhMO8wAPAx2cDc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-621-_yX0V8PePHiNzeIA8hA2sA-1; Fri, 07 Jul 2023 10:01:05 -0400 X-MC-Unique: _yX0V8PePHiNzeIA8hA2sA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4B612100812B; Fri, 7 Jul 2023 14:01:04 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-39.pek2.redhat.com [10.72.12.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id A18962166B25; Fri, 7 Jul 2023 14:00:51 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, schnelle@linux.ibm.com, vkoul@kernel.org, eli.billauer@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, derek.kiernan@amd.com, dragan.cvetic@amd.com, linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com, linus.walleij@linaro.org, tsbogend@alpha.franken.de, joyce.ooi@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, tglx@linutronix.de, maz@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, frowand.list@gmail.com, Baoquan He , kernel test robot , devicetree@vger.kernel.org Subject: [PATCH 8/8] of: make OF_EARLY_FLATTREE depend on HAS_IOMEM Date: Fri, 7 Jul 2023 21:58:52 +0800 Message-Id: <20230707135852.24292-9-bhe@redhat.com> In-Reply-To: <20230707135852.24292-1-bhe@redhat.com> References: <20230707135852.24292-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770771207076967676?= X-GMAIL-MSGID: =?utf-8?q?1770771207076967676?= On s390 systems (aka mainframes), it has classic channel devices for networking and permanent storage that are currently even more common than PCI devices. Hence it could have a fully functional s390 kernel with CONFIG_PCI=n, then the relevant iomem mapping functions [including ioremap(), devm_ioremap(), etc.] are not available. In LKP error report at below on s390: ------ ld: kernel/dma/coherent.o: in function `dma_init_coherent_memory': coherent.c:(.text+0x102): undefined reference to `memremap' ld: coherent.c:(.text+0x226): undefined reference to `memunmap' ld: kernel/dma/coherent.o: in function `dma_declare_coherent_memory': coherent.c:(.text+0x8b8): undefined reference to `memunmap' ld: kernel/dma/coherent.o: in function `dma_release_coherent_memory': coherent.c:(.text+0x9aa): undefined reference to `memunmap' ------ In the config file, several Kconfig options are: ------ '# CONFIG_PCI is not set' CONFIG_OF_EARLY_FLATTREE=y CONFIG_DMA_DECLARE_COHERENT=y ------ So, enabling OF_EARLY_FLATTREE will select DMA_DECLARE_COHERENT and cause above building errors even though they are not needed because CONFIG_PCI is disabled. Here let OF_EARLY_FLATTREE depend on HAS_IOMEM so that it won't be built to cause compiling error if PCI is unset. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ Signed-off-by: Baoquan He Cc: Rob Herring Cc: Frank Rowand Cc: devicetree@vger.kernel.org --- drivers/of/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig index e40f10bf2ba4..da9826accb1b 100644 --- a/drivers/of/Kconfig +++ b/drivers/of/Kconfig @@ -55,7 +55,7 @@ config OF_FLATTREE config OF_EARLY_FLATTREE bool - select DMA_DECLARE_COHERENT if HAS_DMA + select DMA_DECLARE_COHERENT if HAS_DMA && HAS_IOMEM select OF_FLATTREE config OF_PROMTREE