From patchwork Fri Jul 7 06:33:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 116993 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3067621vqx; Thu, 6 Jul 2023 23:49:44 -0700 (PDT) X-Google-Smtp-Source: APBJJlGju0mS+j4H7wG2jiJ4fE9JXf5OJdc/O/v3ig2aWuLuhju+fSNzyiVPRbNvYk9fqVPbNYqN X-Received: by 2002:a05:6808:220b:b0:3a0:41d4:b144 with SMTP id bd11-20020a056808220b00b003a041d4b144mr5049287oib.1.1688712584620; Thu, 06 Jul 2023 23:49:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688712584; cv=none; d=google.com; s=arc-20160816; b=Ichllj9Su5GJU660w9rWPLgCpOmPCinjoNMVUD9hfZjTzTRNCCn/jkCk56P3bmUktW 6M3KchO0KBexIma2n9DvP74GRfg3U9kUbX4YrBN+E0FdLKZWHbvwx6rNrTTwnWhbUnaK 5NrfecLS0Vr3m6pz/wNbqeC3jLYSsq9/RL+Dlt1+CL745G+2hG9WjO9Iqwp/7cHuEWA9 iuu4ndKV6XvVG4hNBkG1YhzwIXjCqUFRhY5dNIr5ppB1ngNMCcigzyUh17trr+lJwQx1 YZMX169q8/Zt+ZRc4SHYONtxZwYx/aH4NaJMPnyllU5fOmoURjDnRxHaVAxUFvLwXmlW e7bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=e1W0PEIp2Z9O+/54QqCCTT57o1K3eq1ISnoT3iEkIG4=; fh=r102X2Gp3Ll0scyBTiyjmxYlXDGfBgzF9EqFvsdroRM=; b=D3lNH0zE8QfFOZkdH1nTDaqWNOUrqem4SY8Y0KFc8UyykXamMF6k9id/1LZMlezm9x 6SG8dgaYWKewFNt1vmd3DzW/j+5w1/dguAge1Jbsdmty1Goau5bfUc4ayT8ZYhKAIPbW rz9m8Kxx+quy3gPMQk5JSRN8lvcOn1ljQo1gLSUmOOurhNwlDS7sY2gHmvEifMZhh00b 0REYXAVNv5rCyEjOmSwvtHMy9pc5rbZ9csfthyEGYuvXv4kMp46namLsIKgKa+dHLeVp QKkyPFaGHhblASRs1m6zBySfWBnxyq5gO17bi/wMeD+p4m/jEH0ZVZAaQiduJoO/wQvS T2Rw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ji+vp0Rf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kk15-20020a17090b4a0f00b002632a1243dbsi897656pjb.104.2023.07.06.23.49.30; Thu, 06 Jul 2023 23:49:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ji+vp0Rf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231769AbjGGGdn (ORCPT + 99 others); Fri, 7 Jul 2023 02:33:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229642AbjGGGdl (ORCPT ); Fri, 7 Jul 2023 02:33:41 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED1491FC9 for ; Thu, 6 Jul 2023 23:33:39 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-992ca792065so186613066b.2 for ; Thu, 06 Jul 2023 23:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688711618; x=1691303618; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=e1W0PEIp2Z9O+/54QqCCTT57o1K3eq1ISnoT3iEkIG4=; b=Ji+vp0Rf7GnjgL/ryIs4zj5psew4pNxA0cs8GFKCCt4E8wh0ztH3y1BPKo8A6Kr5CR Ssh+LsCi0ePSmFr6nLgrN73CA2MGcMaJIrfjpg/jM7aBYCC7QstmFfJTkw+D0od4S9CL fK43PEE9RS+gtkkroUsHTHuZrB4sb2u/XCw+wBuIGWfkCD0UmOg1nuWcTcVNjB4Y9lBJ XtIxHr9Fe2nvRTn/d7F6dMPhkKhvs3PfzluZg24d0Fqx/c5HsGGJBo/U2On4yiyKU7x2 jekKm74a17Mc0FGyAaRQgC6mRyV6NJcMAVHpqNP/NinRZ88jHW6ZblkBXu+EnDP5KDX+ smmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688711618; x=1691303618; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e1W0PEIp2Z9O+/54QqCCTT57o1K3eq1ISnoT3iEkIG4=; b=CH6oYhL5vXL6mBbBRHmNs5OTl8kY/3NjWwsJZ89Bd6u40787udscaO/RyY0Xta7qe8 l4i+Wz4/WTHrLBFfsVzve2JmQNsoFX+vmL2zZeAv7pIrsCk33IJoiOUq+HkIzmrlAxni afbqX5v7nHqhHQNmG+UZLOwC+v84JMLsd4Aq8pkuqIgGwe/XcYVbMxOeTJYRl5Mp+QAj OmfQX7NOgyW9BIXVV3IyRUqLFbZz3SNX8cdt9m/3KZH2Yqk6CI4MptbYh7j+4tj663OW z33raKcqyELbVUYM3OAYA92YuXA8Mlb8wtqPdycRTrJ5gwMRLnbsaSFT/3fj+APFZhfK FU+w== X-Gm-Message-State: ABy/qLaC0DQxNkGu+c36ugQdAUGwSTSTmnYmB7MmNhCrmMitH77RnvBa QAS+O6Y7q+bF9KITI08tTwkEUA== X-Received: by 2002:a17:907:75f6:b0:94f:449e:75db with SMTP id jz22-20020a17090775f600b0094f449e75dbmr3160188ejc.52.1688711618411; Thu, 06 Jul 2023 23:33:38 -0700 (PDT) Received: from krzk-bin.. ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id s24-20020a170906169800b0096f7500502csm1724803ejd.199.2023.07.06.23.33.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 23:33:38 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 1/3] arm64: dts: rockchip: correct wifi interrupt flag in eaidk-610 Date: Fri, 7 Jul 2023 08:33:33 +0200 Message-Id: <20230707063335.13317-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770743487188437655?= X-GMAIL-MSGID: =?utf-8?q?1770743487188437655?= GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE. Correct the interrupt flags, assuming the author of the code wanted same logical behavior behind the name "ACTIVE_xxx", this is: ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH Signed-off-by: Krzysztof Kozlowski --- Changes in v2: 1. Correct subject and commit msg (active low -> high) --- arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts b/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts index d1f343345f67..6464ef4d113d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts @@ -773,7 +773,7 @@ brcmf: wifi@1 { compatible = "brcm,bcm4329-fmac"; reg = <1>; interrupt-parent = <&gpio0>; - interrupts = ; + interrupts = ; interrupt-names = "host-wake"; pinctrl-names = "default"; pinctrl-0 = <&wifi_host_wake_l>; From patchwork Fri Jul 7 06:33:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 116990 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3066065vqx; Thu, 6 Jul 2023 23:45:33 -0700 (PDT) X-Google-Smtp-Source: APBJJlGzMmFCw48NWxfRAi7ozrdlz3RZ9dvJ4mpF6GFMwm4la0RjCqCtT6Di1PyIRm3bwk4I+73h X-Received: by 2002:a17:902:7781:b0:1b7:f98d:5567 with SMTP id o1-20020a170902778100b001b7f98d5567mr3543698pll.68.1688712333148; Thu, 06 Jul 2023 23:45:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688712333; cv=none; d=google.com; s=arc-20160816; b=h5ztf0tAhJ8zhB52p7FYIe5ues9XPS2xLW4XT7MafEmUQctSZf7BXdQibuFXGVol4J TK1gS0rWFU7abaTmMSmw3zFXcSUNQmmjOXu/6O5TC4mzOOa366oXaL+s2QhnrE3OWTqy sVnxxkq3UVcsNXZKYY4uc1KZz9Vbq69gBduEfSqxo/Yxb6UFL1JoMtzJJAF+K1BoPRiy axkjm6kH1EMXAbcjeoLdksIXcwUh5U09SykXxvc4QMwN1JY6aEIkYxCFnTJQtE/VSOT4 wLt5AliHuDacD8mXlNDlF9K6C8rnv6ngnHirk9iJ9CtLZ3Q2g5KjCo+RD3WvbVLjpinr FP8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2gUQGEXg3NwnR1jgA5o6lKwJkp5ln8c5jv9qArkjhok=; fh=S8bbPLpxsrJLoj4bMVjbrUluevyB4T5744zTOEFAzMU=; b=xaUzAwL5tKT57X3EdftYNH/f+vIy0ePCJk+cmY1C382VC666ErL+Ofrv8JZ4omgS+m ccF/xEyvCuXYGjV620Owv7LvLyoU0RYMUWBx0AOCvzkOYb372jV7tbJHkM4GttK9AmwJ NivPsZ/6A3eRZlABKJoS6eAFejAksHvV1GCw1zkcZNeDcT47wkXmmZDSOX8FWsFk0D1J jR5exL5zJU42iRuAcca4w+CORueqr9TGj8/HVURVGaLzDqUEDPxihuHivwWu2r7rWr5X LvT990wlhbKmHGAOCOpys5rU0rmBHJRtPjKbHvldYxjlGXdhhDdWl1CsMriL+6L5dhjX anVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sk8oCY0k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a13-20020a170902eccd00b001b8a54f99d2si3244122plh.427.2023.07.06.23.45.19; Thu, 06 Jul 2023 23:45:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sk8oCY0k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231781AbjGGGds (ORCPT + 99 others); Fri, 7 Jul 2023 02:33:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231675AbjGGGdm (ORCPT ); Fri, 7 Jul 2023 02:33:42 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6039E1FD7 for ; Thu, 6 Jul 2023 23:33:41 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-98e39784a85so510839166b.1 for ; Thu, 06 Jul 2023 23:33:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688711620; x=1691303620; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2gUQGEXg3NwnR1jgA5o6lKwJkp5ln8c5jv9qArkjhok=; b=sk8oCY0kkiy/wQ/T3PrdyQFle55qJrxLJxCZ13gyQrboPMWCk6ag5YJu24CBFoVacr E1FkxQTtKjBt5g4vZF9jTM4+MgIVlyTd64hzg21sNVcsIl62YD7WycredOLAT5i7L7If JTxIJmky9s2SSiiugSYOZVbgAVp9PlkQ0h6Slm7erVmqSxMTPkNvtCzufmFX+8UCHBkY qBG7dEUj9oHyRpcAFm5GbSMB2H673Cjbl6kWvdjfWNHKaXQFVPkK2urVkRfIuOV/ls28 O034wkpRgYcMfqZ+fbyybp2R2I7/uyaBs2Ug1bVVPBFIFlpuEGAacghxN8nWmEMrhFUU NcnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688711620; x=1691303620; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2gUQGEXg3NwnR1jgA5o6lKwJkp5ln8c5jv9qArkjhok=; b=HXwlQuhIkzbxjkBQZdx9B1Lc+t6kCaKVO7n7Dle5vpnXfCHz/1CQA2zbq5zW54yW5G i1YwM0wDUzorEBr2/iQFJBF21bQ6vjx8Dhy+cNAeoU7JFH3hBEeb7fa/3Nqj3rLFHbnq rUAPcg4WNYhVroqYgGpB/+JtboqwHLS9ybj2+ddB5O85BFfwUgNv4HzZ5c12bCD+5Kqb Kv3w6pJcIzwhWAUAOzRKOugDAPG4ra/j9AEqzvtG76oiwRrRHNkI3VvLI00nNjJ+gBM3 rfPciJXRvRL8V3/oaTZSvfRGIOVdxqtnom2LcUufctMD1gfmpB187KVPTuY5sg7zl4mF Gh6w== X-Gm-Message-State: ABy/qLayAvTs1rcLl+7ScBlzQRRCMV5j2BC5lqnCPaNKkHoPljRj/WyX yyLBw2tPNMb4k7nlfbHK5pheRA== X-Received: by 2002:a17:907:d15:b0:992:103c:43fa with SMTP id gn21-20020a1709070d1500b00992103c43famr7378130ejc.30.1688711619777; Thu, 06 Jul 2023 23:33:39 -0700 (PDT) Received: from krzk-bin.. ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id s24-20020a170906169800b0096f7500502csm1724803ejd.199.2023.07.06.23.33.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 23:33:39 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Christopher Obbard Subject: [PATCH v2 2/3] arm64: dts: rockchip: correct wifi interrupt flag in Rock Pi 4B Date: Fri, 7 Jul 2023 08:33:34 +0200 Message-Id: <20230707063335.13317-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230707063335.13317-1-krzysztof.kozlowski@linaro.org> References: <20230707063335.13317-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770743223130234564?= X-GMAIL-MSGID: =?utf-8?q?1770743223130234564?= GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE. Correct the interrupt flags, assuming the author of the code wanted same logical behavior behind the name "ACTIVE_xxx", this is: ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH Signed-off-by: Krzysztof Kozlowski Tested-by: Christopher Obbard --- Changes in v2: 1. Correct subject and commit msg (active low -> high) 2. Add Tb tag --- arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts index cec3b7b1b947..8a17c1eaae15 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts @@ -31,7 +31,7 @@ brcmf: wifi@1 { compatible = "brcm,bcm4329-fmac"; reg = <1>; interrupt-parent = <&gpio0>; - interrupts = ; + interrupts = ; interrupt-names = "host-wake"; pinctrl-names = "default"; pinctrl-0 = <&wifi_host_wake_l>; From patchwork Fri Jul 7 06:33:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 116985 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3064471vqx; Thu, 6 Jul 2023 23:40:55 -0700 (PDT) X-Google-Smtp-Source: APBJJlG2pU+BEoxh7L7ce1RHIb3aYO6EsqBvnM2hRgjxq/36QedGPL0vRqzMEdt2d+MV34ARAajX X-Received: by 2002:a17:902:e88f:b0:1b8:9046:4bfb with SMTP id w15-20020a170902e88f00b001b890464bfbmr5216798plg.9.1688712055244; Thu, 06 Jul 2023 23:40:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688712055; cv=none; d=google.com; s=arc-20160816; b=R/FSLFKy927MA+c4+1kWQI3JnSxz65FiNrxrWhCNA9BJvxTRTgllo136CVRHj6nABF HoGNHBdtcBojPaw75FyR8LjvnpKUSLroWjOPlhosGfyS6L/4FlX/fRFUHHoGAH78rTdl sxQFIIHgxq0vO03KMVHQv3ecJeicgENxASMhjC0wV/jabBaCi1UqceouO4HLnOpIVYfz OdEsDzNG4Hs8nm8QATgbx5rc0wd4czktCh7pR+79cjx7dJ+XAV5c+Oz/JiqAIhiZblPa mMq8sWCfTA5licAbFiEvFokVsM1xe08q54E4+Bbe/4eBgjuJoqjzp9TN6rL3CMh4mLBB 0CXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2rZJMXQqBbYtG35iaT5k3WfIhsJUmOKUvW8i0uD8NBI=; fh=r102X2Gp3Ll0scyBTiyjmxYlXDGfBgzF9EqFvsdroRM=; b=ENp9OCWQ0ONC9zcUbQuHtI2DMQPI5yQiZls9SQZtrWApsPuHmrYljubX1fZ3YH8OPy D1skrCtq6cdONItV/r4GQsIefZu6UkWTdqZrCC8A52uSmT+OihXic2B+8kMCGA088fi8 4fyogK4YehGrdQe76dpX0c3pjiQpkbnTNlgIVn7PB5WmJdYHTaDYnN+PMAOycjPb1M13 KabZIvVnzTbAVLb2dZTQ0tyH1nCWGRrdoVRW/XOAlYiq+/limV49vt3baJmNniw/A+1L bWH9ChGN35Lj8PO0uHYmonbTeKbgwOJ+el2ky9uHMEEfnQwb2whgoecBik84bg6yzZka Qh0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=R6ZFDYFt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a13-20020a170902eccd00b001b8a54f99d2si3244122plh.427.2023.07.06.23.40.41; Thu, 06 Jul 2023 23:40:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=R6ZFDYFt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232135AbjGGGdz (ORCPT + 99 others); Fri, 7 Jul 2023 02:33:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231756AbjGGGdn (ORCPT ); Fri, 7 Jul 2023 02:33:43 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90EDE1FC7 for ; Thu, 6 Jul 2023 23:33:42 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-51e43473ee0so34356a12.3 for ; Thu, 06 Jul 2023 23:33:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688711621; x=1691303621; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2rZJMXQqBbYtG35iaT5k3WfIhsJUmOKUvW8i0uD8NBI=; b=R6ZFDYFtiyI8QhUOPF6/ZqW8UzJswYZ0EN+ADhSd2YTyJsje3D0PZj3nDoKg+IU2g6 oePk+WhsqDnjZIloNBJmSLMHqjTh7jSs/l2GuCbZETzeD4fx6VwJvnlNXfHHZ8GGPRsD 5ICdV+l8u7Nf6IaA+Rsx6fDrSi/rctd28Y6urlyxFCJiagJlNi87Cr3wP6dis1J8wMc1 eTAl9POvBZ3rb38PLgSDNFPh8k2X3OUDM+GRlL4FpHdIPiyxXES1wcNDdpM0Btn4wxCt QIB9RujK6e936OkZFLvYEedcYoGVRECEYmBhWA9J2y9lkb4N+5Iey2L4FSf/Pl1ycqFq inwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688711621; x=1691303621; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2rZJMXQqBbYtG35iaT5k3WfIhsJUmOKUvW8i0uD8NBI=; b=ipCCryZ7EPhSpUewXXz1Ov5yTi+2LBHog2j4j6fX5wGUOMyRRbfq4AiLwAtZziDgH0 P+NWw48wzu6TgF0fjQrURIkf5HYHm3JFGPKw4xSojwac+pyg6IVXRXO1IT3uWOQdbVTh cDl4eFqF6ibImfu/MToqZUxy7w+23Jd2nMXleojVmV/mT9LH9zD72359vzmMv76kPpk5 4XA/ehslPBOzI29GV7DCXgytBSMSjc9Fob2Z+Sn5fhdHK7bKvKfIScQG32QkqpY5ykE9 K8qgt0geQ6P8oeq1cuSkDQXtoAFlyCymAchrTIuAccjPukjk4bzLYfxGe3kKDlbBOmit 7bHg== X-Gm-Message-State: ABy/qLaeEE7XdEd2GqW3d8An0hqO6bwOGAkm2i21JkuhD9oaeduE0Bud tfVy2khjjCT3vJBb6ujdzL0tHg== X-Received: by 2002:a17:906:d7b1:b0:98e:1b9b:aef7 with SMTP id pk17-20020a170906d7b100b0098e1b9baef7mr2683392ejb.64.1688711621156; Thu, 06 Jul 2023 23:33:41 -0700 (PDT) Received: from krzk-bin.. ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id s24-20020a170906169800b0096f7500502csm1724803ejd.199.2023.07.06.23.33.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 23:33:40 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 3/3] arm64: dts: rockchip: correct wifi interrupt flag in Box Demo Date: Fri, 7 Jul 2023 08:33:35 +0200 Message-Id: <20230707063335.13317-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230707063335.13317-1-krzysztof.kozlowski@linaro.org> References: <20230707063335.13317-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770742931604719384?= X-GMAIL-MSGID: =?utf-8?q?1770742931604719384?= GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE. Correct the interrupt flags, assuming the author of the code wanted same logical behavior behind the name "ACTIVE_xxx", this is: ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH Signed-off-by: Krzysztof Kozlowski --- Changes in v2: 1. Correct subject and commit msg (active low -> high) --- arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts index 322f3e809f15..0c18406e4c59 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts +++ b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts @@ -416,7 +416,7 @@ brcmf: wifi@1 { compatible = "brcm,bcm4329-fmac"; reg = <1>; interrupt-parent = <&gpio2>; - interrupts = ; + interrupts = ; interrupt-names = "host-wake"; pinctrl-names = "default"; pinctrl-0 = <&wifi_host_wake_h>;