From patchwork Thu Jul 6 15:30:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 116780 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp2659617vqx; Thu, 6 Jul 2023 08:56:42 -0700 (PDT) X-Google-Smtp-Source: APBJJlEsuBbEMD+P1VGZgsn5RMG5x08S1LXKIGXYn8bXz9ZL4zHefoJIaoQg9q6cP+cZTFSfqzVh X-Received: by 2002:a05:6a20:9707:b0:126:39ce:476b with SMTP id hr7-20020a056a20970700b0012639ce476bmr2084338pzc.12.1688659002547; Thu, 06 Jul 2023 08:56:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688659002; cv=none; d=google.com; s=arc-20160816; b=Mi50XsmvBeLkV8pf/hKwGJTVswNzH8fLnkon7hpUo0Qc+hxjdVzTug1enIO7ksPkhw 5qfbQxsYWRtlYf+x7QV7zpdT0TPQiHaghajb0reAOx4w5T2j0gCuBfJPcVOOjwtKd2s9 Azh6eJoIpIkSt8nu74XyeM4iJ9WF2n3yoPRFokQkCEaFiJ9Wg9P9ALDlRRfWsTA2UZ+0 i5hoQkiEmNKzijJ8rO7wOwFr3tdvp2/Yh5s891jLsJ6QDJt9I2/XHy1C6Vcf88l9MFBQ n9cq6goCxAuiQDsQTRoF8vYB553R9Lz6uyv/ejkiSojwIF/RWxRY2qqwvAzmdqwrW+RU xVSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=6jMofBA7gA1YiDZVNupz/HwUhbRN81fT8RgUUGt37Ig=; fh=sJJNXphix7V0fWxNnZrLO7/+UcdTSaNQQxl2CAF7ryM=; b=H6yTwxCIJmdyxw4aL/MHE7yRhkThQikyMJpr6H00TaKCt6/db0g3xDv6RA26qUzLUN NfKOVPT1dQ8G0SE/y8Qt4L1hHbr19UgzmU4LbxG/j8/jycca1qDM65kbSySTXBVU/UqD 389QkRL8A3mk17ZNhAwfP6/Tf+W20GIlAp+YqagByKVkRf7NaWOccmWeKFzCIxUN654s Ohy1zNJIZYKjPIL85cUdChha9auuO7nYl5rqY6hkYrZ8/f4I7PEbrqxm3VMgR0sAitfr QmLkCzcuS3nCMIkDSmIXn9uioWz7uleXPdwKHaknPJ3wLtrlvkO7YrUmQSnHMBxjJ/KD P2iA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r12-20020a63440c000000b00546bab11218si1634112pga.439.2023.07.06.08.56.29; Thu, 06 Jul 2023 08:56:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233777AbjGFPan (ORCPT + 99 others); Thu, 6 Jul 2023 11:30:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233748AbjGFPak (ORCPT ); Thu, 6 Jul 2023 11:30:40 -0400 Received: from michel.telenet-ops.be (michel.telenet-ops.be [IPv6:2a02:1800:110:4::f00:18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEA5F1BEB for ; Thu, 6 Jul 2023 08:30:36 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:5979:7b6f:39a:b9cb]) by michel.telenet-ops.be with bizsmtp id HrWZ2A00W45Xpxs06rWZ2S; Thu, 06 Jul 2023 17:30:34 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qHQw9-000g6y-2O; Thu, 06 Jul 2023 17:30:33 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qHQwD-000qrS-DI; Thu, 06 Jul 2023 17:30:33 +0200 From: Geert Uytterhoeven To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Javier Martinez Canillas Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] drm/fbdev-dma: Fix documented default preferred_bpp value Date: Thu, 6 Jul 2023 17:30:31 +0200 Message-Id: <91f093ffe436a9f94d58fb2bfbc1407f1ebe8bb0.1688656591.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770687302566646475?= X-GMAIL-MSGID: =?utf-8?q?1770687302566646475?= As of commit 6c80a93be62d398e ("drm/fb-helper: Initialize fb-helper's preferred BPP in prepare function"), the preferred_bpp parameter of drm_fb_helper_prepare() defaults to 32 instead of drm_mode_config.preferred_depth. Hence this also applies to drm_fbdev_dma_setup(), which just passes its own preferred_bpp parameter. Fixes: b79fe9abd58bab73 ("drm/fbdev-dma: Implement fbdev emulation for GEM DMA helpers") Signed-off-by: Geert Uytterhoeven Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fbdev_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_fbdev_dma.c b/drivers/gpu/drm/drm_fbdev_dma.c index d86773fa8ab00f49..76aa52b38a13ed63 100644 --- a/drivers/gpu/drm/drm_fbdev_dma.c +++ b/drivers/gpu/drm/drm_fbdev_dma.c @@ -217,7 +217,7 @@ static const struct drm_client_funcs drm_fbdev_dma_client_funcs = { * drm_fbdev_dma_setup() - Setup fbdev emulation for GEM DMA helpers * @dev: DRM device * @preferred_bpp: Preferred bits per pixel for the device. - * @dev->mode_config.preferred_depth is used if this is zero. + * 32 is used if this is zero. * * This function sets up fbdev emulation for GEM DMA drivers that support * dumb buffers with a virtual address and that can be mmap'ed.